[Koha-bugs] [Bug 22896] Item to be transferred at checkin clears overridden due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 --- Comment #4 from Brian --- FY18 means Fiscal year 2018 Hi this bug is attached to our development New System Pref, “Don’t forgive lost after(set date), modify checkin routine to check the value of the itemlost_on field. My superiors want this bug pushed, thank you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #17 from Cab Vinton --- We would also be happy to see this bug applied as soon as possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22933] Support for FIDO WebAuthn (passwordless)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22933 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22933] New: Support for FIDO WebAuthn (passwordless)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22933 Bug ID: 22933 Summary: Support for FIDO WebAuthn (passwordless) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: blac...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Target Milestone: --- What do you mean about support for WebAuthn for staff? No Password, just USB token and touch. Nice demo and test: https://webauthn.me/ https://webauthn.io/ Demo code Javascript https://github.com/fido-alliance/webauthn-demo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22932] Serial issues on opac-detail.pl sorts dates alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 Andrew changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22932] New: Serial issues on opac-detail.pl sorts dates alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 Bug ID: 22932 Summary: Serial issues on opac-detail.pl sorts dates alphabetically Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When sorting serial issues in the OPAC by date, those dates are sorted alphabetically rather than as dates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728 --- Comment #14 from Andrew --- Given enough time, I could probably get around to arguing either side of this. But I think I'm leaning more toward putting it in the attribute setup. There's enough specific setup stuff for each attribute there already that I think that's where folks are more likely to expect this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22929] Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294 Joelle Hannert changed: What|Removed |Added CC||jhann...@nmc.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22890] Add a chronological changelog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #5 from Katrin Fischer --- This has an interesting aspect - do we want to provide this for librarians, or for end developers? (new feature vs. renamed method) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22724] Staff without writeoff permissions have access to 'Write off selected' button on Pay Fines tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22724 --- Comment #19 from Liz Rea --- Created attachment 89879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89879=edit Bug 22724: Check permissions in the script before displaying template Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22724] Staff without writeoff permissions have access to 'Write off selected' button on Pay Fines tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22724 Liz Rea changed: What|Removed |Added Attachment #89826|0 |1 is obsolete|| Attachment #89827|0 |1 is obsolete|| --- Comment #18 from Liz Rea --- Created attachment 89878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89878=edit Bug 22724: Allow only users with correct permissions to 'Write off selected' Due to the addition of a 'Write off selected' button in 18.11, users without writeoff permissions could mistakenly view and action the 'Write off selected' option for a patron in Accounting > Make a payment (Fines > Pay fines). The attached patch corrects this error. Test plan: 1) Make sure that a staff user has '(writeoff) Write off fines and fees' permission disabled 2) Bring up a patron with an unpaid fee, go to Accounting -> Make a payment 3) Note that 'Write off selected' button is displayed. 4) Select a fee, click 'Write off selected'. Note that staff member has access to 'Write off an amount toward selected fines' 5) Apply the patch 6) Repeat steps 1-2, and note that the button is no longer displayed 7) Bonus points, as a staff user with writeoff permissions enabled check that all four buttons (Pay amount, Pay selected, Write off all, Write off selected) are displayed Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22724] Staff without writeoff permissions have access to 'Write off selected' button on Pay Fines tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22724 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19618] Automatic/standing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Tomás Cohen Arazi changed: What|Removed |Added Assignee|tomasco...@gmail.com|agustinmoy...@theke.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22921] Relatives issues only shows first one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22921 Katrin Fischer changed: What|Removed |Added Severity|major |normal --- Comment #2 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #1) > It turn out it does not appear on master, it is caused by Bug 15219 Missed the next comment... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold dates on reserve/request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- What is the use case for changing the date the hold was placed? (allowing them to be in the future? And should this not depend on the syspref then?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22921] Relatives issues only shows first one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22921 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22802] When ordering form a staged file, if funds are populated per item order level fund should not be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 --- Comment #12 from Jonathan Druart --- Created attachment 89877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89877=edit Bug 22917: Fix typo in another test file It looks safe to do it here and now. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Jonathan Druart changed: What|Removed |Added Attachment #89857|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 89876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89876=edit Bug 22917: Fix a typo in an output_pref call Due to a type in a call to output_pref (datenonly vs dateonly) we were comparing logactions within a minutes accuracy. Counting the logs for the day would be sufficient for the test ;) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22914] Batch Item Delete column misconfigured when using show/hide tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 --- Comment #15 from Jonathan Druart --- (In reply to Lucas Gass from comment #13) > Thanks Jonathan. I will be more precise with advertisement in the future. :) Why in the future when you can start now? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #9 from Liz Rea --- Created attachment 89874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89874=edit Bug 22907: Remove previous code handling the same thing See: commit a71b96295fb07084e4f87ac1a471e89355f3c5a4 Bug 12627: Fix default values Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #8 from Liz Rea --- Created attachment 89873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89873=edit Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #10 from Liz Rea --- Created attachment 89875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89875=edit Bug 22907: Add missing use statement Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Liz Rea changed: What|Removed |Added Attachment #89763|0 |1 is obsolete|| Attachment #89767|0 |1 is obsolete|| Attachment #89768|0 |1 is obsolete|| Attachment #89865|0 |1 is obsolete|| --- Comment #7 from Liz Rea --- Created attachment 89872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89872=edit Bug 22907: Add tests Do not use copyrightdate as it is weird to have it int Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Liz Rea changed: What|Removed |Added Attachment #89868|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 89870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89870=edit Bug 22905: Fix update of suggestion's status if branchcode filter is 'all' Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Let forget what could have happened earlier in the script and do it the regular way, from $input. Then call ModSuggestion with only what we need. Test plan: Confirm that the steps described before work as expected once this patch is applied Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=22907 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #10 from Liz Rea --- Created attachment 89871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89871=edit Bug 22905: (QA follow-up) remove bad warn Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22914] Batch Item Delete column misconfigured when using show/hide tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22914] Batch Item Delete column misconfigured when using show/hide tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 ByWater Sandboxes changed: What|Removed |Added Attachment #89796|0 |1 is obsolete|| --- Comment #14 from ByWater Sandboxes --- Created attachment 89869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89869=edit Bug 22914: Batch Item Delete column misconfigured when using show/hide tool Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #20 from Liz Rea --- I don't like the idea of combining them. Records are records. Items are items. Yes, I'm a curmudgeon. ^.^ The way I'd like to see it done: - use the existing tool for batch deleting items - give feedback regarding the items that were actually deleted (existing) - Check an item's biblio to see if that item is the last on the biblio - if it is, use the existing pathway for deleting records if all items are to be deleted (existing), and add on deleting the reserves on that biblio in that pathway. - give actionable feedback regarding any items with item level holds that couldn't be deleted because of holds - either links to the affected items that open in a new tab so a librarian can deal to the holds or some other mechanism like a button "Delete this item's holds I know what I'm doing" This could be a good project for an intern somewhere. Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Attachment #89828|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 89868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89868=edit Bug 22905: Fix update of suggestion's status if branchcode filter is 'all' Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home › Acquisitions › Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Let forget what could have happened earlier in the script and do it the regular way, from $input. Then call ModSuggestion with only what we need. Test plan: Confirm that the steps described before work as expected once this patch is applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Cannot upate the status of suggestions if the branchcode filter is set to all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Summary|Edit suggestions - wrong|Cannot upate the status of |branchcode behavior |suggestions if the ||branchcode filter is set to ||all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22912] Accidental multiple clicking of fine "pay" creates multiple entries in accountlines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22912 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|NEW |In Discussion Severity|critical|normal --- Comment #1 from Liz Rea --- Hi Vijay, Which page are you referring to? As near as i can tell, there is a confirmation step between the "Pay" button and a payment actually being made. Normal importance until we can confirm what screen (a url would do) you are seeing this behaviour from. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Liz Rea changed: What|Removed |Added CC||t.patta...@gmail.com --- Comment #30 from Liz Rea --- *** Bug 22902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22902] Double entries of overdue fines in the accountlines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22902 Liz Rea changed: What|Removed |Added Resolution|--- |DUPLICATE CC||wizzy...@gmail.com Status|NEW |RESOLVED --- Comment #2 from Liz Rea --- I believe this is a duplicate report to bug 22877, which has a patch. :) *** This bug has been marked as a duplicate of bug 22877 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 --- Comment #4 from Liz Rea --- Created attachment 89867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89867=edit Bug 22928: Add selenium tests Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 Liz Rea changed: What|Removed |Added Attachment #89851|0 |1 is obsolete|| Attachment #89862|0 |1 is obsolete|| --- Comment #3 from Liz Rea --- Created attachment 89866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89866=edit Bug 22928: (bug 20226 follow-up) Fix display of 'Update child to adult' link Looks like it is caused by bug 20226, however I am pretty sure it works when I wrote the patch. [% IF Categories.scalar.all(category_type => 'A').count > 0 %] is always wrong. It must be, either: [% IF Categories.all(category_type => 'A').size > 0 %] or [% SET adult_categories = Categories.scalar.all(category_type => 'A') %] [% IF adult_categories.count > 0 %] In the first case we are getting an array whereas in the later, a Koha::Patrons which is preferable. Test plan (from 20226): - Remove all your adult categories (categories.category_type='A') - Create a patron with a child category - Try to update to adult category => The entry does no longer appears! (This is a change in the behaviour) - Create one adult category - Update to adult category => There is a JS confirmation message, if you accept the patron will be updated to the adult category - Create (at least) another adult category - Create another child - Update to adult category => No more confirmation message but a popup to select the adult category - Pick one => The patron has been updated to the adult category Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Edit suggestions - wrong branchcode behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard --- My patch is a non-starter, so I restored Aleisha's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Edit suggestions - wrong branchcode behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > I am confused. If I apply the patches from bug 22907, I cannot recreate the > original issue. Scratch that, it's wrong! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Edit suggestions - wrong branchcode behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 --- Comment #6 from Jonathan Druart --- I am confused. If I apply the patches from bug 22907, I cannot recreate the original issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard changed: What|Removed |Added Attachment #61172|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 --- Comment #6 from Jonathan Druart --- Created attachment 89865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89865=edit Bug 22907: Add missing use statement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard changed: What|Removed |Added Status|Failed QA |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard changed: What|Removed |Added Attachment #82990|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 --- Comment #1 from Jonathan Druart --- Created attachment 89864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89864=edit Bug 22930: Make TestBuilder->build_object explodes if parameters are wrong This patch implements bug 15339 for build_object. We want it to warn if the call is wrong. Test plan: Make sure the tests are still returning green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15339] TestBuilder build parameter warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What|Removed |Added Blocks||22930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 [Bug 22930] Make TestBuilder more strict when called with too wrong arguments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Jonathan Druart changed: What|Removed |Added Depends on||15339 Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 [Bug 15339] TestBuilder build parameter warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #125 from Liz Rea --- Hi Agustin, Thanks for updating your patches, I've had a look over them and the behaviour seems better to me. I'm willing to sign this off, but I'd really like for VOKAL to test it with their real-life requirements and scenarios in mind - I'm not with that institution and I can't purport to speak to their functional requirements. I've approached Joy at ByWater to see if she can arrange a testing setup for them with this patchset, hopefully we'll hear something soon about that - I know how frustrating it is to endlessly rebase. Note to QA: I haven't attached signed off patches, pending VOKAL's testing/comments. Let me know if you'd like me to do something differently. The dev itself looks solid, passes the QA scripts and all of your new tests are passing. The functionality seems good so far as I can see, thank you for all of that and nice job! Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 --- Comment #6 from Jonathan Druart --- Created attachment 89863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89863=edit Bug 22847: [18.11] Correctly displayed circ rule values for max_holds Here a version for 18.11, it needs a signoff! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 --- Comment #2 from Jonathan Druart --- Created attachment 89862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89862=edit Bug 22928: Add selenium tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22908] Modsuggestion will generate a notice even if the modification failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #29 from Liz Rea --- Created attachment 89861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89861=edit Bug 22877: (QA follow-up) Clarify intent of tests and remove one. This patch embelishes the existing comments slightly and removes a test which had a FIXME, but was in fact just a duplicate of the test directly above it. I beleive it became a duplicate after the subroutine signature changed at some point recently. I also move the bug 22877 specific test into a subtest. Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #28 from Liz Rea --- Created attachment 89860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89860=edit Bug 22877: (follow-up) Fix test plan count Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Liz Rea changed: What|Removed |Added Attachment #89818|0 |1 is obsolete|| Attachment #89819|0 |1 is obsolete|| Attachment #89820|0 |1 is obsolete|| Attachment #89821|0 |1 is obsolete|| --- Comment #26 from Liz Rea --- Created attachment 89858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89858=edit Bug 22877: Unit test to highlight problem Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 --- Comment #27 from Liz Rea --- Created attachment 89859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89859=edit Bug 22877: Prevent double overdue processing for lost and returned Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize --- Good fixes, added my own version of last patch.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917
Martin Renvoize changed:
What|Removed |Added
Attachment #89798|0 |1
is obsolete||
--- Comment #8 from Martin Renvoize ---
Created attachment 89856
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89856=edit
Bug 22917: Prevent Circulation.t if tests ran too slowly
After bug 21213 we wanted to know why Circulation.t was failing randomly on a
given test.
Since it is pushed, it failed (at least) twice, with the same error:
# Failed test 'AddReturn must have debarred the patron'
# at t/db_dependent/Circulation.t line 3112.
# got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
# 'WasReturned' => 1
# };
# Failed test 'Test at line 1918'
# at t/db_dependent/Circulation.t line 3116.
# got: '0'
# expected: '1'
# Failed test 'Test at line 1918'
# at t/db_dependent/Circulation.t line 3119.
# got: undef
# expected: '2019-05-30'
# Looks like you failed 3 tests of 21.
The test at line 3113 expects the flags 'WasReturned' and 'Debarred' to be set,
but only WasReturned is.
Which means the patron has not been debarred. It is not because the checkout
has
not been detected as overdue.
If you apply only the first patch you will see that the tests are failing with
the exact same failures.
Indeed, if due_date is not passed to test_debarment_on_checkout, it is set to
now (dt_from_string).
However, if the call and the test of the parameters inside the subroutine takes
more than 1 second,
then due_date will be after what we really expect. To reproduce that, we add
1 minute to due_date and we observe the tests failing.
The trick here (and we should have in all our tests) is to mock
DateTime->now to make sure dt_from_string will always return the same
value, it is what we expect from our tests (in 99.9% of the cases at
least).
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Martin Renvoize changed: What|Removed |Added Attachment #89853|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 89857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89857=edit Bug 22917: Fix a typo in an output_pref call Due to a type in a call to output_pref (datenonly vs dateonly) we were comparing logactions within a minutes accuracy. Counting the logs for the day would be sufficient for the test ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Martin Renvoize changed: What|Removed |Added Attachment #89797|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 89855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89855=edit Bug 22917: Recreate the failure Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22931] Add ability to change wording of sendbasket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22931 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Component|OPAC|Notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22931] New: Add ability to change wording of sendbasket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22931 Bug ID: 22931 Summary: Add ability to change wording of sendbasket.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Some libraries would like to have the ability to change the text of the email send by sendbasket.pl. Many libraries change the name 'cart' to something else and for consistency would like to be able to change that wording in the email that is sent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #4 from Alex Arnaud --- Created attachment 89854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89854=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org;, - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 Martin Renvoize changed: What|Removed |Added Attachment #89799|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 --- Comment #6 from Martin Renvoize --- I've replaced the final patch with an alternative that fixes the typo in the test rather than altering the behaviour of C4::Log::logaction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22917] Circulation.t fails if tests are ran slowly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 --- Comment #5 from Martin Renvoize --- Created attachment 89853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89853=edit Bug 22917: Fix a typo in an output_pref call Due to a type in a call to output_pref (datenonly vs dateonly) we were comparing logactions within a minutes accuracy. Counting the logs for the day would be sufficient for the test ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22930] New: Make TestBuilder more strict when called with too wrong arguments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22930
Bug ID: 22930
Summary: Make TestBuilder more strict when called with too
wrong arguments
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Target Milestone: ---
It happens to me too often to call TestBuilder->build[_object] without 'value':
$builder->build_object({ class => 'Koha::Patrons', { categorycode =>
$category->categorycode });
Then I am loosing minutes to understand what my tests do not fail (yes, fail).
We could make it display a warning or croak or whatever.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22929] New: Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22929 Bug ID: 22929 Summary: Enabling the GDPR_Policy will affect libraries using the SCO module in Koha Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- With the introduction of the sys pref GDPR Policy in 18.11, having this enabled seems to affect the SCO module in Koha- if the library is also using AutoSelfCheckAllowed. If they library as the system preference AutoSelfCheckAllowed set to ALLOW, the consent of GDPR seems to get tangled up in this process. The self-check URL will get directed to /cgi-bin/koha/opac-patron-consent.pl and seem to be stuck. The consent form never appears, and this login will not be successful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 Jonathan Druart changed: What|Removed |Added Keywords||rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 axel Amghar changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 axel Amghar changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #1 from axel Amghar --- Created attachment 89852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89852=edit Bug 22924: Elasticsearch, show more than 10 facets To test: Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 15, - make the search "a" in the catalog, - in Refine your search click on show more for authors, - make sure there is no more than 10 facets dislpaying With the patch: - apply the patch, - make the same, - make sure there is exactly 15 facets for authors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22905] Edit suggestions - wrong branchcode behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||wizzy...@gmail.com --- Comment #5 from Liz Rea --- Interesting, this works if you edit the individual suggestion (use the edit button - I did it beccause I was curious) and accept it there, but not if you check it and use the "mark selected as" from the bottom of the suggestions page. The behaviour is exactly the same with or without this patch? Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 --- Comment #1 from Jonathan Druart --- Created attachment 89851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89851=edit Bug 22928: (bug 20226 follow-up) Fix display of 'Update child to adult' link Looks like it is caused by bug 20226, however I am pretty sure it works when I wrote the patch. [% IF Categories.scalar.all(category_type => 'A').count > 0 %] is always wrong. It must be, either: [% IF Categories.all(category_type => 'A').size > 0 %] or [% SET adult_categories = Categories.scalar.all(category_type => 'A') %] [% IF adult_categories.count > 0 %] In the first case we are getting an array whereas in the later, a Koha::Patrons which is preferable. Test plan (from 20226): - Remove all your adult categories (categories.category_type='A') - Create a patron with a child category - Try to update to adult category => The entry does no longer appears! (This is a change in the behaviour) - Create one adult category - Update to adult category => There is a JS confirmation message, if you accept the patron will be updated to the adult category - Create (at least) another adult category - Create another child - Update to adult category => No more confirmation message but a popup to select the adult category - Pick one => The patron has been updated to the adult category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 axel Amghar changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22928] New: "Update child to adult patron" link no longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 Bug ID: 22928 Summary: "Update child to adult patron" link no longer displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Patrons Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 20226 Target Milestone: --- Looks like it is caused by bug 20226, however I am pretty sure it works when I wrote the patch. [% IF Categories.scalar.all(category_type => 'A').count > 0 %] is always wrong Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 Jonathan Druart changed: What|Removed |Added Blocks||22928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22928 [Bug 22928] "Update child to adult patron" link no longer displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 Bug 22888 depends on bug 22811, which changed state. Bug 22811 Summary: Add button to clear DataTables filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 --- Comment #7 from Jonathan Druart --- *** Bug 21072 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21072] Should not show 'Update patron to adult' if no adult patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21072 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 20226 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Version(s)||19.05.00 released in|| Status|Pushed to Master|RESOLVED --- Comment #6 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #34 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22906] Minor corrections to plugins home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 Bug 22906 depends on bug 22053, which changed state. Bug 22053 Summary: Ability to disable some plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 axel Amghar changed: What|Removed |Added Attachment #89829|0 |1 is obsolete|| --- Comment #5 from axel Amghar --- Created attachment 89850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89850=edit Bug 22903: Elasticsearch, dynamic display when you refine your search To test: With Elasticsearch-> Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 10, - search in the catalog "a" and then in Refine your search click on show more (just to see how it works), - then search with special characters like "é", ç" ... and make the same test, the research should be wrong when you click on show more and the page is realoaded. Then apply the patch: - and make the same with a classic reasearch, then with special characters, - verify that when you click on show more the page isn't realoded and the reasearch is correct. - same with show less - and finnaly, add some facets and test show more/less With Zerbra -> - put your SysPref SearchEngine with Zebra as value, - and make the same thing as elasticsearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #115 from Agustín Moyano --- Created attachment 89840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89840=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #118 from Agustín Moyano --- Created attachment 89843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89843=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #117 from Agustín Moyano --- Created attachment 89842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89842=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
