[Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 --- Comment #3 from Katrin Fischer --- (In reply to Pablo AB from comment #2) > Shouldn't always newer bugs marked duplicated of older ones, instead of the > other way around? At least unless the newer have much more info. > > Marking older bugs duplicate of newer ones give the wrong impression that > this request is recent. You are right Pablo that this is the general rule. Tbh, I was not sure if this was active and picked the other for the recent activity on it. It sure is debatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #16 from Katrin Fischer --- Blocked by dependency bug 20388 awaiting sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 --- Comment #2 from Pablo AB --- Shouldn't always newer bugs marked duplicated of older ones, instead of the other way around? At least unless the newer have much more info. Marking older bugs duplicate of newer ones give the wrong impression that this request is recent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #60 from Katrin Fischer --- > ..., because I doubt copyright date has meaning to users) I meant: people! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Katrin Fischer changed:
What|Removed |Added
CC||oleon...@myacpl.org
--- Comment #59 from Katrin Fischer ---
First of all: I like this!
Some findings while testing:
1) Use the TT Asset plugin instead:
[% IF ( Koha.Preference('OPACSuggestionAutoFill') ) %]
[% END %]
2) Style question :) (non-blocker)
[% IF NOT Koha.Preference( 'OPACSuggestionAutoFill' ) %]
Why not UNLESS? Just hadn't seen this before!
3) The jQuery plugin
Wondering about the Javascript file included here. I think right now it's the
biggest issue for me.
It's labelled "jquery autofill plugin", but it appears to be unrelated to the
existing one or has been changed so much I am not seeing the relationship
anymore:
https://plugins.jquery.com/autofill/
Maybe this should be renamed as it's now a plugin dealing with the Google API
specifically and no longer a generic one and the note be removed to avoid
confusion?
I also think that Jonathan's comment 18 is still valid. If we only need it on
one page, it would make sense to only include it there.
I think we also really need to figure out the license situation here. My guess
right now is that Martin is the author.
We don't usually add the authors/licenses for js files written for Koha that
live in bootstrap/js, so maybe this is mostly about removing the confusing
comment/making sure this was written for Koha and is not a general plugin.
Adding Owen.
4) Pref description should mention this is about the suggestion form :)
5) It would be nice if the error message didn't appear as another button (and
if the Google Search button was more clearly formatted as a button)
(non-blocker)(In reply to Chris Cormack from comment #7)
6) Copyright date / Publication year
> > And lastly, not a problem but a question: In my test copyright date is never
> > populated. Is that a bug or a problem with Google Books' data?
>
> Yes, Google books API only hands back publication date, not copyright date.
I think it might make sense to use this in the field. While technically not the
same, we use both in Koha often for the same thing. This is one of the forms
using copyright date, but in other places it will be publication year. And it
all goes into the same fields when creating a record from it. The year would be
helpful I think. (I'd even go as far to say we should relabel the form, because
I doubt copyright date has meaning to users)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- This patch does a bit more than I thought - apart from changing the hold date, it also allows to change the expiration date. I think while the first should be controlled by the AllowHoldDateInFuture, the expiration date should not as it's already available to be set in the table now. Note: the expiration date has a double use, it's used to say: - Patron: I don't need this after... and also: - Library: Hold needs to picked up until ... Can you please change? I am not sure about the consequences of this change. I think the date pickers are a bit too wide in the table. Adding Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Summary|Allow to modify hold dates |Allow to modify hold and |on reserve/request.pl |hold expiration date in ||staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22954] Minor markup error in OPAC messaging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Katrin Fischer changed: What|Removed |Added Attachment #90261|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 90268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90268=edit Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What|Removed |Added Attachment #90259|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 90267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90267=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- That's a lot of sign-offs! Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Maybe something for another day/bug: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc OK filters FAIL forbidden patterns forbidden paattern: Contains old bootstrap style for buttons (see bug 16239) (line 93) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What|Removed |Added Attachment #90257|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 90266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90266=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22948] Markup error in OPAC bibliographic detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3567] Display Alternate Graphic Representation (MARC21 880) in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3567 Katrin Fischer changed: What|Removed |Added Blocks||23032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23032] New: Add 264 to Alternate Graphic Representation (MARC21 880)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Bug ID: 23032 Summary: Add 264 to Alternate Graphic Representation (MARC21 880) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 3567 Target Milestone: --- The 880 field containing information from 264 is not displayed in the OPAC and intranet detail pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3567 [Bug 3567] Display Alternate Graphic Representation (MARC21 880) in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- Hi Jessie, I just tested this on master and can't replicate the problem. Can you confirm this is still a problem in 18.05 or later? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Course Reserve Item |Holding branch disappears |Location Disappears after |after saving to course and |saving to course|isn't restored when ||removing item from course -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22961] Allow special characters in password complexity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22961 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Amit, can you explain this bug a bit more please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #9 from Katrin Fischer --- Created attachment 90265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90265=edit Bug 22960: (follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 --- Comment #1 from Katrin Fischer --- Created attachment 90264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90264=edit Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22958] The Help link on SMS providers page should link to the correct chapter in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What|Removed |Added Summary|Clicking on the HELP button |The Help link on SMS |when in SMS providers- does |providers page should link |not bring user to that |to the correct chapter in |portion in the manual |the manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22958] Clicking on the HELP button when in SMS providers- does not bring user to that portion in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22958] Clicking on the HELP button when in SMS providers- does not bring user to that portion in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22958 Katrin Fischer changed: What|Removed |Added Version|18.11 |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 --- Comment #3 from Katrin Fischer --- Created attachment 90263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90263=edit Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #4 from luli...@ibwya.net --- $ sudo koha-remove klib Removing Koha instance klib ERROR 1133 (28000) at line 1: Can't find any matching row in the user table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #3 from luli...@ibwya.net --- Koha18.11.05.000 on Debian 9.9 and MariaDB10.1.38 has the same issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #24 from Katrin Fischer --- (In reply to Liz Rea from comment #23) > I think I agree, pub date searches should use the 008, but non-marc > libraries coming to Koha might not know how to use the 008 and that... kind > of frightens me. But they might also not add useful data to 260/264... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #33 from Katrin Fischer --- I've moved the discussion about the buttons onto a new bug 23031. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 luli...@ibwya.net changed: What|Removed |Added CC||luli...@ibwya.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Katrin Fischer changed: What|Removed |Added Depends on||21364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 [Bug 21364] Allow closing basket from vendor search/view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What|Removed |Added Blocks||23031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 [Bug 23031] Improve UX of buttons on order search page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] New: Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Bug ID: 23031 Summary: Improve UX of buttons on order search page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When the change for bug 21364 was made, there as some discussion about what buttons should be accessible immediately and what should be hidden in the menu. Owen's last suggestion was: The "View" part of the split button is an unnecessary duplication of the linked basket name earlier in the table. I think the actions column should have two possible buttons: "Add to basket" and "Close basket." Maybe we could implement this? As I understand it, we would remove the view part which would leave us with 2 (or 3: uncertain prices instead of close basket) buttons that show outside of a menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21329 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Katrin Fischer changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 14049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bug 22800 depends on bug 22550, which changed state. Bug 22550 Summary: OPAC suggestion form doesn't require mandatory fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Kelly, I think your request is a bit different to Lisette's. I see Lisette's feature more like the additional fields for subscriptions and baskets, while yours sounds more like BorrowerUnwantedFields. It might be good to split this into 2 bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
--- Comment #80 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #79)
> (In reply to Jonathan Druart from comment #78)
> > 1. Only one occurrence of passwordlengthhint
> > koha-tmpl/intranet-tmpl/prog/css/installer.css:#passwordlengthhint
> >
> > 2. Do we really need the warning when adding/editing a patron?
> > BTW, $warning is not needed, memberentry.pl
> > 177 my $warning = 1;
> > 178 $template->param("passwordwarning"=>$warning);
> >
> > 3. Just a though, next time we add a "step" we will need to rethink the
> > template. The shift is terrible. And hard to see the real changes.
> >
> > Not passing QA for 2, waiting for another QA point of view.
>
> I would suggest to squash some patches, getting rid of merge marker stuff
> and warnings etc.
> In general, I would not favor putting more prefs inside onboarding. Keep it
> simple. This change can be made without changing onboarding.
I tend to agree with Marcel and Jonathan here.
I am not sure if we should add this to the installer as it adds a lot more to
read for little gain (slows down the process). I think instead, why not just
set it to at least 8 by default?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #155 from Katrin Fischer --- Hi David, 1) Documentation https://gitlab.com/gnucifer/koha-manual/commit/593c5da008dbc4b074cac9dee167cce9a6dfc250#c5e2c75dc923f21c5b95185b2f350df00fec661f Thanks a lot, this documentation is SO helpful. We really couldn't have continued without as the feature is quite complex. 2) GUI - Terminology and translatability One thing that bothers me is that the GUI is a big 'rough'. I'd much prefer if it was using better terms/descriptions like in the help instead of 'codes'. bachmod = Bach record modification intranet = Cataloging module (unles it inlcudes batchmod?) batchimport = Staged MARC import etc. batchmarcimport = Cronjob batchmarcimport.pl (I hope I got them right) Experience tells that those are likely to get translated strangely or might not be translatable at all. 3) Over-granularity? Another thing that bothers me is a bit is the granularity. Being able to limit to specific patrons seems a little overkill? Especially since the interface expects borrowernumbers to be entered? (borrower = patron) Is there a use case for this? 4) marc_merge_rules_modules I am still quite suspicious of this one. We should not add descriptions to the database ever (translatability) - and this currently won't work for new installations. Can you please consider moving the modules to the templates instead and checking if this table is really needed as is? Or explain to me? At the moment the patch set doesn't apply. - I am really interested in the feature, just feel right now that it's an old development that still needs a bit of love. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14669] Search orders by managing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14669] Search orders by managing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer changed: What|Removed |Added Attachment #89619|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 90262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90262=edit Bug 14669: Add search option for managing library to orders search Currently the order search can't be limited by managing library. The patch adds the search option to the order history search form and a column for the managing library to the search results table. To test: - Create some baskets with orders - Set managing library for some, but also have some without - Apply patch - prove t/db_dependent/Acquisition.t - Go to Aquisition > Orders search tab on top > Advanced search link - Search for orders without limiting Orders with and without managing library set should show up - Limit search to a specific managing library - Verify results match expectations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14669] Search orders by managing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 --- Comment #6 from Katrin Fischer --- Hm, this is a little strange - patch applies cleanly for me. Just uploading it again to make sure! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
