[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Martin Renvoize changed: What|Removed |Added Attachment #90573|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 90878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90878=edit Bug 23103: Cannot checkin items lost by deleted patrons with fines attached Test Plan: 1) Checkout an item to a patron 2) Ensure the item has a replacement cost (or itemtype has default) 3) Ensure patrons are charged when items lost 4) Mark the item lost 5) Confirm patron has a fine 6) Write off the fine 7) Delete the patron 8) Check in the item 9) Note the internal server error 10) Apply this patch 11) Repeat steps 1-8 12) Note there is no internal server error! 13) prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #10 from Martin Renvoize --- (In reply to Jonathan Druart from comment #6) > Should we really ignore this case? It sounds like the library owes money to > somebody. > I have no idea how we could handle it properly however... I think this isn't a problem actually.. the use case is that patron lost the book and then left the library.. then at a later date someone came across the book, spotted the library tag and so was nice enough to return it to the library. The original patron has left at this point, there's no way for us to refund the payment to them and I don't think there's a requirement to track them down to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What|Removed |Added Version(s)|19.05.00, 18.11.06 |19.05.00, 18.11.06, released in||18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #1 from Andrew Isherwood --- Just to clarify, in the above workflows, at the stage: - User can then either choose a result and be taken to it, or choose none and continue with the request as normal If no sources return any results, then the user would continue with the request as normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Jonathan Field changed: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #26 from Martin Renvoize --- Back to NSO with fresh patch attached :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Attachment #90850|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 90877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90877=edit Bug 22741: Make updated_on timezone aware in Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What|Removed |Added CC||mag...@libriotech.no, ||tomasco...@gmail.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23173] New: ILL should be able to search third party sources prior to request creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Bug ID: 23173 Summary: ILL should be able to search third party sources prior to request creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com Target Milestone: --- Currently, there is no integrated way of knowing if an item being requested is already available. If a user creating a request wants to know if the item they are requesting is already available, it is necessary to search the, possibly, multiple sources the library has available (catalogue, discovery interface, open access provider etc.) first. The problem is further compounded if the institution has the unmediated ILL workflow enabled where a request can be placed with no oversight, even though the institution may already have access to it. I propose a mechanism by which, during request creation, one or more "sources" are searched with the provided metadata to try and determine if the item being requested is already available and, if so, links to that item are provided. This behaviour will be optional, via a syspref. "Sources" will be provided as Koha plugins and will provide the ability to accept metadata conforming to the established ILL schema, search the source with which they're concerned, and return results in a prescribed format. This will be performed via an API common to all "source" plugins. All plugins performing this task will be in a common plugin category and therefore enumerable. The workflow for two backends: Freeform: - User fills in Freeform form, clicks submit button - User is taken to an "Availability" page - ILL enumerates source plugins that can service this type of request (mostly determined by material type) and makes search requests to each using provided metadata - Displays results from each source, with links to matching items - User can then either choose a result and be taken to it, or choose none and continue with the request as normal BLDSS: - Identical to above except the user will choose a BLDSS result rather than filling in the Freeform form As part of this work, a source plugin, which will serve as a reference, will be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103
--- Comment #9 from Marcel de Rooy ---
Strange. Circulation.t passes and fails with me:
not ok 19 - AddReturn must have debarred the patron
# Failed test 'AddReturn must have debarred the patron'
# at t/db_dependent/Circulation.t line 3194.
# got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
# 'WasReturned' => 1
# };
not ok 20 - Test at line 1918
# Failed test 'Test at line 1918'
# at t/db_dependent/Circulation.t line 3198.
# got: '0'
# expected: '1'
not ok 21 - Test at line 1918
# Failed test 'Test at line 1918'
# at t/db_dependent/Circulation.t line 3201.
# got: undef
# expected: '2019-07-05'
# Looks like you failed 3 tests of 21.
t/db_dependent/Circulation.t .. 130/131
# Failed test 'Item needs rentalcharge confirmation to be issued'
# at t/db_dependent/Circulation.t line 3358.
# Structures begin differing at:
# $got->{RENTALCHARGE} = Does not exist
# $expected->{RENTALCHARGE} = '1'
# Failed test 'Item needs rentalcharge confirmation to be issued,
increment'
# at t/db_dependent/Circulation.t line 3362.
# Structures begin differing at:
# $got->{RENTALCHARGE} = Does not exist
# $expected->{RENTALCHARGE} = '3'
# Looks like you failed 2 tests of 2.
t/db_dependent/Circulation.t .. 131/131
# Failed test 'CanBookBeIssued & RentalFeesCheckoutConfirmation'
# at t/db_dependent/Circulation.t line 3364.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Martin: * Commit title does not contain 'follow-up' correctly spelt - 093cc6da89 * Commit title does not contain '(QA follow-up)' correctly spelt - 093cc6da89 ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added Attachment #90710|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 90876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90876=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #13 from Marcel de Rooy --- (In reply to M. Tompsett from comment #2) > Your insertion of comments while clarifying, would have been better in a > separate commit, so it would be easier to check. Agree completely. Without the two patches of Mark, this patch would probably be sitting in the queue for much longer! @RM: Patch 2 and 3 do not need to be pushed (although they can), but prove that patch 1 can be pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90794|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 90875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90875=edit Bug 23159: (follow-up) re-add comments" This reverts the previous followup, so that all patches can be pushed without only pushing the first one. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90792|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 90873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90873=edit Bug 23159: Reindent addbiblio.tt This patch corrects whitespace in the basic MARC editor template, addbiblio.tt: Tabs converted to spaces, indentation corrected. Some comments have been added in the markup to clarify the page structure. To test, apply the patch and open the basic MARC editor. Confirm that everything works correctly, including: - Showing/hiding subfields - Re-ordering subfields - Removing tags and subfields - Cloning tags and subfields - Plugin links Use the "-w" flag when using diff to examine the patch. The only changes should be places where single lines were broken up and where comments were added. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23159] Reindent addbiblio.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90793|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 90874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90874=edit Bug 23159: (follow-up) remove added comments Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #23 from Marcel de Rooy --- @RM: Passing QA with a follow-up. Note that the current query also fails on strict SQL mode. So not blocking for that. And yes, it could be moved to a module on a new report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #22 from Marcel de Rooy --- Created attachment 90872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872=edit Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If a rule has not been defined for an itemtype or you submit a biblio level hold, you cannot filter on holdallowed<>0. Test plan: Test with a biblio level hold. Have two items; one item should be blocked with a policy. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Attachment #90639|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 90871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90871=edit Bug 13640: Do not display unreserveable items on the Holds to pull screen We should only display the items that meet the hold policies Test plan: It would be good to have a huge list of holds displayed on the "Holds to pull" and confirm that the display is now correct. One of the possible test plan has been let in a comment on the bug report: Bib Record A has 2 items: Item Record X (can be placed on hold) Item Record Y (cannot be placed on hold) If you place a bib-level hold on Bib Record A, both Item Record X and Item Record Y show up as available items in the Holds To Pull List. With this patch applied you must not see Y Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #14) > Signing off as in a testing it appears to work as expected.. > > I'd love to see this query moved into a module and unit tested really, but > this fix works for now in my opinion.. good luck QAers. It does not work, but I agree about the module thing ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #19 from Marcel de Rooy --- The where condition is wrong. It should also incorporate the case that default_branch_item_rules is NULL (for istance, no corresponding record found for a biblio level hold). Will add a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #18 from Marcel de Rooy --- Fails on strict sql mode: DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP BY [for Statement [ ... etc ] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #17 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Koha/Schema/Result/OldReserve.pm | 8 Koha/Schema/Result/Reserve.pm | 8 .../atomicupdate/bug_23133_item_level_holds.perl | 19 +++ installer/data/mysql/kohastructure.sql| 4 ++-- I would not recommend doing this in one patch. And thought that we even had a rule for that? But can't find it. DBIx schema files should be separate and marked as do_not_push, if the RM wants to generate them himself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added Attachment #90822|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 90870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90870=edit Bug 23090: Add some special characters TEST PLAN - $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP@ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 (Clean up and databases made) Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
