[Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- prove -v t/integration/auth/ t/integration/auth/cas.t ... 1..2 # Subtest: intranet 1..10 [Tue Jul 2 05:13:43 2019] [debug] GET "/cgi-bin/koha/mainpage.pl" [Tue Jul 2 05:13:43 2019] [debug] Routing to a callback A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/integration/auth/cas.t Line: 74 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # No tests run! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests t/integration/auth/password.t .. 1..2 # Subtest: intranet 1..10 [Tue Jul 2 05:13:46 2019] [debug] GET "/cgi-bin/koha/mainpage.pl" [Tue Jul 2 05:13:46 2019] [debug] Routing to a callback A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/integration/auth/password.t Line: 58 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # No tests run! Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report --- t/integration/auth/cas.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. t/integration/auth/password.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=2, Tests=0, 5 wallclock secs ( 0.02 usr 0.00 sys + 4.16 cusr 0.59 csys = 4.77 CPU) Result: FAIL -- confirmed the same problem in comment #2, marking Failed QA. Though, I don't know if it is this patch, or the one it depends on, that is the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What|Removed |Added Attachment #90996|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 91170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91170=edit Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref Test plan: 1/ set uppercasesurname to 'Do' 2/ register a new patron using the REST API with lowercase surname 3/ verify the surname is not saved in uppercase 4/ apply patch 5/ repeat 2 6/ verify the surname now is saved to uppercase Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 --- Comment #6 from M. Tompsett --- Created attachment 91171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91171=edit Bug 23199: Added tests for Koha::Patron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 --- Comment #7 from M. Tompsett --- Created attachment 91172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91172=edit Bug 23199: (follow-up) Fix tab/space issues Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Attachment #90983|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Comment on attachment 90983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90983 Bug 23199 : move uppercasesurname from memberentry.pl to Koha::Patron I believe the second patch is a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #4 from Tomás Cohen Arazi --- (In reply to M. Tompsett from comment #3) > Comment on attachment 91155 [details] [review] > Bug 23246: (follow-up) Hardcoding tab position is not enough > > Review of attachment 91155 [details] [review]: > - > > *sniff sniff* Love the fixing of the hard coding. :) Glad to hear -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #3 from M. Tompsett --- Comment on attachment 91155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155 Bug 23246: (follow-up) Hardcoding tab position is not enough Review of attachment 91155: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23246=91155) - *sniff sniff* Love the fixing of the hard coding. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23249] New: Print hold slips without confirmation for multiple locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 Bug ID: 23249 Summary: Print hold slips without confirmation for multiple locations Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jdem...@roseville.ca.us QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 19383 Our library just upgraded to 18.11.06 and we tested bug 19383 which allows printing hold slips without confirmation. Everything worked as expected but we noticed this only works if you have one library location. This does not work for multiple library locations and looks like it overwrites the transfer and prints the hold slip making it confusing for staff. After the slip prints the screen displays both the hold box and then the transfer box below it. Here is a test plan of how to recreate this issue: 1. Place an item on hold that is at Library A and select Library B as the pick up location. 2. Check in item at Library A to trigger the transfer. 3. A hold slip still automatically prints and states its on hold at Library B. 4. Once you close the pop up box, you can see two alerts, one to reprint the hold slip and then the actual transfer prompt is below. Thanks, Jen DeMuth Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 [Bug 19383] Print hold slips without confirmation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Print hold slips without confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 jdem...@roseville.ca.us changed: What|Removed |Added Blocks||23249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 [Bug 23249] Print hold slips without confirmation for multiple locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What|Removed |Added Attachment #91101|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 91169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91169=edit Bug 23198: Wrong icons/paths in 18.11 for self check modules This patch amends the CSS in self checkout and self check-in modules so that paths to icon images are correct. To test, apply the patch and make sure the WebBasedSelfCheck and SelfCheckInModule preferences are enabled. In self-checkout and self-check-in, confirm that the following icons appear correctly: - "Help" (?) icon in the upper right. - "Finish" (stop sign) icon -- Shown to logged-in self checkout users from the start. Shown to self-check-in users after they check in an item. - "Cancel" (X) icon -- Shown for instance when you try to check out an item which is already checked out to you and can be renewed. - Also in this dialog: "Return" (Book with arrow) and "Renew" (refresh icon). Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Hayley Mapley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from Hayley Mapley --- Ready to be signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #53 from Josef Moravec --- Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23198] [18.11] Wrong icons/paths in 18.11 for self check modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Wrong icons/paths in 18.11 |[18.11] Wrong icons/paths |for self check modules |in 18.11 for self check ||modules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What|Removed |Added Attachment #88330|0 |1 is obsolete|| --- Comment #51 from Josef Moravec --- Created attachment 91167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91167=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What|Removed |Added Attachment #88329|0 |1 is obsolete|| --- Comment #50 from Josef Moravec --- Created attachment 91166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91166=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting returned checkouts Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What|Removed |Added Attachment #88331|0 |1 is obsolete|| --- Comment #52 from Josef Moravec --- Created attachment 91168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91168=edit Bug 17005: Add plugin parameters to /checkouts endpoint Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22999] Switch two-column templates to Bootstrap grid: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22999 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer --- I am sorry, Owen, but this one no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22999: Switch two-column templates to Bootstrap grid: Circulation Applying: Bug 22999: (follow-up) Indentation updates error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22999: (follow-up) Indentation updates The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22999-follow-up-Indentation-updates-hr86eW.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 Katrin Fischer changed: What|Removed |Added Attachment #91052|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 91165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91165=edit Bug 22897: Switch two-column templates to Bootstrap grid: ILL requests This patch modifies the ILL requests template to use the Bootstrap grid instead of YUI. To test, apply the patch and look at the ILL requests template. Confirm that it looks correct at various browser widths. Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22897] Switch two-column templates to Bootstrap grid: ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22897 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer changed: What|Removed |Added Attachment #91123|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 91164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91164=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Confirm that specifying a due date and selecting "remember" shows a new message with the selected date. - Confirm that unchecking "remember" hides the message. - Confirm that date settings are remembered and the correct message displayed (or not) during check-in. - Test with CircSidebar enabled and disabled. Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #44 from Katrin Fischer --- This works well for me, just a spelling question: Remember due date for next check in Should it be check-in in this case? (substantive)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tomás Cohen Arazi changed: What|Removed |Added Attachment #91129|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 91163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91163=edit Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name At some point of history, the flag to indicate if a plugin was enabled/disabled was called "enabled", now it's called "is_enabled" To test: 1) get a fresh master copy 2) Enable plugins 3) Install any plugin CHECK => plugin appears as disabled => If you try to enable it, it just appears as disabled just the same 4) Apply this patch 5) Reload page SUCCESS => plugin appears as enabled => enable / disable action works again 6) Sign off Signed-off-by: Frédéric Demians Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #26 from Agustín Moyano --- Created attachment 91160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91160=edit Bug 20691: Add ability to turn feature on and off This patch adds two preferences 1. AllowPatronToSetFinesVisibilityForGuarantor: Allow/Don't allow patrons to choose their own privacy settings for showing the patron's fines to the patron's guarantor 2. AllowStaffToSetFinesVisibilityForGuarantor: Allow/Don't allow staff to set the ability for a patron's fines to be viewed by linked patrons in the OPAC Also adds a tinyint, non nullable, default to 0 column in borrower and deletedborrower named privacy_guarantor_fines. 1. privacy_guarantor_fines = 0 => don't allow guarantor to see guarantee's fines 2. privacy_guarantor_fines = 1 => allow guarantor to see guarantee's fines To test: 1) git reset --hard master 2) apply patches (including dependencies) 3) perl installer/data/mysql/updatedatabase.pl 4) dbic 5) restart_all 6) in intranet search for AllowPatronToSetFinesVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor preferences SUCCESS => both preferences should be present 7) search for a patron with guarantor SUCCESS => in details tab, in "Library use" section you should see a row labeled "Show fines to guarantor" 8) edit CHECK => in Guarantor information there is no "Show fines to guarantor" select 9) set AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 10) return to patron with guarantor and edit SUCCESS => in Guarantor information section there is a "Show fines to guarantor" select 11) change "Show fines to guarantor" select to "Yes" and save SUCCESS => Value is saved 12) go to details tab SUCCESS => in "Library use" section you see a row labeled "Show fines to guarantor" with value "Yes" 13) set OPACPrivacy preference to "Allow" 14) open 2 opacs, one with a patron that has a guarantor and another that hasn't and go to "your privacy" tab. CHECK => in both opacs you should not see a "Allow your guarantor to view your current fines?" select 15) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 16) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select => in Patron without guarantor you don't see a "Allow your guarantor to view your current fines?" select 17) in Patron with guarantor change value of select and save SUCCESS => Value is saved 18) in intranet set OPACPrivacy preference to "Don't allow" and AllowPatronToSetFinesVisibilityForGuarantor to "Don't allow" 19) got to "your personal details" in both opacs CHECK => in both opacs you should not see no Privacy section with a "Allow your guarantor to view your current fines?" select 20) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 21) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select in a Privacy section => in Patron without guarantor there is no Privacy section 22) in Patron with guarantor change value of select and update SUCCESS => Value is saved 23) Sign off Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #27 from Agustín Moyano --- Created attachment 91161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91161=edit Bug 20691: Implement fines view This patch implements the logic to show guarantee's fines with guarantor user. To test: 1) Apply (if not already done) steps 1 to 5 of previous patch 2) Apply this patch 3) Set OPACFinesTab and AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 4) Find a guarantee and in accounting create a manual invoice 5) Enter OPAC with guarantor user CHECK => In summary there is no "Relatives fines" tab 6) On intranet edit guarantee and set "Show fines to guarantors" to "Yes" and save 7) Reload guarantor's OPAC SUCCESS => You see a "Relatives fines" tab with guarantee's fines information 8) Sign off Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #28 from Agustín Moyano --- Created attachment 91162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91162=edit Bug 20691: (follow-up) Fix qa fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Attachment #90093|0 |1 is obsolete|| Attachment #90094|0 |1 is obsolete|| Attachment #91025|0 |1 is obsolete|| Attachment #91026|0 |1 is obsolete|| --- Comment #25 from Agustín Moyano --- Created attachment 91159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91159=edit Bug 20691: Database update Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 91158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Summary|Simplify visibility logic |Simplify visibility logic |in opac-detail.pl and |in opac-MARCdetail.pl |opac-MARCdetail.pl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Print hold slips without confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #14 from Katrin Fischer --- (In reply to jdem...@roseville.ca.us from comment #13) > We just tested the automatic printing and it only seems to work if you have > one library location. It works for everything else but at the end we tried > switching the hold location to one of our other branches and it still auto > prints the hold even. Here is my test example: > > 1. Item found on Library A shelf for pick up at Library B. > 2. Check in item at Library A to trigger the transfer. > 3. Hold slip prints and says its on hold at Library B. > > So it looks like it overwrites the transfer, however a transfer box does > come up under the hold box. > > Thanks, > > Jen Hi Jen, could you file this as a new bug maybe? This one is RESOLVED FIXED and any work needs to be done on a new bug as a bug fix now. You can use the "depends" field to link to this bug. Let me know if I can help! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi changed: What|Removed |Added Attachment #91156|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 91157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91157=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber This patch makes opac-ISBDdetail.pl redirect to a 404 page (as it should) in the event of a bad biblionumber passed. To test: - Open your browser on a known record detail page (OPAC) - Switch to the ISBD view => SUCCESS: It shows - Alter the biblionumber on the URL into an obviously non-existent biblionumber (e.g. very high value) => FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-=> FAIL: Internal errors are shown - Apply this patch - Reload the bad biblionumber ISBD view => SUCCESS: Browser is redirected to the 404 page as it should - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|oleon...@myacpl.org |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 91156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91156=edit Bug 23248: Avoid opac-ISBDdetail.pl breaking on invalid biblionumber Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23248] New: opac-ISBDdetail.pl dies on invalid biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23248 Bug ID: 23248 Summary: opac-ISBDdetail.pl dies on invalid biblionumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org To reproduce: - Open your OPAC on a biblio detail page - Pick the ISBD page - Alter the biblionumber query param to an obviously non-existent one => FAIL: It explodes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall --- Unit tests are failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-detail.pl and opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Summary|Simplify visibility logic |Simplify visibility logic |in opac-*detail.pl |in opac-detail.pl and |[OMNIBUS] |opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] New: Simplify visibility logic in opac-*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Bug ID: 23247 Summary: Simplify visibility logic in opac-*detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The logic seems too complex for the covered use cases, and it queries the DB too many times without a real need for that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-*detail.pl [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Summary|Simplify visibility logic |Simplify visibility logic |in opac-*detail.pl |in opac-*detail.pl ||[OMNIBUS] Depends on||22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16507] Show play media tab first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 [Bug 23246] Record detail page jumps into the 'images' tab if no holdings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi changed: What|Removed |Added Depends on||16507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 [Bug 16507] Show play media tab first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #153 from Martin Renvoize --- I hit this error during DB update.. seems harmless but perhaps we should be handling it better. DEV atomic update: bug_14570.perl DBD::mysql::db do failed: Column 'relationship' cannot be null [for Statement " INSERT INTO borrower_relationships ( guarantor_id, guarantee_id, relationship ) SELECT guarantorid, borrowernumber, relationship FROM borrowers WHERE guarantorid IS NOT NULL; "] at (eval 1396) line 24. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9548] Log changes to baskets/basket groups so you can print/download the same data as at time of creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 91155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91155=edit
Bug 23246: (follow-up) Hardcoding tab position is not enough
There are many conditions that determine the tab number for 'media'.
Translated into variables that hold the tabs count on each condition, it
is clear that '3' was not good enough:
[%- holdings = (SeparateHoldings) ? 2 : 1
notes = (MARCNOTES || notes) ? 1 : 0
acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
frbr = (FRBRizeEditions && XISBNS) ? 1 : 0
local_covers = (LocalCoverImages && (localimages ||
CAN_user_tools_upload_local_cover_images)) ? 1 : 0
media_tab = holdings + notes + acq + frbr + local_covers
-%]
This patch gets rid of the hardcoded value, adds an id to the 'media'
tab (i.e. 'media_tab') and uses JS to get the right index.
To test:
- Play with the different options governing those variables
=> FAIL: 3 is not always the 'media' tab
- Apply this patch
- Repeat your tests
=> SUCCESS: It always picks the 'media' tab
- Sign off :-D
Sponsored-by: American Numismatics Society
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 91154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91154=edit Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to This patch makes jumping into the third tab happen only if HTML5MediaEnabled is set to 'both' or 'staff'. To test: - Have HTML5MediaEnabled set to 'opac' or 'not at all' - Open the detail page of a record with no holdings => FAIL: The 'images' tab is selected - Apply this patch - Reload => SUCCESS: The 'holdings' tab is selected as it should be. - Sign off :-D Sponsored-by: America Numismatic Society -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19383] Print hold slips without confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #13 from jdem...@roseville.ca.us --- We just tested the automatic printing and it only seems to work if you have one library location. It works for everything else but at the end we tried switching the hold location to one of our other branches and it still auto prints the hold even. Here is my test example: 1. Item found on Library A shelf for pick up at Library B. 2. Check in item at Library A to trigger the transfer. 3. Hold slip prints and says its on hold at Library B. So it looks like it overwrites the transfer, however a transfer box does come up under the hold box. Thanks, Jen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #5 from Martin Renvoize --- On second thoughts.. the tree beneath bug 23214 is fairly large and currently blocked by an FQA bug.. will wait on that to test this, but in effect, it means this bug is blocked.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #4 from Martin Renvoize --- As a note to this one.. I think it really ought to have been written independently of bug 23214 really.. it was a surprise to see that as a dependency here as really they're pretty unrelated changes. I will however on this occasion look to testing both to save you a refactor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize --- Failing QA.. we need tests adding to Koha/SearchEngine/Elasticsearch/QueryBuilder.t for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Add logs for budgets and funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Martin Renvoize changed: What|Removed |Added Blocks||13988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 [Bug 13988] Log activities related to Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13988] Log activities related to Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Martin Renvoize changed: What|Removed |Added Depends on||13325 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 [Bug 13325] Add logs for budgets and funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #117 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 --- Comment #70 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23045] Advanced cataloging editor (rancor) throws a JS error on incomplete/blank lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23045 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23225] OPAC ISBD view returns 404 when no item attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23225 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #30 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] New: Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Bug ID: 23246 Summary: Record detail page jumps into the 'images' tab if no holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This is certainly related to bug 16507. The original implementation is supposed to jump into the 'media tab' if there are no holdings, but it is not checking HTML5MediaEnabled or HTML5MediaYouTube in order to jump to that tab. Steps to reproduce: - Have HTML5MediaYouTube and HTML5MediaEnabled disabled - Create a record with no items - Go to the detail page => FAIL: the 'Images' tab is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 91153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91153=edit Bug 23230: Make _version_compare OO context aware On using _version_compare in plugins development, it would be nice if it was able to be called as an object method. This way we don't need to fully qualify it like this: Koha::Plugins::Base::_version_compare and we can do $self->_version_compare instead. This patch implements this behavior change. It is backwards compatible so plugins using the 'old way' don't break. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 91152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91152=edit Bug 23230: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 --- Comment #2 from Katrin Fischer --- Firefox Quantum, 67.0.4 (Windows) works with 19.05 too I think this might make this WONTFIX? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826 Nick Clemens changed: What|Removed |Added Attachment #89330|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 91151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91151=edit Bug 22826: Allow indexing of individual authorities in Elasticsearch To test: 1 - perl misc/search_tools/rebuild_elastic_search.pl -h 2 - Note it indicates the bn option can be passed to index individual authids 3 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v 4 - Note the error 5 - Apply patch 6 - perl misc/search_tools/rebuild_elastic_search.pl -h 7 - Note new option ai|authid for indexing individual authids 8 - Note updated text for bn|biblionumber option 9 - perl misc/search_tools/rebuild_elastic_search.pl -a -bn 92 -v 10 - No errors, but no records indexed 11 - perl misc/search_tools/rebuild_elastic_search.pl -a -ai 92 -v 12 - 1 record indexed 13 - perl misc/search_tools/rebuild_elastic_search.pl -ai 92 -bn 92 -v 14 - 1 authority record and 1 biblio record indexed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Katrin Fischer changed: What|Removed |Added Version|master |18.11 --- Comment #1 from Katrin Fischer --- Chrome works with 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What|Removed |Added Attachment #84283|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 91150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91150=edit Bug 21958: Fix bibliographic record field comparison with authority This makes the comparison between bibliographic field and authority field more robust and per subfield. This makes the comparison not consider the same e.g. the following fields: $a Test User $a Test $b User The actual issue cannot be as easily reproduced with the patches for bug 21826 applied, but here's a test plan anyway: 1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*) 2. Make sure authority linking still works properly 3. Make sure authority and biblio frameworks allow subfield i 4. Make sure that even if you add subfield i to 700 in biblio, authority link is kept the same 5. Make sure that even if you add subfield i to the authority record, the authority link is kept the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #18 from Nick Clemens --- Created attachment 91149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91149=edit Bug 16787: Rebase fixes and updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #16 from Nick Clemens --- Created attachment 91147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91147=edit Bug 16787: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #17 from Nick Clemens --- Created attachment 91148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91148=edit Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record To test: 1 - Set 'Holds per record' to 0 for some itemtype/patorn combination 2 - Attempt to plac a hold 3 - Will see 'Too many..' 4 - Apply patch 5 - Try again 6 - Should now see 'No holds..' 7 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Attachment #72827|0 |1 is obsolete|| Attachment #72828|0 |1 is obsolete|| Attachment #72889|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 91146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91146=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23245] Floating toolbar on vendors page overlaps with vendor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #0) > This method is to be run inside plugin objects that inherit from > Koha::Plugins::Base, but calling > > $self->_version_compare(); > > won't work because the method doesn't expect $self to be passed. We should make it work either way since historically it has been non-OO and there are some plugins that may be using it in a non-OO way. I think ti should be easy to check the first parameter to know if it is being called as an object method or not! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23245] New: Floating toolbar on vendors page overlaps with vendor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23245 Bug ID: 23245 Summary: Floating toolbar on vendors page overlaps with vendor name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Created attachment 91145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91145=edit Floating toolbar overlapping with vendor name In some browsers we see strange behaviur with the new floating toolbar on the vendor summary page. The toolbar will overlap with the vendor's name (see screenshot). So far it happens in: Version 73.0.3683.103 (Windows) Firefox Quantum, 67.0.4 (Windows) Working well: Firefox Quantum 60.7.1esr (64-Bit) (Windows) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #24 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #23) > (In reply to Joonas Kylmälä from comment #22) > > > I'm not sure I understand what you are proposing we deprecate. Can you > > > clarify that for me? Thanks! > > > > To deprecate AllowItemsOnHoldCheckoutSCO and just have one syspref, e.g. > > "AllowItemsOnHoldCheckoutSCO". > > Sorry, I meant just to have for example "AllowItemsOnHoldCheckout" Thanks! I tend to agree with Katrin. For instance, it may be that Koha SCO is being used on site and librarians want to prevent patrons from grabbing books from the hold shelf and SIP is being used off site and if the "patron has possession" of the item they need to be able to check it out. This scenario is completely contrived but I think it's illustrative ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23244] Sort order in basket to default to title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 --- Comment #1 from Paul Thornton --- Customer wants the sort order in a basket to default to title a-z, and have all titles in the basket display on the one screen. While you can create it to 'x number of entries' and also display a-z, it cannot be set as a default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23244] New: Sort order in basket to default to title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 Bug ID: 23244 Summary: Sort order in basket to default to title Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: paul.thorn...@educampus.ie QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #10 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #8) > (In reply to Kyle M Hall from comment #7) > > Created attachment 91143 [details] [review] [review] > > Bug 23233: Remove use of AllowItemsOnHoldCheckout from > > C4::Items::GetItemsInfo > > You accidentally obsoleted the new patch instead of old one? I realized it wasn't complete and I decided to keep it separate for clarity. Thanks for checking! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
