[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #9 from Alex Buckley --- Hi Nadine and Nick, Thanks for taking the time to test/look at my patches. I've done the following in the follow-up patch I've just attached in response to your notes in comment #4 Nick: Re. point 1. * Renamed the syspref so it has a name more relevant to what it does: RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult * Set the preference to OFF by default so if the library wants the behaviour change they have to actively enable it. Re. point 2. * As the syspref has been renamed to reflect that it doesn't block unlinked patrons from being set as guarantors this should be resolved now. Having said that it could be a good idea in the future to block unlinked patrons from being set as guarantors in another bug report in the future. Re. point 3. * When the aforementioned syspref is enabled then the contactname, contactfirstname and relationship are set to NULL upon a guarantee being updated to a guarantor via members/update-child.pl or members/memberentry.pl Can you please retest? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #8 from Alex Buckley --- Created attachment 91726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91726=edit Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Renamed syspref now called: RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult * Also set syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult syspref and confirm it is disabled 15. Repeat steps 1-5 and notice that the guarantor information is displayed on the new adult's record (i.e. when the RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult syspref is disabled the current Koha behaviour occurs). 16. In the database confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not set to NULL. 17. Repeat steps 7-10 and notice that the guarantor information is displayed on the new adult's record Also repeat step 16 and confirm the same outcome 18. Set GuarantorsMustBeLinkedToPatronAccount syspref to enabled 19. Repeat steps 1-5 and confirm the guarantor information is not displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to enabled implements the behaviour change). Also repeat step 16 and confirm the guarantorid, contactname, contactfirstname and relationship are all NULL 20. Repeat steps 7-10 and confirm the guarantor information is not displayed Also repeat step 16 and confirm the guarantorid, contactname, contactfirstname and relationship are NULL 21. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley changed: What|Removed |Added Attachment #91725|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #7 from Alex Buckley --- Created attachment 91725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91725=edit Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Set the GuarantorsMustBeLinkedToPatronAccount syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for GuarantorsMustBeLinkedToPatronAccount syspref and confirm it is enabled 15. Repeat steps 1-5 and notice that the guarantor information is not displayed on the new adult's record also in the database confirm the guarantorid, contactname, contactfirstname, relationship are set to NULL. 16. Repeat steps 7-10 and notice that the guarantor information is not displayed on the new adult's record 17. Set GuarantorsMustBeLinkedToPatronAccount syspref to disabled 18. Repeat steps 1-5 and confirm the guarantor information is displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to disabled keeps the current Koha behaviour) also check in the database and confirm that guarantorid is NULL, and contactname, contactfirstname and relationship are not NULL. 19. Repeat steps 7-10 and confirm the guarantor information is displayed Also check in the database and confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not NULL 20. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley changed: What|Removed |Added Attachment #91724|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley changed: What|Removed |Added Depends on||23224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Alex Buckley changed: What|Removed |Added Blocks||12949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 [Bug 12949] changing child to adult doesn't remove link to guarantor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #6 from Alex Buckley --- Created attachment 91724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91724=edit Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Set the GuarantorsMustBeLinkedToPatronAccount syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for GuarantorsMustBeLinkedToPatronAccount syspref and confirm it is enabled 15. Repeat steps 1-5 and notice that the guarantor information is not displayed on the new adult's record also in the database confirm the guarantorid, contactname, contactfirstname, relationship are set to NULL. 16. Repeat steps 7-10 and notice that the guarantor information is not displayed on the new adult's record 17. Set GuarantorsMustBeLinkedToPatronAccount syspref to disabled 18. Repeat steps 1-5 and confirm the guarantor information is displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to disabled keeps the current Koha behaviour) also check in the database and confirm that guarantorid is NULL, and contactname, contactfirstname and relationship are not NULL. 19. Repeat steps 7-10 and confirm the guarantor information is displayed Also check in the database and confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not NULL 20. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #5 from Alex Buckley --- Hi Nick, Thanks very much for your test feedback I will make changes now. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Lucas Gass changed: What|Removed |Added Attachment #90516|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 91723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91723=edit This is much better. CSS is always greater than jQuery in these instances. Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272 --- Comment #6 from Lucas Gass --- Created attachment 91722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91722=edit Good enhancment, works well and passes qa tools. signing off Bug 22272 - Calendar: When entering date... ...ranges grey out dates in the past from the start date In "Calendar" tool it's possible to pick dates before start date as end date. This patch sets end date calendars "minDate" as picked start day to grey out past dates. Also reindents datepicker code for better readability. Test plan: - Apply this patch - Set start date from first calendar - Set end date from second calendar => Dates before start date are greyed out Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #183 from Agustín Moyano --- Created attachment 91721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91721=edit Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #176 from Agustín Moyano --- Created attachment 91714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91714=edit Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #180 from Agustín Moyano --- Created attachment 91718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91718=edit Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #174 from Agustín Moyano --- Created attachment 91712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91712=edit Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #181 from Agustín Moyano --- Created attachment 91719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91719=edit Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #182 from Agustín Moyano --- Created attachment 91720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91720=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #172 from Agustín Moyano --- Created attachment 91710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91710=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #173 from Agustín Moyano --- Created attachment 91711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91711=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #175 from Agustín Moyano --- Created attachment 91713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91713=edit Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #179 from Agustín Moyano --- Created attachment 91717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91717=edit Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #170 from Agustín Moyano --- Created attachment 91708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91708=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #177 from Agustín Moyano --- Created attachment 91715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91715=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #171 from Agustín Moyano --- Created attachment 91709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91709=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #178 from Agustín Moyano --- Created attachment 91716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91716=edit Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #169 from Agustín Moyano --- Created attachment 91707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91707=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #167 from Agustín Moyano --- Created attachment 91705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91705=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #168 from Agustín Moyano --- Created attachment 91706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91706=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #166 from Agustín Moyano --- Created attachment 91704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91704=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #163 from Agustín Moyano --- Created attachment 91701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91701=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #165 from Agustín Moyano --- Created attachment 91703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91703=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #164 from Agustín Moyano --- Created attachment 91702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91702=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #89837|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91261|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91273|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91280|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91276|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91282|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91263|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91262|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91275|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91277|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91278|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91279|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91269|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91265|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91266|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91274|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91264|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91268|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91270|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91271|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #91272|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #39 from Lucas Gass --- backported Kyle's rebase for 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #167 from Kyle M Hall --- Created attachment 91698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91698=edit Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #169 from Kyle M Hall --- Created attachment 91700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91700=edit Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #168 from Kyle M Hall --- Created attachment 91699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91699=edit Bug 14570: (follow-up) Fix patron type when "add child" button is pressed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added Attachment #91439|0 |1 is obsolete|| Attachment #91440|0 |1 is obsolete|| Attachment #91441|0 |1 is obsolete|| Attachment #91442|0 |1 is obsolete|| Attachment #91443|0 |1 is obsolete|| Attachment #91444|0 |1 is obsolete|| Attachment #91445|0 |1 is obsolete|| --- Comment #163 from Kyle M Hall --- Created attachment 91694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91694=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #166 from Kyle M Hall --- Created attachment 91697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91697=edit Bug 14570: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #165 from Kyle M Hall --- Created attachment 91696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91696=edit Bug 14570: (follow-up) fix qa FAIL tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #164 from Kyle M Hall --- Created attachment 91695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91695=edit Bug 14570: (follow-up) fix table name in j2a.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #162 from Liz Rea --- Apologies, this seems to not apply: Auto-merging members/deletemem.pl CONFLICT (content): Merge conflict in members/deletemem.pl Patch failed at 0001 Bug 14570: Make it possible to add multiple guarantors to a record The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Bug 14570 - Make it possible to add multiple guarantors to a record will have a look to resolve that but you may beat me! Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23283 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12159 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283 --- Comment #9 from Fridolin SOMERS --- In >= 19.05.x Bug 12159 made this change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00|19.11.00,19.05.02 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #38 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.01 released in|| --- Comment #39 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22571] MARC modification templates do not handle control fields in conditional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 benjamin.r.philbr...@lmco.com changed: What|Removed |Added CC||benjamin.r.philbrook@lmco.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 benjamin.r.philbr...@lmco.com changed: What|Removed |Added CC||benjamin.r.philbrook@lmco.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 --- Comment #7 from Nick Clemens --- (In reply to Katrin Fischer from comment #6) > This is a strange change in behaviour between 17.11 and 18.11. > > In 17.11: clicking on subfields leads to the 'summary' page of subfields > with edit and delete buttons for each: > /cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=000= > > In 18.11: clicking on the subfields link leads to the edit screen and there > is no link to the 'summary' page visible, which is a usability problem if > you are trying ot delete a subfield. > > Can this please be backported to 18.11 as well? I think you describing bug 23153 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||rhouk@ottumwapubliclibrary. ||org Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357 --- Comment #1 from Nick Clemens --- Created attachment 91693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91693=edit Bug 23357: Check if generating a duplicate print notice before generating notice To test: 1 - Check out an overdue to a patron 2 - Set a notice trigger for the same number of days overdue for the patrons patron type 3 - Set the trigger to send via email and sms You may need to define SMSSendDriver preference to enable SMS, you can put 'Email' 4 - perl misc/cronjobs/overdue_notices.pl -v -t 5 - Check the patrons record, 1 notice generated 6 - Check the db: SELECT * FROM message_queue; 7 - Note the message 'Overdue notices' contains a doulbed content for the notice 8 - DELETE * FROM message_queue; 9 - Apply patch 10 - perl misc/cronjobs/overdue_notices.pl -v -t 11 - Chekc the patron's account, 1 message in 'Notices' 12 - Check the DB SELECT * FROM message_queue; 13 - The 'Overdue notices' notice is not doubled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23179] Add 'Edit subfields' to framework management tag dropdown and clarify options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23179 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- This is a strange change in behaviour between 17.11 and 18.11. In 17.11: clicking on subfields leads to the 'summary' page of subfields with edit and delete buttons for each: /cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=000= In 18.11: clicking on the subfields link leads to the edit screen and there is no link to the 'summary' page visible, which is a usability problem if you are trying ot delete a subfield. Can this please be backported to 18.11 as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23357] New: overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357 Bug ID: 23357 Summary: overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz In overdue_notices.pl we have a check to avoid sending a patron two notices if they are missing an email address and an sms number, however, we don't apply this check to generating the notice content and so send the library the same info twice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #218 from Ere Maijala --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16786] No longer to add multiple emails addresses in an email field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net --- Comment #1 from BASE Library Consortium --- Our library teams used to have this functionality on a previous LMS and would like to see this enhancement. Test case on BibLibre Koha sandbox 04 (17.06) when adding more than one valid email address in the email, emailpro or B_email and separating using a comma, space or semicolon, the error message reads: Please enter a valid email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89246|0 |1 is obsolete|| --- Comment #217 from Ere Maijala --- Created attachment 91692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91692=edit Bug 11529: (follow-up) Fix QA issues - Remove SplitKohaField - Avoid using Stash in templates - Improved display of part fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89243|0 |1 is obsolete|| --- Comment #214 from Ere Maijala --- Created attachment 91689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91689=edit Bug 11529: (follow-up) Remove manage_keywords2koha_mappings permission. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89245|0 |1 is obsolete|| --- Comment #216 from Ere Maijala --- Created attachment 91691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91691=edit Bug 11529: (follow-up) Fix link on hold request page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89244|0 |1 is obsolete|| --- Comment #215 from Ere Maijala --- Created attachment 91690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91690=edit Bug 11529: Add templates for biblio title display. Unify display. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89242|0 |1 is obsolete|| --- Comment #213 from Ere Maijala --- Created attachment 91688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91688=edit Bug 11529: Remove duplicate column name from select query Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89239|0 |1 is obsolete|| --- Comment #210 from Ere Maijala --- Created attachment 91685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91685=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89237|0 |1 is obsolete|| --- Comment #208 from Ere Maijala --- Created attachment 91683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91683=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89241|0 |1 is obsolete|| --- Comment #212 from Ere Maijala --- Created attachment 91687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91687=edit Bug 11529: Replace bibliosubtitle with biblio in all framework sql's. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89240|0 |1 is obsolete|| --- Comment #211 from Ere Maijala --- Created attachment 91686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91686=edit Bug 11529: Update kohafield in default framework only if not already set. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89238|0 |1 is obsolete|| --- Comment #209 from Ere Maijala --- Created attachment 91684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91684=edit Bug 11529: Remove field mapping table and admin page Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89236|0 |1 is obsolete|| --- Comment #207 from Ere Maijala --- Created attachment 91682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91682=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89235|0 |1 is obsolete|| --- Comment #206 from Ere Maijala --- Created attachment 91681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91681=edit Bug 11529: Use new biblio fields whenever possible Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Attachment #89234|0 |1 is obsolete|| --- Comment #205 from Ere Maijala --- Created attachment 91680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91680=edit Bug 11529: Add new fields to biblio table Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/