[Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #4) > Should we add an update database entry to fix this for existing > installations? I think we should. We already got people installing 19.05 for production use and we could just repeat the initial database update from introducing the feature with a check for data already being there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #4 from Katrin Fischer --- Should we add an update database entry to fix this for existing installations? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What|Removed |Added Attachment #91882|0 |1 is obsolete|| --- Comment #11 from ByWater Sandboxes --- Created attachment 91918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91918=edit Bug 23390: (QA follow-up) Don't redeclare variable Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What|Removed |Added Attachment #91888|0 |1 is obsolete|| --- Comment #12 from ByWater Sandboxes --- Created attachment 91919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91919=edit Bug 23390: (follow-up) Quote aliases Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23390] Add placeholder syntax for column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What|Removed |Added Attachment #91880|0 |1 is obsolete|| --- Comment #10 from ByWater Sandboxes --- Created attachment 91917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91917=edit Bug 23390: Introduce placeholder syntax for report column names This patch adds the ability to rename columns in MySQL reports using a syntax: [[column|alias]] To test: 1 - Write a report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 2 - Run report 3 - Note you can batch modify the patrons 4 - Update report: SELECT cardnumber AS library_barcode FROM borrowers WHERE cardnumber LIKE '%9' 5 - Run report 6 - Note batch options are no longer present 7 - Apply patch 8 - Run report, no change 9 - Update report like: SELECT [[cardnumber|library_barcode]] FROM borrowers WHERE cardnumber LIKE '%9' 10 - Run report 11 - Batch options work! 12 - Update report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 13 - Verify batch options still work 14 - Set report 'public' 15 - Verify report can be run via JSON URLs: http://kohadev.mydnsname.org:8080/cgi-bin/koha/svc/report?id=1 http://kohadev.mydnsname.org:8081/cgi-bin/koha/svc/report?id=1 Signed-off-by: George Williams Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com --- Comment #3 from Jessie Zairo --- I think in addition to giving a delete permission, we should also had a merge patron permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com --- Comment #7 from Jessie Zairo --- I am also interested in a notice when staff cancels a hold manually. I agree, maybe an authorized value or standard reasons for cancelling a hold (lost / missing / withdrawn). The notice could included the reason the hold was cancelled. I like the idea of Patron Messaging Preferences including Hold cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23410] Add submenus to system preferences sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- I think that would be very helpful! We have so many system preferences that sometime they can be hard to find if you don't know the specific pref to search for. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #2 from Nick Clemens --- Created attachment 91916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91916=edit Bug 23407: Don't process items for staff results either We also don't use the items here, same test plan but on staff cleint results, should see no change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #3 from Nick Clemens --- Created attachment 91915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91915=edit Bug 23414: Prefetch reserves and use them for determining waiting This dependss on bug 23413 Same tests as before, you shouldn't see a hit with this change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #2 from Nick Clemens --- Created attachment 91914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91914=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #1 from Nick Clemens --- Created attachment 91913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91913=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] New: Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Bug ID: 23414 Summary: Improve performance of C4/XSLT/buildKohaItemsNamespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org There are some improvements we can make to this routine to improve the speed at which we return results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #1 from Nick Clemens --- Created attachment 91912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91912=edit Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] New: Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Bug ID: 23413 Summary: Add a holds routine to Koha::Items to fetch related holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #46 from Liz Rea --- I suppose we ought to go back and test this again for 19.11 - did we ever fix the tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Kyle M Hall changed: What|Removed |Added Attachment #91877|0 |1 is obsolete|| Attachment #91878|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 91910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91910=edit Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 --- Comment #4 from Kyle M Hall --- Created attachment 91911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91911=edit Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23399] Reindent returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23108] staffaccess permission can be easily circumvented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 Aguayo changed: What|Removed |Added CC||azucena.agu...@uvu.edu --- Comment #2 from Aguayo --- Hi Jonathan, The ProtectSuperlibrarianPrivileges doesn't prevent the issue with either option set. If Patron A with only borrower permissions attempts to change the password using the "Change Password" button for Patron B, Patron A gets an error that they can't change the username/password of Patron B. Working as intended. However, Patron A can use the "Edit" button and change Patron B from Staff category to Adult category. Then after saving the account, Patron A can change the username/password of Patron B. At this point, Patron B is locked out of their account. In my case, Patron A has the following rights -(circulate) -(catalogue) -(borrowers) Patron A doesn't have -(permissions) -(staffaccess) (borrowers) is enough to allow the change from Staff to Adult. It seems that the settings protecting the Staff accounts don't look at the Edit rights of borrowers to prevent a category change. And ProtectSuperlibrarianPrivileges only prevents password changes for the Staff category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #1 from Lucas Gass --- Created attachment 91909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91909=edit Bug 23412: HTML should be allowed in MARC notes. (5xx fields) TEST PLAN 1. Add some HTML to one of the 5xx fields that displays in the OPAC: koha 2. Go to the record in the OPAC and look under the 'Title notes' tab. 3. See that the HTML displays literally. 4. Apply patch 5. Look at the 'Title notes' tab again. 6. HTML displays correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] New: HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Bug ID: 23412 Summary: HTML should be allowed in MARC notes. (5xx fields) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some librarians like to add HTML in the 5xx fields to display links, etc. We should allow $raw filters in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #6 from Fridolin SOMERS --- patron.opacnote exists in other places : koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc borrowernotes exists in a lot of other places. BTW html filter should always be used, not $raw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall changed: What|Removed |Added Attachment #91856|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 91908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91908=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23286] Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #5 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #4) > Instead of: > > +[% FILTER html_line_break %] > +[% patron.opacnote | > html %] > +[% END %] > > You can just do: > > [% patron.opacnote | html | html_line_break %] > > (I think we first want to espace, then make br so the br are not esacped) Indeed, its much better ;) See existing : [% subscription.notes | html | html_line_break %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23194 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23409 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411
--- Comment #1 from Nick Clemens ---
Created attachment 91907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91907=edit
Bug 23411 - SMS messages should not fall back to 'email'
To test:
1 - Have a patron wiht an sms number, but no email
2 - Enable sms by setting SMSDriver syspref to Email
3 - Set Notice triggers to send an overdue via sms and email
4 - Ensure the selected notice is defined only for 'email'
5 - Checkout an overdue to the patron above
You can set a specify a due date in the past
6 - perl misc/cronjobs/overdue_notices.pl -t
7 - Check the patron notices tab, they have a print notice and an SMS notice
pending
8 - The SMS notice used the 'email' template
9 - Apply patch
10 - sudo koha-mysql kohadev
11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above};
12 - Run the cron again
13 - Patron should have a print notice queued, no sms
14 - Define an SMS notice
15 - delete the message queue
16 - Run again
17 - The patron should have a print and an SMS
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23411] New: SMS messages should not fall back to 'email'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Bug ID: 23411 Summary: SMS messages should not fall back to 'email' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 15967 ensured that an email notice that falls back to print when the patron has no email will send a print notice using the email template if there is no print template. When SMS and fallback were added this means that an SMS message where there is no SMS template will use the email template - it shouldn't as SMS messages need to be shorter, we should instead fail sending SMS if no SMS template defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #4 from Katrin Fischer --- Instead of: +[% FILTER html_line_break %] +[% patron.opacnote | html %] +[% END %] You can just do: [% patron.opacnote | html | html_line_break %] (I think we first want to espace, then make br so the br are not esacped) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Attachment #91905|0 |1 is obsolete|| --- Comment #3 from Alex Arnaud --- Created attachment 91906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91906=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Alex, I think there is a nicer way to solve this using TT filters. I've seen them used in quite a few places already. http://www.template-toolkit.org/docs/manual/Filters.html#section_html_line_break -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #1 from Alex Arnaud --- Created attachment 91905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91905=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer --- Applies perfectly on 18.11.x - moving straight to PQA, another one-line patch fixing a bad bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #7 from Katrin Fischer --- Created attachment 91904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91904=edit Bug 22710: [18.11.x] Return to the last advanced search link not filtering correctly in 18.11.x Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What|Removed |Added Summary|Return to the last advanced |[18.11] Return to the last |search link not filtering |advanced search link not |correctly in 18.11.x|filtering correctly CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Confirmed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23410] New: Add submenus to system preferences sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Bug ID: 23410 Summary: Add submenus to system preferences sidebar menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Created attachment 91902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91902=edit Screenshot showing updated interface One of my proposed changes in Bug 20935 is the addition of submenu items in the sidebar menu of system preferences. I'm proposing this as a standalone enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 --- Comment #1 from Nick Clemens --- Created attachment 91903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91903=edit Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #28 from Magnus Enger --- (In reply to Nick Clemens from comment #26) > (In reply to Jonathan Druart from comment #25) > > Maybe like: > > Purge statistics entries more than DAYS days old > > Purge catalog records deleted more then DAYS days ago > > Purge patrons deleted more than DAYS days ago > > Purge checkouts (old_issues) returned more than DAYS days ago > > Purge transfers completed more than DAYS day ago Fridolin: Any chance you can find the time to update the POD with these suggestions? We really need a way to clean up the data that these patches clean up. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Summary|Show borrowernotes and |Show borrowernotes and |opacnote's lines feeds |opacnote's lines feeds |(staff and opac)|(staff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12345] Can't Clear Reading History for Anonymous patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #5 from Magnus Enger --- (In reply to Jonathan Druart from comment #2) > Still valid. > But the behavior is the expected one: When you delete a checkout history you > actually anonymise the checkout history :) I would say this qualifies as a WONTFIX. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] New: Show borrowernotes and opacnote's lines feeds (staff and opac)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bug ID: 23409 Summary: Show borrowernotes and opacnote's lines feeds (staff and opac) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently, lines feeds typed in borrowernotes and opacnote are not visible in the interface. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff and opac)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
