[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #26 from Hayley Mapley  ---
Patch doesn't apply

git bz apply 11677
Bug 11677 - Limit to Only items currently available for loan or reference not
working

34431 - Bug 11677 - Limit to Only items currently available for loan or
reference not working!
92144 - Bug 11677: Use zebra not-onloan-count index for availability limit

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11677 - Limit to Only items currently available for loan or
reference not working!
error: sha1 information is lacking or useless (C4/Search.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 11677 - Limit to Only items currently available for
loan or reference not working!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

--- Comment #1 from Alex Buckley  ---
Created attachment 92147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92147=edit
Bug 23450: Display subscription and issue cost in subscription interface of the
catalouge/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

Alex Buckley  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz,
   ||hayleymap...@catalyst.net.n
   ||z

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23450] New: Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450

Bug ID: 23450
   Summary: Display issue and subscription price for each issue in
subscription tab of /catalogue/detail.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422

Nick Clemens  changed:

   What|Removed |Added

  Attachment #82874|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 92146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92146=edit
Bug 15422: Consider partial copies needed as whole numbers

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422

Nick Clemens  changed:

   What|Removed |Added

  Attachment #82873|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 92145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92145=edit
Bug 15422: Correct calculation of holds ratio report

See comment 1 for a detailed explanation of current calculations and
needed calculations

Also removes an unnecessary variable

To test:
 1 - Place 4 holds on a biblio with one item
 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds
ratios)
 3 - Run with 'Hold ratio'=3, it says order 1, ok
 4 - Run with HR=4, it says order 1, wrong
 5 - Run with HR=2, it syas order 2, wrong
 6 - Run with HR=.5, it syas order 4, wrong
 7 - Apply patch
 8 - Run with HR=3, order 1, OK
 9 - Run with HR=4, item does not appear (0 to order), OK
10 - Run with HR=2, order 1, OK
11 - Run with HR=.5, order 7, OK

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Blocks||23449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23449
[Bug 23449] Get available pickup locations from REST API
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23449] Get available pickup locations from REST API

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23449

Lari Taskula  changed:

   What|Removed |Added

 Depends on||16826
   Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826
[Bug 16826] REST API: Add API routes for getting item availability and
holdability
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23449] New: Get available pickup locations from REST API

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23449

Bug ID: 23449
   Summary: Get available pickup locations from REST API
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lari.task...@hypernova.fi

We need a way to tell if we can use library as a hold pickup location via rest
api. Patches attached in this Bug number aim to extend Bug 16826.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

--- Comment #25 from Nick Clemens  ---
Created attachment 92144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92144=edit
Bug 11677: Use zebra not-onloan-count index for availability limit

This uses the work from bug 18098 to use the count of not-onloan items to
determine availability.

Note that availability in this sense means not check out and not lost.
Transfers, holds, and not for loan statuses
should probably have indexes built in the same way as bug 18098 (there are
related fixmes in the code)

To test:
 1 - make sure SearchEngine pref is set to 'Zebra'
 2 - Do a search on the OPAC that returns some records
 3 - Find a record in those results with more than one 1 item, and checkout 1
leaving 1 (or more) available
 4 - Find another record with only 1 item, check that item out
 5 - Limit opac search to available items - both records disappear
 6 - Apply patch
 7 - Restart all the things
 8 - Repeat search
 9 - First record should show, but no second
10 - Mark other items of first record as lost, return items on second record
11 - Repeat search, first record should not be in results, second should

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14942] if there is no barcode, item level hold can become a biblio level hold

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |WORKSFORME
 Status|Patch doesn't apply |RESOLVED

--- Comment #5 from Katrin Fischer  ---
I've tested too and can't replicate the issue. The item level hold stays item
level. There have been lots of changes since this was filed, so I tihnk it
could have easily been fixed as a side effect of another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23366] Add html option on subscription additional field

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23366

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
If you want to add links, would a URL option be nice? Then you could just copy
in the link without dealing with any HTML and we'd display that as a link once
saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #10 from Katrin Fischer  ---
Hi Nick, I agree on fixing the bug first - can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15422: Correct calculation of holds ratio report
Using index info to reconstruct a base tree...
M   circ/reserveratios.pl
Falling back to patching base and 3-way merge...
Auto-merging circ/reserveratios.pl
CONFLICT (content): Merge conflict in circ/reserveratios.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15422: Correct calculation of holds ratio report
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15422-Correct-calculation-of-holds-ratio-repor-0dn4_I.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20856] Restore ability to delete unverified self registrations after x hours

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856

--- Comment #3 from Katrin Fischer  ---
Hi Frido, no this is not fixed. The job is now done by the cleanup script, but
it still can't be scheduled for hours again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22255] Item Search csv export, missing fields

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22255

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hi Josè, you need to check the translations on translate.koha-community.org. If
you tell us the language, we might be able to help.
As this can't be fixed in Koha, I am moving this to "RESOLVED MOVED".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21538] Show ilbrary on account page

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I think both the Transactions and the Make a payment tab would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo)

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from Katrin Fischer  ---
Hi Jonathan, thx for your work and input on this!

I've tried signing off, but the tests don't pass for me:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Koha/Patrons.t
t/db_dependent/Koha/Patrons.t .. 8/40 
#   Failed test at t/db_dependent/Koha/Patrons.t line 275.
#  got: ''
# expected: 'On invalid "is going to expire" date, the method should
not crash with "Invalid local time for date in time zone"'
# Looks like you failed 1 test of 9.

#   Failed test 'is_going_to_expire'
#   at t/db_dependent/Koha/Patrons.t line 280.

Could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184

--- Comment #1 from Katrin Fischer  ---
We get quite some support requests about this. If you want to export records
that don't have items (electronic resources, serials, set records) you need to
explicitly uncheck the already checked branches.

From the feedback we receive in support, I'd suggest that we uncheck all
branches by default. This means by default you export all records, unless you
limit your export. Which seems more logical.

I've taken a look at the logic of the script but got quite confused, some help
changing this would be appreciated!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23428] Self registration with a verification by email is broken

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Katrin Fischer  ---
Hi Jonathan, 

is this for a specific version or am I missing something on testing? 

I have just tested twice on master without the patch and everytime the email
verification link worked without error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23428] Self registration with a verification by email is broken

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|unspecified |master
   Severity|major   |critical

--- Comment #2 from Katrin Fischer  ---
Updating severity as this is a 'patron facing' feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22884] Remove ending . from XSLT templates

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884

--- Comment #17 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #13)
> After these patches if you have a 440 and a 490 in the record they have no
> space between.
> 
> I mean, you probably shouldn't have both, but I have seen stranger things

Follow-up added, thx for testing Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22884] Remove ending . from XSLT templates

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884

--- Comment #16 from Katrin Fischer  ---
Created attachment 92143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92143=edit
Bug 22884: Show separator between 440 and 490 fields

This adds a ; as separator between 440 and 490 fields used in the
same record. Currently we loop first 440 and then 490. 490 is displayed
depending on the indicator.

So after we finish the first loop, we check for existence of 490 on the
same record now to decide if a separator is needed.

To test:
- Look at various records using one or multiple 440 and 490 fields
- Verify the display is correct, especially when both appar on the
  same record in both OPAC and staff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22884] Remove ending . from XSLT templates

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23423] Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423

Katrin Fischer  changed:

   What|Removed |Added

Version|19.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23423] Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Katrin Fischer  ---
I just tested on master and the link is broken for me everywhere:
- OPAC detail and result pages
- Staff detail and result pages

I wanted to check the MARC standard... but:
Some Library of Congress Websites Will Not Be Available August 9-11 

But as it turns out... this is a regression caused by the recently added 21887.

I am updating severity as this content is created by the file upload feature
that is inbuilt into Koha. So we can expect a lot of those links broken now :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23423] Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||21887


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887
[Bug 21887] 856$u link problem in XSLT result lists and detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||23423
 CC||katrin.fisc...@bsz-bw.de

--- Comment #20 from Katrin Fischer  ---
Unfortunately this causes a regression with any relative links added by the
opload feature no longer working: bug 23423


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423
[Bug 23423] Online resource links which are OPAC retrieve file references are
not correctly formatted in the OPAC detail view
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #90288|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 92141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92141=edit
Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive

Brought up on Bug 21578, the 'your fines' tab in the OPAC would be
better named as 'your charges' as not all charges are fines, some are
credits etc.

To test:
1) In the OPAC, click on the user's name and note that the tab that was called
your fines is now called your charges.
2) When you click on the tab, the title says Your charges, the breadcrumb says
Your
charges, and the table title is Your charges.

Sponsored-by: Catalyst IT.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

--- Comment #9 from Katrin Fischer  ---
Created attachment 92142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92142=edit
Bug 22627: Rename tab on my summary page

This completes the first patch by also changing the
tab on the OPAC summary page from "Fines" to "Charges".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

--- Comment #7 from Katrin Fischer  ---
(In reply to Lucas Gass from comment #6)
> This looks nice. But when I try to sign-off I get:
> 
> Found multiple bug references specified commits:
>   https://bugs.koha-community.org/show_bug.cgi?id=22627
>   https://bugs.koha-community.org/show_bug.cgi?id=21578

Hi Lucas, works ok for me - maybe your branch was not clean?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

--- Comment #7 from Katrin Fischer  ---
Created attachment 92140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92140=edit
Bug 8778: Add Keyword phrase to OPAC advanced search

Adds a new search index to the advanced search in OPAC:
Keyword phrase
The new search option displays when the "More options" are
selected.

To test:
- Apply patch
- Go to Advanced search in OPAC
- Look at the search pull downs
- Verify everything looks correct
- Click "More options"
- Verify the Keyword phrase search option shows
- Test if it works correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add "Phrase" Searching to   |Add Keyword phrase search
   |OPAC Search |to OPAC search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
I am seeing some issues here - when I used the linking on an existing sample
record I got:

Search main heading ($a only), contains: Waeschke, Hermannus,
search main headin, contains: 1850- [from old catalog]


Resulting in:

[Request] ** [http://localhost:9200]-[400] [query_shard_exception] Failed to
parse query [(1850-) AND ([from*) AND (old*) AND (catalog])], with:
{"index":"koha_kohadev_authorities","index_uuid":"S12XDtQeTMWLoBsmUsRlnw"},
called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/Search.pm line 100.
With vars: {'body' => {'status' => 400,'error' => {'phase' => 'query','grouped'
=> bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ),'root_cause' => [{'type' =>
'query_shard_exception','reason' => 'Failed to parse query [(1850-) AND
([from*) AND (old*) AND (catalog])]','index_uuid' =>
'S12XDtQeTMWLoBsmUsRlnw','index' => 'koha_kohadev_authorities'}],'type' =>
'search_phase_execution_exception','reason' => 'all shards
failed','failed_shards' => [{'index' => 'koha_kohadev_authorities','shard' =>
0,'node' => 'Secs-Ua8SyyeB_6hIXEnSA','reason' => {'type' =>
'query_shard_exception','reason' => 'Failed to parse query [(1850-) AND
([from*) AND (old*) AND (catalog])]','index' =>
'koha_kohadev_authorities','index_uuid' => 'S12XDtQeTMWLoBsmUsRlnw','caused_by'
=> {'caused_by' => {'type' => 'parse_exception','reason' => 'Encountered "
 "AND "" at line 1, column 21.
Was expecting:
"TO" ...
'},'reason' => 'Cannot parse \'(1850-) AND ([from*) AND (old*) AND
(catalog])\': Encountered "  "AND "" at line 1, column 21.
Was expecting:
"TO" ...
','type' => 'parse_exception'}}}]}},'request' => {'serialize' => 'std','qs'
=> {},'path' => '/koha_kohadev_authorities/_search','method' => 'GET','ignore'
=> [],'mime_type' => 'application/json','body' => {'query' => {'bool' =>
{'must' => [{'query_string' => {'query' => '(Waeschke,) AND
(Hermannus,)','default_field' => 'heading-main','analyze_wildcard' => bless(
do{\(my $o = 1)}, 'JSON::PP::Boolean' )}},{'query_string' => {'query' =>
'(1850-) AND ([from*) AND (old*) AND (catalog])','default_field' =>
'heading','analyze_wildcard' =>
$VAR1->{'request'}{'body'}{'query'}{'bool'}{'must'}[0]{'query_string'}{'analyze_wildcard'}}}]}},'from'
=> 0,'size' => 20,'sort' => [{'heading__sort.phrase' => 'asc'}]}},'status_code'
=> 400}
Unable to perform your search. Please try again.

When I remove the second input, it works with and without the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Signed Off

--- Comment #7 from Katrin Fischer  ---
Counting Kyle's sign-off here, switching to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/