[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #45 from Liz Rea --- The "bad" perms, are the way that they are always created - if you delete the logs and re initialize them they come back that way. :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #44 from Liz Rea --- intranet error and opac error tho, those ones are created by apache, not plack. And those are the ones with the bad perms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Michal Denar --- Hello, can you rebase on master? Thank you. Applying: Bug 21958: Fix bibliographic record field comparison with authority Using index info to reconstruct a base tree... M C4/AuthoritiesMarc.pm M C4/Biblio.pm M C4/Heading.pm M C4/Heading/MARC21.pm M installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql M t/db_dependent/AuthoritiesMarc.t Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 21958: Fix bibliographic record field comparison with authority The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21958-Fix-bibliographic-record-field-compariso-DE87lj.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #13 from Nick Clemens --- I like this one Owen, I didn't like the way the dialogs disappeared when the modal appeared though. I am wondering if we can simply leave them in place? While we can bring the modal back up, it might be nice to keep the messages in place. I tried making them show on modal hide, but that added more page flicker Feel free to SO or obsolete my follow-up, I won't argue strongly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Nick Clemens changed: What|Removed |Added Attachment #92481|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 92514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92514=edit Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Kyle Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #12 from Nick Clemens --- Created attachment 92515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92515=edit Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22826] Allow indexing of individual authority records in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22826 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar changed: What|Removed |Added Attachment #91998|0 |1 is obsolete|| --- Comment #7 from Michal Denar --- Created attachment 92512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92512=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar changed: What|Removed |Added Attachment #91999|0 |1 is obsolete|| --- Comment #8 from Michal Denar --- Created attachment 92513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92513=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23210] login4tags should be a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Michal Denar changed: What|Removed |Added Attachment #92504|0 |1 is obsolete|| --- Comment #3 from Michal Denar --- Created attachment 92511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92511=edit Bug 23518: Problem with borrower search autocomplete This patch fixes a bug introduced by my patch for Bug 23405: Keyboard navigation of patron autocomplete results was broken because I incorrectly assumed that the autocomplete "select" action was redundant because keyboard navigation would trigger the selected link. It doesn't! This patch adds the "select" action back to the autocomplete configuration, explicitly defining a redirect to match the URL which is followed if the user uses the mouse to click a result. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Making a selection from the autocomplete results should work by clicking with a mouse OR using the arrow keys and TAB or ENTER. - Test with patrons with and without card numbers. Signed-off-by: Nick Clemens Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #43 from Tomás Cohen Arazi --- Plack logs should be generated by Plack, no Apache at all. And my guess at some point was that starman (or the koha-plack script runnning as root) was to blame for the permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #42 from Liz Rea --- i forgot to put in the perms that work with this patch: vagrant@kohadevbox:kohadev$ ls -lha total 688K drwxr-xr-x 2 kohadev-koha kohadev-koha 4.0K Aug 30 14:50 . drwxr-xr-x 3 root root 4.0K Aug 30 14:47 .. -rw-r--r-- 1 kohadev-koha kohadev-koha 25K Aug 30 18:36 indexer-error.log -rw-r--r-- 1 kohadev-koha kohadev-koha0 Aug 30 14:47 indexer-output.log -rw-r--r-- 1 kohadev-koha kohadev-koha0 Aug 30 14:47 intranet-error.log -rw-r--r-- 1 kohadev-koha kohadev-koha 105K Aug 30 14:49 opac-error.log -rw-r--r-- 1 kohadev-koha kohadev-koha 524K Aug 30 18:36 plack-error.log -rw-r--r-- 1 kohadev-koha kohadev-koha 6.8K Aug 30 18:36 plack.log -rw-r--r-- 1 kohadev-koha kohadev-koha 773 Aug 30 18:36 zebra-error.log -rw-r--r-- 1 kohadev-koha kohadev-koha 399 Aug 30 18:36 zebra-output.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
--- Comment #41 from Liz Rea ---
Ok, I've made this work again, and I followed my previous notes to get there
with the addition of one detail
by default, the log perms look like this:
vagrant@kohadevbox:kohadev$ ls -lah
total 688K
drwxr-xr-x 2 kohadev-koha kohadev-koha 4.0K Aug 30 14:50 .
drwxr-xr-x 3 root root 4.0K Aug 30 14:47 ..
-rw-r--r-- 1 kohadev-koha kohadev-koha 25K Aug 30 18:36 indexer-error.log
-rw-r--r-- 1 kohadev-koha kohadev-koha0 Aug 30 14:47 indexer-output.log
-rw-r--r-- 1 root root0 Aug 30 14:47 intranet-error.log
-rw-r--r-- 1 root root 105K Aug 30 14:49 opac-error.log
-rw-r--r-- 1 kohadev-koha kohadev-koha 524K Aug 30 18:36 plack-error.log
-rw-r--r-- 1 kohadev-koha kohadev-koha 6.8K Aug 30 18:36 plack.log
-rw-r--r-- 1 kohadev-koha kohadev-koha 773 Aug 30 18:36 zebra-error.log
-rw-r--r-- 1 kohadev-koha kohadev-koha 399 Aug 30 18:36 zebra-output.log
If you apply this patch, and restart plack and try for an error:
"Log4perl: Seems like no initialization happened. Forgot to call init()?"
Ok that's not great. So look at Koha::Logger - in
119 sub _init {
120 my $rv;
121 if ( exists $ENV{"LOG4PERL_CONF"} and $ENV{'LOG4PERL_CONF'} and -s
$ENV{"LOG4PERL_CONF"} ) {
122
123 # Check for web server level configuration first
124 # In this case we ASSUME that you correctly arranged logfile
125 # permissions. If not, log4perl will crash on you.
126 # We will not parse apache files here.
127 Log::Log4perl->init_once( $ENV{"LOG4PERL_CONF"} );
128 }
129 elsif ( C4::Context->config("log4perl_conf") ) {
130
131 # Now look in the koha conf file. We only check the permissions of
132 # the default logfiles. For the rest, we again ASSUME that
133 # you arranged file permissions.
134 my $conf = C4::Context->config("log4perl_conf");
135 if ( $rv = _check_conf($conf) ) {
136 Log::Log4perl->init_once($conf);
137 return $rv;
138 }
139 else {
140 return 0;
141 }
142 }
143 else {
144 # This means that you do not use log4perl currently.
145 # We will not be forcing it.
146 return 0;
147 }
148 warn "Log4Perl did not crash";
149
150 return 1;# if we make it here, log4perl did not crash :)
151 }
I didn't have any environment variables set in my devbox, so we're looking at
the path from koha-conf.xml.
So we assume "you arranged the file permissions" and something about this
doesn't sit right with me, and probably explains what is happening here.
Anyway, with this patch installed the default way I've done for testing,
apparently _check_conf fails - probably bc koha-kohadev can't write the apache
initialized logs. With the permissions set for owner koha-kohadev:koha-kohadev,
the patch works.
When the log files are initialized, there are some that are set by Apache
(opac-access/error, intranet-access/error) and plack, which is initialized by
Koha. The plack one is owned by the instance, the apache ones are owned by
root. Logrotate will set these permissions back at rotate time.
Does somebody out there know more than me about logrotate and apache, to help
get these permissions doing the right thing? This patch is really necessary
(splitting is nice and stuff, but timestamps alone would be super ace).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #193 from Liz Rea --- Hi, Applied this today with an eye to sign it off, and got a merge conflict :( Applying: Bug 22284: New message, new column and filter pickup locations in reserve/request.tt Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 22284: New message, new column and filter pickup locations in reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23526] New: Shibboleth login url with query has double encoded '?' %3F
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526
Bug ID: 23526
Summary: Shibboleth login url with query has double encoded '?'
%3F
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
In login_shib_url we place an encoded '?' into the login url:
65 if ( $query->query_string() ) {
66 $param = $param . '%3F' . $query->query_string();
67 }
Then in the templates we filter that using the URL filter:
If you have a Shibboleth account, please click here to login.
The URL filter turns the % into %25 and the string comes out as
https://anykoha.bywatersolutions.com/Shibboleth.sso/Login?target=https://anykoha.bywatersolutions.com/cgi-bin/koha/opac-search.pl%253Fq=cats
This returns a 4040 on successful login
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #2 from Owen Leonard --- Created attachment 92510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92510=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #1 from Owen Leonard --- Created attachment 92509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92509=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23525] New: ISBD view uses view policy of ACQ framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525
Bug ID: 23525
Summary: ISBD view uses view policy of ACQ framework
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In staff interface, ISBD view always uses view policy of ACQ framework.
This comes from a change from commit :
Bug 19289: Use the ACQ framework to display bibliographic details
@@ -97,7 +97,7 @@ my $record_processor = Koha::RecordProcessor->new({
filters => 'ViewPolicy',
options => {
interface => 'intranet',
-frameworkcode => $framework
+frameworkcode => 'ACQ'
},
Is this a mistake ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Nick Clemens changed: What|Removed |Added Attachment #92466|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 92508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92508=edit Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #14 from Nick Clemens --- Created attachment 92507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92507=edit Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens changed: What|Removed |Added Attachment #91506|0 |1 is obsolete|| Attachment #91507|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 92506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92506=edit Bug 23007: Add TransfersBlockCirc system preference Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Emma Ternrud changed: What|Removed |Added CC||emma.tern...@ub.gu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #129 from Stefan Berndtsson --- There seems to be a bug in Koha/Hold.pm, set_waiting() where GetReservesControlBranch() is called as a method rather than a function causing the package name to become the first argument. This line: my $controlbranch = C4::Reserves->GetReservesControlBranch( $item, $patron ); Should be: my $controlbranch = C4::Reserves::GetReservesControlBranch( $item, $patron ); ...if I'm not mistaken. The current code causes an error with checkin on the pickup library for the book. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22786] Can create new funds for locked budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 --- Comment #7 from Nick Clemens --- Passing QA here, I don't really like that we can force add a fund, especially since we can do it with no code or name or amount. Hit that a bunch and create lots of new empty funds, then you can edit and add amounts http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?op=add_validate_period_id=1 Opening a new bug 23524 for fact that you can still edit/delete funds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23524] New: Can modify/delete funds for locked budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524 Bug ID: 23524 Summary: Can modify/delete funds for locked budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org What are the allowed actions for a locked budget? Should it be read only? To recreate: 1 - From acqui home click on a budget 2 - Edit the budget and lock it 3 - on admin/aqbudgets.pl notice all funds have an action button 4 - You cannot add, but the button is not disabled 5 - You can modify 6 - You can delete -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22786] Can create new funds for locked budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22786] Can create new funds for locked budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Nick Clemens changed: What|Removed |Added Attachment #92480|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 92505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92505=edit Bug 22786: Prevent fund creation for locked budgets If a budget is locked, there is a "New fund for $budget" link that is disabled but clickable. We should ensure that the link is not clickable and prevent it at controller level (do we need it at module level, ie. Koha::Acquisition::Fund->store?) Test plan: - Create a budget, lock it - Go to /cgi-bin/koha/admin/aqbudgetperiods.pl - Click on the name of the budget you just created => The "New > New fund for $budget_name" button should be disabled - Click it anyway => Without this patch the form to add a new fund is displayed => With this patch applied nothing happens - Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_formbudget_period_id=XXX With XXX the budget's id => Without this patch the form is displayed => With this patch applied you get a message: "The budget is locked, fund creation is not possible." And you are not able to create a new fund QA notes: 1. See description 2. The add_validate op can still be forced, let trust librarians with administration permissions for now. Signed-off-by: Hayley Mapley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #2 from Owen Leonard --- I think we can work within the permissions definitions the staff client enforces right now, and I think you've got it right: - 'place_holds' allows changes to any hold detail except priority - 'modify_holds_priority' allows changes to priority independently of any other detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Nick Clemens changed: What|Removed |Added Attachment #92503|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 92504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92504=edit Bug 23518: Problem with borrower search autocomplete This patch fixes a bug introduced by my patch for Bug 23405: Keyboard navigation of patron autocomplete results was broken because I incorrectly assumed that the autocomplete "select" action was redundant because keyboard navigation would trigger the selected link. It doesn't! This patch adds the "select" action back to the autocomplete configuration, explicitly defining a redirect to match the URL which is followed if the user uses the mouse to click a result. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Making a selection from the autocomplete results should work by clicking with a mouse OR using the arrow keys and TAB or ENTER. - Test with patrons with and without card numbers. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 --- Comment #1 from Owen Leonard --- Created attachment 92503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92503=edit Bug 23518: Problem with borrower search autocomplete This patch fixes a bug introduced by my patch for Bug 23405: Keyboard navigation of patron autocomplete results was broken because I incorrectly assumed that the autocomplete "select" action was redundant because keyboard navigation would trigger the selected link. It doesn't! This patch adds the "select" action back to the autocomplete configuration, explicitly defining a redirect to match the URL which is followed if the user uses the mouse to click a result. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Making a selection from the autocomplete results should work by clicking with a mouse OR using the arrow keys and TAB or ENTER. - Test with patrons with and without card numbers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Alex Arnaud changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #37 from Koha Team Lyon 3 --- Hi, Yes Jonathan, I'm not really fond of the behavior proposed because it changes the current calculation of suspension days for the loan in days. I don't want to block the resolution of this issue, but if we keep the correction proposed, We just have to be aware that we should explain that there's a change and that people have to check their circulation rules if they use the Suspension charging interval. But for the moment, I'm not sure a lot of libraries are using it Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23229] "Get all requests" API call fired when loading any ILL page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229 Fridolin SOMERS changed: What|Removed |Added Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #94 from Katrin Fischer --- (In reply to martha simons from comment #93) > > TypeError: a.aoColumns[c] is https://www.stepcalculator.com/ undefined > > /intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js > > Line 29 Hi Martha, please file a new bug with a step-by-step description on how to get to this error. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 martha simons changed: What|Removed |Added CC||marthasimons9...@gmail.com --- Comment #93 from martha simons --- > TypeError: a.aoColumns[c] is https://www.stepcalculator.com/ undefined > /intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js > Line 29 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
