[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Bob Birchall changed: What|Removed |Added CC||b...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu --- Comment #1 from Myka Kennedy Stephens --- +1 Agreed. I have noticed that the table that generates in the OPAC view adds 'N/A' to the author field. Perhaps the JS for the staff client table could be amended to insert "N/A" when the author field is absent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Owen Leonard changed: What|Removed |Added Version|18.11 |master Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What|Removed |Added Attachment #92592|0 |1 is obsolete|| --- Comment #17 from Hayley Mapley --- Created attachment 92600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92600=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What|Removed |Added Attachment #92593|0 |1 is obsolete|| --- Comment #18 from Hayley Mapley --- Created attachment 92601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92601=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What|Removed |Added Attachment #92594|0 |1 is obsolete|| --- Comment #19 from Hayley Mapley --- Created attachment 92602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92602=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21390] Send self registration verification emails immediately
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 --- Comment #1 from Chris Cormack --- Created attachment 92599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92599=edit Bug 21390 Send registration verification emails immediately To test 1/ Enable self registration 2/ Register, notice message is queued in the table but not sent 3/ Apply patch 4/ Register again, notice message is queued, but immediately sent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21390] Send self registration verification emails immediately
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea changed: What|Removed |Added Assignee|oleon...@myacpl.org |wizzy...@gmail.com CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #218 from Charles Farmer --- Created attachment 92598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92598=edit Bug 17015: Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #217 from Charles Farmer --- Created attachment 92597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92597=edit Bug 17015: Install scripts for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #216 from Charles Farmer --- Created attachment 92596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92596=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #85677|0 |1 is obsolete|| Attachment #85678|0 |1 is obsolete|| Attachment #85679|0 |1 is obsolete|| Attachment #85680|0 |1 is obsolete|| Attachment #85681|0 |1 is obsolete|| Attachment #85682|0 |1 is obsolete|| Attachment #85683|0 |1 is obsolete|| Attachment #85684|0 |1 is obsolete|| Attachment #85685|0 |1 is obsolete|| Attachment #85686|0 |1 is obsolete|| Attachment #85687|0 |1 is obsolete|| Attachment #85688|0 |1 is obsolete|| Attachment #85689|0 |1 is obsolete|| Attachment #85690|0 |1 is obsolete|| Attachment #85691|0 |1 is obsolete|| --- Comment #215 from Charles Farmer --- Created attachment 92595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92595=edit Bug 17015: Performance comparison (images) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #15 from Owen Leonard --- Created attachment 92594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92594=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #16 from Owen Leonard --- Rebased! (In reply to Hayley Mapley from comment #12) > After applying the patch, the header had slightly less left margin/left > padding. My follow-up addresses this. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #14 from Owen Leonard --- Created attachment 92593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92593=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What|Removed |Added Attachment #92207|0 |1 is obsolete|| Attachment #92208|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 92592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92592=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 --- Comment #1 from Kyle M Hall --- Created attachment 92591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92591=edit Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Kyle M Hall changed: What|Removed |Added Summary|.accounttype should match |accountlines.accounttype |authorised_values.authorise |should match |d_value in size |authorised_values.authorise ||d_value in size -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23539] New: .accounttype should match authorised_values.authorised_value in size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Bug ID: 23539 Summary: .accounttype should match authorised_values.authorised_value in size Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Account type is a varchar(16), but the authorised value filling it ( MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to this size to avoid truncation of authorised values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Tomás Cohen Arazi changed: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Holds_priority_en ||dpoint_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Incorrect permission|Add
|requirements for holds |/holds/{hold_id}/priority
|operations via the API |route (PUT)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #7 from Tomás Cohen Arazi ---
My implementation adds the:
PUT /holds/{hold_id}/priority endpoint for setting the priority of a hold. It
uses the same approach rotas endpoint does. And it checks for the very specific
permissions.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 92588
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92588=edit
Bug 23517: Add a spec for PUT /holds/{hold_id}/priority
This patch adds the OpenAPI spec for the endpoint, and tests for the
desired behaviour.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 92590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92590=edit Bug 23517: (follow-up) Tidy tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 92589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92589=edit Bug 23517: Add the controller method for holds priorities handling This patch implements the PUT /holds/:hold_id/priority endpoint To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 --- Comment #2 from Owen Leonard --- Created attachment 92587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92587=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What|Removed |Added Summary|Use use a template block to |Remove obsolete category |output patron categories|markup from patron entry Severity|enhancement |minor --- Comment #1 from Owen Leonard --- I'm repurposing this bug because further investigation shows that the repeated section of markup is in fact obsolete. I will submit a patch to remove the obsolete markup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] New: Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Bug ID: 23538 Summary: Email Library when New Patrons Self Register Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Self Registration is a great feature in the OPAC. However, some libraries find it hard to manage these new registrations and would like to be alerted via email when a new patron self-registers. In the newest version of Koha, 19.05, this feature has been added for Purchase Suggestions, email library when new purchase suggestion is created. It would be great to have this same thing for Self Registration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 --- Comment #1 from Liz Rea --- Created attachment 92586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92586=edit Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23537] New: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Bug ID: 23537 Summary: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Some items from overdrive, such as magazines, don't have a primaryCreator in their object. When Koha gets a result like this, the overdrive search won't show any results after the first to have this condition, because it's trying to push an undefined property. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] New: Use use a template block to output patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Bug ID: 23536 Summary: Use use a template block to output patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 23533, 23534 There are three places in the patron entry template which use the same logic for displaying the patron category. These can be converted into a single re-usable block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 [Bug 23533] Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 [Bug 23534] Use patron-title.inc on patron entry page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What|Removed |Added Blocks||23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What|Removed |Added Blocks||23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What|Removed |Added Attachment #92377|0 |1 is obsolete|| --- Comment #73 from Julian Maurice --- Created attachment 92585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92585=edit Bug 15261: Check reserves while renewing an issue Test plan: - Create an issue (i.e from 15/09/2017 to 04/10/2017), - place a reserve on the same item from 05/10/2017 to 30/10/2017), - enable PreventCheckoutOnSameReservePeriod, - Check that you are not able to renew the issue. Rebased (2018-03-15) Rebased (2019-04-18) Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What|Removed |Added Attachment #92376|0 |1 is obsolete|| --- Comment #72 from Julian Maurice --- Created attachment 92584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92584=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rebased on master (2016-03-11) Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Rebased on master (2019-04-18) Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #1 from Owen Leonard --- Created attachment 92583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92583=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #2 from Owen Leonard --- Created attachment 92582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92582=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #1 from Owen Leonard --- Created attachment 92581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92581=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #7 from Thomas Dukleth --- I successfully changed variables and added some additional conditions to avoid NULL values as necessary from the original form of the Postgres to MySQL conversion script, http://www.winterrodeln.org/trac/browser/servermediawiki/trunk/pgsqltomysql/pgsqltomysql.py . I also added the Postgres schema for the wiki which is "mediawiki", the same as the database name in the case of the Koha Wiki, and not the "public" schema. I should now be reporting that it takes X minutes to run a script to convert the wiki database on my test system, however, there is an error similar to what was found to be SQL statement quotation or comma separation problem addressed at https://stackoverflow.com/questions/41475309/psycopg-error-column-does-not-exist and https://stackoverflow.com/questions/41804213/psycopg2-programmingerror-column-your-name-does-not-exist . I am printing the generated SQL statements to try to trace the problem. I may try using the generated SQL statements directly with suggested quotation to avoid problems where the SQL statements as stored in a variable elude what may be needed quotation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #39 from Julian Maurice --- Patches rebased on master. Removed two patches because a similar fix was pushed in bug 22142 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #38 from Julian Maurice --- Created attachment 92580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92580=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What|Removed |Added Attachment #91575|0 |1 is obsolete|| Attachment #91576|0 |1 is obsolete|| Attachment #91577|0 |1 is obsolete|| Attachment #91578|0 |1 is obsolete|| --- Comment #37 from Julian Maurice --- Created attachment 92579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92579=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > (In reply to Jonathan Druart from comment #4) > > I am wondering if we should not retrieve the list of itemtypes for which the > > holds are allowed, then use them in the WHERE clause. > > It will make the query more readable and we will remove a LEFT JOIN. What do > > you think? > > That makes some sense, but will be two queries instead of one? In either > case I think we should fix this now and re-engineer this report on another > bug +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #5 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > I am wondering if we should not retrieve the list of itemtypes for which the > holds are allowed, then use them in the WHERE clause. > It will make the query more readable and we will remove a LEFT JOIN. What do > you think? That makes some sense, but will be two queries instead of one? In either case I think we should fix this now and re-engineer this report on another bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
