[Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

Theodoros Theodoropoulos  changed:

   What|Removed |Added

 CC||th...@lib.auth.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589

--- Comment #11 from Theodoros Theodoropoulos  ---
Indeed, I can verify that I'm using plack too.

The new bug sounds a bit (more) critical... Although the fix would be fairly
straight forward (replacing exit with safe_exit), identifying where is needed
and testing that the patch does the trick might be tricky...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] Toolbars and toolbar buttons should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

--- Comment #1 from Hayley Mapley  ---
Created attachment 93507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93507=edit
Bug 23724: Added IDs to Cataloging toolbar and buttons

Test plan:
Check that the buttons or div buttons now have IDs which will allow the
buttons to be hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] Toolbars and toolbar buttons should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

Hayley Mapley  changed:

   What|Removed |Added

Summary|Toolbars should have|Toolbars and toolbar
   |distinct IDs|buttons should have
   ||distinct IDs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] Toolbars should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

Hayley Mapley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] Toolbars should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

Hayley Mapley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23708

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] Toolbars should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

Hayley Mapley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n
   |ity.org |z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708

Hayley Mapley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23724

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23724] New: Toolbars should have distinct IDs

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724

Bug ID: 23724
   Summary: Toolbars should have distinct IDs
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hayleymap...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

The Cataloguing and Serials toolbars both have the ID of toolbar. 
IDs should be distinct to allow for easier styling.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23543] Adding withdrawn to the item search

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #93500|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 93506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93506=edit
Bug 23543: Adding Withdrawn to the Item Search

This patch adds "Withdrawn" status to the item search form and item
search results.

To test you should have one or more items in your catalog which have a
'Withdrawn' status.

Perform an item search and limit to a widthdrawn status. Verify that the
search returns the correct results and that the withdrawn column in
search results shows the correct information.

Test the "Export results to CSV" button. The resulting file should
contain the correct data, including withdrawn status.

Signed-off-by: joe 

Signed-off-by: David Roberts 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654

--- Comment #8 from David Cook  ---
(In reply to Chris Nighswonger from comment #7)
> 
> I'd look at the unit conversion code first to see if there's something going
> on there. Beyond that, I'm not sure what to suggest as it still works in the
> library here.

Yeah, I think I probably won't work on this, as I just did a workaround to get
the cards to display as desired. I don't have a lot of libraries using patron
cards, especially with images, so not too much of a priority over here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075

Martin Renvoize  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff
   Keywords|rel_19_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Martin Renvoize  ---
This all looks reasonable and sane to me at this point and I don't believe it
leads to any breaking changes.

Passing QA, please go ahead and merge it into the project at your convenience
Alex.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

--- Comment #15 from Martin Renvoize  ---
Works well, thanks Jonathan. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #13 from Martin Renvoize  ---
This looks solid to me, I've noted Marcelr's comment but believe we're safe
here given the responses and a look at the code myself..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Martin Renvoize  ---
All works as expected, a great first patch Björn, Signing off.

The bug states it's sponsored, could we get the sponsor name so we can add it
to the patch for proper attribution?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Attachment #78630|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93504|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

--- Comment #4 from Martin Renvoize  ---
Created attachment 93505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93505=edit
Bug 21343: Respect patron language preference in automtic renewals

To test:
1) Set up different automatic renewal notices for Default and one other
language
2) Make sure you have checkouts due for auto-renewal to patrons with
non-Default language pref
3) Run automatic_renewals.pl . All patrons will get the default-language notice
4) Apply patch.
5) Repeat 2)
6) Run automatic_renewals.pl . Patrons will receive notices according to their
language preference.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

--- Comment #7 from Christopher Brannon  ---
Perhaps a branch field and a borrower field could be added.  If the field is
empty, it applies to everyone.  Otherwise, it would be limited to matching
borrower IDs or branches.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343

--- Comment #3 from Martin Renvoize  ---
Created attachment 93504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93504=edit
Bug 21343: Automatic renewal notice will now respect patron language
preference.

To test:
1) Set up different automatic renewal notices for Default and one other
language
2) Make sure you have checkouts due for auto-renewal to patrons with
non-Default language pref
3) Run automatic_renewals.pl . All patrons will get the default-language notice
4) Apply patch.
5) Repeat 2)
6) Run automatic_renewals.pl . Patrons will receive notices according to their
language preference.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

--- Comment #6 from Christopher Brannon  ---
(In reply to Daniel Gaghan from comment #4)
> Having the ability to limit who can see which reports would help a lot at
> PCCLD. It would certainly clean up the report module and make relevant
> reports easier for staff to find.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

--- Comment #5 from Christopher Brannon  ---
(In reply to Cab Vinton from comment #3)
> Would also be nice to limit access to reports by the home library of the
> staff.
> 
> Some reports are specific to the needs of just one library. Some reports are
> in development for a while. And so on.
> 
> As reports proliferate over time, libraries would welcome any option that
> reduces the number of reports visible to them.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize  ---
It would be great to get an answer to the above Johanna, I'm very interested to
know whether this bug is resolved for you with that alternative implementation
or whether we still need to work here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #4 from Martin Renvoize  ---
I've checked out the branch (and rebased it to check it still applies simply).

All seems to work well, no obvious regressions.. signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654

--- Comment #7 from Chris Nighswonger  ---
(In reply to David Cook from comment #6)
> Actually, after I changed my Images data that's caused the X/Y axis for my
> Text fields to completely change. 
> 
> I'd say there's a number of factors regarding units that are wrong here...

Just FTR:

1. A lot of code has run off of the keyboard since I wrote this stuff over nine
years ago, so there may be changes I'm unaware of and resulting bugs.

2. There may indeed be something buggy about the unit conversion code that I
originally wrote. The library I did the work for uses Imperial units and that
was my focus. I would definitely check there first. Everything is converted to
post script points.

3. The fundamental coordinate system is taken from the PDF ISO 32000-1 standard
published by Adobe and has its origin at the lower left corner of the page. In
other terms, the page is the first quadrant of the Cartesian Coordinate system.

I'd look at the unit conversion code first to see if there's something going on
there. Beyond that, I'm not sure what to suggest as it still works in the
library here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Tomás Cohen Arazi  ---
We need tests for the behavior.
Also, we shouldn't fallback to undef. Just return bad request explaining what
went wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631

Daniel Gaghan  changed:

   What|Removed |Added

 CC||daniel.gaghan@pueblolibrary
   ||.org

--- Comment #4 from Daniel Gaghan  ---
Having the ability to limit who can see which reports would help a lot at
PCCLD. It would certainly clean up the report module and make relevant reports
easier for staff to find.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

Dobrica Pavlinusic  changed:

   What|Removed |Added

Summary|using exit to stop sending  |using exit inside eval to
   |output to browser doesn't   |stop sending output to
   |work under plack|browser doesn't work under
   ||plack

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

--- Comment #1 from Dobrica Pavlinusic  ---
Problem occurs only if we use exit inside eval block like:

eval {
warn "in eval";
exit;
};
warn "after eval";

Under CGI, this would print just "in eval". Bacause of interaction of
CGI::Compile which wraps system exit under plack we get both lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

--- Comment #2 from Michal Denar  ---
Hello Nick,
can you rebase this patch on master?

CONFLICT (content): Merge conflict in
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23676: Use 'false' for opac suppression


Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5630] CAS improvements

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630

Dobrica Pavlinusic  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23723

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

Dobrica Pavlinusic  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5630

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589

Dobrica Pavlinusic  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23723

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

Dobrica Pavlinusic  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23589

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23723] New: using exit to stop sending output to browser doesn't work under plack

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

Bug ID: 23723
   Summary: using exit to stop sending output to browser doesn't
work under plack
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dpav...@rot13.org
QA Contact: testo...@bugs.koha-community.org

When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending
headers and html after pdf output to browser. It seems that using just exit
isn't enough to stop plack from generating headers and html page. This was
noticed back in 2011 with Bug 5630 which added safe_exit in C4::Auth. It seems
that we need to use something similar throughout all code which gets invoked
with plack to fix this.

I'm opening this bug as placeholder until I do more testing and figure out
which parts need change and we have a lot of exit; in code:

git grep 'exit;' | wc -l
352

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589

--- Comment #10 from Dobrica Pavlinusic  ---
I can confirm that this is plack problem. If I implement something similar to
safe_exit in C4::Auth it doesn't emit extra html after pdf.

However, this is not the only place where we have exit and while some code
flows would exit anyway (since under plack exit doesn't work) I'm sure we have
more places in code which should be fixed (ater redirects is one obvious one --
it would seem to work, but we are probably sending Location: header and whole
html after it).

This will have to be another bug since it will touch many places and isn't
really related to this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Liz Rea  changed:

   What|Removed |Added

  Attachment #93502|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 93503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93503=edit
Bug 23722 - Document allow_empty_passwords in the example SIP config file

The example SIP config file in Koha is kind of a kitchen sink document where
all available SIP2 options should be demonstrated.
The allow_empty_passwords flag should be included in it.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Charles Farmer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #14 from Charles Farmer  ---
> This is much better handled at the template level. We don't want to give 
> syspref permissions to the volunteer who prints labels.

But I'm not asking you to, I'm saying that most libraries we work with have a
systematic approach to printing barcodes. They configure it once and forget
about it, I don't understand which use case you're describing where every
barcode printed has to be padded differently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

--- Comment #1 from Kyle M Hall  ---
Created attachment 93502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93502=edit
Bug 23722 - Document allow_empty_passwords in the example SIP config file

The example SIP config file in Koha is kind of a kitchen sink document where
all available SIP2 options should be demonstrated.
The allow_empty_passwords flag should be included in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||23722


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722
[Bug 23722] Document allow_empty_passwords in the example SIP config file
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||18755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
[Bug 18755] Allow empty password fields in Patron Info requests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23722] New: Document allow_empty_passwords in the example SIP config file

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722

Bug ID: 23722
   Summary: Document allow_empty_passwords in the example SIP
config file
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

The example SIP config file in Koha is kind of a kitchen sink document where
all available SIP2 options should be demonstrated. The allow_empty_passwords
flag should be included in it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589

--- Comment #9 from Dobrica Pavlinusic  ---
(In reply to Theodoros Theodoropoulos from comment #5)
> Hi Dobrica,
> 
> Thanks for your patch! Indeed it fixes the output. I will try to properly
> sign it off later.
> 
> Having said that, there I'm now at 18.11 and there is another issue (that
> exists regardless of your patch). The generated pdf file in /tmp/ is proper
> pdf, the one that gets downloaded when I click discharge is CORRUPTED (has
> html code appended in the bottom of the pdf file). Did you also have this
> issue?

You are absolutely right. We indeed emit html (and headers) after pdf. I never
noticed this before. This is on 19.05 for me. However, on current master I
don't see anything after pdf. I thinks this is difference in configuration and
not versions. 19.05 for me (with html junk) is running via plack while my
development is plain cgi. Are you also running plack?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21114] Select multiple item rows with Ctrl+click and Shift+click

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21114

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

--- Comment #1 from Sarah Cornell  ---
I just had a staff request this feature.  Best case scenario, we'd like to be
able to select groups of items or patrons wherever this style of list occurs,
not just in the batch item modification tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706

--- Comment #11 from David Roberts  ---
Actually, it looks like this might have already been fixed in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706

--- Comment #10 from David Roberts  ---
That looks like it's trying to apply an obsolete patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23697] Auto complete for patron search in patron module

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697

--- Comment #4 from Katrin Fischer  ---
After discussing with Owen, I think it would be best if we use the pref for
this as well and update the wording of the pref a little bit to cover both.

Matts, could you provide a follow-up please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23697] Auto complete for patron search in patron module

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||oleon...@myacpl.org

--- Comment #3 from Katrin Fischer  ---
This works fine!

Just have a little 'but': For the patron auto-complete we got a system
preference to turn the feature off: CircAutocompl

So my question would be: Should we also use this pref here? Does it need a
pref?

I am setting 'Failed QA' - let's discuss this quickly tomorrow. Also adding
Owen in CC as he might know about the reasoning behind the pref in circulation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23611] Add export option to authorized values administration

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611

--- Comment #5 from Owen Leonard  ---
Created attachment 93501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93501=edit
Bug 23611: (follow-up) Correct ID of table

The DataTable configuration wasn't working on the table showing an
individual category's authorized values because of a mismatch in the
table id. This patch corrects it.

To test, apply the patch and view the "Authorized values" page.

The initial list of categories should be displayed as a DataTable. Click
through to see the values defined for any category. The resulting table
of values should also be a functioning DataTable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23611] Add export option to authorized values administration

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23697] Auto complete for patron search in patron module

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|autocompletion search in|Auto complete for patron
   |patron module   |search in patron module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Katrin Fischer  ---
Wondering: If is translates to "like", should "not" not translate to "not
like"? Currently it will be != which doesn't allow for truncation.

Example would be a search for: Title does not contain a certain keyword.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #36 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 23626:
Something went wrong !Applying: Limit memory consumption when
exporting, too
fatal: sha1 information is lacking or useless
(installer/data/mysql/atomicupdate/bug_23626.perl).
error: could not build fake ancestor
Patch failed at 0001 Limit memory consumption when exporting, too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23543] Adding withdrawn to the item search

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93163|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 93500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93500=edit
Bug 23543: Adding Withdrawn to the Item Search

This patch adds "Withdrawn" status to the item search form and item
search results.

To test you should have one or more items in your catalog which have a
'Withdrawn' status.

Perform an item search and limit to a widthdrawn status. Verify that the
search returns the correct results and that the withdrawn column in
search results shows the correct information.

Test the "Export results to CSV" button. The resulting file should
contain the correct data, including withdrawn status.

Signed-off-by: joe 

Signed-off-by: David Roberts 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23543] Adding withdrawn to the item search

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23543] Adding withdrawn to the item search

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543

Katrin Fischer  changed:

   What|Removed |Added

Summary|Adding Withdrawn to the |Adding withdrawn to the
   |Item Search |item search
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #180 from Séverine Queune  ---
Created attachment 93499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93499=edit
Buttons difference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23711] Icons on staff main page should be font icons

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711

--- Comment #13 from Owen Leonard  ---
Created attachment 93498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93498=edit
Bug 23711: Fix bad path

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23711] Icons on staff main page should be font icons

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711

--- Comment #12 from Owen Leonard  ---
Created attachment 93497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93497=edit
Bug 23711: Change icons and remove unused SVG

Signed-off-by: Fridolin Somers 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||laurence.ra...@biblibre.com

--- Comment #18 from Laurence Rault  ---
Applying: Bug 18745: kohastructure.sql: Move aqbooksellers above serial
Applying: Bug 18745: Add foreign key constraint on subscription.aqbooksellerid
fatal: sha1 information is lacking or useless (C4/Serials.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 18745: Add foreign key constraint on
subscription.aqbooksellerid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23711] Icons on staff main page should be font icons

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711

Owen Leonard  changed:

   What|Removed |Added

  Attachment #93479|0   |1
is obsolete||
  Attachment #93480|0   |1
is obsolete||
  Attachment #93481|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 93496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93496=edit
Bug 23711: Icons on staff main page should be font icons

Signed-off-by: Fridolin Somers 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||severine.que...@bulac.fr

--- Comment #179 from Séverine Queune  ---
On step 6 : when I edit the rule, the "Preset" field comes back to the first
value "Custom" : I think it's a disturbing and the value registred should be
kept.

On step 7 : there are gaps into the buttons, like if icons where missing, and
they don't seem to have the same css (can send a screenshot if needed).
Behaviours of both buttons are correct.

On step 13 : once the rule is saved, the filter displays "intranet" but when
creating the rule, it's "Staff client MARC editor". Maybe it should be
uniformised ?

Tested using a sandbox so can't run tests on step 15.

Hope this feedback will be helpfull !
Except these points, the feature works fine and will be very useful !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710

--- Comment #20 from Christopher Brannon  ---
Please push this to stable and old stable.  I consider this a critical bug that
can do damage in mass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18783] Allow automatic claims for serials

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||laurence.ra...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23715] Batch item modification sets a value in incorrect field

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23715

--- Comment #3 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #2)
> Hi Christopher, we just fixed a bug like this (waiting for Rmaints
> currently): bug 18710. Marking duplicate, please check and change back if I
> am mistaken!
> 
> *** This bug has been marked as a duplicate of bug 18710 ***

Yep, that's the culprit.  Hope they will backport it.  I consider it critical
since it will do unwanted things to mass records.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 93495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93495=edit
Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service

Actually, the GetRecords service gives many information :
bibliographic data (marcxml field)
item data (items field)
issue data (issues field)

The issue data should not be sent by these service, its a privacy problem.
Biblio title and author are redundant.
This patch changes to use Koha::Checkouts to get issues informations with only
the addition of item barcode.

Test plan :
1) Enable ILS-DI webservice
2) Checkout an item
3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords={biblionumber}
4) Check the issues tag content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #91 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 14715:
Something went wrong !Applying: Bug 14715: results per page setting
for catalog search
Using index info to reconstruct a base tree...
M   C4/Search.pm
M   catalogue/search.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
M   opac/opac-search.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
CONFLICT (content): Merge conflict in opac/opac-search.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
Auto-merging catalogue/search.pl
CONFLICT (content): Merge conflict in catalogue/search.pl
Auto-merging C4/Search.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14715: results per page setting for catalog search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816

--- Comment #4 from Nick Clemens  ---
Created attachment 93494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93494=edit
Bug 20816: Make SIP tests pass under ES

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816

Nick Clemens  changed:

   What|Removed |Added

  Attachment #90813|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 93493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93493=edit
Bug 20816: Add ability to define custom templated fields in SIP patron
responses

To test:
 1 - You will need to enable SIP on your testing instance
cp etc/SIPconfig.xml /etc/koha/sites/kohadev/
sudo koha-start-sip
add a user listed in the SIPconfig to your system and give them permissions
(superlibrarian works)
 2 - If you copied the above file you should be set to get custom field DE with
dateexpiry
 3 - send a status test using the sip cli tester:
 perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp
xyzzy -l LPL --patron nick -m patron_status_request
 4 - send an information test using the sip cli tester:
 perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp
xyzzy -l LPL --patron nick -m patron_information
 5 - confirm you receive the DE field with a dateexpiry
 6 - Add your own custom fields and confirm it works with several
 7 - prove -v t/db_dependent/SIP/Patron.t
 8 - prove -v t/db_dependent/SIP/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93374|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 93492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93492=edit
Bug 18084: Language selector hidden in user menu on mobile interfaces

This patch updates templates and CSS so that the language-selection menu
in the header will not be hidden if the browser width is too narrow.

This patch also makes some more general improvements to the responsive
adaptability of the header elements.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test the changes by viewing pages in the OPAC and adjusting your browser
width, paying attention to how elements in the top menu adapt to
different sizes. Test under varying conditions:

 - Logged in/not loggeed user
 - Search history enabled and disabled
 - OpacLangSelectorMode showing menu in header or not
 - opacuserlogin enabled or disabled

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14669] Search orders by managing library

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669

Alex Sassmannshausen  changed:

   What|Removed |Added

 CC||a...@komputilo.eu
 Status|Needs Signoff   |Failed QA

--- Comment #13 from Alex Sassmannshausen  ---
Tests pass, but filtering does not seem to work.

I've created baskets with orders.  One is managed by centerville the other by
none.

Standard search returns both results, but search filtered by managed by
centerville also returns both.  I would expect to only return those managed by
centerville.

Managing library is also not displayed in the basket overview datatable.

Hth,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add desk management

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #25 from Séverine Queune  ---
I notices several problems :
 - the creation form make me think I can choose the desk ID, but I can't : it
has to be a number. If I write something else, it's replaced.
 - if I delete a desk and then create a new one, I can re-use the desk ID of
the deleted desk. I don't know if it can lead to problems linking datas, but to
me, it's seems a curious behaviour.
 - if I create a new desk using, by mistake, an existing desk ID, it updates
the existing desk.

My conclusion is that desk ID should not be an editable field.

Except these points, it works fine :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||severine.que...@bulac.fr

--- Comment #9 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 23706:
Something went wrong !Applying: LLP: Bug 23706
Using index info to reconstruct a base tree...
M  
koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
error: Failed to merge in the changes.
Patch failed at 0001 LLP: Bug 23706

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710

--- Comment #10 from Agustín Moyano  ---
Created attachment 93491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93491=edit
Bug 23710: (follow-up) Human readable error messages in request.tt, check
AllowHoldPolicyOverride and AllowHoldDateInFuture in Koha::REST::V1::Holds.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Alex Sassmannshausen  changed:

   What|Removed |Added

 CC||a...@komputilo.eu
 Status|Needs Signoff   |Failed QA

--- Comment #14 from Alex Sassmannshausen  ---
Hi Nick,

As discussed, I'm failing this because of an error on the Shift-Ctrl-{C,X}
keyboard shortcuts.  When they are used, console logs errors that curCursor is
not a function.

Also, as a suggested improvement, possibly addressing some of the useability
issues raised, it'd be amazing if any cut or copy operation resulted in the
latest item in the clipboard being selected immediately.

This would allow users to cut/copy & paste fields and subfields quickly without
having to switch to the mouse to select the last copied/cut content and then
focusing on the right location in the editor again.

Hth,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686

--- Comment #4 from Katrin Fischer  ---
Created attachment 93490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93490=edit
Bug 23686: (QA follow-up) Fix updatedatabase and make descriptions consistent

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93203|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 93489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93489=edit
Bug 23686: Check onsite checkout when the last checkout was an onsite one

Prevent from checking again and again the onsite checkout box when
doing onsite checkouts in batches. If preceding checkout was an onsite
one, the box will be checked.

Test plan:

1. enable  OnSiteCheckouts
2. make your circulation rules able to checkout onsite
3. onsite checkout a document
4. you should return to the checkout page, the box isn't checked
5. apply patch
6. updatedatabase.pl
7. redo steps 3, it should again print a checkout page with an
   unchecked onsite checkout box
8. enable  OnSiteCheckoutAutoCheck system preference
9. redo step 3
10. when returning to the checkout page, the onsite checkout box
should be already checked

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706

--- Comment #2 from Magnus Enger  ---
So let me just repeat that I think integration with the Norwegian national
patron database is the main point of this patch, and that testing for
regressions should be sufficient to sign off. 

The password checking is a nice side effect, but it can and should be extended
and improved in some other bug than this.

And yes, this makes it possible to create a plugin that steals passwords. But I
think plugins are pretty powerfull already, and we should always inspect the
contents of plugins before we install them. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706

--- Comment #1 from Magnus Enger  ---
Created attachment 93488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93488=edit
Bug 22706 - Add plugin hooks for Norwegian national patron database

The main point of this patch is to make it possible to integrate Koha
with the Norwegian national patron database. Code for this was earlier
introduced in Bug 11401 and removed again in Bug 21068.

To test this is mainly a question of spotting regressions, it should
still be possible to set and change a password in all possible ways:
- Setting a password for a new user
- Changing a password in the staff client
- Changing a password in the OPAC
If these work as expected, everything should be OK.

A nice side effect of this work is that it will allow for plugins that
validate passwords. I have created a tiny plugin that enforces PIN
codes of 4 digits. (Yeah, I know, those are the worst passwords, but
some libraries do require them.) It is published here:
https://github.com/Libriotech/koha-plugin-pin
To test this way, install the plugin and try to change the password
of an exsisting user to something that is not a 4 digit PIN. You
should get an error that says "The password was rejected by a plugin".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816

Jesse Maseto  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #2 from Jesse Maseto  ---
Patch does not apply. Merge conflicts.

Using index info to reconstruct a base tree...
M   C4/SIP/ILS/Patron.pm
M   C4/SIP/Sip.pm
M   C4/SIP/Sip/MsgType.pm
M   etc/SIPconfig.xml
Falling back to patching base and 3-way merge...
Auto-merging etc/SIPconfig.xml
CONFLICT (content): Merge conflict in etc/SIPconfig.xml
Auto-merging C4/SIP/Sip/MsgType.pm
CONFLICT (content): Merge conflict in C4/SIP/Sip/MsgType.pm
Auto-merging C4/SIP/Sip.pm
Auto-merging C4/SIP/ILS/Patron.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20816: Add ability to define custom templated fields
in SIP patron responses
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20816-Add-ability-to-define-custom-templated-f-a8rxuw.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23721] New: Names of exported basketgroup files should be uniformised

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721

Bug ID: 23721
   Summary: Names of exported basketgroup files should be
uniformised
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

When exporting a basket group, the names of the files are different depending
on the format chosen : if pdf, the aqbasketgroup.name is used ; if csv, it's
the aqbasketgroup.id.
I think it would be clearer for the users if names could be the same.
My preference goes to the aqbasketgroup.name as it's the name chosen by
librarians to ease acquisition management.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23720] Add div wrapper to search results to make moving cover images easier

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720

Lucas Gass  changed:

   What|Removed |Added

Summary|Move cover images to the|Add div wrapper to search
   |left side of results page   |results to make moving
   ||cover images easier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >