[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #6 from Katrin Fischer --- Created attachment 93906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93906=edit Bug 23762: Editing is_html status of email template fails under multi-languages To test: 1.Enable multi-languages 2.Set the preference 'TranslateNotices' on 'Allow' 3.Go to: tools==>Notices & slips==>Edit (one notice) 4.Click on the "Email" in the Default, uncheck the checkbox for 'HTML Messages'. 5.Save 6.Reopen the notice, nothing changed. 7.Apply the patch 8.Repeat the steps 4 and 5 9.Success. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #5 from Katrin Fischer --- Ok... it cannot be unchecked it seems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > Actually, it should be: Don't use default, but any other. I can see the > issue when picking German. Actually no, this happens with and without the patch if no subject and text is entered. I am sorry, I can't replicate the problem :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #3 from Katrin Fischer --- Actually, it should be: Don't use default, but any other. I can see the issue when picking German. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Bin, I tested this according to your test plan, but the HTML checkbox saves correctly for me on master. Can you please check your test plan again? What I did: - Edit MEMBERSHIP_EXPIRY - Pick default tab - Check checkbox for HTML - Save - Reopen - Checkbox was saved (patch wasn't applied) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer changed: What|Removed |Added CC||ma...@pobox.com --- Comment #9 from Katrin Fischer --- *** Bug 23782 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23782] Adding new item after MARC import closes tab on Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23782 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Mark, I think this is a duplicate to bug 23680 that has just been pushed to master and should be checked by Release Maintainers for backporting soon. *** This bug has been marked as a duplicate of bug 23680 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #188 from David Cook --- (In reply to Ere Maijala from comment #184) > That's because the escaped characters have a special meaning at least in > Elasticsearch, and unless we escape these characters in ES query builder, > they need to be accounted for here. Otherwise ES would balk e.g. trying to > parse [something] as a range. > A that's good to know. I thought it was passing the data straight to Zebra, so I was confused why we'd be mangling the data. What you say makes more sense. > I'd be happy to provide some documentation on a wiki page, if that'd be > useful. In the long run this may be used by quite many since it provides > Z39.50 and SRU on top of Elasticsearch, which would otherwise require > running Zebra. Yes please :). I didn't see any references to Elasticsearch in the patches I viewed. I thought it required Zebra to be used. I must've missed the "Add support for SRU and Elasticsearch" patch now that I look again... hehe. It would be great to use this instead of Zebra in that context! I was groaning at the idea of storing MARCXML in MySQL and indexing it into *both* Elasticsearch and Zebra just to get Z39.50 functionality... Nice one, Ere! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #12 from David Nind --- That's awesome! Thanks Thomas for all your work on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #1 from Aleisha Amohia --- Created attachment 93905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93905=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||23781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 [Bug 23781] SMS and messaging preferences for recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Bot changed: What|Removed |Added Attachment #90762|0 |1 is obsolete|| --- Comment #40 from Nightly Build Bot --- Created attachment 93904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93904=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23782] New: Adding new item after MARC import closes tab on Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23782 Bug ID: 23782 Summary: Adding new item after MARC import closes tab on Firefox Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ma...@pobox.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I recently upgraded our Koha from 18.11 to 19.05, and the following problem showed up: when attempting to add a new item for a bib record from an imported MARC record, the new item page briefly shows up, then closes the tab. I have observed this in Firefox 69.0.1 on Linux Mint as well as Pale Moon. Here's how to get this to happen: Use "Stage MARC for import" and "Staged MARC management" to import a MARC record. Make sure to tell Koha NOT to process item data. Once the record has been imported and the "Staged MARC management" page is showing the table containing the record summary, click on the record number in the rightmost column of the table. This should open a new tab showing the catalog details for the new bib record. Select "New item" from the "New" button at the top of the page. The new item form will show for a fraction of a second, but then the tab will close. I'm fairly sure this behavior didn't occur in 18.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] New: SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Bug ID: 23781 Summary: SMS and messaging preferences for recalls Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Add the option for users to receive notices by SMS for recalls. This requires adding recalls to messaging preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Could we have a regression test for this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #3 from Katrin Fischer --- Note: I can only see the problem, if I add something to a translated template first. Then with turning off the pref, this tab will remain in the list, so you end up with 2 email tabs and can't see which language it is anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #93887|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #2 from Katrin Fischer --- Created attachment 93903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93903=edit Bug 23765: After TranslateNotices is set to 'Don't allow', email settings still show multiple languages To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit ,the template still shows all the languages. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 Katrin Fischer changed: What|Removed |Added Severity|minor |enhancement CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Cori, the matching rules are fully configurable. The ones you listed below are just some samples that Koha adds out of the box as sample data during instalation. Have you tried adding your own? The only tricky bit is knowing the index name. I found this helpful: https://bywatersolutions.com/news/match-points-in-koha I am changing to enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14239] Bibframe support in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 John Sterbenz changed: What|Removed |Added CC||jster...@umich.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 Katrin Fischer changed: What|Removed |Added Attachment #93871|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 93902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93902=edit Bug 23778: Regression: Guarantor entry section no longer has a unique id This patch adds back a fieldset ID which was accidentally removed by Bug 14570: This ID is important if libraries want to customize the patron entry page to hide the guarantor section. To test, apply the patch and go to Patrons -> New patron. Inspect the markup and look at the fieldset labeled "Guarantor information." It should have the correct ID attribute. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #93900|0 |1 is obsolete|| --- Comment #163 from Bin Wen --- Created attachment 93901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93901=edit Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first indicator value of new headings saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 --- Comment #3 from Myka Kennedy Stephens --- *** Bug 19238 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19238] CORPO_NAME authority file ignores first indicator of new headings saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19238 Myka Kennedy Stephens changed: What|Removed |Added Resolution|--- |DUPLICATE CC||mkstephens@lancasterseminar ||y.edu Status|NEW |RESOLVED --- Comment #1 from Myka Kennedy Stephens --- This is related to the same problem reported for personal name headings in Bug 19237 *** This bug has been marked as a duplicate of bug 19237 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first indicator value of new headings saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu Status|CLOSED |REOPENED Resolution|WORKSFORME |--- --- Comment #2 from Myka Kennedy Stephens --- I am seeing this behavior in 18.11. System generated authority records do not save values in the MARC21 indicators. When linking to a system-generated authority, the indicator in the bibliographic record gets overwritten by the indicator from the authority record. To replicate: 1. Identify a system-generated authority record for personal name or corporate name 2. Note that the indicator fields are empty (##) 3. Create a new bibliographic record 4. Enter the heading in a 100 1- or 110 2- field as appropriate 5. Click the authority search tool to find the system-generated heading you want to link to 6. Choose the authority record identified in step 1 7. Note that the indicator you entered in the field (a 1 in a 100 or 2 in 110) is now missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602
--- Comment #14 from Katrin Fischer ---
Augustin, can you please have a look at bug 23602? It looks like this patch set
broke the display of the item type in the table.
This part in the template does no longer seem to work:
[% UNLESS Koha.Preference('noItemTypeImages') %]
[% SET image_location =
itemtype.image_location('intranet') %]
[% IF image_location %][% ELSE %][% END %]
[% END %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #93856|0 |1 is obsolete|| --- Comment #162 from Bin Wen --- Created attachment 93900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93900=edit Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes Signed-off-by: Hayley Mapley Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23772] Itemtype icons not showing in table and not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #2 from Katrin Fischer --- Quite some detective work there! Should we split this into 2 separate bugs then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer changed: What|Removed |Added Attachment #93861|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #25 from Katrin Fischer --- Created attachment 93899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93899=edit Bug 17179: (follow-up) Add to keyboard_shortcuts.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer changed: What|Removed |Added Attachment #93858|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 93898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93898=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer changed: What|Removed |Added Attachment #93857|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 93897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93897=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927
Katrin Fischer changed:
What|Removed |Added
Attachment #93355|0 |1
is obsolete||
--- Comment #4 from Katrin Fischer ---
Created attachment 93896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93896=edit
Bug 22927: Do not check an already lost item when marked as withdrawn or
damaged
Due to how moredetail.pl was written it was hard to know which action
was triggered.
Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned
Note for QA: Maybe we could have just tested if exists
$item_changes->{'itemlost'}
to call LostItem
Signed-off-by: Claudie Trégouët
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Attachment #93890|0 |1 is obsolete|| --- Comment #13 from Josef Moravec --- Created attachment 93895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93895=edit Bug 23770: (follow-up) Use ->to_api in /cities This patch aims to prove the behaviour does not differ. So you can run the tests for the endpoints, and the behaviour remains. The mappings and methods cannot be removed until $c->objects->search is fixed to make use of them as well. That will happen once all used Koha::Object-based classes implement the mappings. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Attachment #93883|0 |1 is obsolete|| --- Comment #11 from Josef Moravec --- Created attachment 93893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93893=edit Bug 23770: Unit tests This patch introduces tests for the new to_api method introduced in Koha::Object(s). It uses Koha::City as a sample for simplicity. And it also uses Koha::Illrequests to test the case in which there's no to_api_mapping method defined on the class, to highlight that a fallback to calling TO_JSON is done. [1] [1] This is done under the assumption Illrequests controller code doesn't use any kind of mapping as the rest of the API controllers do, so there's little chance it would be added in a future. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t \ t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Attachment #93888|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 93894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93894=edit Bug 23770: (follow-up) Add tests for Koha::Objects->TO_JSON Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Attachment #93882|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 93892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93892=edit Bug 23770: Add to_api_mapping method to Koha::City Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Josef Moravec changed: What|Removed |Added Attachment #93881|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 93891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93891=edit Bug 23770: Add Koha::Object(s)->to_api method Generic method that changes the attribute names of an object in the presence of the to_api_mapping method. It otherwise falls back to returning the TO_JSON output. This is WIP submitted early for scrutiny. Tests and example usage in an API controller coming. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com --- Comment #9 from Michal Denar --- Any test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 93890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93890=edit Bug 23770: (follow-up) Use ->to_api in /cities This patch aims to prove the behaviour does not differ. So you can run the tests for the endpoints, and the behaviour remains. The mappings and methods cannot be removed until $c->objects->search is fixed to make use of them as well. That will happen once all used Koha::Object-based classes implement the mappings. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18893] The dateformat sys pref not used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- > Batch item modification - after entering barcodes the second screen shows > date formats as 2017-07-03 This matches the item edit screen where dates are also displayed in ISO format. In fact I think that in most cases where Koha loops over an arbitrary set of MARC subfields we can't format dates because there's no easy way to identify which column will contain date data. > Also the specific due date helper in checkout displays the chosen date in a > different format. This has been fixed in later versions. While this bug is only half-fixed, there is another bug which covers the first issue: Bug 11500. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17482] Untranslatable "Machine generated authority record" (Marc field 667$a)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17482 Owen Leonard changed: What|Removed |Added Severity|enhancement |normal --- Comment #1 from Owen Leonard --- In Biblio.pm: 571 $marcrecordauth->insert_fields_ordered( 572 MARC::Field->new( 573 '667', '', '', 574 'a' => "Machine generated authority record." 575 ) 576 ); Looks like it dates back to 2011 and Bug 7284. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15308] Suggested new interface for item type translation process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 --- Comment #3 from Owen Leonard --- Created attachment 93889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93889=edit Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23780] New: Batch check out fails to inform or trap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Bug ID: 23780 Summary: Batch check out fails to inform or trap Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I have managed to catch failures in Batch check out on the following scenario: Patron has fines over the allowed limit. Item type only allows 5 check outs. When checking out 6 of this item type, Batch check out failed to: * Show any information that the patron had reached fine limit * Show that the patron was checking out too many of this item type If I checked out these 6 items without the fine, it gives the warning about too many items and asks me to confirm. If I check out 5 of these items with the fine, it does not explain why I need to confirm. It seems that Batch check out: * Is not displaying a reason for confirmation with the fine block. * Is not displaying a reason for confirmation when there are multiple blocks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Christopher Brannon changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #8 from Owen Leonard --- Updated the remote branch and downloadable patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 93888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93888=edit Bug 23770: (follow-up) Add tests for Koha::Objects->TO_JSON Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23507] Add ability to show and print change given on fee receipt from FinePaymentAutoPopup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 --- Comment #9 from Katrin Fischer --- (In reply to Martin Renvoize from comment #7) > (In reply to Katrin Fischer from comment #6) > > I am wondering if we should not always print the change given on the receipt > > instead of just the first time. Having it added to the template and only > > printing sometimes could turn out confusing (or be the next bug report :) ) > > We don't store that information Katrin, so we can't print it after the > initial transaction at the moment. Can't argue that point! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #1 from Bin Wen --- Created attachment 93887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93887=edit Bug 23765 - After TranslateNotices is set to 'Don't allow', email settings still show multiple languages To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit ,the template still shows all the languages. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Bin Wen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #11 from Katrin Fischer --- Thx a lot, Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #24 from Katrin Fischer --- (In reply to Kyle M Hall from comment #23) > (In reply to Katrin Fischer from comment #22) > > We've discussed the two approaches at the hackfest and came to the decision > > that the timezone aware approach seems the better one right now. > > > > The main issue with Kyle's approach is the lack of documentation, as there > > is a real danger this could turn into a secret feature not being used. So I > > make it a condition for QA that we get some documentation and examples on > > the wiki: > > > > https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit > > > > Kyle, are you ok with that? > > Yes! Did someone beat me to it, or would you like more examples? > https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Example: > _Format_dates I think some more complex examples would be nice that show why this patch is needed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #1 from Cori Lynn Arnold --- It should _at least_ look for $1xx fields, but DGI would _love_ to have $001 control number field checking -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #8 from Katrin Fischer --- Hi Anke, I meant a made up example "Karin Mustermann" or "Donald Duck" of course :) - just to see about the encoding of the file and if there are any differences to how I ususally format it. I'll try to have a look and see if I can replicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] New: Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 Bug ID: 23779 Summary: Importing authority records should look for $1xx field matches Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: carn...@dgiinc.com QA Contact: testo...@bugs.koha-community.org Created attachment 93886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93886=edit Importing Auth Record Match options When you import authority records using Tools->Stage MARC records for import the options for checking duplicates are for ISBN , ISSN and KohaBiblio. However, those fields make no sense for checking auth duplications. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #7 from Owen Leonard --- (In reply to Owen Leonard from comment #5) > This is ready for testing Cancel that, need to add some things! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #3 from Bin Wen --- Sorry, wrong patch push. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #6 from Owen Leonard --- Created attachment 93885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93885=edit Screenshot of the new TinyMCE editor interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Bin Wen changed: What|Removed |Added CC||bin@inlibro.com Attachment #93884|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #5 from Owen Leonard --- This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here: https://gitlab.com/koha-dev/koha-dev/commits/bug-22661-tinymce-upgrade I have also put a downloadable patch here in case that helps: https://zivotdesign.com/download/bug-22661.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #2 from Bin Wen --- Created attachment 93884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93884=edit Bug 23765 - After TranslateNotices is set to 'Don't allow', email settings still show multiple languages To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit ,the template still shows all the languages. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Bin Wen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 93883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93883=edit Bug 23770: Unit tests This patch introduces tests for the new to_api method introduced in Koha::Object(s). It uses Koha::City as a sample for simplicity. And it also uses Koha::Illrequests to test the case in which there's no to_api_mapping method defined on the class, to highlight that a fallback to calling TO_JSON is done. [1] [1] This is done under the assumption Illrequests controller code doesn't use any kind of mapping as the rest of the API controllers do, so there's little chance it would be added in a future. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t \ t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 93882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93882=edit Bug 23770: Add to_api_mapping method to Koha::City Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 93881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93881=edit Bug 23770: Add Koha::Object(s)->to_api method Generic method that changes the attribute names of an object in the presence of the to_api_mapping method. It otherwise falls back to returning the TO_JSON output. This is WIP submitted early for scrutiny. Tests and example usage in an API controller coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Josef Moravec from comment #2) > +1 > > Thanks Tomás. > > I do think that's the way we should go. Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Tomás Cohen Arazi changed: What|Removed |Added Attachment #93831|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23357] overdue_notices.pl can send library doubled emails for patrons with no email/sms if both transports enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23357 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #69 from Lari Taskula --- Resolved a bunch of conflicts, need sign-offs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69674|0 |1 is obsolete|| --- Comment #68 from Lari Taskula --- Created attachment 93880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93880=edit Bug 18595: Disable digest checkbox when forced on To test: 1. Force a digest on via message_transports table (delete rows where message_attribute is 1 and is_digest is 0) SQL: delete from message_transports where message_attribute_id=1 and is_digest=0; 2. Go to either OPAC or staff client messaging preferences 3. Observe digest checkbox is disabled for message attribute 1 (normally Item due row) Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69673|0 |1 is obsolete|| --- Comment #67 from Lari Taskula --- Created attachment 93879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93879=edit Bug 18595: Remove references to C4::Members::Messaging To test: 1. grep -r 'C4::Members::Messaging' This command should not produce any results in Koha source code after this patch. 2. Check the pages touched by this commit 3. Try setting and viewing patron and patron category messaging preferences As this completes the move from C4::Members::Messaging to new Koha-objects for messaging preferences, everything should be ready for proper testing. Make sure you have EnhancedMessagingPreferences system preference enabled. Then, try creating new categories and setting default messaging preferences, as well as editing the messaging preferences of the already existing categories. Try adding new patrons and make sure the default patron messaging preferences are by default the same that you set for that category. Edit already exisiting patrons' messaging preferences and make sure changes are applied. Observe no crash at any point, otherwise fail this patch. Don't forget to test both intranet and OPAC. Finally, run unit tests: 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69671|0 |1 is obsolete|| --- Comment #65 from Lari Taskula --- Created attachment 93877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93877=edit Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences This patch moves C4::Members::Messaging::GetMessagingPreferences to Koha::Patron::Message::Preference(s) The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences GENERAL 1. Apply patch 2. Search Koha source code for references of "GetMessagingPreferences" (grep -r 'GetMessagingPreferences'). 3. Observe no results in source code. UNIT TESTS 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69672|0 |1 is obsolete|| --- Comment #66 from Lari Taskula --- Created attachment 93878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93878=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreference This patch moves C4::Members::Messaging::SetMessagingPreference to Koha::Patron::Message::Preference The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences GENERAL 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreference" (grep -r 'SetMessagingPreference'). 3. Observe no results in source code. UNIT TESTS 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Reserves.t 3. prove t/db_dependent/Koha/Patron/Categories.t Works as expected. QA tools fails with: FAILC4/Members/Messaging.pm pod empty section in previous paragraph Can be fixed in a followup. Signed-off-by: Marc Véron QA tools pass now OK Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69670|0 |1 is obsolete|| --- Comment #64 from Lari Taskula --- Created attachment 93876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93876=edit Bug 18595: Unit tests preparing for GetMessagingPreferences move This patch prepares removing GetMessagingPreferences by adding some useful unit tests for subroutines that the move targets. Reserves.t already covers print notice, but this patch adds tests for a set transport type. To test: 1. Run t/db_dependent/Circulation.t 2. Run t/db_dependent/Reserves.t 3. Observe test pass Works together with followup patch Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69668|0 |1 is obsolete|| --- Comment #62 from Lari Taskula --- Created attachment 93874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93874=edit Bug 18595: Move C4::Members::Messaging::GetMessagingOptions This patch moves C4::Members::GetMessagingOptions to Koha::Patron::Message::Preferences->get_options. The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! This patch also removes previously unused GetMessagingOptions in opac-messaging.pl To test: Make sure you have enabled the following system preferences: - opacuserlogin - EnhancedMessagingPreferences - EnhancedMessagingPreferencesOPAC GENERAL 1. Apply patch 2. Search Koha source code for references of "GetMessagingOptions" (grep -r 'GetMessagingOptions'). 3. Observe no results in source code. OPAC 1. Login to OPAC. 2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl). 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. INTRANET 1. Login to intranet. 2. Go to edit patron's details and scroll down to their messaging preferences. 3. Observe the preferences looking normal and as they should be. 4. Set any combination of messaging preferences. 5. Observe them apply as expected, repeat step 4-5 as much as you like. 6. Go to Administration -> Patron categories -> Edit (for any category) 7. Scroll down to observe default messaging preferences for this patron category 8. Observe the preferences looking normal and as they should be. 9. Set any combination of messaging preferences. 10. Observe them apply as expected, repeat step 9-10 as much as you like. 11. Go to cgi-bin/koha/members/memberentry.pl?op=add=XXX, replace XXX with the categorycode you were just editing. 12. Fill in required data, do not modify messaging preferences, click Save. 13. Observe a new patron with default messaging preferences. Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69669|0 |1 is obsolete|| --- Comment #63 from Lari Taskula --- Created attachment 93875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93875=edit Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults This patch moves C4::Members::SetMessagingPreferencesFromDefaults to Koha::Patron->set_default_messaging_preferences The patch makes a heavy touch on core messaging preference features, but should not introduce any visible changes for end user. Keep this in mind if testing. If you notice any changes in Koha, something is probably wrong! To test: Make sure you have enabled the following system preferences: - EnhancedMessagingPreferences GENERAL 1. Apply patch 2. Search Koha source code for references of "SetMessagingPreferencesFromDefaults" (grep -r 'SetMessagingPreferencesFromDefaults'). 3. Observe no results in source code. INTRANET 1. Login to intranet. 2. Go to Administration -> Patron categories -> Edit (for any category) 3. Scroll down to observe default messaging preferences for this patron category 4. Observe the preferences, remember them for the next step. 5. Go to cgi-bin/koha/members/memberentry.pl?op=add=XXX, replace XXX with the categorycode you were just editing. 6. Look at messaging preferences. They should be same as in step 4. 7. Fill in required data, do not modify messaging preferences, click Save. 8. Observe a new patron with default messaging preferences. Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #69667|0 |1 is obsolete|| --- Comment #61 from Lari Taskula --- Created attachment 93873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93873=edit Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging This patch adds unit tests for Koha::Patron::Categories->default_messaging. Tests will help preparing for moving C4::Members::Messaging to Koha-objects. To test: 1. Run t/db_dependent/Koha/Patron/Categories.t Signed-off-by: Marc Véron Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Lari Taskula changed:
What|Removed |Added
Attachment #93865|0 |1
is obsolete||
--- Comment #64 from Lari Taskula ---
Created attachment 93872
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93872=edit
Bug 17499: Add Koha-objects for messaging preferences
This patch adds Koha-objects for messaging preferences.
Adds simple validation for messaging preferences.
The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference
Adds a method for getting available messaging options.
Adds a method for setting default messaging preferenes.
$patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
...or...
Koha::Patron::Message::Preference->new_from_default({
borrowernumber => 123,
categorycode => "ABC",
message_attribute_id => 1,
});
Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
$preference->message_transport_types (for
getting)
$preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
(also supports other calling conventions, see documentation for more)
Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.
Includes test coverage for basic usage.
To test:
1. prove t/db_dependent/Koha/Patron/Message/*
Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.
Signed-off-by: Dominic Pichette
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
