[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #21 from Marcel de Rooy  ---
Problem with required Title field in Tools/News. Leaving the title blank
somehow is not a good idea. You can't edit the record now.

Opacheader shows more text than anticipated: I had this in the pref
TEST But the contents of another news item (location All) is shown
too. Probably not wanted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Patrick,
which preferences/features do you use to limit the list of pick-up locations in
the first place? I'd like to confirm the bug, but need more information about
your configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680

Katrin Fischer  changed:

   What|Removed |Added

Summary|Perl string '0' evaluated   |Can't open 'Edit items' or
   |as javascript boolean   |'Add item' links in new tab
   |triggers window.close() |- tab is closed immediately
   |when should not |

--- Comment #11 from Katrin Fischer  ---
2 duplicates filed already - changing bug title to make it more readable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #20 from Marcel de Rooy  ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680

Katrin Fischer  changed:

   What|Removed |Added

 CC||felicia.beaudry@equinoxinit
   ||iative.org

--- Comment #10 from Katrin Fischer  ---
*** Bug 23490 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23490] Edit Items in Advanced Editor fails

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23490

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---
This has been fixed recently with bug 23680 and is waiting to be backported for
stable releases.

*** This bug has been marked as a duplicate of bug 23680 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23466] In some catalogs it does not show the "holding"

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23466

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #4 from Katrin Fischer  ---

> In some catalogs it does not show the "holding", in the opac-error of the
> log, it shows an error in the line 1034 koha / lib / C4 / Items.pm, the koha
> we use is version 18.11

With the exact error I meant the line from the logs. A lot of what appears in
the logs is just warnings and not real errors that affect the functionality of
Koha. 

We have tested latest 18.11.x extensively and haven't noticed any errors in
display. 

There is not enough information on the bug report as it is now to see where the
problem stems from. This could also be a migration or data issue.

Marking this WORKSFORME for now, please reopen with more information if the
problem still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

--- Comment #16 from Marcel de Rooy  ---
Somehow does not meet:
elsif( $_->{msg} =~ /Incorrect (?\w+) value: '(?.*)' for column
'(?\w+)'/ ) {

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #15 from Marcel de Rooy  ---
Depending on strict mode I have two results of the Object.t test:

not ok 1 - Exception thrown correctly
#   Failed test 'Exception thrown correctly'
#   at t/db_dependent/Koha/Object.t line 411.
# expecting: Koha::Exceptions::Object::BadValue
# found: normal exit
# Looks like you failed 1 test of 1.
not ok 16 - Bad value tests

#   Failed test 'Exception thrown correctly'
#   at t/db_dependent/Koha/Object.t line 411.
# expecting: Koha::Exceptions::Object::BadValue
# found: DBIx::Class::Exception
(DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value:
'wrong_value' for column `koha_master`.`borrowers`.`lastseen` at row 1 at
/usr/share/koha/Koha/Object.pm line 156
# )
# Looks like you failed 1 test of 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning."

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Hi Julie, I've tested on 18.11 and this doesn't appear to be a general problem. 

Another thing to check is your item data - make sure item type, home and
holding branches are always set. Please let us know if Owen's and my
suggestions didn't help you and the problem persists.

Closing the bug meanwhile.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23588] REST API: Can't create a patron

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23588

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Katrin Fischer  ---
Hi Muhammed, checking this again, this sounds like a support request rather
than a bug.

Questions about Koha configuration are best asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 Status|Signed Off  |BLOCKED

--- Comment #14 from Marcel de Rooy  ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709
[Bug 23709] Can't add new subfields to bibliographic frameworks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17258
 CC||katrin.fisc...@bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20419] Current location not updated correctly on the return of an item on hold

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22097

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20419

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20419] Current location not updated correctly on the return of an item on hold

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18499] catalog 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499

--- Comment #2 from Nick Clemens  ---
To clarify, in a system with mixed classification sources the callnumber
browser uses the DefaultClassificationSource defined in the sysprefs for all
browsing.

This is problematic in some situations, for instance:
'2017 SCHM' is a generic callnumber, if you set the Default to 'LOC' you get
back a blank string

To recreate:
1 - Set DefaultClassificationSource to LOC
2 - perl -e "use C4::ClassSource; print GetClassSort( undef, undef, '2017 SCHM'
);"
3 - You get no feedback
4 - Set DefaultClass.. to Dewey
5 - repeat #2
6 - You get a populated string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18499] catalog 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499

Nick Clemens  changed:

   What|Removed |Added

Summary|catalog 'Call Number|catalog 'Call Number
   |Browser' on edit items  |Browser' on edit items
   |screen does not sort on |screen uses the default
   |items.cn_sort   |classification source
   ||rather than the item
   ||specific source

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19884] Improve performance of GetItem

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #56 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #55)
> You will notice that there's actually a prefetch of the related metadata row
> and the (maybe multiple) items rows in the same query (through a LEFT JOIN).

That's clever!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6795] Library-specific OPAC preferences

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795

--- Comment #6 from Owen Leonard  ---
> opaccredits
> opacheader
> OpacMainUserBlock
> OpacNav
> OPACNoResultsFound

But 22318 enables fixes for these preferences.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #34 from Owen Leonard  ---
*** Bug 11251 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 22318 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23799] New: Mojolicious::Plugin::OpenAPI missing

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799

Bug ID: 23799
   Summary: Mojolicious::Plugin::OpenAPI missing
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dalagior...@sch.gr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 93984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93984=edit
Screenshot of the web installer (in Greek)

I've just installed koha on a laptop running Debian 10 and I'm facing the
following problem. The web installer is telling me that there are some Perl
modules missing. In particular the Mojolicious::Plugin::OpenAPI module is
missing. However I got no errors during koha-common installation. I've even
tried to run 'sudo apt-get install libmojolicious-plugin-openapi-perl' again
but apt is reporting that it is already the newest version. What do I do?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795
[Bug 23795] Convert OpacCredits system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23795] Convert OpacCredits system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23796


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796
[Bug 23796] Convert OpacCustomSearch system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23796] Convert OpacCustomSearch system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23798


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798
[Bug 23798] Convert OpacMaintenanceNotice system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23797


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797
[Bug 23797] Convert OpacLoginInstructions system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
[Bug 23794] Convert OpacMainUserBlock system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
[Bug 22880] Convert opacheader system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23798


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798
[Bug 23798] Convert OpacMaintenanceNotice system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23798] New: Convert OpacMaintenanceNotice system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798

Bug ID: 23798
   Summary: Convert OpacMaintenanceNotice system preference to
news block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 22318

Building on 22318, the OpacMaintenanceNotice system preference should be
converted to a Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23797


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797
[Bug 23797] Convert OpacLoginInstructions system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] New: Convert OpacLoginInstructions system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Bug ID: 23797
   Summary: Convert OpacLoginInstructions system preference to
news block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 22318

Building on 22318, the OpacLoginInstructions system preference should be
converted to a Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23796


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796
[Bug 23796] Convert OpacCustomSearch system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23796] New: Convert OpacCustomSearch system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796

Bug ID: 23796
   Summary: Convert OpacCustomSearch system preference to news
block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 22318

Building on 22318, the OpacCustomSearch system preference should be converted
to a Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23795] New: Convert OpacCredits system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795

Bug ID: 23795
   Summary: Convert OpacCredits system preference to news block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 22318

Building on 22318, the OpacCredits system preference should be converted to a
Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23795


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795
[Bug 23795] Convert OpacCredits system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794
[Bug 23794] Convert OpacMainUserBlock system preference to news block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23794] New: Convert OpacMainUserBlock system preference to news block

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

Bug ID: 23794
   Summary: Convert OpacMainUserBlock system preference to news
block
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: hayleymap...@catalyst.net.nz,
jonathan.dru...@bugs.koha-community.org,
katrin.fisc...@bsz-bw.de, lu...@bywatersolutions.com,
m.de.r...@rijksmuseum.nl,
testo...@bugs.koha-community.org
Depends on: 22318

Building on 22318, the OpacMainUserBlock system preference should be converted
to a Koha news block.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #13 from Thomas Dukleth  ---
I have successfully tested for the following changes in converting the Koha
Wiki database from Postgres to MySQL.  Postgres MediaWiki defaults had text
types without any size constraint while the same columns in MySQL had strong
default size constraints.

We have the example of actual use in Postgres where it is evident that there
are some circumstances where perfectly reasonable and correct use exceeds the
MySQL size constraints and there seems to be no problem with altering the
column size in MySQL to accommodate legitimate existing data use.  At the same
time, it seems appropriate to truncate the data for the few accidents where
someone pasted wiki page content mistakenly into the comments field.

Some cases where the column size default is too small in MySQL but the data is
automatically generated or essentially automatically generated indicate that
the MySQL column size constraint was not well planned.

In one case where the comment in a comment column is legitimate but exceeds the
MySQL column size by a few characters which can be truncated without loss of
understanding, it seems appropriate to truncate the column for the one row
which goes over the size limit. If the MySQL size change of the same data type
would be from. 

In the SQL statements below the comment "Original" immediately precedes an SQL
statement for the original structure of the column.  If the original structure
statement is not commented out it is restored, otherwise the next SQL statement
after comments provides the structure for the column with an increased size.

For the three columns with a size increase from the default, it will be
necessary in MediaWiki upgrades to check whether the size may be decreased by
the upgrade if that would ever happen.

-- Original
-- ALTER TABLE `account_credentials` MODIFY COLUMN `acd_comment` varchar(255)
NOT NULL DEFAULT '';
-- Allow for sufficiently greater than largest legitimate found data
-- length of 472.  An explanatory greeting message to a user about a
-- login problem seems necessary and appropriate
ALTER TABLE `account_credentials` MODIFY COLUMN `acd_comment` varchar(511) NOT
NULL DEFAULT '';

-- Original
ALTER TABLE `archive` MODIFY COLUMN `ar_comment` tinyblob NOT NULL;
-- Truncated in database migration Python script for greater than largest
-- length for TINYBLOB, 255 bytes including one extra byte for data size.
--
-- Wrong field use mistake with illegitimate found data length 5446.
-- Column truncation affecting 3 rows.

-- Original
-- ALTER TABLE `categorylinks` MODIFY COLUMN `cl_sortkey` varchar(70) CHARACTER
SET utf8mb4 COLLATE utf8mb4_bin NOT NULL DEFAULT '';
-- Allow for sufficiently greater than largest legitimate found data
-- length of 165.  Column data is automatically generated from page
-- titles and used as a key for page title sort order which would
-- obviously not work properly if shorter than the longest page title.
-- Template titles are the longest but there are many others over the
-- default.
ALTER TABLE `categorylinks` MODIFY COLUMN `cl_sortkey` varchar(200) CHARACTER
SET utf8mb4 COLLATE utf8mb4_bin NOT NULL DEFAULT '';

-- Original
ALTER TABLE `filearchive` MODIFY COLUMN `fa_description` tinyblob;
-- Truncated in database migration Python script for greater than largest
-- length for default size TINYBLOB, 255 bytes including one extra byte
-- for data size.
--
-- Wrong field use mistake with illegitimate found data length 5447.
-- Column truncation affecting 3 rows.

-- Original
-- ALTER TABLE `logging` MODIFY COLUMN `log_comment` varchar(255) NOT NULL
DEFAULT '';
-- Truncated in database migration Python script for sufficiently greater
-- than largest legitimate found data length of 278.  Many essentially
-- automatically filled uses which slightly exceed 255 characters.
--
-- An alternative to increasing the size of the column to accommodate
-- legitimate use could be changing some essentially automatically filled
-- text patterns in the data to some more abbreviated form.
--
-- Wrong field use mistake with illegitimate found data length 5447.
-- Column truncation affecting 3 rows.
ALTER TABLE `logging` MODIFY COLUMN `log_comment` varchar(300) NOT NULL DEFAULT
'';

-- Original
ALTER TABLE `revision` MODIFY COLUMN `rev_comment` tinyblob NOT NULL;
-- Truncated in database migration Python script for greater than the
-- largest length for default size TINYBLOB, 255 bytes including one
-- extra byte for data size.
-- 
-- Largest legitimate found data length of 259.
--
-- Column truncation affecting 1 row cutting off the end of a word but not
-- affecting understandability of comment.  At the end of the comment the
-- word "breadcrumbs."  would be truncated as "breadcr" truncating four
-- characters and the full stop at the end of the sentence.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

Nick Clemens  changed:

   What|Removed |Added

  Attachment #90451|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

--- Comment #2 from Nick Clemens  ---
Created attachment 93982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93982=edit
Bug 23089: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

--- Comment #3 from Nick Clemens  ---
Created attachment 93983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93983=edit
Bug 23089: Fix sorting on sum and regular fields

As of bug 20589 we no longer analyze sort fields and so we no longer need to
append ".phrase"
to our sort in searches.

Additionally, sort fields based on 'sum' should also use sum in building the
value to sort on

To test:
0 - Be using ES
1 - Find the most circulated item in your collection
2 - Search for '*'
3 - Sort by popularity DESC
4 - Note that item is not first
5 - Try to sort by anything but relevancy, it fails
6 - Apply patch
7 - Redo searches and sorts
8 - Things should now work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

Nick Clemens  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

--- Comment #49 from Nick Clemens  ---
Created attachment 93981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93981=edit
Bug 23626: (follow-up) Fix JS when not viewing results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|23354   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|23321   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|23049   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|23354   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #93971|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 93980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93980=edit
Bug 23793: Add an EmbedItems RecordProcessor filter for MARC::Record objects

This patch is work in progress. I submit early with the aim to provide
people thinking about performance on the biblio/records/items front an
idea of what I'm thinking.

The synopsis on the new filter is self explanatory. The idea is that we
calculate as much as we can outside the loops. And this simpe
implementation is clean and light as well.

Problems:
- Filters are supposed to support passing multiple MARC records, this
one doesn't, beacuse I didn't think enough of a way to pass all the
items and biblionumbers in a way that is safe...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Actual price should be shown in basket

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

--- Comment #10 from Michael Sutherland  ---
That's great! Thank you so much!


(In reply to Owen Leonard from comment #9)
> (In reply to Michael Sutherland from comment #8)
> > Owen --
> > 
> > According to the bug 23523 it was signed off
> 
> Yes, and the next step is for it to be reviewed by a member of the QA team.
> After that it will be reviewed by the Release Manager.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Actual price should be shown in basket

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

--- Comment #9 from Owen Leonard  ---
(In reply to Michael Sutherland from comment #8)
> Owen --
> 
> According to the bug 23523 it was signed off

Yes, and the next step is for it to be reviewed by a member of the QA team.
After that it will be reviewed by the Release Manager.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Actual price should be shown in basket

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

--- Comment #8 from Michael Sutherland  ---
Owen --

According to the bug 23523 it was signed off by 

Signed-off-by: Claire Gravely 


(In reply to Owen Leonard from comment #7)
> (In reply to Michael Sutherland from comment #6)
> > What does that mean? What will it take for the block be cleared? 
> 
> It means this bug depends on another bug (bug 23523) which is still in the
> QA process. Once that bug is approved this one can move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Tomás Cohen Arazi  ---
I paste the synopsis for easier analysis:

my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ items, metadata ] }
);

my $opachiddenitems_rules;
eval {
my $yaml = C4::Context->preference('OpacHiddenItems') . "\n\n";
$opachiddenitems_rules = YAML::Load($yaml);
};

my @items  = grep { $_->hidden_in_opac({ rules => $opachiddenitems_rules })
@{$biblio->items};
my $record = $biblio->metadata->record;

my $processor = Koha::RecordProcessor->new(
{
filters => ('EmbedItems'),
options => {
items=> \@items,
item_tag => $item_tag,
biblionumber => $biblionumber
}
}
);

$processor->process( $record );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #53 from Martin Renvoize  ---
Created attachment 93978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93978=edit
Bug 23049: Update API

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #54 from Martin Renvoize  ---
Created attachment 93979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93979=edit
Bug 23049: (follow-up) Fix manual debits via add_debit

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #52 from Martin Renvoize  ---
Created attachment 93977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93977=edit
Bug 23049: Drop type lookup as it's now a foreign key

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #51 from Martin Renvoize  ---
Created attachment 93976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93976=edit
Bug 23049: 'N' -> 'NEW_CARD'

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #49 from Martin Renvoize  ---
Created attachment 93974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93974=edit
Bug 23049: Remove manual_debit as it's never called

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #50 from Martin Renvoize  ---
Created attachment 93975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93975=edit
Bug 23049: Capitalise type passed to add_debit for overdue

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #47 from Martin Renvoize  ---
Created attachment 93972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93972=edit
Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency

This patch updates all cases where debit_type_code was 'HE' to
'RESERVE_EXPIRED' which is more informative and consistent with the
new style guidelines.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #48 from Martin Renvoize  ---
Created attachment 93973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93973=edit
Bug 23049: Capitalise type passed to add_debit for lost_item

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 93971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93971=edit
Bug 23793: Add an EmbedItems RecordProcessor filter for MARC::Record objects

This patch is work in progress. I submit early with the aim to provide
people thinking about performance on the biblio/records/items front an
idea of what I'm thinking.

The synopsis on the new filter is self explanatory. The idea is that we
calculate as much as we can outside the loops. And this simpe
implementation is clean and light as well.

Problems:
- Filters are supposed to support passing multiple MARC records, this
one doesn't, beacuse I didn't think enough of a way to pass all the
items and biblionumbers in a way that is safe...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #46 from Martin Renvoize  ---
Created attachment 93970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93970=edit
Bug 23049: Capitalise type passed to add_debit for account

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #44 from Martin Renvoize  ---
Created attachment 93968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93968=edit
Bug 23049: Capitalise 'rent' calls to add_debit

This works towards making type codes consistent

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #45 from Martin Renvoize  ---
Created attachment 93969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93969=edit
Bug 23049: Update 'PF' to 'PROCESSING' for consistency

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #43 from Martin Renvoize  ---
Created attachment 93967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93967=edit
Bug 23049: Update 'Res' to 'RESERVE' for consistency

This patch updates all cases where debit_type_code was 'Res' to
'RESERVE' which is more informative and consistent with the new style
guidelines.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #42 from Martin Renvoize  ---
Created attachment 93966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93966=edit
Bug 23049: Update existing code to use debit_type

* Update C4::Accounts::chargelostitem
* Update C4::Accounts::manualinvoice
* Update C4::Circulation::_FixOverduesOnReturn
* Update C4::Circulation::_FixAccountForLostAndReturned
* Update C4::Overdues::UpdateFine
* Update C4::Overdues::GetFine
* Update C4::Overdues::GetOverduesForBranch
* Update Koha::Account->pay
* Update Koha::Account->add_debit
* Update Koha::Account->non_issues_charges
* Update Koha::Account::Line->apply
* Update Koha::Account::Line->adjust
* Update controller scripts
* Update reports scripts
* Update tests

Test Plan
1) Run the test suit and ensure everything still passes
2) Test reports/cash_register_stats still works
3) Test that adding manual invoices still works
4) Test that making payments still works
5) Test that lost item fee handling still works
6) Test that invoice printing still works
7) Test that the sco still works

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #40 from Martin Renvoize  ---
Created attachment 93964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93964=edit
Bug 23049: Update maninvoice to reference debit types

Test plan:
1) Naviage to a patron record and select the accounts > manual invoice
   tab
2) Add some manual invoices and confirm they are working as expected
3) Signoff

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #41 from Martin Renvoize  ---
Created attachment 93965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93965=edit
Bug 23049: Add tests

Test plan:
  prove t/db_dependent/Koha/Account/DebitType.t
  prove t/db_dependent/Koha/Account/DebitTypes.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #39 from Martin Renvoize  ---
Created attachment 93963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93963=edit
Bug 23049: Filter out system types by default

Test Plan
1) Navigate to the debit types management page added in previous patches
2) Note that system types are now filtered out by default
3) Click on the new unfilter button to include system types
4) Signoff

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #38 from Martin Renvoize  ---
Created attachment 93962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93962=edit
Bug 23049: Account types configuration - Admin page

Test plan:
1) Go to admin home, note there is new Debit types page in Accounting
   section
2) Go to any other admin page and confirm there is link to Debit types
   in the admin menu as well
3) Go to Debit types page
4) You should see a datatable listing existing debit types, ensure they
   are working as expected.
5) Try to create, edit and delete some debit types. Note: Some debit
   types cannot be deleted as they are needed for koha functionality.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #37 from Martin Renvoize  ---
Created attachment 93961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93961=edit
Bug 23049: Add CHECK constraint to accountlines

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93579|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Actual price should be shown in basket

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

--- Comment #7 from Owen Leonard  ---
(In reply to Michael Sutherland from comment #6)
> What does that mean? What will it take for the block be cleared? 

It means this bug depends on another bug (bug 23523) which is still in the QA
process. Once that bug is approved this one can move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #36 from Martin Renvoize  ---
Created attachment 93960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93960=edit
Bug 23049: Add debit_type

* Add account_debit_types table
* Add ac_debit_types_branches table
* Add account_debit_types defaults
* Add Koha::Account::DebitType and Koha::Account::DebitTypes
* Prevent deletion of defaults
* Migrate MANUAL_INV values
* Remove MANUAL_INV references
* Migrate accounttype values

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93577|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93578|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93576|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93575|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93574|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93573|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93572|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93571|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93569|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93570|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93568|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >