[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #5 from Katrin Fischer  ---
(In reply to Arthur Suzuki from comment #4)
> needed_before_date is actually stored in the "reservedate", this is just a
> way to place a reserve on a future date.
> pickup_expiry_date is the date after which the reserve is automatically
> cancelled if not picked up by the user and this one is stored in the
> "expirydate"
> 
> Maybe the parameter "needed_before_date" shall be renamed another way.
> 
> The use case is for example for teachers/students who need to reserve a book
> for a course, they need it between "needed_before_date" and
> "pickup_expiry_date".
> There is no way to provide either date from ILS-DI right now, but we have
> this need for bundled holds (for which Cecile showed the bundled loans
> counterpart at the Hackfest in Marseille).

I think I would make it something like 'expiry_date' (doesn't matter if it has
been waiting for pickup or not) and something like 'not_needed_before' or even
'start_date' to clear things up a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Arthur Suzuki  ---
(In reply to Katrin Fischer from comment #7)
> Wondering: does this use the same logic that is used in the OPAC to build
> the pick-up location list?

Hm... Uses Koha::Library->pickup_location.
Opac goes through all libraries which are set as possible pickup location (site
configuration) and check if desired book is available for transfer there.
This is basically what does Koha::Library->pickup_location but embed in a nice
method.

Uses the same function (Koha::Library->pickup_location(In reply to Katrin
Fischer from comment #6)
> 3) We are missing tests for the change to Service.pm

Okay, have to write some then...

> 4) I can't seem to make the documentation show up? Checking the OPAC side
> documentation here: /cgi-bin/koha/ilsdi.pl

Neither can I... although it's been written in the code, have to check what's
wrong there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

--- Comment #4 from Arthur Suzuki  ---
needed_before_date is actually stored in the "reservedate", this is just a way
to place a reserve on a future date.

pickup_expiry_date is the date after which the reserve is automatically
cancelled if not picked up by the user and this one is stored in the
"expirydate"

Maybe the parameter "needed_before_date" shall be renamed another way.

The use case is for example for teachers/students who need to reserve a book
for a course, they need it between "needed_before_date" and
"pickup_expiry_date".
There is no way to provide either date from ILS-DI right now, but we have this
need for bundled holds (for which Cecile showed the bundled loans counterpart
at the Hackfest in Marseille).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #93455|0   |1
is obsolete||

--- Comment #8 from Arthur Suzuki  ---
Created attachment 94039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94039&action=edit
Bug 23015: Implements a new ILS-DI service to get available pickup libraries
for an item or record

test plan :
1 / Set a library A as available pickup location in the intranet
2 / query ILS-DI service with any record which has at least an item in
A or an item which can be transfered to A => should send all
informations about A

3 / Remove A from available pickup locations from the item in the intranet then
repeat 2 => should
give empty reply

4 / Try with unexisting patron, unexisting item or unexisting record,
should throw an explicit error

Signed-off-by: Christophe Croullebois 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #78 from Katrin Fischer  ---
Hi Nick, can you please rebase? ... Bit scared of the datatables code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #211 from Katrin Fischer  ---
Some doubts here:

1) Koha vs. C4

This adds quite some new code to the C4 namespace:
AddHoldGroup
DeleteHoldGroup
GetHoldGroupHolds
GetReserveCount

We already have started to move to Hold.pm and Holds.pm in the Koha namespace.

I feel like the new things (*HoldGroup*) at least should be started in the new
namespace... someone else might weigh in here.

Also uses lots of SQL.

2) Database changes

The database update looks quite complicated, because you try to catch that the
holds_groups could already exist. I feel it could be simplified.

The holds groups table only consists of a PK column?

I think the charset is not correct, should be:

3) Had the same question looking at the new method added:
+# TODO: Should be: $reserve_cnt = $patron->holds->count;
+$reserve_cnt = GetReserveCount( $borrowernumber );

4) Rename test file (must have missed the global renaming :) )

5) How does this feature affect limits on holds? (total and daily limits). Will
every hold be counted as before?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #210 from Katrin Fischer  ---
I am having issues with the Schema updates. 

I tried to skip 
Bug 15516: (follow-up) Schema updates
in favor of runing the dbic command myself later, but 
Bug 15516: Fixing missing curly bracket
looks like there are also manual changes?

Can you please keep the automated updates in a separate patch and rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #22 from Katrin Fischer  ---
Forgot to run yarn build --view opac

It's better now, but problems still remain with spaces and 'for reference'
label. [] show... but I can't copy and paste them from the OPAC to here? 

With C&P:
Items available for loan: CentervilleCall number: 005.13/3 (1).
Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall
number: 005.13/3 (1). Damaged (1). 

Manually edited:
Items available for loan: Centerville[Call number: 005.13/3] (1).
Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
Ordered[Call number: 005.13/3] (1). Damaged (1).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #21 from Katrin Fischer  ---
My example: Record with 4 items:
- 1 damaged + Staff collecton
- 1 ordered
- 1 Staff collection
- 1 'without' status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Katrin Fischer  ---
Sorry, but something is not working quite right here still. I get quite
unreadable output in the OPAC :(

With this patch:
Availability: Items available for loan: CentervilleCall number: 005.13/3 (1).
Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall
number: 005.13/3 (1). Damaged (1). 

Before:
Availability: Items available for loan: Centerville [Call number: 005.13/3]
(1). Items available for reference: Centerville [Call number: 005.13/3] (1).
Damaged (1). On order (1). 

- Can we please bring back the [] for now? 
- Totally missing the: 'Available for reference' label?
- I am also tempted to say 'kill Call number', but we should concentrate on one
change at a time here. We should focus on the 'not for loan' descriptions here
first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

Summary|Show the NOT_LOAN   |Show the NOT_LOAN
   |authorised values for item  |authorised values for item
   |status in XSLT OPAC search  |status in XSLT OPAC search
   |results.|results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

--- Comment #22 from Katrin Fischer  ---
Created attachment 94038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94038&action=edit
Bug 17247: (follow-up) Terminology fix: Use Restricted instead of debarred

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

--- Comment #21 from Katrin Fischer  ---
Created attachment 94037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94037&action=edit
Bug 17247: Check if patron is restricted in HoldItem and HoldTitle

Test plan:
Make sure a restricted patron cannot hold a title or item through ILS-DI.
Response from the WebService should be "PatronDebarred".

Signed-off-by: Brendan Gallagher 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93549|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

--- Comment #20 from Katrin Fischer  ---
This is a really small bug fix now, so I am inclined to passing it.

It would be nice to have a regression test for this. Also, we should be using
"Restricted" instead of Debarred. I'll add a follow-up suggesting the
terminology change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is restricted

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Katrin Fischer  changed:

   What|Removed |Added

Summary|ILS-DI HoldTitle and|ILS-DI HoldTitle and
   |HoldItem should check if|HoldItem should check if
   |patron is debarred  |patron is restricted
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
Summary|ILS-DI doesn't implement|ILS-DI doesn't implement
   |needed_before_date and  |needed_before_date and
   |pickup_expiry_date  |pickup_expiry_date
   |parameters. |parameters
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
1) Same formal issues than on bug 23015:
- commit message
- failing qa tools for tabs vs. spaces

 FAIL   C4/ILSDI/Services.pm
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 730)
forbidden pattern: tab char (line 735)
forbidden pattern: tab char (line 816)
forbidden pattern: tab char (line 821)
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   OK valid

2) Unit tests for change to Service.pm 

3) I am not sure about the patch 'content'.

needed_before_date = Visible on the Koha holds form as 'Hold not needed after'.
Stored in the database in reserves.expirationdate. Correct?

pickup_expiry_date = This one confuses me. The expiration date for pick-up is
usually calculated by Koha using different configuration parameters and not
something that the user can 'pick' at the time of placing a hold.

But what makes it worse: Both go in the same column in the database atm (yes,
bad). When a hold is set to waiting, the pick-up date is calculated and rebases
the patron entered date in reserves.expirationdate. 

So... I think this cannot work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

--- Comment #7 from Katrin Fischer  ---
Wondering: does this use the same logic that is used in the OPAC to build the
pick-up location list?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Katrin Fischer  ---
3) We are missing tests for the change to Service.pm

4) I can't seem to make the documentation show up? Checking the OPAC side
documentation here: /cgi-bin/koha/ilsdi.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

--- Comment #5 from Arthur Suzuki  ---
Thanks for your review, will fix that after lunch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

--- Comment #4 from Katrin Fischer  ---
havig = habit!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Arthur,

just some feedback on formal stuff:

1) Please always start your commit messages with Bug:  (no extra space
before the :). I usually fix those, but it gets boring fast :)

2) There is a lot of complaints about whitespace. Please make sure your editor
is set to not use tabs but 4 spaces instead. 

 FAIL   C4/ILSDI/Services.pm
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 644)
forbidden pattern: tab char (line 646)
forbidden pattern: tab char (line 647)
forbidden pattern: tab char (line 651)
forbidden pattern: tab char (line 653)
forbidden pattern: tab char (line 654)
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   OK valid

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
   OK filters
   FAIL   forbidden patterns
forbidden pattern: tab char (line 69)
forbidden pattern: tab char (line 692)
forbidden pattern: tab char (line 693)
forbidden pattern: tab char (line 697)
   OK git manipulation
   OK js_in_body
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   opac/ilsdi.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 94)
forbidden pattern: tab char (line 112)
   OK git manipulation
   OK pod
   OK spelling
   OK valid

It's also very good to get into the havig of running the QA test tools, so
those can be caught and fixed early!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23435] Add multiple copies of an item when receiving in serials

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93827|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 94036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94036&action=edit
Bug 23435: Add multiple copies of an item when receiving in serials

This feature allows you to add multiple item records when receiving a
serial, if the subscription is set to 'create item record when receiving
serials'. Please note this is not the same as multi-receiving, more like
multi-adding!

To test:
1) Create a subscription, ensure the 'Create an item record when
receiving this serial' option is selected
2) Receive a serial
3) Expand the item form by selecting 'click to add item'
4) Fill in details, including a barcode. Leave 'number of copies' as 1
and Save.
5) Confirm the serial is received as expected.
6) In another tab, open the bibliographic record attached to this
subscription
7) Confirm the item record was created upon receiving the serial
8) Go back to the serial collection and receive next serial
9) Expand the item form by selecting 'click to add item'
10) Fill in details again, this time change 'number of copies' to a
different number e.g. 3, and Save
11) Confirm the serial is received as expected.
12) Check back at the biblio record that 3 item records were created and
the barcode was incremented for each additional item.

Sponsored-by: Brimbank City Council
Signed-off-by: Maryse Simard 

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23435] Add multiple copies of an item when receiving in serials

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23772] Itemtype icons not showing in table

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23772] Itemtype icons not showing in table

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772

--- Comment #6 from Katrin Fischer  ---
Thx for the fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23772] Itemtype icons not showing in table

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #94016|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 94035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94035&action=edit
Bug 23772: Revert to passing itemtype objects to the template

This patch restores the methodology prior to bug 23602 of passing the
full Koha::ItemType objects to the template and thus giving us the
ability to use all the methods present within them.

Test plan:
1) Ensure you have at least one itemtype with an assigned icon and the
   images enabled.
2) View the itemtypes admin page and note the icons display again
3) Ensure you have at least one itemtype with library limitations
   defined.
4) View the itemtypes admin page and note the library limitations still
   display.
5) Signoff

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

--- Comment #11 from Katrin Fischer  ---
(In reply to tecnicouncoma from comment #10)
> Hi people. I tried robots.txt and nothing happend. I installed Koha in an i7
> computer with 16G RAM.
> 
> We are rebooting the system twice a day because of the DoS.
> 
> ¿Any alternative procedure to follow?
> 
> Thx,

Hi, I think you might want to ask on the mailing list how others have dealt
with the problem. If your robots.txt was added correctly and the bots are
ignoring it, you might want to try and block them by IP in the firewall.

There is also the OPACPublic systm preference that will only allow people to
search after being registered (to anser comment#9)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #3)
> (In reply to Tomás Cohen Arazi from comment #2)
> > This is a POC. It uses the default FW when it shouldn't, as each FW might
> > have a different mapping for items.itemnumber.
> 
> Well, not POC. It is completely funcional and the default framework is a
> reasonable fallback. I will try to submit the unit tests, but please
> consider testing it along with the filter on the performance patchsets.

I think not only a fallback, if I understand correctly, the default framework
defines the mappings now:
Bug 19096 - Koha to MARC mappings (Part 2): Make Default authoritative

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23677] Add route to get a bibliographic record

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Component|Architecture, internals,|REST api
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

2019-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Katrin Fischer  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||katrin.fisc...@bsz-bw.de
  Component|Architecture, internals,|Hold requests
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/