[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #204 from David Cook --- (In reply to Ere Maijala from comment #203) > I see. I'll take another stab at trying to make the tests work with both > versions. I can try to help. I'm pretty busy at the moment, so not too keen to spin up a koha-testing-docker and try it out, but if you point me at the test, I can have a look. Martin's already pushed the patches to master, so maybe it doesn't matter too much? Maybe he can clarify things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #203 from Ere Maijala --- (In reply to David Cook from comment #202) > I think I don't know enough about the particular test in question to really > continue the conversation. I figured it was a case of providing a > configuration value to a function in the test, but it sounds like perhaps > it's a Zebra config file and that it's an integration test, so I see how > that could be tricky. I withdraw my suggestion heh. I value the suggestion, though it wouldn't solve the problem that YAZ 4 and 5 do diagnostics (error handling) differently. I'll see if I can modify the tests to pass on both. > That's an interesting question. Looking at > https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in > Jessie and Stretch, but Buster and Bullseye use YAZ 5. I see. I'll take another stab at trying to make the tests work with both versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22064] Allow to change due date of an item without requiring checkin or renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #202 from David Cook --- (In reply to Ere Maijala from comment #199) > The path is in a config file, so hard-coding it there there doesn't seem > quite proper. It doesn't seem possible to specify it programmatically. > Anyway, it wouldn't help since YAZ 4 and 5 handle some error conditions > differently, unless I remove the offending tests. That's of course possible > too, but I would rather not do that unless it's the last option. > I think I don't know enough about the particular test in question to really continue the conversation. I figured it was a case of providing a configuration value to a function in the test, but it sounds like perhaps it's a Zebra config file and that it's an integration test, so I see how that could be tricky. I withdraw my suggestion heh. > Now, this strays from the main topic a bit, but as far as I can tell last > YAZ 4 release was in 2013. That's pretty ancient. Could we decide not to fix > the tests for such an old version? That's an interesting question. Looking at https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in Jessie and Stretch, but Buster and Bullseye use YAZ 5. Perhaps we could specify a YAZ 4 run time dependency and YAZ 5 as a build dependency in the Debian control file? But then we probably should be building on the same OSes that we're supporting at run time, so I think perhaps we do have to support YAZ 4 behaviour until we don't support Debian Stretch anymore? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21892] Robin Sheat is not a typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #21 from David Cook --- (In reply to Marcel de Rooy from comment #4) > Just ignore false messages? We might end up adding all names.. Ignoring false messages sounds reasonable to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23756] Appendix for workflows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Christopher, I like the idea. Maybe something for the docs meeting as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 --- Comment #3 from Katrin Fischer --- Very impressed with the German in the commit message! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Katrin Fischer changed: What|Removed |Added Attachment #93749|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 94108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94108=edit Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23811] New: Line breaks in MARC fields 520 not visible in OPAC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23811 Bug ID: 23811 Summary: Line breaks in MARC fields 520 not visible in OPAC view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: kugler_ste...@hotmail.com QA Contact: testo...@bugs.koha-community.org Input fields for MARC fields 520 (tested for summary 520 ## $a and review 520 1# $a) allow line breaks, which are converted to -tags in the "Descriptions" tab for a biblio item (intranet view). But there are no line breaks for this text in the opac view. I think both views should look the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 Katrin Fischer changed: What|Removed |Added CC||johanna.ra...@koha-suomi.fi --- Comment #9 from Katrin Fischer --- *** Bug 22545 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Katrin Fischer changed: What|Removed |Added Status|In Discussion |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #10 from Katrin Fischer --- Changing this to a duplicate of bug 23322 then. *** This bug has been marked as a duplicate of bug 23322 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #13 from Katrin Fischer --- Actually, still an issue on 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|Patch doesn't apply |RESOLVED CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer --- Verified that collection is now exported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18783] Allow automatic claims for serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 --- Comment #10 from Katrin Fischer --- I am sorry, doesn't apply - can we get another rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20389] Indexing fields concatenated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20389 --- Comment #6 from Katrin Fischer --- (In reply to Séverine Queune from comment #5) > Just tried in master : concatenation works fine using parenthesis : 700(ab) Hi Claire, does this solve the problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23791] Allow granular control of social networks enabled by SocialNetworks syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 --- Comment #3 from Katrin Fischer --- Created attachment 94107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94107=edit Bug 23791: (follow-up) Fix database update description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23791] Allow granular control of social networks enabled by SocialNetworks syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Owen, could you have another look please? Only the Twitter link works for me, the other icons/networks don't show up. yarn build --view opac was run and also multiple restart all... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Katrin Fischer changed: What|Removed |Added Attachment #94019|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 94106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94106=edit Bug 23528: Show 'log in to add tags' link on all search result entries This patch modifies the OPAC search result template so that each result shows the "Log in to add tags" link instead of just the first. To test, apply the patch and make sure TagsEnabled and TagsInputOnList are both enabled. Perform a search in the OPAC while not logged in. In the list of results, the "Log in to add tags" link should appear with every result. Log in to the OPAC and confirm that the "Add tag" link appears as expected. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19716] Add option to send header line for CSV output with runreport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23327 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23327] Optionally add column headings to emailed reports generated by the runreport.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23327 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19716 CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- It looks like we have this option for CSV now (bug 19716). This could use the same parameter maybe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What|Removed |Added Summary|Problem with renewal period |Problem with renewal period |when using the renewal tab |when using the renewal tab |in 19.05.03 | Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What|Removed |Added Attachment #93746|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 94105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94105=edit Bug 23551: Fix AddRenewal call in circ/renew.pl Without the patch, renewing from the renewal tab/page led to wrong renewal/due dates. To test: - Check an item out to your patron account - Renew it from the patron account - Note the due date - Return the item - Check the item out again - Renew it using the renewal tab - Verify a different due date was calculated - Apply patch - Repeat test - due dates now should be the same Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Katrin Fischer changed: What|Removed |Added Summary|Batch modification tool |Batch modification tool |orders items by barcode |orders items by barcode |incremental by default |incremental by default |(different behavior than|(regression to 17.11) |17.11) | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21487] Add option to disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21487 Katrin Fischer changed: What|Removed |Added Summary|Disable CataloguingLog |Add option to disable |syspref in |CataloguingLog syspref in |UNIMARC_sync_date_created_w |UNIMARC_sync_date_created_w |ith_marc_biblio.pl |ith_marc_biblio.pl Status|In Discussion |ASSIGNED CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Changing out of discussion - I think agreement to add a parameter was reached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|catalog 'Call Number|'Call Number Browser' on |Browser' on edit items |edit items screen uses the |screen uses the default |default classification |classification source |source rather than the item |rather than the item|specific source |specific source | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #6 from Katrin Fischer ---
I am not sure about these fallbacks in the code - can you please explain?
+# we should use the unitprice if included
+my $cost_tax_included = $order->{unitprice_tax_included} ||
$order->{ecost_tax_included};
+my $cost_tax_excluded = $order->{unitprice_tax_excluded} ||
$order->{ecost_tax_excluded};
+$order->{tax_value_on_ordering} = (
get_rounded_price($cost_tax_included) - get_rounded_price($cost_tax_excluded) )
* $order->{quantity};
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|unitprice tax column values |Unitprice tax column values |are not populated if|are not populated if |entered upon ordering |entered upon ordering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #5 from Katrin Fischer --- I think usually the 'actual price' is entered on receive - can you explain the use case for entering it on order? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 --- Comment #1 from Katrin Fischer --- Created attachment 94104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94104=edit Bug 22814: Make patron names on holds modal consistent (second check-in) Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. To test: - Place a hold on an item - Check in the item to trigger the hold modal - Confirm hold - Check the item in again - verify name of patron displays - Apply patch - Repeat - Verify name display now matches between the two modals - change HidePatronName pref - Repeat - Name display should still match -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Katrin Fischer changed: What|Removed |Added Status|NEW |ASSIGNED CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 --- Comment #3 from Katrin Fischer --- Created attachment 94103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94103=edit Bug 22677: Include hint to OAI page path on OAI-PMH preference This copies the way we are doing it for othe rprefs (ILSDI and similar) and adds a hint to the description to make it easier to find the right path for the OAI server. To test: - Apply patch - Verify that the system preference for OAI-PMH includes now a hint to: /cgi-bin/koha/oai.pl?verb=Identify - Verify the hint is correct (add OPAC base URL) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16446] Allow librarians to add borrowers to lists by borrowernumber or cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 Katrin Fischer changed: What|Removed |Added CC||ha...@orex.es --- Comment #6 from Katrin Fischer --- *** Bug 23810 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23810] upgrade fail when reserves waitting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23810 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This looks like a duplicate of bug 23809. Please reopen if I am mistaken. *** This bug has been marked as a duplicate of bug 23809 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 Katrin Fischer changed: What|Removed |Added Attachment #94042|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 94102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94102=edit Bug 23525: (bug 19289 follow-up) Use biblio's framework not ACQ This patch restores the behavior prior to commit 84ce1fb5921cdddf2368f0c330dede0f602742d0 Bug 19289: Use the ACQ framework to display bibliographic details Test plan is hard to provide for such a simple and obvious change. I would recommend you to read the previous commit and confirm that the change did not make sense. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Katrin Fischer changed: What|Removed |Added Attachment #94041|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 94101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94101=edit Bug 23038: Remove unused stderr vars Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Katrin Fischer changed: What|Removed |Added Attachment #90678|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 94100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94100=edit Bug 23038: Hide expected warnings from tests When tests are ran, there are 2 warnings that are expected and raised by DBI. As they are expected they must be correctly caught and not displayed. We could have reconnect with PrintError turned off, but then reconnect with it on. Test plan: % prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Suggestions.t Must not display DBI warnings Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #21 from Jonathan Druart --- Kyle, I have tried to rebase the patch but I lost myself in the tests. Could you have a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #20 from Jonathan Druart --- Created attachment 94099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94099=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. Signed-off-by: Kyle M Hall Signed-off-by: Martha Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21892] Robin Sheat is not a typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #20 from Robin Sheat --- :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |martin.renvoize@ptfs-europe |ommunity.org|.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Attachment #90682|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 94098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94098=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 --- Comment #3 from Corinne Hayet --- both if you add a subfield using "edit/add subfield" menu or using import framework function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #42 from Jonathan Druart --- Still waiting for another QA feedback, back to NQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 --- Comment #2 from Corinne Hayet --- yep, we use 18.11.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 --- Comment #8 from Jonathan Druart --- See comment 1 and the patch I linked to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21892] Robin Sheat is not a typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Jonathan Druart changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #19 from Jonathan Druart --- Too much time spent on this, won't fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22988] Visible reduction in image quality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 --- Comment #9 from Jonathan Druart --- I will need a step-by-step plan to recreate, as well as an image (or at least a link). While waiting for a correct fix it seems that we should consider a revert of the original patch to prevent the problem to propagate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Corinne, can you confirm you still get this error using the last 18.11.x version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12561 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- What about removing the code? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23663 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #201 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23691] Problem related access user and password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23691 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Works now. You should contact Orex if you are facing issues with their sandboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #200 from Tomás Cohen Arazi --- Created attachment 94097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94097=edit Bug 13937: (follow-up) Add missing entry to koha-common.install Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Simple patch so going to take Jonathans SO and a PQA (especially as I've used this in production myself with an upgrade for a live customer this morning). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 94096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94096=edit Bug 23793: Unit tests This patch introduces full test coverage for the EmbedItems filter. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Filter/EmbedItems.t => SUCCESS: Tests pass! 3. Sign off :-D 4. Use it to improve Koha! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Small patch |Trivial patch Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94030|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 94095
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94095=edit
Bug 23793: Add an EmbedItems RecordProcessor filter for MARC::Record objects
This patch introduces a RecordProcessor filter for MARC::Record objects
that embeds MARC::Field's for each item that is passed to the processor.
Target usage:
my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ items, metadata ] }
);
my $opachiddenitems_rules;
eval {
my $yaml = C4::Context->preference('OpacHiddenItems') . "\n\n";
$opachiddenitems_rules = YAML::Load($yaml);
};
my @items = grep { !$_->hidden_in_opac({ rules => $opachiddenitems_rules })
@{$biblio->items->as_list};
my $record = $biblio->metadata->record;
my $processor = Koha::RecordProcessor->new(
{
filters => ('EmbedItems'),
options => {
items=> \@items
}
}
);
$processor->process( $record );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 94094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94094=edit Bug 23807: Unit tests This patch introduces tests for the Koha::Item->as_marc_field method. It tries to cover all the use cases. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS; Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #105 from Martin Renvoize --- Created attachment 94092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94092=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94008|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #106 from Martin Renvoize --- Created attachment 94093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94093=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94007|0 |1 is obsolete|| --- Comment #104 from Martin Renvoize --- Created attachment 94091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94091=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94006|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 94090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94090=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94005|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 94089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94089=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94001|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 94085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94085=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94002|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 94086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94086=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94004|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 94088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94088=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94003|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 94087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94087=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94000|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 94084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94084=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93999|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 94083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94083=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93997|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 94081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94081=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93995|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 94079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94079=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93994|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 94078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94078=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93993|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 94077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94077=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93996|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 94080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94080=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE Capitalise reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93998|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 94082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94082=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93992|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 94076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94076=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93991|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 94075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94075=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93990|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 94074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94074=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #93989|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 94073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94073=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #11 from Andreas Hedström Mace --- (In reply to Sally from comment #10) > ...but I can't see how to implement your suggestion of using TransferSlip > instead of HoldSlip? The two notices don't share the same object variables > - hold and borrower aren't available in TransferSlip, so how would we > identify something as being on hold? I had missed that those objects aren't available for the transfer-slip. So making the new bahviour optional as Katrin suggest makes more sense than adding more objects to the transfer slips. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #10 from Sally --- (In reply to Andreas Hedström Mace from comment #7) > I still see Johannas approach as the more valid one, especially concerning > issues of data privacy. For Sallys use case, I would suggest changing the > approach: adding holds information to the transfer slips using the IF > statement in the TT syntax, rather than keeping todays behaviour. Thanks Katrin - making it optional would be a good solution. Andreas - as long as our workflow can remain the same (it is vital that staff packing and unpacking items in transit can differentiate on the printed slip between low and high priority transfers - i.e. ordinary returns vs items on hold), I don't mind how we approach this. ...but I can't see how to implement your suggestion of using TransferSlip instead of HoldSlip? The two notices don't share the same object variables - hold and borrower aren't available in TransferSlip, so how would we identify something as being on hold? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #9 from Andreas Hedström Mace --- (In reply to Katrin Fischer from comment #8): Yes, it might make most sense to make it optional. I see your point. I'm just thinking that there are so many system preferences in Koha, that new ones should be added carefully. But here it makes sense. =) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
