[Koha-bugs] [Bug 23845] New: Dashboard for database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23845 Bug ID: 23845 Summary: Dashboard for database Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I see that there is a bug in the works (or was in the works) for something like this: bug 6828. Would like to see something that would report on database health, especially on dead information. Like deleted and withdrawn elements that are stored in tables. Basically, things that could be pruned once in a while. Maybe have some tools available in the dashboard that would help to do the pruning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Myka Kennedy Stephens --- Patch does not apply. Here is the behavior I'm seeing in my test: On master, without the patches from this bug applied: 1. Create a new serial subscription 2. Set the first publication date to a date in 2016 3. Set the subscription start date to a recent date in 2019 4. Set subscription length to 104 issues ** Also set frequency to weekly, numbering pattern to number beginning with number 1 5. Test prediction pattern ** This results in a pattern that is for numbers 1-104 beginning with the date of the first issue. The subscription start date is not included in the predictions listed because it is beyond the 104 issues. 6. Apply patch * Repeat steps 1-5 7. Test prediction pattern ** The results match the prediction pattern prior to applying the patch. When you save the subscription, the issue expected is Issue No. 1 from 2016, not the issue that corresponds with the subscription start date. The expected/desired behavior is for Koha to start the prediction pattern based on the subscription start date, listing the number of issues based on the subscription length value. Koha will need to calculate the issue number based on the numbering pattern and the first issue publication date. What is presently happening is the prediction pattern is based on the first date of publication and length of subscription. This is a problem for libraries that start a new subscription in the middle of a publication, need to predict issues from the starting point of their subscription, and want to preserve the first date of publication in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 --- Comment #1 from Nick Clemens --- Created attachment 94416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94416=edit Bug 23844: Check if field defined in framework and specify 'Default' for framework To test: 1 - Go to Cataloguing 2 - New from Z3950 3 - Find an import a record 4 - Check the plack logs: Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 565. Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 580. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 711. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 715. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 734. 5 - Apply patch 6 - Repeat 7 - No new errors 8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates no errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23844] New: Noisy warns in addbiblio.pl when importing from Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Bug ID: 23844 Summary: Noisy warns in addbiblio.pl when importing from Z3950 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: 1 - Go to Cataloguing 2 - New from Z3950 3 - Find an import a record 4 - Check the plack logs: Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 565. Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 580. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 711. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 715. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 734. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23736] Advanced Editor: Search by Control Number not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23736 --- Comment #5 from Cori Lynn Arnold --- Okay, great workaround, but we'd love to see this working in the "Advanced Search" area as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||23770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 [Bug 23770] Add Koha::Object(s)->to_api method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] New: Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Bug ID: 23843 Summary: Make existing endpoints use Koha::Object(s)->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Now we made the decision to move the to_api logic to the Koha::Object-level, we need to migrate the existing endpoints. This will be done without touching the tests at this stage, to prove no behavior change takes place. Once it is done, a new bug will remove the existing mappings in the API controllers, and adjust the tests accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23736] Advanced Editor: Search by Control Number not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23736 --- Comment #4 from Nick Clemens --- (In reply to Cori Lynn Arnold from comment #3) > Nick, thanks for looking into this, but I am not seeing anyway to search > "Local-number" in the Advanced Editor? Am I missing something? > > https://paste.pics/b86b3bb78a94487d57cb9623c649dd0e You can search that in the general koha search bar, just enter: Local-number: faw00039489 it shoudl have no results Control-number should find the correct record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23736] Advanced Editor: Search by Control Number not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23736 --- Comment #3 from Cori Lynn Arnold --- Nick, thanks for looking into this, but I am not seeing anyway to search "Local-number" in the Advanced Editor? Am I missing something? https://paste.pics/b86b3bb78a94487d57cb9623c649dd0e -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23837] detail.pl contains a lot of whitespace in the td.status cell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23837 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > That will not be the only place where you will see something like this. When > writing TT syntax, it leaves 'whitespace' in the code, unless you do > something like [%- ... -%]. > > See: > http://www.template-toolkit.org/docs/manual/Syntax. > html#section_Chomping_Whitespace > > It will not hurt the output either way. HTML doesn't care about extra spaces. It doesn't hurt the output, until you try to manipulate it with jQuery. Then it becomes a nightmare. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23736] Advanced Editor: Search by Control Number not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23736
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--- Comment #2 from Nick Clemens ---
For the 'Control number' field in rancor advanced search we actually map it to
"attr 1=12" which is Local-number
In Unimarc we map 001 into Local-number, but in MARC21 we map it to
Contorl-number
to test, try a search for:
Local-number: faw00039489
vs
Control-number: faw00039489
koha-tmpl/intranet-tmpl/lib/koha/cateditor/search.js:
25 var _pqfMapping = {
26 author: '1=1003', // s=al',
27 cn_dewey: '1=13',
28 cn_lc: '1=16',
29 date: '1=30', // r=r',
30 isbn: '1=7',
31 issn: '1=8',
32 lccn: '1=9',
33 local_number: '1=12',
34 music_identifier: '1=51',
35 standard_identifier: '1=1007',
36 subject: '1=21', // s=al',
37 term: '1=1016', // t=l,r s=al',
38 title: '1=4', // s=al',
39 }
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #205 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #204) > Rebased and pushed addition QA followups to the github branch. > > I'm unable to replicate your test failures at the moment and have tried with > 6 different datasets... sorry but I'm going to struggle to fix that one > without being able to replicate it :(. OK Coming back to it soon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #15 from Lari Taskula --- Created attachment 94413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94413=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store invalid YAML syntax into OpacHiddenItems preference 3. Observe error 4. You should also see line and column number of where the error occured -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Lari Taskula changed: What|Removed |Added Attachment #91863|0 |1 is obsolete|| --- Comment #14 from Lari Taskula --- Created attachment 94412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94412=edit Bug 20930: Display human readable errors in preferences page Displays human readable error when YAML/JSON preference has invalid syntax. If multiple preferences are modified at the same time, notifies librarian of the preferences that were saved and the ones that had errors. To test: 1. Apply patches 2. Write invalid YAML syntax to OpacHiddenItems system preference 3. Observe "Error; Preference OpacHiddenItems has invalid syntax" error You should also receive a hint on line and column numbers of where the error occured. 4. Write valid YAML syntax to OpacHiddenItems system preference 5. Observe "Saved preference OpacHiddenItems" message 6. Test steps 2-5 for both single preference modification and together with other system preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23842] New: gui for export/import Patron permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23842 Bug ID: 23842 Summary: gui for export/import Patron permissions Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: frak...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be great to have some way how to batch changes to the staff (librarians) - either trough classes/groups or/and with some string or xml for interoperability between installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #7 from Devinim --- Created attachment 94411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94411=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #13 from Lari Taskula --- Would be nice to get this signed-off - it makes both sysadmins' and librarians' life easier as it is very simple to make mistakes in YAML syntax. Validations are usually pretty nice, especially in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #150 from Nick Clemens --- Minor conflict from new clipboard feature on rancor Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] ); Should be 'logged_in_user'? This is very awesome! It seems to work as expected for the most part, but I found some functional issues that I think must be addressed: After saving duplicate we should use the new record number and duplicate should be unchecked - is essentially 'Save as new'? Checking 'Catalog record ##' and 'New catalog record' would imply duplicate, but it doesn't do that - maybe we shouldn't have 'New catalog record' when editing an existing record? Similarly, saving as 'Duplicate' and 'New catalog record' creates two new records if I uncheck the current record. Saving to "Batch: test" and "test: #5" is confusing, do I need to check both? the Batch seems superfluous, I am not sure that unchecking the specific record and selecting only the batch is clear that we are creating a new record, maybe if a specific record is not checked we can show "Batch: test (new record)" The export feature is awesome - it would be nice to have this on the 'Manage staged records' page too, but not a blocker here Not a blocker, but if I revert and imported batch should I be able to manage that batch in Rancor? Similarly, if I stage a new batch I must reload rancor to be able to manage that batch Some overall GUI cleanup would be nice, but I think this can go as is with improvement later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23036] Optionally order facets by result hits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23036 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23841] New: Add a button to get from an item to it's biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Bug ID: 23841 Summary: Add a button to get from an item to it's biblio record Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: frak...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I think it would be handy to have some way how to get from detailed list of items as is this: ../cgi-bin/koha/catalogue/moredetail.pl?biblionumber=61855=66778 to it's biblio "parent": ../cgi-bin/koha/catalogue/detail.pl?biblionumber=61855 TL: Most of the time, librarians arrive to the item page trough it's biblio, but this is not a rule (for example many time we just click on barcode in Circulation module) and simple "back" in browser do not bring person much closer to desired record. I am open to suggestion about form how to do this, but only way I found (for staff without right to edit biblio) till today is to delete parameter "=66778" from URL - and that is not something, I want to teach my staff... Librarians, which are allowed to edit records, can push "Edit" rollout button and then "Edit Record", jump to the Editing, where just "Cancel" button bring them right where they need to be. Simple button with label "Record" (Or "Biblio") in one line with "New", "Edit", "Save", "Add to", "Print" and "Place hold" would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23346] Add without-db-name parameter to koha-dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23346 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23346] Add without-db-name parameter to koha-dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23346 Martin Renvoize changed: What|Removed |Added Attachment #92629|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 94410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94410=edit Bug 23346: Add without-db-name parameter to koha-dump Test plan: Run koha-dump [yourdb]. Rename the files in var/spool/koha/[yourdb] Run koha-dump --without-db-name [yourdb] Run a diff between the unzipped sql files. The last dump should not contain a CREATE DATABASE and USE statement. See BZ 15664 c4. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Attachment #93344|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 --- Comment #4 from Marcel de Rooy --- Created attachment 94409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94409=edit Bug 23700 - Fix output of koha-plack --restart To test: - Run "sudo koha-plack restart kohadev" and verify the output is out of line. - Apply the patch - If you are on e.g. kohadevbox you need to copy koha-plack to /usr/sbin/ thus: sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack - Run "sudo koha-plack restart kohadev" again and check that you get two lines of output, nicely aligned with the "OK" inside the square brackets. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy changed: What|Removed |Added Attachment #93441|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 94407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94407=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) Signed-off-by: Brendan Gallagher Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #6 from Marcel de Rooy --- Created attachment 94408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94408=edit Bug 23712: (QA follow-up) Silence two other warns too Caused by undefined method: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 859. Test plan: Run test again Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- t/db_dependent/Illrequests.t .. 4/11 Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 859. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry --- First thought: the inconsistent capturing behavior is the more pressing issue here. Let's not lose that while addressing the wording on the item details. Second: I like changing the item details message to just "there is a hold on this item." The greater context of who the hold is for, where it will be picked up, and what priority it's at is all just a click away on the Holds tab, where it is presented in a clearer, more contextualized fashion. Making the note in item details try to give all that information is trying to shove a lot of detail into a small box, which sets us up for misunderstandings when folks don't read that information carefully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1626] Trim whitespace from barcode inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1626 Tomáš Wünsch changed: What|Removed |Added CC||frak...@gmail.com Resolution|FIXED |--- Status|CLOSED |REOPENED --- Comment #1 from Tomáš Wünsch --- Are we only one, which still sometimes meet his problem? With our serials only, but it happen sometimes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #204 from Martin Renvoize --- Rebased and pushed addition QA followups to the github branch. I'm unable to replicate your test failures at the moment and have tried with 6 different datasets... sorry but I'm going to struggle to fix that one without being able to replicate it :(. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- loggedinusername == 1 ? Are you sure that this is correct? I am not ;) $user = $patron->firstname . ' ' . $patron->surname; $template->param( loggedinusername => $user ); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23840] New: Overlap of top menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23840 Bug ID: 23840 Summary: Overlap of top menu Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: frak...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 94403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94403=edit picture of graphical overlap of top menu For more then one or two SHORT links in IntranetNav variable in Staff Client Preferences (Appearance) and variable window size there is some interval of page width, when an visual overlap between top menu from the right one (user/library related & Help) to the left one(general) happen. In previous version this do not happen (right menu jump one row down instead). Examples of both is shown in an attachment: 19.05: https://i.imgur.com/4aVrcRt.png 18.11: https://i.imgur.com/y4iJeMD.png -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #14 from Nick Clemens --- (In reply to Katrin Fischer from comment #13) > We should not make such a change without fully understanding the why and how > here. That's why I pick 'in discussion'. If we end up doing it, I want to be > able to explain to the libraries why. Imagine Patron A has a 'next available' hold and Patron B has an item level hold on Item A To find the holds on an item we call Koha::Item::current_holds - this will returnholds on the specific item, it will never find 'next available' holds because they are not on a specific item - We will display Patron B At checkin we actually check the holds, and we check hold_fill_targets at some level. The effect being that if you have not run the holds queue the item will fill the higher priority hold for Patron A, however, if you have built the holds queue it could do a few things: If there are multiple items available then Patron A may get assigned Item B for the queue and Patron B will get Item A - for this scenario Item A will trigger for patron B If there is only one available item then Patron A will be assigned Item A and Item A will trigger Patron A This scenario seems reasonable, the holds queue is going to try and fill the holds so that both patrons can get the item they want if it can. For display though we would need to check the DB for both hold_fill_targets and specific holds. I don't think this information of who gets the hold is so important on details, since we will resolve it at checkout, I think simply letting the librarian know this item is held should suffice. I will ask around internally for more opinions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23835] ILL Module not working in 19.05, shows error in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23835 --- Comment #2 from b.paster...@gmail.com --- Unfortunately, this changed nothing. I removed block, so that it would look like this: ABC. About page shows the same error still. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #218 from Ere Maijala --- Not sure about thoroughness, but I've now added initial documentation on how to set this up: https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server. I also added notes and links to https://wiki.koha-community.org/wiki/APIs_and_protocols_supported_by_Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23839] New: Several dead links on community web site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23839 Bug ID: 23839 Summary: Several dead links on community web site Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzy...@gmail.com Reporter: anke.br...@gwdg.de On https://koha-community.org/documentation/other-docs/ several of the links do not work correctly: 1) While http://www.nexpresslibrary.org/training/ is reachable, following the link "Training", which leads to https://www.nexpresslibrary.org/training/ leads to a security warning in Firefox (probably NEKLS just have an old certificate?) 2) The link "Koha Presentations, Slideshare" to https://www.slideshare.net/search/slideshow?q=kohails leads to a message "Your search for kohails did not yield any results.[...]" 3) "Koha Testing plan", https://bywatersolutions.com/koha-testing-plan/, leads to " Page Not Found Template not found: koha-testing-plan" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23346] Add without-db-name parameter to koha-dump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23346 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23446] Fix display issue with serials navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23446 Martin Renvoize changed: What|Removed |Added Version(s)|19.11.00,19.05.04 |19.11.00,19.05.04, 18.11.10 released in|| CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #36 from Andrew Isherwood --- Created attachment 94402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94402=edit Bug 23051: (follow-up) Fix unit tests As raised by Nick in comment #35 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy --- Moving to SO: trivial change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825
--- Comment #3 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #1)
> FWIW I get the test passed with:
>
> -elsif( $_->{msg} =~ /Incorrect (?\w+) value:
> '(?.*)' for column '(?\w+)'/ ) {
> +elsif( $_->{msg} =~ /Incorrect (?\w+) value:
> '(?.*)' for column (?`\w+)/ ) {
>
>
> But I guess it will make it failed for someone else.
Yeah but we can make it a bit more flexible. See my patch. Could you QA it ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #2 from Marcel de Rooy --- Created attachment 94401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94401=edit Bug 23825: Koha/Object.t might fail on a backtick If the SQL error message contains a backtick instead of a regular quote, the regex for throwing an exception did not work. Example: Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` Note the backtics where the regex contains a regular quote. This patch makes it more flexible: it allows one \W character before the column name, even optional. Test plan: Run Koha/Object.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #203 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #199)
> Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
> branch.
>
> Thanks for your hard work.
> I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and
> continued on the current stand.
>
> Comments below are in order of time noted, not priority.
>
> User experience:
> During startup of admin/debit_types.pl I am seeing the 15 records for a
> short moment and end up with 3 records (filtered).
I agree, I not a fan of the "flash of unstyled content" effect this has but as
yet I've not managed to work around it.. I'll have another try.
> It would be nice to see them all and only allow editing of the non-system
> types ?
This is actually how I had it originally but updated the approach after
feedback from Nick and Severine. Perhaps just sorted the system and archived
ones to the bottom would be the best approach.. though I liked them being
interleaved so one could see why you could not create a new type with a code
that matched a system debit type.
> Same when saving a record (no blocker, but does not look good). When you do
> not want to show the records, do not fetch them at all?
> I saw that I now have a debit type F (Unexpected type found during upgrade).
I will take a look at adding some additional handling into the db update to
catch more cases of unrecognised types.. 'F' is obviously missed in certain
cases in previous bugs and should be caught and converted to proper 'OVERDUE'
types in my opinion. (I'm going to apply the patchset to a number of clones of
customers from various versions and try to spot some patterns to see what other
types may be being missed).
> Obviously this had to do with old fines stuff. I understand that bug 22521
> should have dealt with those, but somehow I still had such a record in
> accountlines. I am wondering if this will happen to more people and if we
> should anticipate on that by giving this F another description than
> unexpected ;)
>
> $dbh->do(
> qq{
> INSERT IGNORE INTO account_debit_types (
> code,
> description,
> can_be_added_manually,
> default_amount,
> is_system
> )
> SELECT
> SUBSTR(accounttype, 1, 80),
> "Unexpected type found during upgrade",
> 1,
> NULL,
> 0
> FROM
> accountlines
> WHERE
> amount > 0
> }
> );
> No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this
> query to eliminate a lof of ignored inserts.
Good catch, I'll update the update statement
> And a question: If this type is unexpected, why do we enable Add manually ?
Also a good catch, thanks :).
>
> sub UpdateFine
> You touch the following line, obviously only changing the type codes. But
> this is a condition for finding the overdues. Why type M in the first place,
> and why not yet another debit code?
> debit_type_code => [ 'OVERDUE', 'M' ],
> This needs fixing somehow but I agree that it should be done on its own
> report..
Totally agree, I've never been entirely sure why 'M' was in that list and have
been slowly working towards removing it by clarifying it's use in bugs like
this.
>
> sub GetFine
> +WHERE debit_type_code LIKE 'OVERDUE'
> Shouldnt that be = ?
Also agree, I remember coming accross that one and thinking the same but
forgetting to actually change it. Thanks :). (I think historically it comes
from when fines were 'F' and 'FU' so it was a `LIKE "F%"`.)
>
> flexability [a.o. :) ]
> No, not so flexible.
>
> sub adjust
> -my $account_type = $self->accounttype;
> [..]
> +my $debit_type_code = $self->debit_type_code;
> As I understand, the only allowed code is now overdue so debit. But this
> change does not look very solid to me. Hopefully, we will not adjust too
> much ;)
Not sure I follow.. I'll double check the code but I believe it checks against
'OVERDUE' + 'UNRETURNED' (mix of type + status)
>
> Copier Fees
> Database: | Copier Fees | Copier Fees |
> 1 | 0.25 | 0 |
> -INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
> ('MANUAL_INV','Copier Fees','.25');
> git grep 'Copier Fees'
> installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO
> `authorised_values` (category, authorised_value, lib) VALUES
> ('MANUAL_INV','Copier Fees','.25');
> Oops, you should remove that one above.
> Since we previously installed Copier Fees as a manual invoice, I think you
> should do now too. So add it too account_debit_types.sql.
> And Copier Fees should also have a new code. Now the description and code
> are the same. It is inconsistent with the other debit types. You also
> changed lots of other codes, or not?
I spotted that one this morning
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 --- Comment #31 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #24) > I set it back to SO because the failure I found was not related to the > patchset. Will re-check. Using koha-testing-docker here. Although I can cause a failure with prove too, I will not block this patch set since it seems that the regex in sub store should be improved and we opened a report for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Attachment #93895|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 94400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94400=edit Bug 23770: (follow-up) Use ->to_api in /cities This patch aims to prove the behaviour does not differ. So you can run the tests for the endpoints, and the behaviour remains. The mappings and methods cannot be removed until $c->objects->search is fixed to make use of them as well. That will happen once all used Koha::Object-based classes implement the mappings. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Attachment #93894|0 |1 is obsolete|| --- Comment #29 from Marcel de Rooy --- Created attachment 94399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94399=edit Bug 23770: (follow-up) Add tests for Koha::Objects->TO_JSON Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Attachment #93893|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 94398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94398=edit Bug 23770: Unit tests This patch introduces tests for the new to_api method introduced in Koha::Object(s). It uses Koha::City as a sample for simplicity. And it also uses Koha::Illrequests to test the case in which there's no to_api_mapping method defined on the class, to highlight that a fallback to calling TO_JSON is done. [1] [1] This is done under the assumption Illrequests controller code doesn't use any kind of mapping as the rest of the API controllers do, so there's little chance it would be added in a future. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t \ t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Attachment #93891|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 94396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94396=edit Bug 23770: Add Koha::Object(s)->to_api method Generic method that changes the attribute names of an object in the presence of the to_api_mapping method. It otherwise falls back to returning the TO_JSON output. This is WIP submitted early for scrutiny. Tests and example usage in an API controller coming. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Attachment #93892|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 94397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94397=edit Bug 23770: Add to_api_mapping method to Koha::City Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #1 from Andrew Isherwood --- Created attachment 94394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94394=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #2 from Andrew Isherwood --- Created attachment 94395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94395=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Andrew Isherwood --- Test plan - - Apply the patch - Navigate to Koha administration and locate the "RenewalLog" syspref - Ensure the syspref is initially set to "Don't log" - Navigate to Patrons - Find a patron with at least one loan, or loan an item to a patron - Renew an item that is on loan, feel free to do this a few times - Click "Circulation history" - TEST: Observe that the item renewal count is displayed but it is not possible to view details of the renewals - Navigate to Koha administration and locate the "RenewalLog" syspref - Set the syspref to "Log" - Return to the patron's loans - Renew the item a few more times - Click "Circulation history" - TEST: Note that the renewal count has increased appropriately, and there is now a "View" link - Click the "View" link - TEST: Observe that an "Item renewals" modal appears containing details of the renewals - TEST: Observe that, since not all renewals were logged, information about what proportion of renewals were logged is displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What|Removed |Added Blocks||17436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 [Bug 17436] Add a way to know in patron module where renew of an item was made -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Change sponsored?|Sponsored |--- Depends on||23838 --- Comment #7 from Andrew Isherwood --- It turns out that the development I have carried out for our customer, although similar to the requirements specified in this bug, has more basic requirements. Our customer simply wants to be able to click a link next to the renewal count and view details of renewal date and who the renewal was carried out by, all of which is currently recorded when the RenewalLog syspref is enabled. The requirements specified in this bug would require more work as the information they wish to display is not currently recorded. Consequently, I have create a new bug (Bug 23838) where I will attach the patches and test plan for the work I have done. Hopefully that work will ease the path for whoever tackles this bug. I will make this bug dependent on 23838. Apologies for the confusion! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 [Bug 23838] Add ability to view item renew history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] New: Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bug ID: 23838 Summary: Add ability to view item renew history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It should be possible, when viewing a patron's circulation history, to view details of an item's renewals. Each renewal should be displayed as: Renewed on by -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #202 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #201) > I saw that I still had data that conflicted with accounttype IS NOT NULL OR > debit_type_code IS NOT NULL; > > But when I removed that data and ran Accounts.t again, it still fails. So, we should make sure that at upgrade time we no longer have data that does not meet the new constraint. And still something wrong in the test ?? I leave it here for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #201 from Marcel de Rooy --- I saw that I still had data that conflicted with accounttype IS NOT NULL OR debit_type_code IS NOT NULL; But when I removed that data and ran Accounts.t again, it still fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #6 from Andrew Isherwood --- Ignore those patches and the test plan. I just realised there's something missing. Apologies! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #200 from Marcel de Rooy --- [FAIL] t/db_dependent/Accounts.t [OK] t/db_dependent/Circulation.t [OK] t/db_dependent/Circulation/NoIssuesChargeGuarantees.t [OK] t/db_dependent/Circulation/Returns.t [OK] t/db_dependent/Circulation/issue.t [FAIL] t/db_dependent/Koha/Account.t [OK] t/db_dependent/Circulation/issue.t [OK] t/db_dependent/Koha/Account/DebitType.t [OK] t/db_dependent/Koha/Account/DebitTypes.t [FAIL] t/db_dependent/Koha/Account/Lines.t [OK] t/db_dependent/Koha/Patron.t [OK] t/db_dependent/Reserves.t [OK] t/db_dependent/SIP/Transaction.t [FAIL] t/db_dependent/api/v1/patrons_accounts.t t/db_dependent/api/v1/patrons_accounts.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_master`.`accountlines`, CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `branchcode`, `date`, `debit_type_code`, `description`, `interface`, `manager_id`) VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ? )" with ParamValues: 0=50, 1=50, 2=2930, 3='wfeFkt_9', 4='N', 5='A description', 6='test', 7=2930] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. => Looks like the description is copied to the debit code ? The other tests stumble over: DBIx::Class::Storage::DBI::_dbh_execute(): CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` at /usr/share/koha/Koha/Object.pm line 156 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Attachment #94392|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Attachment #94393|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #199 from Marcel de Rooy ---
Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
branch.
Thanks for your hard work.
I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and
continued on the current stand.
Comments below are in order of time noted, not priority.
User experience:
During startup of admin/debit_types.pl I am seeing the 15 records for a short
moment and end up with 3 records (filtered).
It would be nice to see them all and only allow editing of the non-system types
?
Same when saving a record (no blocker, but does not look good). When you do not
want to show the records, do not fetch them at all?
I saw that I now have a debit type F (Unexpected type found during upgrade).
Obviously this had to do with old fines stuff. I understand that bug 22521
should have dealt with those, but somehow I still had such a record in
accountlines. I am wondering if this will happen to more people and if we
should anticipate on that by giving this F another description than unexpected
;)
$dbh->do(
qq{
INSERT IGNORE INTO account_debit_types (
code,
description,
can_be_added_manually,
default_amount,
is_system
)
SELECT
SUBSTR(accounttype, 1, 80),
"Unexpected type found during upgrade",
1,
NULL,
0
FROM
accountlines
WHERE
amount > 0
}
);
No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this query
to eliminate a lof of ignored inserts.
And a question: If this type is unexpected, why do we enable Add manually ?
sub UpdateFine
You touch the following line, obviously only changing the type codes. But this
is a condition for finding the overdues. Why type M in the first place, and why
not yet another debit code?
debit_type_code => [ 'OVERDUE', 'M' ],
This needs fixing somehow but I agree that it should be done on its own
report..
sub GetFine
+WHERE debit_type_code LIKE 'OVERDUE'
Shouldnt that be = ?
flexability [a.o. :) ]
No, not so flexible.
sub adjust
-my $account_type = $self->accounttype;
[..]
+my $debit_type_code = $self->debit_type_code;
As I understand, the only allowed code is now overdue so debit. But this change
does not look very solid to me. Hopefully, we will not adjust too much ;)
Copier Fees
Database: | Copier Fees | Copier Fees |
1 | 0.25 | 0 |
-INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
('MANUAL_INV','Copier Fees','.25');
git grep 'Copier Fees'
installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO
`authorised_values` (category, authorised_value, lib) VALUES
('MANUAL_INV','Copier Fees','.25');
Oops, you should remove that one above.
Since we previously installed Copier Fees as a manual invoice, I think you
should do now too. So add it too account_debit_types.sql.
And Copier Fees should also have a new code. Now the description and code are
the same. It is inconsistent with the other debit types. You also changed lots
of other codes, or not?
Does this hold for some other debit types too that were formerly hardcoded?
Stuff like sundry etc. ? Which actually is a horrible category..
+ [%- SWITCH account.debit_type_code -%]
+ [%- CASE 'ACCOUNT' -%]Account creation fee
+ [%- CASE 'ACCOUNT_RENEW'-%]Account renewal fee
+ [%- CASE 'LOST' -%]Lost item
+ [%- CASE 'M'-%]Sundry
+ [%- CASE 'NEW_CARD' -%]New card
+ [%- CASE 'OVERDUE' -%]Fine
+ [%- CASE 'PROCESSING' -%]Lost item processing fee
+ [%- CASE 'RENT' -%]Rental fee
+ [%- CASE 'RENT_DAILY' -%]Daily rental fee
+ [%- CASE 'RENT_RENEW' -%]Renewal of rental item
+ [%- CASE 'RENT_DAILY_RENEW' -%]Rewewal of daily rental item
+ [%- CASE 'RESERVE' -%]Hold fee
+ [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long
+ [%- CASE-%][% account.debit_type.description |
html %]
+ [%- END -%]
Note that koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc contains debit
code M for sundry while account_debit_types.sql install M as Manual fee !
This is a BLOCKER. Please correct.
At the credit side, I am seeing code FORW (and FOR and W and WO !) and having
doubts about it, leaving it outside the scope for now..
Submitting another comment for the failing tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website :
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Attachment #94391|0 |1 is obsolete|| --- Comment #4 from Andrew Isherwood --- Created attachment 94393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94393=edit Bug 17436: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff --- Comment #5 from Andrew Isherwood --- Test plan - - Apply the patch - Navigate to Koha administration and locate the "RenewalLog" syspref - Ensure the syspref is initially set to "Don't log" - Navigate to Patrons - Find a patron with at least one loan, or loan an item to a patron - Renew an item that is on loan, feel free to do this a few times - Click "Circulation history" - TEST: Observe that the item renewal count is displayed but it is not possible to view details of the renewals - Navigate to Koha administration and locate the "RenewalLog" syspref - Set the syspref to "Log" - Return to the patron's loans - Renew the item a few more times - Click "Circulation history" - TEST: Note that the renewal count has increased appropriately, and there is now a "View" link - Click the "View" link - TEST: Observe that an "Item renewals" modal appears containing details of the renewals - TEST: Observe that, since not all renewals were logged, information about what proportion of renewals were logged is displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Andrew Isherwood changed: What|Removed |Added Attachment #94390|0 |1 is obsolete|| --- Comment #3 from Andrew Isherwood --- Created attachment 94392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94392=edit Bug 17436: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 --- Comment #1 from Andrew Isherwood --- Created attachment 94390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94390=edit Bug 17436: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 --- Comment #2 from Andrew Isherwood --- Created attachment 94391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94391=edit Bug 17436: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #89724|0 |1 is obsolete|| --- Comment #9 from Arthur Suzuki --- Created attachment 94389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94389=edit Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Laurence Rault changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||laurence.ra...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #91784|0 |1 is obsolete|| --- Comment #8 from Arthur Suzuki --- Created attachment 94388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94388=edit Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Attachment #85414|0 |1 is obsolete|| --- Comment #3 from Arthur Suzuki --- Created attachment 94387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94387=edit Bug 22379 : Fix checks not made by ILS-DI method CancelHold Disable the possibility for a borrower to cancel a reservation which is either in a Transit or Waiting state. This reproduce the behaviour seen on the OPAC. Also replaces previous checks on the borrowernumber since CanReserveBeCanceledFromOpac already checks this. Test plan (before patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "RecordNotFound" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower Test plan (after patch) : -Put a reserve for a borrower -Try to cancel the reserve providing another borrowernumber as argument -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Try to cancel the reserve providing the borrowernumber the reserve is for. -> Should succeed, reply with "Canceled" -> Reserve do not show up in the list of holds for the borrower -Put a new reserve with a pickup branch != from the homebranch -Transfer the item to the pickup branch (reserve status = Transit) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. -Checkout the reserved item in the pickup branch (reserve status = Waiting) -Try to cancel the reserve (with proper borrowernumber) -> Should fail and reply "BorrowerCannotCancelHold" -> Reserve still appears in the list of holds. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23813] DB error on upgrade from 18.12 to 19.05.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- (In reply to Jonathan Druart from comment #2) > Confirmed, it happens if the item type of a circ rule has been deleted. > > Should we remove the rule silently? Create a temporary item type and display > a warning? > > Upping severity. I was always under the impression that they would be deleted by FK constraint (delete the itemtype, issuingrules cleans up...) So I'd opt for removing silently. There can be no items with this itemtype, so cleaning up the issuing rule makes sense to me, but wondering if there is a deeper issue to have them in the first place? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #13 from Katrin Fischer --- We should not make such a change without fully understanding the why and how here. That's why I pick 'in discussion'. If we end up doing it, I want to be able to explain to the libraries why. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #12 from Katrin Fischer --- Can you explain why the displayed patron would not be the one receiving the next item? I have thought about it, but fail to come up with a use case. And if it's not something that depends on environment (current library location or something) we should be able to fix it. Our libraries are mostly single branch and I think for them this works well and they would not like it being removed for some less informative text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #21 from Katrin Fischer --- This is a rather small change, so I don't want to block it any longer. Just 2 things: - There are no unit tests for the changes in Reserve.pm - I am not sure all libraries will be happy about people being able to move the pick-up date, as there is also a fine penalty in some for not picking up your holds, but for the same reason: others will like it. If you get a call that someone needs some extra time, you can do that now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Attachment #94372|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 94386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94386=edit Bug 22922: (follow-up) Markup corrections This patch adds a "size" attribute to the datepicker input fields and adds self-closing "/". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Attachment #89916|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 94384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94384=edit Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Attachment #89917|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 94385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94385=edit Bug 22922: Use jQuery datepicker instead of Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added Attachment #89915|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 94383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94383=edit Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
