[Koha-bugs] [Bug 23863] Editing a basket clears create_items value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Andrew Fuerste-Henry --- Signed off on behalf of Sarah Cornell - Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23863] Editing a basket clears create_items value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 ByWater Sandboxes changed: What|Removed |Added Attachment #94586|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 94597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94597=edit Bug 23863: Editing a basket clears create_items value Test Plan: 1) Create a basket with a non-default value for aqbasket.create_items 2) Click Edit from basket.pl 3) Click Save without changing anything 4) Note that aqbasket.create_items is no longer set 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Note create_items is unchanged! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23579] error during web install: 'changed_fields' can't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 Cindy Murdock Ames changed: What|Removed |Added CC||cmurd...@ccfls.org --- Comment #1 from Cindy Murdock Ames --- Just chiming in to say this affected me too, and seemed to prevent the database creation from being completed. Fixed it by the same method, removing " DEFAULT ''" from line 3398 of kohastructure.sql. This was a fresh package install of 19.05.04 on Ubuntu Server Edition 18.04.3, with mysql-server 5.7.27-0ubuntu0.18.04.1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 94596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94596=edit Bug 23843: Add mapping to Koha::Acquisition::Fund This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_funds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 94595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94595=edit Bug 23843: Add mapping to Koha::Acquisition::Bookseller This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 94594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94594=edit Bug 23843: Add mapping to Koha::Item This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 94591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94591=edit Bug 23843: Add mapping to Koha::Hold This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 94593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94593=edit Bug 23843: Add mapping to Koha::Patron This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 94592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94592=edit Bug 23843: Add mapping to Koha::Library This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 94590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94590=edit Bug 23843: Add mapping to Koha::Club::Holds This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/clubs_holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 94589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94589=edit Bug 23843: Add mapping to Koha::Checkout This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/checkouts.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 94587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94587=edit Bug 23843: Make funds endpoint tests more robust Now that we use ->to_api all the object attributes are returned, so the original tests that didn't follow the FKs would pass, and now they don't. If there is no budget linked to the fund, it will return undef, which is not accepted on the API (though it accepts not returning the attribute). To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_funds.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 94588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94588=edit Bug 23843: Add mapping to Koha::Account::Line This patch adds a to_api_mapping method to the class. This in effect enables calling ->to_api on the object. The mapping is borrowed from the API controller. It is not removed from the controller so we are able to verify (through the tests) that there is no behavior change. Once this is pushed we need to implement the counter-wise methods and clean the controllers. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94512|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94511|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94514|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94513|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94509|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94507|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94506|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94510|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94508|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #94496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23863] Editing a basket clears create_items value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23863] Editing a basket clears create_items value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23863] Editing a basket clears create_items value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 --- Comment #2 from Kyle M Hall --- Created attachment 94586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94586=edit Bug 23863: Editing a basket clears create_items value Test Plan: 1) Create a basket with a non-default value for aqbasket.create_items 2) Click Edit from basket.pl 3) Click Save without changing anything 4) Note that aqbasket.create_items is no longer set 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Note create_items is unchanged! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23633] Filter out historical charges by default on a users 'your charges' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23633 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23880] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23880 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Summary|No control! |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23881] New: No control!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23881 Bug ID: 23881 Summary: No control! Change sponsored?: --- Product: Koha Version: 18.05 Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: achievekogul...@gmail.com QA Contact: testo...@bugs.koha-community.org Cannot control economy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23880] New: No control!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23880 Bug ID: 23880 Summary: No control! Change sponsored?: --- Product: Koha Version: 18.05 Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: achievekogul...@gmail.com QA Contact: testo...@bugs.koha-community.org Cannot control economy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 94584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94584=edit Bug 23860: Make the patrons endpoint add the Location header Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 94583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94583=edit Bug 23860: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 94585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94585=edit Bug 23860: Update tests to new style Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23878] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23878 Owen Leonard changed: What|Removed |Added Summary|Test|SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23879] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23879 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|No control! |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23878] Test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23878 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23879] New: No control!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23879 Bug ID: 23879 Summary: No control! Change sponsored?: --- Product: Koha Version: 18.05 Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: achievekogul...@gmail.com QA Contact: testo...@bugs.koha-community.org Cannot control economy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23878] New: Test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23878 Bug ID: 23878 Summary: Test Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: achievekogul...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14228] fill in patron info by scanning an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 --- Comment #3 from Owen Leonard --- This might be a good candidate for a plugin since the functionality would be US-specific. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23317] Elasticsearch - IntranetCatalogSearchPulldown breaks searching indexes via query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23317 --- Comment #4 from Nick Clemens --- So this actually works in master currently, as long as 'keyword' is selected. If you try to select 'Title' in the dropdown and then search 'au:dickens' it fails Do we need to support searches like that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What|Removed |Added Keywords||needs_rfc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14228] fill in patron info by scanning an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 --- Comment #2 from Christopher Brannon --- Would be interested in seeing a tool in the new patron form that would allow you to scan the barcode on the driver's license and grab information like patron name, birth date, address, etc, and fill in the appropriate fields. Data appears to be marked, similar to SIP data. We could make it so libraries could select what data is imported from the license, and format it properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14228] fill in patron info by scanning an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Andrew Fuerste-Henry changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #1 from Andrew Fuerste-Henry --- *** Bug 23877 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23877] Scan code on driver's license and fill in selected fields for new patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23877 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 14228 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23633] Filter out historical charges by default on a users 'your charges' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23633 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23633] Filter out historical charges by default on a users 'your charges' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23633 Owen Leonard changed: What|Removed |Added Attachment #94532|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 94582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94582=edit Bug 23633: Hide paid transactions by default on the OPAC This patch adds filtering on paid for type transactions to the OPAC accounts page. The filtering is enabled by default but may be toggled to show historical transactions. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 SiobhanC changed: What|Removed |Added CC||siobhancot...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #8 from Nick Clemens --- Created attachment 94581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94581=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What|Removed |Added Attachment #91913|0 |1 is obsolete|| Attachment #91914|0 |1 is obsolete|| Attachment #91915|0 |1 is obsolete|| Attachment #94537|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 94580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94580=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23877] New: Scan code on driver's license and fill in selected fields for new patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23877 Bug ID: 23877 Summary: Scan code on driver's license and fill in selected fields for new patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Would be interested in seeing a tool in the new patron form that would allow you to scan the barcode on the driver's license and grab information like patron name, birth date, address, etc, and fill in the appropriate fields. Data appears to be marked, similar to SIP data. We could make it so libraries could select what data is imported from the license, and format it properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23876] New: Holds queue section says it "shows all of the holds at your library" which is not true
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23876 Bug ID: 23876 Summary: Holds queue section says it "shows all of the holds at your library" which is not true Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org We have to change the Holds queue section as it says "This report will show you all of the holds at your library." I talked with Katrin and Nick on IRC and they told me it's more of a "holds to pull" report for large systems or consortia. As of writing this, there is no report that show all of the holds at your library. There is a demand for this (see bug #19749), but nothing has been done so far. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching for flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 Danielle Elder changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om --- Comment #4 from Danielle Elder --- CLI options would be nice too. ;) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18506] SSO - Shibboleth Only Mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens changed: What|Removed |Added Severity|normal |critical Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | --- Comment #4 from Nick Clemens --- Bumping relevancy, we must fix sorting before release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] Elasticsearch - ES - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Nick Clemens changed: What|Removed |Added Depends on||23089 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||alex.arn...@biblibre.com, ||ere.maij...@helsinki.fi, ||glask...@gmail.com, ||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 [Bug 23089] Elasticsearch - cannot sort on non-text fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens changed: What|Removed |Added Blocks||23875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 [Bug 23875] Elasticsearch - ES - When sorting by score we should provide a tiebreaker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #3 from Tomáš Wünsch --- temporary solution: - about:config in FF - security.mixed_content.block_active_content setup to "false". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] Elasticsearch - ES - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 --- Comment #1 from Nick Clemens --- Created attachment 94579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94579=edit Bug 23875: Explicitly srt searches by score and provide local-number as tie breaker To test: 1 - Set search engine to ES 2 - Search the catalog for "*" 3 - Note results 4 - Edit first result 5 - Repeat search, results are reordered 6 - Apply patch 7 - Search for "*" 8 - Highest biblionumbers are returned first 9 - Edit first result, repeat search 10 - Order does not change 11 - Confirm sorting by author, title, etc passes the same trials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] Elasticsearch - ES - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching for flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #3 from Kelly McElligott --- Yes this would be super helpful! I would agree . -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] New: Elasticsearch - ES - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Bug ID: 23875 Summary: Elasticsearch - ES - When sorting by score we should provide a tiebreaker Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com In ES if we sort by 'relevance' we actually don't pass anything to ES and results are ordered by score. When doing a search limiting only by collection or type, the scores are all the same. This is fine, except that editing any record will then cause a reordering of the results, even though it won't affect the score. We should provide a tie-breaker in the case of equal sort scores -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Martin Renvoize changed: What|Removed |Added Keywords||needs_rfc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #118 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #117 from Martin Renvoize --- Looks good and works well.. passes the QA scripts... Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94240|0 |1 is obsolete|| --- Comment #112 from Martin Renvoize --- Created attachment 94573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94573=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94238|0 |1 is obsolete|| --- Comment #110 from Martin Renvoize --- Created attachment 94571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94571=edit Bug 22445: Custom cover images - opac user (checkout list) Test plan: - Check an item out to a patron - At the OPAC loggin as this patron On the checkout list you should see the cover image. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94243|0 |1 is obsolete|| --- Comment #115 from Martin Renvoize --- Created attachment 94576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94576=edit Bug 22445: Add new pattern %normalized_isbn% Quite bad to use C4::Koha from Koha::Biblio :-/ Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #2 from Tomáš Wünsch --- Created attachment 94578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94578=edit printscreen from console - http needed on https connection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94242|0 |1 is obsolete|| --- Comment #114 from Martin Renvoize --- Created attachment 94575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94575=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client This patch adds some CSS and markup to staff client templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. This patch also adds a missing to fix display problems. To test, apply the patch and regenerate the staff client CSS. Post an oversized image which corresponds to a record in your catalog. View the following pages to confirm that the image displays well: - Catalog search results - Bibliographic detail page Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94239|0 |1 is obsolete|| --- Comment #111 from Martin Renvoize --- Created attachment 94572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94572=edit Bug 22445: Custom cover images - detail (staff) Test plan: Staff side now, go the detail page of a bibliographic record You should see the cover image. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94241|0 |1 is obsolete|| --- Comment #113 from Martin Renvoize --- Created attachment 94574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94574=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - OPAC This patch adds some CSS and markup to OPAC templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. To test, apply the patch and regenerate the OPAC CSS. Post an oversized image which corresponds to a record in your OPAC which can be added to a user's checkouts and to a list. View the following pages to confirm that the image displays well: - OPAC search results - Bibliographic detail page - Shelf browser - List contents - Recent comments - "Your summary" Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445
Martin Renvoize changed:
What|Removed |Added
Attachment #94244|0 |1
is obsolete||
--- Comment #116 from Martin Renvoize ---
Created attachment 94577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94577=edit
Bug 22445: Replace %% with {}
Sponsored-by: Orex Digital
Signed-off-by: Hayley Mapley
Signed-off-by: Hugo Agud
Signed-off-by: Owen Leonard
Signed-off-by: Michal Denar
Signed-off-by: Kyle Hall
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94237|0 |1 is obsolete|| --- Comment #109 from Martin Renvoize --- Created attachment 94570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94570=edit Bug 22445: Custom cover images - opac reviews (rss) Test plan: Same as previous patch, then click on the feeds link Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94236|0 |1 is obsolete|| --- Comment #108 from Martin Renvoize --- Created attachment 94569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94569=edit Bug 22445: Custom cover images - opac reviews Test plan: - enable OpacShowRecentComments - make a comment (OPAC) - approve it (staff) - click 'Recent comments' (OPAC) => You should see the custom cover Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94233|0 |1 is obsolete|| --- Comment #105 from Martin Renvoize --- Created attachment 94566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94566=edit Bug 22445: Custom cover images - opac detail Test plan: Go to the bibliographic record detail page at the OPAC, you should see the custom cover image. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94234|0 |1 is obsolete|| --- Comment #106 from Martin Renvoize --- Created attachment 94567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94567=edit Bug 22445: Custom cover images - opac result (rss) This cannot be tested, it seems that the template is broken. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94231|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 94563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94563=edit Bug 22445: Custom cover images - opac shelfbrowser Test plan: Go to the detail page of a bibliographic record (at the OPAC) and confirm the at custom cover images are displayed in the shelf browser Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #1 from Tomáš Wünsch --- Created attachment 94565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94565=edit printscreen of security failure -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94235|0 |1 is obsolete|| --- Comment #107 from Martin Renvoize --- Created attachment 94568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94568=edit Bug 22445: Custom cover images - opac shelves Test plan: Add a bibliographic record (that has a custom image) to a shelf, view the shelf (OPAC). You should see the image. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94232|0 |1 is obsolete|| --- Comment #104 from Martin Renvoize --- Created attachment 94564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94564=edit Bug 22445: Custom cover images - opac results Test plan: Search for bibliographic records at the OPAC, the custom cover should be displayed Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94230|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 94562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94562=edit Bug 22445: Allow marc fields as pattern %tag$field% There is a limitation here, only one replacement will work. Let see if it is needed later to support several patterns Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94228|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 94560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94560=edit Bug 22445: Add new method Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize changed: What|Removed |Added Attachment #94229|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 94561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94561=edit Bug 22445: Add tests for Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley Signed-off-by: Hugo Agud Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Kyle Hall Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445
Martin Renvoize changed:
What|Removed |Added
Attachment #94227|0 |1
is obsolete||
--- Comment #99 from Martin Renvoize ---
Created attachment 94559
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94559=edit
Bug 22445: Add new prefs *CustomCoverImages*
This patch set adds a new method to display cover images for
bibliographic records.
The idea is to provide a flexible way allowing several use cases:
- local path
- remote url
- webservice
which would follow a given pattern.
So far only the following patterns are available:
- {isbn} will be replaced byt the isbn of the record
- {issn}
- using MARC subfields:
{024$a} to replace with the value in 024$a
(Note that the selector has been changed from %% to {} in a coming
patch)
For example
- /your/local/images/{isbn}.png
- https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb
- etc.
There are 3 new sysprefs:
CustomCoverImagesURL
=> Define the path/url
CustomCoverImages
=> Turn on/off the display of the custom cover image in the staff client
OPACCustomCoverImages
=> Turn on/off the display of the custom cover image at the OPAC
Sponsored-by: Orex Digital
Signed-off-by: Hayley Mapley
Signed-off-by: Hugo Agud
Signed-off-by: Owen Leonard
Signed-off-by: Michal Denar
Signed-off-by: Kyle Hall
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #42 from Andrew Isherwood --- Hi Martin - The renewal is carried out from within Koha::Account::pay if the syspref is turned on and the issue meets the required conditions, so even if the plugins are not explicitly calling the renewal, it will still happen anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Tomáš Wünsch changed: What|Removed |Added Priority|P5 - low|P4 Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] New: Advanced Editor is not loaded over HTTPS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Bug ID: 23874 Summary: Advanced Editor is not loaded over HTTPS Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: frak...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Symptoms: Loading, please wait... Editor of record is visually loaded in background, but over it is big endless running circle with announcement: "Loading, please wait... Source of problem: The script is by default blocked by browsers because there is some hardlink to HTTP content. Another details: - This is related both to 18.05 and 19.05, Firefox and Chrome, Win10 and Ubuntu, and it's behaving practically same. - We have in general disabled (forwarded) all unsecured traffic to https at our nginx rproxy server. Console output: Blocked loading mixed active content “http://demo.koha.cz/cgi-bin/koha/svc/cataloguing/framework?callback=define” editor.pl The resource from “https://demo.koha.cz/cgi-bin/koha/svc/cataloguing/framework?frameworkcode==define” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff). editor.pl
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #41 from Martin Renvoize --- As the maintainer of the Pay360 and WPM plugins, I'd be happy to remove the logic that attempts to renew items from within those plugins themselves and have that action taken from 'koha proper' as per sysprefs... Just my two cents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #40 from Andrew Isherwood --- Hi Nick >I am also not sure about the code path if a patron paid fines on the opac (via >paypal etc.) but renewals are not allowed on the opac. Looking at the code, the OPAC PayPal payment would cause items to be renewed as part of the fine payment. The same applies if the site is using the WPM or Capita payment plugins, I'm not sure of any others though I suspect the same would also be true for any payment plugin, essentially anything that pays the fines using the Koha::Account::pay function. I'm unsure what to do here. There seems to be a convention of passing a "note" parameter when calling the "pay" function. With the OPAC PayPal payment, the note is passed as "PayPal", with Capita it's "Pay360 Payment" etc. So, we could have a blacklist (not sure which would be best), which prevented the renewal from happening if the payment was passed a note containing one of these values, though that seems a bit fragile. If we are going to prevent renewal for payments made via the OPAC, we should probably highlight that in the syspref. Any thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Lari Taskula changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Lari Taskula changed: What|Removed |Added Attachment #94530|0 |1 is obsolete|| --- Comment #18 from Lari Taskula --- Created attachment 94557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94557=edit Bug 23233: (follow-up) Add description to atomic upgrade Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #9 from Joonas Kylmälä --- (In reply to Johanna Räisä from comment #8) > Created attachment 94555 [details] [review] > Bug 18795: (follow-up) Unify error message to be same across codebase > > In Koha/REST/V1/Patrons.pm the error message for not finding patron is > "Patron not found" so let's use the same here. > > Signed-off-by: Johanna Raisa You added the error message change here also in the test (which I had forgotten) so thanks for that little change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
