[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy changed: What|Removed |Added Attachment #95135|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 95182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95182=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy changed: What|Removed |Added Attachment #95133|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 95180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95180=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy changed: What|Removed |Added Attachment #95134|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 95181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95181=edit Bug 23949: Update documentation Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy changed: What|Removed |Added Attachment #95161|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 95179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95179=edit Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #120 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #119) > The database upgrade breaks on my kohadevbox setup (mysql-server package > version 5.7.27-0ubuntu0.18.04.1): Looking again at the error message the bug is probably from Bug 23049 and not this. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #12 from Marcel de Rooy --- Created attachment 95178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95178=edit Bug 21301: (QA follow-up) Fix number of tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #11 from Marcel de Rooy --- I do expect additional tests here too. Your test should show that the sensitive information is no longer in the output of GetRecords etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy changed: What|Removed |Added Severity|critical|major --- Comment #10 from Marcel de Rooy --- Lowering the severity to Major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #9 from Marcel de Rooy --- More serious: 2019-11-08 07:21:08 0 598 CPL 2019-11-22 23:59:00 perl01 690 0 2019-11-08 07:21:08 0 5 If you are concerned about borrowernumber in hold, then you should be for issue too. Inconsistent ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #8 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #2) > The issue data should not be sent by these service, its a privacy problem. 0 633 2019-11-08 07:06:05 5 0 2019-11-08 1 110 CPL 0 Is this really a privacy issue? In order to identify the person associated with borrowernumber 5, you'll need additional information. So if this is just theoretical, then removing the borrowernumber might not be enough ;) If I have biblionumber and reservedata or timestamp, I might also be able to find the associated borrower? No blocker, just pushing a bit.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #119 from Joonas Kylmälä --- The database upgrade breaks on my kohadevbox setup (mysql-server package version 5.7.27-0ubuntu0.18.04.1): > $ updatedatabase > Upgrade to 19.06.00.042 done (Bug 22445 - Add new pref *CustomCoverImages*) > DBD::mysql::db do failed: You have an error in your SQL syntax; check the > manual that corresponds to your MySQL server version for the right syntax to > use near 'IGNORE TABLE accountlines > ADD > debit_type_code ' at line 1 [for Statement " > ALTER IGNORE TABLE accountlines > ADD > debit_type_code varchar(80) DEFAULT NULL > AFTER > accounttype > "] at > /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19888. > DBD::mysql::db do failed: Key column 'debit_type_code' doesn't exist in table > [for Statement " > ALTER TABLE accountlines ADD CONSTRAINT > `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES > `account_debit_types` (`code`) ON DELETE RESTRICT ON UPDATE CASCADE > "] at > /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19901. > DBD::mysql::db do failed: Unknown column 'debit_type_code' in 'field list' > [for Statement " > UPDATE accountlines SET debit_type_code = accounttype, accounttype = > NULL WHERE accounttype IN (SELECT code from account_debit_types) > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl > line 19910. > Upgrade to 19.06.00.043 done (Bug 23049 - Add account debit_types) > DBD::mysql::db do failed: You have an error in your SQL syntax; check the > manual that corresponds to your MySQL server version for the right syntax to > use near 'IGNORE TABLE accountlines > ADD > credit_type_code' at line 1 [for Statement " > ALTER IGNORE TABLE accountlines > ADD > credit_type_code varchar(80) DEFAULT NULL > AFTER > accounttype > "] at > /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19992. > DBD::mysql::db do failed: Key column 'credit_type_code' doesn't exist in > table [for Statement " > ALTER TABLE accountlines > ADD CONSTRAINT > `accountlines_ibfk_credit_type` > FOREIGN KEY (`credit_type_code`) REFERENCES > `account_credit_types` (`code`) > ON DELETE RESTRICT > ON UPDATE CASCADE > "] at > /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 20005. > DBD::mysql::db do failed: Unknown column 'credit_type_code' in 'field list' > [for Statement " > UPDATE > accountlines > SET > credit_type_code = accounttype, accounttype = NULL > WHERE accounttype IN (SELECT code from account_credit_types) > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl > line 20067. > Upgrade to 19.06.00.044 done (Bug 23805 - Add account credit_types) > Upgrade to 19.06.00.045 done (Bug 23866 - Set HEA syspref to prompt for > review) > Upgrade to 19.06.00.046 done (Bug 15260 - Option for extended loan with > useDaysMode) > Upgrade to 19.06.00.047 done (Bug 14697 - Extend and enhance 'Claims > returned' lost status) > Upgrade to 19.06.00.048 done (Bug 22581 - add new OPACShowMusicalInscripts > and OPACPlayMusicalInscripts system preferences) > Upgrade to 19.06.00.049 done (Bug 13958 - Add a SuspensionsCalendar syspref) > Upgrade to 19.06.00.050 done (Bug 23293 - Add > 'OPACFineNoRenewalsIncludeCredits' system preference) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens changed: What|Removed |Added Attachment #95171|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 95177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95177=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #33 from David Cook --- Ran into this problem as it was causing /usr/share/koha/bin/cronjobs/longoverdue.pl to seemingly randomly die when this patch is applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
--- Comment #32 from David Cook ---
Comment on attachment 81710
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81710
Bug 20844: Revert hold when setting an item to lost
Review of attachment 81710:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20844=81710)
-
::: C4/Circulation.pm
@@ +3688,5 @@
> +my $LostItemLevelHold;
> +if ( $restype eq "Waiting" || $restype eq "Reserved" ) {
> +if ( $res->{originalholdtype} eq "B" ) {
> +#originalholdtype equalling "B" means this is a bib level hold
> +C4::Reserves::RevertWaitingStatus({itemnumber => $itemnumber});
This line appears to be buggy. I haven't fully investigated, but if the hold
type is B, the itemnumber can't be used to look up the reserve, and eventually
causes a fatal error in _FixPriority (due to a lack of error handling in
RevertWaitingStatus, _FixPriority, etc.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Jorge Rodriguez changed: What|Removed |Added Ever confirmed|1 |0 Severity|enhancement |new feature CC||jorge.mol...@urural.edu.gt Status|RESOLVED|UNCONFIRMED Resolution|INVALID |--- --- Comment #4 from Jorge Rodriguez --- install.pl: DBD::mysql::st execute failed: Table 'koha_library.audio_alerts' doesn't exist at /usr/share/perl5/DBIx/RunSQL.pm line 273. I have Ubuntu 18.04 lts y Koha Estable 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 Martin Renvoize changed: What|Removed |Added Severity|critical|major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13775] software error when choosing authority via plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #9 from Martin Renvoize --- Wondering if this one is still relevant and whether Katrins information was enough and you wanted to take this forward Jonathan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13775] software error when choosing authority via plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13775] software error when choosing authority via plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|critical|major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15732] Remove accountno column from accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Rocio Dressler changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Rocio Dressler --- *** This bug has been marked as a duplicate of bug 21683 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #51 from Rocio Dressler --- *** Bug 15732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23992] New: Adding multiple items with barcode might end with infinite loop if same barcode will be next_value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 Bug ID: 23992 Summary: Adding multiple items with barcode might end with infinite loop if same barcode will be next_value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: nug...@gmail.com Reporter: nug...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In /cataloguing/additem.pl we had the comment: "FIXME : Please note that there is a risk of infinite loop here if we never find a suitable barcode". I researched that when we are adding '$number_of_copies', there will be no infinite loop there in that 'for' loop EXCEPT if the 'next_value' method will return the same but defined barcode only (border case1). Other cases: - without a barcode code always adds any number of items in a sequential way, so nothing to fix, - if we have '$barcodevalue' defined in the beginning, code adds items with barcodes generating them with 'next_value', if then no barcode will be generated in 'next_value' then '$exist_itemnumber' will not be defined, so loop will keep adding items without barcodes. Sequentially. (case2) - if barcode will be occupied so it will be skipped until next barcode will be generated, a free one, this was discussed with KohaSuomi as "might be not needed" but because this already created in this way in KC so let's keep this logic, so nothing to fix here too. I am preparing patch to generate in case2: "no_barcode_value" error message if it was started with a barcode and no more barcodes generated, or in case1: if the barcode after 'next_value' will be the same as old value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15732] Remove accountno column from accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Rocio Dressler changed: What|Removed |Added CC||ro...@bywatersolutions.com --- Comment #2 from Rocio Dressler --- I agree!! And it's a required field so has to be supplied when migrating fines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17875] Linking to series authority records fails when a space precedes the semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Chris Cormack changed: What|Removed |Added Component|Label/patron card printing |Database --- Comment #1 from Chris Cormack --- Switching to the DB component so we can try to gather all the DB changes together -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #18 from Nick Clemens --- Created attachment 95176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95176=edit Bug 22831: (follow-up) Sort results, group by db -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #9 from Jonathan Druart
---
(In reply to Séverine Queune from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > (In reply to Séverine Queune from comment #3)
> > > Hi Jonathan,
> > >
> > > I found 2 issues.
> > >
> > > I have this software error : "Tag "" is not a valid tag. at
> > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a
> > > suggestion using the empty form (opac & staff client) and saving a
> > > suggestion modification on staff client (no problem using the checkbox and
> > > drop-down menu).
> >
> > I do not understand that one. There are 2 bugs opened with this error but no
> > idea where the error comes from. Can you detail a bit more?
> > Reading the code it seems related to the item type.
> >
> > (for the record)
> > 685 my ($it_tag, $it_subfield) =
> > GetMarcFromKohaField('biblioitems.itemtype', '');
> > 686 if ($record->field( $it_tag )) {
> > 687 $record->field( $it_tag )->add_subfields( $it_subfield =>
> > $suggestion->{itemtype} );
> > 688 }
> > 689 else {
> > 690 $record->append_fields(
> > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield =>
> > $suggestion->{itemtype})
> > 692 );
> > 693 }
>
> Oh... Weird... In my instance, there is no field mapped to
> biblioitems.itemtype, but if I add one, I can save the suggestion correctly.
> Is it the expected / future behaviour ?
> This a problem we don't have with 18.05.00 so we'll have to be be aware
> about adding a mapping for biblioitems.itemtype if so.
I am not sure, but the code that is exploding comes from bug 14973 (so not
pushed yet). Do you know why you do not have this mapping? Discussion should
continue on bug 14973 if needed.
> My second try was an on different computer with a different resolution
> screen, I noticed a tiny display issu with the new link in OPAC (see
> attachement). Sorry I missed that on first test.
Fixed.
You will need to regenerate the CSS file to see the changes: yarn build --view
opac
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #8 from Jonathan Druart --- Created attachment 95175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95175=edit Bug 14963: Fix ergonomic issue on small screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #7 from Séverine Queune --- Created attachment 95174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95174=edit Tiny gap before the new "Suggestion" link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- record ids should be sorted numerically. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
--- Comment #6 from Séverine Queune ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Séverine Queune from comment #3)
> > Hi Jonathan,
> >
> > I found 2 issues.
> >
> > I have this software error : "Tag "" is not a valid tag. at
> > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a
> > suggestion using the empty form (opac & staff client) and saving a
> > suggestion modification on staff client (no problem using the checkbox and
> > drop-down menu).
>
> I do not understand that one. There are 2 bugs opened with this error but no
> idea where the error comes from. Can you detail a bit more?
> Reading the code it seems related to the item type.
>
> (for the record)
> 685 my ($it_tag, $it_subfield) =
> GetMarcFromKohaField('biblioitems.itemtype', '');
> 686 if ($record->field( $it_tag )) {
> 687 $record->field( $it_tag )->add_subfields( $it_subfield =>
> $suggestion->{itemtype} );
> 688 }
> 689 else {
> 690 $record->append_fields(
> 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield =>
> $suggestion->{itemtype})
> 692 );
> 693 }
Oh... Weird... In my instance, there is no field mapped to
biblioitems.itemtype, but if I add one, I can save the suggestion correctly.
Is it the expected / future behaviour ?
This a problem we don't have with 18.05.00 so we'll have to be be aware about
adding a mapping for biblioitems.itemtype if so.
My second try was an on different computer with a different resolution screen,
I noticed a tiny display issu with the new link in OPAC (see attachement).
Sorry I missed that on first test.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff URL||https://gitlab.com/joubu/Ko ||ha/commits/bug_23590 --- Comment #10 from Jonathan Druart --- The patches need to be applied in the following (reverse) order: Bug 23590: Add lastmodification by and date columns Bug 23590: Display managed date in 'Your purchase suggestions' Bug 23590: Add the ability to notify a new manager Bug 23590: Only return patrons that have the suggestions_manage permission Bug 23590: Batch update manager for suggestions Bug 23590: Cleaning - Remove op_* vars Bug 23590: Clean TT variables for patrons Bug 23590: Add ability to edit the manager of a suggestion Bug 14963: Set status=ORDERED for suggestions created from existing record Bug 14963: Add the ability to suggest purchase on existing title Bug 23854: Fix failure on dates when editing a suggestion Bug 23594: Restore previous view after delete or update itemtype Bug 23594: Fix [un]checkall links Bug 23594: Batch modification for itemtypes on suggestions page Bug 14973: Add missing filters in templates Bug 14973: Remove double declaration of suggestions_loop Bug 14973: Remove double textarea for notes Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) If it can help, I have pushed a branch with all the patches applied: https://gitlab.com/joubu/Koha/commits/bug_23590 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
--- Comment #5 from Jonathan Druart
---
(In reply to Séverine Queune from comment #3)
> Hi Jonathan,
>
> I found 2 issues.
>
> I have this software error : "Tag "" is not a valid tag. at
> /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a
> suggestion using the empty form (opac & staff client) and saving a
> suggestion modification on staff client (no problem using the checkbox and
> drop-down menu).
I do not understand that one. There are 2 bugs opened with this error but no
idea where the error comes from. Can you detail a bit more?
Reading the code it seems related to the item type.
(for the record)
685 my ($it_tag, $it_subfield) =
GetMarcFromKohaField('biblioitems.itemtype', '');
686 if ($record->field( $it_tag )) {
687 $record->field( $it_tag )->add_subfields( $it_subfield =>
$suggestion->{itemtype} );
688 }
689 else {
690 $record->append_fields(
691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield =>
$suggestion->{itemtype})
692 );
693 }
> For suggestions made from an existing notice, suggestion status is not
> update after the adding to a basket (no problem for suggestions made from
> the empty form, and for the "Available" status after the receipt).
Fixed!
> Except these point, everything seems very clear to me and respond to our
> needs, so thanks a lot !
> Icon on opac is ok for me.
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #4 from Jonathan Druart --- Created attachment 95173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95173=edit Bug 14963: Set status=ORDERED for suggestions created from existing record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Séverine Queune changed: What|Removed |Added CC||nicolas.legr...@bulac.fr, ||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Séverine Queune --- Patch failed on both sandbox and devbox. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23590: Add ability to edit the manager of a suggestion fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 23590: Add ability to edit the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Séverine Queune --- Hi Jonathan, I found 2 issues. I have this software error : "Tag "" is not a valid tag. at /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a suggestion using the empty form (opac & staff client) and saving a suggestion modification on staff client (no problem using the checkbox and drop-down menu). For suggestions made from an existing notice, suggestion status is not update after the adding to a basket (no problem for suggestions made from the empty form, and for the "Available" status after the receipt). Except these point, everything seems very clear to me and respond to our needs, so thanks a lot ! Icon on opac is ok for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #2 from Jonathan Druart --- The hardest part is missing, suggestion/suggestion.pl I will come back to this one later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens changed: What|Removed |Added Summary|Batch Record Deletion does |Batch Record Deletion does |not remove records from |not remove records from |search index|Elasticsearch search index -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Blocks||23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Depends on||23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #1 from Jonathan Druart --- Created attachment 95172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95172=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||alex.arn...@biblibre.com, ||ere.maij...@helsinki.fi, ||fridolin.som...@biblibre.co ||m, glask...@gmail.com, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||joonas.kylm...@helsinki.fi, ||julian.maur...@biblibre.com ||, m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com --- Comment #2 from Nick Clemens --- I could use a hand understanding what is happening here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart changed: What|Removed |Added Blocks||15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #1 from Nick Clemens --- Created attachment 95171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95171=edit Bug 23986: Remove sort from batch bib deletion After lots and lots fo digging, I removed the sort from this loop. Somehow, this allows the ES records to be deleted. I do not understand this patch, but it works. Possibly we need to sort the error arrays after the fact To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart changed: What|Removed |Added Depends on||23991 Blocks|15449 | --- Comment #1 from Jonathan Druart --- Bug 23991 - Move SearchSuggestion to Koha::Suggestions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Blocks||23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on|23990 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] New: Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug ID: 23991 Summary: Move SearchSuggestion to Koha::Suggestions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||23990 --- Comment #24 from Jonathan Druart --- Bug 23990 - Move C4::Suggestions code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart changed: What|Removed |Added Blocks||15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23990] New: Move C4::Suggestions code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug ID: 23990 Summary: Move C4::Suggestions code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|critical|normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Jessie Zairo changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Jessie Zairo changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23989] New: Enable SSO options for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Bug ID: 23989 Summary: Enable SSO options for SelfCheck modules for Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: jza...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Currently the self check module allow users to sign in via cardnumber, or userid/password. The sign in form should be extended to allow SSO options (LDAP/Shibboleth/OAuth/etc.) on this login form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23988] When replace record with z39.50, give option on what gets pre-populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988 Peggy Thrasher changed: What|Removed |Added CC||p.thras...@dover.nh.gov --- Comment #1 from Peggy Thrasher --- It would make our lives so much easier if this had only the ISBN filled in. Dover Public Library, NH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19521] Partial fine payment is not working with comma decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19521 Martin Renvoize changed: What|Removed |Added Severity|critical|major CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23988] New: When replace record with z39.50, give option on what gets pre-populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988 Bug ID: 23988 Summary: When replace record with z39.50, give option on what gets pre-populated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently in Koha, when a user chooses to replace an existing record with another record using z39.50, Koha will prepopulate the z39.50 search with Title, Author and ISBN. This search is very constrictive and it would be nice to have the option of what fields get prepopulated instead of having to manually remove the fields that the user doesn't want. Specifically, an ISBN pre-population would be ideal for a library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #8 from Jonathan Druart --- Created attachment 95169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95169=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #2 from Jonathan Druart --- Created attachment 95170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95170=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #6 from Jonathan Druart --- Created attachment 95167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95167=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #7 from Jonathan Druart --- Created attachment 95168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95168=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #3 from Jonathan Druart --- Created attachment 95164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95164=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #4 from Jonathan Druart --- Created attachment 95165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95165=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #5 from Jonathan Druart --- Created attachment 95166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95166=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #2 from Jonathan Druart --- Created attachment 95163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95163=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #1 from Jonathan Druart --- Created attachment 95162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95162=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23854] Cannot edit a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart changed: What|Removed |Added Blocks||23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Jonathan Druart changed: What|Removed |Added Blocks||23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart changed: What|Removed |Added Blocks||23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart changed: What|Removed |Added Depends on||14963, 23594, 23854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 [Bug 23594] Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What|Removed |Added Blocks||14963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart changed: What|Removed |Added Depends on||14973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #6 from Caroline Cyr La Rose --- Sorry! I thought only the last patch would work as it contains the previous work too, but maybe not... Still learning git -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice changed: What|Removed |Added Attachment #95129|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #5 from Julian Maurice --- It looks like you have obsoleted the previous patch while it's still needed. Is it intended ? If you are using git-bz, it automatically obsoletes patch with the same title, so be sure to use different titles for all your commits. I will de-obsolete the first patch and test it as soon as possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Code scans well and does what is expected. I agree to the pragmatic decision of just removing the option at this point too. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Caroline Cyr La Rose changed: What|Removed |Added Attachment #95129|0 |1 is obsolete|| --- Comment #3 from Caroline Cyr La Rose --- Created attachment 95160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95160=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Martin Renvoize changed: What|Removed |Added Attachment #94687|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 95161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95161=edit Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Caroline Cyr La Rose changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #4 from Caroline Cyr La Rose --- I have added the | html filters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #7 from Martin Renvoize --- Works as expected, checked if the online documentation needed any updating to reflect the change, but neither issues nor reservations have any details in the examples. Looks good to me, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301
Martin Renvoize changed:
What|Removed |Added
Attachment #93495|0 |1
is obsolete||
--- Comment #5 from Martin Renvoize ---
Created attachment 95158
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95158=edit
Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service
Actually, the GetRecords service gives many information :
bibliographic data (marcxml field)
item data (items field)
issue data (issues field)
The issue data should not be sent by these service, its a privacy problem.
Biblio title and author are redundant.
This patch changes to use Koha::Checkouts to get issues informations with only
the addition of item barcode.
Test plan :
1) Enable ILS-DI webservice
2) Checkout an item
3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords={biblionumber}
4) Check the issues tag content
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
