[Koha-bugs] [Bug 24005] Software error: at login

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005

--- Comment #5 from Jonathan Druart  
---
Hello Andrew,

You are hitting an issue that has been fixed by bug 23579, and that will be
part of the next 19.05.x version (19.05.05, not released yet).
You should try with MariaDB instead of MySQL.

Also it is not needed to copy the code into the comment, I have access to it as
you provided me the version you are using :)

Good luck!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24005] Software error: at login

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005

--- Comment #4 from Andrew Lau  ---
Many thanks for the very practical advice! I removed the instance and attempted
reinstalling it. Now the following error message occurs:




-
The following error occurred while importing the database structure:

[Tue Nov 12 12:04:18 2019] install.pl: DBD::mysql::st execute failed: BLOB,
TEXT, GEOMETRY or JSON column 'changed_fields' can't have a default value at
/usr/share/perl5/DBIx/RunSQL.pm line 273.

Please contact your system administrator



The /usr/share/perl5/DBIx?RunSQL.pm looks like this:

--
  GNU nano 2.9.3   
 /usr/share/perl5/DBIx/RunSQL.pm

package DBIx::RunSQL;
use strict;
use DBI;

use vars qw($VERSION);
$VERSION = '0.15';

=head1 NAME

DBIx::RunSQL - run SQL from a file

=cut

=head1 SYNOPSIS

#!/usr/bin/perl -w
use strict;
use lib 'lib';
use DBIx::RunSQL;

my $test_dbh = DBIx::RunSQL->create(
dsn => 'dbi:SQLite:dbname=:memory:',
sql => 'sql/create.sql',
force   => 1,
verbose => 1,
);

... # run your tests with a DB setup fresh from setup.sql

=head1 METHODS

=head2 C<< DBIx::RunSQL->create ARGS >>

=head2 C<< DBIx::RunSQL->run ARGS >>

Runs the SQL commands and returns the database handle.
In list context, it returns the database handle and the
suggested exit code.

=over 4

=item *

C - name of the file containing the SQL statements

The default is C

If C is a reference to a glob or a filehandle,
the SQL will be read from that. B

This allows one to create SQL-as-programs as follows:

  #!/usr/bin/perl -w -MDBIx::RunSQL -e 'create()'
  create table ...

If you want to run SQL statements from a scalar,
you can simply pass in a reference to a scalar containing the SQL:

sql => \"update mytable set foo='bar';",

=item *

C, C, C - DBI parameters for connecting to the DB

=item *

C - a premade database handle to be used instead of C

=item *

C - continue even if errors are encountered

=item *

C - print each SQL statement as it is run

=item *

C - callback to call with each SQL statement instead of
C

=item *

C - filehandle to write to instead of C

=back

=cut

sub create {
my ($self,%args) = @_;
$args{sql} ||= 'sql/create.sql';

my $dbh = delete $args{ dbh };
if (! $dbh) {
$dbh = DBI->connect($args{dsn}, $args{user}, $args{password}, {})
or die "Couldn't connect to DSN '$args{dsn}' : " . DBI->errstr;
};

Runs an SQL file on a prepared database handle.
Returns the number of errors encountered.

If the statement returns rows, these are printed
separated with tabs.

=over 4

=item *

C - a premade database handle

=item *

C - name of the file containing the SQL statements

=item *

C - continue even if errors are encountered

=item *

C - print each SQL statement as it is run

=item *

C - callback to call with each SQL statement instead of
C

=item *

C - filehandle to write to instead of C

=item *

C - whether to exit with a nonzero exit code if any row is found

This makes the function return a nonzero value even if there is no error
but a row was found.

=item *

C - whether to output the (one) row and column, without any
headers

=back

=cut

sub run_sql_file {
my ($self,%args) = @_;
my @sql;
   {
open my $fh, "<", $args{sql}
or die "Couldn't read '$args{sql}' : $!";
# potentially this should become C<< $/ = ";\n"; >>
# and a while loop to handle large SQL files
local $/;
$args{ sql }= <$fh>; # sluuurp
};
$self->run_sql(
%args
);
}

=head2 C<< DBIx::RunSQL->run_sql ARGS >>

my $dbh = DBI->connect(...)

for my $file (sort glob '*.sql') {
DBIx::RunSQL->run_sql_file(
verbose => 1,
dbh => $dbh,
sql => 'create table foo',
);
};

Runs an SQL string on a prepared database handle.
Returns the number of errors encountered.

If the statement returns rows, these are printed
separated with tabs, but see the C and C options.

=over 4

=item *

C - a premade database handle

=item *

C - string or array reference containing the SQL statements

=item *

C - continue even if errors are encountered

=item *

C - print each SQL statement as it is run

=item *

C - callback to call with each SQL statement instead of
C

=item *

C - filehandle to write to instead of C

=item *

C - whether to exit with a nonzero exit code if any row is found

This makes the function return a nonzero value even if there is no error
but a row was found.

=item *

C - whether to output the (one) row and column, without any
headers

=back

=cut

sub run_sql {
my ($self,%args) = @_;
my 

[Koha-bugs] [Bug 24015] New: UNIMARC Authorities

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24015

Bug ID: 24015
   Summary: UNIMARC Authorities
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: igor.a.syc...@mail.ru
QA Contact: testo...@bugs.koha-community.org

UNIMARC Authorities, 3rd edition
Add 
010 - International Standard Name Identifier (ISNI) (new 2016)
017 - Other Identifier (new 2017)

https://www.ifla.org/publications/unimarc-authorities--3rd-edition--updates?og=33

authorities_normal_unimarc.sql:
...
('', '010', 'International Standard Name Identifier (ISNI)',
'International Standard Name Identifier (ISNI)', 0, 0, ''),

...
('', '017', 'Other Identifier', 'Other Identifier', 0, 0, ''),

...
('', '010', 'a', 'Number (ISNI)', 'Number (ISNI)', 0, 0, 0, '', '', '',
0, 1, 0, '', ''),
('', '010', 'y', 'Cancelled ISNI', 'Cancelled ISNI', 1, 0, 0, '', '',
'', 0, 1, 0, '', ''),
('', '010', 'z', 'Erroneous ISNI', 'Erroneous ISNI', 1, 0, 0, '', '',
'', 0, 1, 0, '', ''),
('', '010', '6', 'Interfield linking data', 'Interfield linking data',
1, 0, 0, '', '', '', 0, 1, 0, '', ''),

...
('', '017', 'a', 'Identifier', 'Identifier', 0, 0, 0, '', '', '', 0, 1,
0, '', ''),
('', '017', 'b', 'Qualification', 'Qualification', 1, 0, 0, '', '', '',
0, 1, 0, '', ''),
('', '017', 'z', 'Erroneous Identifier', 'Erroneous Identifier', 1, 0,
0, '', '', '', 0, 1, 0, '', ''),
('', '017', '2', 'System Code', 'System Code', 0, 0, 0, '', '', '', 0,
1, 0, '', ''),

...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests!

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
(In reply to Cori Lynn Arnold from comment #3)
> I specifically think this is a *BUG* and not an enhancement. If the
> interface lets you search and provides result sets, than it should return
> results from both places when searching for the same thing.

The records in the catalog are searched using Zebra, the reservoir records are
not indexed by Zebra and can only be searched with SQL, that's why they don't
work the same and it would be hard to make them, unless we decided to make an
index for the reservoir records as well I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24014] New: Return to last Advanced Search link incorrectly encoded

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24014

Bug ID: 24014
   Summary: Return to last Advanced Search link incorrectly
encoded
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

After performing an advanced search in the opac, if you click on the link to
return to the last Advanced Search it is incorrectly encoded and results in a
404 page error. 

Changing line 117 of opac-results.tt from

Return to the last advanced search

to 

Return to the last advanced search

corrects the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

Cori Lynn Arnold  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #3 from Cori Lynn Arnold  ---
I specifically think this is a *BUG* and not an enhancement. If the interface
lets you search and provides result sets, than it should return results from
both places when searching for the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600

--- Comment #7 from Katrin Fischer  ---
(In reply to Andres Ovalle from comment #6)
> "ENTIDAD DE PRUEBA" was the last library created in the system, after that
> there are the groups that is where we have problems.
> 
> An example image:
> 
> https://www.dropbox.com/s/vn753b4a9g4or6c/Captura%20de%20Pantalla%202019-11-
> 06%20a%20la%28s%29%208.01.19%20p.%20m..png?dl=0

I know - but they really don't display for me like on your screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

--- Comment #17 from Cori Lynn Arnold  ---
(In reply to Katrin Fischer from comment #16)

> Hi Cori, 001 should be indexed as Control-number and be searchable. You
> could add it to advanced search pull downs using jQuery - would that help of
> have you already tried and found something not working?

Katrin,

Can you elaborate on this? Point me to some documentation? Which interface?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24013] New: Transferring a checked out item gives a software error

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013

Bug ID: 24013
   Summary: Transferring a checked out item gives a software error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reproduce:
1. check out an item
2. Go to circulation -> transfer and put in the barcode of the item you just
checked out
3. error: Can't call method "borrowernumber" on unblessed reference at
/home/vagrant/kohaclone/C4/Circulation.pm line 350

This occurs in the C4::Circulation::transferbook subroutine. It happens because
Bug 18276 accidentally reintroduces an old subroutine (GetOpenIssue) that
returns an unblessed reference. This line should use Koha Objects instead.

Code causing an error:

my $issue = GetOpenIssue($itemnumber);
# check if it is still issued to someone, return it...
if ( $issue ) {
AddReturn( $barcode, $fbr );
$messages->{'WasReturned'} = $issue->borrowernumber;
}

Suggested fix:

my $issue = Koha::Checkouts->find({ itemnumber => $itemnumber });

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013

Aleisha Amohia  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953

--- Comment #2 from Aleisha Amohia  ---
Yes it is a weird one. I think given that the option is a checkbox, it does
imply that it's a separate action to the button, and you should be able to
cancel a hold while clicking any button.
In this case I think we just need to ensure that the cancel hold checkbox is
considered if any of the buttons is clicked.

Otherwise, the checkbox should be removed and the cancel hold action should be
a second screen confirmation, after choosing "Yes, check out".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273.

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496

Katrin Fischer  changed:

   What|Removed |Added

   Severity|new feature |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15449] Move stuff to the Koha namespace

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Katrin Fischer  changed:

   What|Removed |Added

Summary|Move stuffs to the Koha |Move stuff to the Koha
   |namespace   |namespace
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

--- Comment #16 from Katrin Fischer  ---
(In reply to Cori Lynn Arnold from comment #15)
> Librarian here: 
> 
> We currently use the cataloging search because the Advanced Search doesn't
> support searching by control number. 

Hi Cori, 001 should be indexed as Control-number and be searchable. You could
add it to advanced search pull downs using jQuery - would that help of have you
already tried and found something not working?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #4 from Tomás Cohen Arazi  ---
I want to hear your opinions, I'm not feeling comfortable with this, looking at
cleaning Koha::REST::V1::Patrons with this makes me wonder if it is falling
short.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 95278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95278=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object

This patch introduces the following methods to the Koha::Object class:
- set_from_api
- new_from_api

This methods are going to be used when writing API controllers that map
to the attributes to the DB schema ones.

To test:
1. Apply this patchset
2. Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 95277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95277=edit
Bug 23893: Implement Koha::Object->from_api_mapping

This patch implements the from_api_mapping method, that calculates (and
caches) the reserve mapping from the to_api_mapping method.

A generic to_api_mapping is added to simplify things a bit in the generic
to_api method and so the mappings are reusable in the way they are in
from_api_mapping.

To test:
1. Apply this patches
2. Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 95276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95276=edit
Bug 23893: Unit tests

This patch introduces tests for the implemented methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
Version|18.11   |master
   Severity|minor   |normal
 Depends on||13618
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I will need to double check this fix, but it seems ok at first glance.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Add additional template filter methods and a filter presence test
to Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23777


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777
[Bug 23777] Text converted to html entity codes in cataloguing edit form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

--- Comment #3 from Jonathan Druart  
---
Created attachment 95275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95275=edit
Bug 23777: Fix auth finder escaping

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874

Jonathan Druart  changed:

   What|Removed |Added

Version|19.05   |master
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #9 from Jonathan Druart  
---
Hi Tomáš, can you try this patch please?

I am pretty sure we will need to adjust much more occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874

Jonathan Druart  changed:

   What|Removed |Added

Summary|Advanced Editor is not  |Advanced Editor is not
   |loaded over HTTPS   |loaded if
   ||X-Content-Type-Options:
   ||nosniff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24012] Display 'Locked' budget in red

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012

--- Comment #1 from Caroline Cyr La Rose  ---
Also add "lock" icon for usability (specifically colour-blind users), as per
Martin's request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874

--- Comment #8 from Jonathan Druart  
---
Created attachment 95274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95274=edit
Bug 23874: Fix advanced editor if nosniff is set

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24012] New: Display 'Locked' budget in red

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012

Bug ID: 24012
   Summary: Display 'Locked' budget in red
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I find it illogical that the 'Locked' in locked budget is displayed in green.
Shouldn't it be displayed in red?

To reproduce:
1- Go to Administration
2- Click on Budgets
3- Add a new budget and check the 'Lock budget' box
4- Click on the 'Inactive budgets' tab
5- Note that 'Locked' is displayed in green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

--- Comment #1 from Jonathan Druart  
---
Created attachment 95273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95273=edit
Bug 23900: Teach label maker to concat database fields

Test plan:
- define a label layout with this field list: "100a 245s","enumchron
copynumber"
- find or create a record with values for all of those fields
- generate a label for that record
- the 100a and 245s successfully display on one line
- the enumchron and copynumber are displayed and separated by a space

Try other combinations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|19.05   |master
   Assignee|cnighswon...@foundations.ed |jonathan.dru...@bugs.koha-c
   |u   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24011] New: Browser tabs auto close when editing items from report with biblio links

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011

Bug ID: 24011
   Summary: Browser tabs auto close when editing items from report
with biblio links
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mksteph...@lancasterseminary.edu
QA Contact: testo...@bugs.koha-community.org

Since upgrading to 19.05, following a linked biblionumber from a report and
making an edit to an item will close the new browser tab after the edit is
complete. This is not desired behavior (at least for my library) because it
doesn't allow us to check for accuracy after saving changes and it does not
allow the opportunity to make edits to additional items attached to the record.
The link has to be clicked again from the report to be able to see the record
view.

To test:
1. Create a report with linked biblios that includes this snippet of SQL code:
CONCAT('',b.biblionumber,'')
as biblionumber
2. Run the report
3. Click on a biblio link; the record view opens in a new browser tab
4. Click on the edit item button; the edit item screen loads
5. Make a change to the item; click save changes
6. The browser tab closes, leaving only the report tab open.

Note, the changes do appear to save before the tab closes. I suspect that a
well-meaning developer intended for this to be a shortcut or time saver, but it
is a major annoyance when attempting to make edits from a report and the record
has multiple items attached. It would also be nice to have visual confirmation
that the changes were indeed saved and they are accurate. The tab auto-closes
before the user gets that visual confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page (Chromium)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899

Jonathan Druart  changed:

   What|Removed |Added

Summary|Cannot change size of Show  |Cannot change size of Show
   |SQL Code box on run report  |SQL Code box on run report
   |page|page (Chromium)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
See https://github.com/codemirror/CodeMirror/issues/850

There is code we could take from https://codepen.io/sakifargo/pen/KodNyR

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23892] Code related to import/export biblio frameworks in XML format must be removed

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23892

Jonathan Druart  changed:

   What|Removed |Added

Summary|Code related to |Code related to
   |import/export biblio|import/export biblio
   |frameworks in CSV format|frameworks in XML format
   |must be removed |must be removed

--- Comment #2 from Jonathan Druart  
---
^CSV^XML^

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953

Jonathan Druart  changed:

   What|Removed |Added

   Severity|minor   |normal
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||oleon...@myacpl.org

--- Comment #1 from Jonathan Druart  
---
Looks like a long standing issue and I did not find a duplicated bug report,
that's weird.

At first glance I would say the checkbox is only taken into consideration for
"Yes, check out"

https://snipboard.io/jEXNBP.jpg

Not sure how we could make it clear on the interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|23293   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293
[Bug 23293] OPACFineNoRenewals always compares against 'balance' not
'outstanding'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23293


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293
[Bug 23293] OPACFineNoRenewals always compares against 'balance' not
'outstanding'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding'

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|14825   |24007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007
[Bug 24007] Koha::Account::non_issues_charges is badly named
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007
[Bug 24007] Koha::Account::non_issues_charges is badly named
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=24007   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=24009   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007
[Bug 24007] Koha::Account::non_issues_charges is badly named
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24009


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009
[Bug 24009] Koha::Account->outstanding_debits should support inline filtering
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #2 from Martin Renvoize  ---
Created attachment 95272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95272=edit
Bug 24009: Add Unit Tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #1 from Martin Renvoize  ---
Created attachment 95271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95271=edit
Bug 24009: Add filter_by option to outstanding_debits

This patch adds an optional 'filter_by' arguament to
Koha::Account->outstanding_debits which current accepts 'blocks_issue'
and will filter down the result set of outstanding_debits based upon the
values of the following system preferences.

* `HoldsInNoissuesCharge`
* `RentalsInNoissuesCharge`
* `ManInvInNoissuesCharge`

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||lari.task...@hypernova.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24010] New: Number of issues to display to staff accepts non-integer values

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

Bug ID: 24010
   Summary: Number of issues to display to staff accepts
non-integer values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When adding a new serial subscription in the page
/cgi-bin/koha/serials/subscription-add.pl one can add to the field "Number of
issues to display to staff" a non-integer value like "f" and then when you save
this new subscription and go to the "Subscriptions" tab in
/cgi-bin/koha/catalogue/detail.pl?biblionumber= you get the following error
in plack-error.log:

>DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for 
>Statement "SELECT   serialid,serialseq, status, planneddate, publisheddate, 
>notes
>FROM serial
>WHEREsubscriptionid = ?
>AND  status IN (2,4,41,42,43,44)
>ORDER BY publisheddate DESC LIMIT 0,f
>" with ParamValues: 0=2] at /home/koha/kohaclone/C4/Serials.pm 
> line 784.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

--- Comment #30 from Andrew Isherwood  ---
Needed a rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93910|0   |1
is obsolete||

--- Comment #28 from Andrew Isherwood  ---
Created attachment 95269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95269=edit
Bug 23173: Provide core infrastructure

This patch adds the required infrastructure to enable ILL availability
plugins to intercept the request creation process and, using the
supplied metadata, search for and display possible relevant items from
whichever availability plugins are installed.

Currently three availability plugins exist:

z39.50 - Searches any number of the Koha instance's configured Z targets
https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950

EDS - Searches the EBSCO Discovery Service
https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds

Unpaywall - Searches the Unpaywall API for possible open access versions
of the requested item
https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall

The Unpaywall plugin is intended to serve as a "reference" plugin as the
API it deals with is extremely simple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93909|0   |1
is obsolete||

--- Comment #27 from Andrew Isherwood  ---
Created attachment 95268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95268=edit
Bug 23173: Add ILLCheckAvailability syspref

This patch adds the new syspref "ILLCheckAvailability"

Sponsored-by: Public Health England

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #93911|0   |1
is obsolete||

--- Comment #29 from Andrew Isherwood  ---
Created attachment 95270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95270=edit
Bug 23173: Add unit tests

Test Koha::Illrequests::Availability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24009

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24007

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #3 from Joonas Kylmälä  ---
What log is where the warning goes and which version of elasticsearch do you
use?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|alex.arn...@biblibre.com|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24009] New: Koha::Account->outstanding_debits should support inline filtering

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

Bug ID: 24009
   Summary: Koha::Account->outstanding_debits should support
inline filtering
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

We have a number of places where we want to get a specific list of outstanding
debits for comparison.. at the moment one would have to construct a search
directly by inspecting system preferences at the controller level.

By addins a filter option to oustanding_debits we can move that back to the
object level without having to add additional methods.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Joonas Kylmälä  ---
If I don't have any vendors in Koha then this error comes up to the browser's
JavaScript console:

> ReferenceError: BOOKSELLER_IDS is not defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

--- Comment #2 from Cori Lynn Arnold  ---

I'm not sure I understand what you mean by "It seems that only title, author
and isbn are supported by this search." 

Only title, author and isbn are supported by the *Reservoir* search, but other
fields are supported by the *Catalog* search. Why not support the SAME search
over both sets?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24005] Software error: at login

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Hi Andrew, and welcome!

You should not need to modify anything after the installation process.
Do you see the different tables in the database? How many?

I would recommend you to remove the instance of Koha you have created and start
again.

Also, it could help to take a look at the logs (/var/log/koha/YOUR_INSTANCE) to
see if there is something useful there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95247|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95248|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95246|0   |1
is obsolete||

--- Comment #14 from Joonas Kylmälä  ---
Created attachment 95265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95265=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?patron_id=123

To test:
1. prove t/db_dependent/api/v1/checkouts.t
2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123
where 123 is your patron's borrowernumber

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #15 from Joonas Kylmälä  ---
Created attachment 95266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95266=edit
Bug 18795: (follow-up) Check whether patrons exists before deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #16 from Joonas Kylmälä  ---
Created attachment 95267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95267=edit
Bug 18795: (follow-up) Unify error message to be same across codebase

In Koha/REST/V1/Patrons.pm the error message for not finding patron is
"Patron not found" so let's use the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

Cori Lynn Arnold  changed:

   What|Removed |Added

 CC||carn...@dgiinc.com

--- Comment #15 from Cori Lynn Arnold  ---
Librarian here: 

We currently use the cataloging search because the Advanced Search doesn't
support searching by control number. We would prefer that the Advanced Search
supports searching the control number as well as searching in the reservoir
(for control number and the currently available fields). I agree with Barbara
Johnson, make the search configurable for those that are confused and want to
get rid of it. Then make the configurable preference of either the Basic or
Advanced editor the default.

I would ultimately prefer that a search works the same weather you are
searching in the catalog, the reservoir, or Z39.50. There are a three searching
interfaces in Koha in the cataloging tab and they all are drastically different
and return different things. Why not have one, efficient interface that does
the same thing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24004] "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24004] "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major
 CC||bgkrie...@gmail.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23941

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10047

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |enhancement
Version|19.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir"

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
It seems that only title, author and isbn are supported by this search.

We could extend it to the full MARC records but that may return too many
results.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|joonas.kylm...@helsinki.fi  |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94903|0   |1
is obsolete||

--- Comment #51 from Andrew Isherwood  ---
Created attachment 95262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95262=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94904|0   |1
is obsolete||

--- Comment #52 from Andrew Isherwood  ---
Created attachment 95263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95263=edit
Bug 23681: Add unit tests

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94901|0   |1
is obsolete||

--- Comment #49 from Andrew Isherwood  ---
Created attachment 95260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95260=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #95148|0   |1
is obsolete||

--- Comment #53 from Andrew Isherwood  ---
Created attachment 95264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95264=edit
Bug 23681: (follow-up) Fix typo

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94902|0   |1
is obsolete||

--- Comment #50 from Andrew Isherwood  ---
Created attachment 95261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95261=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94900|0   |1
is obsolete||

--- Comment #48 from Andrew Isherwood  ---
Created attachment 95259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95259=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94899|0   |1
is obsolete||

--- Comment #47 from Andrew Isherwood  ---
Created attachment 95258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95258=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94897|0   |1
is obsolete||

--- Comment #45 from Andrew Isherwood  ---
Created attachment 95256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95256=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94896|0   |1
is obsolete||

--- Comment #44 from Andrew Isherwood  ---
Created attachment 95255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95255=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94898|0   |1
is obsolete||

--- Comment #46 from Andrew Isherwood  ---
Created attachment 95257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95257=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

Signed-off-by: Benjamin Veasey 
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion.

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize  changed:

   What|Removed |Added

Summary|No warning is produced when |Attempting to delete a
   |trying to delete a patron   |patron with outstanding
   |with credit (patron is not  |credits should warn and
   |deleted)|block the deletion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822

--- Comment #6 from Martin Renvoize  ---
Updated the bug title to reflect the impact of the change and Jonathans
bugfix.. Cloned the original bug to bug 24008 to record the enhancement request
to add blocking of patron deletions if outstanding credits are found and
additional warnings as this is an additional workflow that needs implementing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822

Martin Renvoize  changed:

   What|Removed |Added

Summary|No warning is produced when |Regression: As of 19.05.04
   |trying to delete a patron   |deletion of patrons with
   |with credit (patron is not  |outstanding credits is
   |deleted)|silently blocked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24008] New: No warning is produced when trying to delete a patron with credit (patron is not deleted)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Bug ID: 24008
   Summary: No warning is produced when trying to delete a patron
with credit (patron is not deleted)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: fridolin.som...@biblibre.com, gmcha...@gmail.com,
jonathan.dru...@bugs.koha-community.org,
katrin.fisc...@bsz-bw.de, kyle.m.h...@gmail.com,
martin.renvo...@ptfs-europe.com,
testo...@bugs.koha-community.org, th...@lib.auth.gr,
tomasco...@gmail.com, victor.grous...@biblibre.com
Depends on: 23822

+++ This bug was initially created as a clone of Bug #23822 +++

When one tries to delete a patron that has a credit in his account, no warning
is produced. 
The deletion is not performed (which is the proper behavior), however one would
expect to see a warning similar to the one that is produced when the patron has
an unpaid fine, a checked out item, a hold, etc.

The following screencast was performed in ByWaters' sandboxes running 19.05 and
shows the issue:
https://screencast-o-matic.com/watch/cq6D6vu4YJ


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822
[Bug 23822] No warning is produced when trying to delete a patron with credit
(patron is not deleted)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008
[Bug 24008] No warning is produced when trying to delete a patron with credit
(patron is not deleted)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding'

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24007

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24007   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007
[Bug 24007] Koha::Account::non_issues_charges is badly named
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted)

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24007

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >