[Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer changed: What|Removed |Added Attachment #95711|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 95757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95757=edit Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer changed: What|Removed |Added Attachment #95712|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 95758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95758=edit Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer changed: What|Removed |Added Attachment #95696|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 95756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95756=edit Bug 24013: Fix transferbook if item is checked out Wrong conflict resolution, the following commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones restored a previous change from commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Not that "easy" or "simple"... Test plan: Run the test before and after this patch. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer changed: What|Removed |Added Attachment #95695|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 95755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95755=edit Bug 24013: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Is 18.11 the right version here? It looks like send_digests was introduced later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer changed: What|Removed |Added Attachment #95697|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 95754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95754=edit Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 Katrin Fischer changed: What|Removed |Added Component|Lists |I18N/L10N CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Still valid. Example: https://translate.koha-community.org/de/translate/#search=dt_modification_time=source,target=exact,case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
Status|Needs Signoff |Failed QA
--- Comment #4 from Katrin Fischer ---
Hi Owen,
why not search the ISBN as is? Or in different formats according to our ISBN
variations prefs? I am not sure about the line using the as_isbn10.
+if( $isbn = Business::ISBN->new( $query ) ) {
+$isbn = $isbn->as_isbn10->as_string;
+$isbn =~ s/-//g;
As I understand it, if the ISBN is a new one (13), this will return undef.
as_isbn10
Returns a new ISBN object. If the object is already ISBN-10, this method
clones it. If it is an ISBN-13 with the prefix 978, it returns the ISBN-10
equivalent. For all other cases it returns undef.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #18 from Katrin Fischer --- Is this still work in progress? (Status: Assigned) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Katrin Fischer changed: What|Removed |Added Attachment #95726|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 95753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95753=edit Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer changed: What|Removed |Added Attachment #95738|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95752=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 --- Comment #2 from Katrin Fischer --- successfuly => successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit | |y.org | Component|I18N/L10N |Mana-kb CC||julian.maur...@biblibre.com ||, katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- It looks like this might be a bug in Mana itself, changing the module and adding Julian. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #8 from Katrin Fischer --- (In reply to Lisette Scheer from comment #7) > (In reply to Katrin Fischer from comment #6) > > Hi Lisette, nice patch! > > > > Just some small things for your next one: > > > > - The first line always needs to start with 'Bug :'. > > - Something seems to happen to the breaks in your patches - no problem, I've > > fixed it. How do you write the commit message? Maybe try to add an extra > > empty line after the first. > > > Katrin, > Thanks for fixing it. > I'm using the devbox. > I'll do: > 1) git commit basket.tt > 2) Write the commit notes, following the instructions on the wiki that I > found here: https://wiki.koha-community.org/wiki/Commit_messages > 3) :wq! to write and quit. > 4) git bz attach -e 24403 HEAD > 5) Put all the line breaks back in and change the status. > > I did think it was quirky that I had to put the line breaks in again. > That was also why I had 2 patches on this one. The first time I forgot to -e > so I re-attached it after editing. Hm something is odd there, you shouldn't have to do anything on bugzilla and it doesn't really work well this way. It sounds like you are using vi in the devbox. One can change the default editor for git via the config files for the devbox, maybe this could improve things... but it SHOULD work with vi too :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741
Maryse Simard changed:
What|Removed |Added
Attachment #95702|0 |1
is obsolete||
--- Comment #4 from Maryse Simard ---
Created attachment 95751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95751=edit
Bug 14741: Selecting all child permissions doesn't select the top level check
box
This patch modifies the patron flags page so that manually selecting all
the child permissions also checks the checkbox for the parent
permission.
To test, apply the patch, open a patron record, select More -> Set
permissions.
- Expand a set of permissions, for instance "Add, modify, and view
patron information."
- If any boxes are checked, uncheck them.
- Check each of the "child" checkboxes ("Add, modify, and view..." and
"View patron infos..." ).
- When both checkboxes are checked, the "Add, modify, and view" parent
permission should be automatically checked.
Signed-off-by: Maryse Simard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Katrin Fischer changed: What|Removed |Added Attachment #95252|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Katrin Fischer changed: What|Removed |Added Attachment #95653|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 95750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95750=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #7 from Katrin Fischer --- It's really a little ugly... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Katrin Fischer changed: What|Removed |Added Attachment #95705|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95749=edit Bug 24084: PlainMARC view broken on OPAC if other $.ajax calls produce errors This patch removes the use of jQuery's ajaxSetup() and load() to get the "plain" MARC view and replaces it with $.get(). This allows for error-handling on this specific AJAX request rather than all on the page. To test, apply the patch and view a bibliographic record in the OPAC. - Click the "MARC view" tab. - Click the "view plain" link. - The plain-text MARC view should load. - Clicking "view labeled" should return you to the original view. To test error handling, edit opac-MARCdetail.tt line 185 and add a typo to the URL, e.g. "opac-showmark.pl." Repeat the above steps. Clicking the "view plain" link should trigger an error message: "Sorry, plain view is temporarily unavailable." Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Tiny change, PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24096] New: Mana KB "Shared successfully" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 Bug ID: 24096 Summary: Mana KB "Shared successfully" untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Created attachment 95748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95748=edit English Success message in fr-CA page When sharing a report with Mana KB, there is a message that says "Shared successfuly! (sic) Thanks for your help" That string is untranslatable. It is nowhere in the po files. I wonder if that has to do with the URL that I get http://v1905-intranet/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved=Shared%20successfuly!%20Thanks%20for%20your%20help If the message is in the URL, maybe it's just not in the tt? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #7 from Katrin Fischer --- Created attachment 95747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95747=edit Bug 21574: Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #7 from Lisette Scheer --- (In reply to Katrin Fischer from comment #6) > Hi Lisette, nice patch! > > Just some small things for your next one: > > - The first line always needs to start with 'Bug :'. > - Something seems to happen to the breaks in your patches - no problem, I've > fixed it. How do you write the commit message? Maybe try to add an extra > empty line after the first. Katrin, Thanks for fixing it. I'm using the devbox. I'll do: 1) git commit basket.tt 2) Write the commit notes, following the instructions on the wiki that I found here: https://wiki.koha-community.org/wiki/Commit_messages 3) :wq! to write and quit. 4) git bz attach -e 24403 HEAD 5) Put all the line breaks back in and change the status. I did think it was quirky that I had to put the line breaks in again. That was also why I had 2 patches on this one. The first time I forgot to -e so I re-attached it after editing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Maryse Simard --- Everything works on the add/edit item page, but the datepicker looks a bit off on the new order page. The dialog is missing the selects for the month and year as well as the "today" button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Owen, I have some difficulties with this bug. The second "Place hold" button on the end of the page does no longer 'lock' when it should. Example: - override is not active - try to place a hold on a record with only 'not for loan' itemtypes - the first 'place hold' button is locked, but the second after the item table is not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Katrin Fischer changed: What|Removed |Added Attachment #95242|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95746=edit Bug 23958: Use Font Awesome icon to replace "new window" icon image This patch modifies several templates in order to eliminate the dependency on an image file for styling certain links which open popups or new windows. A Font Awesome icon is used instead. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Cataloging: - Create a new MARC record which has the same ISBN as a record in your catalog. - When you save the record it should warn you that it is a possible duplicate. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Circulation: - Enable the itemBarcodeFallbackSearch system preference. - Open a patron for checkout and enter a word in the "barcode" field instead of a barcode. - The page should return a list of titles to choose from. Each title should be a link with an icon. Clicking the link should open details about the title in a new window. Acquisitions: - Go to Acquistisions -> Vendor -> Basket. - Choose "Add to basket" -> From an external source. - Search for and select a record which exists in your catalog. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking this link should open details about the title in a new window. - Create a MARC file with two records: One which exists in your catalog and one which doesn't. Stage that file for import. - Choose "Add to basket" again and select "From a staged file." - Select the file you staged. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Patrons: - Create a new patron which has the same name and birthday as an existing patron. - When you save the record you should be shown a duplicate warning. The link to the possible duplicate patron should be prefixed with an icon and should open the patron's details in a popup window. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer changed: What|Removed |Added Attachment #95587|0 |1 is obsolete|| Attachment #95709|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95745=edit Bug 24056: Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system preferences. 2) Add a cash register. 3) Edit the cash register. 4) Note the incorrect capitalization. 5) Apply the patch. 6) Edit the cash register. 7) Note the correct capitalization. Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24057] Hea is not an acronym
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24057] Hea is not an acronym
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Katrin Fischer changed: What|Removed |Added Attachment #95529|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95744=edit Bug 24057: Hea is not an acronym This patch changes "HEA" (incorrectly capitalized) to "Hea" on the staff client administration home page. To test, apply the patch and set the "UsageStats" system preference to "No, let me think about it." - Go to Administration in the staff client. - There should be a message at the top asking if you want to share anonymous usage statisitcs with the community. The word "Hea" in this message should be capitalized correctly. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer changed: What|Removed |Added Attachment #95607|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 95743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95743=edit Bug 24053: Typo in FinePaymentAutoPopup description There is a typo in the FinePaymentAutoPopup system preference description. This patch fixes that. To test: 1) Go to the systems preferences in administration. 2) Search for FinePaymentAutoPopup 3) Observe .. at the end of the preference description. 4) Apply the patch 5) Repeat steaps 1-2 6) Ovserve correct punctuation at the end of the preference description. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer changed: What|Removed |Added Attachment #95585|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #6 from Katrin Fischer --- Hi Lisette, nice patch! Just some small things for your next one: - The first line always needs to start with 'Bug :'. - Something seems to happen to the breaks in your patches - no problem, I've fixed it. How do you write the commit message? Maybe try to add an extra empty line after the first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer changed: What|Removed |Added Attachment #95741|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer changed: What|Removed |Added Attachment #95449|0 |1 is obsolete|| Attachment #95710|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 95742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95742=edit Bug 24033: Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match the order form. To test: 1) In acquisitions, create a budget. 2) In acquisitions, create a fund. 3) In acquisitions, create a vendor. 4) In acquisitions, create a basket and add a test item to the basket. 5) Observe the column titles ecost tax inc. and ecost tax exc. Check the column visibility settings if you don't see the columns. 6) Apply the patch. 7) Observe the column titles have been updated. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #4 from Katrin Fischer --- Created attachment 95741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95741=edit k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24088] Add link to item search in staff client main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Maryse Simard changed: What|Removed |Added Attachment #95721|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 95740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95740=edit Bug 24088: Add link to item search in staff client main page In staff client main page, there is a link to advanced search. I propose to add a link to item search below it. This search is very usefull, it needs more visibility. Test plan : 1) Loggin to staff client 2) On main page /cgi-bin/koha/mainpage.pl 3) Check you see a big link to item search below advanced search 4) Click on it and check you go to item search Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24088] Add link to item search in staff client main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Maryse Simard changed: What|Removed |Added Attachment #95722|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 95739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95739=edit Bug 24089: Upgrade jQuery Validate plugin in the staff client This patch upgrades the jQuery Validate plugin in the staff client from v1.10.0 to v1.19.1. To test, apply the patch and clear your browser cache if necessary. Test various pages to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard changed: What|Removed |Added Attachment #95736|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 95738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95738=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24095] New: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Bug ID: 24095 Summary: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org On the "my summary" page in the OPAC, under the holds tab, clicking the delete button for a hold should trigger a confirmation message. The MSG_CONFIRM_DELETE_HOLD is not defined so the confirmation is skipped and the hold is deleted without confirmation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com --- Comment #9 from Maryse Simard --- > Test Plan: > 1) Run the included tests and verify they pass. I can't seem to find which tests this refers to. Could they be missing? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 --- Comment #2 from Owen Leonard --- Created attachment 95737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95737=edit Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #37 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #34) > (In reply to Tomás Cohen Arazi from comment #33) > > Marcel, your patch introduces the use of ->update. Given the problems about > > it raised on bug 21761, could you resubmit it without using ->update? > > Thanks! > > Ah, you are right about that ;) > In this case it is a bit theoretical argument, since LastBorrower only > contains three fields and has no individual store sub. So replacing the > while..next was just regular optimization. > I do not mind setting back the while loop, although personally I would be > inclined to wait on the outcome of the discussion before removing all > updates. Fair enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #4 from Katrin Fischer --- I think we are not far apart - I just don't want to up the requirements. It should still be possible to file a simple bug, growing into the process. We can still ask for more and help people to retrieve this information. - version (easy, about page) - logs (hard, especially since some can't access their servers on this level) - Js console (middle) - OS version (easy, about page) - DBMS (easy, about page) Should we add a copy button to the about page that makes it really easy to get a nicely formatted summary? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24094] New: Authority punctuation mismatch prevents linking to correct records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Bug ID: 24094 Summary: Authority punctuation mismatch prevents linking to correct records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org In a bibliographic record, the comma preceding the relationship designator, i.e., the comma before $e, is prescribed--it has to be there for the record to conform to RDA and MARC21. Authority records view this as a different name/etc, so it does not match. Every, single, correctly cataloged RDA/MARC21 record is going to have a $e preceded by a comma in every authority controlled X00 and X10 field. Authorities need to disregard/strip trailing commas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 --- Comment #1 from Owen Leonard --- Created attachment 95736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95736=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24093] New: Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug ID: 24093 Summary: Sorting indicators broken on list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 23013 Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard changed: What|Removed |Added Blocks||24093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 [Bug 24093] Sorting indicators broken on list contents view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #6 from Victor Grousset/tuxayo --- TODO: - rebase on master (the last 13 months...) - write test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 95735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95735=edit WIP not validated at all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 95734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95734=edit WIP Bug 21507 - Fix decimal separators issues in patrons payments/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 --- Comment #1 from Owen Leonard --- Created attachment 95733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95733=edit Bug 13806: No input sanitization where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22835] Serve static files from plugins through the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 --- Comment #24 from Tomás Cohen Arazi --- @fridolin can we backport this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Suzanne Fayle changed: What|Removed |Added CC|sfa...@roseman.edu | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #19 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Agustín Moyano changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #36 from Agustín Moyano ---
(In reply to Marcel de Rooy from comment #35)
> (In reply to Agustín Moyano from comment #31)
> > (In reply to Marcel de Rooy from comment #24)
> > > Hmm
> > >
> > > sub last_returned_by {
> > > my ( $self, $borrower ) = @_;
> > >
> > > my $items_last_returned_by_rs =
> > > Koha::Database->new()->schema()->resultset('ItemsLastBorrower');
> > >
> > >
> > > Not so nice in Koha::Item. (Possibly out of scope though)
> >
> > This was introduced in Bug 14945.
> >
> > Do you want me to change it to use Items::LastPatrons class?
>
> Another report?
Agreed, I created bug 24092 to address this issue.
Changing this bug to SO again.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Agustín Moyano changed: What|Removed |Added Depends on||23260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 [Bug 23260] Anonymize (remove) patron data from items_last_borrower -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io, ||m.de.r...@rijksmuseum.nl, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano changed: What|Removed |Added Blocks||24092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24092] New: Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092
Bug ID: 24092
Summary: Change Koha::Item to use Items::LastPatrons instead of
ItemLastBorrower resultset
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: agustinmoy...@theke.io
QA Contact: testo...@bugs.koha-community.org
Koha::Item uses
my $items_last_returned_by_rs =
Koha::Database->new()->schema()->resultset('ItemsLastBorrower');
to retrieve item's last borrower.
It should use Items::LastPatrons class introduced in bug 23260
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500
--- Comment #1 from Owen Leonard ---
Created attachment 95732
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95732=edit
Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item
cataloguing pages)
This patch modifies the cataloging plugin dateaccessioned.pl so that it
triggers the addition of a datepicker widget to fields it is linked
with. Despite its name the plugin can be used on any item field which
requires a date.
To test, apply the patch and make sure you have one or more item
subfields linked to the dateaccessioned.pl plugin. For instance, in
MARC21:
- Administration -> MARC bibliographic framework -> MARC structure ->
952 -> Edit subfields:
- subfields d ("Date acquired") and w ("Price effective from"):
- Other options -> Plugin -> dateaccessioned.pl
- Go to cataloging and add or edit an item on a bibliographic record
- The "Date acquired" and "Price effective from" fields should be
styled as datepickers.
- Clicking in these fields should populate the field with today's date
and trigger the datepicker popup.
- Test that all the datepicker features work correctly.
- Test that manual entry of a date works.
- With the AcqCreateItem system preference set to "placing an order,"
go to Acquisitions -> Vendor -> Add to basket.
- Add a title to your basket using your preferred method.
- In the "New order" form, find the section for adding an item.
- Test the "Date acquired" and "Price effective from" fields, which
should behave just like they did in the cataloging module.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize changed: What|Removed |Added CC||bdiazmu...@gmail.com, ||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize changed: What|Removed |Added Attachment #95730|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 95731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95731=edit Bug 24068: (RM follow-up) Enhance the POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Works well and is an obvious correction to a typo.. Signing off and Passing QA in one hit... I've also enhanced the documentation for the module a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068
Martin Renvoize changed:
What|Removed |Added
Attachment #95578|0 |1
is obsolete||
--- Comment #2 from Martin Renvoize ---
Created attachment 95729
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95729=edit
Bug 24068: Fix I18 plugin - tnpx must call __npx
Test plan:
Use the following code to test this change
[% PROCESS 'i18n.inc' %]
[% SET nb_stuffs = 1 %]
[% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.',
nb_stuffs, { count = nb_stuffs }) | $raw %]
[% SET nb_stuffs = 42 %]
[% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.',
nb_stuffs, { count = nb_stuffs }) | $raw %]
Compare with and without the patch
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
