[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mkstephens@lancasterseminar
   ||y.edu

--- Comment #3 from Myka Kennedy Stephens  ---
I'm also finding that the test plan isn't clear.

Here's what I tried:
1. Set up MarcItemsFieldsToOrder; used the example provided in the system
preferences and set mappings for holdingbranch and itype.
2. According to the manual, MarcItemsFieldsToOrder applies to item records
created from a MARC record in a staged file:
a. Staged a MARC record
b. Opened a basket for "My Vendor"
c. Added an order to the basket from staged MARC record
d. Closed the basket
e. Received a shipment
f. Went to record and saw new item
3. At no point in the process was I prompted to enter a ccode or not for loan
value. These remained blank throughout the process.

Tested on master (19.12.00.002)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mkstephens@lancasterseminar
   ||y.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127

--- Comment #10 from Myka Kennedy Stephens  
---
(In reply to Katrin Fischer, comment #9)
Absolutely, bug 24109 should be fixed. It looks like that is well underway.
(Thank you, Nick!)

I didn't mean to start a heated debate. I was sharing a recent experience when
I was particularly thankful for the easy access to search by item location in
the staff-client advanced search. Since the search does work with ES, it is
possible that other libraries (small in number, yes) are using this search
function more regularly than we do at my library.

Yes, I know shelving location is still searchable using ccl. And yes, I am
aware that it could be added back in with JS if a library really needed it. In
the use case I presented, which was different from an everyday workflow, I
would have found it annoying to remember the right ccl syntax in that
moment--but perhaps that says more about my personality than Koha! :-)

If shelving location searching didn't work in both Zebra and ES, I would see a
clear reason to remove it. But since it works in one and not the other, I think
it is important to carefully consider the benefits and drawbacks to all users,
both Zebra and ES. The more ES development takes place, it is likely that we
will run into more of these scenarios where something will work with one search
engine and not the other. Do we really want to remove a feature from Koha
because it doesn't work with Zebra, despite the fact that it works with ES? 

Perhaps a compromise would be to keep shelving location as a drop-down option
in the staff client advanced search only? If there's too much backing to remove
it altogether, I won't stand in the way. I've said my piece.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by shelving location is not converted to correct index

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109

--- Comment #3 from Myka Kennedy Stephens  ---
Patch works as expected. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by shelving location is not converted to correct index

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109

Myka Kennedy Stephens  changed:

   What|Removed |Added

  Attachment #96623|0   |1
is obsolete||

--- Comment #2 from Myka Kennedy Stephens  ---
Created attachment 96628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96628&action=edit
Bug 24109: Map 'loc' to 'location' whne building ES queries

When building the query we start with mc-loc - then we strip the mc, convert
the field, and restore mc-
to indicate the searches should be ORed together.

We have a mapping for mc-loc to location, but we strip the mc for converting

For all other mc indexes there is no issue as they don't need to be mapped
(they are the same minus the mc)

To test:
0 - Be using Elasticsearch and have  AdvancedSearchTypes set to include loc
1 - Perform an advanced search for two shelving locations that have items in
the catalog
2 - Note no restuls
3 - Apply patch
4 - Restart all the things
5 - Repeat search
6 - You get results!

Signed-off-by: Myka Kennedy Stephens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by shelving location is not converted to correct index

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109

Myka Kennedy Stephens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mkstephens@lancasterseminar
   ||y.edu
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Myka Kennedy Stephens  ---
I'm sorry, Nick, but I can't get the patch to apply. I've tried on two
different systems (Mac and Linux) using docker.

Results:
Setup: 19.05.x branch (19.05.06.000 on last attempt); ES enabled, query auto
truncate turned off
1. There are 13 authority records in the test database containing "fiction"
2. 'Default' authority search for "fiction" 
3. Yields 13 results - 3 topical and 10 genre/form
4. 'Genre/Form Term' authority search for "fiction"
5. Yields 0 results
6. Apply patch
7. restart_all, updatedatabase, dbic, reindex ES
8. 'Genre/Form Term' authority search for "fiction"
9. Yields 0 results

Plack error log doesn't show anything. If there's another place to check for
errors to troubleshoot the patch, please let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #96625|0   |1
is obsolete||

--- Comment #85 from Bernardo Gonzalez Kriegel  ---
Created attachment 96627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96627&action=edit
Bug 8643: Add important constraint to marc subfields

This fix permits to add an "Important" option to the marc structure pages.

Testing:

1) Apply the patch
2) Run updatedatabase.pl
3) Regenerate CSS
4) Define 100 as an "important" field ( Administration » MARC bibliographic
framework » MARC structure ( Default Frameword) » Edit )
5) Define 100$a as an "important" subfield (Administration » MARC bibliographic
framework » MARC structure (Default Frameword) » Subfield » Onglet a)
6) Edit a record to clear the field 100 (subfields are all blank)
7) Save the record.
8) Validate the following message:

A few important fields are not filled:

* tag 100 subfield a Nom de personne in tab
* Field 100 is important, at least one of its subfields should be filled.

Are you sure you want to save?

Sponsored by the CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Bernardo Gonzalez Kriegel 
Tested on update and new install, works as described.
No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24262] Translate installer data in YAML format

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Depends on|18688   |
   Patch complexity|--- |Small patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688
[Bug 18688] Warnings about UTF-8 charset when creating a new language
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks|24262   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262
[Bug 24262] Translate installer data in YAML format
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24262] Translate installer data in YAML format

2019-12-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #96593|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 96626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96626&action=edit
Bug 24262: Translate installer data in YAML format

This patch adds the ability to:
1) Create new translation files from yaml installer files
2) Create installer directory for a given language

It will not create a installer directory if it already exists.

New (possible) translation files:
  xx-YY-installer.po
  xx-YY-installer-MARC21.po
  xx-YY-installer-UNIMARC.po

Needs Bug 13897 (for yaml files)

To test:
1) Apply patches from Bug 13897
2) Apply this patch
3) Go to misc/translation
4) Create translation files for a NEW language
   $ ./translate create xx-YY

   check new file 'xx-YY-installer.po'

5) Copy ../../installer/data/mysql/en/optional/auth_val.yml
   into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/
   and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/

   remove po/xx-YY*, then repeat creation

   check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po'
   and 'xx-YY-installer-UNIMARC.po'

   remove all new files

6) Create for xx-YY again and try update
   $ ./translate create xx-YY
   edit ../../installer/data/mysql/en/optional/auth_val.yml
   and change one char in one of the translatable values,
   also edit 'xx-YY-installer.po', translate the same
   string (in msgstr).

   Do an update
   $ ./translate update xx-YY

   check in 'xx-YY-installer.po' a fuzzy value for the
   translated value and the preservation of the translation
   Fix the translation, or add a new one.

7) Create an install dir for xx-YY
   ./translate install xx-YY

Check new dir '../../installer/data/mysql/xx-YY/'
Check files on it
$ tree ../../installer/data/mysql/xx-YY/
and compare with ../../installer/data/mysql/en/

All installation files must be present

8) Try a new Koha install using this language in the
   usual way.
   Check in authorised_values table for the translated string.

9) Try create an install dir for an existing language
   (eg. es-ES, de-DE or fr-FR ), eg.
   ./translate install de-DE

   Install dir is detected and not changed, a note is printed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/