[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass  changed:

   What|Removed |Added

Summary|previousIssuesDefaultSortOr |previousIssuesDefaultSortOr
   |der and |der and
   |todaysIssuesDefaultSortOrde |todaysIssuesDefaultSortOrde
   |r   |r sort incorrectly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

--- Comment #1 from Lucas Gass  ---
Created attachment 97580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97580=edit
Bug 24456: change default sort orders/make wording clearer

TEST PLAN:
1. Apply patch
2. Have some checkout from today and some from multiple previous days.   
3. Set  todaysIssuesDefaultSortOrder &  previousIssuesDefaultSortOrder to
'earliest to latest' and confirm it sorts correctly.  
4. Reverse the 2 system preferences and see that it is now sorting the opposite
way.
5. Also look at the wording of each system prefence and make sure it makes
sense

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24456] New: previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Bug ID: 24456
   Summary: previousIssuesDefaultSortOrder and
todaysIssuesDefaultSortOrder
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder are backwards.
If you choose 'earliest to latest' it sorts 'latest to earliest' and vise
versa.

Also the wording of todaysIssuesDefaultSortOrder is wrong. It says  
"Sort today's checkouts on the circulation page from {X} due date." With
today's checkouts it does not sort by date due but by timestamp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21296] suspend hold ignores system preference on intranet

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21296] suspend hold ignores system preference on intranet

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #95624|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 97579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97579=edit
Bug 21296: suspend hold ignores system preference on intranet

This patch modifies the DataTable configuration for the table of holds
which displays under the "Holds" tab on the patron's checkout and
details pages. A variable is now defined in the JavaScript with the
value of the "SuspendHoldsIntranet" system preference. This variable is
passed to the DataTable configuration to determine whether the column is
visible or not.

One of the changes made in this patch moves a 

[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #7 from Agustín Moyano  ---
Created attachment 97577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97577=edit
Bug 24455: Add moment-timezone library in staff

This patch adds
koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #8 from Agustín Moyano  ---
Created attachment 97578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97578=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the a js-date-format.inc file on each opac and staff interface
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #5 from Agustín Moyano  ---
Created attachment 97575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97575=edit
Bug 24455: Add moment library in staff

This patch adds koha-tmpl/intranet-tmpl/lib/moment/moment.min.js in order to
use the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #6 from Agustín Moyano  ---
Created attachment 97576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97576=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #97567|0   |1
is obsolete||
  Attachment #97568|0   |1
is obsolete||
  Attachment #97569|0   |1
is obsolete||

--- Comment #4 from Agustín Moyano  ---
Created attachment 97574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97574=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24454] currency formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #1 from Agustín Moyano  ---
Created attachment 97573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97573=edit
Bug 24454: Add Currencies.pm template plugin and currency.inc files

This patch adds a new TT plugin called Currencies which retrieves information
about the active currency.

It also adds a currency.inc file in both opac and intranet, which if included
in your TT, you will have the $currency function available in JS.

The $currency function formats numbers into the configured active currency
format.

For example:

$currency(12322.4532) //Returns '$12,322.45' if currency format is 'US' and
active currency has '$' symbol and no space separation.

To test you must implement and test bug 20212, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24454] currency formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24437] Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 23382 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Nick Clemens  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #76 from Nick Clemens  ---
*** Bug 24437 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nick Clemens  changed:

   What|Removed |Added

  Attachment #97525|0   |1
is obsolete||
  Attachment #97526|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 97571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97571=edit
Bug 24448: Unit tests

This patch adds tests for the new method to be introduced. It also moves
the tests for Koha::Biblio->subscriptions to the Biblio.t where it
really belongs.

To test, run this tests along with the patch implementing the new
method.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #4 from Nick Clemens  ---
Created attachment 97572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97572=edit
Bug 24448: Add Koha::Biblio->subscriptions_count

This patch adds the handy subscriptions_count method to the Koha::Biblio
class. It is intended to be used as a shortcut for

$biblio->subscriptions->count

in places like the API where we can embed the output of a method.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
   t/db_dependent/Koha/Biblios.t
=> SUCCESS: Tests pass! i.e. Biblios.t still passes, and the tests for
the new method in Biblio.t pass as well.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Maryse Simard  changed:

   What|Removed |Added

  Attachment #97445|0   |1
is obsolete||

--- Comment #2 from Maryse Simard  ---
Created attachment 97570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97570=edit
Bug 24433: OPAC account page no longer asks for confirmation before deleting
hold

This patch restores markup added by Bug 21870 and subsequently removed
accidentally by Bug 21772. This allows the OPAC user summary page to
display a confirmation dialog before deleting a hold.

To test, apply the patch and  log in to the OPAC as a user with holds.

 - On the "Your summary" page, click the "Holds" tab.
 - Click the "Cancel" button next to any hold.
 - You should see a modal dialog asking for confirmation, showing the
   correct title.
 - Test both the "Yes" and "No" actions.

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #3 from Agustín Moyano  ---
Created attachment 97569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97569=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the
koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc file
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #2 from Agustín Moyano  ---
Created attachment 97568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97568=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #1 from Agustín Moyano  ---
Created attachment 97567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97567=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #97404|0   |1
is obsolete||

--- Comment #4 from Cori Lynn Arnold  ---
Created attachment 97566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97566=edit
Bug 24429: Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they
are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano  changed:

   What|Removed |Added

 Depends on||24455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano  changed:

   What|Removed |Added

 Blocks||20936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #9 from Nick Clemens  ---
Created attachment 97564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97564=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio

This patch introduces an accessor to the related orders, and a method
that returns the active orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:

$biblio->orders->count

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #10 from Nick Clemens  ---
Created attachment 97565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97565=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

--- Comment #6 from Nick Clemens  ---
Created attachment 97562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97562=edit
Bug 24435: Add Koha::Biblio->items_count

This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:

  $count = $biblio->items->count;
you can call:
  $count = $biblio->items_count;

The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:

   $biblio->to_api({ embed => { items_count => {} } });

If there are several nested layers of objects, doing manually can get
really tricky and error prone.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nick Clemens  changed:

   What|Removed |Added

  Attachment #97446|0   |1
is obsolete||
  Attachment #97447|0   |1
is obsolete||
  Attachment #97448|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 97563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97563=edit
Bug 24430: Unit tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Nick Clemens  changed:

   What|Removed |Added

  Attachment #97489|0   |1
is obsolete||
  Attachment #97490|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 97561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97561=edit
Bug 24435: Unit tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard  changed:

   What|Removed |Added

  Attachment #97482|0   |1
is obsolete||

--- Comment #10 from Maryse Simard  ---
Created attachment 97559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97559=edit
Bug 24443: Consider NULL as 0 for issues in items search

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

Test plan:
1) Use SQL to count items with items.issues = NULL :
   select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard  changed:

   What|Removed |Added

  Attachment #97496|0   |1
is obsolete||

--- Comment #11 from Maryse Simard  ---
Created attachment 97560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97560=edit
Bug 24443: Unit test

Signed-off-by: Maryse Simard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items search

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Cori Lynn Arnold  ---
Found a couple issues, pulling this back.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97460|0   |1
is obsolete||

--- Comment #49 from David Nind  ---
Created attachment 97557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97557=edit
Bug 7468: (follow-up) Add missing filters

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97458|0   |1
is obsolete||

--- Comment #47 from David Nind  ---
Created attachment 97555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97555=edit
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97459|0   |1
is obsolete||

--- Comment #48 from David Nind  ---
Created attachment 97556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97556=edit
Bug 7468: (follow-up) fix label-edit-range template

Edit the labels/label-edit-range.tt template to follow current
standards :
- Use footer javascript
- Use bootstrap grid
- Use jQuery Validation plugin for validation

Also fixes breadcrumbs to be more specific.

To test:
Make sure the page looks correct and still works as expected.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97461|0   |1
is obsolete||

--- Comment #50 from David Nind  ---
Created attachment 97558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97558=edit
Bug 7468: fix the export labels popup header

When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.

To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97457|0   |1
is obsolete||

--- Comment #46 from David Nind  ---
Created attachment 97554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97554=edit
Bug 7468: Showing the error message according to the community interface
patterns, fixing a javascript condition

TEST PLAN++

1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the
"Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
. Either by entering the URL directly
. OR, from the front page, by clicking "Tools", followed by the hyperlink
"Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
. Keeping both fields at "0" should trigger a warning beside the first
field: "*Cannot be smaller than 1"
. If the value "From:" is greater the "To:" value, a warning should appear
beside the second field: "*Cannot be smaller than the starting value"
. Make sure the form doesn't let you enter non-numerical values
. For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a
starting position
. The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of
0pt, don't use it
. All the default layouts should look alike, since we're only printing a
barcode over a number, and not bibliographic information
. Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a
"Download as PDF" hyperlink. Clicking the link should prop up a download dialog
box
8) Save the PDF locally, or simply open it, and make sure the options you used
were taken into account

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97456|0   |1
is obsolete||

--- Comment #45 from David Nind  ---
Created attachment 97553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97553=edit
Bug 7468: Add warning when range has non-existent barcodes

+ Added a warning when the user selects a range with some non-existent
barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so
desires, but will warn him if he tries to print only biblios (which results in
missing entries or a blank page).

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97454|0   |1
is obsolete||

--- Comment #43 from David Nind  ---
Created attachment 97551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97551=edit
Bug 7468: Print barcodes by range

Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.

C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding  database entry.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind  changed:

   What|Removed |Added

  Attachment #97455|0   |1
is obsolete||

--- Comment #44 from David Nind  ---
Created attachment 97552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97552=edit
Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #97449|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 97550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97550=edit
Bug 24434: Remove updateWrongTransfer

This patch simply removes the unused updateWrongTransfer method from
C4::Circulation.

Test plan: Read code and varify that the method would never actually be
triggered.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24455] New: date formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Bug ID: 24455
   Summary: date formatting from JS
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: agustinmoy...@theke.io
  Reporter: agustinmoy...@theke.io
QA Contact: testo...@bugs.koha-community.org
CC: tomasco...@gmail.com

API calls in OPAC brings raw JSON.

We need a way to format data into the configured date from JS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Cori Lynn Arnold  changed:

   What|Removed |Added

 CC||carn...@dgiinc.com
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Cori Lynn Arnold  ---
Exactly as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #95694|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 97549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97549=edit
Bug 16683: Help links to fields 59X in cataloguing form are broken

This patch adds more specificity to handling of MARC21 documentation
links in the basic MARC editor.

To test, apply the patch and make sure the "advancedMARCeditor" system
preference is set to "Display."

You may need to edit a bibliographic framework so that 09x, 59x, and 69x
tags will display in the editor.

Edit or create a bibliographic record using that framework. Next to each
tag label in the editor should be a "?" link. Clicking this link should
open a new window with the correct Library of Congress documentation
page.

Check the links for 09x, 59x, and 69x tags as well as others to confirm
they open the correct pages.

Signed-off-by: Cori Lynn Arnold 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24454] New: currency formatting from JS

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Bug ID: 24454
   Summary: currency formatting from JS
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: agustinmoy...@theke.io
  Reporter: agustinmoy...@theke.io
QA Contact: testo...@bugs.koha-community.org
CC: tomasco...@gmail.com

API calls in OPAC brings raw JSON.

We need a way to format data into the configured currency from JS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24453] New: Framework configuration, silently fails with no "Text for librarian"

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24453

Bug ID: 24453
   Summary: Framework configuration, silently fails with no "Text
for librarian"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: carn...@dgiinc.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When creating a new subfield for a framework, the subfield will silently not
save if the "Text for librarian" field isn't populated.

Reproduce issue:

1. Go to Administration->MARC bibliographic framework
2. Edit the Default framework by clicking the "Action" button and selecting
"Marc Framework"
3. Search for tag 500
4. Click on the "Action" button and select "Edit subfields"
5. Click on the "New" tab
6. Enter 9 into the subfield code and leave the rest default
7. Hit "Save changes" button

RESULT:
List of all the subfields is shown with no subfield 9

Expected:
List to include subfield 9

Repeating the same processes but adding "Some Text" to the "Text for librarian"
field results in a proper save.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23618] Make addition SIP2 fields available to self service to add cost of items checked out to check out slip

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23618

--- Comment #2 from Niamh  ---
I have seen this done on check out receipts from other systems. 
I am looking for the additional fields to be added that will create the
message. It doesn't have to be the ones that I've mentioned previously, so long
as the outcome is the desired one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Cori Lynn Arnold  ---
Absolutely fantastic! Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #97531|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 97548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97548=edit
Bug 24452: Advanced editor - show multiple spaces visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that multiple consecutive spaces within a line will be detected and
highlighted.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

 - Go to Cataloging -> Advanced editor.
 - On any text entry line (e.g. 245), enter some words with one, two,
   and more spaces in between them. When there are two or more spaces
   between words the spaces between the words should have a dotted red
   underline.
 - Remove the extra spaces and confirm that the dotted line disappears.

Signed-off-by: Cori Lynn Arnold 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|In Discussion   |ASSIGNED

--- Comment #4 from Andrew Fuerste-Henry  ---
Removing In Discussion flag as Jonathan opened a new bug for his question.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24435


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435
[Bug 24435] Add Koha::Biblio->items_count
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||24418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
[Bug 24418] Add Koha::Biblio->suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00, 19.05.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #75 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #10 from Tomás Cohen Arazi  ---
I submit an unfinished implementation that renders both the original table, and
the new one (generated through the API). The aim is to get people to review it,
and suggest changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 97545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97545=edit
Bug 20212: Extend datatables for API interaction

This patch introduces an .api method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 97547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97547=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 97546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97546=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #97055|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 97544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97544=edit
Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn
is enabled

In Koha 18.11 backdating a return triggered a recalculation of the fine. This
was removed in bug 14591, and I believe it was in error. The bug report itself
has no justification for the change in behavior.

Test Plan:
1) Disable CalculateFinesOnReturn
2) Backdate an overdue with fines, note the fine does not change
3) Apply this patch
4) Repeat step 2
5) The fine should be updated!

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Kelly McElligott  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #96765|0   |1
is obsolete||

--- Comment #4 from ByWater Sandboxes  ---
Created attachment 97543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97543=edit
Bug 24286: Escape forward slash in GENRE/FORM (and any authtype)

Note that bug 24267 will fix the issue during Z39 searching for new auth, but
the duplicate check at saving will still fail

To test:
 0 - Set SearchEngine to Elasticsearch,  QueryRegexEscapeOptions  to 'Don't
Escape'
 1 - Browse to Authorities
 2 - Select New->New from Z3950
 3 - Search for subject 'Short stories'
 4 - Auth search explodes
 5 - Apply patch
 6 - Repeat and confirm the search results return
 7 - Import and save the GENRE/FORM record for Short stories
 8 - Repeat the search and import the same record
 9 - Confirm that upon save you are notified of duplicate, don't save
10 - set  QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works
and importing/save notifies of duplicate
11 - set SearchEngine to Zebra and confirm Z39 searching works and
importing/save notifies of duplicate

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97512|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 97542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97542=edit
Bug 23092: Add 'daterequested' to branchtransfers table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97500|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize  ---
Created attachment 97541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97541=edit
Bug 24297: Record 'Manual' trigger transfers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24436] Record if a transfer was triggered by a 'hold'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97510|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 97539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97539=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97509|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 97538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97538=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24436] Record if a transfer was triggered by a 'hold'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97511|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 97540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97540=edit
Bug 24436: Add handling for reserve transfer triggers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97508|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 97537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97537=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97507|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 97536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97536=edit
Bug 24298: Record transfer triggers for returns

This patch adds handling to catch transfers that may have been triggered
on item return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97506|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 97535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97535=edit
Bug 24298: Add return enums to branchstransfer triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #8 from Martin Renvoize  ---
Created attachment 97534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97534=edit
Bug 24296: Update stockrotation process to use branchtransfers.reason

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'reason' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97517|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 97533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97533=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24287] Transfers should record how they were triggered.

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #97516|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 97532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97532=edit
Bug 24287: Add `trigger` to `branchtransfers`

This patch adds the `trigger` field to the `branchtransfers` table to
record what triggered a transfer.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14476] Improving opac-search performances

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #12 from Julian Maurice  ---
Since caching the XSLT result is not desirable, should we close this bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #26 from Julian Maurice  ---
Forgot to change the status. Back to "signed off"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

--- Comment #1 from Owen Leonard  ---
Created attachment 97531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97531=edit
Bug 24452: Advanced editor - show multiple spaces visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that multiple consecutive spaces within a line will be detected and
highlighted.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

 - Go to Cataloging -> Advanced editor.
 - On any text entry line (e.g. 245), enter some words with one, two,
   and more spaces in between them. When there are two or more spaces
   between words the spaces between the words should have a dotted red
   underline.
 - Remove the extra spaces and confirm that the dotted line disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24452] New: Advanced editor - show multiple spaces visually

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Bug ID: 24452
   Summary: Advanced editor - show multiple spaces visually
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: carn...@dgiinc.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Currently end of the line spaces are shown by highlighting them. Catalogers
would like to see where there are duplicate spaces in a line so they can remove
them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24451] New: Clarify wording when deleting a bib attached to orders

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24451

Bug ID: 24451
   Summary: Clarify wording when deleting a bib attached to orders
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

From detail.pl, when attempting to delete a bib that is connected to any
uncanceled orders in acquisitions, we receive the message: "Warning: This
record is used in X order(s). Deleting it could cause serious issues on
acquisition module. Are you sure you want to delete this record?"

This message would be more helpful if it distinguished between open and closed
orders. Deleting a bib connected to an open order will cause serious issues.
Deleting a bib connected to closed orders will not.

I see three possible fixes:
- Change the message to specify "This record is used in X open order(s) and Y
closed order(s). Deleting a record used in open orders could cause serious
issues ..."
- Change the message to only appear if the bib is used in orders connected to
an active budget and give a count of only orders connected to an active budget.
- Complete bug 16872 to entirely block the deletion of bibs in open orders,
then remove this warning. If we're not allowing the deletion of bibs from open
orders, then it's not a big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not implemented

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264

Lucas Gass  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldstable
 Version(s)||19.05.07
released in||

--- Comment #8 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24432] order_by broken for date columns

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 97528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97528=edit
Bug 24432: Regresion test

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24432] order_by broken for date columns

2020-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 97529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97529=edit
Bug 24432: add Koha::Objects->from_api_mapping

This patch adds from_api_mapping to Koha::Objects, in order to be able to get
the mapping from a result set.

To test:
1. apply this patch
2. prove t/db_dependent/Koha/Objects.t
3. sign off

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >