[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #94 from David Nind --- Created attachment 99801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99801=edit Screenshots - screens not aligned correctly It may be my setup (using koha-testing-docker) but I can't seem to get the staff interface screens and the signage to display correctly (Firefox, Google Chrome, and Chromium on Ubuntu 18.04). In the staff interface the add and edit screens take up the whole width of the screen, and the other tools menu items are pushed to the bottom. On the signage screens, things don't display correctly. Screenshots attached. Notes from testing : - Apply patches - Run updatedatabase - Run dbic - flush_memcached - restart_all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24763] Backdating check-ins creating fine issues that can't be resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24763 --- Comment #2 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #1) > This should be resolved as of bug 21747. The excess payment amount is moved > into a credit. Do you have examples generated after you moved to 19.05? Check our support tickets. They have all been handled through Bywater because we couldn't do anything with them. I would think if it were fixed, our backdating wouldn't be touching it at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #40 from Nick Clemens --- Created attachment 99800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99800=edit Bug 24476: Allow direct editing of autorenew_checkouts by patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #38 from Nick Clemens --- Created attachment 99798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99798=edit Bug 24476: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #37 from Nick Clemens --- Created attachment 99797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99797=edit Bug 24476: Rename autorenewal to autorenew_checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #39 from Nick Clemens --- Created attachment 99799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99799=edit Bug 24476: Add boolean for TINYINT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #36 from Nick Clemens --- Created attachment 99796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99796=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #35 from Nick Clemens --- Created attachment 99795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99795=edit Bug 24476: Change CanBookBeRenewed and adjust tests Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #34 from Nick Clemens --- Created attachment 99794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99794=edit Bug 24476: API Updates Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Nick Clemens changed: What|Removed |Added Attachment #97997|0 |1 is obsolete|| Attachment #97998|0 |1 is obsolete|| Attachment #97999|0 |1 is obsolete|| Attachment #98000|0 |1 is obsolete|| Attachment #98001|0 |1 is obsolete|| Attachment #98002|0 |1 is obsolete|| --- Comment #33 from Nick Clemens --- Created attachment 99793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99793=edit Bug 24476: Database updates Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24765] New: Updated on date in Claims returned starts off as 12/31/1969
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24765 Bug ID: 24765 Summary: Updated on date in Claims returned starts off as 12/31/1969 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: k...@bywatersolutions.com Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Looking at other data tables with date columns that are blank - this display is not doing the same thing, such as Aqorders or Purchase Suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24763] Backdating check-ins creating fine issues that can't be resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24763 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- This should be resolved as of bug 21747. The excess payment amount is moved into a credit. Do you have examples generated after you moved to 19.05? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 --- Comment #7 from Michal Denar --- Created attachment 99792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99792=edit Bug 24559: Database update Signed-off-by: Michal Denar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 Michal Denar changed: What|Removed |Added Attachment #99626|0 |1 is obsolete|| Attachment #99785|0 |1 is obsolete|| --- Comment #6 from Michal Denar --- Created attachment 99791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99791=edit Bug 24559: Add 'year' type to Elasticsearch When indexing fields like 260c or 008_/7-10 we need a way to format these 'date' fields into years. Removing punctuation and coverting unknown values to 0 To test: 1 - Edit some records to have dates of publication in 008 like 202u 2021 203u 2039 2 - Also add to title for all records a unique word like 'octoparrot' 3 - Search for 'octoparrot' 4 - Sort records by publication/copyrightdate 5 - Confirm sorting is not as expected 6 - Apply patch 7 - Set copydate to 'year' type 8 - Reindex 9 - Repeat search 10 - Confirm sorting works as expected Nice work, Nick. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Maryse Simard changed: What|Removed |Added Attachment #99786|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 99790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99790=edit Bug 23753: Add missing humanMsg library to pages using background job JavaScript The JavaScript used to process background uploads calls the humanMsg library under some circumstances. There are several templates which use background-job-progressbar.js which don't include the humanMsg assets. This patch corrects those templates. Note: upload-images.tt has been modified to remove the inclusion of background-job-progressbar.js because it was unused. To test, apply the patch and test the following processes which include background job processing: - Batch item modification -- the background job is triggered when you submit your changes - Batch record modification -- the background job is triggered when you submit your changes - Stage MARC for import -- the background job is triggered when you click the "Sage for import" button after uploading a file - Staged MARC management -- the background job is triggered when you click "Import this batch into the catalog" In each case the process should complete correctly. If you would like to test the error message handling provided by the humanMsg library you can deliberately introduce an error into the JavaScript. After applying the patch you can modify js/background-job-progressbar.js to alter line 63 from: url: f.action, ...to: url: f.action + "foo", Perform the same tests and confirm that you see an error message. Don't forget to undo your changes to background-job-progressbar.js before signing off. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] New: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Bug ID: 24764 Summary: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Currently if you use the HTML option in the news tool TinyMCE does automatic code cleanup and this can be problematic. If I enter into the HTML field: The editor thinks this is nothing and won't update code at all. IF I enter: TEST the editor changes it to: TEST It would be better if the feature didn't auto cleanup HTML. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19036] Number payment receipts / payment slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 --- Comment #13 from Martin Renvoize --- Note to self.. I'd like to add support for cash_register_id + timstamp as an option for numbering.. I'll post that as a followup once we've worked through my other comments ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Agustín Moyano changed: What|Removed |Added Depends on||23640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 [Bug 23640] L1 cache too long in SIP Server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23640] L1 cache too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Agustín Moyano changed: What|Removed |Added Blocks||23223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 [Bug 23223] Allow requested items to be checked out via SIP2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 24639, which changed state. Bug 24639 Summary: Update libsearch-elasticsearch-perl to 6.00-1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 --- Comment #4 from Mason James --- *** Bug 24639 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24639] Update libsearch-elasticsearch-perl to 6.00-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24639 Mason James changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Mason James --- *** This bug has been marked as a duplicate of bug 24552 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 14759, which changed state. Bug 14759 Summary: Replacement for Text::Unaccent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 What|Removed |Added Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Mason James changed: What|Removed |Added Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Mason James changed: What|Removed |Added Severity|minor |critical Priority|P5 - low|P1 - high --- Comment #3 from Mason James --- increasing severiyy to fix broken jenkins https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/5/consoleText koha_1 | Test Summary Report koha_1 | --- koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 2816 Tests: 2 Failed: 1) koha_1 | Failed test: 2 koha_1 | Non-zero exit status: 11 koha_1 | t/db_dependent/Koha/Patrons.t (Wstat: 512 Tests: 40 Failed: 2) koha_1 | Failed tests: 17-18 koha_1 | Non-zero exit status: 2 koha_1 | t/db_dependent/Koha/XSLT/Security.t (Wstat: 256 Tests: 8 Failed: 1) koha_1 | Failed test: 7 koha_1 | Non-zero exit status: 1 koha_1 | t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 512 Tests: 4 Failed: 0) koha_1 | Non-zero exit status: 2 koha_1 | Parse errors: Bad plan. You planned 13 tests but ran 4. koha_1 | Files=499, Tests=13968, 2404.87 wallclock secs ( 4.84 usr 9.79 sys + 2334.25 cusr 768.49 csys = 3117.37 CPU) koha_1 | Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24763] New: Backdating check-ins creating fine issues that can't be resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24763 Bug ID: 24763 Summary: Backdating check-ins creating fine issues that can't be resolved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org From ByWater: When libraries accept payment on accruing fines and then backdate the checkin of the item, the final amount due can end up less than the amount paid. (There are other ways for this to happen, but backdated checkin is the most common.) It's not a fine that can be paid off (because it's negative), but it's not truly a credit either so it cannot be reconciled or voided. We would like to see this addressed so we can continue to backdate our overnight bookdrop items without these issues, and without having to constantly ask our support vendor to remove them for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96426|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 99789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99789=edit Bug 22273: Modify Koha::ArticleRequest->store to fill created_on For a new record, store should fill created_on. The database will always update the timestamp updated_on. Since open also calls SUPER::store, we do not need to call it twice. Test plan: [1] Run t/db_dependent/ArticleRequests.t [2] In the interface, add two article requests. Change the status of one to PROCESSING. Check created_on and updated_on in the article_requests table. The changed request should have updated_on > created_on. Signed-off-by: Bernardo Gonzalez Kriegel [1] Tests pass ok 12 - New article request has created_on date set ok 13 - New article request has updated_on date set [2] Work as described. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96425|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 99788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99788=edit Bug 22273: Database revision for table article_requests Column created_on should not be updated. It is filled once by the store method of Koha::ArticleRequest. Column updated_on should be a timestamp, updated by the database. Note: Although higher versions of MySQL and MariaDB support two timestamps (NOT NULL) in one table, I kept on the safe side by allowing NULL on the created_on column. @RM: Don't forget to run DBIx update. Test plan: Run new install or upgrade. Signed-off-by: Bernardo Gonzalez Kriegel Tested running update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96424|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 99787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99787=edit Bug 22273: Replace typo opan by opac in POD Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23640] L1 cache too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24761 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24761 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 [Bug 24761] Caching issues in scripts running in daemon mode [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 Tomás Cohen Arazi changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23640 | Summary|Caching issues in scripts |Caching issues in scripts |running in daemon mode |running in daemon mode ||[OMNIBUS] Depends on||23640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 [Bug 23640] L1 cache too long in SIP Server -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96235|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Comment on attachment 96235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96235 Bug 23223: Disable syspref cache in SIPServer I'm obsoleting the sysprefs caching handling patch here, as I wasn't aware of bug 23640. Thanks Jonathan for pointing that out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 --- Comment #4 from Owen Leonard --- I changed the title of this bug to reflect the new aim of the patch: To include the humanMsg library on pages which need it (rather than removing it as a dependency). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21865] improve remove_unused_authorities.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21865
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
--- Comment #4 from Bernardo Gonzalez Kriegel ---
Hi,
with this code
40 if ( $want_help || !$confirm ) {
you need to confirm even to do a test.
Is that the intended behavior?
May be "if ( $want_help || !($test || $confirm) ) {"
Otherwise the script works well (tested using zebra)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 --- Comment #3 from Owen Leonard --- Created attachment 99786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99786=edit Bug 23753: Add missing humanMsg library to pages using background job JavaScript The JavaScript used to process background uploads calls the humanMsg library under some circumstances. There are several templates which use background-job-progressbar.js which don't include the humanMsg assets. This patch corrects those templates. Note: upload-images.tt has been modified to remove the inclusion of background-job-progressbar.js because it was unused. To test, apply the patch and test the following processes which include background job processing: - Batch item modification -- the background job is triggered when you submit your changes - Batch record modification -- the background job is triggered when you submit your changes - Stage MARC for import -- the background job is triggered when you click the "Sage for import" button after uploading a file - Staged MARC management -- the background job is triggered when you click "Import this batch into the catalog" In each case the process should complete correctly. If you would like to test the error message handling provided by the humanMsg library you can deliberately introduce an error into the JavaScript. After applying the patch you can modify js/background-job-progressbar.js to alter line 63 from: url: f.action, ...to: url: f.action + "foo", Perform the same tests and confirm that you see an error message. Don't forget to undo your changes to background-job-progressbar.js before signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Owen Leonard changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory for js files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 --- Comment #5 from Nick Clemens --- (In reply to Myka Kennedy Stephens from comment #3) > Nick, I'm getting this error when I try to change copydate to Year: > An error occurred when updating mappings: > DBIx::Class::Storage::DBI::_dbh_execute(): Data truncated for column 'type' > at row 1 at /kohadevbox/koha/Koha/Object.pm line 156 . > > How do I fix that? (and how on earth did you come up with octoparrot??) Hah, you need the update I didn't attach It's a Simpsons joke: https://giphy.com/gifs/season-12-the-simpsons-12x9-3orifddyIN9i0I9tp6 "polly shouldn't be" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 --- Comment #4 from Nick Clemens --- Created attachment 99785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99785=edit Bug 24559: Database update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #21 from Bernardo Gonzalez Kriegel --- (In reply to Martin Renvoize from comment #5) > 1) Enable AutoItemReturn and accompanying system preference It is AutomaticItemReturn :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #99777|0 |1 is obsolete|| --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 99784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99784=edit Bug 24298: (follow-up) Add missing filter! Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #99776|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 99783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99783=edit Bug 24298: Add tests for ModItemTransfer Signed-off-by: Bernardo Gonzalez Kriegel All 8 tests in 'ModItemTransfer tests' pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #99774|0 |1 is obsolete|| --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 99781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99781=edit Bug 24298: Add return enums to branchstransfer triggers Signed-off-by: Bernardo Gonzalez Kriegel updatedabase runs Ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #99775|0 |1 is obsolete|| --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 99782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99782=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. Test Plan: 1) Enable AutomaticItemReturn and accompanying system preference 2) Return an item to the wrong branch and note the transfer 3) Check the database for the new trigger value Signed-off-by: Bernardo Gonzalez Kriegel Added test plan. Works Ok, trigger saved in database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Owen Leonard changed: What|Removed |Added Attachment #94027|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED CC||n...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #18 from Nick Clemens --- More general code cleanup on other bug, moved the unit tests from here to there *** This bug has been marked as a duplicate of bug 24759 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koha::Item method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from Nick Clemens --- *** Bug 23165 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koha::Item method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 Nick Clemens changed: What|Removed |Added Summary|OpacRenewalBranch code |OpacRenewalBranch code |should be a Koh::Item |should be a Koha::Item |method |method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Owen Leonard changed: What|Removed |Added Summary|Background job JavaScript |Add missing humanMsg |should not try to call |library to pages using |humanMsg library|background job JavaScript Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koh::Item method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 --- Comment #4 from Nick Clemens --- Created attachment 99780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99780=edit Bug 23165: Unit tests for AddRenewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #22 from Martin Renvoize --- (In reply to Jonathan Druart from comment #21) > My feeling is that we should maintain a list of "accepted"/"validated" > plugins, and so have a WS serving (on a Koha community server) that list. I did initially think the same and intended to write such a service.. however I have come around to this approach as it reduces the need build, host and maintain another system, not to mention maintaining the data. I have added followup bugs that request we add signatures to plugin releases and a way from inside Koha itself to validate those. Once we have those I think we pretty much have what you are suggesting.. we can update the default config we ship to only include a pointer to the community gitlab and as we as a community deem a plugin to have reached a level of maturity we are happy with we can suggest an adoption of it into our gitlab and thus sign subsequent releases. Hope that makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19036] Number payment receipts / payment slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19036] Number payment receipts / payment slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #12 from Martin Renvoize ---
Comment on attachment 99676
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99676
Bug 19036: Add ability to auto generate a number for account credits
Review of attachment 99676:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19036=99676)
-
Great work Julian, I really wasn't sure what the criteria were for this yet so
I'm really pleased to see you've taken it on.
Just a few comments and questions as outlined:
::: Koha/Account/Line.pm
@@ +771,5 @@
> +sub store {
> +my ($self) = @_;
> +
> +my $AutoCreditNumber = C4::Context->preference('AutoCreditNumber');
> +if ($AutoCreditNumber && !$self->in_storage && $self->is_credit &&
> !$self->credit_number) {
Hmm, I slightly wonder if it's a good idea to allow passing credit_number and
allowing it to override the AudoCreditNumber setting.. to me if it's set then
we should throw an Exception if someone is trying to pass in their own?
Not a failing case, but wanted to raise as a question.
The second question here.. should this apply to ALL credit types, or just a
subset of those that actually deal with taking money as apposed to writeoffs
and other types of giving credit (like LOST_ITEM_RETURN)?
@@ +773,5 @@
> +
> +my $AutoCreditNumber = C4::Context->preference('AutoCreditNumber');
> +if ($AutoCreditNumber && !$self->in_storage && $self->is_credit &&
> !$self->credit_number) {
> +my $rs = Koha::Database->new->schema->resultset($self->_type);
> +
It feels like this whole block should be inside a transaction.. you're doing a
lookup followed by a store using calculated data.. what if another db
connection adds a payment line at the same time?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24162] Late orders improvements - display new columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Devinim changed: What|Removed |Added Attachment #98693|0 |1 is obsolete|| --- Comment #4 from Devinim --- Created attachment 99779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99779=edit Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24162] Late orders improvements - display new columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #6 from Nick Clemens --- Created attachment 99778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99778=edit Bug 23165: Set branch for renewal Originally I used 'opac' as the interface so that we would follow opac rules for setting the branches for renewals. If using api we must explicitly state the branch - falling back to the checkout branch is the simplest fix as we don't have a user here. This also corrects typo if setting surname/firstname to CRON instead of ILSDI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #15 from Martin Renvoize --- Created attachment 99777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99777=edit Bug 24298: (follow-up) Add missing filter! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Attachment #98293|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 99775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99775=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #16 from Martin Renvoize --- (In reply to Bernardo Gonzalez Kriegel from comment #11) > Hi, > qa tools complains > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >FAIL filters > missing_filter at line 522 ( > ) > > $raw/html? Thanks for taking a look Bernardo.. all fixed up in the followup :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Attachment #98294|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 99776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99776=edit Bug 24298: Add tests for ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Attachment #98292|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 99774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99774=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What|Removed |Added Depends on||24434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Blocks||22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Blocks|24298 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Depends on|24434 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24726] overdue_notices.pl should use Koha::Library->get_effective_email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24726 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24723] EmailPurchaseSuggestions should use Koha::Library->get_effective_email when set to 'BranchEmailAddress'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24723 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24721] emailLibrarianWhenHoldIsPlaced should use Koha::Library->get_effective_email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24721 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22821] Patron notes about item email notification fallback order is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #17 from Martin Renvoize --- Excellent testing Myka, thankyou :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining the inbound email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 --- Comment #10 from Martin Renvoize --- Thanks for testing Bernardo :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22821] Patron notes about item email notification fallback order is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining the inbound email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #5 from Martin Renvoize --- Created attachment 99773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99773=edit Bug 24754: (QA follow-up) opac -> api for 'interface' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Martin Renvoize changed: What|Removed |Added Attachment #99768|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 99772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99772=edit Bug 24754: Set userenv for ilsdi requests To test: 1 - Enable ILSDI in systempreferences 2 - Checkout an item to a patron 3 - Enable Renewal logs 4 - Ensure you will be able to renew the item several times 5 - Open an incognito/private browser 6 - Renew item via ilsdi: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan_id=5_id=1128 7 - Check action logs - note renewal is indicated as opac 8 - In private browser open a new tab 9 - Sign in to staff client 10 - Return to other tab 11 - Refresh page to repeat renewal 12 - Check action_logs 13 - The second renewal indicates it was renewed via intranet by logged in staff member 14 - Apply patch 15 - restart_all 16 - Ensure staff client still signed in 17 - Repeate renewal again 18 - Check logs, renewal now indicates opac again (as it should) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754
--- Comment #3 from Martin Renvoize ---
Comment on attachment 99768
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99768
Bug 24754: Set userenv for ilsdi requests
Review of attachment 99768:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24754=99768)
-
::: opac/ilsdi.pl
@@ +129,5 @@
>
> +# Set the userenv
> +C4::Context->_new_userenv(1);
> +C4::Context->set_userenv(
> +undef, undef, undef, 'CRON', 'CRON', undef,
OK.. so those are being used as 'firstname' and 'surname'.. weird..
CRON is probably OK
@@ +132,5 @@
> +C4::Context->set_userenv(
> +undef, undef, undef, 'CRON', 'CRON', undef,
> +undef, undef, undef, undef, undef
> +);
> +C4::Context->interface('opac'); #FIXME 'ilsdi' should be a valid value?
Valid values are currently 'api', 'opac', 'intranet', 'sip', 'cron' and
'commandline'..
I reckon 'api' would fit reasonably well here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #2 from Martin Renvoize --- Comment on attachment 99768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99768 Bug 24754: Set userenv for ilsdi requests Review of attachment 99768: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24754=99768) - ::: opac/ilsdi.pl @@ +129,5 @@ > > +# Set the userenv > +C4::Context->_new_userenv(1); > +C4::Context->set_userenv( > +undef, undef, undef, 'CRON', 'CRON', undef, Those 'CRON' values stand out as a little weird here to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24762] New: Statuses that should not be manually changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24762 Bug ID: 24762 Summary: Statuses that should not be manually changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be great if there were an option for each status, as to weather it could be manually changed or not. We have cases where the long overdue lost status is changed manually, and it disrupts the automated processing of fines/fees. It would be great if we had this option. Seems easy enough to implement too, if an option is found active, the status is disabled. It should not be allowed to affect automatic processes though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24761 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23223 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24162] Late orders improvements - display new columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #29 from Jonathan Druart --- Created attachment 99771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99771=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) > Owen, sorry but I found a regression. > > With OPACPopupAuthorsSearch and NOT OPACXSLTDetailsDisplay > Hit /cgi-bin/koha/opac-detail.pl?biblionumber=15 > Without the patch, the link on "Additional authors: Bradbury, Nicola." opens > a popup. It does not with your patch. Saw with Owen on IRC. There was only 1 checkbox on the popup, so assuming it's a bug fix and not a regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Attachment #99296|0 |1 is obsolete|| Attachment #99297|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 99770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99770=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24739] Buster ships with Net::Netmask 1.9104 which supports IPv6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23640] L1 cache too long in SIP Server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24761 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23640 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Invalidation of L1 cache for SIP has been done on bug 23640. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What|Removed |Added Attachment #92663|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 99769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99769=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||j...@bywatersolutions.com, ||jza...@bywatersolutions.com ||, mag...@libriotech.no, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #1 from Nick Clemens --- Created attachment 99768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99768=edit Bug 24754: Set userenv for ilsdi requests To test: 1 - Enable ILSDI in systempreferences 2 - Checkout an item to a patron 3 - Enable Renewal logs 4 - Ensure you will be able to renew the item several times 5 - Open an incognito/private browser 6 - Renew item via ilsdi: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan_id=5_id=1128 7 - Check action logs - note renewal is indicated as opac 8 - In private browser open a new tab 9 - Sign in to staff client 10 - Return to other tab 11 - Refresh page to repeat renewal 12 - Check action_logs 13 - The second renewal indicates it was renewed via intranet by logged in staff member 14 - Apply patch 15 - restart_all 16 - Ensure staff client still signed in 17 - Repeate renewal again 18 - Check logs, renewal now indicates opac again (as it should) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What|Removed |Added Attachment #92662|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 99767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99767=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
