[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #15 from Arthur Suzuki --- Hi David, last patch i can see on master is 22816, is it the same on your side?... I use gitlab as my remote : https://gitlab.com/koha-community/Koha I guess I'm doing smthg wrong but can't figure out what. I'll try to check around with my colleagues. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969 Marcel de Rooy changed: What|Removed |Added Attachment #100158|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 100213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100213=edit Bug 22969: fix biblionumber on 001 in UNIMARC XSLT In UNIMARC default configuration the 001 is linked to biblio.biblionumber. In some XSLT files, 090$a is used. This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page. Test plan : 1) Use UNIMARC database 2) Set default in all XSLT system preferences 3) At OPAC, perform a search and click on a result 4) Check displayed page shows the correct biblio record 5) Same at intranet Signed-off-by: Bernardo Gonzalez Kriegel Tested on clean UNIMARC install. Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5" Added two records, with result: +--+--+ | biblionumber | biblioitemnumber | +--+--+ |1 |5 | |2 |6 | +--+--+ Without patch, OPAC results shows for first record http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong! with patch result is correct Works, no errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Marcel de Rooy changed: What|Removed |Added Attachment #100177|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 100212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100212=edit Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Marcel de Rooy changed: What|Removed |Added Attachment #100181|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Marcel de Rooy changed: What|Removed |Added Attachment #99594|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 --- Comment #19 from Marcel de Rooy --- Created attachment 100211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100211=edit Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() This patch replaces the CGI "http" object method with its equivalent class method, which doesn't require object instantiation and thus skips global initialization and premature handling of the incoming HTTP request. Test plan: 0. Disable Plack if it is enabled 1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1 2. Clear Memcached 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 4. Note that form below "Upload progress" never appears and errors show in browser console 5. Apply the patch 6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 7. Note that form appears below "Upload progress" Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy See comment18 on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 --- Comment #18 from Marcel de Rooy --- > Test plan: > 0. Disable Plack if it is enabled I am having the impression that this bug has nothing to do with Plack. It is about creating another CGI object that "steals the upload". > 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl See debian/templates/apache-shared-intranet-plack.conf ProxyPass "/cgi-bin/koha/tools/stage-marc-import.pl" "!" This script does not even function under Plack, it is handled by Apache! But it is clear to me that preventing the CGI->new call and calling http as a class method resolves the situation. So passing QA on the second patch. Note that the first patch does the same thing, but lets keep that shuffling of env vars in the module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #17 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
Marcel de Rooy changed:
What|Removed |Added
Attachment #100204|0 |1
is obsolete||
--- Comment #5 from Marcel de Rooy ---
Created attachment 100210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100210=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly
Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
90 if ( $self->is_found ) {# We can't suspend found holds
So when TestBuilder generate a hold with found=W the test fail.
A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 --- Comment #13 from Marcel de Rooy --- RM: I prefer Owen's patch too, marked as PASSED_QA. If you agree, obsolete the other two. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Attachment #100208|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 --- Comment #12 from Marcel de Rooy --- Created attachment 100209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100209=edit Bug 24803: [PASSED_QA] Clicking "Log in to your account" throws fatal Javascript error This patch removes the "data-toggle" attribute from the login link in order to avoid a JavaScript error. Since we have a custom click handler to trigger the modal we don't need Bootstrap's "automatic" modal handling. Test plan: 1. Apply patch 2. Open F12 dev tools 3. Click "Log in to your account" on OPAC 4. Observe no Javascript errors in console Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24677] [19.11] Wrong year picked in serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677 Joy Nelson changed: What|Removed |Added Version(s)||19.11.04 released in|| Status|Passed QA |Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 --- Comment #14 from David Cook --- (In reply to Tomás Cohen Arazi from comment #13) > > On small shops, it's easier to just carry the config from the DB and use > stock configurations for the rest of the stack. Power to the users! Yeah it's interesting! Honestly, the more time goes by, the more carrying config from the DB makes sense. Much easier than trying to mess with a bunch of files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 --- Comment #13 from Tomás Cohen Arazi --- (In reply to David Cook from comment #12) > Interesting approach! I was surprised you didn't handle it at the reverse > proxy level, but interesting to allow libraries to configure their own > header. On small shops, it's easier to just carry the config from the DB and use stock configurations for the rest of the stack. Power to the users! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.com
Status|Needs Signoff |Failed QA
--- Comment #4 from Bernardo Gonzalez Kriegel ---
Hi, there is a problem in the code
-> 243 my $quoted_codes = '';
244 if ($letter_codes) {
245 my @codes = map { "'$_'" } split(',', $letter_codes);
-> 246 my $quoted_codes = join(',', @codes);
247 }
Two "my $quoted_codes", in lines 243 and 246.
$quoted_codes passed to execute will always be empty.
Remove the second 'my'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24642] Cache::Memcached::Fast::Safe must be marked as mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24642 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.04 released in|| Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #70 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 --- Comment #11 from David Cook --- Nice one, Owen. I think I prefer Owen's patch best, since it keeps a usable link. But will leave it up to QA/RM. (Also, as Jonathan noted on koha-devel, GoogleOpenIDConnect will be affected by the same issue, so whatever approach we choose here should be applied there as well.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 David Cook changed: What|Removed |Added Attachment #100191|0 |1 is obsolete|| --- Comment #10 from David Cook --- Created attachment 100208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100208=edit Bug 24803: [Alternate] Clicking "Log in to your account" throws fatal Javascript error This patch removes the "data-toggle" attribute from the login link in order to avoid a JavaScript error. Since we have a custom click handler to trigger the modal we don't need Bootstrap's "automatic" modal handling. Test plan: 1. Apply patch 2. Open F12 dev tools 3. Click "Log in to your account" on OPAC 4. Observe no Javascript errors in console Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24662] Remove global variables MSG_* from datatables.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug 24662 depends on bug 24661, which changed state. Bug 24661 Summary: Inclusion of locale-related javascript files is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Joy Nelson changed: What|Removed |Added Resolution|FIXED |--- Version(s)|20.05.00|20.05.00, 19.11.04 released in|| Status|RESOLVED|REOPENED --- Comment #22 from Joy Nelson --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24725] xgettext does not support (yet) ES template literals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24725 Bug 24725 depends on bug 21156, which changed state. Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24661] Inclusion of locale-related javascript files is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 Bug 24661 depends on bug 21156, which changed state. Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Bug 15522 depends on bug 21156, which changed state. Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.04 released in|| Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #18 from Joy Nelson --- Correction- Pushed to 19.11.x branch for 19.11.04 Thanks martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24734] LangInstaller is looking in wrong directory for js files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.04 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #12 from David Cook --- Interesting approach! I was surprised you didn't handle it at the reverse proxy level, but interesting to allow libraries to configure their own header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22622] Add Koha::Object method _new_from_hashref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22622 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Bernardo Gonzalez Kriegel --- Does not apply, seems easy to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #21 from Agustín Moyano ---
Created attachment 100206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100206=edit
Bug 20936: Add patron's hold history menu in OPAC
This patch adds patron's hold history in OPAC. Right now, it only shows records
from old_reserves table, but I'll wait till bug 20271 is pushed to show full
history (old and new holds)
To test:
1. apply this patch
2. Find a patron, place several holds and cancel or fulfill them
3. Go to patron's opac
CHECK => There is no 'your holds history' option in menu
4. In admin preferences enable OPACHoldsHistory
5. Go back to patron's opac
SUCCESS => There is a 'your holds history' menu option
=> Holds history displays all holds canceled or fulfilled
6. Filter, order and change page
SUCCESS => All controls work as expected
7. Sign off.
Table content is fetched from the api. If you see data, and you can order and
filter then please sign off bug 24561.
Date columns use $date function to transform dates strings from api (for
example '2020-02-20') to 'dateformat' prefernce format ('02/20/20202'). If you
change dateformat prefernce and see the changes reflected in date columns,
please sign off bug 24455.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #22 from Agustín Moyano --- Created attachment 100207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100207=edit Bug 20936: Add test Add test to /api/v1/public/patrons/:patron_id/holds endpoint To test: 1. prove t/db_dependent/api/v1/patrons_holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Attachment #100116|0 |1 is obsolete|| Attachment #100117|0 |1 is obsolete|| --- Comment #20 from Agustín Moyano --- Created attachment 100205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100205=edit Bug 20936: Add OPACHoldsHistory syspref Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22182] Advanced editor - Rancor - Create item record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22182 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21970] Scan and Go functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21970 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12731] Mulitiple setspecs that use the same MARC tag only work for the first setspec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12731 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 24531 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first field with a given tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531 Tomás Cohen Arazi changed: What|Removed |Added CC||sow...@andrews.edu --- Comment #19 from Tomás Cohen Arazi --- *** Bug 12731 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19676] Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp for apache2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676
John Sterbenz changed:
What|Removed |Added
CC||jster...@umich.edu
--- Comment #4 from John Sterbenz ---
I second this big thanks.
An OS upgrade to ubuntu 18.04 (koha 18.11) started a problem in which staging
MARC records for load would upload the file but then cause failure after
options were set and "Stage for import" was clicked ("Failed to submit form:
error"). Bug 15032 seemed like the right place to start--it wasn't. Someone
graciously pointed me here and this appears to be the fix I needed (with
Philippe's directory modification).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 --- Comment #1 from Hannah Olsen --- At my library we use Course Reserves regularly to manage our displays so that we can change the shelving location and have it change back automatically. We found the bug while trying to figure out why things that had been on display weren't moving back to their original shelving locations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--- Comment #3 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #2)
> I will double check tomorrow but I think the following one is not correct:
>
> @@ -86,7 +84,6 @@ sub last_cashup {
> { order_by => { '-desc' => [ 'timestamp', 'id' ] }, rows => 1 }
> )->single;
>
> -return unless $rs;
> return Koha::Cash::Register::Action->_new_from_dbic($rs);
> }
You are right. We return undef on the singular case
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- For me, the tests passed both before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
David Nind changed:
What|Removed |Added
Attachment #100201|0 |1
is obsolete||
--- Comment #3 from David Nind ---
Created attachment 100204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100204=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly
Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
90 if ( $self->is_found ) {# We can't suspend found holds
So when TestBuilder generate a hold with found=W the test fail.
A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #14 from David Nind --- Sorry Arthur, patch no longer applies! Applying: Bug 23531: fix ILSDI non-implemented but documented parameters Using index info to reconstruct a base tree... M C4/ILSDI/Services.pm M koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt M opac/ilsdi.pl Falling back to patching base and 3-way merge... Auto-merging opac/ilsdi.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23531: fix ILSDI non-implemented but documented parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point of sale system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a new release notes||'branch details' page to ||the POS system which ||displays a summary of the ||cash register transactions ||for a branch since each ||register was last cashed ||up. It also allows for ||cashing up individual ||registers or cashing up all ||registers at a given branch ||in one transaction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #19 from Agustín Moyano --- (In reply to Tomás Cohen Arazi from comment #17) > A few remarks: > - Some POD are wrong (koha_object_class for effective_itemtype?) > - You copied and pasted from other API controllers, but kept deprecated > things like _to_model that are not even used > - There's some debugging leftovers > - There are no tests for the controller > > Please solve them and re-submit I was too eager to get this going.. I'll attend them ASAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24816] Test suite execution time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816 --- Comment #1 from Tomás Cohen Arazi --- It is for sure because of our dependencies madness (i.e. things like OAuth don't currently work unless you cpan CryptX) and the same must be happening to other libs that make tests skip. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #18 from Agustín Moyano --- (In reply to Jonathan Druart from comment #16) > And tests, pretty please. How can I refuse if you ask so nicely XD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #2 from Jonathan Druart
---
I will double check tomorrow but I think the following one is not correct:
@@ -86,7 +84,6 @@ sub last_cashup {
{ order_by => { '-desc' => [ 'timestamp', 'id' ] }, rows => 1 }
)->single;
-return unless $rs;
return Koha::Cash::Register::Action->_new_from_dbic($rs);
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24816] Test suite execution time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24816] New: Test suite execution time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24816 Bug ID: 24816 Summary: Test suite execution time Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Quick note, from Jenkins: D8 - Took 38 min on Docker_1 D9 - Took 53 min on Docker_1 That needs to be investigated, and recreated in a proper benchmarking env. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize changed: What|Removed |Added Blocks||24815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 [Bug 24815] Koha::Cash::Register relations should return sets not undef -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Martin Renvoize changed: What|Removed |Added Depends on||23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 --- Comment #1 from Martin Renvoize --- Created attachment 100203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100203=edit Bug 24815: Correct return values of Koha::Cash::Register relations This patch correct all cases of return undef to instead return an empty resultset. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Blocks||24815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 [Bug 24815] Koha::Cash::Register relations should return sets not undef -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Martin Renvoize changed: What|Removed |Added Depends on||23321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] New: Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Bug ID: 24815 Summary: Koha::Cash::Register relations should return sets not undef Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The cash register class contains a bad pattern of returning 'undef' for relations instead of an empty resultset. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 didier changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 --- Comment #1 from didier --- Created attachment 100202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100202=edit Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] New: HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Bug ID: 24814 Summary: HTML forms set a minimal width for dropdown combo with empty set. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gauthe...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hi, If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. It's a bandaid, a proper solution would be to compute container width on actuel message size. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 Hannah Olsen changed: What|Removed |Added CC||hol...@duncanville.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
Jonathan Druart changed:
What|Removed |Added
Attachment #100200|0 |1
is obsolete||
--- Comment #2 from Jonathan Druart
---
Created attachment 100201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100201=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly
Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
90 if ( $self->is_found ) {# We can't suspend found holds
So when TestBuilder generate a hold with found=W the test fail.
A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
--- Comment #1 from Jonathan Druart
---
Created attachment 100200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100200=edit
Bug 24813: Prevent api/v1/holds.t to fail randomly
Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
90 if ( $self->is_found ) {# We can't suspend found holds
So when TestBuilder generate a hold with found=W the test fail.
A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] New: api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Bug ID: 24813 Summary: api/v1/holds.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org t/db_dependent/api/v1/holds.t .. 3/8 # Failed test 'Hold suspension created' # at t/db_dependent/api/v1/holds.t line 400. # got: '400' # expected: '201' # Failed test 'Hold is suspended' # at t/db_dependent/api/v1/holds.t line 405. # Failed test 'Hold is suspended' # at t/db_dependent/api/v1/holds.t line 418. # Failed test 'Hold suspension has correct end date' # at t/db_dependent/api/v1/holds.t line 419. # got: undef # expected: '2020-03-05' # Failed test 'Hold suspension created' # at t/db_dependent/api/v1/holds.t line 435. # got: '400' # expected: '201' # Failed test 'exact match for JSON Pointer "/end_date"' # at t/db_dependent/api/v1/holds.t line 435. # got: undef # expected: '2020-03-10' # Failed test 'The Location header is set' # at t/db_dependent/api/v1/holds.t line 435. # got: undef # expected: '/api/v1/holds/287/suspension' # Looks like you failed 7 tests of 24. t/db_dependent/api/v1/holds.t .. 7/8 # Failed test 'suspend and resume tests' # at t/db_dependent/api/v1/holds.t line 464. t/db_dependent/api/v1/holds.t .. 8/8 # Looks like you failed 1 test of 8. t/db_dependent/api/v1/holds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22206] Add routes to enable suspension or resumption of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Jonathan Druart changed: What|Removed |Added Blocks||24813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 [Bug 24813] api/v1/holds.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||22206 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 [Bug 22206] Add routes to enable suspension or resumption of holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #6 from Devinim --- Created attachment 100199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100199=edit Bug 13547: Item field 3 (Materials specified) would be useful to see on OPAC Test plan: 1- View a record with Materials specified (field 3) data in the opac 2- Apply patch 3- Log in to staff client 4- Home->Administration->Column Settings->OPAC->holdingst 5- Set item_materials visibility 6- Refresh OPAC page 7- Confirm that the materials specified column has been added after the Call number column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Michal Denar changed: What|Removed |Added Attachment #100197|0 |1 is obsolete|| --- Comment #5 from Michal Denar --- Created attachment 100198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100198=edit Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Nice work. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #31 from Andrew Isherwood --- OK, if we can assume the time should be 23:59, then I agree :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608
--- Comment #30 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #29)
> (In reply to Jonathan Druart from comment #26)
>
> Hi Jonathan
>
> > When I edit I pick 23:59 but 22:59 is saved. Then edit again, save without
> > modifying anything, 21:59 is saved, and so on.
>
> I can't replicate this. So, you're selecting a date, default time is 23:59,
> but when you save, 22:59 is saved? Is that the value sent by the API call,
> or the value that's returned by the API? As I say, I can't replicate this,
> it works fine for me.
This is sent when I pick 23:59
{"date_due":"2020-03-18T22:59:00.000Z"}
My host and the server do not have the same timezone, that's why I see
something different.
What your patch does (and so the JS lib from bug 24455 I guess) is the expected
behavior, in an ideal world.
But it cannot be the only place in Koha where it works like that.
If such behavior is really needed, we need to redesign how we store and display
date/datetime.
> > If I edit the date and remove the time page, save, it's loading endlessly.
> > Which means 1. errors are not handled correctly, and 2. date only formatted
> > dates are not taken into account.
>
> The "loading endlessly" is actually the JS falling over because the call to
> DateTime_from_syspref is failing because DateTime_from_syspref doesn't check
> what it's got before trying to split it. So it splits the received string by
> " ", then tries to split the second part of that by ":" which of course
> fails because the second part is null.
>
> Having considered this for a while, I'm not clear of the best way forward,
> it potentially opens a can of worms. We could say that DateTime_from_syspref
> should validate what it's got before working with it, and if it fails
> validation, it should error. We have date validation with accompanying
> errors in the form of calendar.inc's validate_date, so it would be
> reasonable to say we need similar time validation. However, if we're doing
> that, should we not be adding that to the upcoming moment.js work in Bug
> 24455 since that uses moment.js for date formatting, it should probably be
> leveraging moment.js' date & time validation. But if we do that with the
> time component, should we not also switch the date validation that's
> currently in calendar.inc to using moment.js.
>
> Maybe I'm overcomplicating, but that was my thought process. I don't want to
> just put a hack in, but at the same time, doing it "properly" could be a
> pain in the ass.
>
> Any thoughts?
Looks like a quick change to DateTime_from_syspref could do the trick.
If the time part does not exist then add it with "23:59".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 --- Comment #4 from Martin Renvoize --- Created attachment 100197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100197=edit Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 --- Comment #3 from Martin Renvoize --- Aha.. I see.. the UI piece for actually setting the permission got lost in a rebase! Patch coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24812] Add permission for 'discount' process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 --- Comment #2 from Martin Renvoize --- Did you test this Michal? The original patchset was meant to add such a permission.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point of sale system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 --- Comment #10 from Martin Renvoize --- Created attachment 100196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100196=edit Bug 24492: (RM follow-up) Redirect to correct page after cashup Cashup of a single register was resulting in a redirect to the register details page. It should return to the branch details page instead. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 --- Comment #8 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #7) > (In reply to Bernardo Gonzalez Kriegel from comment #6) > > > Summary: > > 1) Can be rewritten to single lines if needed > > Nope, that makes sense! Ok > > > 2a) I think is not a problem > > If I am not wrong, the ^W appeared *with* the patches. You mean ^M? Look for example the RENEWAL letter in your dump without patch. It's a little notice with at least 4 ^M In sample_notices.sql you can see that the first letter, ODUE, has '\n' for newlines; the second one, ACQCLAIM, has '\r\n' for the same. I need to use only one, and '\r\n' works for win/linux > > > 2b) Followup uploaded to Bug 24593 > > Thanks! > > > 2d) Waiting your opinion > > How big would it be to allow NULL for translated value? If it can be a quick > fix I guess it's better to have it. Not a big problem :) Followup added to Bug 24262 to skip null values and followup added to Bug 24583 to restore nulls in labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24583] Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 100195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100195=edit Bug 24583: (followup) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24262] Translate installer data in YAML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 100194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100194=edit Bug 24262: (followup) admit null values on labels This patch adds handling of null values on translatable labels. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Martin Renvoize changed: What|Removed |Added Attachment #100134|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
