[Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Hi Lucas. I have signed this off as this fixes the issue on the circulation page, however the same thing occurs on these pages: - Tools - Tools > Patron card creator - Reports - Reports > Items with no checkouts - Circulation > Set library - Circulation > Transfer - Circulation > Overdues with fines Not sure whether these should be fixed in this bug, or a new bug(s) created. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825
David Nind changed:
What|Removed |Added
Attachment #100302|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 100307
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100307=edit
Bug 24825: Add [% SET footerjs = 1 %] to circulation-home.tt
TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #23 from Arthur Suzuki --- \o/ Many thanks for your help and fixing typo :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 David Nind changed: What|Removed |Added Attachment #100043|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 100306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100306=edit Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 David Nind changed: What|Removed |Added Attachment #100269|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 100305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100305=edit Bug 24754: Set userenv for ilsdi requests Currently ILSDI scripts do not have a userenv set. This affects both action_logs and statistics. For action_logs we either get no user or, if there is an active session, we use that one. This can have unintended consequences and we should explicitly set the env so that system user (0) is recorded For statistics we need to specify a branch to record for actions like renewals. With bug 24759 we add an items method for this. We should take advantage of this method and use the 'opac' interface as the ilsdi scripts live there. To test: 1 - Enable ILS-DI in systempreferences 2 - Checkout an item to a patron 3 - Enable Renewal logs (RenewalLog system preference) 4 - Ensure you will be able to renew the item several times 5 - Open an incognito/private browser 6 - Renew item via ilsdi: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan_id=5_id=1128 7 - Check action logs, interface may be random, user should be 0, if not make sure the user in step 9 is a different one 8 - In private browser open a new tab 9 - Sign in to staff client 10 - Return to other tab 11 - Refresh page to repeat renewal 12 - Check action_logs 13 - The second renewal indicates it was renewed via intranet by logged in staff member 14 - Apply patch 15 - restart_all 16 - Ensure staff client still signed in 17 - Repeate renewal again 18 - Check logs, renewal now indicates opac again (as it should), user is 0 even if logged in on other tab Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 David Nind changed: What|Removed |Added Attachment #100215|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 100303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100303=edit Bug 24817: Add sleep between db create actions We need to allow some time to pass between calls that add cash register lines to accountlines or cash_register_actions. We use database level triggers to maintain the timestamp fields, so cannot use Time::Fake, and the methods we are testing assume that, as human interactions, there will be at least a second between the last 'sale' on a cash register and the 'cashup' of that same cash register. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 David Nind changed: What|Removed |Added Attachment #100275|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 100304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100304=edit Bug 24817: Horrible cludge date setting to remove sleep Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825
--- Comment #1 from Lucas Gass ---
Created attachment 100302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100302=edit
Bug 24825: Add [% SET footerjs = 1 %] to circulation-home.tt
TEST PLAN:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
-apply patch
-load the circulation page, the logo is hidden
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24825] circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24825] New: circulation-home.tt is missing [% SET footerjs = 1 %]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825
Bug ID: 24825
Summary: circulation-home.tt is missing [% SET footerjs = 1 %]
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
circulation-home.tt does not have [% SET footerjs = 1 %], therefore
javascript/jQuery are impossible on this page.
TO RECERATE:
-add this jQuery to IntranetUserJS: $('#logo').hide();
-load the circulation page, it does not hide the logo.
-go to any other page on the staff client, the logo is hidden.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #58 from David Nind --- Thanks Gabriel, the patch now applies! I've changed the status to Failed QA as: - The test plan indicates it should be available for carts and lists: carts work, for lists there is no option to download (only shows RIS, BibTeX, ISBD, MARC as options). - The tests don't pass for me. root@ffb0d824040d:koha(bz17385)$ prove t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 28. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 77. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 85. Global symbol "$builder" requires explicit package name (did you forget to declare "my $builder"?) at t/db_dependent/XSLT.t line 95. Execution of t/db_dependent/XSLT.t aborted due to compilation errors. # Looks like your test exited with 255 before it could output anything. t/db_dependent/XSLT.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.87 cusr 0.09 csys = 0.99 CPU) Result: FAIL root@ffb0d824040d:koha(bz17385)$ prove t/XSLT.t t/XSLT.t .. 2/12 # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report --- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.63 cusr 0.14 csys = 3.79 CPU) Result: FAIL Notes from testing: - Need to enable 'Custom' option for OpacExportOptions system preference. - Naming: . For cart shows as: XSL - Simple Export . System preference OpacExportOptions shows as: Custom . Staff interface save shows as: Simple Export (from the sample .xsl file) . OPAC save record shows as: Simple Export (from the sample .xsl file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #9 from Andreas Roussos --- Created attachment 100301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100301=edit Bug 23925: (follow-up) Add missing CSS classes The highlighted input field for an incorrect ISBN was displayed incorrectly -- this patch fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr --- Comment #8 from Andreas Roussos --- I've tested the plugin on both a MARC21 and a UNIMARC installation and it works fine, except for a minor hiccup in the display of the highlighted input field when the ISBN is incorrect (see attached screenshots). This is due to a couple of missing CSS classes for the HTML element. I will provide a follow-up that addresses this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #7 from Andreas Roussos --- Created attachment 100300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100300=edit correct display of input field when the ISBN is wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #6 from Andreas Roussos --- Created attachment 100299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100299=edit incorrect display of input field when the ISBN is wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 David Nind changed: What|Removed |Added Attachment #100270|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 100298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100298=edit Bug 22771: Fix mistakes in list of nonfiling character fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 David Nind changed: What|Removed |Added Attachment #99696|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 100297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100297=edit Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added Attachment #100267|0 |1 is obsolete|| --- Comment #5 from Andreas Roussos --- Created attachment 100296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100296=edit Bug 23925: Value builder plugin to check ISBN validity This patch adds a new value builder plugin ISBN.pl, which should be attached to field 020a. The plugin will perform a simple checksum checking when trying to save the record, and inform the user that the ISBN is illegal if the checksum doesn't match. The ISBN plugin is a test case for additional value builder plugin functionality that lets the plugins check field values and prevent saving if so desired. The example plugin has been updated with information on how to write a pre-save check function. To test: 1) Add the ISBN.pl plugin to the field 020a in MARC subfield structure admin. 2) Go to cataloguing and try to save the record, no complaints about the ISBN (Because the plugin will not complain about empty field) 3) Enter something in the 020a field and try to save, you should receive a complaint about illegal ISBN. 4) Enter a valid ISBN (eg. 978-951-1-27641-8) and try to save, there should be no complaints about the ISBN. Signed-off-by: Pasi Kallinen Signed-off-by: Devinim Signed-off-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24713] JavaScript error on staff client catalog search results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind changed: What|Removed |Added Text to go in the||This patch modifies the release notes||output of template toolkit ||variables so that values in ||the in-page JavaScript are ||quoted. This avoids ||JavaScript errors when the ||template variable is empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #22 from David Nind --- In the test plan "the ISL-DI system preference" should be "the ILS-DI system preference"! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #21 from David Nind --- (In reply to Arthur Suzuki from comment #18) > Yup, had some issues with my remotes configuration, just got to learn that > one shall not use gitlab anymore. > Patch should apply now. > Arthur Thanks Arthur for fixing _ I'm not sure I would have been much help working out what was wrong 8-) I also updated the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Attachment #100222|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 100295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100295=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided Signed-off-by: Arthur Suzuki Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Attachment #100221|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 100294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100294=edit Bug 23531: Fix ILS-DI non-implemented but documented parameters Koha's ILS-DI service does not implement the "needed_before_date" and "pickup_expiry_date" parameters for holds, although they are documented. This patch changes the parameter names and implements them: - needed_before_date => start_date - pickup_expiry_date => expiry_date Test plan: 1) Enable the ISL-DI system preference. 2) Submit a hold request using ILS-DI with "needed_before_date" and "pickp_expiry_date" parameters, for example (change the bib_id, item_id, and dates as appropriate): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=19_id=126_id=264_before_date=2020-03-12_expiry_date=2020-03-31_location=CPL 3) Check that the dates in the request are NOT shown for the hold (go to the item record and then the holds section): - Date: will show the current date, rather than the needed_before_date entered - Expiration: will be empty, rather than the pickup_expiry_date entered 4) Delete the hold. 5) Apply the patch. 6) Resubmit the hold request in step 2 using "start_date" and "expiry_date" parameters, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=19_id=126_id=264_date=2020-03-12_date=2020-03-31_location=CPL 7) Check that dates shown for the hold are now correct: - Date: will show the start_date entered - Expiration: will show the expiry_date entered 8) Check that the tests pass (prove t/db_dependent/ILSDI_Services.t) 9) Sign off! Signed-off-by: Christophe Croullebois Signed-off-by: Arthur Suzuki Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Attachment #97105|0 |1 is obsolete|| --- Comment #57 from Gabriel DeCarufel --- Created attachment 100293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100293=edit Bug 17385: QA Critics Fixed and added Missing Filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Attachment #97103|0 |1 is obsolete|| --- Comment #55 from Gabriel DeCarufel --- Created attachment 100291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100291=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Attachment #97104|0 |1 is obsolete|| --- Comment #56 from Gabriel DeCarufel --- Created attachment 100292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100292=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Attachment #97101|0 |1 is obsolete|| --- Comment #53 from Gabriel DeCarufel --- Created attachment 100289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100289=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley Signed-off-by: Cori Lynn Arnold https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Gabriel DeCarufel changed: What|Removed |Added Attachment #97102|0 |1 is obsolete|| --- Comment #54 from Gabriel DeCarufel --- Created attachment 100290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100290=edit Bug 17385: Add tests for CustomXSLTExportList + Added tests for CustomXSLTExportList to C4::XSLT + Added an eval block in CustomXSLTExportList to handle invalid XML. * Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent + Added "Custom" option to OPACExportOptions preference. Tested with invalid XML (not originally on purpose, but...) and then added a new field to add to the simple export. Walked through the testing steps. Question: should this also apply to the cataloging page as an export option? It doesn't now. Signed-off-by: Cori Lynn Arnold Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23562] Only one authorities search in header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Owen Leonard changed: What|Removed |Added Attachment #92650|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #16 from Owen Leonard --- Created attachment 100287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100287=edit Bug 24157: New permission - delete_baskets Add a new permission to delete acquisition baskets Test plan: - Remove the new permission "delete_basket" for a given patron, use it to log in into Koha - Create basket, try to delete it => There is no way to delete it - Add the permission => Now you can delete the basket Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #17 from Owen Leonard --- Created attachment 100288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100288=edit Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice This follow-up makes minor changes to the template so that the checkbox for reopening or closing an invoice are not displayed when the user doens't have the correct permissions. To test, apply the patch and try the process of viewing or editing an invoice as a user with these various permissions: - edit_invoices ON - edit_invoices OFF - reopen_closed_invoices ON - reopen_closed_invoices OFF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #15 from Owen Leonard --- Created attachment 100286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100286=edit Bug 24157: New permission - delete_invoices Add a new permission to delete invoices Test plan: - Remove the new permission "delete_invoices" for a given patron, use it to log in into Koha - Create an invoice, try to delete it => There is no way to delete it - Add the permission => Now you can delete the invoice Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #13 from Owen Leonard --- Created attachment 100284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100284=edit Bug 24157: New permission - edit_invoices Add a new permission to edit invoices Test plan: - Remove the new permission "edit_invoices" for a given patron, use it to log in into Koha - Create an invoice, edit it (click "detail") => You can see the detail of the invoice, but cannot edit it. It's a read-only view. - Add the permission => The form is back and you can modify the invoices and save the changes. Also, you are able to create adjustments. Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #14 from Owen Leonard --- Created attachment 100285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100285=edit Bug 24157: Add new method Acq::Invoice::Adjustement->fund Moving to its own commit in case we want to cherry-pick or move it to its own bug report. Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Owen Leonard changed: What|Removed |Added Attachment #98651|0 |1 is obsolete|| Attachment #98652|0 |1 is obsolete|| Attachment #98653|0 |1 is obsolete|| Attachment #98654|0 |1 is obsolete|| Attachment #98655|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 100283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100283=edit Bug 24157: New permission - reopen_closed_invoices New permission to reopen a closed invoice. Test plan: - Remove the new permission "reopen_closed_invoices" for a given patron, use it to log in into Koha - Create an invoice, close it => You are not able to reopen the invoice - Add the permission => You are able to reopen the invoice Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24824] updated_on should be a read-only field via the api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #32 from Agustín Moyano --- seems timezone is not saved in date_due column, because it's a datetime rather than timestamp https://stackoverflow.com/questions/19843203/how-to-store-a-datetime-in-mysql-with-timezone-info Maybe we can alter that column to timestamp, so timezone is saved, or I can add a flag to the JS function in 24455 to use timezone or not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 Martin Renvoize changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard changed: What|Removed |Added Attachment #100202|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 100282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100282=edit Bug 24814: HTML forms set a minimal width for dropdown combo with empty set. If there's no item, dropdown message "No matches found" is hard to read. Affect: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt To test: - Select a catalogue notice in Koha intranet. - Open add item form. - Choose a dropdown combo with an empty set, 'j - Shelving control number' is a good candidate. - Apply the patch. - Re select the compo in open add item form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24814] HTML forms set a minimal width for dropdown combo with empty set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24814 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when entering a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Owen Leonard changed: What|Removed |Added Attachment #100223|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 100281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100281=edit Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24665] Add ability to Run Cash Register report with New Cash register feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 --- Comment #1 from Martin Renvoize --- What did you have in mind Kelly... I must admit, I've never really used that report. Having just taken a look at it, are you simply suggesting adding the ability to limit the results by a particular cash register via a select menu? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when entering a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What|Removed |Added Blocks||24665 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 [Bug 24665] Add ability to Run Cash Register report with New Cash register feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What|Removed |Added Depends on||24665 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 [Bug 24665] Add ability to Run Cash Register report with New Cash register feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24665] Add ability to Run Cash Register report with New Cash register feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Martin Renvoize changed: What|Removed |Added Blocks||13985 Depends on||23321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files in .editorconfig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Owen Leonard changed: What|Removed |Added Attachment #99860|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 100280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100280=edit Bug 24774: Set JSON indentation of 2 spaces in .editorconfig To test: 1. Start an editor that supports .editorconfig 2. Open or create a JSON file 3. Observe identation is set to 2 spaces by default Sponsored-by: Hypernova Oy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24774] Specify 2 space indentation for JSON files in .editorconfig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24774 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|String patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Owen Leonard changed: What|Removed |Added Attachment #100199|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 100279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100279=edit Bug 13547: Add item field 3 (Materials specified) to the OPAC holdings table Test plan: 1- View a record with Materials specified (field 3) data in the opac 2- Apply patch 3- Log in to staff client 4- Home->Administration->Column Settings->OPAC->holdingst 5- Set item_materials visibility 6- Refresh OPAC page 7- Confirm that the materials specified column has been added after the Call number column. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461 Martin Renvoize changed: What|Removed |Added Attachment #97623|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 100278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100278=edit Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup class. To test: 1. Compare the mapping with the one on the RFC => SUCCESS: They match 2. Sigh off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Looking good to me.. SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in hold confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard changed: What|Removed |Added Attachment #92032|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 100277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100277=edit Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in hold confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24777] Use patron.is_debarred instead of patron.debarred in return.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24777] Use patron.is_debarred instead of patron.debarred in return.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Devinim changed: What|Removed |Added Attachment #99926|0 |1 is obsolete|| --- Comment #2 from Devinim --- Created attachment 100276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100276=edit Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24788] Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24788] Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #99191|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 --- Comment #5 from Martin Renvoize --- That second patch does the trick.. but in my opinion feels much worse than using a sleep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 --- Comment #4 from Martin Renvoize --- Created attachment 100275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100275=edit Bug 24817: Horrible cludge date setting to remove sleep -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim changed: What|Removed |Added Attachment #100273|0 |1 is obsolete|| --- Comment #4 from Devinim --- Created attachment 100274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100274=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr --- Comment #3 from Devinim --- We have changed some conflicts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Add sleep calls to Koha::Cash::Register test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 --- Comment #3 from Martin Renvoize --- (In reply to Jonathan Druart from comment #2) > Nope, using sleep in tests is wrong. > Why do not you force the timestamp (NOW-1h for instance) for the account > lines? Because I don't want to change add_cashup to accept a timestamp to be passed just to pass the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim changed: What|Removed |Added Attachment #86906|0 |1 is obsolete|| --- Comment #2 from Devinim --- Created attachment 100273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100273=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 --- Comment #5 from Nick Clemens --- Rebased, but this needs test coverage - the pod is explicit that we set the date, so maybe we have moved on from here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added Component|Circulation |Command-line Utilities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added CC||gmcha...@gmail.com, ||kyle.m.h...@gmail.com Component|Command-line Utilities |Circulation Assignee|k...@bywatersolutions.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added Attachment #59560|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 100272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100272=edit Bug 17996 - longoverdue.pl should not set 'datereturned' when --mark-returned option is used When longoverdue.pl returns items, it sets old_issues.returndate to the current date. This means that when staff look at the borrowers' circulation history, they see a returndate displayed, which is confusing. We don't lose information by not setting old_issues.returndate, because items.itemlost_on will contain the date that the item was lost. Test Plan: 1) Apply this patch 2) Mark an item lost using longoverdue.pl with --mark-returned 3) Note the item's old_issues line does not have a returndate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24824] updated_on should be a read-only field via the api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24824] New: updated_on should be a read-only field via the api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24824 Bug ID: 24824 Summary: updated_on should be a read-only field via the api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When updating a patron via the api we should write protect the updated_on field and ensure it is updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #22 from Nick Clemens ---
I tested the following, let me know if i missed elsewhere:
editing patron satff
editing patron opac
importing patron
patron creation/update via ldap
Branch limitations do not save
Cannot load patron if attribute value not in authorized values (OK, but should
have a way to identify)
Opac update of attributes fails, blank value passed to update request
Patron import with 'replace only included attributes' fails
Can't use string ("Koha::Patron::Attribute") as a HASH ref while "strict refs"
in use at /kohadevbox/koha/Koha/Object.pm line 625
Attributes in ILSDI shows some extra info:
borrowernumber, authorised_value_category - is noisier than without patch
Test failures:
Test Summary Report
---
t/00-testcritic.t (Wstat: 256 Tests: 1020 Failed: 1)
Failed test: 732
Non-zero exit status: 1
t/00-valid-xml.t (Wstat: 512 Tests: 135 Failed: 2)
Failed tests: 1-2
Non-zero exit status: 2
t/Logger.t(Wstat: 256 Tests: 1 Failed: 1)
Failed test: 1
Non-zero exit status: 1
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813
--- Comment #11 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #10)
> It's not related to 500 but 400. There is a
> Koha::Exceptions::Hold::CannotSuspendFound that is raised and we need to see
> it somewhere.
My gut feeling is we should somehow overload Test::Mojo so it does ->or( sub {
diag $t->tx->res->to_string } ), or just add it everywhere and enforce it as a
coding guideline.
This would give us more light on handled exceptions, but we still need
something for unhandled exceptions, in the lines of bug 18206 (probably making
use of a helper instead, but you get the point).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18206] REST API: Default exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- I'd love to see this one start moving again.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining the inbound email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 --- Comment #13 from Martin Renvoize --- how about '->inbound_email_address' ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24455] Date formatting from JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #38 from Jonathan Druart --- WARNING: This must NOT be pushed before I have a better clarity of the needs. This does not need to be pushed before one of the 2 dependent bugs anyway. See for instance bug 24608 comment 26. (This bug does not need to be marked as blocked, the dep is the other way around) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #23 from Jonathan Druart --- In case someone else comes for QA before me, see bug 24608 comment 26 and see if the problem exists in this feature as well. Agustin, a couple of things I spot: * authnotrequired needs to be removed (there is a new check in the QA script) * Schema files should be in a separate patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #83 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #82 from Martin Renvoize --- Created attachment 100271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100271=edit Bug 23051: (RM follow-up) Fix rebase error Looks like at some point during reworking/rebasing the signature for Koha::Account::Line->apply changed and was then reverted but one case of the reversion got lost. The error was highlighted in the patrons_accounts credit api tests. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > Ok but then it will explode in some cases Nick. For instance the logged in > user does not exist. Scratch that, it won't reach that code for "opac" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
