[Koha-bugs] [Bug 24922] New: 000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24922 Bug ID: 24922 Summary: 000 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: pterodactylxpl...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101340=edit Hacked By Pterodactyl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24921] New: 000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24921 Bug ID: 24921 Summary: 000 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: pterodactylxpl...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101339=edit Hacked By Pterodactyl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #45 from Tomás Cohen Arazi --- I've got an interesting DB with lots of real-life acq data, and: - There are some use cases that I didn't consider - Some combinations of the data produce error 500. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel --- Hi Marcel, current ACQ framework does not have tag 942. Do you think we need to add it and it's subfields? Patches applies cleanly, test pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100835|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 101338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101338=edit Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass Signed-off-by: Bernardo Gonzalez Kriegel Prefs gone. Fixed missing 'r' in atomic update message. Test pass, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Bernardo Gonzalez Kriegel changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |wizzy...@gmail.com |ity.org | CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96808|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 101337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101337=edit Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. Signed-off-by: Bernardo Gonzalez Kriegel Works ok. Fixed tab char in line 98, no more errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101208|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 101336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101336=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24541] Database cleanups, purge messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Please rebase -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Bernardo Gonzalez Kriegel --- Sorry, does not apply. Perhaps you can try removing fr-CA install dir as in Bug 24897 (for es-ES), unless you have sample data specific for fr-CA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24920] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920 Owen Leonard changed: What|Removed |Added Attachment #101322|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24920] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24920 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hacked by darksec |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24919] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919 Owen Leonard changed: What|Removed |Added Attachment #101321|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24919] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24919 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hacked By LinuXploit|SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Michal Denar changed: What|Removed |Added Assignee|m...@jkozlovsky.cz |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||bgkrie...@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- Hi, this patch does not apply. Some comments: * If want to add new auth types then we need to add some definitions in authorities_normal_marc21.yml, I can help with that * For the new auth types we need new codes, you are using the same as existing ones, perhaps we can use 147 NAME_EVENT Named event 162 MED_PERFRM Medium of Performance Term 180 GENRL_SUBD General Subdivision 181 GEOGR_SUBD Geographic Subdivision 182 CHRON_SUBD Chronological Subdivision 185 FORM_SUBD Form Subdivision -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100558|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 101335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101335=edit Bug 21708: Sort MARC fields in TransformHtmlToMarc Instead of pushing 999 in the front :) Test plan: Do not yet apply this patch. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field (MARC21 999) follows leader. Apply this patch. Restart Plack. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field is in right position. Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, correct tag order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100557|0 |1 is obsolete|| --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 101334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101334=edit Bug 21708: Add a few tests in TransformHtmlToMarc.t Test plan: Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change patch. Verify that the test fails on the order of fields. Go to test plan of the second patch. Signed-off-by: Bernardo Gonzalez Kriegel Test fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21708] Editing a record moves field 999 to first in the marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21708 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24883] Command line utility to load yaml files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101332|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 101333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101333=edit Bug 24883: Add POD entry and remove unused variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24883] Command line utility to load yaml files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24883 --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 101332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101332=edit Bug 24883: Add POD entry and remove unused variable https://bugs.koha-community.org/show_bug.cgi?id=24833 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24833] Field ending punctuation needs to consider abrreviations and exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Attachment #101331|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Comment on attachment 101331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101331 Bug 24883: Add POD entry and remove unused variable Sorry, wrong bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24724] Add plugin hook for new SQL report export formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24724 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin SOMERS --- I propose you to depend on Bug 20415 that removes UseKohaPlugins system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24833] Field ending punctuation needs to consider abrreviations and exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 101331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101331=edit Bug 24883: Add POD entry and remove unused variable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Looks good, nice job -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Fridolin SOMERS changed: What|Removed |Added Attachment #83776|0 |1 is obsolete|| --- Comment #3 from Fridolin SOMERS --- Created attachment 101329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101329=edit Bug 22098: Update stocknumberAV cataloguing plugin to use objects This patch: - changes SQL to Koha::AuthorisedValues - remove type param from script tag - fixes the plugin description 0) Do not apply the patch 1) Set the plugin 1.1) Update a biblio framework and link plugin stocknumberAV.pl to some item subfield 1.2) Add authorised values category called "INVENTORY" 1.3) Add some authorised values: authorised value is prefix and description is a current stock/inventory number 2) Add an item and try to use this plugin to ensure you set it correctly 2.1) Use a defined prefix to see if the number is correct 2.2) Ensure the number is correctly incremented in authorised values 2.3) Use not defined prefix to see the error message 2.4) Insert a not prefix string (eg number) to see it is not changed 3) Apply the patch 4) Repeat 2) and see it is working the same 5) Look into patch and confirm the description does make sense and is rigth according to what you see in UI 6) Sign off :D Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Fridolin SOMERS changed: What|Removed |Added Attachment #91421|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 101330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101330=edit Bug 22098: (follow-up) fix grammar/formating Perldoc - nubers => numbers - some vertical spacing - !}fmt -w65 - "contains of letters" => "containing letters" TEST PLAN - perldoc cataloguing/value_builder/stocknumberAV.pl apply patch perldoc cataloguing/value_builder/stocknumberAV.pl -- after the patch is more readable. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #29 from Fridolin SOMERS --- Works as expected. This behavior makes sense to me. Note for QA : Some lines are missing ending ";"non ? Like : return $av_check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80759|0 |1 is obsolete|| --- Comment #27 from Fridolin SOMERS --- Created attachment 101327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101327=edit Bug 21503: Changed logic for checking values Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80762|0 |1 is obsolete|| --- Comment #28 from Fridolin SOMERS --- Created attachment 101328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101328=edit Bug 21503: Simplify If Else logic Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80758|0 |1 is obsolete|| --- Comment #26 from Fridolin SOMERS --- Created attachment 101326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101326=edit Bug 21503: Tests clarification for debugging Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80563|0 |1 is obsolete|| --- Comment #24 from Fridolin SOMERS --- Created attachment 101324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101324=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested shelving location code. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80601|0 |1 is obsolete|| --- Comment #25 from Fridolin SOMERS --- Created attachment 101325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101325=edit Bug 21503: Tests cleanup and highlight a missing case This patch does the following changes: - Use build_object to create the MSS - Store the generate AVs. That was not the case before and so we were not testing the right things - Split the tests into 2 parts: staff and OPAC, for readability - Update the tests' descriptions - Highlight a problem: If descriptions are missing for both OPAC and staff, undef is returned. Is that what we expect? It seems that it is not what were expecting the tests. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Attachment #80561|0 |1 is obsolete|| --- Comment #23 from Fridolin SOMERS --- Created attachment 101323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101323=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
