[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102666|0 |1 is obsolete|| --- Comment #54 from Lari Taskula --- Created attachment 102676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102676=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102665|0 |1 is obsolete|| --- Comment #53 from Lari Taskula --- Created attachment 102675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102675=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to select past date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- enhancement will not be backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com --- Comment #53 from Lucas Gass --- assuming this is wanted in 19.05.x as well. backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Lari Taskula changed: What|Removed |Added Attachment #102668|0 |1 is obsolete|| --- Comment #7 from Lari Taskula --- Created attachment 102673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102673=edit Bug 25103: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Lari Taskula changed: What|Removed |Added Attachment #102667|0 |1 is obsolete|| --- Comment #5 from Lari Taskula --- Created attachment 102671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102671=edit Bug 25103: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "ONSITE" (on-site) and "CHECKOUT" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Lari Taskula changed: What|Removed |Added Attachment #102669|0 |1 is obsolete|| --- Comment #8 from Lari Taskula --- Created attachment 102674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102674=edit Bug 25103: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Lari Taskula changed: What|Removed |Added Attachment #102670|0 |1 is obsolete|| --- Comment #6 from Lari Taskula --- Created attachment 102672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102672=edit Bug 25103: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #15 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24788] Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 --- Comment #4 from Lari Taskula --- Created attachment 102670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102670=edit Bug 25103: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 --- Comment #3 from Lari Taskula --- Created attachment 102669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102669=edit Bug 25103: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 --- Comment #2 from Lari Taskula --- Created attachment 102668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102668=edit Bug 25103: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 --- Comment #1 from Lari Taskula --- Created attachment 102667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102667=edit Bug 25103: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "ONSITE" (on-site) and "CHECKOUT" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802
--- Comment #8 from Lucas Gass ---
My rebase:
else {
for (my $i=0;$i<$count;$i++){
undef $itemnumber[$i] if !$itemnumber[$i];
-ModReserve({
+my $suspend_until = $query->param( "suspend_until_" . $reserve_id[$i]
);
+my $params = {
rank => $rank[$i],
reserve_id => $reserve_id[$i],
branchcode => $branch[$i],
itemnumber => $itemnumber[$i],
-suspend_until => $suspend_until[$i]
-});
+defined $suspend_until ? ( suspend_until => $suspend_until ) : (),
+};
+if (C4::Context->preference('AllowHoldDateInFuture')) {
+$params->{reservedate} = $reservedates[$i] ?
dt_from_string($reservedates[$i]) : undef;
+}
+
+ModReserve($params);
}
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24802] Updating holds can cause suspensions to apply to wrong hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24802 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- attempted to rebase and all seems good, test plan works but I fail the qa tool: FAIL reserve/modrequest.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Global symbol "@reservedates" requires explicit package name (did you forget to declare "my @reservedates"?) Global symbol "@reservedates" requires explicit package name (did you forget to declare "my @reservedates"?) reserve/modrequest.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24813] api/v1/holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24813 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22969] fix biblionumber on 001 in UNIMARC XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22969 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102661|0 |1 is obsolete|| --- Comment #51 from Lari Taskula --- Created attachment 102665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102665=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102662|0 |1 is obsolete|| --- Comment #52 from Lari Taskula --- Created attachment 102666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102666=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102660|0 |1 is obsolete|| --- Comment #50 from Lari Taskula --- Created attachment 102664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102664=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102659|0 |1 is obsolete|| --- Comment #49 from Lari Taskula --- Created attachment 102663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102663=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24798] smart-rules.tt has erroneous comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24798 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102658|0 |1 is obsolete|| --- Comment #48 from Lari Taskula --- Created attachment 102662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102662=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102657|0 |1 is obsolete|| --- Comment #47 from Lari Taskula --- Created attachment 102661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102661=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102656|0 |1 is obsolete|| --- Comment #46 from Lari Taskula --- Created attachment 102660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102660=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102655|0 |1 is obsolete|| --- Comment #45 from Lari Taskula --- Created attachment 102659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102659=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24803] Clicking "Log in to your account" throws fatal Javascript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24803 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #18 from Lucas Gass --- cannot recreate in 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24719] C4::Context::set_remote_address() prevents file upload for non-Plack Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24719 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- the sub set_remote_address does not exist in C4/Context.pm in 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102597|0 |1 is obsolete|| --- Comment #43 from Lari Taskula --- Created attachment 102657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102657=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102596|0 |1 is obsolete|| --- Comment #42 from Lari Taskula --- Created attachment 102656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102656=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102599|0 |1 is obsolete|| --- Comment #44 from Lari Taskula --- Created attachment 102658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102658=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102593|0 |1 is obsolete|| Attachment #102594|0 |1 is obsolete|| Attachment #102595|0 |1 is obsolete|| Attachment #102598|0 |1 is obsolete|| --- Comment #41 from Lari Taskula --- Created attachment 102655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102655=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24552] Koha does not work with Search::Elasticsearch 6.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #15 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Blocks||25103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 [Bug 25103] Dynamically add checkout types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Lari Taskula changed: What|Removed |Added Depends on||25037 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 [Bug 25037] Add support for multiple checkout types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25103] New: Dynamically add checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 Bug ID: 25103 Summary: Dynamically add checkout types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@hypernova.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This is a follow-up to Bug 25037 that adds issues.checkout_type column for determining the type of checkout (currently only normal and on-site are supported). This Bug adds a new authorised value category, CHECKOUT_TYPE and adds the current checkout types as authorised values. Librarians can then add their own checkout types via authorised values user interface. However this does not yet add support for checking out items with dynamically created checkout types. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #40 from Lari Taskula --- (In reply to Katrin Fischer from comment #39) > Hi Lari, > > I really like the idea of circulation types - I think I actually suggested > something like that when on-site was introduced at the time, because I know > other systems use this concept. Just curious, which systems and how does it work in them? > I have 2 comments for discussion/consideration. > > 1) "This commit adds an authorised value category "CHECKOUT_TYPE" and > an authorised value "OS" (on-site) and "C" (normal checkout)." > > I feel this is not necessary and would vote for hard-coding the circulation > types and their descriptions. It will make it translatable and keep people > from 'messing' with it. Unless you plan to really allow people to add a lot > more of those? The default values are both hardcoded and exist as authorised value. While we are at it, my idea was to add database support for dynamicity. Although, fully supporting such feature would require more changes in the GUI and circulation logic which I do not plan to implement. What comes to messing with the values - we can set a RESTRICT flag into the foreign key which means one cannot change nor delete the authorised values, unless the whole issues and old_issues table is empty. This way a librarian cannot accidentally mess up a production system (unless they really did not had any checkouts (active or returned) yet). But we can proceed with only hardcoding the values. We can move the authorised value patches to another Bug for someone else to continue from there. In order to protect issues.checkout_type from non-existing types, we could use an ENUM data type that only allows a value from a set of possible hardcoded values. I will do that now so we can get this Bug moving easier. We can then later choose whether to include auth value functionality or not. > I'd also use more speakign abbreviations, maybe 'ONSITE' and > CHECKOUT - no need to make things more cryptical than necessary. It would > help doing reports etc. too. I don't have any preference on the code choices. We can make it more readable. > 2) On the mailing list it was suggested to have 'normal' 'on-site' and > 'all'. I am not sure about the 'all'. I feel it might be complicating things > more than necessary. If all was to preserve current behaviour, I don't think > that would work as on-site currently is 1 day by default, independent of the > normal loan period. The circulation rules part of this Bug was moved to Bug 25089. "All" is useful if you only need to separate one or two rules between the types of checkouts. As an example, you could then have one full set of rules with "All" scope, and loan period = 1, renewals allowed = 0 with "on-site" scope. Thx for your input! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25088] The tool to bulk edit due dates proxy error times out with large data sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25088 Kyle M Hall changed: What|Removed |Added Resolution|--- |DUPLICATE CC||k...@bywatersolutions.com Status|NEW |RESOLVED --- Comment #4 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 25101 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om --- Comment #3 from Kyle M Hall --- *** Bug 25088 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 ByWater Sandboxes changed: What|Removed |Added Attachment #102650|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 102654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102654=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #9 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > Looking at the logs the interface is shown as 'opac', should this not be > command-line? The interface is labeled as 'cron' in my testing, and is not modified by this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall changed: What|Removed |Added Attachment #71068|0 |1 is obsolete|| Attachment #71070|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 102652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102652=edit Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #8 from Kyle M Hall --- Created attachment 102653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102653=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN - 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25102] New: Gwn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25102 Bug ID: 25102 Summary: Gwn Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: jbmarkowic...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 102651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102651=edit gengans Gen Ryuzaki -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 Kyle M Hall changed: What|Removed |Added Blocks||25101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 [Bug 25101] Add ability to skip previewing results when batch extending due dates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall changed: What|Removed |Added Depends on||25020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25020 [Bug 25020] Extending due dates to a specified date should preserve time portion of original due date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #1 from Kyle M Hall --- Created attachment 102650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102650=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25101] New: Add ability to skip previewing results when batch extending due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Bug ID: 25101 Summary: Add ability to skip previewing results when batch extending due dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25050] Elasticsearch - authority indexing depends on mapping order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25050 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #6 from Lisette Scheer --- (In reply to Lucas Gass from comment #5) > Some librarians use a lot of News items (both in slips and in the the OPAC > ). That makes for a lot of clutter once we start adding the HTML > preferences. What are the thoughts of separating these into separate 'Tools'? > > -News > -Another section for "HTML customization" or whatever is decided to call it This is even better. Especially in consortium where different libraries might all be using the news for different things, it could be very clunky to have all the news + these content fields we are moving into the news. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #6 from Andrew Fuerste-Henry --- However, see bug 20101 -- the cron log doesn't record that the cron was run. This is really a separate issue, but came up in conversation about this. Looks like Kyle had a patch for that bug nearly complete? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- Some librarians use a lot of News items (both in slips and in the the OPAC ). That makes for a lot of clutter once we start adding the HTML preferences. What are the thoughts of separating these into separate 'Tools'? -News -Another section for "HTML customization" or whatever is decided to call it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #5 from Andrew Fuerste-Henry --- Changes made by the cron are recorded in the action log, flagged as performed by user 0 via interface cron. One could write a report to list those and schedule it to email to the library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #102646|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 102649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102649=edit Bug 25097: Add option to message_queue to allow for only specific sending notices The message_queue.pl currently will send all the messages queued up. It would be nice to have some control over which messages are to be sent. Example: We have libraries who only wanted to send 'hold notices' but not overdue, advance notice, etc during the covid-19 quarantine. And some that were the opposite - turn off hold notices, but send other generated notices. Test Plan: 1) Apply this patch 2) Enqueue some messages with different letter codes 3) Run process_message_queue.pl with the new -c parameter using one of the letter codes enqueued 4) Note that only the messages with the selected code were processed! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24993] koha-sip --restart is too fast, doesn't always start sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea changed: What|Removed |Added Attachment #102255|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 102648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102648=edit Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24993] koha-sip --restart is too fast, doesn't always start sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 --- Comment #19 from Katrin Fischer --- Thx, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25100] New: Add ability to add custom text to top of the Self registration Form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100 Bug ID: 25100 Summary: Add ability to add custom text to top of the Self registration Form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be great if we could have a custom HTML setting for information at the top of the self registration field to make it easy for staff to add/edit information about how to follow up with their new card. We currently use jquery to add it, but it would be nice if it was a separate setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24993] koha-sip --restart is too fast, doesn't always start sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Liz Rea --- Hi Jonathan, I just tested this in my devbox, I'd get into the loop but every test I did, sip didn't get started after it stopped. I'll try to troubleshoot it but if you can immediately see what's wrong, happy for a fix. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard changed: What|Removed |Added Attachment #100923|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 102647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102647=edit Bug 16962: Remove the use of "onclick" from serial collection template This patch removes the use of event attributes like "onclick" from the serial collection template. Events are now defined in JavaScript. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly and affect only that tab. - On a subscription which has expired, test that the "Renew" button works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Using action logs seems like the most flexible option, as the results could be emailed with run_report.pl, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 --- Comment #1 from Kyle M Hall --- Created attachment 102646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102646=edit Bug 25097: Add option to message_queue to allow for only specific sending notices The message_queue.pl currently will send all the messages queued up. It would be nice to have some control over which messages are to be sent. Example: We have libraries who only wanted to send 'hold notices' but not overdue, advance notice, etc during the covid-19 quarantine. And some that were the opposite - turn off hold notices, but send other generated notices. Test Plan: 1) Apply this patch 2) Enqueue some messages with different letter codes 3) Run process_message_queue.pl with the new -c parameter using one of the letter codes enqueued 4) Note that only the messages with the selected code were processed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #4 from Lisette Scheer --- (In reply to Owen Leonard from comment #1) > Maybe "News and content" ? > > It's technically redundant but I worry that people will wonder where News > went. +1 We still use this for news and I think it would confuse some of our folks who use that feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #3 from Andrew Fuerste-Henry --- Also, I should add, this cron already has a log option, it's just not very helpful. It gives an itemnumber and the new value of the edited field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Martin Renvoize changed: What|Removed |Added Attachment #102345|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #16 from Martin Renvoize --- Subclassing seems to have done the trick.. I just had to delve deeper into the dbic docs to understand how to call my subclass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Martin Renvoize changed: What|Removed |Added Attachment #102344|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 102645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102645=edit Bug 25040: monkeypatch Schema::Loader for recent MariaDB Recent versions of MariaDB changed the output of 'DESCRIBE' for timestamp columns with defaults from `CURRENT_TIMESTAMP` to `current_timestamp()`. As such the code inside DBIx::Class::Schema::Loader which catches such cases and outputs `\"current_timestamp"` as a sensible cross platform default is missed and this leads of inconsistent class files and bugs with out default lookup code in Koha::Objects. This patch serves as a backport of the code I have submitted upstream such that out developers can continue to use update_dbix_class_files.pl to build their schema classes from the database and regardless of their db server version get a consistently correct output. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Add lang from cookie to plugins template params
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099
--- Comment #1 from Nicolas Legrand ---
Created attachment 102644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102644=edit
Bug 25099: Add lang from cookie to plugins template params
To make internationalised plugins, it may be useful to get the
KohaOpacLanguage from Koha cookie. This patch adds the value of
$cgi->cookie('KohaOpacLanguage') to a LANG variable which is sent to
the template plugin.
In your plugin, you can add a i18n directory containing
lang[-DIALECT].inc files with a TOKENS hash like this:
[%
TOKENS = {
PLUGIN_NAME = "Mannequin"
PRESENTATION = "Voici un example d'outil."
CLICK_ME = "Cliquez moi !"
}
%]
The plugin template can then include such a lang[-DIALECT].inc with a
hash containing all the plugin strings:
[% TRY %]
[% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %]
[% CATCH %]
[% PROCESS "$PLUGIN_DIR/i18n/default.inc" %]
[% END %]
The strings are then printed in the template with something like:
[% TOKENS.PRESENTATION %]
Test plan:
1. apply patch
2. install, enable and run BULAC Mannequin plugin
3. it should print stuff in english by default
4. install french French (fr-FR)
5. change you Koha lang to French
6. run again the plugin
7. ho là là! French!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Add lang from cookie to plugins template params
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 Nicolas Legrand changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] New: Add lang from cookie to plugins template params
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 Bug ID: 25099 Summary: Add lang from cookie to plugins template params Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legr...@bulac.fr QA Contact: testo...@bugs.koha-community.org CC: k...@bywatersolutions.com, severine.que...@bulac.fr, tomasco...@gmail.com Created attachment 102643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102643=edit The Mannequin plugin to test this Bug To make internationalised plugin, it may be useful to get the KohaOpacLanguage from Koha cookie. We could then branch an include template containing all strings in the page in a specific language à la Theke solutions (see https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/blob/master/Koha/Plugin/Com/Theke/PayViaPayPal/opac_online_payment_error.tt) The idea is to have Koha/Plugin/Com/Something/Superplugin/i18n with lang_dialect.inc files. It contains a TOKENS hash with all the string you need for your plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #2 from Andrew Fuerste-Henry --- Other crons generate a log file, so I'd stick with that standard. One could then set something up on the server to email a copy of that log file. I've poked a this a bit a little already, so I've assigned this bug to myself. But I'm unlikely to get it done really quickly, so I might not be a great option if there's urgency here. I'm thinking something similar to items.content would be nice -- a set list of fields that are provided per updated item with the ability to customize that field list if desired. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 --- Comment #1 from Donna --- With the way I see libraries using automatic item modifications, a report that is emailed would be preferred. Typically they are using this function to move things from "New" to regular shelves, and need a list of items to physically take off the New shelf. So an emailed report with call number, title, and barcode would be very helpful. We get a LOT of requests for this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25098] New: automatic item modification needs report function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098 Bug ID: 25098 Summary: automatic item modification needs report function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: j...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The automatic item modification cronjob does not have an option for reporting the items that were modified. Can the cronjob log in action_logs, or as a report that's emailed, or into a logfile that can be downloaded? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #85 from Kyle M Hall --- Created attachment 102642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102642=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #84 from Kyle M Hall --- Created attachment 102641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102641=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #82 from Kyle M Hall --- Created attachment 102639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102639=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #83 from Kyle M Hall --- Created attachment 102640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102640=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Joy Nelson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #81 from Kyle M Hall --- Created attachment 102638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102638=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #79 from Kyle M Hall --- Created attachment 102636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102636=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #80 from Kyle M Hall --- Created attachment 102637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102637=edit Bug 20256: (QA follow-up) Handle non-existing userenv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #77 from Kyle M Hall --- Created attachment 102634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102634=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #78 from Kyle M Hall --- Created attachment 102635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102635=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #74 from Kyle M Hall --- Created attachment 102631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102631=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
