[Koha-bugs] [Bug 25114] Remove duplicated logic from GetLoanLength()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 Lari Taskula changed: What|Removed |Added Blocks||25089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 Lari Taskula changed: What|Removed |Added Blocks||25089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on||25113, 25114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 [Bug 25113] Make CirculationRules.t flexible for new scope combinations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 [Bug 25114] Remove duplicated logic from GetLoanLength() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103042|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 103056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103056=edit Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #1 from Owen Leonard --- Created attachment 103055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103055=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Owen Leonard changed: What|Removed |Added Depends on||25166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] New: Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bug ID: 25166 Summary: Add "aria-hidden = true" to Font Awesome icons in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 23003 Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #8 from Lari Taskula ---
Created attachment 103053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103053=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #9 from Lari Taskula ---
Created attachment 103054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103054=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #7 from Lari Taskula ---
Created attachment 103052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103052=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #5 from Lari Taskula --- Created attachment 103050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103050=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #6 from Lari Taskula ---
Created attachment 103051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103051=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #3 from Lari Taskula --- Created attachment 103048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103048=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #4 from Lari Taskula --- Created attachment 103049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103049=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #1 from Lari Taskula --- Created attachment 103046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103046=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #2 from Lari Taskula --- Created attachment 103047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103047=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #16 from Katrin Fischer --- Created attachment 103045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103045=edit Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What|Removed |Added Attachment #63325|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 103044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103044=edit Bug 17853 - Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24892] Resolve some warnings in opac-memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24892 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #10 from Hayley Mapley --- Minor patch will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24848] Help link from label creator batch/layout/template points to card creator in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #12 from Hayley Mapley --- Not an issue in 18.11, not backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What|Removed |Added Assignee|grace.m...@gmail.com|katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What|Removed |Added Attachment #63326|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14229] Link to accounting tab from fines column in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 --- Comment #2 from Katrin Fischer --- Created attachment 103043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103043=edit Bug 14229: Only show 'Create labels' link on staged records import when status is imported The label creator won't be able to add a batch for items, if they are not imported into the database (missing itemnumber). This patch hides the link, when the status is not imported to avoid the error situation. To test: - Export a record with items from your Koha installation - Delete record an items - Stage the record with the items - the "Create labels" link should be showing - Try to create the labels - note error - Apply patch - Retry - the link should no longer show - Import the records - the should show now - Crate labels again - a new batch should have been created - Verify the link on the batch # leads to the batch in the labels module Bonus: Moves the message from the .pl file to the template to make it translatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8595] Link to 'host item' confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #17 from Hayley Mapley --- Minor patch will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25110] Allow patrons to add star ratings to titles on their summary/checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Owen Leonard --- The ratings feature has never allowed the user to set a rating on the search results page. To make that change is certainly possible but I would consider it out of scope for this bug. Ed: Did you clear your browser cache after applying the patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word order in Patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #10 from Hayley Mapley --- Minor patch will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #16 from Hayley Mapley --- I am having trouble recreating, is somebody able to confirm that this patch works for 18.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #15 from Hayley Mapley --- I cannot get any of the data fields showing on my labels in 18.11.x, following this test plan. Is somebody able to confirm that this works in 18.11 and that this patch fixes any issues? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add checkout_type to checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 --- Comment #9 from Lucas Gass --- reverted from 19.05.x, missing dependency that I overlooked -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05, |20.05.00, 19.11.05 released in|19.05.10| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14369] Only show 'Create labels' link on staged records import when status is 'Imported'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 Katrin Fischer changed: What|Removed |Added Summary|don't allow labels on |Only show 'Create labels' |staged records |link on staged records ||import when status is ||'Imported' Assignee|cnighswon...@foundations.ed |katrin.fisc...@bsz-bw.de |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass changed: What|Removed |Added Depends on||25137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 [Bug 25137] PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25137] PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Lucas Gass changed: What|Removed |Added Blocks||25136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 --- Comment #2 from Lucas Gass --- Created attachment 103042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103042=edit Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25136] PatronSelfRegistrationLibraryList controls both self-reg and self-modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25110] Allow patrons to add star ratings to titles on their summary/checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 Ed Veal changed: What|Removed |Added CC||ev...@mckinneytexas.org --- Comment #7 from Ed Veal --- When I tested this I saw the "stars" briefly then the empty dropdown appeared with the "rate me" button next to it. There were rating numbers in the dropdown but you had to click on the dropdown to see them. I agree with Kelly that this really needs to appear the same as the other rating points. I am sure you are working on that and I think this is a great enhancement. Keep it up! Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14229] Link to accounting tab from fines column in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 --- Comment #1 from Katrin Fischer --- Created attachment 103041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103041=edit Bug 14229: Add link from patron search results fine to accounting tab in patron account This adds a link to the accounting tab from the patron search results by making the amount in the Fines column clickable. To test: - Make sure you have some patrons with fines, credits and 0,00 - Search for your patrons using the patron search, make sure you get more than one result for your search - Check the results table - the amount should always be linked and lead to the patron account accounting > transactions tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14229] Link to accounting tab from fines column in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14229] Link to accounting tab from fines column in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14229] Link to accounting tab from fines column in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 Katrin Fischer changed: What|Removed |Added Summary|fines clickable on patron |Link to accounting tab from |results to pay |fines column in patron ||search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24566] UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24566 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z --- Comment #8 from Hayley Mapley --- Minor patch will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- I love this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Lucas Gass changed: What|Removed |Added Attachment #102295|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 103040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103040=edit Bug 25031: Improve handling of multiple covers on the biblio detail page in the staff client This patch modifies the template, JS, and CSS for the bibliographic detail page in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference View a variety of titles and confirm that the cover images are displaying correctly, whether there be 0, 1, 2, or more covers available. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13535] Table alert is missing FK and not deleted with the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 --- Comment #2 from Katrin Fischer --- Created attachment 103039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103039=edit 32# Attachment to Bug 13535 - Table alert is missing FK and not deleted with the patron Bug 13535: Add FK constraint on borrowrnumber to alert table When a patron is deleted, we should clean up the data connected to the patron. This includes subscriptions to 'new issue arrived' arrive messages from the serials module. To test: Part1: - Apply patch - Run updatedatabase - verify no error message - Run updatedatabase again - verify still no error message - Add a subscription and select a notice template for patron notification - Log in as any patron (not yourself) and subscribe to the email alert in the OPAC - Veriy on the subscription detail page, that the patron is subscribed in staff - Note borrowernumber and delete patron - SELECT * from alert; in a report - There should no longer be an entry with the borrowernumber Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13535] Table alert is missing FK and not deleted with the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25086] OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo --- It works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24870] Translate installer data label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24870 Hayley Mapley changed: What|Removed |Added Version(s)|20.05.00, 19.11.05, |20.05.00, 19.11.05, released in|19.05.10|19.05.10, 18.11.16 CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Hayley Mapley --- Backported to 18.11.x for 18.11.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25086] OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103025|0 |1 is obsolete|| --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 103038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103038=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25072] Printing details.tt is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25165] New: Explain all the cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25165 Bug ID: 25165 Summary: Explain all the cataloging plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org The only one that I could find in the manual is the cn_browser plugin, the upload plugin and a vague mention of unimarc 1XX plugins. https://koha-community.org/manual/19.11/en/html/administration.html#edit-existing-frameworks (towards the end of the section) As of writing this (19.12.00.071) this is the list of plugins: - barcode - barcode_manual - callnumber-KU - callnumber - cn_browser - dateaccessioned - macles - marc21_field_005 - marc21_field_006 - marc21_field_007 - marc21_field_008 - marc21_field_008_authorities - marc21_field_008_classifications - marc21_field_245h - marc21_leader - marc21_leader_authorities - marc21_linking_section - marc21_orgcode - normarc_field_007 - normarc_field_008 - normarc_leader - stocknumber - stocknumberAV - stocknumberam123 - unimarc_field_010 - unimarc_field_100 - unimarc_field_100_authorities - unimarc_field_105 - unimarc_field_106 - unimarc_field_110 - unimarc_field_115a - unimarc_field_115b - unimarc_field_116 - unimarc_field_117 - unimarc_field_120 - unimarc_field_121a - unimarc_field_121b - unimarc_field_122 - unimarc_field_123a - unimarc_field_123d - unimarc_field_123e - unimarc_field_123f - unimarc_field_123g - unimarc_field_123i - unimarc_field_123j - unimarc_field_124 - unimarc_field_124a - unimarc_field_124b - unimarc_field_124c - unimarc_field_124d - unimarc_field_124e - unimarc_field_124f - unimarc_field_124g - unimarc_field_125 - unimarc_field_125a - unimarc_field_125b - unimarc_field_126 - unimarc_field_126a - unimarc_field_126b - unimarc_field_127 - unimarc_field_128a - unimarc_field_128b - unimarc_field_128c - unimarc_field_130 - unimarc_field_135a - unimarc_field_141 - unimarc_field_210c - unimarc_field_210c_bis - unimarc_field_225a - unimarc_field_225a_bis - unimarc_field_4XX - unimarc_field_686a - unimarc_field_700-4 - unimarc_leader - upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25072] Printing details.tt is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25072] Printing details.tt is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072 --- Comment #1 from Lucas Gass --- Created attachment 103037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103037=edit Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #44 from Andrew Fuerste-Henry --- If All Unavailable still isn't quite right. Backing up: If On Shelf Holds is set to Yes, you should be able to place holds on all items, regardless of whehter or not they're on order. If On Shelf Holds is set to If Any Unavailable, you should be able to place holds on items marked On Order, but not on items where notforloan=0. If On Shelf Holds is set to If All Unavailable, you should be able to place holds on items marked On Order only if *all* items on the bib have notforloan!=0, are checked out, or are otherwise not available for checkout. So if I have 1 item that's currently checked out and one that marked On Order, I should be able to place a hold on either. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13535] Table alert is missing FK and not deleted with the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Katrin Fischer changed: What|Removed |Added Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 --- Comment #3 from Katrin Fischer --- I see what you by it being used for 2 features. So we have: `verification_token` varchar(255) NOT NULL DEFAULT '', `borrowernumber` int(11) NOT NULL DEFAULT '0', PRIMARY KEY (`verification_token` (191),`borrowernumber`), Because we either have it's either or: modification: borrowernumber != 0 or, no verfication token self registration borrower = 0, verififcation token exists The design, if I understand it correctly, also means that one patron can only have one modification request at a time. And a PK column can not be NULL... as the resulting keys wouldn't be unique any more. The main idea about the FK was to make sure we don't keep storing address and other personal data in there when the patron was long deleted. Would it be simpler to solve that in the method deleting the patron? (where we move the data to deleted_borrowers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25110] Allow patrons to add star ratings to titles on their summary/checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Attachment #102062|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #18 from Lucas Gass --- Created attachment 103036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103036=edit Bug 25007: (follow-up) Add check for normalized ISBN in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #16 from Lucas Gass --- Created attachment 103034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103034=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Attachment #102063|0 |1 is obsolete|| --- Comment #17 from Lucas Gass --- Created attachment 103035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103035=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21294] Indentify boolean fields on the DB structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 --- Comment #5 from Tomás Cohen Arazi --- Should we also add the is_boolean entry to the already existing TINYINT(1)? I would do it on a as-needed basis. As-needed would imply accepting (in QA) a commit that does it, on bugs that require it. For example, if we suddenly want to embed something that is missing that in a totally different place (e.g. $order->suggestions and Koha::Schema::Result::Suggestion missing is_boolean on an attribute) we would accept that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT and DisplayIconsXSLT descriptions should be clearer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 --- Comment #11 from Lucas Gass --- On the results page the class name of that element is 'results_material_type' on both the OPAC and staff side. On the details page the class name is 'type' on Maybe: DisplayOPACMaterialType DisplayMaterialType -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT and DisplayIconsXSLT descriptions should be clearer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 --- Comment #10 from Katrin Fischer --- (In reply to Lucas Gass from comment #9) > If this hides the icons and the descriptions should the name of the system > preferences also change to reflect that? We could, I just held off to cause not too much disruption (manuals, docuemtation etc.). Do you have a suggestion? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25164] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25164 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|E |SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT and DisplayIconsXSLT descriptions should be clearer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- If this hides the icons and the descriptions should the name of the system preferences also change to reflect that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25162] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25162 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25160] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25160 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Summary|Whwjwjwj|SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Lucas Gass changed: What|Removed |Added Attachment #102058|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 103033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103033=edit Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25110] Allow patrons to add star ratings to titles on their summary/checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 --- Comment #6 from Kelly McElligott --- Ah! I see now Owen! Yes, it is working however, I would like to talk about keeping the rating system consistent with how it looks in the results page, where the user can hover over the stars and rate the book. I think for the user to see stars, they understand that it can be rated?! Just my thoughts on this! Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24913] Self registration: Ask users to enter email address twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24913 --- Comment #8 from Martin Renvoize --- My mistake on the JS front then.. reading the patches it just looked like it disabled copy and paste for the inputs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 --- Comment #12 from Joy Nelson --- test for 19.11 tests pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #16 from Joy Nelson --- fix for 19.11.x tests pushed to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24901] C4::Circulation::transferbook lacks tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24901 --- Comment #10 from Joy Nelson --- 19.11.x patch applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25144] Callnumber browser is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25144 Lucas Gass changed: What|Removed |Added Attachment #103030|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 103032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103032=edit Bug 25144: [19.05.x only] Remove subtitle from query Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25144] Callnumber browser is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25144 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25164] New: E
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25164 Bug ID: 25164 Summary: E Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: armymrcy...@gmail.com Created attachment 103031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103031=edit Happy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25163] New: Add the ability to bulk attach items to a bib record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25163 Bug ID: 25163 Summary: Add the ability to bulk attach items to a bib record Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently, in Koha, a single item can be attached to a biblio record at one at a time. Libraries do have the need to do this in bulk as they could be possibly moving multiple items to another bib record and having the ability to do it in bulk would be beneficial. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25144] Callnumber browser is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25144 --- Comment #4 from Nick Clemens --- Created attachment 103030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103030=edit Bug 25144: [19.05.x only] Remove subtitle from query -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25144] Callnumber browser is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25144 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Nick Clemens changed: What|Removed |Added Attachment #103029|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 --- Comment #14 from Nick Clemens --- Created attachment 103029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103029=edit Bug 18499: [19.05.x only] Remove subtitle from query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #28 from David Nind --- Thanks Nick! I can now get most things to work, except for steps 17 and 21 - not sure what I'm doing wrong here. There are reserves table entries: current date = 2020-04-15, waitingdate for items = 2020-04-12, holiday date set (day = 14, month =4, yeare = 20204 Step 17: perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 4 branch CPL passed on parameter No reserves found for CPL Step 21: perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 4 -mtt sms No reserves found for CPL Message 'HOLDREMINDER' content not found for FFL Message 'HOLDREMINDER' content not found for FPL ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #9 from Kyle M Hall --- Created attachment 103028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103028=edit Bug 14708: Don't allow merging of Anonymous Patron into other patron records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #8 from Kyle M Hall --- Created attachment 103027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103027=edit Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24913] Self registration: Ask users to enter email address twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24913 --- Comment #7 from Owen Leonard --- (In reply to Martin Renvoize from comment #6) > This also feels like we could give faster feedback to the end-user. It has JS validation and it works correctly. I only ran into the error because I was testing with JS disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25162] ./MR.F1KT0L
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25162 Owen Leonard changed: What|Removed |Added Attachment #103023|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25162] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25162 Owen Leonard changed: What|Removed |Added Summary|./MR.F1KT0L |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
