[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What|Removed |Added Attachment #92603|0 |1 is obsolete|| Attachment #92604|0 |1 is obsolete|| --- Comment #47 from Julian Maurice --- Created attachment 103556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103556=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #48 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24162] Late orders improvements - display new columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #103522|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 103555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103555=edit Bug 24718: (follow-up) Updated schema file For sandboxes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #99542|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 103551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103551=edit Bug 24718: Get templates working with HourBasedHolds Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #99548|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 103553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103553=edit Bug 24718: Ensuring tests pass Confirm these tests pass before and after applying patches t/db_dependent/Holds.t t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/HoldsQueue.t t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #99543|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 103552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103552=edit Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #103521|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 103554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103554=edit Bug 24718: (follow-up) Removing old code This solves the JS error Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #99541|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 103550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103550=edit Bug 24718: Get reservedate and expirationdate to use datetime Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 David Nind changed: What|Removed |Added Attachment #99540|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 103549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103549=edit Bug 24718: Introducing HourBasedHolds system preference Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] New: Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Bug ID: 25261 Summary: Multiple parts handling - confirmation alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.fi...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Koha already has a field in the item record to identify multi-part material. Materials specified (bound volume or other part) or 952$3. When there is a value in this field (e.g. 2) Koha will prompt you at checkout and checkin with a message dialog which says: Note about the accompanying materials: 2 This is helpful but can be missed by library staff. This enhancement takes this one step further to introduce a confirmation box to acknowledge that the parts have been checked on issue and return. This prevents staff from proceeding before checking the item in their hands. The reason for this is to prevent arguments with library patrons that they did not originally take all the parts or that they did not return all the parts. For example, a CD with an accompanying booklet or a string quartet with 4 parts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Josef Moravec changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #216 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #212) > Nice work everyone! I've been looking at the code and so far would like to > mention: > - I would prefer 'archived' instead of 'deleted' in the chosen terminology. > And reserve 'delete' for permanent deletion. There is deleted_on and is_current (comment 198 and later for the discussion). > - I'd suggest we split this bug into separate ones for each case to ease > testing and have more people onboard. I know it might be frustrating to read > this, but I think it is the best. There is 2 years history in those commits, splitting them will break everything and add lot of work. I won't do that. I can help to push this one until the finish line but as it. > - In light of the work on the *reserves tables that was announced today, I'd > suggest we review the column names (this could be done in a follow-up bug, > but worth thinking about. That's definitely something different. > - With the same spirit as the above comment, having views for the 'old > tables' might be a good idea. For the reports then you mean? I would personally prefer to add a warning in the report table if the deleted tables are used, but we could add a view. Adding views mean that we will keep them forever? If yes it will add work to maintain them, otherwise when are we going to remove them? Like 1 year after? 2 years? > - Can we merge biblio and biblioitems here? Definitely out of the scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 --- Comment #5 from Jonathan Druart --- % git grep '\ koha-tmpl/opac-tmpl/bootstrap/js/global.js:\ Are not they valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #103488|0 |1 is obsolete|| --- Comment #31 from PTFS Europe Sandboxes --- Created attachment 103548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103548=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones This patchset adds a new syspref: BiblioItemtypeImages If you set BiblioItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. The control field images are formed in XSLT and use label 'Material type' When switching to 'Koha' the images are added in the tmeplate and labeled 'Item type' if labelled TODO: Image size cleanup - adjust UNIMARC xslt To test: 1 - Apply patch 2 - Update database 3 - Do an opac search and view results 4 - Switch pref to 'Koha' and refresh 5 - Note itemtypes appear and material types dissappear 6 - Click in to a record details 7 - Note you see itemtype and icon 8 - Switch the pref 9 - Note you now see material type and icon 10 - Repeat in staff interface Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #28 from Josef Moravec ---
Comment on attachment 101957
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101957
Bug 24412: Attach waiting reserve to desk
Review of attachment 101957:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24412=101957)
-
::: Koha/Hold.pm
@@ +173,3 @@
> };
>
> +if (defined $desk_id) { $values->{'desk_id'} = $desk_id };
the desk_id => $desk_id, setting in values above should be omitted, only the
one in if should stay
@@ +323,5 @@
> +my ($self) = @_;
> +
> +$self->{_desk} ||= Koha::Desks->find( $self->desk_id() );
> +
> +return $self->{_desk};
You should use relation and _new_from_dbic here, see
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace_.5BPROPOSAL_FOR_CHANGE_dev_meeting_2.2F2020.5D
::: Koha/Template/Plugin/Desks.pm
@@ +47,5 @@
> +
> +sub GetName {
> +my ( $self, $desk_id ) = @_;
> +my $d = Koha::Desks->find( $desk_id );
> +return (defined $d) ? $d->unblessed->{'desk_name'} : q{};
should be something like:
return $d ? $d->desk_name : q{};
::: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ +120,4 @@
> [% IF ( hold.found ) %]
> [% IF ( hold.atdestination ) %]
> [% IF ( hold.found ) %]
> +Item waiting at [% hold.wbrname | html
> %][% IF hold.desk_name %], [% hold.desk_name | html %],[% END %] type="hidden" name="pickup" value="[% hold.wbrcode | html %]" /> since [%
> hold.waiting_date | $KohaDates %]
Looks like you don't need to use Desks template plugin.
::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +381,4 @@
> [% SET hold = item.first_hold %]
> [% IF hold %]
> [% IF hold.waitingdate %]
> +Waiting at [% Branches.GetName(
> hold.branchcode ) | html %][% IF ( hold.desk_id ) %], [% Desks.GetName (
> hold.desk_id ) | html %][% END %] since [% hold.waitingdate | $KohaDates %].
you don't new Desks template plugin, just use hold.desk.desk_name
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +468,4 @@
>
>
> name="cancel_reserve" value="0" />
> +class="btn btn-default approve" [% IF (Desks.defined) %]data-dismiss="modal"
> [% END %]>
Will need update as Desks.defined was removed in previous patches on bug 24201
::: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
@@ +106,4 @@
>
> [% IF ( HOLD.is_at_destination ) %]
> [% IF ( HOLD.found ) %]
> +Item waiting at [%
> HOLD.branch.branchname | html %][% IF ( HOLD.desk_id ) %], [%
> Desks.GetName ( HOLD.desk_id ) | html %],[% END %]
you don't new Desks template plugin, just use hold.desk.desk_name
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #27 from Josef Moravec ---
Comment on attachment 101956
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101956
Bug 24412: kohastructure and atomic update
Review of attachment 101956:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24412=101956)
-
:::
installer/data/mysql/atomicupdate/bug_24412_Attach_waiting_reserve_to_desk.perl
@@ +1,4 @@
> +$DBversion = 'XXX'; # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +# you can use $dbh here like:
> +$dbh->do(q{
there should be check for column existance before adding it, something like:
if ( !column_exists( 'reserves', 'desk_id' ) ) {
$dbh->do(...);
}
@@ +5,5 @@
> +ALTER TABLE reserves ADD COLUMN desk_id INT(11) DEFAULT NULL AFTER
> branchcode,
> + ADD KEY desk_id (`desk_id`),
> + ADD CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES
> `desks` (`desk_id`) ON DELETE CASCADE ON UPDATE CASCADE ;
> + });
> +$dbh->do(q{
there should be check for column existance too
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489 --- Comment #5 from Martin Renvoize --- (In reply to Nick Clemens from comment #4) > This patch does highlight some issues - it is possible to create fines of > partial cents. With this patch those fines cannot be written off, or at > least the partial cents cannot. Can you clarify how fines can end up as partial cents.. I've lost track of where/how this can happen :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #41 from Martin Renvoize --- The idea of the input tz is that you're passing in the TZ of the string being passed in.. the idea of the tz conversion at the bottom (and in the call to now) is that we always pass back a DateTime object with a consistent config based timezone. doing this call at the bottom means we will convert internally to the correct instance timezone from the passed timezone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #34 from Martin Renvoize --- Time is running out for this, this cycle now.. I would love to have seen this and bug 24412 make it through alongside bug 13881 this cycle so we had a full feature. There's still a small window of opportunity if we can get back to it quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||23091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24815] Koha::Cash::Register relations should return sets not undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24815 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25231] Don't alert when replacing a bibliographic record via Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25231 Katrin Fischer changed: What|Removed |Added Summary|Don't alert when replacing |Don't alert when replacing |record via Z39.50 |a bibliographic record via ||Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #215 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #212) > - I would prefer 'archived' instead of 'deleted' in the chosen terminology. > And reserve 'delete' for permanent deletion. I am with Katrin here. Deleted is fine. Permanently deleted is gone ;) > - I'd suggest we split this bug into separate ones for each case to ease > testing and have more people onboard. I know it might be frustrating to read > this, but I think it is the best. > - Can we merge biblio and biblioitems here? Here means another report probably :) This move is huge already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103361|0 |1 is obsolete|| --- Comment #62 from Lari Taskula --- Created attachment 103547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103547=edit Bug 25089: Change sorting order to branchcode, checkout_type, categorycode, itemtype Otherwise we need to duplicate a rule with renewalsallowed=0 every rule if we don't want on-site checkouts to be renewalable. To test: 1. prove t/db_dependent/Koha/CirculationRules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103360|0 |1 is obsolete|| --- Comment #61 from Lari Taskula --- Created attachment 103546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103546=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103358|0 |1
is obsolete||
--- Comment #59 from Lari Taskula ---
Created attachment 103544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103544=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103359|0 |1
is obsolete||
--- Comment #60 from Lari Taskula ---
Created attachment 103545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103545=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103356|0 |1
is obsolete||
--- Comment #57 from Lari Taskula ---
Created attachment 103542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103542=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103357|0 |1
is obsolete||
--- Comment #58 from Lari Taskula ---
Created attachment 103543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103543=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103353|0 |1 is obsolete|| --- Comment #54 from Lari Taskula --- Created attachment 103539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103539=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103354|0 |1 is obsolete|| --- Comment #55 from Lari Taskula --- Created attachment 103540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103540=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103355|0 |1 is obsolete|| --- Comment #56 from Lari Taskula --- Created attachment 103541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103541=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103352|0 |1 is obsolete|| --- Comment #53 from Lari Taskula --- Created attachment 103538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103538=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103351|0 |1 is obsolete|| --- Comment #52 from Lari Taskula --- Created attachment 103537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103537=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #214 from Katrin Fischer --- I am not sure about the use of archived - for libraries archived might have a different meaning and be counter-intuitive. We are talking about items and records that have been removed from their collections permanently here, I feel deleted is better and would match the GUI functionalities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 --- Comment #4 from Alex Buckley --- Created attachment 103536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103536=edit Bug 25090: Add sysprefs to define destination of OPAC self reg verification emails Online resources such as Ancestry, EBSCO etc. often charge on a usage basis and for library users to access them they need a Koha OPAC login. Enabling PatronSelfRegistration syspref allows patrons to immediately create a Koha patron and have the ability to login to the OPAC. Enabling PatronSelfRegistrationVerifyByEmail delays when the patron can login to the OPAC until after they have clicked on the verification email sent to their entered email address. Currently there is no way for libraries to moderate self registrations and prevent certain users (e.g. registrations from outside an organisation) from having OPAC logins and therefore access to paid online resources. This enhancement adds two new system preferences PatronSelfRegistrationVerificationRecipient and PatronSelfRegistrationVerificationRecipientAddress. These new system preferences work in the same way as existing sysprefs EmailPurchaseSuggestions, EmailAddressForSuggestions, and they keep the current Koha behaviour as their default. The former new syspref allows librarians to control where the verification email (generated after OPAC self registration form is submitted) goes to. The choices are: A. Self registering patrons selected home library email B. KohaAdminEmailAddress - Although ReplyToDefault syspref is defaulted to be used first C. Email address entered into PatronSelfRegistrationVerificationRecipientAddress D. Self registering patron email address - This is the default set for PatronSelfRegistrationVerificationRecipient. If A,B,C is selected then a new STAFF_OPAC_REG_VERIFY notice is sent to the library staff after the OPAC self registration form is submitted. The library staff can then review the submitted patron information and if they are happy for that user to have a OPAC login they click the verification link. Whereupon a patron account is added to the Koha borrowers table and the 'SELF_REG_APPROVED' notice containing a password reset link is sent to the patron. If D is selected then after submitting the OPAC self registration form is submitted then the patron is emailed the OPAC_REG_VERIFY notice directly and they can click the verification link whereupon they have a OPAC login. Test plan: 1. Enable PatronSelfRegistration, PatronSelfRegistrationVerifyByEmail, and OpacResetPassword sysprefs. Also ensure there are different values in KohaAdminEmailAddress, ReplyToAddress sysprefs and branch email address (Administration > Libraries) 2. Visit OPAC click registration link 3. Submit form and query the database: select to_address from message_queue where letter_code='OPAC_REG_VERIFY'; 4. Observe the verification email is sent directly to the email address entered in step #3 5. Apply patch and restart plack 6. update database: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 7. Observe 2 new sysprefs: * PatronSelfRegistrationVerificationRecipient -> Note this has default value of 'email address of Self registering patron' * PatronSelfRegistrationVerificationRecipientAddress 8. Repeat steps 2,3,4 and observe the 'OPAC_REG_VERIFY' notices is still sent directly to the patron 9. Change PatronSelfRegistrationVerificationRecipient to 'email address of branch' 10. Revisit the OPAC, resubmit the OPAC self registration (setting the library to a library with a email set in step #1) and observe text is displayed telling you that your self registration has been sent to librarians for approval 11. Query the database: select to_address, content from message_queue where letter_code='STAFF_OPAC_REG_VERIFY'; Observe that the STAFF_OPAC_REG_VERIFY notice was sent to the individual library email address and contains: * Card number * Name: title firstname surname * Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country * Email * Phone * Mobile * Fax * Secondary email * Secondary phone * Home library * Temporary patron category And a verification link 12. Query the database and observe the patron added in step 8 doesn't yet exist in the borrowers table, e.g: select * from borrowers where email=; 13. Copy the verification link from step #11 into your browser 14. Observe the OPAC is displaying text telling you a password reset link email was sent to patron 15. Query the database and observe the patron has been added to the borrowers table now: select * from borrowers where email=; 16. Query the message_queue table and observe the password reset email 'SELF_REG_APPROVED' has been sent to the patron: select to_address, content from message_queue where letter_code='SELF_REG_APPROVED'; 17. Click on the password reset link in that email and observe the password reset page in the OPAC loads with the login
[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added Attachment #103535|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23930] No permissions SSO login to staff client should redirect to a custom URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23930 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I'm not sure that I understand this one. What SSO are you targeting and what scenario? From the OPAC side, I have a OpenID Connect client for Koha (which one of these days I'll find time to upstream). If I already have a session with the Identity Provider and I click on a Koha link, it'll prompt me to log in, I'll choose my Identity Provider from the login options for Koha, it'll bounce me to the IdP, then bounce me back. If I don't have authorization/permission, I'd expect to see my original Koha page saying that I'm not authorized. I could see it being an issue if it re-directed me to a login page though, as I'd already be authenticated just not authorized... ...which is where I'm getting lost with your description. You're saying the patron has been authenticated but they're not authorized to be in the staff client, so they're being re-directed to the Koha login page instead of whatever page they were trying to access? I take it that you want to redirect the patron back to the page they were on before they navigated to Koha? What kind of SSO is this? I'm guessing the redirection to the IdP must be automatic and not require the user to click on something on the Koha staff client login side? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25259] Tumblebooks Integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25259 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25258] Kanopy integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25258 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #17 from David Cook --- (In reply to Martin Renvoize from comment #11) > As for requiring module load prior to reading the yml.. hmm, does feel like > we should be able to get that path info from the plugin base code koha side > somehow.. A chunk of this is actually about how we then expose the new meta > file next to releases on github (and eventually gitlab) so we can grab that > data via api's and display/use it prior to install entirely. The proposed process sounds like how Apt works (ie download and use the metadata before you even see the packaged software), but you're trying to shoehorn it into Github/Gitlab infrastructure. Looking at https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases, I see the koha-plugin-kitchen-sink-v2.1.39.kpz and PLUGIN.yml sitting next to each other. That means you could download and verify the metadata without the software, but that would make importing plugins a 2 step process, if you had to import the KPZ and YAML both. It would also be possible to load in the wrong YAML file for a KPZ. In terms of importing, it would be easier if the PLUGIN.yml were located within the KPZ file. However, that would require staging and unpacking the file to get the PLUGIN.yml metadata. Not very API friendly and also a bit fiddly at the server level. Ok I'm having a thought... If PLUGIN.yml had a MD5 hash for the KPZ file, that would bind together a PLUGIN.yml file and a KPZ file. (Note that you could cryptographically sign the PLUGIN.yml file to increase security.) To import a plugin, you'd first import the PLUGIN.yml, and then you'd import the KPZ file (this could be manual or automated). For backwards compatibility, you could still import a KPZ file without a PLUGIN.yml. Maybe we could add a system preference for this and slowly deprecate this functionality. For the Upload UI, you could noticeably prompt for the PLUGIN.yml, but have a small visible link to "skip" the metadata verification process. For the Plugin Management UI, maybe it would have to generate plugin metadata in the absence of the file. It would be less secure, but that's the world that we're living in at the moment, and we could deprecate this insecure functionality over time. Alternatively, maybe make Koha so that all new plugins for a system have to have PLUGIN.yml in order to import, but all existing plugins have metadata auto-generated for them (after all, they're already installed in the system). And maybe have a system preference to turn off the PLUGIN.yml requirement if necessary to import old plugins that don't have PLUGIN.yml? That would default to the safer option while allowing backwards compatibility optionally. How does that sound? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
