[Koha-bugs] [Bug 24897] Remove es-ES installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24897] Remove es-ES installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897 --- Comment #4 from Martin Renvoize --- Created attachment 103823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103823=edit Bug 24897: (RM follow-up) Drop tests for es-ES notices This follow-up removes the tests for the presence and validity of the spanish translated notices. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 --- Comment #3 from David Cook --- Thanks, Frédéric! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #3 from David Cook --- Thanks, Frédéric. Much appreciated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296
--- Comment #4 from Frédéric Demians ---
Coming back from bug 25297, I have a question: Is it necessary to explicitly
call:
Koha::Objects->new->empty;
When you assign a result:
my $result = Koha::Holds->new;
Don't you have already $result->count == 0 ?
If this was the case, your code in bug 25297 could become something like that:
my $result = Koha::Holds->new;
my $biblio = $self->biblio;
return $result unless $biblio;
my $items_rs = $self->_result->aqorders_items;
my @item_numbers = $items_rs->get_column('itemnumber')->all;
return $result unless @item_numbers;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Frédéric Demians changed: What|Removed |Added Attachment #103819|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 103822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103822=edit Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/ Renew or Edit details" Signed-off-by: Frédéric Demians Without this patch the display was incomplete on patron detail tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 Frédéric Demians changed: What|Removed |Added Attachment #103820|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 103821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103821=edit Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians See the typo, the bug before/after -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 --- Comment #16 from Victor Grousset/tuxayo --- There are currently 2 big holes in my rewrite. They are the TODOs in the code, I'm copying them here. # TODO test fails depending on what we have from LOC. # e.g. If Title or Transcribing agency is not provided # * tag 040 subfield c Transcribing agency in tab 0 # * tag 245 subfield a Title in tab 2 # * Field 040 is mandatory, at least one of its subfields must be filled. # * Field 245 is mandatory, at least one of its subfields must be filled. # Idea: a simple & reliable way to handle this would be to unconditionally # fill 040$c and 245. # Before doing that (inventing my thing): has this problem already been solved in our knowledge in a better way? # TODO we have the issue of when we run the test twice, the record exists # and Koha asks about what to do about this. # Is there an obvious way to cleanup this? # notes: the need is to cleanup after the test sucess # and to cleanup before starting the test again in the case after a failure. # Will bug 19821 help? # Bug 19821 - Run tests on a separate database # Idea from the current cleanup(): (whose code seems mostly not related to this test) # - name the record specifically like test_cataloging_workflow # - delete it and it's related items # - question: isn't it risky about data integrity? # Another idea: # - pick a random number and replace the ISBN by it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #15 from Victor Grousset/tuxayo --- V1 of rewrite: diff: https://gitlab.com/tuxayo/Koha/-/commit/6f2aaf0867b3157d4823fe6c7e5449b49fe1133a whole test file: https://gitlab.com/tuxayo/Koha/-/blob/6f2aaf0867b3157d4823fe6c7e5449b49fe1133a/t/db_dependent/selenium/cataloging_workflow.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #3 from Frédéric Demians --- How to sign-off such a patch? And who has the knowledge/authority to do it? Reading the code and the reasoning behind this patch, I could say that it's clear and clean, but is it enough to sign-off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Assignee|ch...@bigballofwax.co.nz|vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 --- Comment #1 from David Cook --- Created attachment 103820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103820=edit Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25301] New: Category code is blank when renewing or editing expired/expiring patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Bug ID: 25301 Summary: Category code is blank when renewing or editing expired/expiring patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When renewing or editing the details of an expired patron via the "Renew" or "Edit details" links, there is a blank argument to "categorycode=". At a glance, it doesn't seem to cause problems, so we should either fix the argument, or remove the parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25300] New: Edit details in "Library use" section uses bad $op for Expiration Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 Bug ID: 25300 Summary: Edit details in "Library use" section uses bad $op for Expiration Date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the "Library use" section on the Details page for a patron for an expired/epiring patron, the "Edit details" link uses op=modify], which looks like it works (ie it doesn't explode), but it doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #1 from David Cook --- Created attachment 103819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103819=edit Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/ Renew or Edit details" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22134] Add account expiration information to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25299 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22134 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25299] New: Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Bug ID: 25299 Summary: Date not showing on Details page when patron is going to expire Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The date doesn't show on the Details page when the patron is going to expire. It does appear on the "Check out" page, however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22134] Add account expiration information to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #15 from David Cook --- Looks like this actually created a regression. Once I confirm the bug and fix I'll open up another bug report... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #22 from David Cook --- I like the sound of this but the implementation seems very different to what I would have expected. I thought it would be something like "misc/devel/install_plugin.pl ". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23303] When uninstalling a plugin we don't call any form of 'unload'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23303 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #16 from David Cook --- Oh... I like the sound of this. Could be very handy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 --- Comment #4 from David Cook --- (In reply to Jonathan Druart from comment #2) > Do we have something else? If Bug 22417 goes ahead, the koha-worker daemons would probably need it, if they were closely coupled to Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24761] Caching issues in scripts running in daemon mode [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761 --- Comment #3 from David Cook --- > Do we have something else? I can't think of anything else? In terms of Koha-related daemons, at a glance all I see are the following: - koha-plack (starman) - koha-indexer (rebuild_zebra.pl) - koha-sip (SIPServer.pm) - koha-zebra (zebrasrv) - koha-z3950-responder (Z3950Responder.pm) koha-plack and koha-zebra are irrelevant. koha-indexer and koha-sip are done. So that should just leave koha-z3950-responder via https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25292. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25246] Add script to export bib data to EBSCO EDS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246
--- Comment #12 from David Cook ---
Comment on attachment 103711
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103711
Bug 25246: Add script to export bib data to EBSCO EDS
Review of attachment 103711:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=25246=103711)
-
Looking at this overall, maybe it should be changed from "export2ebsco.pl" to
"export2ftp.pl" or "export_to_ftp.pl" and just made a bit more generalized.
Not everyone uses EBSCO, but I'm sure many people use FTP for metadata
consumers like national libraries and such.
::: misc/export2ebsco.pl
@@ +1,1 @@
> +#!/usr/bin/env perl
This should be #!/usr/bin/perl
@@ +24,5 @@
> +use C4::Context;
> +use C4::Auth;
> +use C4::Output;
> +use C4::Biblio;# GetMarcBiblio GetXmlBiblio
> +use C4::Koha; # GetItemTypes
Many of these modules appear to be unused?
@@ +49,5 @@
> +if ( not $result or $want_help ) {
> +usage();
> +}
> +
> +unless ( chdir '/tmp' ) {
It would be good to use a configurable directory, since /tmp might be very
small on some systems and the export very large
@@ +64,5 @@
> +my $export_filename = shift;
> +my $dbh = C4::Context->dbh;
> +
> +my $query =
> +# 'SELECT distinct biblioitems.biblionumber FROM biblioitems WHERE
> biblionumber >0 ';
This comment should be removed
@@ +65,5 @@
> +my $dbh = C4::Context->dbh;
> +
> +my $query =
> +# 'SELECT distinct biblioitems.biblionumber FROM biblioitems WHERE
> biblionumber >0 ';
> + 'SELECT distinct biblioitems.biblionumber FROM biblioitems LEFT JOIN
> items USING (biblioitemnumber) WHERE biblioitems.biblionumber >0 ';
The WHERE clause seems odd to include but I don't see any problem with it. I'm
guessing the author sometimes has biblios with negative biblionumbers?
@@ +74,5 @@
> +open my $fh, '>:encoding(utf8)', $export_filename
> + or croak "Cannot open $export_filename : $!";
> +
> +while ( my ($biblionumber) = $sth->fetchrow_array ) {
> +#my $marc_record = GetMarcBiblio($biblionumber, 1);
This comment should be removed
@@ +91,5 @@
> +my @abbr = qw( Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec );
> +my @tm= localtime();
> +my $month = $tm[4];
> +my $year = $tm[5] - 100;
> +my $name = 'INSERT FILE NAME HERE' . $abbr[$month] . $year;
The filename needs to be provided by a CLI option or configuration file
@@ +101,5 @@
> +}
> +
> +sub transfer_file {
> +my $marc_file = shift;
> +my $remote= 'ftp.epnet.com';
Probably best not to hard-code this either, since hostnames are prone to change
@@ +103,5 @@
> +sub transfer_file {
> +my $marc_file = shift;
> +my $remote= 'ftp.epnet.com';
> +my $username = q(INSERT USERNAME HERE);
> +my $password = q(INSERT PASSWORD HERE);
The username and password need to be provided by a CLI option or configuration
file (the latter being better for security).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25246] Add script to export bib data to EBSCO EDS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246 --- Comment #11 from David Cook --- (In reply to David Roberts from comment #10) > We could have used OAI but there is at least one limitation, the main one > being that EBSCO can't handle the deletions. Although we tag records as > "deleted" in the OAI xml, EBSCO don't/can't use that. They asked us to set > position 5 of the leader (000) to "d". However, Koha doesn't do this > automatically so it would mean manually editing the record each time which > is impractical. I guess the other option would be to write another patch to > set position 5 on deletion. So, unless you know another way of handling the > deletions, the export script is still our preferred method. That's an interesting point! We've certainly encountered that obstacle with EBSCO. However, how are deletions handled with your export script? It looks to me like you're just exporting the full set of bib records on each export, which would be functionally equivalent to them re-harvesting the whole collection using OAI-PMH. That said, it would be much less intensive to generate 1 export to FTP than requiring EBSCO to do X number of HTTP requests to get the same result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25298] EbRaHiM-VaKeR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25298 Owen Leonard changed: What|Removed |Added Attachment #103818|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25298] EbRaHiM-VaKeR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25298 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25298] EbRaHiM-VaKeR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25298 Owen Leonard changed: What|Removed |Added Attachment #103817|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25298] EbRaHiM-VaKeR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25298 --- Comment #1 from vaker --- Created attachment 103818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103818=edit iranonymous.ir dvczxc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25298] New: EbRaHiM-VaKeR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25298 Bug ID: 25298 Summary: EbRaHiM-VaKeR Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: ebrahimghia...@gmail.com Created attachment 103817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103817=edit Hacked by EbRaHiM-VaKeR EbRaHiM-VaKeR iranonymous.ir -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914 --- Comment #17 from Victor Grousset/tuxayo --- > Let's not overthink this. What about increasing trust by making this an > opt-in feature? Okay, so same as library name and location? On the same screen? Can we assume enough that the Koha admin will have the right knowledge about whether to share or not system version data? > I am not sure, but I think information is not stored completely anonymously > in the HEA database? (we do store libary names etc.)? Are the whole reports stored? Or is the report content dispatched in the various data aggregates on reception? Making it not possible after reception to associate the system version data with library name. Which means a data leak won't really expose any additional[1] data other than the aggregates on the websites. [1] and the random ids which don't have any value IIUC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Phil Ringnalda changed: What|Removed |Added Attachment #103815|0 |1 is obsolete|| --- Comment #8 from Phil Ringnalda --- Created attachment 103816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103816=edit Bug 25282: Correct Bootstrap dropdown button markup Incorrect markup surrounding Bootstrap dropdown buttons causes display problems with the buttons are in a DataTable. Dropdown wrapper s must have a "btn-group" class. To reproduce the problem, look at the MARC bibliographic frameworks page. The "Actions" menu when triggered will not line up with the button. In almost all cases, dropdown buttons inside tables should also have the "dropup" class on their wrapper so that the menu appears above the button. This prevents the menu from disappearing off the bottom of the window when the button is positioned low in the viewport. To test, apply the patch and test the button menus in tables on the following pages: - Acquisitions -> Invoices - Acquisitions -> Add to order -> From external source -> Results - Acquisitions -> Suggestions - Administration -> Budgets - Administration -> Funds - Administration -> Authority types - Administration -> Authority types -> MARC structure - Administration -> MARC bibliographic frameworks - Administration -> MARC bibliographic frameworks -> MARC structure - Administration -> OAI sets configuration - Administration -> Z39.50/SRU servers - Authorities -> Authority search results - Authorities -> New from Z39.50/SRU -> Search results - Cataloging -> Edit items - Cataloging -> New from Z39.50/SRU -> Search results - Circulation -> Article requests - Reports -> Saved reports - Tools -> Patron lists - Tools -> Rotating collections - Serials -> Serials search results Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #7 from Phil Ringnalda --- Not a current problem, just something to worry about in the future: Authorities -> New from Z39.50/SRU -> Search results doesn't have much clutter above the top result, so a small font or one added action could push the menu for the top result up above the top of the window. Everything else has more than enough headroom. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 --- Comment #8 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #3) > We fixed it manually in koha-testing-docker by setting the right > permissions. You should do the same in kohadevbox so it is back to > functional and you can test things. > No worries about this, we will solve it before the release, and I will set a > pipeline for testing this on normal packages install (i.e. build a package, > install it, and check the generated permissions. Probably on monday. From Tomas comment it sounds like there is still ab it more work needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 Tomás Cohen Arazi changed: What|Removed |Added Blocks|20212 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Depends on|24965 |25297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 [Bug 24965] Koha::Object->to_api should handle undef counts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Owen Leonard changed: What|Removed |Added Attachment #103789|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 103815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103815=edit Bug 25282: Correct Bootstrap dropdown button markup Incorrect markup surrounding Bootstrap dropdown buttons causes display problems with the buttons are in a DataTable. Dropdown wrapper s must have a "btn-group" class. To reproduce the problem, look at the MARC bibliographic frameworks page. The "Actions" menu when triggered will not line up with the button. In almost all cases, dropdown buttons inside tables should also have the "dropup" class on their wrapper so that the menu appears above the button. This prevents the menu from disappearing off the bottom of the window when the button is positioned low in the viewport. To test, apply the patch and test the button menus in tables on the following pages: - Acquisitions -> Invoices - Acquisitions -> Add to order -> From external source -> Results - Acquisitions -> Suggestions - Administration -> Budgets - Administration -> Funds - Administration -> Authority types - Administration -> Authority types -> MARC structure - Administration -> MARC bibliographic frameworks - Administration -> MARC bibliographic frameworks -> MARC structure - Administration -> OAI sets configuration - Administration -> Z39.50/SRU servers - Authorities -> Authority search results - Authorities -> New from Z39.50/SRU -> Search results - Cataloging -> Edit items - Cataloging -> New from Z39.50/SRU -> Search results - Circulation -> Article requests - Reports -> Saved reports - Tools -> Patron lists - Tools -> Rotating collections - Serials -> Serials search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #8 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 25297 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24965, which changed state. Bug 24965 Summary: Koha::Object->to_api should handle undef counts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 --- Comment #3 from Tomás Cohen Arazi --- *** Bug 24965 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 103813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103813=edit Bug 25297: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 103814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103814=edit Bug 25297: Consistent return value in K::A::Order->current_item_level_holds This patch makes the return values for 'current_item_level_holds' consistent: they will always be a Koha::Holds iterator. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => FAIL: It doesn't work as expected, cannot call ->count on undef, etc 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914 --- Comment #16 from Katrin Fischer --- Let's not overthink this. What about increasing trust by making this an opt-in feature? - Share Koha configuration information - Share system configuration / versions etc. While Hea indeed has some trust, it could always be hacked. We should encourage users to share data, but always give them a choice. I am not sure, but I think information is not stored completely anonymously in the HEA database? (we do store libary names etc.)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||25296 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 [Bug 25296] Add a way to force an empty Koha::Objects resultset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25297] New: Consistent return value in K::A::Order->current_item_level_holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 Bug ID: 25297 Summary: Consistent return value in K::A::Order->current_item_level_holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Right now it returns undef if there's no bilbio or items linked to the order. WE should rely on bug 25296 and return an empty Koha::Holds resultset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #90 from Katrin Fischer --- If I understand correctly the problematic line is: $minPasswordLength = 8 if not $minPasswordLength or $minPasswordLength < 8; So if we kept the patch as attached, I think we will break people's workflows. If you have set to a lower password value now, Koha will suddenly force you to use a longer password. Another use case I could see is 4 digit PINs for self checks. I know some older self checks don't support alphanumeric, not sure about length. I feel like we should continue the discussion on a hardcoded value on bug 18308 and keep this one to just change the default value we ship Koha with. It will be a step forward that we can get through quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 103811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103811=edit Bug 25296: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 103812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103812=edit Bug 25296: Add a way to force an empty Koha::Objects resultset This patch adds a new ->empty method to Koha::Objects, that can be used to make the underlying DBIC resultset empty. This way, we can have consistency in our method's return values without the need to build a query that we know in advance that will be empty. No need to hit the DB at all. To test: 1. Apply this patches 2. Notice the tests cover what is expected 3. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! Yay! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] New: Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296
Bug ID: 25296
Summary: Add a way to force an empty Koha::Objects resultset
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
In some scenarios, it would be handy for consistency to just return an empty
resultset (instead of undef, for example).
Take the following example:
sub current_item_level_holds {
my ($self) = @_;
my $items_rs = $self->_result->aqorders_items;
my @item_numbers = $items_rs->get_column('itemnumber')->all;
return unless @item_numbers;
my $biblio = $self->biblio;
return unless $biblio;
return $biblio->current_holds->search(
{
itemnumber => {
-in => \@item_numbers
}
}
);
}
if we wanted to always return a Koha::Holds iterator (as ->current_holds does)
we could do:
sub current_item_level_holds {
my ($self) = @_;
my $items_rs = $self->_result->aqorders_items;
my @item_numbers = $items_rs->get_column('itemnumber')->all;
my $biblio = $self->biblio;
unless ( $biblio and @itemnumbers ) {
return Koha::Holds->new->empty;
}
return $biblio->current_holds->search(
{
itemnumber => {
-in => \@item_numbers
}
}
);
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103113|0 |1 is obsolete|| --- Comment #19 from Andrew Fuerste-Henry --- Created attachment 103810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103810=edit Bug 23816: Fix other tests This patch fixes other tests broken by new password length and strength override To test: 1. prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Koha/Patrons/Import.t \ t/db_dependent/Koha/Plugins/Patron.t \ t/db_dependent/Search/History.t \ t/db_dependent/api/v1/auth_basic.t \ t/db_dependent/api/v1/checkouts.t \ t/db_dependent/api/v1/patrons_password.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t 2. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103110|0 |1 is obsolete|| --- Comment #16 from Andrew Fuerste-Henry --- Created attachment 103807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103807=edit Bug 23816: (follow-up) Define boolean column in shcema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103112|0 |1 is obsolete|| --- Comment #18 from Andrew Fuerste-Henry --- Created attachment 103809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103809=edit Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103108|0 |1 is obsolete|| --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 103805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103805=edit Bug 23816: Update kohastructure and atomic update Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103111|0 |1 is obsolete|| --- Comment #17 from Andrew Fuerste-Henry --- Created attachment 103808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103808=edit Bug 23816: Add tests Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103109|0 |1 is obsolete|| --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 103806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103806=edit Bug 23816: [DO NOT PUSH] Update category schema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Waiting for an answer. In my opinion it feels dirty. We should have a way to effectively build an 'empty iterator' instead of actually performing a search to the DB, knowing it needs to return 0 results. Damn you make me work extra all the time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Owen Leonard --- Not a CSS problem after all but a markup problem. The surrounding the menu should have a "btn-group" class as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #89 from Aleisha Amohia --- If this feature is about increasing the minimum password length, then I don't see why we can't include the fix for Bug 21314 in this patch as it is. They go together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25277] Z3950responder does not work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25277 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25279] Make the cities list use the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #5 from Kyle M Hall --- Created attachment 103803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103803=edit Bug 25279: Use the API to list cities This patch makes the general cities datatable use the API for rendering. To test: 1. Test the datatable behaviour 2. Apply this patch 3. Repeat your tests => SUCCESS: Things work! Filtering and sorting specially Bonus: Use the browser inspector to notice each interaction with the datatable triggers an API call with the right query parameters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25279] Make the cities list use the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #6 from Kyle M Hall --- Created attachment 103804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103804=edit Bug 25279: Fix edit and delete links Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25279] Make the cities list use the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Kyle M Hall changed: What|Removed |Added Attachment #103693|0 |1 is obsolete|| Attachment #103694|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 103802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103802=edit Bug 25279: Add general query parameters to the /cities route Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25279] Make the cities list use the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #31 from Victor Grousset/tuxayo --- Yes, bug 25285 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914 --- Comment #15 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #14) > (In reply to Victor Grousset/tuxayo from comment #13) > > On the other hand, isn't sharing the full version of Koha already more of a > > potential security issue? > > It's in the html source so you can consider it public already. That was the point. Well sort off. I meant that it's already in Hea by default which means some existing trust on the Hea server. But yes it's even available to whoever has access to the OPAC or intranet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23861] Add authorised value categories description option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 --- Comment #4 from Katrin Fischer --- I think we could have both. Please note that the descriptions are a very new addition - for a long time they were no instructions. So while I agree it would be nice to have, I don't see the same urgency or error potential I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23861] Add authorised value categories description option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 --- Comment #3 from Pablo AB --- If using templates complicates the issue too much I would move everything to description column. AFAIK it would be similar to what happen with tag names on frameworks, by default hardcoded on the .sql. The user can then change it at wish. IMO is much more important to have the feature of add/modify AV cats descriptions. I see users creating categories with spaces and diacritics as a workaround, to have more meaningful names. I'm not sure if this could have adverse consequences (Bug 7013). Also related: Bug 20307. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #1 from Nick Clemens --- Created attachment 103801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103801=edit Bug 25273: WIP This patch moves the code for indexing the match-heading field into its own special section only used for authorities Rather than allowing the user to map this field, we create it on our own and add to the indexe documents. Currently, it doesn't work. I think the issue is that match-heading is not being added to the index so is not searchable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] New: Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Bug ID: 25295 Summary: Allow customization of staff client based on login location Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com With more library systems or multiple-branch libraries using Koha, it would be really helpful to be able to customize the look of the staff client based on the library a staff member is logged in at. For instance, allow a library system to designate a header or background color on the staff client based on the branch. So branch A would be green, branch B would be purple, etc. This would allow users to easily and quickly identify which branch they are logged in to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25270] Physical description/format is inconsistent between MARC21slim2OPACResults.xsl and MARC21slim2intranetResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25270 Annette changed: What|Removed |Added CC||amegn...@coloradocollege.ed ||u --- Comment #2 from Annette --- Yes, the OPAC and intranet details should display this information. Consistency is very important and the information in the 007 is very useful/helpful to both user and staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Lucas Gass changed: What|Removed |Added Attachment #103798|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 103800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103800=edit Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Lucas Gass changed: What|Removed |Added Attachment #103797|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 103799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103799=edit Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #4 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > Looks like this patch does the job but IIRC we already switched from left to > right because of another problem (?) Yes, because it's possible for the menu to disappear off the right side of the screen at lower browser widths or with languages which have longer menu item text. While using "pull-left" fixes the symptom of the problem, I believe the real issue is that Bootstrap is calculating the position of the menu button before DataTables draws the table. Whatever solution we come up with will need to be tested with any DataTable that has a Bootstrap menu button in it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25269] MARC21slim2OPACResults.xsl does not display all formats (physical descriptions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25269 Annette changed: What|Removed |Added CC||amegn...@coloradocollege.ed ||u --- Comment #4 from Annette --- The material type "Music" has a number of different formats. When a search for a certain item returns results for different formats for the same item (e.g., Gershwin recording of "Swanee") the list could contain a sound disc, roll, and a cassette. It is helpful to be able to tell right away from the results list which formats are available. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 --- Comment #1 from Owen Leonard --- Created attachment 103798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103798=edit Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25294] New: Don't show deletion button if user can't delete suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294 Bug ID: 25294 Summary: Don't show deletion button if user can't delete suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org If OPACViewOthersSuggestions is enabled the logged-in user might be viewing a list of suggestions none of which they have permission to delete. If this is the case the "Delete suggested" button should not appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23582] Add option to columns configuration menu to show all columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23582 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21332] Content of public lists RSS should match search results RSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21332 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20670] Add markup and standard classes for sidebars and main content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20670 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 --- Comment #2 from Owen Leonard --- Created attachment 103797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103797=edit Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
