[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #28 from Victor Grousset/tuxayo  ---
After a few days and rereading the thing I'll be optimistic and sign it off :)

If the points from comment 24 are clear also for QA then the patches can move
on to get QAed.


Fixed steps 4 of the plan:
> 4/ Add a manual invoice with an invalid barcode, not an error is
> displayed
↓
> 4/ Add a manual invoice with an invalid barcode, note that an error is
> displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #103382|0   |1
is obsolete||

--- Comment #27 from Victor Grousset/tuxayo  ---
Created attachment 103898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103898=edit
Bug 22393: (follow-up) Corrections for QA feedback

We correct the behviour of 'amount' being passed back to the template
and add a work around for the existance of deleted_items alongside a FK
to items in the accountlines table.

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #103336|0   |1
is obsolete||

--- Comment #26 from Victor Grousset/tuxayo  ---
Created attachment 103897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103897=edit
Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice

This patch re-arranges the manualinvoice controller script to clarify
code flow, replaces the last call to C4::Accounts::manualinvoice with a
call to Koha::Accounts->add_debit wrapped in a try catch block and also
adds a check on passed barcodes when the invoice type is 'LOST' so it
can link the subsequently created accountline to the item and issue.

Test plan
1/ Add a manual invoice (without entering a barcode)
2/ Add a manual invoice with a valid barcode (Not a LOST type)
3/ Add a manual invoice with a valid, but old, barcode (Not a LOST type)
4/ Add a manual invoice with an invalid barcode, note that an error is
displayed
5/ Add a manual invoice with type 'LOST' and a valid barcode for a
checkout your user has had checked out
6/ Add a manual invoice with type 'LOST' and a valid barcode, but not
one that will match a checkout for your user. Note an error is displayed
7/ When errors are displayed, note the form contains data from the
previous submission so you can just correct the error rather than
re-enter all data.
8/ Signoff

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #94 from Victor Grousset/tuxayo  ---
Great enhancement! :D

I tested everything I think.
The 3 test plans of the patchset:
- comment 81
- comment 86
- comment 89
The additional test notes from
- comment 85
- comment 91

Anything missing to sign it off?

David:
>> 1) The image attached to the bug shows the human readable field name then
>> the system field name in brackets. With the patches only the system field
>> name is shown. Not a show stopper to get this really nice feature into the
>> next release, but from a 'user' perspective having it the way in the image
>> looks much nicer to me.


Jonathan:
> You should regenerate the css file with `yarn build css`.

I'm also getting only the system field name.

Not a show stopper IMHO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Attachment #103037|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 103896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103896=edit
Bug 25072: Fix details.tt print CSS

TO TEST:
-Search for something in the catalog and go to the details page.
-Try to print either for the Print button in Koha or File->Print...
-Notice the large amount of whitespace on the left
-Apply patch
-Reload detaials page and attempt to print again.
-No whitespace on left side

Signed-off-by: Bernardo Gonzalez Kriegel 
Improves output using Firefox browser, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103871|0   |1
is obsolete||

--- Comment #7 from Andrew Fuerste-Henry  ---
Created attachment 103895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103895=edit
Bug 25189: Don't create authority if results found

Automatic authority creation assumes that if we don't match we need a new
authority.

Using the Default linker, however, we don't match if there exists more than one
match.
This leads to repeatedly generating authorities once there is a duplicate in
the system

We shoudl instead only create a new authority if there are no results

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and 
CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add a heading for that authority to a bib record
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103870|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 103894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103894=edit
Bug 25189: Unit tests

Adds new test for not adding authority if some already exist

Also replaces use of 'SearchAuthorities' as it is Zebra specific

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Seems to be a Firefox problem, or at least I can see your problem using Firefox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

--- Comment #3 from Andrew Fuerste-Henry  ---
Oh, and I'm sorry I completely missed your earlier question. Yes, CCL works in
Elastic broadly.
This isn't a huge deal, since Elastic lets you use quotation marks. So
ti:"Batman Returns" does that ti,phr:Batman Returns fails to do. But it'd still
be good to maintain some continuity for longtime Zebra users.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
(In reply to Lucas Gass from comment #3)
> Here is what I am talking about:
> 
> https://snipboard.io/7OWAej.jpg

Lucas,
I see, but this is what I see

https://snipboard.io/Jca7w1.jpg

(Opera, current master, Print option from details page)

No space on the left for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25183] cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25183

--- Comment #9 from Victor Grousset/tuxayo  ---
- created a self registration
- I see it with
  - select * from borrowers order by borrowernumber DESC limit 1\G
- Applied the patch
- ./cleanup_database.pl --del-exp-selfreg --del-exp-selfreg-type=soft
- woops, wrong syntax, got the help printed
- ./cleanup_database.pl --del-exp-selfreg --del-exp-selfreg-type soft
- it seems it did something! 
- self registration not here anymore
  - select * from borrowers order by borrowernumber DESC limit 1\G
- it's not it deletedborrowers despite "soft"
  - select * from deletedborrowers order by borrowernumber DESC limit 1\G

So, test failed.
Hypothesis: I didn't get the param syntax right and the it's falling back to
the default "del-exp-selfreg-type" value which is "hard"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Severity|enhancement |trivial
 Status|NEW |Needs Signoff
 CC||bgkrie...@gmail.com
   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24636] Acquisitions planning sections untranslatable

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 103893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103893=edit
Bug 24636: translate planning sections

This patch adds a new inc file to process
and translate plannig sections

To test:
1) Apply patch
2) Create new language files
(cd misc/translator; ./translate create xx-YY)
3) Verify new file is taken into account in
translation files
egrep -n budget_planning misc/translator/xx-YY*.po
check new strings in staff-prog file
4) Go to Administration > Budgets > Founds > Planning
select different options, check page title and
'Planning for...' phrase
5) Translate strings, install new language, enable it,
verify the text change with options like point 4)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

Phil Ringnalda  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

--- Comment #2 from Phil Ringnalda  ---
Created attachment 103892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103892=edit
Bug 25308: Escape querystring for Z39.50 popup from cataloging

Test plan:

1. For bonus fun, Administration -> MARC Frameworks -> New framework,
with the code A and description Ants & Bees
2. In the A Actions menu, choose MARC structure since Import won't
work
3. Accept the offer to copy in structure from default
4. Cataloging -> New record -> Ants & Bees
5. Type This & That in the 245$a (and for extra credit, in 020$a, and
create an author authority with an & in it so you can put it in the
100/110)
6. Click Z39.50/SRU search, make sure everything you typed is prefilled
including the parts after &
7. Search for anything that will retrieve a record (the ISBN This &
That probably won't), choose Import
8. Check that the record came back, and verify in the Settings menu that
it's still in the Ants & Bees framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25246] Add script to export bib data to EBSCO EDS

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246

--- Comment #15 from David Roberts  ---
Hi David

No worries - I'm working my way through your suggestions! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25246] Add script to export bib data to EBSCO EDS

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246

David Cook  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from David Cook  ---
Going to mark this one as Failed QA for now due to my in-line comments, as I
imagine the QA team would agree. 

If you disagree, feel free to mark back as Signed Off, and I'll leave my
comments at that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] When cataloguing search fields are prefilled form record, content after & is cut off

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

Phil Ringnalda  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org
   |ity.org |
 CC||p...@chetcolibrary.org

--- Comment #1 from Phil Ringnalda  ---
If you really want to turn one bug into having to file dozens more, make your
first step be "create a new MARC framework with the description Ants & Bees and
the code A" Once you get past the inability to import an exported framework
into it, and just click MARC structure and get the offer to copy in from
default so you can use it to catalog, I'd expect there will be a lot more
bustage (besides what I noticed fixing this, that when you find a record via
Z39.50 and try to load it, it will come back into the nonexistent framework
"A").

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299

--- Comment #6 from David Cook  ---
(In reply to Katrin Fischer from comment #5)
> Good catch!

Thanks but I can't take the credit. We upgraded one of our libraries to 19.11
recently, and a librarian there has a very keen eye!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24808] Untranslatable strings in results.js

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 103891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103891=edit
Bug 24808: enable translation on results.js

String sorrounded by "__()"

To test:
1) create translation files for a language
(cd misc/translator; ./translate create xx-YY)

2) Check string
egrep -l "No cover image available" misc/translator/po/xx-YY-*
present in 2 files, opac-bootstrap and staf-prog

3) Apply patch

4) Create files again
(cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY)

5) Check again
egrep -l "No cover image available" misc/translator/po/xx-YY-*
present in 3 files, new in messages-js

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24808] Untranslatable strings in results.js

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |
   Patch complexity|--- |Trivial patch
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

--- Comment #2 from Katrin Fischer  ---
I just realized this was filed for Elasticsearch.

For Zebra, it seems all good:
'query_cgi' => 'q=ccl=ti%2Cphr%3Astreet',
'querystring' => 'ti,phr:street',
'search_query' => '(rk=( ti,phr="street")) ',

I think for Elasticsearch you are correct, it doesn't look like phrase is
always used. It appears to work when Title, phrase from advanced search is
used, but not when you enter the ccl = is ccl understood by Elasticsearch at
all?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24914] Saving a record as MARC (Unicode/UTF-8, Standard) remove items

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24914

--- Comment #1 from Katrin Fischer  ---
But wouldn't that be the expected behavior as the 952 is not standard? Would it
help if we changed the decriptions including "without item data" somehow?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103888|0   |1
is obsolete||

--- Comment #364 from Aleisha Amohia  ---
Created attachment 103890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103890=edit
Bug 19532: Updated schema files

Including boolean attribute for recalls.old flag and
recalls.item_level_recall flag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25309] New: Unable to create patrons

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309

Bug ID: 25309
   Summary: Unable to create patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 103889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103889=edit
Sandbox Error Trace Log

On master, it is not possible to create patrons. You get an error 
Can't call method "extended_attributes" on an undefined value at
/kohadevbox/koha/members/memberentry.pl line 560

This happens whether you populate the delivered extended attribute (SHOW_BCODE)
or not. 

I have reproduced this on my own dev server, and on the Sandboxes. I've
attached the error trace log from the sandboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

--- Comment #3 from Lucas Gass  ---
Bernardo,

Here is what I am talking about:

https://snipboard.io/7OWAej.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #81586|0   |1
is obsolete||
  Attachment #81587|0   |1
is obsolete||
  Attachment #81618|0   |1
is obsolete||
  Attachment #81652|0   |1
is obsolete||
  Attachment #81653|0   |1
is obsolete||
  Attachment #81654|0   |1
is obsolete||
  Attachment #81655|0   |1
is obsolete||
  Attachment #81656|0   |1
is obsolete||
  Attachment #81657|0   |1
is obsolete||
  Attachment #81658|0   |1
is obsolete||
  Attachment #81659|0   |1
is obsolete||
  Attachment #81660|0   |1
is obsolete||
  Attachment #81661|0   |1
is obsolete||
  Attachment #81662|0   |1
is obsolete||
  Attachment #81663|0   |1
is obsolete||
  Attachment #81664|0   |1
is obsolete||
  Attachment #81665|0   |1
is obsolete||
  Attachment #81666|0   |1
is obsolete||
  Attachment #81667|0   |1
is obsolete||
  Attachment #81668|0   |1
is obsolete||
  Attachment #81669|0   |1
is obsolete||
  Attachment #81670|0   |1
is obsolete||
  Attachment #81671|0   |1
is obsolete||
  Attachment #81672|0   |1
is obsolete||
  Attachment #81673|0   |1
is obsolete||
  Attachment #81674|0   |1
is obsolete||
  Attachment #81675|0   |1
is obsolete||
  Attachment #81676|0   |1
is obsolete||
  Attachment #81677|0   |1
is obsolete||
  Attachment #81678|0   |1
is obsolete||
  Attachment #81679|0   |1
is obsolete||
  Attachment #81680|0   |1
is obsolete||
  Attachment #81681|0   |1
is obsolete||
  Attachment #81682|0   |1
is obsolete||
  Attachment #81683|0   |1
is obsolete||

--- Comment #362 from Aleisha Amohia  ---
Created attachment 103887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103887=edit
Bug 19532: Database and installer stuff

- recalls table
- circulation rules: recalls allowed (total), recalls per record
(count), on shelf recalls allowed, recall due date interval (day),
recall overdue fine, recall shelf time/pickup period (day)
- sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog
- email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM,
RECALL_REQUESTER_DET
- user permission: recalls, manage_recalls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #363 from Aleisha Amohia  ---
Created attachment 103888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103888=edit
Bug 19532: Updated schema files

Including boolean attribute for recalls.old flag and
recalls.item_level_recall flag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #361 from Aleisha Amohia  ---
I will be working on this patch now. The current patches will be made obselete
and fresh patches will be added over the next few weeks. A heads up - there
will likely be lots of emails.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #75 from Joy Nelson  ---
backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25022] Display problem in authority editor with repeatable field

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25022

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 Status|Pushed to master|Pushed to stable
 CC||j...@bywatersolutions.com

--- Comment #8 from Joy Nelson  ---
backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #17 from Joy Nelson  ---
enhancement no backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25004] Search results place hold button not enabled when checking result checkboxes on opac-search.pl

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #8 from Joy Nelson  ---
not needed in 19.11.x branch as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 was not
backported.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24941] Serials: Link to basket in acqusition details is broken

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||j...@bywatersolutions.com
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

--- Comment #7 from Joy Nelson  ---
backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17938] XSLT: Label of 583 is repeated for multiple tags and private notes don't display in staff

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||j...@bywatersolutions.com
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

--- Comment #9 from Joy Nelson  ---
backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446

--- Comment #9 from Katrin Fischer  ---
Thx Phil for taking on this old and annoying bug!

I have added (and tested) your step 9 to the commit message and found another
bug while testing:

Bug 25308 - When cataloguing search fields are prefilled form record, content
after & is cut off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103707|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 103886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103886=edit
Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin

While adding the data from the existing field to the auth_finder URI,
we're using encodeURI(), which is meant for an entire URI and thus
doesn't escape &. Things that are going into a querystring need
encodeURIComponent() instead.

Test plan:

1. Enable the system preference EnableAdvancedCatalogingEditor
2. Clear your browser cache, even a shift+reload won't get you a fresh
marc-editor.js for the advanced editor
3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk
4. In the Basic editor, use the authority plugin on the 650 field to
select that authority.
5. Click the authority plugin again, verify that the popup contains This
& That and Stuff & Junk rather than just This and Stuff
6. From the Cataloging home page choose Advanced editor
7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk
8. Type ctrl+shift+L and verify the popup shows both words in both
fields
9. When you remember the plugin exists there too, edit your
Stuff & Junk authority, and in a 550 tag type One & Two in
$a and Three & Four in $x and click the plugin link, verify that
the search window has your search terms not cut off.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25014] Capitalization: Call Number in sort options in staff and OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25014

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

--- Comment #5 from Joy Nelson  ---
Backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25013] Fix capitalization: Edit Items on batch item edit

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25013

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 CC||j...@bywatersolutions.com

--- Comment #5 from Joy Nelson  ---
Backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25012] Fix class on OPAC view link in staff detail page

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Joy Nelson  ---
Backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24303] Guarantor relationship is not shown with guarantor name on moremember.pl

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24303

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om
   Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c
   |ity.org |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25308

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25308] New: When cataloguing search fields are prefilled form record, content after & is cut off

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25308

Bug ID: 25308
   Summary: When cataloguing search fields are prefilled form
record, content after & is cut off
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To test:
- Add a new record from default framework in cataloguing
- Enter something containing an & in the middle (Stuff & stuff) in
  245$a
  100$a
- Click on Z39.50/SRU search
- Verify the fields author and title are prefilled, but information is cut off
at the &

See also bug 11446 in this context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25049] Changes to overduerules.pl are not being saved

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25049

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13714

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13714] Problems deleting the delay field in overdue triggers

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13714

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25049

--- Comment #2 from Katrin Fischer  ---
Linking bug 25049 - it appears we need some validation for delay changes?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25049] Changes to overduerules.pl are not being saved

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25049

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11318

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11318] Overdues won't send if first trigger lacks a delay value

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11318

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEW |RESOLVED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25049

--- Comment #3 from Katrin Fischer  ---
I believe it's no longer possible to configure a null value from the GUI, see
also bug 25049 (and verified in testing). I think best to focus on bug 25049
now and add good error messages there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25307] SPAM

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25307

Katrin Fischer  changed:

   What|Removed |Added

Summary|Rexy.gans   |SPAM
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25006] Koha::Item->as_marc_field generates undef subfields

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 CC||j...@bywatersolutions.com

--- Comment #8 from Joy Nelson  ---
backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24996] Unwanted CSS change unhides OPAC results sorting button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #5 from Joy Nelson  ---
missing dependencies - not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #73 from Joy Nelson  ---
Also - dependencies lacking in 19.11.x - not backported

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com
 Version(s)|20.05.00|20.05.00,19.11.06
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #11 from Joy Nelson  ---
Backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19475] Calendar copy creates duplicates

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00,19.11.06
released in||
 Status|Pushed to master|Pushed to stable
 CC||j...@bywatersolutions.com

--- Comment #23 from Joy Nelson  ---
Backported to 19.11.x branch for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25307] New: Rexy.gans

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25307

Bug ID: 25307
   Summary: Rexy.gans
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: iamozor...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 103885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103885=edit
Haloo

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335

David Nind  changed:

   What|Removed |Added

 Attachment #103883|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 103884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103884=edit
Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql

The description on STATUS was incomplete, missing 2 status and
the SUGGEST_STATUS category.

To test:
- Later this will show up in schema.koha-community.org, but
  for now it can only be verified reading the patch.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #72 from Joy Nelson  ---
does not apply cleanly to 19.11.x  please rebase if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24900] Fix 'MARC modification templates' to not assume that 'from field' will match 'conditional field'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #11 from Joy Nelson  ---
Tests don't apply cleanly to 19.11.x branch.  Please rebase if needed in
19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172

--- Comment #21 from Blou  ---
It's very hard to handle  fields with translations.

Without modification, it will display English words.  Definitively what the
user does not want.

The alternative (here coded) display in French, and then yes, would save the
modification in French in the DB.  The display would then be French everywhere
after.  It is NOT a win-win, I admit, but it's certainly closer to the user's
needs than the current situation where there's no translation.

I know because I have to handle those requests from many different
institutions...

Now, brainstorming, I suppose a solution could be to have the display separated
from an empty edit-box, which, if data is entered, would be saved as-is in the
DB.  Again, not translatable, though.  Really I don't see an edit option where
French doesn't end up in the DB.

I just think it's the least bad option.  

But I'm listening, I admit to limited imagination right now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to Owen Leonard from comment #2)
> The list of lists in the OPAC is paginated server-side, so adding sorting
> would require one of these methods:
> 
> 1. Add sorting to the query, including handling of ascending and descending
> and the ability to order by the number of titles on the list.
> 
> 2. Remove the server-side pagination and use DataTables to sort and paginate
> the all the results client-side. This would be adequate only if it isn't
> expected that there might be a very large number of lists.
> 
> 3. Remove the server-side pagination and re-implement the table with an AJAX
> datasource, doing AJAX pagination.

4. Add an API route for this, and use the features we've recently added
(specially bug 24561). It would make sorting by any column just trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335

--- Comment #4 from Katrin Fischer  ---
Rebased - Joubu added the new archived column just below the line I fixed,
causing the conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #102795|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 103883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103883=edit
Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql

The description on STATUS was incomplete, missing 2 status and
the SUGGEST_STATUS category.

To test:
- Later this will show up in schema.koha-community.org, but
  for now it can only be verified reading the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313

--- Comment #3 from Katrin Fischer  ---
I've added a link to a UNIMARC documentation I consulted and rephrased the
subject of your commit message to be a bit more descriptive :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103471|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 103882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103882=edit
Bug 19313: Fix typo in in unimarc_field_130.pl value builder

This patch fixes a simple typo

Test plan:
1) Go to Administration -> MARC bibliographic framework
2) Select a framework and add plugin unimarc_field_130.pl to 130 field
3) Open cataloguing screen
4) Go to 130 field and check if for subfield a shows value for
   'unknown' select it and close the window, check on value on 130$a at
   position 8 to have the value 'd'.
5) Repeat step 4 and select the value 'mixed emulsion' close the plugin
   window and check at position 8 to have the value 'u'
6) Apply the patch
7) Go to field 130, open the plugin window and select value 'unknown'
   close the window and check at position 8 to have the value 'u'
8) Go to field 130, open the plugin window and select value 'mixed
   emulsion', close the window and check at position 8 to have the
   value 'v'

Mentored-by: Andreas Roussos

Signed-off-by: Katrin Fischer 
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_130_update2017.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Katrin Fischer  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #3 from Katrin Fischer  ---
I think 1) might be easiest, but I think we will keep adding new sort requests
for every columsn etc and it seems a bit non-standard these days.

I am not sure how many entries some lists have - I haven't seen a really really
long one, but it could happen... so maybe 3) would be best?

Adding tcohen as I think handling big table data server side is something he
has been working on for acquisitions in order to fix performance issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25187] Instructor search only display first ten results which may not be enough for common names

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25187

--- Comment #1 from Katrin Fischer  ---
Maybe instead of using the auto-complete like search we should use a standard
patron search here (an example would be the option to add patrons to receive
notifications when an order is received in acq, changing a suggester in a
suggestion from staff side, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25271] Add floating toolbar to OPAC cart

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25271] Add floating toolbar to OPAC cart

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103777|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 103881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103881=edit
Bug 25271: Add floating toolbar to OPAC cart

This patch adds JavaScript to the OPAC cart view so that the toolbar at
the top of the display "floats" as you scroll down.

The patch also makes a minor correction to the OPAC SCSS affecting the
display of the buttons in the cart toolbar.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Add some items to a cart in the OPAC.
 - Open the cart and confirm that the toolbar sticks to the top of the
   window as you scroll down.
 - Confirm that it works in the "More details" view.
 - Confirm that other JavaScript-based operations are not affected:
   table sorting and all the various toolbar buttons.

Signed-off-by: Frédéric Demians 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25271] Add floating toolbar to OPAC cart

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271

--- Comment #6 from Katrin Fischer  ---
QA script complains a bit, but this will be fixed by bug 25166 - so I suggest
we forego a follow-up here.

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
   OK filters
   FAIL   forbidden patterns
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 23)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 25)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 28)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 30)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 31)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 32)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 34)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 44)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 47)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 50)
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 53)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25166] Add aria-hidden = "true" to Font Awesome icons in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add "aria-hidden = true" to |Add aria-hidden = "true" to
   |Font Awesome icons in the   |Font Awesome icons in the
   |OPAC|OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846

--- Comment #3 from Katrin Fischer  ---
Hm, we probably have. It might not have come up so far, as a name might be used
in different languages and not be translated? But I know some instutions have
an official English name here too and for some we even switch the logo with
language change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
(In reply to Katrin Fischer from comment #10)
> Still valid.
> 

The file and the string are no more present, I think this is now invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168

--- Comment #9 from Katrin Fischer  ---
We package the jQuery libraries - they should always be the same for everony on
a specific Koha version. Which is your exact 18.11.x verson? (what's the x? you
can find the information on the about page)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25304] Some of the markup needs to be corrected

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25304

Katrin Fischer  changed:

   What|Removed |Added

Summary|Some of the mark needs to   |Some of the markup needs to
   |be corrected|be corrected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25305] Double UTF-8 encoding on translation files

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_20_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103800|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 103880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103880=edit
Bug 25294: Don't show deletion button if user can't delete suggestions

This patch adds logic to the OPAC suggestions template so that when the
OPACViewOthersSuggestions system preference is enabled and the logged-in
user is viewing other users' suggestions, the "Delete selected" button
is only displayed when there are suggestions the user can delete.

To test you should have suggestions in your system from at least two
users.

- Set the OPACViewOthersSuggestions preference to "Show"
- Log in to the OPAC as a user who hasn't submitted any suggestions
- Go to the suggestions page (with "?suggested_by_anyone=1" appended to
  the URL if necessary, see Bug 22515).
- In the table of suggetions, there should be no titles with a checkbox
  in the first column.
- At the bottom of the table there should be no "Delete selected"
  button.

- Log in to the OPAC as a user with suggestions.
- Return to the suggestions page and view all suggestions.
- There should be titles with corresponding checkboxes and the "Delete
  selected" button should appear at the bottom.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25294] Don't show deletion button if user can't delete suggestions

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25294

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103822|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 103879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103879=edit
Bug 25299: Show soon to expire patron date

This patch fixes the call to show the patron expiry date
on the Details page when the patron is soon to expire.

Test plan:
0. Do not apply patch yet
1. Create a patron
2. Set patron's date expiry to 3 days from today
3. Go to Details tab
4. Note message "Expiration: Patron's card will expire soon.
Patron's card expires on Renew or Edit details"
5. Apply patch
4. Note message pattern "Expiration: Patron's card will expire soon.
Patron's card expires on XX/XX/ Renew or Edit details"

Signed-off-by: Frédéric Demians 
Without this patch the dispay was incomplete on patron detail tab

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299

--- Comment #5 from Katrin Fischer  ---
Good catch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103821|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 103878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103878=edit
Bug 25300: Fix typo in "Edit details" for expiring/expired patron

This patch removes a typo in the argument to the "op" parameter
for the "Edit details" link when editing an expiring/expired patron
on the Details page.

Test plan:
0. Do not apply patch yet
1. Create patron
2. Set expiry date to 3 days from now
3. Go to Details tab in patron record
4. Click "Edit details" in "Library use" section
5. Note the form is blank and has no patron data in it
6. Apply the patch
7. Reload the Details page in patron record
8. Click "Edit details" in "Library use" section
9. Note the form now contains your patron data and will
work for editing the details

Signed-off-by: Frédéric Demians 
See the typo, the bug before/after

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103841|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 103877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103877=edit
Bug 25002: JS Includes should be wrapped with template comments

This patch adds HTML comments to Template::Toolkit include files which
contain 

[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are caused by OPACUserJS/IntranetUserJS

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|25002   |
 Depends on||25002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002
[Bug 25002] JS Includes should be wrapped with template comments
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||25003
 Depends on|25003   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003
[Bug 25003] Clearly identify when JavaScript errors are caused by
OPACUserJS/IntranetUserJS
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25306] Unnecessary update of framework in ModBiblioMarc

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25306] Unnecessary update of framework in ModBiblioMarc

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306

--- Comment #1 from Nick Clemens  ---
Created attachment 103876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103876=edit
Bug 25306: Remove framework paramter from ModBiblioMarc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25306] New: Unnecessary update of framework in ModBiblioMarc

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306

Bug ID: 25306
   Summary: Unnecessary update of framework in ModBiblioMarc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

All calls to this function are either passing the framework obtained from the
bib, or precede or are preceded by a bib modification which sets the framework
code.

We do not need this parameter in this function

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25306] Unnecessary update of framework in ModBiblioMarc

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25305] Double UTF-8 encoding on translation files

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Depends on||24217, 24365
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |
   Patch complexity|--- |Trivial patch
   Severity|enhancement |normal


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217
[Bug 24217] use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365
[Bug 24365] Using strict from TmplTokenizer.pm broke the translator script
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24217] use strict for all modules

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks||25305


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305
[Bug 25305] Double UTF-8 encoding on translation files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks||25305


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305
[Bug 25305] Double UTF-8 encoding on translation files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >