[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104334|0 |1 is obsolete|| --- Comment #400 from Aleisha Amohia --- Created attachment 104336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104336=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104333|0 |1 is obsolete|| --- Comment #399 from Aleisha Amohia --- Created attachment 104335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104335=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104329|0 |1 is obsolete|| --- Comment #398 from Aleisha Amohia --- Created attachment 104334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104334=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104326|0 |1 is obsolete|| --- Comment #395 from Aleisha Amohia --- Created attachment 104331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104331=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104328|0 |1 is obsolete|| --- Comment #397 from Aleisha Amohia --- Created attachment 104333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104333=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104327|0 |1 is obsolete|| --- Comment #396 from Aleisha Amohia --- Created attachment 104332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104332=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104325|0 |1 is obsolete|| --- Comment #394 from Aleisha Amohia --- Created attachment 104330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104330=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104247|0 |1 is obsolete|| --- Comment #390 from Aleisha Amohia --- Created attachment 104326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104326=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104249|0 |1 is obsolete|| --- Comment #392 from Aleisha Amohia --- Created attachment 104328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104328=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104250|0 |1 is obsolete|| --- Comment #393 from Aleisha Amohia --- Created attachment 104329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104329=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104248|0 |1 is obsolete|| --- Comment #391 from Aleisha Amohia --- Created attachment 104327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104327=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104066|0 |1 is obsolete|| --- Comment #386 from Aleisha Amohia --- Created attachment 104322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104322=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104246|0 |1 is obsolete|| --- Comment #389 from Aleisha Amohia --- Created attachment 104325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104325=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104068|0 |1 is obsolete|| --- Comment #388 from Aleisha Amohia --- Created attachment 104324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104324=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104067|0 |1 is obsolete|| --- Comment #387 from Aleisha Amohia --- Created attachment 104323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104323=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #28 from David Cook --- Actually, in Jonathan's defence again, on Ubuntu 18.04 it wouldn't be a "nightly" method so much as a daily/every morning method when run in cron.daily, as it's set up to run at 6:25am out of the box. Maybe it should go in /etc/cron.d/koha-common instead with a better time defined. And then local admins can customize that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #53 from David Cook --- At the moment, I'm writing a new task scheduler in Golang for a plugin version of Bug 10662. Like the existing Perl version attached to Bug 10662, it closely couples the task scheduler and OAI-PMH harvester. In the Golang case, when the timer fires, a new thread is created to do a HTTP download of XML (which actually pipes the XML stream into another thread with a XML stream reader in it which concurrently parses and writes away the downloaded records). I am planning to give each task a thread to take those downloaded records and import them into Koha (via a Plugin API). But if I were to use a more generalized task scheduler... I'm not sure how I'd do it. If we did have a message queue, perhaps the download task would send the records to an API which would record them and then enqueue a RabbitMQ message to an import worker. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #52 from David Cook --- I've been thinking more about this recently. How to be all things to all people? For instance, the original Koha task scheduler for Bug 1993 was meant to schedule a report to run once at an absolute time and email the result to someone. Bug 25245 wants plugins to be able to run every night. That is, a periodic task that runs at the same time every day/night (while not being too fussed on exact start/end times). Bug 10662 wants to schedule tasks to run every X seconds. That is, a periodic task that runs X seconds after it last ran. Those are arguably 3 different types of schedules. The Celery project would handle that using ETA and Periodic Tasks: https://docs.celeryproject.org/en/stable/userguide/calling.html#eta-and-countdown https://docs.celeryproject.org/en/latest/userguide/periodic-tasks.html Looking at cron, we can see it just loops infinitely and sleeps for 1 minute at a time then checks what jobs need to run: https://github.com/cronie-crond/cronie/blob/master/src/cron.c#L358 In the past, I've used timers using Perl's POE or Golang's Timer to alert me when a job needs to start. That's fine so long as your process runs forever. You do need to persist the job data, so that if you restart you can re-create your timers. In terms of the actual implementation... lately I'm thinking a daemon with a HTTP API so you can create, retrieve, update, delete, start timer, stop timer. When a timer does fire... the daemon should add the task to a queue. (This is also what cron does https://github.com/cronie-crond/cronie/blob/master/src/cron.c#L589). Now that queue could be a RabbitMQ message queue. It could be an in-memory queue in the task scheduler daemon and it could run tasks itself by forking a child process, using a thread (if not Perl), or using a connected worker. It could be a database table. On that note, it becomes apparent to me that we don't need to depend on Bug 22417 to move forward here. The task scheduler can be a black box with an API for the front end, and then pluggable backends for different queue systems. Although as I say that I haven't thought it through enough. With a FIFO queue, we run into cron's limitation of not tracking execution of a task. As is, Bug 10662 scenario is impossible, because we don't have the result of the task to update the task with new data (ie new "from" date) and new time to schedule. With RabbitMQ, we can use message acknowledgements to determine when the task is completed. Celery also has a result store. But Bug 10662 would still be unique in that it's not really a periodic task but rather an absolute task that gets rescheduled. It looks like Celery does actually have callbacks that can be run on the result at the end of a task. That's interesting. That would be a good thing to develop. Arguably the Report Email functionality could make good use of that. The task would be to generate the report and store the result. The callback would then email it. In the case of Bug 10662, the callback could perhaps update the original task, enqueue a new one. I'd have to think more about that mechanism... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > I'd argue Bug 22417 tries to be too comprehensive, and that we'd be better > off just adding RabbitMQ and Net::Stomp as dependencies, and then doing a > light experimental implementation here. Actually, that wouldn't work. We would need a proper task scheduler. It's a nice idea in theory, but I don't think it's happening any time soon, so I'd say go with cron and try to solve this one in the future :/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #26 from David Cook --- (In reply to Tomás Cohen Arazi from comment #23) > (In reply to Kyle M Hall from comment #22) > > (In reply to Jonathan Druart from comment #21) > > > I have the feeling that this should have been implemented on top of bug > > > 22417 (with bug 1993 in mind). > > > > Is there any reason this cannot be updated to use the functionality of those > > bugs once they've been taken care of? It doesn't look like there is a > > definite end in site for them. > > I agree here. Bug 22417 is a longer shot IMHO. I agree with everyone in a way. I've spent years talking about and working on task scheduler functionality for Koha, and I don't think it's happening any time soon. Cron is a well-established familiar task scheduler that can do a good enough job. I'd argue Bug 22417 tries to be too comprehensive, and that we'd be better off just adding RabbitMQ and Net::Stomp as dependencies, and then doing a light experimental implementation here. However, even if we had only 1 worker consuming from RabbitMQ, that's another process to manage. It adds new administrative overhead and fragility that we don't have by continuing to use cron. Frido also made a good point back in Portland about queue based task schedulers (like the one I wrote). From a vendor point of view, you might not want all your Koha instances running their background jobs at the same time. If those background jobs use APIs, you might end up hitting rate limits for instance. Or if you're sending out lots of emails, you might get flagged as a spammer. So it becomes prudent for vendors to be able to stagger background jobs on a server. Of course, that criticism applies to using cron.daily for background jobs too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #25 from David Cook --- (In reply to Jonathan Druart from comment #24) > The main inconvenient of this implementation is that the time the job will > start is not configurable. That's true although that's a criticism I have of many of the daily cronjobs. (We're switching over more to using the Koha Debian packages, and noticed one of the gaps between it and our custom installs is the inflexibility of the cronjobs out of the box.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #63 from David Cook --- (In reply to Julian Maurice from comment #8) > Won't that be a problem if people want to publish their plugins on CPAN ? I've been thinking about this more, and while I was skeptical at first... I actually kind of like the idea now. For vendors, it could be easier to provide plugins via the system rather than at an instance basis. Coupled with a whitelist or some other "enable/disable" system per instance, it could make plugin management easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890 --- Comment #9 from David Cook --- I like all those ideas, Katrin. Bug 24632 would allow installation of only plugins signed by trusted providers. Bug 25370 would allow installation of only plugins with certain package names. Turning off manual plugin uploads might also be a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25370] Create whitelist of plugins allowed to be installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #1 from David Cook --- I am thinking the whitelist would contain an entry like "Koha::Plugin::Com::ByWaterSolutions::CSV2MARC". However, another plugin could pretend to be that same one. A malicious plugin could pretend to be a popular plugin and thus defeat the whitelist. With Bug 24632, that would be far less likely. You could set up your plugin keys so that only Bywater Solutions is trusted, and then only "Koha::Plugin::Com::ByWaterSolutions::CSV2MARC" is allowed on the whitelist. It is still possible to have collisions if you trust more than one provider and they use the same name, but that is unlikely due to the naming conventions Kyle created from the start. Different vendors should use their company names like "Koha::Plugin::Com::ProsentientSystems::OaiHarvester" (which one day I hope to be a real thing). Plus, if we did start using vendor/community Github/Gitlab as repositories, we could potentially limit the likelihood of people sourcing plugins from obscure locations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25370] New: Create whitelist of plugins allowed to be installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 Bug ID: 25370 Summary: Create whitelist of plugins allowed to be installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org This feature would provide a whitelist of plugins that are allowed to be installed in Koha. This whitelist would be managed by some kind of administrator*. This feature coupled with Bug 24632 would allow Koha users to only installed certain authentic plugins from trusted providers. (*I've been thinking that a superlibrarian really should be able to configure all aspects of Koha. However, from a vendor perspective, there are quality of service and security risks that comes with that. So perhaps the administrator level should be configurable. Defaulting to superlibrarian but optionally being switched to backend sysadmin for vendors, so that they can have ultimate say, when running on their own hardware.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22832] Require plugins to specify the methods they implement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Tomás Cohen Arazi from comment #0) > I think plugins should just expose what methods they implement that are > intended to be used in Koha, not any internal method. Agreed. That would make it much easier to manage plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25130] Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25130] Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 ByWater Sandboxes changed: What|Removed |Added Attachment #104320|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 104321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104321=edit Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24903] Special characters like parentheses in numbering pattern cause duplication in recievedlist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #12 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25038] OPAC reading history checkouts and on-site tabs not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #8 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #21 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25050] Elasticsearch - authority indexing depends on mapping order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25050 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #21 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #23 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25095] Remove warn left in FeePayment.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25095 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #5 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25069] AddressFormat="fr" behavior is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #6 from Joy Nelson --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25005] Admin Rights issue for Suggestion to Purchase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #6 from Joy Nelson --- does not apply to 19.11.x cleanly. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #23 from Joy Nelson --- unit test patch does not apply to 19.11.x Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #64 from David Nind --- Changed status backed to signed off - patch now applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #7 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22937] Searching by library groups uses group Title rather than Description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22937 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #12 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23514] Call numbers are not splitted in Label Creator with layout types other than Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23514 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com --- Comment #15 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #46 from Joy Nelson --- does not apply to 19.11.x branch please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24840] Datetime issues in automatic_renewals / CanBookBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #10 from Joy Nelson --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #31 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #30) > (In reply to Tomás Cohen Arazi from comment #29) > > Have you thought of using some sort of semaphore, like adding a column to > > authority records: 'waiting_merge' and act depending on its value? > > Waiting merge = record in needs_merge with done = 0. Kind of the same. We > can allow a merge of something that waits for a merge. But we must be > careful. Thats the crux of this patch set. I didn't spot that by only reading the patch. I should've applied it and looked at it in context. Sorry for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #30 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #29) > Have you thought of using some sort of semaphore, like adding a column to > authority records: 'waiting_merge' and act depending on its value? Waiting merge = record in needs_merge with done = 0. Kind of the same. We can allow a merge of something that waits for a merge. But we must be careful. Thats the crux of this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25130] Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25130] Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 --- Comment #1 from David Roberts --- Created attachment 104320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104320=edit Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 104319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104319=edit Bug 25327: Do not call authenticate_api_request to render the spec The original code for Koha::REST::V1::Auth::under called authenticate_api_request when requesting the API spec. This didn't make sense, and recent changes on what conditions are tested for public routes, broke the route. We could add another condition, but it really doesn't make sense to call authenticate_api_request if it should be publicly available in any configuration, as discussed on the bug. This patch adds a trivial check and the requested route, and lets the request through in any case in 'under'. To test: 1. Point your browser to: http://kohadev.myDNSname.org:8080/api/v1/ http://kohadev.myDNSname.org:8080/api/v1/.html => FAIL: In both cases you get an authorization error. 2. Apply the regression tests patch 3. Run: $ kshell k$ prove t/db_dependent/api/v1/auth.t => FAIL: The tests reflect the situation, and fail 4. Apply this patch 5. Repeat 1 and 3 => SUCCESS: All good! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 104318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104318=edit Bug 25327: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25082] Unknown language code if 041 $a is linked to an authorized value list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25082 --- Comment #10 from Katrin Fischer --- This should work like this: When you don't use AVs, it will display the descriptions from the XSLT file. If you are using AVs, it will display the descriptions of the AVs. Does that make sense? You should only see codes if you had entered a code that is neither in the XSLT nor in the AV list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25130] Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25368] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25368 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Ferguso |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25369] IntranetCoce not displaying Cover Images on Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25369] New: IntranetCoce not displaying Cover Images on Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369 Bug ID: 25369 Summary: IntranetCoce not displaying Cover Images on Staff Client Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The bug 18421, allowed for Coce images to be displayed on the Staff client. Unfortunately, there does seem to be some issues with the loading of this display. There was a comment on this bug describing what I am finding also, but I don't believe this was addressed or a new bug created. Steps to reproduce: 1. Turn on IntranetCoce 2. Search the staff side 3. Note that no images display on the brief results page. 4. Click on a link to a book and see (possibly) a cover image. If a cover image was seen, go back to the results page and now you will see that same cover image displayed in the brief results. 4. No other cover images are still displaying, just the 1 cover image from the record you clicked. 5. If you didn't see a cover image in #4 and should (meaning this cover image is seen on the OPAC), go back to results, and sometimes the cover image will show. 6. After several reloads of this page, the cover images do start to appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #11 from Victor Grousset/tuxayo --- ho là là ça marche! It works! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #104309|0 |1
is obsolete||
--- Comment #10 from Victor Grousset/tuxayo ---
Created attachment 104317
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104317=edit
Bug 25099: Sending a LANG variable to plug-in template
To make internationalised plug-ins, it may be useful to get the lang
from C4::Languages::getlanguage. This patch adds
C4::Languages::getlanguage result to a LANG variable which is sent to
the template plugin.
In your plugin, you can add a i18n directory containing
lang[-DIALECT].inc files with a TOKENS hash like this:
[%
TOKENS = {
PLUGIN_NAME = "Mannequin"
PRESENTATION = "Voici un example d'outil."
CLICK_ME = "Cliquez moi !"
}
%]
The plugin template can then include such a lang[-DIALECT].inc with a
hash containing all the plugin strings:
[% TRY %]
[% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %]
[% CATCH %]
[% PROCESS "$PLUGIN_DIR/i18n/default.inc" %]
[% END %]
The strings are then printed in the template with something like:
[% TOKENS.PRESENTATION %]
Test plan:
1. apply patch
2. install, enable and run BULAC Mannequin plugin
3. it should print stuff in english by default
4. install french French (fr-FR)
5. change you Koha lang to French
6. run again the plugin
7. ho là là! French!
Thanks to Tomàs Cohen and his pay via paypal plug-in from which most
ideas in this patch are taken.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #25 from Victor Grousset/tuxayo --- It didn't work and thanks to the patch it works! :D To next person testing and re-uploading the patches: I forgot to add in the test plan to run the following: prove t/db_dependent/SIP/* (not adding to not spam with email notification again) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #10 from David Roberts --- (In reply to Katrin Fischer from comment #7) > I think I'd make the display the same for checkouts an details in also > displaying git on top - but that's more a feeling. You are right in that it > displays on the page. > > I splitted this out of bug 21211, which was not reported by me, when fixing > the tool bars :) Hi Katrin - I hope this patch does what you want! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #102859|0 |1
is obsolete||
--- Comment #24 from Victor Grousset/tuxayo ---
Created attachment 104316
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104316=edit
Bug 23403: Catch other cases of ->{patron}
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #101456|0 |1 is obsolete|| --- Comment #23 from Victor Grousset/tuxayo --- Created attachment 104315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104315=edit Bug 23403: List borrowernumber in the ILS::Patron fields Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #101445|0 |1 is obsolete|| --- Comment #22 from Victor Grousset/tuxayo --- Created attachment 104314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104314=edit Bug 23403: Fix whitespace Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #101304|0 |1 is obsolete|| --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 104313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104313=edit Bug 23403: Remove cardnumber from SIP == Test plan == 1 - Have two patrons with userids and no cardnumber 2 - Note which of these has the higher borrower number 3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber See example after 4 - Note the book may checkout to the wrong patron! 5 - Apply patch 6 - Checkout to both patrons via sip 7 - The patrons get the correct checkouts === SIP CLI emulator === ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \ -l CPL --patron 23529001000463 -m checkout --item 301259 translation: via the koha user term1, checkout item 301259 to patron 23529001000463 Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #9 from David Roberts --- Created attachment 104312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104312=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. https://bugs.koha-community.org/show_bug.cgi?id=25118 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25118] Return claims has some translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #13 from David Roberts --- Whoops, sorry - I attached a patch to the wrong bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25118] Return claims has some translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118 David Roberts changed: What|Removed |Added Attachment #104311|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25118] Return claims has some translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118 --- Comment #12 from David Roberts --- Created attachment 104311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104311=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #8 from David Roberts --- I've changed the title of this bug as it has moved on from what was originally reported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts changed: What|Removed |Added Summary|Circulation notes only |Make circulation notes more |displays on checkouts tab, |prominent on the patron |but not on details |details tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #20 from Victor Grousset/tuxayo --- Wait, I had to user the user dedicated to sip. (term1 in koha-testing-docker) kohadev-koha@b5a2119a1209:/kohadevbox/koha$ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 -m checkout --item 301297 Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2020050415582620200504 155826AOCPL|AA2352935676|AB301297|ACterm1|BON|BIN| READ: 121NNY20200504155827AOCPL|AA2352935676|AB301297|AJDream of fair to middling women /|AH20200509235900| The testing continues! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19558] Link 130 uniform title authority record to 240 tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19558 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #19 from Victor Grousset/tuxayo --- > 3 - Use the SIP cli emulator to connect and checkout a book to the patron > with higher borrowernumber Should something like that do? I'm not sure I'm using well the emulator. And I barely know SIP to manually check whether the command is correct. ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l CPL --patron 2352935676 -m checkout --item 301297 Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2020050415462920200504 154629AOCPL|AA2352935676|AB301297|ACkoha|BON|BIN| Use of uninitialized value $data in concatenation (.) or string at ./misc/sip_cli_emulator.pl line 344, chunk 1. READ: https://gitlab.com/koha-community/Koha/-/blob/a6985d167e11eaafee985b51cb0188a693405af5/misc/sip_cli_emulator.pl#L344 Now, trying with telnet by copying the message to read the server response. kohadev-koha@b5a2119a1209:/kohadevbox/koha$ telnet localhost 6001 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. 9300CNkoha|COkoha|CPCPL| 941 11YN2020050415462920200504 154629AOCPL|AA2352935676|AB301297|ACkoha|BON|BIN| Connection closed by foreign host. That's rude! *pouts* Doing the same checkout via the UI work. - same koha librarian user (superlibrarian) - same barcode - same patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #29 from Tomás Cohen Arazi --- Have you thought of using some sort of semaphore, like adding a column to authority records: 'waiting_merge' and act depending on its value? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jaki changed: What|Removed |Added CC||jaki.fris...@leblibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Nicolas Legrand from comment #8) > I let the QA team decide if C4::Languages::getlanguage called from > Koha::Plugin::Base is legit or not :). That's not a problem, Nicolas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 --- Comment #8 from Nicolas Legrand --- I let the QA team decide if C4::Languages::getlanguage called from Koha::Plugin::Base is legit or not :). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25368] New: Ferguso
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25368 Bug ID: 25368 Summary: Ferguso Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: cukfergus...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 104310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104310=edit Ferguso Akwkwkkwkwk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 Nicolas Legrand changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099 Nicolas Legrand changed: What|Removed |Added Attachment #102644|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25099] Sending a LANG variable to plug-in template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25099
--- Comment #7 from Nicolas Legrand ---
Created attachment 104309
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104309=edit
Bug 25099: Sending a LANG variable to plug-in template
To make internationalised plug-ins, it may be useful to get the lang
from C4::Languages::getlanguage. This patch adds
C4::Languages::getlanguage result to a LANG variable which is sent to
the template plugin.
In your plugin, you can add a i18n directory containing
lang[-DIALECT].inc files with a TOKENS hash like this:
[%
TOKENS = {
PLUGIN_NAME = "Mannequin"
PRESENTATION = "Voici un example d'outil."
CLICK_ME = "Cliquez moi !"
}
%]
The plugin template can then include such a lang[-DIALECT].inc with a
hash containing all the plugin strings:
[% TRY %]
[% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %]
[% CATCH %]
[% PROCESS "$PLUGIN_DIR/i18n/default.inc" %]
[% END %]
The strings are then printed in the template with something like:
[% TOKENS.PRESENTATION %]
Test plan:
1. apply patch
2. install, enable and run BULAC Mannequin plugin
3. it should print stuff in english by default
4. install french French (fr-FR)
5. change you Koha lang to French
6. run again the plugin
7. ho là là! French!
Thanks to Tomàs Cohen and his pay via paypal plug-in from which most
ideas in this patch are taken.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25304] Some of the markup needs to be corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25304 Timothy Alexis Vass changed: What|Removed |Added Attachment #104302|0 |1 is obsolete|| --- Comment #6 from Timothy Alexis Vass --- Created attachment 104308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104308=edit Bug 25304: Some of the markup needs to be corrected To test: 1) Open an item in OPAC and see if everything works as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 --- Comment #16 from David Gustafsson --- @Marcel de Rooy Did not get the same error, are you sure you where in master when applying the patch? It did need rebasing though, so have now rebased against latest master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Attachment #104304|0 |1 is obsolete|| --- Comment #15 from David Gustafsson --- Created attachment 104307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104307=edit Bug 24823: Remove unused parameters Remove unused Elasticsearch parameters 'key_prefix' and 'request_timeout'. Refactor so that get_elasticsearch_params only returns parameters used by Search::Elasticsearch, add class accessor for index_name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Attachment #104303|0 |1 is obsolete|| --- Comment #14 from David Gustafsson --- Created attachment 104306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104306=edit Bug 24823: Fix spelling error and remove last of Catmandu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Attachment #100308|0 |1 is obsolete|| --- Comment #13 from David Gustafsson --- Created attachment 104305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104305=edit Bug 24823: Drop Catmandu dependency Replace remaining Catmandu dependant code with the Search::Elasticsearch equivalent. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t, t/Koha/SearchEngine/ElasticSearch/* and t/db_dependent/Koha/SearchEngine/* 3) All tests should pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Attachment #100617|0 |1 is obsolete|| --- Comment #12 from David Gustafsson --- Created attachment 104304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104304=edit Bug 24823: Remove unused parameters Remove unused Elasticsearch parameters 'key_prefix' and 'request_timeout'. Refactor so that get_elasticsearch_params only returns parameters used by Search::Elasticsearch, add class accessor for index_name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 David Gustafsson changed: What|Removed |Added Attachment #100337|0 |1 is obsolete|| --- Comment #11 from David Gustafsson --- Created attachment 104303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104303=edit Bug 24823: Fix spelling error and remove last of Catmandu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25304] Some of the markup needs to be corrected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25304 Timothy Alexis Vass changed: What|Removed |Added Attachment #104281|0 |1 is obsolete|| --- Comment #5 from Timothy Alexis Vass --- Created attachment 104302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104302=edit Bug 25304: Some of the markup needs to be corrected To test: 1) Open an item in OPAC and see if everything works as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What|Removed |Added Attachment #104299|0 |1 is obsolete|| --- Comment #8 from Timothy Alexis Vass --- Created attachment 104301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104301=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25367] New: Rename GetPlugins to search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25367 Bug ID: 25367 Summary: Rename GetPlugins to search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org This would bring us closer to a standard Koha::Object which is more familiar to end users. We could also perhaps remove the filtering by metadata as it doesn't appear to be used outside of tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104296|0 |1 is obsolete|| --- Comment #16 from Tomás Cohen Arazi --- Created attachment 104300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104300=edit Better tests... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23108] staffaccess permission can be easily circumvented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 --- Comment #4 from Andrew Fuerste-Henry --- Verified that this is still an issue in Master. I suggest we fix this by making StaffAccess required in order to change the borrower category of a borrower in a staff category. This is complicated by the fact that patron category is included in batch patron modification, unlike everything currently covered by StaffAccess, so we'd have to figure out how we want Koha to behave and report there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What|Removed |Added Attachment #104036|0 |1 is obsolete|| --- Comment #7 from Timothy Alexis Vass --- Created attachment 104299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104299=edit Bug 25302: The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent. To test: 1) Open an item in OPAC and see if it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
