[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

--- Comment #1 from David Cook  ---
Created attachment 104912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104912=edit
Bug 25510: Fix shell syntax for updating log4perl.conf for instances

This patch fixes the shell syntax when updating log4perl.conf
for instances.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25510

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24905

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] New: Typo in koha-common.postinst causing shell errors

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Bug ID: 25510
   Summary: Typo in koha-common.postinst causing shell errors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

When installing a custom Koha 19.11.05, I got the following error:

/var/lib/dpkg/info/koha-common.postinst: 155: [: !log4perl_component:
unexpected operator

I don't think we should be using the square brackets in that line at all and
should put a space between ! and log4perl_component.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #12 from David Cook  ---
I think that there's actually a typo in this that is causing minor errors.
Going to investigate more fully...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25485

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25509

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

--- Comment #1 from David Cook  ---
Created attachment 104911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104911=edit
Bug 25509: Remove useless libjs-jquery dependency

We don't use the libjs-jquery package, so we should remove
the dependency.

To Test:
1) Build package (out of scope of test plan)
2) Install package
3) Note that libjs-jquery is marked by apt as no longer required
4) Remove libjs-jquery package from system and note how it
doesn't take koha-common with it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104902|0   |1
is obsolete||

--- Comment #473 from Aleisha Amohia  ---
Created attachment 104910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104910=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104869|0   |1
is obsolete||

--- Comment #472 from Aleisha Amohia  ---
Created attachment 104909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104909=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104868|0   |1
is obsolete||

--- Comment #471 from Aleisha Amohia  ---
Created attachment 104908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104908=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104865|0   |1
is obsolete||

--- Comment #468 from Aleisha Amohia  ---
Created attachment 104905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104905=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104867|0   |1
is obsolete||

--- Comment #470 from Aleisha Amohia  ---
Created attachment 104907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104907=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104866|0   |1
is obsolete||

--- Comment #469 from Aleisha Amohia  ---
Created attachment 104906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104906=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104863|0   |1
is obsolete||

--- Comment #466 from Aleisha Amohia  ---
Created attachment 104903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104903=edit
Bug 19532: Database and installer stuff

- Add recalls table
- Add recalls circulation rules - recalls allowed, recalls per record, on shelf
recalls, recall due date interval, recall overdue fine, recall shelf time
- Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog
- Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM)
- Add print notice (RECALL_REQUESTER_DET)
- Add user permission - recalls, manage_recalls
- Add Recall and CancelRecall enum options for branchtransfers reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104864|0   |1
is obsolete||

--- Comment #467 from Aleisha Amohia  ---
Created attachment 104904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104904=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] New: Remove useless libjs-jquery dependency

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

Bug ID: 25509
   Summary: Remove useless libjs-jquery dependency
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

We have a dependency on libjs-jquery for the Debian packages, but it appears to
be unused.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

--- Comment #11 from Victor Grousset/tuxayo  ---
(In reply to David Cook from comment #5)
> And we're requiring Debian's libjs-jquery package too, although I don't
> think that actually gets used anywhere?

git grep "/usr/share/" | grep -vE
"/usr/share/koha|/usr/share/perl5|/usr/share/fonts|/usr/share/debconf|/usr/share/doc/koha"

IIUC, nothing to worry about :D


Makefile.PL:push @version, ('/usr/share/perl/5.10') if !$version[0];
debian/copyright: /usr/share/common-licenses/GPL-3 .
debian/koha.config:if [ -f /usr/share/dbconfig-common/dpkg/config.mysql ]; then
debian/koha.config: . /usr/share/dbconfig-common/dpkg/config.mysql 
debian/koha.postinst:. /usr/share/dbconfig-common/dpkg/postinst.mysql 
debian/koha.postrm:if [ -f /usr/share/dbconfig-common/dpkg/postrm.mysql ]; then
debian/koha.postrm:. /usr/share/dbconfig-common/dpkg/postrm.mysql
debian/koha.prerm:. /usr/share/dbconfig-common/dpkg/prerm.mysql 
debian/rules:   ln -s /usr/share/tinymce/www \
debian/rules:  
/usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from David Cook  ---
Actually, I'll do more testing without my changes... going back to "Needs
Signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from David Cook  ---
(In reply to Kyle M Hall from comment #1)
> Test Plan:
> 1) Install Koha 19.11 from package
> 2) Browse to the news editor
> 4) Note the WYSIWYG editor is missing
> 5) Build a new Koha package with this patch applied, install it
> 6) Reload the news editor
> 7) Note the WYSIWYG editor is back!

As I noted above, I found this wasn't a sufficient test plan.

I did something like this:

0) Applied Kyle's patch + manually updated debian/control and removed a
questionable line in debian/rules
1) Built the koha-common package
2) Unlinked /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce in my
target environment
3) Installed (ie upgraded) Koha package
4) Noted the WYSIWYG editor is back!

So... not sure this one is quite there yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

--- Comment #8 from David Cook  ---
(In reply to David Cook from comment #7)
> Comment on attachment 104849 [details] [review]
> Bug 25485: TinyMCE broken in Debian package installs
> 
> Review of attachment 104849 [details] [review]:
> -
> 
> ::: debian/rules
> @@ +23,3 @@
> > rm $(TMP)/var/log/koha/README
> > rm -r \
> > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce
> 
> At a glance, it looks like this should cause a problem? But maybe I'm
> misreading the rules file.

So I removed that rule in my test, but that also meant the existing symlink
didn't get removed... so I had to unlink the symlink and then reinstall the
koha-common package...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

--- Comment #7 from David Cook  ---
Comment on attachment 104849
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104849
Bug 25485: TinyMCE broken in Debian package installs

Review of attachment 104849:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=25485=104849)
-

::: debian/rules
@@ +23,3 @@
>   rm $(TMP)/var/log/koha/README
>   rm -r \
>   $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce

At a glance, it looks like this should cause a problem? But maybe I'm
misreading the rules file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

--- Comment #6 from David Cook  ---
(In reply to Kyle M Hall from comment #1)
> Test Plan:
> 1) Install Koha 19.11 from package
> 2) Browse to the news editor
> 4) Note the WYSIWYG editor is missing
> 5) Build a new Koha package with this patch applied, install it
> 6) Reload the news editor
> 7) Note the WYSIWYG editor is back!

I don't think that this test plan is 100% sufficient, but it is a hard one to
explain well...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25481] koha-plack not working under D10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25481] koha-plack not working under D10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481

--- Comment #7 from Victor Grousset/tuxayo  ---
I'm getting this error.

> root@32f1d65b48bc:kohadevbox$ koha-plack --restart kohadev
> start-stop-daemon: user 'kohadev-koha.kohadev-koha' not found
> [FAIL] Error: Plack not running for kohadev: failed!

Extract of my /etc/passwd file
kohadev-koha:x:1000:1000:Koha instance
kohadev-koha,,,:/var/lib/koha/kohadev:/bin/bash

My dev env is
export KOHA_IMAGE=master-buster ; ku

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22865] Add authorities to a list

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22865

verolencinas  changed:

   What|Removed |Added

 CC||verolenci...@yahoo.com.ar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25481] koha-plack not working under D10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481

--- Comment #5 from David Cook  ---
(In reply to Jonathan Druart from comment #2)
> Since D10, the behaviour of start-stop-daemon changed, see from its
> manual:
> """
> Warning:  using this match option with a world-writable pidfile or using it
> alone with a daemon that writes the pidfile as an unprivileged (non-root)
> user will be refused with an error (since
> version 1.19.3) as this is a security risk, because either any user can
> write to it, or if the daemon gets compromised, the contents of the pidfile
> cannot be trusted, and  then  a  privileged
> runner (such as an init script executed as root) would end up acting on any
> system process.  Using /dev/null is exempt from these checks.
> """

Oh right... that makes sense. Nevermind me... 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25481] koha-plack not working under D10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481

--- Comment #6 from David Cook  ---
(In reply to Jonathan Druart from comment #2)
> Since D10, the behaviour of start-stop-daemon changed, see from its
> manual:
> """
> Warning:  using this match option with a world-writable pidfile or using it
> alone with a daemon that writes the pidfile as an unprivileged (non-root)
> user will be refused with an error (since
> version 1.19.3) as this is a security risk, because either any user can
> write to it, or if the daemon gets compromised, the contents of the pidfile
> cannot be trusted, and  then  a  privileged
> runner (such as an init script executed as root) would end up acting on any
> system process.  Using /dev/null is exempt from these checks.
> """

Oh right... that makes sense. Nevermind me... 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25481] koha-plack not working under D10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
Haven't looked into this in Koha but just a bit of Googled info on
start-stop-daemon:

Jessie: 1.17.27
https://manpages.debian.org/jessie/dpkg/start-stop-daemon.8.en.html

Stretch: 1.18.25
https://manpages.debian.org/stretch/dpkg/start-stop-daemon.8.en.html

Buster: 1.19.7
https://manpages.debian.org/buster/dpkg/start-stop-daemon.8.en.html

Ubuntu 18.04 (based off buster/sid): 1.19.05
http://manpages.ubuntu.com/manpages/bionic/man8/start-stop-daemon.8.html

Issue introduced in 1.19.3?
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921557

Claimed to be fixed in 1.19.5 in February though...

Jonathan, could you report on what version of dpkg is installed in your test
environment? Might be that the update hasn't flowed to the Docker images you're
using.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #4)
> This is amazing.

I know, right?

I've often wondered why we used Debian's tinymce package. I think we used to do
the same thing with the yui Javascript. 

And we're requiring Debian's libjs-jquery package too, although I don't think
that actually gets used anywhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #104870|0   |1
is obsolete||

--- Comment #465 from Aleisha Amohia  ---
Created attachment 104902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104902=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339

--- Comment #7 from David Cook  ---
(In reply to Jonathan Druart from comment #6)
> Why did you pick those 2 scripts? And why only biblionumber?
> 

Wise questions. They were flagged by a security consultant, so I fixed them
locally, and posted the patches here to be upstreamed.

> If you want to fix this problem (it is not really an issue imo), you should
> do it all over the place, where we retrieve a variable that is supposed to
> be an id and we send it back to the template. I am pretty sure there are
> others.
> 

As you say, it's not really a (critical) issue, as we've got the XSS risk
handled by the templates. Imho, it's just a bit embarrassing that we don't
validate the data more - but not problematic per se. 

That said, I don't see an issue with patching it in some places and not all
places. (After all, previous efforts by Jared seem to have only patched it in
some places and not all places.)

I agree that there are certainly other places where this happens too. 

> That being said, I don't see biblionumber passed to the template from
> opac-review.pl.

Good catch! The reason is actually rather amusing. It appears Bug 25340 (a bug
I reported the same day as this one but Owen fixed) removed the biblionumber
issue from opac-review.pl as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #24 from Andrew Fuerste-Henry  ---
Oh, I should mention that in the course of your test plan I ran into an
unrelated error. Confirmed it happens without your patch, filed bug 25508 for
it. At step 5 of test 2, when you pay off the fine, Koha gets weird about
whether or not it should renew the overdue item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

--- Comment #18 from David Cook  ---
(In reply to Jonathan Druart from comment #17)
> Related bug removed it

Thanks, Jonathan. I was looking at a slightly out of date 19.11 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Cannot change owner of list

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #7 from David Cook  ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to David Cook from comment #5)
> > Since they have full access to the SQL reporting, they
> > already have full access to that data, so the privacy issue is a bit moot. 
> 
> Agreed. But it may be a matter of Does the system facilitate crossing such
> privacy borders? The reporting backdoor is a subject on itself ;)

Those are good points too heh.

I think in that case maybe private lists should be absolutely private, but
public lists should be able to have owners changed by superlibrarians. 

Shared lists... well I don't quite understand the concept of shared lists yet
(neither from the user or technical perspective), although I think I get what
you'd mean by disowning a list in that context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485

--- Comment #4 from Tomás Cohen Arazi  ---
This is amazing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

--- Comment #6 from Tomás Cohen Arazi  ---
Jonathan, I didn't manage to make things work on JSON::Validator 0.97. I give
up on this one.

Lets discuss using local::lib as everyone else, and bundle our dependencies...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25473] Can't add order from MARC file, save button does nothing

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473

--- Comment #4 from Victor Grousset/tuxayo  ---
After testing.

== Good news ==
No more JS errors :D


== Some things couldn't be tested. ==

> Item information tab: Cataloging plugins for fields like
date acquired, barcode

- date acquired ok
- barcode: nothing happens, no error. Does it depends on other data/config?

> Default accounting details tab: Show inactive control

I couldn't find how to make a fund inactive ^^"


== Bad news ==
test plan of comment 0 fails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25072] Printing details.tt is broken

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06.
released in||19.05.11

--- Comment #10 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25299] Date not showing on Details page when patron is going to expire

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable

--- Comment #9 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25300] Edit details in "Library use" section uses bad $op for Expiration Date

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25291] Barcode should be escaped everywhere in html code

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25291

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
doesnt apply cleanly to 19.05.x, if needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25235] Don't alert when replacing an authority record via Z39.50

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25235

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
enhancement will not be backported to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17232] When creating a new framework from an old one, several fields are not copies (important, link, default value, max length, is URL)

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15234] Gateway Timeout in z3950_search.pl when a Z39.50 query is performed against a large group of targets.

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
Yeah you might want to see if you can change the apache timeout on that path.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #4)
> The use of $validator->bundle breaks Stretch

It is always falling back to the catch block in stretch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of Sale page

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
Bug 24525 depends on bug 24339, which changed state.

Bug 24339 Summary: SIP codes are missing from the default payment_types on 
installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338
Bug 24338 depends on bug 24339, which changed state.

Bug 24339 Summary: SIP codes are missing from the default payment_types on 
installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #25 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Tomás Cohen Arazi  ---
The use of $validator->bundle breaks Stretch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23081] Make items.issues and deleteditems.issues default to 0 instead of null

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #24 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #33 from Victor Grousset/tuxayo  ---
(In reply to Martin Renvoize from comment #16)
> I'm afraid we cannot yet use the 'IF EXISTS' syntax here as we are
> maintaining support for Jessie up to the end of it's LTS date (2020-06-30).
> I intend to drop support for that Debian version at the release of 20.05 (at
> which time I believe we should also drop support for it from 19.11  at
> 19.11.06 and 19.05 at 19.05.12).
> 
> However, even once we have dropped such support, unless I am mistaken,
> stretch is still stuck at MySQL 5.5 (though it recommends MariaDB instead. 
> As such, we'll need a clear deprecation of mysql 5.5 support outlined and
> publicised before we can make this change.

My second test of the above comment seems to show that MySQL 5.5 is already not
supported in our case.
I'm just spinning up a Koha with MySQL 5.5 and run koha-remove then it fails on
a syntax error mentioning IF EXISTS.

So, should we still avoid IF EXISTS?(I don't have the big picture)
In this case it doesn't look like it will break anything new for anyone. "Just"
breaking a second thing when using koha-remove.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25508] New: Confusing renewal message when paying accruing fine

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508

Bug ID: 25508
   Summary: Confusing renewal message when paying accruing fine
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off
2 - Checkout an item to a patron and make it overdue (can backdate the
checkout)
3 - Make sure the itemtype has fines that will be charged
4 - Charge the fines:
 Set finesMode = production
 perl misc/cronjobs/fines.pl -v
5 - Check the fine appears on the patrons account
6 - Pay off the fine
7 - Receive alert after payment that reads: "The fines on the following items
were paid off, renewal results are displayed below:
No title ( ): Not renewed - Unknown error"

Looks like we're not properly hiding that alert when RenewAccruingItemWhenPaid
is off? So it's reporting that nothing was renewed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #32 from Victor Grousset/tuxayo  ---
== 1 ==
I might had issues related to bug 25482 because my dev env was Debian 10
(koha-testing-docker ku-md10)
Which could explain cause koha-plack to not work which would cause issue to
stop the instance.

Actually only Apache processes are still there when doing koha-remove.
With koha-disable, no errors and starman and Apache processes are still there.

== 2 ==
So I tried with Debian 9 + MySQL 5.5 (koha-testing-docker ku)
And now I get this issue.

> root@b92acf73a243:kohadevbox$ koha-remove kohadev
> Removing Koha instance kohadev
> ERROR 1064 (42000) at line 1: You have an error in your SQL syntax;
> check the manual that corresponds to your MySQL server version for
> the right syntax to use near 'IF EXISTS `koha_kohadev`@`%`' at line 1

== 3 ==
So I tried with Debian 9 + MariaDB (from it's repos) (koha-testing-docker
ku-md9)
Same error as with Debian 10. Processes still here.

> userdel: user kohadev-koha is currently used by process 839
> /usr/sbin/deluser: `/usr/sbin/userdel kohadev-koha' returned error code 8. > 
> Exiting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #104842|0   |1
is obsolete||

--- Comment #23 from Andrew Fuerste-Henry  ---
Created attachment 104901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104901=edit
Bug 8338: Remove zero amount overdues on backdated returns where appropriate

This patch removes any overdues which would be reversed on a backdated
return if CalcFineOnBackdate is enabled and the user has not already
attempted to pay off the accruing fine.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #104841|0   |1
is obsolete||

--- Comment #22 from Andrew Fuerste-Henry  ---
Created attachment 104900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104900=edit
Bug 8338: Unit Tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

--- Comment #21 from Andrew Fuerste-Henry  ---
This looks good except for one extremely minor quibble -- the acount_offsets
entry for the credit created in test 2 shows type "Manual credit," which is
misleading on a credit generated automatically by the system. Signing off
anyway, but would love to see that changed to "system-generated credit" or
something more accurate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24750] Instructor search does not return results if a comma is included after surname or if first name is included

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24750

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #13 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text"

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11

--- Comment #18 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15234] Gateway Timeout in z3950_search.pl when a Z39.50 query is performed against a large group of targets.

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

--- Comment #6 from Katrin Fischer  ---
What I meant is that there is no setting in Koha - this is probably more about
your server configuration. 

I'll add some others in hope they will be able to give more insight.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25211] Missing share icon on OPAC lists page

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable

--- Comment #13 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15234] Gateway Timeout in z3950_search.pl when a Z39.50 query is performed against a large group of targets.

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234

Manos PETRIDIS  changed:

   What|Removed |Added

Summary|Administrative interface|Gateway Timeout in
   |timeout |z3950_search.pl when a
   ||Z39.50 query is performed
   ||against a large group of
   ||targets.

--- Comment #5 from Manos PETRIDIS  ---
As "Cataloging" is only available at the administrative interface and not the
OPAC -as far as I know- I used the term "administrative" in the original title.
I have updated the title to "Gateway Timeout in z3950_search.pl when a Z39.50
query is performed against a large group of targets" as to better reflect the
malfunction.

I have already set timeouts on all target entries in z3950servers table, but
the mere fact that the problem does not arise unless one tries to query a large
number of servers shows that it is not a matter of specific servers not timing
out, but that koha(?) has a total timeout limit set somewhere. It may well be a
matter of configuration as you wrote, but then what is the appropriate system
preference to amend so that no such timeout occurs. 

You have set the status to "Resolved Invalid". Have you tried to recreate the
error conditions and discovered that no such error manifests itself in a stock
koha configuration?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable

--- Comment #12 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25274] JavaScript error in OPAC cart when more details are shown

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25118] Return claims has some translation issues

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #15 from Lucas Gass  ---
Missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25224] Add "Large Print" from 008 position 23 to default XSLT

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25224

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483

--- Comment #8 from Katrin Fischer  ---
I've tested in 17.11 and it works, but only 'by accident' because the browser
ignores the very invalid HTML it creates:

Link to the
resource">  Link to the
resource

The change on master is:

https://cve-grics-ca.proxy.collanaud.qc.ca/fr/1133/33191'%3ELink%20to%20the%20resource%3C/a%3E">Link
to resource

We are now escaping the content entered in $u.

I feel we need a better, different way than adding HTML to this field to be
able to specify a link text. Is there a separator we could use?

url | linktext ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15234] Administrative interface timeout

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|REOPENED|RESOLVED

--- Comment #4 from Katrin Fischer  ---
I don't think what you report is related to a Koha session timeout. I think you
reach a timeout set on the server when things take too long. I am closing this
as the original bug title is not quite right and it looks like a configuration
issue. You might want to set timeouts in the configuration of your Z39.50
server to avoid this kind of issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25400] Circulation and fine rules cloning from one table to another does not copy "current checkouts allowed"

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Attachment #104654|0   |1
is obsolete||

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
Created attachment 104899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104899=edit
Bug 25400: [< 20.05] Fix cloning of circulation rules

This patch is for 19.11 and anterior versions.

The clone functionnality does not clone the "already moved rules"
maxissueqty and maxonsiteissueqty.

Test plan:
Clone some circ rules from one branch to another
Confirm that all the rules have been copied correctly

Signed-off-by: Bernardo Gonzalez Kriegel 
Tested on 19.11, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25400] Circulation and fine rules cloning from one table to another does not copy "current checkouts allowed"

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25505] SPAM

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25505

Katrin Fischer  changed:

   What|Removed |Added

  Alias|ganss, Sxtn |
URL|http://sxtn.com |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25505] SPAM

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25505

Katrin Fischer  changed:

   What|Removed |Added

 Hours Left|2020.00 |0.00
 Resolution|--- |INVALID
Summary|2020|SPAM
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25278] Search fields cache must be separate for different indexes under Elasticsearch

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #10 from Victor Grousset/tuxayo  ---
Applied only the tests; ran => failed
Then applied the fix => passed :D

(also looked at the code, nothing wrong noticed, though not much was understood
^^")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016

David Nind  changed:

   What|Removed |Added

  Text to go in the||This patch improves the
  release notes||display of cover images
   ||where Coce is enabled and
   ||Amazon is a source. Where
   ||the image from Amazon is a
   ||1x1 pixel placeholder
   ||(meaning Amazon has no
   ||image) it is no longer
   ||displayed.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25278] Search fields cache must be separate for different indexes under Elasticsearch

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #103700|0   |1
is obsolete||

--- Comment #7 from Victor Grousset/tuxayo  ---
Created attachment 104896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104896=edit
Bug 25278: Unit tests

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25278] Search fields cache must be separate for different indexes under Elasticsearch

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #103699|0   |1
is obsolete||

--- Comment #8 from Victor Grousset/tuxayo  ---
Created attachment 104897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104897=edit
Bug 25278: Retrieve correct search fields for authorities

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25278] Search fields cache must be separate for different indexes under Elasticsearch

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25278

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #103793|0   |1
is obsolete||

--- Comment #9 from Victor Grousset/tuxayo  ---
Created attachment 104898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104898=edit
Bug 25278: (follow-up) Fix other occurrences

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25482] Wrong permissions in spec break Plack on Debian 10

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25186] Lots of white space at the bottom of each tab on columns configuration

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25186

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24994] TableExists should be used instead of IF NOT EXISTS in updatedatabase

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #104846|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 104895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104895=edit
Bug 24994: Correct DB Updates

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24994] TableExists should be used instead of IF NOT EXISTS in updatedatabase

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24994

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #104884|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 104894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104894=edit
Bug 25504: Crash with the original error if API spec are invalid

Bug 24700 put the whole spec validation into a try catch block that
hides the original error raised by the JSON validator.

If you don't have the patches from bug 25482 and start plack under D10
you will see a huge stacktrace with, lost in the middle:
Koha::REST::V1::catch {...} ("Duplicate keys not allowed, at character
offset 4789 (before "...) called at /usr/share/perl5/Try/Tiny.pm line 123
The complete output is at bug 25482 comment 11.

With this patch, you will get a single line:
Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application
from file "/kohadevbox/koha/api/v1/app.pl": Duplicate keys not allowed, at
character offset 4789 (before "editcatalogue": "cre...") at
/usr/share/perl5/Mojo/JSON.pm line 39.

I am all for stacktraces, but not if the error is hidden ;)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24768] "Return claims" column is missing from column configuration page

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24768

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Lucas Gass  ---
Dependency is missing for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25123] MaxFines does not count the current updating fine

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25123

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #18 from Lucas Gass  ---
Tried to rebase tests for 19.05 but cannot make them pass, skipping this one
for 19.05.x, if it is needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14369] Only show 'Create labels' link on staged records import when status is 'Imported'

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #12 from Lucas Gass  ---
doesn't apply to 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20484] Always show Elasticsearch configuration page when permission is set

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20484

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #12 from Lucas Gass  ---
enhancement will not be backported to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13557] Add hint for on-site checkouts to list of current checkouts in OPAC

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13557

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21211] Patron toolbar does not appear on all tabs in patron account in staff

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21211

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com

--- Comment #13 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18680] sort1/sort1 dropdowns (when mapped to authorized value) have no empty entry

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18680

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11
 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #9 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT and DisplayIconsXSLT descriptions should be clearer

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.11

--- Comment #17 from Lucas Gass  ---
backported to 19.05.x for 19.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor

2020-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >