[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Depends on|25068 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook changed: What|Removed |Added Blocks|25510 | Severity|major |critical --- Comment #6 from David Cook --- Upping this one to critical as you can't build packages until it's fixed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook changed: What|Removed |Added Blocks||25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Depends on||25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #15 from Aleisha Amohia --- Rebased, but still super stuck on that whitespace! Owen, any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia changed: What|Removed |Added Attachment #101783|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 104998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104998=edit Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #28 from David Cook --- Created attachment 104997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104997=edit Bug 25485: Remove tiny_mce symlink during pre install of deb package This patch removes the tiny_mce symlink before Koha package installation using the same method that we used when we removed the YUI symlink in 2015. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #27 from David Cook --- The package now includes the tiny_mce files, but it's not removing the symlink, which is a problem. See Bug 14055 for the YUI related issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #15 from David Cook --- (In reply to Marcel de Rooy from comment #13) > QA Comment: > The problem described in the first comment does not really seem a problem to > me. This is just what authorized values mean. The value is controlled now; > and you should not be able to save another value. Note that if you change it > here, why not change it in the items form or even other places? > I think this exception needs more discussion/consensus. Maybe raise it on > the dev list or a dev meeting. Hmm, I figure if it's a controlled field, you shouldn't be able to save a non-controlled value, but I think the behaviour right now might be to silently delete the existing data. Flagging that the current data isn't authorized and that they must use an authorized value is probably the optimal path forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #54 from Nicolas Legrand --- (In reply to Katrin Fischer from comment #53) > Nicolas, should we add sponsorship by BULAC here? maybe! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 --- Comment #17 from Alex Buckley --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added Attachment #104382|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 --- Comment #15 from Alex Buckley --- Created attachment 104994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104994=edit Bug 25090: Added 3 new notices * STAFF_VER_OPAC_REG - Sent to library containing registered patron details for library to review and select verification link if approve patron creation * PATRON_AND_IB_VER - Sent to patron to inform them they need to verify their email address via verification link then their registration will be reviewed by library * SELF_REG_APPROVED - Sent to patron containing password reset link after library has approved their registration Sponsored-By: Mental Health Education Resource Centre, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 --- Comment #16 from Alex Buckley --- Created attachment 104996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104996=edit Bug 25090: Allow libraries to verify OPAC self registrations These patchsets add two new sysprefs (to replace PatronSelfRegistrationVerifyByEmail), they are: * PatronSelfRegistrationVerifyByEmailToLibrary - Library verifies OPAC self registrations before a record is added to borrowers database table * PatronSelfRegistrationVerifyByEmailToPatron - Patron must verify their email before a record is added to borrowers database table -- 4 possible email verification workflow scenarios: 1) library verification = disabled & patron verification = disabled : 1a) Patron submits OPAC self reg form 1b) Patron account created immediately 2) library verification = enabled & patron verification = disabled : 2a) Patron submits OPAC self reg form 2b) Koha sends notice to library to review registration 2c) Library approves reg by clicking verification link in notice 2d) Patron account is created 2e) Password reset link emailed to patron 3) library verification = disabled & patron verification = enabled : 3a) Patron submits OPAC self reg form 3b) Koha sends verification email to patron 3c) Patron clicks verification link in notice 3d) Patron account is created 4) library verification = enabled & patron verification = enabled : 4a) Patron submits OPAC self reg form 4b) Koha sends verification email to patron to verify email 4c) Patron clicks verification link in notice 4d) Koha sends notice to library to review registration 4e) Library approves reg by clicking verification link in notice 4f) Patron account created 4g) Password reset link emailed to patron --- Test plan (in each test plan step where you must fill in OPAC self reg form please use a different email address): 1. Apply patch and restart plack 2. Update database: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Observe 2 new sysprefs in same line in editor (and observe PatronSelfRegistrationVerifyByEmail syspref has been removed): * PatronSelfRegistrationVerifyByEmailToLibrary - Set to 'None' by default * PatronSelfRegistrationVerifyByEmailToPatron - Set to "Don't require" by default. (Exception: If PatronSelfRegistrationVerifyByEmail syspref was enabled before applying this patch then PatronSelfregistrationVerifyByEmailToPatron will now be enabled). [Test scenario 1] 4. Set the following sysprefs: * PatronSelfRegistration - enabled * OpacResetPassword - enabled * PatronSelfRegistrationVerifyByEmailToLibrary - 'None' * PatronSelfRegistrationVerifyByEmailToPatron - "Don't require" Also set different values in: * KohaAdminEmailAddress syspref * ReplyToAddress syspref * branch email address (Administration > Libraries) 5. Visit OPAC, fill in, submit OPAC registration form 6. Observe your patron account has been created immediately and you can login [Test scenario 2] 6. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'email address of branch' 7. Repeat step 5 and query the database: select to_address, content from message_queue where letter_code='STAFF_VER_OPAC_REG'; 8. Observe the verification email's to_address is library branch email address (i.e. set in Administration > Libraries ) and the notice contains the following information: * Card number * Name: title firstname surname * Physical address: streetnumber, streettype, address, address2, city, state, zipcode, country * Email * Phone * Mobile * Fax * Secondary email * Secondary phone * Home library * Temporary patron category And a verification link 9. Query database again: select count(*) from borrowers where email=; select count(*) from borrower_modifications where email=; The first query returns 0 (as the patron account has not been added to borrowers table), the second query has 1 as patron in borrower_modifications table. 10. Click verification link in notice and query database: select * from borrowers where email= 11. Observe the patron account has now been added to the borrowers table 12. Query database: select to_address, content from message_queue where letter_code='SELF_REG_APPROVED'; 13. Observe password reset link emailed to patron, click on the link and observe the password reset page loads with the patrons username and email pre-filled 14. Set PatronSelfRegistrationVerifyByEmailToLibrary to 'KohaAdminEmailAddress' 15. Repeat step 7 observing the verification email's to_address is ReplytoDefault syspref value (if this is not set then KohaAdminEmailAddress i.e. fallback same as EmailPurchaseSuggestions syspref). 16. Repeat steps 9, 10, 11, 12, 13 which should all have the same outcomes [Test scenario 3] 17. Set PatronSelfRegistrationVerifyByEmailToPatron to "Require" PatronSelfRegistrationVerifyByEmailToLibrary to "None" 18. Repeat step 5 19. Query the database with
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #26 from David Cook --- Created attachment 104995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104995=edit Bug 25485: Remove all mention of tiny_mce in debian/rules This patch removes the removal of the following during the build process: /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Enable library approval of OPAC self registrations before a patron account is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added Attachment #104386|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #25 from David Cook --- Ok with Bug 25068's patch and this one (plus a manual update to debian/control), I was able to create a package. Next, I inspected the files in the package: dpkg-deb -c koha-common_19.12.00-test+20200518031703.5a5d-1_all.deb As I anticipated, it looks like /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce has been removed (as the debian/rules file removes it). I'll add a follow-up patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #5 from David Cook --- Created attachment 104993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104993=edit Bug 25068: Fix koha-common.install directives Bug 24735 removed etc/searchengine/queryparser.yml, which removed the need for koha-common.install to install the following file: debian/tmp/etc/koha/searchengine This patch removes that line and causes the Koha packages to build correctly again. To test: 0) Apply patch 1) Build a Koha package using one of the following methods: - https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way - https://hub.docker.com/r/koha/koha-dpkg - https://gitlab.com/minusdavid/koha-deb-builder-docker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 David Cook changed: What|Removed |Added Depends on||25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook changed: What|Removed |Added Blocks||25485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 [Bug 25485] TinyMCE broken in Debian package installs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 --- Comment #4 from David Cook --- (In reply to Joonas Kylmälä from comment #2) > The wiki instructions don't work since one needs to use for example stretch > to build Koha instead of the default that is squeeze. And yes, removing that > line from koha-common.install fixes the issue but I don't want to submit a > patch for this until I know how we are supposed to configure Elasticsearch > with the Debian package. I haven't used Elasticsearch with Koha yet, so could you speak more to that one? It looks like the Elastic search config lives in "admin/searchengine/elasticsearch/field_config.yaml" rather than "etc/searchengine"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25068] koha-common build error caused by missing /etc/searchengine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Yep, I'm getting the problem too when using https://gitlab.com/minusdavid/koha-deb-builder-docker and master: make[1]: Leaving directory '/home/koha/build/koha-19.12.00-test+20200518020508.3dc1f8a8' dh_install -O--fail-missing cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1376: dpkg-buildpackage -rfakeroot -D -us -uc failed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #24 from David Cook --- (In reply to David Cook from comment #23) > Looks like Bug 24735 got rid of etc/searchengine/queryparser.yml, but > Bugzilla says that bug was pushed to master at the start of March... > > I guess I probably haven't been building master packages since then but > https://dashboard.koha-community.org/ says the master build is still passing > on D9? (In reply to David Cook from comment #22) > Getting the following on master: > > cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file > or directory > dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine > debian/koha-common//etc/koha/ returned exit code 1 > debian/rules:9: recipe for target 'binary' failed > > But I don't think it relates to this patch. See Bug 25068 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24735] Remove QueryParser-related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #17 from David Cook --- (In reply to David Cook from comment #16) > I think this bug may have broken master package builds (despite what > dashboard.koha-community.org is saying)? > Oh, it's already been reported as Bug 25068. Nevermind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24735] Remove QueryParser-related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #16 from David Cook --- I think this bug may have broken master package builds (despite what dashboard.koha-community.org is saying)? I'm getting the following error when building master packages and this seems like the only reason why it would happen... make[1]: Leaving directory '/home/koha/build/koha-19.12.00-test+20200518020508.3dc1f8a8' dh_install -O--fail-missing cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1376: dpkg-buildpackage -rfakeroot -D -us -uc failed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #23 from David Cook --- (In reply to David Cook from comment #22) > Getting the following on master: > > cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file > or directory > dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine > debian/koha-common//etc/koha/ returned exit code 1 > debian/rules:9: recipe for target 'binary' failed > > But I don't think it relates to this patch. Looks like Bug 24735 got rid of etc/searchengine/queryparser.yml, but Bugzilla says that bug was pushed to master at the start of March... I guess I probably haven't been building master packages since then but https://dashboard.koha-community.org/ says the master build is still passing on D9? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #22 from David Cook --- Getting the following on master: cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed But I don't think it relates to this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104917|0 |1 is obsolete|| --- Comment #484 from Aleisha Amohia --- Created attachment 104989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104989=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104919|0 |1 is obsolete|| --- Comment #486 from Aleisha Amohia --- Created attachment 104991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104991=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104918|0 |1 is obsolete|| --- Comment #485 from Aleisha Amohia --- Created attachment 104990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104990=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104920|0 |1 is obsolete|| --- Comment #487 from Aleisha Amohia --- Created attachment 104992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104992=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104916|0 |1 is obsolete|| --- Comment #483 from Aleisha Amohia --- Created attachment 104988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104988=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #5 from Alex Buckley --- Created attachment 104987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104987=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Also adds syspref to optionally choose to embed item information in record when adding/editing bibliographic and item records. Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [ITEM EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ITEM ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [ITEM DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ITEM ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [ITEM EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [ITEM EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [ITEM DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What|Removed |Added Attachment #104986|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #4 from Alex Buckley --- Created attachment 104986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104986=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What|Removed |Added Attachment #104985|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #3 from Alex Buckley --- Created attachment 104985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104985=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What|Removed |Added Attachment #104983|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Medium patch Text to go in the||This patch adds the ability release notes||to define messaging ||preferences for recalls ||email and sms notices ||RETURN_RECALLED_ITEM and ||PICKUP_RECALLED_ITEM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Attachment #93905|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 104984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104984=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #11 from David Cook --- (In reply to Tomás Cohen Arazi from comment #10) > That's interesting, David. Mine is not community per-se. I like yours, might > steal some of it for mine Cool ^_^. It's a work-in-progress, but I've been using it for a while and have it integrated in a CD pipeline, which is working pretty well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 --- Comment #15 from David Cook --- (In reply to Jonathan Druart from comment #6) > Salut Marjorie, > > If you turn URLLinkText off, the "Link to resource" link will be displayed > instead of the URL. I think it's what you are searching for. Honestly, I think this is the answer though. I'd be inclined to mark this as resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25483] Url item field no longer accepts html tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25483 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #14 from David Cook --- (In reply to Katrin Fischer from comment #13) > I think we go way beyond 852 in a lot of areas - which is also the problem: > There are no more free subfields in Koha to use for this. And if you have > repated $u you also get the issue of sequence. Btw - if we used MFHD (MARC > for Holdings Data, we could have a full 856 there, so it's not really a > limitation of the standard). > > The item editor is not made to resort the item subfields and I also feel > like that would not be a good solution and more error prone / harder to > handle for catalogers. Of course, I think the only reason we use the 952 for item/holdings data is because we forced Zebra (and to a lesser degree Elasticsearch) to use MARC. Neither Zebra nor Elasticsearch actually require MARCXML, so another way forward is to have Koha Item Metadata that we create and use however we want. (We'd just need a MARC export for it for metadata exchange with other systems, and in that case we could leave off things like link text.) A complicated avenue for sure, but it's an option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411 David Cook changed: What|Removed |Added Summary|Plugin routes cannot have |Plugin routes cannot have |annonymous access |anonymous access CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #10 from Tomás Cohen Arazi --- (In reply to David Cook from comment #9) > (In reply to Victor Grousset/tuxayo from comment #6) > > IIUC from various IRC discussions, the cleanest[1] way to test package > > install patches while being simple[1] enough to be less likely to messed > > things up is: > > > > - apply comment 4 > > - make packages with https://hub.docker.com/r/koha/koha-dpkg > > - spin a standard Debian (9?) however one wants (container, VM, VPS) > > - install the packages following > > https://wiki.koha-community.org/wiki/Koha_on_Debian > > > > [1] for someone without experience with building packages and installing > > Koha from them > > That's mostly correct, although "install the packages" would need to use > either "apt install ./koha-common" or "dpkg -i > koha-common" > > For making packages, I use my own Docker image > (https://gitlab.com/minusdavid/koha-deb-builder-docker), but I imagine > there's community support for https://hub.docker.com/r/koha/koha-dpkg, so > that's probably better for someone without experience. That's interesting, David. Mine is not community per-se. I like yours, might steal some of it for mine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose and test mode options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #21 from David Cook --- (In reply to Katrin Fischer from comment #20) > I wonder if we could highlight this breaking change a bit more in the > release notes - currently it's almost lost: > > The patches make the --confirm switch required, without it script will be > run in test mode. Existing scheduled cronjobs will need to be updated to > supply this switch. Oh wow yeah that's a good idea. Easy to be caught out by that one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22831] Add a maintenance script for checking DB vs index counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #31 from David Cook --- I wrote something like this for Zebra a long time ago, and while it is useful, it would be great to check if the contents of both the DB and the Index were the same. (For instance, the counts might be the same as you may not have added/deleted in a while, but the contents may still be different, if your updates aren't working.) What do people think about adding a checksum in a MARC field and indexing that? (Alternatively, I suppose we could just use the 005, although I don't know how reliably that is updated.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25485] TinyMCE broken in Debian package installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 --- Comment #21 from David Cook --- Hoping to work on this more today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 --- Comment #9 from David Cook --- (In reply to Marcel de Rooy from comment #8) > +$biblionumber = int($biblionumber); > > I think we have a few places where we do that. And it is really ugly imo. > If you dont pass a valid biblionumber, you should not get a valid response. > > Furthermore int does not like strings. We will have warnings like: > Argument "3abc" isn't numeric in int > > I would rather get rid of the other places.. Yeah, that's a good point. > > Changing status: ID or FQA ? Probably FQA for now, and maybe we should have a separate bug for returning a 404 or something when an invalid biblionumber is given. (And then this bug report would either become a duplicate or implement that new strategy.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #9 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #6) > IIUC from various IRC discussions, the cleanest[1] way to test package > install patches while being simple[1] enough to be less likely to messed > things up is: > > - apply comment 4 > - make packages with https://hub.docker.com/r/koha/koha-dpkg > - spin a standard Debian (9?) however one wants (container, VM, VPS) > - install the packages following > https://wiki.koha-community.org/wiki/Koha_on_Debian > > [1] for someone without experience with building packages and installing > Koha from them That's mostly correct, although "install the packages" would need to use either "apt install ./koha-common" or "dpkg -i koha-common" For making packages, I use my own Docker image (https://gitlab.com/minusdavid/koha-deb-builder-docker), but I imagine there's community support for https://hub.docker.com/r/koha/koha-dpkg, so that's probably better for someone without experience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #2) > So Koha install is broken using the Debian package? Arguably yes. The majority of the install works correctly, but it looks like it ditches out at the end of koha-common.postinst. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #2 from Alex Buckley --- Created attachment 104983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104983=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What|Removed |Added Attachment #104721|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25522] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25522 Owen Leonard changed: What|Removed |Added Summary|Touched By ./GoldGanz |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25522] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25522 Owen Leonard changed: What|Removed |Added Attachment #104982|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25522] New: Touched By ./GoldGanz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25522 Bug ID: 25522 Summary: Touched By ./GoldGanz Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: lanang.gamin...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 104982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104982=edit Hi admin:v -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
