[Koha-bugs] [Bug 20554] New OPAC CSS

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #55 from David Cook  ---
By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin
virus by Symantec Endpoint Protection. 

It says that Symantec have had it flagged for more than 1 year, and that the
file is untrustworthy.

I have examined the Javascript, and it really appears to be a false positive,
but I'm noting it here anyway.

I'm going to look at removing fontfaceobserver locally so that it can pass
security checks for the time being.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #28 from Nick Clemens  ---
Created attachment 105565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105565=edit
Bug 23808: [19.11.x] Pre-fill guarantor fields when adding guarantee to
guarantor

Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the
guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell 
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of
memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki District Council, NZ

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: George Veranis 
Followed the test plan, works as expected. The only failure was
t/DateUtils.t test which will be fixed by Bug 24850.
Also corrected a small typo in the sponsored-by trailer.

Signed-off-by: Kyle M Hall 

Bug 23808: (follow-up) Display card number in 'Guarantor information' in
memberentry.pl

Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber
in 'Guarantor information' we should display 'Patron card number:' with
the cardnumber displayed as that value is more meaningful to librarians.
The hyperlink containing the borrowernumber should stay the same so that
librarians can easily visit the patron record of existing guarantor
patrons.

Test plan:

1. Apply first patch and follow it's test plan

2. On an Adult patrons record select 'Add guarantee'

3. In 'Guarantor information' section of memberentry.pl observe in the
pre-filled guarantor information there is
a line 'Patron #:' with a link displaying a borrowernumber (not card number)
and when you click on the link it takes you to the adult/guarantors patron
account

4. Select 'Search to add' and search and add another guarantor

5. Observe in the added guarantor 'Patron #:' is displayed along with
the borrowernumber (not card number). The borrowernumber displayed in
not a link.

6. Apply this patch

7. On a adults patron select 'Add guarantee'

8. Observe in 'Guarantor information' section the pre-filled guarantor
now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link
now displays the guarantors cardnumber.
Clicking on the link still takes you to the guarantors patron account

9. Repeat step 4

10. Observe in the added guarantor they also have 'Patron card number:'
(instead of 'Patron #:'). A cardnumber rather than borrowernumber is
displayed. The cardnumber is not a link.

11. Confirm tests still pass:
sudo koha-shell 
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos 

Signed-off-by: Kyle M Hall 

Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor
patron in memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',

[Koha-bugs] [Bug 25679] New: If no value is set in the system preference NoIssueCharge, Odd Yellow Box appears

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679

Bug ID: 25679
   Summary: If no value is set in the system preference
NoIssueCharge, Odd Yellow Box appears
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a library does not set the system preference, NoIssueCharge- by leaving this
blank.  Koha will not checkout items to any patrons who owe any amount of
money.  The alert box (yellow) will display and give no words on what the error
is.

Can we add wording to the system preference that a dollar amount should be in
this system preference and also, have the Yellow alert box indicate some
notation about the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25678] Checkout stuck "Loading... you may continue scanning" because of Javascript error

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25678

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23690

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning."

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25678

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25678] New: Checkout stuck "Loading... you may continue scanning" because of Javascript error

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25678

Bug ID: 25678
   Summary: Checkout stuck "Loading... you may continue scanning"
because of Javascript error
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

checkouts.js creates fatal Javascript errors when it tries to run
"escapeHtml()" on null values. 

This typically happens when a title or some other data element is null.

That said, in theory many of these data elements shouldn't be null. 

But... we shouldn't be dying on Javascript errors either. We should catch the
condition and do something about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning."

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
There is a problem related to this but the original description isn't clear
enough...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
I was wondering what KOHA_HOME was about yesterday...

Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset.

Then in kohadevbox and koha-testing-docker, an environmental variable can be
set to a dev install location?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674

--- Comment #2 from David Cook  ---
I feel like this is also the right bug report for discussing virtual hosts VS
instance-prefixed queue names. (Virtual hosts add sysadmin/operations overhead,
but offers a better logical separation message data.) (Note that I haven't
found a public method for deleting RabbitMQ queues. Deleting a virtual host
might be easier from a RabbitMQ cleanup perspective.) I think requiring a
sysadmin to set up RabbitMQ isn't necessarily a deal breaker, so long as we
have appropriate error-handling and alert Koha admin users that they can't use
certain functionality until RabbitMQ has been properly configured. This is my
current inclination.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I'm wondering if we should put connection information (ie hostname, port,
username, password, vhost) in koha-conf.xml or have a dedicated file. I feel
like koha-conf.xml is simpler for the developer, but a dedicated file would be
easier for a sysadmin/operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #57 from David Cook  ---
(In reply to Jonathan Druart from comment #56)
> Can we dedicate this bug report to the base idea, then create bug report on
> top of it for experiment? I'd like to avoid noise for testers and keep the
> comment list easy to follow.

Sounds like a plan, boss man 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #105563|0   |1
is obsolete||

--- Comment #2 from Andrew Fuerste-Henry  ---
Created attachment 105564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105564=edit
Bug 25677 - Checkbox options for EDI accounts cannot be enabled

Checking any of the checkboxes in the EDI Account editor does nothing.
They always remain set to "off".

Test Plan:
1) Browse to edi_accounts.pl
2) Create a new EDI account, check all the checkboxes
3) Edit the account, note none of the checkboxes are checked
4) Apply this patch
5) Repeat steps 1-2
6) Note the checkboxes remain checked

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657

--- Comment #5 from Elaine Bradtke  ---
We have two instances of Koha, they are supposed to be identical (one test, one
production) I always do large imports in test first.  The problem seems to be
in the test site, I just successfully imported into production the same patron
data that failed in test.  I'll have a word with our tech person as to what
differences there are, aside from being on two different cloud servers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

--- Comment #1 from Kyle M Hall  ---
Created attachment 105563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105563=edit
Bug 25677 - Checkbox options for EDI accounts cannot be enabled

Checking any of the checkboxes in the EDI Account editor does nothing.
They always remain set to "off".

Test Plan:
1) Browse to edi_accounts.pl
2) Create a new EDI account, check all the checkboxes
3) Edit the account, note none of the checkboxes are checked
4) Apply this patch
5) Repeat steps 1-2
6) Note the checkboxes remain checked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] New: Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Bug ID: 25677
   Summary: Checkbox options for EDI accounts cannot be enabled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Checking any of the checkboxes in the EDI Account editor does nothing. They
always remain set to "off".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25213] Notify reporter when an OPAC problem is resolved

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25213

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
Summary|It would be beneficial to   |Notify reporter when an
   |be able to notify the   |OPAC problem is resolved
   |patron of a resolution  |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Owen Leonard  ---
Does anyone know how to create the circumstance under which the typo is shown?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is too long

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo  ---
Can't be backported to 19.05.x due to dependence on bug 25311.

So if someone is interested in this bug being backported to 19.05.x, send help
to bug 25311 ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

Donna  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105561|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 105562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105562=edit
Bug 25675: Reword and reorganize sysprefs related to patron self modification

To Test:
1: apply patch
2: restart all
3: go to System Preferences > OPAC
4: confirm "Self registration" section is now labeled "Self registration and
modification"
5: confirm OPACPatronDetails is now in the "Self registration and modification"
section
6: confirm PatronSelfRegistration now reads "(Allow / Don't allow)  library
patrons to register for an account via the OPAC."
7: set OPACPatronDetails to Don't allow
8: set PatronSelfRegistration to Allow
9: log into the opac and verify you're not able to edit your patron details on
an existing account

Signed-off-by: DonnaB 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry  ---
Looking at Joe's site, this seems to be particular to items that are set to
itemlost=1 (which should show "Lost") but are also still checked out. 

select biblionumber from items where onloan is not null and itemlost=1
Bibs listed in this report display "long overdue" as Joe has described.

select biblionumber from items where onloan is null and itemlost=1
Bibs listed in this report show "Lost" as they should

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com
   |ity.org |
Version|19.11   |master
 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

--- Comment #1 from Andrew Fuerste-Henry  ---
Created attachment 105561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105561=edit
Bug 25675: Reword and reorganize sysprefs related to patron self modification

To Test:
1: apply patch
2: restart all
3: go to System Preferences > OPAC
4: confirm "Self registration" section is now labeled "Self registration and
modification"
5: confirm OPACPatronDetails is now in the "Self registration and modification"
section
6: confirm PatronSelfRegistration now reads "(Allow / Don't allow)  library
patrons to register for an account via the OPAC."
7: set OPACPatronDetails to Don't allow
8: set PatronSelfRegistration to Allow
9: log into the opac and verify you're not able to edit your patron details on
an existing account

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API basic auth lacks   |REST API should set
   |C4::Context->userenv|C4::Context->userenv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|lari.task...@hypernova.fi   |tomasco...@gmail.com
 CC||tomasco...@gmail.com
   Severity|enhancement |major
 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED
Version|unspecified |master

--- Comment #4 from Tomás Cohen Arazi  ---
There's been big changes on the API front, but it is not clear when we will be
able to make a clean transition into using Mojolicious for all controlling code
and thus making the stash accessible to Koha::* classes.

That said, I'm taking over this bug, and will make it take care of setting
userenv on every authentication method, as we are now seeing action_logs with
no borrowernumber responsible for changes that happen in the API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #17 from Andrew Fuerste-Henry  ---
It occurs to me that we're not giving any option to keep the lost fee and
restore / recharge the overdue. I don't think anyone needs to do so, but
raising it here in case someone wants to make the case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #16 from Andrew Fuerste-Henry  ---
On step 18 of my plan above, I got this error:
"Unknown error code LostItemFeeCharged at /kohadevbox/koha/circ/returns.pl line
538"

Other thoughts:
- I like the general structure here. where you've chosen to put this setting
makes sense
- What happens if my accruing fine has been fully/partially written off or
paid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #15 from Andrew Fuerste-Henry  ---
I wrote this test plan:
1- apply patch
2- updatedatabase, restart_all
3- verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee
are on
4- verify WhenLostForgiveFine is set to "Forgive"
5- verify circ rules include fines
6- set Default lost item fee refund on return policy to "Refund lost item
charge"
7- create 4 overdue checkouts that will incur fines
8- run fines.pl
9- confirm 4 items checked out with accruing fines
10- confirm all 4 items have a replacement price

Item 1
11- mark the first item lost
12- verify that fine is gone and lost fee has been charged
13- check item in
14- verify that lost fee is gone and overdue charge has not returned

Item 2
15- set Default lost item fee refund on return policy to "Refund lost item
charge and charge new overdue fine"
16- mark second item lost
17- verify that fine is gone and lost fee has been charged
18- check item in
19- verify that lost fee is gone and a new overdue charge has been made

Item 3
20- set Default lost item fee refund on return policy to "Refund lost item
charge and restore overdue fine"
21- mark second item lost
22- verify that fine is gone and lost fee has been charged
23- check item in
24- verify that lost fee is gone and the old overdue charge has been restored

Item 4
25- set Default lost item fee refund on return policy to "Leave lost item
charge"
26- mark second item lost
27- verify that fine is gone and lost fee has been charged
28- check item in
29- verify that lost fee remains and the overdue charge is still gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

--- Comment #3 from Owen Leonard  ---
Created attachment 105560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105560=edit
Bug 25658: Print icon sometimes obscures patron barcode

This patch alters the style of the patron name/cardnumber label on the
checkout screen so that it has a maximum width. This will help avoid the
label being obscured by the print/close buttons displayed when
DisplayClearScreenButton is enabled.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Enable the DisplayClearScreenButton system preference.
 - Check out to a patron. Resize the browser to confirm that at narrower
   browser widths the patron name in the checkout form isn't obscured by
   the print and clear screen buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105558|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 105559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105559=edit
Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not
charging a lost fee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552

--- Comment #6 from Kyle M Hall  ---
Created attachment 105558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105558=edit
Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not
charging a lost fee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
Version|19.11   |master
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24159


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159
[Bug 24159] Short loan collection issues on a day marked as closed (move
useDaysMode to circ rules)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||18936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936
[Bug 18936] Move issuingrules into circulation_rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

Donna  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105556|0   |1
is obsolete||

--- Comment #13 from ByWater Sandboxes  ---
Created attachment 105557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105557=edit
Bug 25349: Add checkEnter function and apply it to SCO page

This patch adds the checkEnter function to the OPAC global.js and then applies
it to the SCO login page.
TO TEST:
1. Go to SCO login and try entering something in the "Login:" input amd
"Password:" input.
2. Pressing enter while in either will automatically submit the form.
3. Apply patch.
4. Type something into the Login: field and press enter, the form should NOT
submit.
5. Type something into the Password: field and pess enter, this SHOULD submit
the form.
6. Change the syspref SelfCheckoutByLogin to 'Cardnumber'
7. Type something into the Please enter your card number: field, the form
should submit.

Signed-off-by: Donnab 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

Lucas Gass  changed:

   What|Removed |Added

 Attachment #105533|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 105556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105556=edit
Bug 25349: Add checkEnter function and apply it to SCO page

This patch adds the checkEnter function to the OPAC global.js and then applies
it to the SCO login page.
TO TEST:
1. Go to SCO login and try entering something in the "Login:" input amd
"Password:" input.
2. Pressing enter while in either will automatically submit the form.
3. Apply patch.
4. Type something into the Login: field and press enter, the form should NOT
submit.
5. Type something into the Password: field and pess enter, this SHOULD submit
the form.
6. Change the syspref SelfCheckoutByLogin to 'Cardnumber'
7. Type something into the Please enter your card number: field, the form
should submit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25642] Technical notes are missing from the release

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25642] Technical notes are missing from the release

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25642] Technical notes are missing from the release

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642

Martin Renvoize  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105541|0   |1
is obsolete||

--- Comment #20 from ByWater Sandboxes  ---
Created attachment 10
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10=edit
Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages

This patch adds the logic and the needed UI elements to be able to pre-load an
import profile. It also displays which profile was used to stage an import in
staged import manager.

To test:
1. Apply all patches
2. Updatedatabase
3. Go to Stage MARC records for Import tool in admin, and upload a file with
MARC records.
CHECK => after uploading, there is a fieldset with the legend “Profile
settings”
  => inside the fieldset there is a select labeled “Pre fill values
with profile”. The only value it has is “Do not use profile”.

4. Change some settings, and set “profile 1” as profile name and click on “Add
profile”
SUCCESS => The select now has the new profile selected

5. Change profile select to “Do not use profile”
SUCCESS => Default values are now displayed in the form

6. Reload the page and upload the file again
SUCCESS => the select still has the profile recently added

7. Select the profile, change some parameter in the form and set the profile
name to “profile 2”, and click add profile
SUCCESS => there are two profiles now, and if you toggle between them, the
parameter changes

8. Select profile 1, change one parameter and click on update profile
SUCCESS => if you toggle that profile with the other, the new parameter of the
value is shown when you select profile 1

9. Select profile 2, change some parameter and click Add profile (leaving the
name as profile 2)
SUCCESS => the page complains there is another profile with the same name, and
asks if you want to replace it.

10. Click on accept
SUCCESS => profile 2 now has the new value in the parameter

11. Select profile 2 and change the name to profile 1
SUCCESS => the page complains there is another profile with that name, and asks
if you want to replace it

12. Click on accept
SUCCESS => in profile select there is only one profile called profile 1 that
has the values of profile 2

13. Select profile 1 and click remove profile
SUCCESS => there is no profile in profile select.

14. Create a profile and click on “Stage for import”
15. Go to Staged MARC management page
SUCCESS => Improt should have the name of the profile in profile column, and
when you click on the file name, there should be the name of the profile in the
details.

16. prove t/db_dependent/ImportBatch.t
t/db_dependent/api/v1/import_batch_profiles.t
17. Sign off

Signed-off-by: Abbey Holt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #19 from Abbey Holt  ---
(In reply to Agustín Moyano from comment #18)
> (In reply to Abbey Holt from comment #16)
> > This is great! There is one area where my matching preferences would not
> > stick when I created a profile. If I select "No" under "Check for embedded
> > item record data" and click "Add profile", No switches back to Yes. My
> > selection for "how to process items" is remembered. It is just the yes-no
> > button that isn't being saved.
> 
> Hi Abbey, thanks so much for pointing that out.. could you please try again?
> 
> Thanks!

It worked! I'm signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676

--- Comment #1 from Joe Sikowitz  ---
Created attachment 105554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105554=edit
Correct item record example

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25676] New: Staff client catalog search shows incorrect item status under location

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676

Bug ID: 25676
   Summary: Staff client catalog search shows incorrect item
status under location
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j...@flo.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 105553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105553=edit
Incorrect search result example

If you have an item that has a Lost status of "Lost" it will appear as "long
overdue" in staff client search results. See attached screenshots for an
example.

This should display the current Lost status instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25675] New: System preference PatronSelfRegistration incorrectly described

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675

Bug ID: 25675
   Summary: System preference PatronSelfRegistration incorrectly
described
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The system preference PatronSelfRegistration description states:  "library
patrons to register or modify their account via the OPAC" however, in testing
it, patron self modification is actually controlled by OPACPatronDetails system
preference, which is in a different area of system preferences.

At the very least, the description for PatronSelfRegistration should be updated
to removed the reference to "modify".

I would also propose that OPACPatronDetails and
PatronSelfModificationBorrowerUnwantedField are placed together.  It is very
confusing to enable the modification function in one section, and define the
display in another section.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17854] New Print slip and close button next to Close button

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25658


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658
[Bug 25658] Print icon sometimes obscures patron barcode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854
[Bug 17854] New Print slip and close button next to Close button
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #3 from Jonathan Druart  
---
Created attachment 105552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105552=edit
Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?)

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586

--- Comment #2 from Jonathan Druart  
---
KOHA_HOME can be:
 * /usr/share/koha  # pkg install
 * /kohadevbox/koha # dev install (or another path ofc, the one in the
intranetdir config)


Weird thing:
 * debian/scripts/koha-plack

392 adjust_paths_dev_install $name
393 export DEV_INSTALL
394 export KOHA_HOME
395
PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer

On a pkg install we don't have /usr/share/koha/installer or
/usr/share/koha/lib/installer
On a dev instal we don't have /kohadevbox/koha/lib

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105424|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 105551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105551=edit
Bug 18086: Add FK constraints for branchcode and categorycode

The overduerules table has no foreign key constraints to any for the
related tables. The columns for branchcode, categorycode, letter1,
letter2, and letter3 should all be foreign keys.

Test Plan:
0) Create some overdue rules with invalid branchcodes and categorycodes
1) Apply this patch
2) Restart all the things!
3) Run updatedatabase.pl
4) Note the invalid rules are deleted
5) Note Default codes are NULL now instead of empty strings
6) Editor should behave as it did before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

--- Comment #2 from Benjamin Daeuber  ---
(In reply to Jonathan Druart from comment #1)
> Where does come from this print icon?

It was introduced in 19.05 with the DisplayClearScreenButton system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Where does come from this print icon?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25643] Remove maxreserves syspref

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #11 from Jonathan Druart  
---
If there is a discussion (maybe on the ML?) and we found a consensus, I am
willing to implement it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22417


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
[Bug 22417] Add a task queue
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||25674


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674
[Bug 25674] Add RabbitMQ options to koha-create
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25674] New: Add RabbitMQ options to koha-create

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674

Bug ID: 25674
   Summary: Add RabbitMQ options to koha-create
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Now that we plan to use RabbitMQ as message broken for a task queue manager, we
need to be able to set the RabbitMQ options on instance creation.

It should fallback to localhost, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662

--- Comment #2 from Jonathan Druart  
---
It must indeed be moved to CanItemBeReserved (and I think stay in the
controller as well, for multi holds).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Delegate background jobs|Add a task queue
   |execution   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660

--- Comment #4 from Caroline Cyr La Rose  ---
hehe! Phew! I'm glad I'm not the only one using vintage methods :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table?

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199

Owen Leonard  changed:

   What|Removed |Added

 CC|oleon...@myacpl.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593

--- Comment #1 from Owen Leonard  ---
Created attachment 105550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105550=edit
Bug 25593: Terminology: Fix "There is no order for this biblio." on catalog
detail page

This patch changes the phrase "There is no order for this biblio" to
"There is no order for this bibliographic record." on the catalog
detail page.

To test, apply the patch and view the bibliographic detail page for a
record which has no order associated with it. The text in the
"Acquisitions details" tab should be correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Add circulation process to inter-library loans

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #88 from Jonathan Druart  
---
+use Carp::Always;

That should be removed, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846

Owen Leonard  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com
  Component|OPAC|System Administration
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|needs_rfc   |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627

Owen Leonard  changed:

   What|Removed |Added

Summary|Move OPAC problem reports   |Move OPAC problem reports
   |from administration to  |from administration to
   |tools?  |tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools?

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627

--- Comment #1 from Owen Leonard  ---
Created attachment 105549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105549=edit
Bug 25627: Move OPAC problem reports from administration to tools

This patch moves the OPAC problem report management page from the
Administration section to the Tools section.

I think this makes sense because management of reports is an ongoing
task, not a configuration.

To test, apply the patch and enable the OPACReportProblem system
preference.

 - Go to Administration. There should be no link to OPAC problem
   reports.
   - Open an administration page which shows the Administration menu in
 the left-hand sidebar, e.g. Libraries. There should be no link to
 OPAC problem reports in the menu.
 - Go to Tools. There should be a link to OPAC problem reports in the
   "Addional tools" section.
   - Open the OPAC problem reports page and confirm that it works
 correctly.
   - The breadcrumbs menu should show "Tools > OPAC problem reports."
   - Confirm that the link in the sidebar menu works correctly.
 - If necessary, submit an OPAC problem report via the OPAC so that
   there is a pending report. Go to the staff interface home page and
   check that the "OPAC problem reports pending" link works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools?

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
> After re-injecting an old clean dump and replaying the updatedatabase.pl
> errors are gone, so it was probably   because of other columns coming from
> patches not yet in master.
> Maybe we should start moving some columns to other tables. An obvious
> candidate is all the address fields that can be moved in a patron_addresses
> table.

Another option would be to move some columns into a JSON column. MariaDB 10.2.7
and MySQL 5.7 both have JSON data types and functions to use JSON values in a
query.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #7 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #3)
> What's the return of
>  show variables where Variable_name = 'innodb_file_per_table';
>  show variables where Variable_name = 'innodb_default_row_format';

MariaDB [koha]> show variables where Variable_name = 'innodb_file_per_table';
+---+---+
| Variable_name | Value |
+---+---+
| innodb_file_per_table | ON|
+---+---+
1 row in set (0.001 sec)

MariaDB [koha]>  show variables where Variable_name =
'innodb_default_row_format';
+---+-+
| Variable_name | Value   |
+---+-+
| innodb_default_row_format | dynamic |
+---+-+
1 row in set (0.001 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
[Bug 22539] Fines charged on back-dated checkin when item has been renewed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|8338|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338
[Bug 8338] Fines not cleared with dropbox mode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|22539   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
[Bug 22539] Fines charged on back-dated checkin when item has been renewed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8338

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22539

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25644] Self Check in Patron Account

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25644

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|martin.renvoize@ptfs-europe |david.roberts@ptfs-europe.c
   |.com|om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25673] Access logging of borrower's personal information

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #6 from Jonathan Druart  
---
https://dev.mysql.com/doc/refman/8.0/en/column-count-limit.html
https://dev.mysql.com/doc/refman/8.0/en/storage-requirements.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #4 from Jonathan Druart  
---
Created attachment 105548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105548=edit
Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #5 from Jonathan Druart  
---
Can you confirm this patch resolves the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

Summary|Restore Forgiven Overdue|Add options to charge new
   |Fines When Lost Item|or restore forgiven
   |Returned|overdues when a lost item
   ||is returned

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

   Severity|major   |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #3 from Jonathan Druart  
---
What's the return of
 show variables where Variable_name = 'innodb_file_per_table';
 show variables where Variable_name = 'innodb_default_row_format';

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #14 from Martin Renvoize  ---
This needs new units tests for the QA step, but I wanted some early testing to
check that the end results are as expected by those interested in the feature.

Many thanks in advance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

2020-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105530|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 105545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105545=edit
Bug 23091: Update unit test

This patch updates the unit test for get_lostreturn_policy to reflect
the rule_name and return code changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >