[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697

David Cook  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697

David Cook  changed:

   What|Removed |Added

 Attachment #105655|0   |1
is obsolete||

--- Comment #4 from David Cook  ---
Created attachment 106174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106174=edit
Bug 25697: Declare base url and suffix in tinymce init

This patch declares the base url and suffix in tinymce init, so
that tinymce will initialize properly cross-browser. Without this change,
tinymce will fail to initialize on IE 11.

Test plan:
0. Apply patch
1. Open IE 11
2. Enable "UseWYSIWYGinSystemPreferences" system preference
3. Go to /cgi-bin/koha/admin/preferences.pl?tab=opac and note that
tinymce initializes correctly
4. Go to /cgi-bin/koha/tools/koha-news.pl and create/edit a news item,
and note that tinymce initializes correctly
5. Go to /cgi-bin/koha/admin/branches.pl and add/edit a library, and
note that tinymce initializes correctly for "OPAC info"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697

David Cook  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803

David Cook  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
I'll be fixing this (sooner or later) locally, since we have many clients that
use IE 11. (Many of these clients having their browser usage forced on them by
corporate IT policies.)

I'll submit my patches here whether or not the community chooses to accept
them.

Maybe we should default me as the Assignee for the "Browser compatibility"
component, as I'm going to be supporting IE for as long as I work at
Prosentient Systems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686

--- Comment #19 from David Cook  ---
(In reply to Katrin Fischer from comment #18)
> I think we should make sure that the biblionumber cannot be hidden in the
> frameworks or at least output a warning on the system information tab if the
> field linked to biblionumber is set to hidden in OPAC.

Agreed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25848] New: Allow staff to cancel subscription alerts on behalf of patrons

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25848

Bug ID: 25848
   Summary: Allow staff to cancel subscription alerts on behalf of
patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Currently, the only way to cancel email alerts/notifications about
subscriptions is manually, by the borrower, through the OPAC.

This is a problem if the borrower has since left the library and can no longer
log in to the OPAC.

There should be a way for staff to cancel these subscriptions to subscription
alerts in the staff client.

To reproduce:
Set up a subscription for a biblio. Edit it and ensure the patron notification
is enabled
Log in to the OPAC and go to that biblio
Click 'Subscribe to email notification on new issues' button and confirm this
Notice there is now a button to cancel the subscription on the OPAC
In the staff client,  go to the subscription and click the subscribers link
next to Patron notification (serials/viewalerts.pl?subscriptionid=X)
Notice you can't remove subscribers here

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

Alex Buckley  changed:

   What|Removed |Added

 Attachment #106172|0   |1
is obsolete||

--- Comment #3 from Alex Buckley  ---
Created attachment 106173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106173=edit
Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

This patch modifies the OAI XSLT file, correcting the path to jQuery
assets and adds a link to jquery-migrate.

To test, apply the patch and make sure the "OAI-PMH" system preference
is enabled.

1. Go to:
/cgi-bin/koha/oai.pl?verb=ListRecords=marc21
   e.g.
   localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=marc21
2. Click on the 'Sets' and 'Metadata' links. The corresponding
   panels with set and metatdata information should be shown.

Tested against master, works as described.
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

--- Comment #2 from Owen Leonard  ---
Created attachment 106172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106172=edit
Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

This patch modifies the OAI XSLT file, correcting the path to jQuery
assets and adds a link to jquery-migrate.

To test, apply the patch and make sure the "OAI-PMH" system preference
is enabled.

1. Go to:
/cgi-bin/koha/oai.pl?verb=ListRecords=marc21
   e.g.
   localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=marc21
2. Click on the 'Sets' and 'Metadata' links. The corresponding
   panels with set and metatdata information should be shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00, 19.05.12
released in||

--- Comment #35 from Victor Grousset/tuxayo  ---
Good news: Backported to 19.05.x branch for 19.05.12

Thanks Tomas for the additional analysis :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Katrin Fischer  ---
There are some failures in QA tools that need to be taken care of. I will try
to come back to this for more testing after they are fixed:

 FAIL   t/db_dependent/Koha/Account.t
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 1068)

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   tinyint_has_boolean_flag
The new column account_credit_types.credit_number_enabled is
using TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/AccountCreditType.pm), see the SQL12 coding guideline

 FAIL   Koha/Account/Line.pm
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 895)
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 910)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17499] Koha objects for messaging preferences

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #82 from Katrin Fischer  ---
This needs a bit of work, there are lots of "red" entries when running the QA
tools, but they should be easy to fix. Examples:

 FAIL   Koha/Patron/Message/Attributes.pm
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 18)
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for 'object_class'

All the tests do pass for me.

Lari, could you take a look and fix these? I'll probably need another QA Team
member to take a closer look at the code after that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #27 from Katrin Fischer  ---
I am sorry Emmi, but this does no longer apply - can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16371: Quote of the Day (QOTD) - Display in different interfaces
.git/rebase-apply/patch:208: trailing whitespace.

error: sha1 information is lacking or useless (Koha/Quote.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 16371: Quote of the Day (QOTD) - Display in different
interfaces
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-16371-Quote-of-the-Day-QOTD---Display-in-diffe-AWZo8w.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775

--- Comment #2 from Katrin Fischer  ---
Looks really nice and I like the new placement of the ical link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803

--- Comment #3 from Katrin Fischer  ---
Iirc we are not officially supporting IE for the staff interface, but only for
the browser. But could only locate a note in the manual: 
https://koha-community.org/manual/20.05/en/html/intro.html?highlight=explorer

Is support of browser versions something we should discuss at the next meeting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Katrin Fischer  changed:

   What|Removed |Added

Summary|Display overdue fines for   |Display overdue fines for
   |the document on SIP checkin |the item on SIP checkin

--- Comment #2 from Katrin Fischer  ---
I think document is not the right word here - i'd use item as it's neutral to
what it is (it could be anything from keys to a multi-part language course).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Katrin Fischer  ---
I think this one is not correct.

permanent_locaton != homebranch.
But also: What if the item is not returned at the home library? 

The location might apply to the home library or the holding branch, it's hard
to tell. I think I would probably not display it by default.

Also I think this would display the codes, not the descriptions?

I think I'd maybe leave it at "Item checked in"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815

Katrin Fischer  changed:

   What|Removed |Added

Summary|SIP Checkout: add more  |SIP Checkout: add more
   |information on why the  |information on why the
   |patron is blocked.  |patron is blocked

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25816] Add OPAC messages in SIP display

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816

Katrin Fischer  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com
Summary|Add opac messages in SIP|Add OPAC messages in SIP
   |display.|display

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105948|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 106171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106171=edit
Bug 24352: Correct location and collection labels in OPAC search results

This patch modifies the OPAC's MARC21 search results XSLT so that
OPAC search result information is correctly labeled
based on the OpacItemLocation preference.

Previously, search results showed the label "Location(s)" whether the
setting was "collection code" or "location."

To test, apply the patch and set the OPACXSLTResultsDisplay system
preference to 'default.'

On the OPAC search results page, each result with items should show
information in this format:

   With the OpacItemLocation preference set to 'call number only,'
- "Availability: Items available for loan: {library} [Call number:
  {call number} ]

   With the OpacItemLocation preference set to 'collection code,'
 - "Availability: Items available for loan: {library}
Collection(s): {collection description} [{ call number }]"

   With the OpacItemLocation preference set to 'location,'
 - "Availability: Items available for loan: {library}
Location(s): {shelving location} [{ call number }]"

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

--- Comment #14 from Katrin Fischer  ---
There are still some oddities (punctuation, repeating the same
location/collection), but I believe this is a great improvement :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer  changed:

   What|Removed |Added

Summary|OpacItemLocation is buggy   |Wrong labels displaying in
   ||result list with
   ||OpacItemLocation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25699] Add edition information to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699

--- Comment #7 from Andrew Nugged  ---
(In reply to Katrin Fischer from comment #4)
> but it would be nice to also have steps for testing this.

all three of us noted that, ok, thanks :P.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105972|0   |1
is obsolete||

--- Comment #32 from Katrin Fischer  ---
Created attachment 106170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106170=edit
Bug 25322: fix for not selected "relationship" defaults to father

When a user creates a patron's guarantor on
/cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a
dropdown, the relationship defaults to first value, which in default sysprefs
is "father". This may or may not be correct as this is not a conscious choice
from the user.

The solution is to make the "Relationship" field mandatory when there is no
empty entry in the system preferences, always starting with an empty option but
not allowing the user to save an empty entry.
And if there is an empty option in sysprefs, it allows to save empty, as well
as makes it default choice.

To reproduce with default system preferences:
1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
3) Observe that relationship is set as "father".
4) Apply the patch.
5) Repeat steps 1 and 2.
6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

To reproduce with empty entry added to system preferences:
1) Add an empty entry to borrowerRelationship at
/cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section
(example: "|father|mother").
2) Create a new patron who is assumed to have a guarantor or modify the
existing one.
3) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
4) Observe that relationship is set as "father".
5) Apply the patch.
6) Repeat steps 1, 2 and 3.
7) Observe when you save the empty entry it does set the relationship as
empty.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759

--- Comment #2 from Katrin Fischer  ---
Hi Kyle, is there a way to add 'fake' EDI data for testing this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834

--- Comment #3 from Katrin Fischer  ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834

--- Comment #2 from George Williams (NEKLS)  ---
Yes, either would work, I think I prefer "Add guarantor" because it's simpler.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23204] Add script for exporting Elasticsearch mappings to YAML

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add script for exporting|Add script for exporting
   |elasticsearch mappings to   |Elasticsearch mappings to
   |YAML|YAML

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25699] Add edition information to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699

--- Comment #6 from Katrin Fischer  ---
*** Bug 25799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25799] Edition information to Holds queue report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 25699 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
I was about to file this as well. Adding Owen hoping he might have an idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25733] Return claims attention can't be cleared

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733

--- Comment #6 from Katrin Fischer  ---
If we add another pref, maybe we should make one for warning about active
claims? That way we could have different limits for total and active and if
only the active are to be counted the pref for resolved could be left empty.
(hope that makes sense)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686

--- Comment #18 from Katrin Fischer  ---
I think we should make sure that the biblionumber cannot be hidden in the
frameworks or at least output a warning on the system information tab if the
field linked to biblionumber is set to hidden in OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686

Katrin Fischer  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #17 from Katrin Fischer  ---
*** Bug 25826 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25826] All results link to 404 in staff and intranet (SOMETIMES)

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 25686 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #8 from Katrin Fischer  ---
Hi Marcel, I think a link to he 'full' display would really make me feel more
confident about this. And we could make to so it can be easily hidden if
needed.
Thx for taking my comments into consideration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Katrin Fischer  ---
The tests pass, but I am irritated by the output, can you explain?

t/db_dependent/Circulation.t .. 30/47 _FixOverduesOnReturn(137,
Koha::Item=HASH(0x560ff2799448)->itemnumber...) failed! at
/home/vagrant/kohaclone/C4/Circulation.pm line 2056.

It doesn't show without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Katrin Fischer  ---
(In reply to David Gustafsson from comment #4)
> Yes, I usually include a test-plan, this fix will not produce any change of
> behaviour with the current code, but causes a bug together with bug 14957.
> So in that case the test-plan would have to include applying that patch.

No change in behaviour can still be tested with and without the patch. I think
it would really help to get this moving and unlock bug 14957. But looking at
the patch I get an idea of why this is hard. Some example uses might still be
good to note and test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25841] Manual should reference update_patrons_category.pl rather than j2a.pl

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25841

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106165|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 106169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106169=edit
Bug 25839: Fix typo patron.streetype in member-main-address-style.inc

Typo in member-main-address-style.inc : patron.streetype > patron.streettype

Generates error :
Template process failed: undef error - The method Koha::Patron->streetype is
not covered by tests!

Test plan : try create a new patron

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25847] New: Set item to CART location when recording local use with statistical patron

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25847

Bug ID: 25847
   Summary: Set item to CART location when recording local use
with statistical patron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When checking an item out to a statistical patron to record a local use, it
would make sense to set the item to shelving location CART is the library is
doing the same on checking (by setting _ALL_: CART in
UpdateItemLocationOnCheckin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Katrin Fischer  ---
Hi Peter, there is a catch here:

MARC21 maps to copyrightdate by default
UNIMARC maps to publicationyear by default

We catch this in a lot of places to make the year appear for both. Could you
please add a fallback to catch and display whatever is used? There should be
quite a few examples in codebase.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827

Katrin Fischer  changed:

   What|Removed |Added

Summary|Update button for   |Add floating toolbar to the
   |request.pl needs to be  |holds summary page in staff
   |pinned in place |interface
Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827

Katrin Fischer  changed:

   What|Removed |Added

  Component|Hold requests   |Templates
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

--- Comment #11 from Daniel Gaghan  ---
I concur with Katrin, we have users who determine what material they read or
view next based on if there is a hold on the material. Not having that notice
will throw them off, especially when the "cannot autorenew due to hold" message
appears the day the item is due.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22332] Limit to currently available items in home library

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332

--- Comment #7 from Katrin Fischer  ---
I think I might be able to explain a bit:

If you have multiple items on a record, Zebra sees all the values and can
search for them, but it's 'a pool' of values. 

If you search for available and a certain library, there will be an available
item and one at the library, but it doesn't have to be the same item. The items
get lost in indexing, as every item field is indexed separately.

That makes it harder to fix this - I guess you'd need to create a combined
index of both values so you can search them in combination and ensure they are
from the same item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722

--- Comment #4 from Katrin Fischer  ---
(In reply to Laura Horgan from comment #3)
> Looks like this was fixed with elasticsearch so wondering if someone should
> look at this one as well bug number 22771

This is a different problem here:
Result lists can sort correctly depending on the indicators of 245 for Zebra
and Elasticsearch, but the lists result set is not created using either of
those. It's created with SQL and therefore we need a completely different fix
here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

--- Comment #10 from Katrin Fischer  ---
(In reply to Joy Nelson from comment #1)
> Holds are a 'flux state' that change frequently.  Is it realistic to state
> that hold have been placed on a title when those holds may or may not impact
> the autorenewal of that item?  Perhaps the hold is cancelled prior to the
> autorenewal check or the hold was filled with another item prior to
> autorenewal check?

I think yes, when a hold blocks a renewal or auto renewal it should be stated
as such (probably depends on AllowRenewalIfOtherItemsAvailable setting). It
could be cancelled, but if not you'd want to plan for the case that you can no
longer keep the item.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

J. Evans  changed:

   What|Removed |Added

 CC||jennie.evans@flower-mound.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25553] Edit item date sort does not sort correctly

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25553

Katrin Fischer  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #8 from Katrin Fischer  ---
*** Bug 25844 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25844] Sorting Date Accessioned or Date Last Seen from AddItem.pl page not sorting correctly

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25844

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 25553 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #34 from Victor Grousset/tuxayo  ---
While testing the advertised "Experimental MariaDB 10.3 support" for 19.05.x,
it turns out that this patch applied and fix two failure.

Will try to backport for 19.11.13

For the record the fixed failures are:

kohadev-koha@665e4031f5cf:/kohadevbox/koha$ time prove -r
t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Koha/Object.t
t/db_dependent/Circulation/MarkIssueReturned.t .. 2/4 DBD::mysql::st execute
failed: Incorrect datetime value: 'bad_date' for column
`koha_kohadev`.`issues`.`returndate` at row 1 [for Statement "UPDATE `issues`
SET `returndate` = ? WHERE ( `issue_id` = ? )" with ParamValues: 0='bad_date',
1=252] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.

#   Failed test 'An exception is thrown on bad date'
#   at t/db_dependent/Circulation/MarkIssueReturned.t line 181.
# expecting: Koha::Exceptions::Object::BadValue
# found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute():
Incorrect datetime value: 'bad_date' for column
`koha_kohadev`.`issues`.`returndate` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 157
# )
# Looks like you failed 1 test of 3.
t/db_dependent/Circulation/MarkIssueReturned.t .. 3/4 
#   Failed test 'Manually pass a return date'
#   at t/db_dependent/Circulation/MarkIssueReturned.t line 185.
t/db_dependent/Circulation/MarkIssueReturned.t .. 4/4 # Looks like you failed 1
test of 4.
t/db_dependent/Circulation/MarkIssueReturned.t .. Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/4 subtests 
t/db_dependent/Koha/Object.t  7/12 
#   Failed test 'Exception thrown correctly'
#   at t/db_dependent/Koha/Object.t line 359.
# expecting: Koha::Exceptions::Object::BadValue
# found: DBIx::Class::Exception
(DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value:
'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 157
# )
# Looks like you failed 1 test of 1.

#   Failed test 'Bad value tests'
#   at t/db_dependent/Koha/Object.t line 363.
# Looks like you failed 1 test of 16.
t/db_dependent/Koha/Object.t  10/12 
#   Failed test 'store() tests'
#   at t/db_dependent/Koha/Object.t line 366.
# Looks like you failed 1 test of 12.
t/db_dependent/Koha/Object.t  Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/12 subtests 

Test Summary Report
---
t/db_dependent/Circulation/MarkIssueReturned.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/db_dependent/Koha/Object.t  (Wstat: 256 Tests: 12 Failed: 1)
  Failed test:  10
  Non-zero exit status: 1
Files=2, Tests=16, 13 wallclock secs ( 0.05 usr  0.01 sys +  9.84 cusr  1.82
csys = 11.72 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25846] New: Improve handling of multiple covers on catalog search results in the staff client

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846

Bug ID: 25846
   Summary: Improve handling of multiple covers on catalog search
results in the staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 25031

Similar to Bug 25031, I'd like to add better handling of multiple cover images
to catalog search results in the staff client.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031
[Bug 25031] Improve handling of multiple covers on the biblio detail page in
the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846
[Bug 25846] Improve handling of multiple covers on catalog search results in
the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600

Nick Clemens  changed:

   What|Removed |Added

 Blocks||25845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845
[Bug 25845] Cannot limit system logs to 'api' interface
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845

Nick Clemens  changed:

   What|Removed |Added

 Depends on||22600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600
[Bug 22600] We should add an 'interface' field to accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25845] New: Cannot limit system logs to 'api' interface

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845

Bug ID: 25845
   Summary: Cannot limit system logs to 'api' interface
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 22600 added the 'api' interface to the system, we should also add this as a
limit in the tools

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25844] New: Sorting Date Accessioned or Date Last Seen from AddItem.pl page not sorting correctly

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25844

Bug ID: 25844
   Summary: Sorting Date Accessioned or Date Last Seen from
AddItem.pl page not sorting correctly
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When on the detail.pl page of a record, the ability to sort by Date Last Seen
and Date Acquired works correctly.  If you go to the additem.pl page, and try
to sort these same columns, they do not work correctly. The dates are all
formatted correctly in both columns and just sort oddly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

Daniel Gaghan  changed:

   What|Removed |Added

 CC||daniel.gaghan@pueblolibrary
   ||.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722

Laura Horgan  changed:

   What|Removed |Added

 CC||horg...@middlesex.mass.edu

--- Comment #3 from Laura Horgan  ---
Looks like this was fixed with elasticsearch so wondering if someone should
look at this one as well bug number 22771

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834

--- Comment #1 from Katrin Fischer  ---
Hi George, I see you added yourself CC - would the suggested change work for
you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Daniel Gaghan  changed:

   What|Removed |Added

 CC||daniel.gaghan@pueblolibrary
   ||.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25843] New: Send patron updates to Staff Review

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25843

Bug ID: 25843
   Summary: Send patron updates to Staff Review
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j...@bywatersolutions.com

Using Patron REST API when patrons submit updates to their information (new
address, phone, etc) the updates go straight into the database.  Can the
updates be send to the staff so the changes can be reviewed and accepted?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958

--- Comment #16 from Sally  ---
Ace, thanks, Owen.  Yeah, we're definitely following the same process - just a
different end result.  I've added a screenshot so you can see the storage
persisting after I've logged out.

My work PC is Windows, Chrome 83.

It's a managed browser, so I just tested on my Chromebook to see if that
resolved it, but I get the same error.  That's Chrome OS, Chrome 83.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22332] Limit to currently available items in home library

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332

--- Comment #6 from Christopher Brannon  ---
(In reply to Holly from comment #5)
> According to Bug 11677 "limit to currently available items" should be
> working on the recent releases, however, I am testing on a 19.11.06 and
> while results are being limited, they are including items marked as Lost.
> Based on the test plan in Bug 11677, I assumed items marked as Lost would
> count as not available and records with Lost items and all other items
> checked out would not appear when the "limit to currently available items"
> was selected.
> 
> Is the "limit to currently available items" working or not working for
> others? 
> 
> Also +1 for the option to limit search results to items currently available
> in the patron home library.

We are also currently using 19.11.6, and this facet is messed up.  It isn't
showing everything that is available, and it is showing things that shouldn't
be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958

--- Comment #15 from Sally  ---
Created attachment 106168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106168=edit
Local Storage setting on log out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25776] Last updated / modified date on notices

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25776

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #1 from George Williams (NEKLS)  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25809] Make claims returned claims visible in the OPAC

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25809

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #2 from George Williams (NEKLS)  ---
I agree with Donna.  It would be nice if this was a choice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25827] Update button for request.pl needs to be pinned in place

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #1 from George Williams (NEKLS)  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22332] Limit to currently available items in home library

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

--- Comment #5 from Holly  ---
According to Bug 11677 "limit to currently available items" should be working
on the recent releases, however, I am testing on a 19.11.06 and while results
are being limited, they are including items marked as Lost. Based on the test
plan in Bug 11677, I assumed items marked as Lost would count as not available
and records with Lost items and all other items checked out would not appear
when the "limit to currently available items" was selected.

Is the "limit to currently available items" working or not working for others? 

Also +1 for the option to limit search results to items currently available in
the patron home library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25825] Allow Claim Return function to be controlled by permissions

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825

--- Comment #1 from George Williams (NEKLS)  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25825] Allow Claim Return function to be controlled by permissions

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Peter Vashchuk  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

--- Comment #1 from Peter Vashchuk  ---
Created attachment 106167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106167=edit
Bug 25798: Add copyright year to "Holds to pull" report

Display copyright year (publication year) of book
together with title in "Holds to pull" report.

Copyright year is fetched from biblio -table as "copyrightyear".

1. Place a hold on book with known copyright year.
2. Go to /cgi-bin/koha/circ/pendingreserves.pl and check the "title"
table of that book that you placed hold on.
3. Observe that there's no information about publication year in that
field.
4. Apply patch.
5. Repeat step 2.
6. Observe that copyright year (publication year) of book appeared
in the title table after book's title and author.

Mentored-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Peter Vashchuk  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783

--- Comment #13 from Kyle M Hall  ---
Created attachment 106166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106166=edit
Bug 25783: Modify calls to AddReserve to match Koha 19.11.x AddReserve
prototype

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Peter Vashchuk  changed:

   What|Removed |Added

 CC||stalkern...@gmail.com
   Assignee|koha-b...@lists.koha-commun |stalkern...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25842] Typo "streetype" in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25842


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842
[Bug 25842] Typo "streetype" in member-main-address-style.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25842


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842
[Bug 25842] Typo "streetype" in member-main-address-style.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25842] New: Typo "streetype" in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842

Bug ID: 25842
   Summary: Typo "streetype" in member-main-address-style.inc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: fridolin.som...@biblibre.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: fridolin.som...@biblibre.com,
testo...@bugs.koha-community.org
Depends on: 25070, 25839

There are several more instances of the incorrect variable "streetype" in
member-main-address-style.inc. While not error-causing, they should be
corrected for consistency.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070
[Bug 25070] Include files to display address and contact must be refactored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839
[Bug 25839] Typo patron.streetype in member-main-address-style.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106156|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 106165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106165=edit
Bug 25839: Fix typo patron.streetype in member-main-address-style.inc

Typo in member-main-address-style.inc : patron.streetype > patron.streettype

Generates error :
Template process failed: undef error - The method Koha::Patron->streetype is
not covered by tests!

Test plan : try create a new patron

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

--- Comment #3 from Owen Leonard  ---
I couldn't reproduce the error in my tests, but the fix look correct so I
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492

Owen Leonard  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

--- Comment #10 from Owen Leonard  ---
*** Bug 25831 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25831] Refine your search button on mobile devices does not work

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25831

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This has been fixed in master and will be in 19.11.07

*** This bug has been marked as a duplicate of bug 25492 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24625] Phase out jquery.cookie.js: showLastPatron

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625

Owen Leonard  changed:

   What|Removed |Added

 Attachment #105946|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 106164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106164=edit
Bug 24625: Store showLastPatron information using localStorage

This patch removes the use of jquery.cookie to store "last patron"
information, using localStorage instead.

Because there is no "session only" option with localStorage, additional
handling of the showLastPatron data is added to the login page. That
takes care of "stale" last patron information if user didn't log out but
the session expired for some reason.

To test apply the patch and enable the showLastPatron system preference.

 1. Load a patron's account for checkout
 2. Navigate away from patron-related pages: Perform a catalog search
from the search header form and open the detail page from the search
results. Confirm that the correct last patron information still
shows.
 3. Load another patron's account for checkout
- There should now be a "Last patron" link in the breadcrumbs bar
  which links to the patron in step 1. Hovering your mouse over the
  link should display a tooltip containing the patron's name and
  card number.
- Click the "X" to clear the last patron information. The last
  patron link should go away.
 4. Log out and log back in. The last patron information should be gone.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24625] Phase out jquery.cookie.js: showLastPatron

2020-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >