[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

David Nind  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

--- Comment #1 from David Nind  ---
Created attachment 106356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106356=edit
Bug 25717: Improve automatic renewal error messages

Improve wording and grammar for automatic renewal error messages.

Test plan:
1. Review the error message changes and make sure they make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |da...@davidnind.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

David Nind  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Component|Architecture, internals,|Circulation
   |and plumbing|
 CC||da...@davidnind.com,
   ||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

--- Comment #7 from Owen Leonard  ---
> I am in 19.11.06, and we do not get the "Guarantor information" fieldset
> with details about the adult record I started with."

I think Bug 23808 fixes this as of 19.11.07.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106351|0   |1
is obsolete||

--- Comment #14 from Owen Leonard  ---
Created attachment 106355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106355=edit
Bug 25654: Make the contact and non-patron guarantor sections separate on
patron entry form

This patch reverses what I think was an unintended change made by Bug
14570 in which the non-patron guarantor fields are shown for all patron
types (not just child patrons) and  grouped with the patron contact fields.

This patch creates a new "Non-patron guarantor" fieldset to show along
with "Patron guarantor" when adding or editing child patrons.

To test, apply the patch check that the  BorrowerUnwantedField system
preference does not contain contactname, contactfirstname,
or relationship.

 - Open an adult patron for editing. You should see no guarantor-related
   fields.
 - Open a child patron for editing. There should be two guarantor
   sections: "Patron guarantor" and "Non-patron guarantor."
   - Test that adding patron guarantors and non-patron guarantors works
 correctly.
   - Add "contactname|contactfirstname|relationship" to the
 BorrowerUnwantedField system preference.
   - Reload the child patron entry form. The non-patron guarantor
 section should now be hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25885] Wait for OverDrive results before redirecting to single Koha result

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885

Owen Leonard  changed:

   What|Removed |Added

Summary|Koha takes you straight |Wait for OverDrive results
   |into detail.pl when there   |before redirecting to
   |is only one result - bad|single Koha result
   |for OverDrive link  |
Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25885] New: Koha takes you straight into detail.pl when there is only one result - bad for OverDrive link

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885

Bug ID: 25885
   Summary: Koha takes you straight into detail.pl when there is
only one result - bad for OverDrive link
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

I would like to suggest, if you have OverDrive (or other 3rd party databases)
enabled on Koha, that Koha NOT push you straight into a record (detail.pl) if
there is only one "Koha" result.  You end up not being able to see OverDrive
results, or switch over to OverDrive when it does that.  Makes the connectivity
useless for those with pin-point searching skills.

When you enable one of these databases, that should be all you need to disable
the default Koha behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25847] Set item to CART location when recording local use with statistical patron

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25847

rco...@arlingtonva.us changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #1 from rco...@arlingtonva.us ---
This would be extremely useful for our staff that search the Holds Queue
report.  I add my support to this bug fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13978] Add cancellation link to hold notification e-mails

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978

--- Comment #3 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #2)
> I think achieving this without having to log in first is the harder bit,
> because you want a link that cannot be guessed and misused by someone else.
> You'd need a token or similar that only the email recipient and Koha know. A
> link into the catalog would be easier.

Maybe the token could be based on the reservation ID, or that and the borrower
ID?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #106167|0   |1
is obsolete||

--- Comment #3 from Peter Vashchuk  ---
Created attachment 106354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106354=edit
Bug 25798: Add copyright year to "Holds to pull" report

Display copyright year (publication year) of book
together with title in "Holds to pull" report.

Copyright year is fetched from biblio -table as "copyrightyear"
and displayed when the preferred marc is set to MARC21.
Publication year is fetched from biblioitems -table as "publicationyear"
and displayed when the preferred marc is set to UNIMARC.

1. Place a hold on book with known copyright year.
2. Go to /cgi-bin/koha/circ/pendingreserves.pl and check the "title"
table of that book that you placed hold on.
3. Observe that there's no information about publication year in that
field.
4. Apply patch.
5. Repeat step 2.
6. Observe that copyright year (publication year) of book appeared
in the title table after book's title and author.

Mentored-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13752] Item level holds crossed if item moved to another bib

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752

--- Comment #6 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #3)
> Wondering: if you move the order using the transfer option, the biblionumber
> would not change. There must be another step we are missing?

If there is a step that is missing, I'm not sure what it is.  But, this does
point out how this can get messed up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13550] Automatic processing status

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13550

--- Comment #2 from Christopher Brannon  ---
I think, ultimately, what is needed is a way to make a list of items, where you
can schedule a one time or reoccurring task.  Maybe even make use of the lists
option (but you would need to be able to list a specific item).  The automatic
item modifications is good, but to try and set a rule for every item you want
to fall into this behavior would be an onerous task.  If there were a way to
link a list of items (again items, not bibs) to one of these rules, that would
be a HUGE improvement.

But it would also help if this tool could be triggered not just by age, but
other counts, like number of issues, or by a certain date.

Does that make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25884] New: Automatic item modifications by age needs title and description fields

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25884

Bug ID: 25884
   Summary: Automatic item modifications by age needs title and
description fields
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

We need to be able to label and describe these rules outside of the settings we
set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #13 from Owen Leonard  ---
*** Bug 25742 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25742] Non-member guarantor fields show in non minor accounts

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25742

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 25654 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

David Nind  changed:

   What|Removed |Added

 Attachment #106350|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 106353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106353=edit
Bug 23148: (follow-up) Replace gif files in the OPAC with pngs

This patch removes the old gif files from the OPAC bridge set and
replaces them with png files.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

David Nind  changed:

   What|Removed |Added

 Attachment #106349|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 106352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106352=edit
Bug 23148: Replace Bridge icons with transparent PNG files

This patch adds SVG versions of the Bridge item type icon set to
misc/interface_customization/itemtypeimg/bridge. It adds some
new icons, and updates some existing icons. All GIF versions of the
icons are replaced with transparent PNG files.

Icon changes:

- English text has been removed from all icons
- New icon for "Periodical," to differentiate from "Journal"
- New icon, "Controller" for video games
- New icon for "Laserdisk" to differentiate from "DVD"
- New icon for "Kit" to differentiate from "Archive"
- New icon, "Reference books."
- Updated "badges" on "Juvenile book" and "Reserve book" to try to
  express the information without English-specific letters.

Before applying the patch, update some item types or collection codes
with Bridge icons. Apply the patch and run the database update process.

 - Open the advanced search page in the staff client and confirm that
   your item type or collection code icons were updated correctly.
 - Go to Administration -> Item types and edit an item type.
   - Check the "bridge" tab and confirm that the icon options look
 correct.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #12 from Owen Leonard  ---
Created attachment 106351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106351=edit
Bug 25654: Make the contact and non-patron guarantor sections separate on
patron entry form

This patch reverses what I think was an unintended change made by Bug
14570 in which the non-patron guarantor fields are shown for all patron
types (not just child patrons) and  grouped with the patron contact fields.

This patch creates a new "Non-patron guarantor" fieldset to show along
with "Patron guarantor" when adding or editing child patrons.

To test, apply the patch check that the  BorrowerUnwantedField system
preference does not contain contactname, contactfirstname,
or relationship.

 - Open an adult patron for editing. You should see no guarantor-related
   fields.
 - Open a child patron for editing. There should be two guarantor
   sections: "Patron guarantor" and "Non-patron guarantor."
   - Test that adding patron guarantors and non-patron guarantors works
 correctly.
   - Add "contactname|contactfirstname|relationship" to the
 BorrowerUnwantedField system preference.
   - Reload the child patron entry form. The non-patron guarantor
 section should now be hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13165] Active Hold Limit

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165

--- Comment #2 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #1)
> You kinda lost me there 
> "I would love to see holds updated to act kind of like the Netflix DVD queue
> system." :)

Are you being funny, or just don't know?  Maybe it is just a US thing?

Basically, a patron could have placed 50 holds, but they are only allowed to
have 10 holds at a time.

Thinking about this more, we can kind of do this, but it means limiting the
checkouts to 10.

But the idea behind this is that their next hold request cannot get triggered
until they are below the threshold.  That threshold could be:
* Number of items currently checked out
* Number of items currently checked out from other libraries
* Number of items currently in transfer or waiting

I'm leaning towards the second one: Number of items currently checked out from
other libraries.  But, you could have 50 items on their way, and then after the
10th item checks out, the rest turn around and go home or to the next person. 
Waste of time.  It might need to be a combination of the second and third. 
number of items currently transfer or waiting, and then if that is below the
threshold, number of items currently checked out from other libraries.

This idea stems from examples of patrons that hoard lots of items through
holds.  We also have patrons that place tons of holds and either don't pick
them up, or pick through what comes in and only checks out what they want. 
Holds are not for browsing here.

I HOPE that helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #11 from Owen Leonard  ---
Guarantors are usually assumed to be parents or guardians. That's why there is
the option to show the guarantee's checkouts to the guarantor.

Having a separate alternate contact allows there to be a greater separation
between the patron and the contact.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12077] Give superlibrarian ability to remove selected patron fine history.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12077

--- Comment #2 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #1)
> For the unwanted credit, does the new 'void' and credit related features
> solve the issue?

No.  We still end up with items we can't resolve on our end of things.  We
still end up asking ByWater to remove credits or line items that should not be
there.  There are some libraries that are not allowed to fix mistakes with
credit, writeoffs or voids.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25654


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
[Bug 25654] Make the contact and non-patron guarantor sections separate on
patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4948] When cancelling a waiting hold, allow to trigger hold for next patron

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry  ---
Kyle, you've got comparable functionality for automatically cancelled holds
waiting for another signoff over on bug 14364. Could that work be expanded to
cover manually-cancelled waiting holds?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

 Depends on||14570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
[Bug 14570] Make it possible to add multiple guarantors to a record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #10 from Benjamin Daeuber  ---
Is there a sense of who's using the alternate contact fields other than for
guarantor information? We use the alternate address for college students and
people who might own property in town but actually live out of town. We mostly
use the alternate contact field as described above, but I would hate to
shoehorn guarantor information into those fields if they are in use otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

Summary|Making the Contact Section  |Make the contact and
   |/ Guarantor Section |non-patron guarantor
   |separate from the Contact   |sections separate on patron
   |details of the patron would |entry form
   |be less confusing   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

--- Comment #6 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #3)
> Here's what I see when I test in 19.11.x:
> 
> 1. Open patron detail page for an adult record
> 2. Click "Add guarantee" button
> 3. Patron edit form opens. I see:
>- Blank "Patron identity" form fields.
>- "Guarantor information" fieldset with details about
>  the adult record I started with.
>- "Main address" and "Contact" fields are filled in
>  with information from adult record.
> 4. I enter the child name and card number, click save.
> 5. I'm redirected to the detail record for the newly-added
>child account.
> 6. Under "Guarantor" on this page is the name of the adult
>I started with, linked to that patron's account.

I am in 19.11.06, and we do not get the "Guarantor information" fieldset with
details about the adult record I started with."

Even after I save, it is not linked to the guarantor.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

--- Comment #5 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #4)
> Also check the value in your PrefillGuaranteeField preference.

That is added in 20.05.  We are 19.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24450] Clarify wording when unable to cancel order and delete record

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24450

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

--- Comment #4 from Owen Leonard  ---
Also check the value in your PrefillGuaranteeField preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

--- Comment #3 from Owen Leonard  ---
Here's what I see when I test in 19.11.x:

1. Open patron detail page for an adult record
2. Click "Add guarantee" button
3. Patron edit form opens. I see:
   - Blank "Patron identity" form fields.
   - "Guarantor information" fieldset with details about
 the adult record I started with.
   - "Main address" and "Contact" fields are filled in
 with information from adult record.
4. I enter the child name and card number, click save.
5. I'm redirected to the detail record for the newly-added
   child account.
6. Under "Guarantor" on this page is the name of the adult
   I started with, linked to that patron's account.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25063] OPAC Renewal Option

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063

--- Comment #4 from Owen Leonard  ---
If the enhancement you describe should be implemented all in one go, then one
bug report is fine. The way you worded the description made it sound like there
were different aspects which could be implemented separately.

Although no enhancement request is guaranteed to be taken up by volunteers, it
does increase the likelihood that a volunteer will tackle an enhancement
request if it can be broken down into its smallest usable component. The
"depends on" and "blocks" fields can be used to link bugs together if one can't
be implemented without another.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12450] Closing libraries for the summer

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450

--- Comment #10 from Christopher Brannon  ---
Just an update on this.  We have been able to transition away from using jQuery
to block pickup locations.  At some point we discovered the preference under
the library settings that allow us to turn the pickup location on and off.  So,
this simplified things.

I don't know at this point, if the patron's pickup location is turned off, if
they are warned that their pickup location has changed, when they place a hold.
 Also, what does this do for items that are already on hold with that pickup
location specified?  To my knowledge, the setting only affects selecting that
location on new holds.  Those current holds are stuck in limbo.

I do think that a lot of pieces are in place.  Ideally, it would be great if
there was a closure tool that set several of these pieces for you:

* Do you want to mark the location as closed?
  - From what date to what date?
* Do you want the pickup location turned off during this time?
  - This should turn off the pickup location, and then back to the prior state,
based on the schedule above.
* Do you want patrons to be able to place holds on these items?
  - This should set the default hold policy for this library and then return to
prior state, according to the schedule above.
* Do you want items to return to this library or to another library?
  - Set to new library and then prior state, according to the schedule above.
* Do you want circulation rules set with a hard due date?
  - Set to new condition, then prior state, according to the schedule above.
* Do you want a news announcement made?
  - Set new message that is set and expires according to the schedule above.

Those are just some things I can think of.  All of these are things that we can
do, manually.  You just have to remember to do them all.  If there was a page
that guided you through this process, showed you schedules that have been set
to do all of these things, this would be a great enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12090] Disabling Library Location

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090

--- Comment #7 from Christopher Brannon  ---
Thanks for the info.  Good to know.  This does make a difference.  I will
continue my campaign on the other bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25063] OPAC Renewal Option

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063

--- Comment #3 from Christopher Brannon  ---
Okay, first off, this is an idea of a new feature.  While I list three or four
specific changes, that all center around the concept of this feature.  I COULD
file each separately, but then the concept of patron renewal would be obscured.
 If you still think this should be 3 or 4 individual enhancements, I can do
that.  But I'm not sure why that is being imposed here when other features are
added that change several elements.  Would just like to understand the
difference so I can be consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

Christopher Brannon  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Christopher Brannon  ---
No, there is no understanding.  It creates a new minor (child) record, as
expected.  But there is no link to the guarantor (parent) account.  While
filling out the child account, you will notice there is no information about
the guarantor in the guarantor fields.  And the account is not linked once you
finish editing and save.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #9 from Caroline Cyr La Rose  ---

> And I'm not sure of the original intent of the development, but as it stands
> now, I think this is a serious issue if we are indeed distinguishing between
> alternate contact and non-patron guarantor contact. And if we're not, why
> add the non-patron guarantor feature at all?

Pre-19.11 we could add non-patron guarantors in the guarantor information (only
first and last names). I think that's why we want to keep it.

I suggest you go give a +1 to bug 12446 which is to allow adults (or any patron
category in fact) to have guarantors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #8 from Benjamin Daeuber  ---
(In reply to Caroline Cyr La Rose from comment #7)
> Pre-19.11, the alternate contact section would be used for that.
> 
> But I agree that yours is a good idea. That would mean moving the Alternate
> contact section to the 'Guarantor information' section and only making it
> appear if we choose 'Non-patron guarantor', I guess?

We use the alternate contact for adults that have guarantors, but which we
can't actually add guarantors to (which is a whole other issue). So I think we
need a whole new set of contact information.

And I'm not sure of the original intent of the development, but as it stands
now, I think this is a serious issue if we are indeed distinguishing between
alternate contact and non-patron guarantor contact. And if we're not, why add
the non-patron guarantor feature at all?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106337|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 106349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106349=edit
Bug 23148: Replace Bridge icons with transparent PNG files

This patch adds SVG versions of the Bridge item type icon set to
misc/interface_customization/itemtypeimg/bridge. It adds some
new icons, and updates some existing icons. All GIF versions of the
icons are replaced with transparent PNG files.

Icon changes:

- English text has been removed from all icons
- New icon for "Periodical," to differentiate from "Journal"
- New icon, "Controller" for video games
- New icon for "Laserdisk" to differentiate from "DVD"
- New icon for "Kit" to differentiate from "Archive"
- New icon, "Reference books."
- Updated "badges" on "Juvenile book" and "Reserve book" to try to
  express the information without English-specific letters.

Before applying the patch, update some item types or collection codes
with Bridge icons. Apply the patch and run the database update process.

 - Open the advanced search page in the staff client and confirm that
   your item type or collection code icons were updated correctly.
 - Go to Administration -> Item types and edit an item type.
   - Check the "bridge" tab and confirm that the icon options look
 correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

--- Comment #4 from Owen Leonard  ---
Created attachment 106350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106350=edit
Bug 23148: (follow-up) Replace gif files in the OPAC with pngs

This patch removes the old gif files from the OPAC bridge set and
replaces them with png files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #7 from Caroline Cyr La Rose  ---
Pre-19.11, the alternate contact section would be used for that.

But I agree that yours is a good idea. That would mean moving the Alternate
contact section to the 'Guarantor information' section and only making it
appear if we choose 'Non-patron guarantor', I guess?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #6 from Benjamin Daeuber  ---
I guess my point is that (In reply to Caroline Cyr La Rose from comment #5)
> The contact information is that of the patron, not the guarantor. That is
> the main confusion reported by Kelly.
> 

I think we need additional contact fields if this is the case. A whole separate
section for non-patron guarantor contact information labeled "Non-Patron
Guarantor". Right now there is essentially one set of contact info and it
appears like it could belong to the non-patron guarantor who doesn't actually
have any contact info.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25742] Non-member guarantor fields show in non minor accounts

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25742

--- Comment #3 from Christopher Brannon  ---
The non-member guarantor information should not be with the "Contact" info. 
The contact info (phone numbers and e-mails) have to do with the patron.  The
non-member guarantor info needs to be with the rest of the guarantor fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25733] Return claims attention can't be cleared

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733

--- Comment #7 from Christopher Brannon  ---
Ideally, I could see the following to be a benefit:
* Preference about the warning behavior
  - Should it show in the warning panel or a banner
  - Should claims show counts for claims, or total claims and claims unresolved
  - Should total claims have resolved claims that don't count towards total
claims
  - Should it block or not
-- Should it block on total claims or claims unresolved
  - Should resolved claims have a moratorium - should they count against the
patron for a set length of time or indefinitely

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

--- Comment #5 from Caroline Cyr La Rose  ---
(In reply to Benjamin Daeuber from comment #4)
> Is the implication if we move those fields that the non-patron guarantors
> will not have contact information?

The contact information is that of the patron, not the guarantor. That is the
main confusion reported by Kelly.

I also find it confusing to have a section named 'Guarantor information', and
then other fields named 'Guarantor something' that are not in that section.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12247] order_manage_all only works if branch is set in basket

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12247

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Christopher Brannon  ---
This is an old bug.  I'm going to mark it as resolved, as things have changed
quite a bit.  If it is an issue in the future, we can open a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

--- Comment #4 from Benjamin Daeuber  ---
Is the implication if we move those fields that the non-patron guarantors will
not have contact information?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #8 from Martin Renvoize  ---
That's better.

So.. before I signoff I'd be interested in opinions on my above question
regarding readability and making it match other blocks that do the same logical
fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #106347|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #7 from Martin Renvoize  ---
Created attachment 106348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106348=edit
Bug 25850: Add Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Christopher Brannon  ---
Agustin, Kidclamp had to rebase a minor conflict.  I don't know the details.

After that, this is what I found:

Everything works except the Batch Item Modification.  It did not change the
setting for the items specified.  Might be because of the rebase.  Please
check.

Also, the description on the patron category is confusing.  It should read "If
Yes, holds placed by patrons of this category will not be given priority."

I am also unable to prove the test, step 21.  I am testing from a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Nick Clemens  changed:

   What|Removed |Added

 Blocks||25750


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750
[Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening
when no 'Actual cost' entered
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Depends on||25322


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322
[Bug 25322] Adding a guarantor with no relationship defaults to first available
relationship name
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25883] New: Show transfer on checkin screen

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883

Bug ID: 25883
   Summary: Show transfer on checkin screen
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When an item generates an automatic transfer at checkin, there's nothing on the
checkin screen to indicate that the transfer has generated. Following bug
23129, the holding branch shows the library where the item was checked in,
rather than the library the item is going to. That's a good an accurate change,
but means we don't have any way to see the transfer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #6 from Martin Renvoize  ---
Added the beginnings of a test there.. first one is unrelated but I wrote it
whilst working out options to test each weekday holiday option.. second patch
I've not managed to get failing yet.. bear with.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #5)
> Please remember to document on the wiki:
> https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks Thx!

Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #5 from Martin Renvoize  ---
Created attachment 106347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106347=edit
Bug 25850: WIP - Add Unit Test

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #4 from Martin Renvoize  ---
Created attachment 106346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106346=edit
Bug 25850: Add tests for weekday holidays

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864

Heather  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Heather  ---
Works well!  I can't wait to get this fix in our catalog!  Thank you, Nick, and
everyone!!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #106247|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 106345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106345=edit
Bug 25864 - Lower case fields for searching

To recreate:
 1 - Have Koha using ES5 and Elasticsearch as search engine
 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
 3 - Do a search in authorities using 'Search entire record' (abduction if
using sample db)
 4 - Note no results
 5 - View the page source and find 'search_query'
 6 - Note the uppercased fields
 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty'
 8 - Note all fields lower-cased
 9 - Apply patch
10 - Repeat search
11 - It works!

Signed-off-by: Heather Hernandez 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #8 from Heather  ---
I would really like to see work on this advance, as the new functionality in
19.11 with the Advanced Biblio Editor's only being able to copy an entire
subfield or copy an entire field has really "broken" my cataloging workflow.

The main problem that I'm having is that I can no longer highlight a portion of
a subfield--I can no longer highlight just a bit of text for copying/pasting in
the ABE (Advanced Bibliographic Editor...see, I like to keyboard things short
and fast...)  I need to highlight to copy a whole field only a few times a day,
and I need to highlight to copy an entire subfield a couple of times a month,
but I want to highlight-copy-paste a portion of text dozens if not hundreds of
times a day, e.g.:

Just typed the author's name in the 245 $c, so I will highlight the most
complicated/likely to have typos/unique portion of their name element for
pasting into the search box to search authorities.  (I have authorities open in
another tab for searching & copy/paste from that tab into the ABE--any of the
searching/linking functions from within the ABE are too cumbersome and slow.) 
But...oh, yeah...I can't highlight any *portion* of the 245 $c anymore.

Just typed the 505 contents note and want to copy/paste as above for concepts
that are candidates for subject headings but...oh, yeah...I can't highlight
just one word in from one of the $t (title) fields.

Just typed a city in the 264 and I'd like to use it in geographic subfields,
but in the 264 $a (a transcription field), it's "San Francisco, CA" so I want
to copy just "San Francisco" to make that an entire $z in a 6XX field but, oh,
right, I can't copy just a portion of a field.  I can copy the whole $a and
then backspace to delete the "CA" which adds keystrokes.  I don't like added
keystrokes.  Added keystrokes make catalogers go cranky-pants.

These are just some of the instances where I want to highlight just a portion
of a subfield.  I could go on and on and on.  Real Catalogers Who Have Taken
The Red Pill Of MARC21 To Use The ABE For What It Is *love love love*
keyboarding because it's all about the speed, babies--our minds are creating
that MARC21 record at the Speed of Thought and our hands need to go as fast as
possible with using Absolute Tons and Tons of
shift-back-arrow-until-word-is-highlighted (maybe occasionally reaching for a
mouse but not often because mousing is wwwer) and then wanting
to...yes...ctrl-c to copy!  Copy!!  Copy it to the clipboard so you can paste
it later!!  All this copying/pasting is used to help avoid typos because typos
are One Of The Enemies!  We hates typos, my precious ye we hatesss
them!!!  The typos and the slow mousing stand in the way of public services
getting the library materials into the waiting hands of the users so we
Catalogers must type the original records as fast as we can!!!  Edit as fast as
we can!!!

So could we please, pretty please, with whipped cream, chocolate sprinkles,
hundreds and thousands, nonpareils, and many cherries and chopped peanuts on
top, restore the ability to copy a portion of text within the ABE to the
clipboard?  It's now what I want most out of Koha.  I'll wait for anything else
that you have if I can have this back.

I'm wiping my brow and opening Connexion Client because I just really can't use
the ABE until I get this functionality back.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25799] Edition information to Holds queue report

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799

Andrew Nugged  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |nug...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25838] Sort facets values by number of occurrences (Zebra)

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #12 from Fridolin SOMERS  ---
Ok its indeed not simple to choose.
I set in discussion, and will close if does not move for a while.
Thanks for your time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631

--- Comment #64 from Julian Maurice  ---
(In reply to Kyle M Hall from comment #61) 
> As an FYI, the idea here is to check the database for the metadata to avoid
> loading the plugin. If it's not in the database, we load the plugin and ask
> it for its' metadata. When we as a plugin for it's metadata it checks
> A) For metadata in it's own Perl module ( fastest )
> B) Checks the database ( second fastest, for convenience when the plugin is
> already loaded, is skipped when upgrading plugins )
> C) The PLUGIN.yml file if it exists ( slowest, but these speeds are all
> relative to each other ;)

I am not sure if I understood that part correctly. You are saying that plugin's
metadata can be in 3 different places (Perl module, database, and YAML file)
now ? And in order to read the YAML file we need to load the module first ?
What are the benefits ?

You are talking about performance of different methods. Have you measured it ?
Do we really gain that much by storing metadata in MySQL ? Have you considered
caching metadata in memcache ?

I thought that the yaml file would become the only source of truth and that it
would allow us to avoid loading the Perl module when not needed (especially for
disabled modules).

I'm sorry but I really don't see what we gain here. If this is for easing
parsing by external tools, then you can just dump the Perl module's metadata
into a YAML file when you create the .kpz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106342|0   |1
is obsolete||

--- Comment #6 from Alex Arnaud  ---
Created attachment 106344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106344=edit
Bug 25882: Remove phr indicator from limits when processing

We assume all limits from advanced search to be a phrase and quote them
when doing this we should remove the phrase marker to avoid doulbe quoting

To test:
 1 - Have koha using ES
 2 - Go to advanced search
 3 - Limit by a single itemtype that exists
 4 - Get some results
 5 - Limit by a different itemtype that exists
 6 - Get some results
 7 - Limit by both itemtypes
 8 - Get only the results for the second itemtype
 9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")
13 - Apply patches
14 - Restart all the things
15 - Repeat search for both itemtypes
16 - Note results now include both types

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106338|0   |1
is obsolete||

--- Comment #5 from Alex Arnaud  ---
Created attachment 106343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106343=edit
Bug 25882: Unit test

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

--- Comment #3 from Alex Arnaud  ---
Tested with es-5 and es-6, ok.
Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106339|0   |1
is obsolete||

--- Comment #4 from Alex Arnaud  ---
Created attachment 106342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106342=edit
Bug 25882: Remove phr indicator from limits when processing

We assume all limits from advanced search to be a phrase and quote them
when doing this we should remove the phrase marker to avoid doulbe quoting

To test:
 1 - Have koha using ES
 2 - Go to advanced search
 3 - Limit by a single itemtype that exists
 4 - Get some results
 5 - Limit by a different itemtype that exists
 6 - Get some results
 7 - Limit by both itemtypes
 8 - Get only the results for the second itemtype
 9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")
13 - Apply patches
14 - Restart all the things
15 - Repeat search for both itemtypes
16 - Note results now include both types

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106285|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 106341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106341=edit
Bug 25875: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25799] Edition information to Holds queue report

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #2 from Andrew Nugged  ---
that one (25699) was about "Holds to pull" report, this one about "Holds queue"
– Katrin, can we return this back to the stream?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #8 from Christopher Brannon  ---
(In reply to Christopher Brannon from comment #7)
> This is only one of four criteria that was specifically asked for in
> exclusion:  patron categories, item types, formats, or specific items.
> 
> I will test this patch, but it cannot be signed off as is.

Ignore this comment.  The description of the test wasn't clear.  I will test to
see if all four criteria are met and works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #7 from Christopher Brannon  ---
This is only one of four criteria that was specifically asked for in exclusion:
 patron categories, item types, formats, or specific items.

I will test this patch, but it cannot be signed off as is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #3 from Martin Renvoize  ---
I like the modulo approach you've used, but I wonder if perhaps it's a tiny bit
clearer if you use the same approach as the 'is_holiday' method uses a few
lines beneath your fix?

Also.. I'd love to see a unit test added to prevent future regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

--- Comment #4 from Matthias Meusburger  ---
Thanks for the feedback, Katrin. The new patch uses item instead of document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

--- Comment #3 from Matthias Meusburger  ---
Created attachment 106340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106340=edit
Bug 25812: Display overdue fines for the item on SIP checkin.

Test plan:

 - Using SIP, checkin an item that has one or several overdue fines.
 - Check that the following message is displayed (AF field):
   "You owe {correctly formatted price} for this item."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Matthias Meusburger  changed:

   What|Removed |Added

 Attachment #106056|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Alex Arnaud  ---
Owen,

As the old syspref name is longer than the others you moved into opac_news, the
atomicupdate fail if the language code is more than 3 characters:

DBD::mysql::db do failed: Data too long for column 'lang' at row 1 [for
Statement "INSERT INTO opac_news (branchcode, lang, title, content ) VALUES
(NULL, ?, '', ?)"] at (eval 1424) line 23.

OpacLoginInstructions_en //Ok
OpacLoginInstructions_es_ES // Not ok
OpacLoginInstructions_de_DE // Not ok

Changing opac_news.lang column to a varchar(30) would be ok.

Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |Failed QA

--- Comment #5 from Julian Maurice  ---
Unit tests pass even without the 2nd patch, can you take a look Nick please ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

--- Comment #1 from Nick Clemens  ---
Created attachment 106338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106338=edit
Bug 25882: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

--- Comment #2 from Nick Clemens  ---
Created attachment 106339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106339=edit
Bug 25882: Remove phr indicator from limits when processing

We assume all limits from advanced search to be a phrase and quote them
when doing this we should remove the phrase marker to avoid doulbe quoting

To test:
 1 - Have koha using ES
 2 - Go to advanced search
 3 - Limit by a single itemtype that exists
 4 - Get some results
 5 - Limit by a different itemtype that exists
 6 - Get some results
 7 - Limit by both itemtypes
 8 - Get only the results for the second itemtype
 9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")
13 - Apply patches
14 - Restart all the things
15 - Repeat search for both itemtypes
16 - Note results now include both types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||alex.arn...@biblibre.com,
   ||and...@bywatersolutions.com
   ||, frede...@tamil.fr,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25882] New: Elasticsearch - Advanced search itemtype limits are being double quoted

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25882

Bug ID: 25882
   Summary: Elasticsearch - Advanced search itemtype limits are
being double quoted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

To test:
 1 - Have koha using ES
 2 - Go to advanced search
 3 - Limit by a single itemtype that exists
 4 - Get some results
 5 - Limit by a different itemtype that exists
 6 - Get some results
 7 - Limit by both itemtypes
 8 - Get only the results for the second itemtype
 9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #104 from Alex Arnaud  ---
Also, a rebase is needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

--- Comment #103 from Alex Arnaud  ---
Comment on attachment 99421
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99421
Bug 21946: Update Administration->Item types to allow for defining parent types

Review of attachment 99421:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21946=99421)
-

::: Koha/ItemType.pm
@@ +151,5 @@
> +return unless $parent_rs;
> +return Koha::ItemType->_new_from_dbic( $parent_rs );
> +
> +}
> +

I can't see any unit test for the parent method. Right ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

--- Comment #102 from Alex Arnaud  ---
Comment on attachment 99419
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99419
Bug 21946: Database updates

Review of attachment 99419:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21946=99419)
-

::: installer/data/mysql/kohastructure.sql
@@ +892,4 @@
>hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the 
> search options in OPAC
>searchcategory varchar(80) default NULL, -- Group this item type with 
> others with the same value on OPAC search options
>PRIMARY KEY  (`itemtype`),
> +  FOREIGN KEY (parent_type) REFERENCES itemtypes(itemtype) ON UPDATE CASCADE 
> ON DELETE CASCADE,

Can you use CONSTRAINT as in the atomic update. So that we can have the
constraint name that is defined in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||25850


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850
[Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due
date lands on a sunday.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||15260
 CC||martin.renvoize@ptfs-europe
   ||.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260
[Bug 15260] Option for extended loan with useDaysMode
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148

--- Comment #2 from Owen Leonard  ---
Created attachment 106337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106337=edit
Bug 23148: Replace Bridge icons with transparent PNG files

This patch adds SVG versions of the Bridge item type icon set to
misc/interface_customization/itemtypeimg/bridge. It adds some
new icons, and updates some existing icons. All GIF versions of the
icons are replaced with transparent PNG files.

Icon changes:

- English text has been removed from all icons
- New icon for "Periodical," to differentiate from "Journal"
- New icon, "Controller" for video games
- New icon for "Laserdisk" to differentiate from "DVD"
- New icon for "Kit" to differentiate from "Archive"
- New icon, "Reference books."
- Updated "badges" on "Juvenile book" and "Reserve book" to try to
  express the information without English-specific letters.

Before applying the patch, update some item types or collection codes
with Bridge icons. Apply the patch and run the database update process.

 - Open the advanced search page in the staff client and confirm that
   your item type or collection code icons were updated correctly.
 - Go to Administration -> Item types and edit an item type.
   - Check the "bridge" tab and confirm that the icon options look
 correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >