[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #24 from Victor Grousset/tuxayo --- Conflict fixed. Double checked the diff of the file afterwards, no issues found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #106050|0 |1 is obsolete|| --- Comment #23 from Victor Grousset/tuxayo --- Created attachment 106359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106359=edit Bug 22672: Change to and to in templates, includes, xslt This patch attempts to replace with AND with in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use . I found templates, includes and XSLT by using 'git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of or that I could have missed. Signed-off-by: Timothy Alexis Vass Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #6 from Victor Grousset/tuxayo --- It works! Test was done by opening the 10 test pages and comparing the source code before and after the patch with a diff tool. The only actually changes are the 4 pages without the hint. And acqui/acqui-home.tt as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105910|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 106358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106358=edit Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template plugin The template plugin Branches contains a method GetLoggedInBranchcode that returns current branch code. This patch adds GetLoggedInBranchname to get current branch name. It is used to replace vars LoginBranchname and LoginBranchcode sent to all templates in C4/Auth.pm. In labels and patrons cards modules, I choose to remove a unseless display of current branch in a hint. In acqui/acqui-home.tt, I choose to remove a useless display of current branch and also because table of founds contains a filter on library. Test plan: Check pages source code to see branch code or name is correct. list of the pages: /cgi-bin/koha/acqui/acqui-home.pl /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/circ/branchoverdues.pl /cgi-bin/koha/circ/set-library.pl /cgi-bin/koha/circ/offline.pl /cgi-bin/koha/labels/label-edit-batch.pl?op=new /cgi-bin/koha/labels/label-manage.pl /cgi-bin/koha/patroncards/edit-batch.pl /cgi-bin/koha/patroncards/manage.pl OPAC: /cgi-bin/koha/opac-detail.pl?biblionumber=XXX Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105909|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 106357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106357=edit Bug 25765: Add GetLoggedInBranchname method Add GetLoggedInBranchname method to Branches templates plugin. Also changes GetName method to use Koha::Library instead of direct SQL. Test plan : Run prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25811] authentication.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 --- Comment #5 from Victor Grousset/tuxayo --- The previous error might have been due to Selenium being in an invalid state. I got it often until I restarted koha-testing-docker. So. Tested with commit 7b54b529078756556252530bb72903caa88e94e7 to have closer conditions. (master was there when I previously got the error) Still can't get it again after 3438 runs! We will see it some day that happens again. For the record I got this error: t/db_dependent/selenium/authentication.t .. # Failed test 'Patron without permission should be redirected to the login form' # at t/db_dependent/selenium/authentication.t line 57. # '502 Bad Gateway' # doesn't match '(?^u:Access denied)' # Looks like you failed 1 test of 5. t/db_dependent/selenium/authentication.t .. 1/2 # Failed test 'Staff interface authentication' # at t/db_dependent/selenium/authentication.t line 72. It's just to find it in case it happens again. Not worthy of a bug now IMHO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #7 from Victor Grousset/tuxayo --- Seem to have happened the 2020-06-23 https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_D9/243/consoleText https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/246/consoleText https://jenkins.koha-community.org/job/Koha_19.05_D8/250/consoleText https://jenkins.koha-community.org/job/Koha_19.05_D9/244/consoleText Didn't find yet the time to write a failing test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798 Andrew Nugged changed: What|Removed |Added CC||slavashish...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13550] Automatic processing status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13550 --- Comment #3 from Katrin Fischer --- Yes, but not totally sure yet how it would be realized best. Maybe changing an enhancing the 'modifications by age' would be a way to go. There is already a bug that it should look for other critiera. Looking at a certain defined list of items, could be another thing. Maybe we need a way to define lists of items like we can define lists for patrons and bibs first? That could also be used with batch tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13165] Active Hold Limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 --- Comment #4 from Katrin Fischer --- I think you are right that this turns into limiting checkouts in some way. So a hold can only trigger when there is 'room' on the patron account? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13165] Active Hold Limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 --- Comment #3 from Katrin Fischer --- Yes it does. Indeed Netflix loaning DVDs were never a thing here in Germany, afaik. So I didn't know how this works/worked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14210] Manage staged marc records deletes replaced item when undoing import into catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #4 from AspenCat Team --- Although a big warn would certainly be helpful, it would be better to get it fixed (so undo could happen). We are on elastic search. Warn should include advising to keep a marc file of the previous state of affairs to load to recreate the items that disappeared. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #7 from AspenCat Team --- This is a major problem for us when we are doing batch changes (or imports). If we need to request a reindex then we also have to consider the timing of the reindex. We are on elastic search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
