[Koha-bugs] [Bug 25163] Add the ability to bulk attach items to a bib record

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25163

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22785] Manage Multiple Matches when importing through Stage Marc Record Import

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #232 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #231)
> Tomas, I cherry-picked 2 of your patches and added a commit to fix the
> atomic update process bug you reported me (pm)

I tested your follow-up, and it works great! I amended my last patch to catch a
typo. You can consider this as SO by me, picking my branch. It includes a
commit from Martin, but better ask him about his SO status!

Good job team!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks|25883   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883
[Bug 25883] Show transfer on checkin screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||25883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883
[Bug 25883] Show transfer on checkin screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25883] Show transfer on checkin screen

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on|23192   |23129


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129
[Bug 23129] Items holdingbranch should be set to the originating library when
generating a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192
[Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||25883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883
[Bug 25883] Show transfer on checkin screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25883] Show transfer on checkin screen

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||23192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192
[Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106472|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 106478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106478&action=edit
Bug 25914: Fix incorrect variable name causing relative's checkouts column to
be empty in OPAC

In the OPAC, the title column in the relatives checkouts table is always empty.

Test Plan:
1) Enable viewing of relative's checkouts in OPAC
2) Check some items out to a patron
3) Log into the OPAC as a relative of that patron that should be able to
   view them
4) Note the title column is empty in the relative's checkouts tab
5) Apply this patch
6) Reload the page
7) Titles should appear in the title column!

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25369] IntranetCoce not displaying Cover Images on Staff Client

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369

Kelly McElligott  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Kelly McElligott  ---
Closing this- the covers do display.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25733] Return claims attention can't be cleared

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733

Andrew Fuerste-Henry  changed:

   What|Removed |Added

Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #47 from Victor Grousset/tuxayo  ---
From what I understand, it's a schema from a version of the OpenAPI
Specification. Something like the draft 4 of the version 2.

Here we can compare a version from 2014 and from now.
https://web.archive.org/web/20141019005411/https://swagger.io/v2/schema.json
vs
https://web.archive.org/web/20200702172005/https://schema.swagger.io/v2/schema.json


Here is the actual source it seems:
https://github.com/OAI/OpenAPI-Specification/blob/c196cac8191069fa97028c2f1ae322d11a74f891/schemas/v2.0/schema.json
vs
https://github.com/OAI/OpenAPI-Specification/blob/master/schemas/v2.0/schema.json


I would *guess* it will stay backward compatible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7638] Add tool for printing patron notices

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638

Tomáš Wünsch  changed:

   What|Removed |Added

 CC||frak...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17120] Specify number of rows per page in report and initial run

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120

Tomáš Wünsch  changed:

   What|Removed |Added

 CC||frak...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Attachment #106356|0   |1
is obsolete||

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 106477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106477&action=edit
Bug 25717: Improve automatic renewal error messages

Improve wording and grammar for automatic renewal error messages.

Test plan:
1. Review the error message changes and make sure they make sense.

The new message make sense to me.

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25861] [19.11] Cannot copy MARC frameworks

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Sending to RMaint 19.11 queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913

--- Comment #1 from Heather  ---
Created attachment 106476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106476&action=edit
A bib record with no 245 and 880 fields from our catalog

I'm uploading one of our MARC21 records, exported from OCLC that has no 245 and
has the 880 fields in it that might be useful for folks to use in testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> I need it ASAP, maybe it will fix 00-testcritic (?)

Not related, forget that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||RM_priority

--- Comment #4 from Jonathan Druart  
---
I need it ASAP, maybe it will fix 00-testcritic (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #231 from Jonathan Druart  
---
Tomas, I cherry-picked 2 of your patches and added a commit to fix the atomic
update process bug you reported me (pm)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25912] Any lost value triggers refund message on check in, even if it doesn't apply

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25912

--- Comment #5 from Christopher Brannon  ---
Wish I could edit my comments in bugzilla sometimes.  :/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25912] Any lost value triggers refund message on check in, even if it doesn't apply

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25912

--- Comment #4 from Christopher Brannon  ---
I down with the second idea.  Just have a list in place of the control.  If
there is nothing there, nothing happens.  We only list what we want action on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

--- Comment #5 from Owen Leonard  ---
(In reply to Owen Leonard from comment #3)
> I'm not sure how to proceed with this one

I think the above patch is the correct solution for now because it not only
restores translatability, it also fixes the default table configuration so that
it doesn't show unstyled (and previously hidden) table controls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #3 from Nick Clemens  ---
(In reply to Andrew Fuerste-Henry from comment #2)
> I'm getting an error in the Elastic rebuild:
> root@287fd5fefa08:koha(master)$ perl
> misc/search_tools/rebuild_elasticsearch.pl -d -b
> Can't call method "items" on an undefined value at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 710.

MARC21 doesn't store the biblionumber in the 001

Should probably call GetMarcFromKohaField( 'biblio.biblionumber' ) to determine
which field to use here

I don't know if calling that for all the item fields may be more performant
that fetching the biblio and iterating items as opposed to checking the MARC as
well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106458|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 106475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106475&action=edit
Bug 25909: Recent change to datatables JS in the OPAC causes errors

This patch reverts some changes made by Bug 25287 which prematurely
introduced the double-underscore i18n function. The i18n features
haven't been fully implemented in the OPAC.

Some lines are reverts to the previous version, and some are additions,
for instance where Bug 25287 introduced new DataTables features and a
new string translation is required.

In addition to i18n changes, the patch also reverts the default
configuration of DataTables in the OPAC so that the "dom" configuration
option is set back to "t." This turns off features like pagination
buttons, filters, etc. which were previously disabled by default.

Enabling these features requires revision to the OPAC CSS in order for
them to display well.

To test, apply the patch and view a page in the OPAC which includes a
DataTable. For instance: checkouts on the "your summary" page, serial
issues on the "full subscription history" page.

Tables should display correctly and sorting should work correctly. There
should be no other DataTables controls visible.

To test translatability:

To test, apply the patch and test that the correct strings are
translatable. In this example I'm testing fr-FR:

- Update a translation:

  > cd misc/translator
  > perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from
  the templates  e.g.  misc/translator/po/fr-FR-opac-bootstrap.po
- Locate strings pulled from bootstrap/en/includes/datatables.inc
  for translation, e.g.:

  #. SCRIPT
  #: opac-tmpl/bootstrap/en/includes/datatables.inc:4
  msgid "Copy to clipboard"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing)
- Install the updated translation:

  > perl translate install fr-FR

Open the translated copy of datatables.inc and confirm that the
translated string appears.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25915] hold queue colunms headers are wrong if users can't change holds priority

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25915

didier  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |didier.gautheron@biblibre.c
   |ity.org |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25915] hold queue colunms headers are wrong if users can't change holds priority

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25915

--- Comment #1 from didier  ---
Created attachment 106474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106474&action=edit
wrong headers

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #230 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #229)
> I don't think items is an exception, and so I don't think biblio should have
> another naming.
> 
> For instance (as noted in comment 198):
> """As we are going to face this situation for some other tables as well (at
> least columns borrowers.cardnumber, borrowers.userid, issues.itemnumber)"""

You're 100% right. I'll tweak my working branch so this moves forward, in a
consistent way! Thanks for the clarification Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25915] New: hold queue colunms headers are wrong if users can't change holds priority

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25915

Bug ID: 25915
   Summary: hold queue colunms headers are wrong if users can't
change holds priority
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: didier.gauthe...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 106473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106473&action=edit
right headers

If a patron 'Modify holds priority (modify_holds_priority) ' permission is
unset wrong column headers are used in hold screen

cgi-bin/koha/reserve/request.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
   Assignee|tomasco...@gmail.com|oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #229 from Jonathan Druart  
---
I don't think items is an exception, and so I don't think biblio should have
another naming.

For instance (as noted in comment 198):
"""As we are going to face this situation for some other tables as well (at
least columns borrowers.cardnumber, borrowers.userid, issues.itemnumber)"""

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24668] Allow users to specify in plugins how often to run the plugin's cron

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24668
Bug 24668 depends on bug 20897, which changed state.

Bug 20897 Summary: Add generic cronjob to run plugins with a 'cronjob' method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897

   What|Removed |Added

 Status|Signed Off  |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245

--- Comment #48 from Martin Renvoize  ---
*** Bug 20897 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a 'cronjob' method

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |DUPLICATE

--- Comment #7 from Martin Renvoize  ---
Ooh.. not sure how I didn't find this one when I was creating bug 25245.. as
that one has already reached PQA I'm going to mark this one as a duplicate..
though this one works hourly whereas the alternative works 'nightly'.. hmm

*** This bug has been marked as a duplicate of bug 25245 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

--- Comment #1 from Kyle M Hall  ---
Created attachment 106472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106472&action=edit
Bug 25914: Fix incorrect variable name causing relative's checkouts column to
be empty in OPAC

In the OPAC, the title column in the relatives checkouts table is always empty.

Test Plan:
1) Enable viewing of relative's checkouts in OPAC
2) Check some items out to a patron
3) Log into the OPAC as a relative of that patron that should be able to
   view them
4) Note the title column is empty in the relative's checkouts tab
5) Apply this patch
6) Reload the page
7) Titles should appear in the title column!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25914] New: Relative's checkouts have empty title in OPAC

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914

Bug ID: 25914
   Summary: Relative's checkouts have empty title in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In the OPAC, the title column in the relatives checkouts table is always empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11723] Message "A refund has been applied" on all lost item returns

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry  ---
+1 on this, it's a source of confusion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25912] Any lost value triggers refund message on check in, even if it doesn't apply

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25912

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry  ---
It seems like we've got two separate things here. First, there's a bug with the
existing functionality, that it's not being accurate about whether or not a fee
will be refunded. Looks like that's covered in bug 11723.

Second, there's an enhancement to introduce functionality for some lost values
to not generate refunds. Let's maybe made this bug focus on that?

Maybe we add a corollary syspref to RefundLostOnReturnControl that takes a list
of exceptions? Or just change RefundLostOnReturnControl so instead of a yes/no
switch one enters a list of lost status for which one wants to refund? And
leave blank if no refund is desired?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
I'm not sure how to proceed with this one... The patch changes __() to _(),
which will eliminate the JS error but won't make the strings translatable
because the _() function doesn't work in standalone JavaScript files.

Bug 25351 implements the JavaScript i18n feature while updated the Cart
JavaScript to use it. If that were approved it would make this bug obsolete.

Otherwise the correct patch for this is to fully revert the changes to lines
where the MST_DT_* variables were used.

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f5dc3dc0dd9fa02d6d11e92a6e466e545b8eccc#patch2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25913] New: Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913

Bug ID: 25913
   Summary: Internal server error when calling get_coins on record
with no title (245) but with 880 linked to 245
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In opac search results we call get_coins in an eval so it can load, on other
scripts we don't

The get_coins routine calls:
$title = $record->field('245')->as_string('ab');

With no check that the 245 exists.

Simple fix would be to call get_coins in an eval everywhere
More comprehensive would be to fall back to 880 field linked ot 245, and then
fallback to blank

This only affects MARC21 I believe as the UNIMARC implementation gets the field
directly without as_string

To recreate:
1 - Load attached record or create a record with 880 and no 245
2 - Enable COinSinOpac
3 - Search for record in staff or opac, it loads in results
4 - Add item to a public list, cannot view in opac
5 - Try to view ISBD or MARC tab on staff client, it fails

When indexing in ES we convert an 880 to its linked field so the record is
searchable, so we could make that a sbroutine

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723

--- Comment #41 from Martin Renvoize  ---
We have this work deployed at a couple of sites now and hope to provide a
signoff soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723

Martin Renvoize  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21468] ILL backends/plugins need hooks into checkin and checkout

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855
[Bug 25855] Add post_renewal_hook in circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21468


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468
[Bug 21468] ILL backends/plugins need hooks into checkin and checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

--- Comment #8 from Martin Renvoize  ---
Comment on attachment 106249
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106249
Bug 25855: Add a post_renewal_action plugin hook

Review of attachment 106249:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25855&attachment=106249)
-

::: C4/Circulation.pm
@@ +4292,4 @@
>  return 0;
>  }
>  
> +=head3 _post_renewal_actions

Hmm.. could we perhaps be a bit more forward-thinking here and adopt a more
generic approach akin to that taken in C4/Biblio.pm where we have
'_after_biblio_actions_hooks' which accepts and action param.. perhaps we could
have `_after_circ_action_hooks` here and then in followup bugs we can extend it
easily to support the other actions available within the module?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

--- Comment #7 from Martin Renvoize  ---
Comment on attachment 106248
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106248
Bug 25855: Unit tests

Review of attachment 106248:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25855&attachment=106248)
-

::: t/db_dependent/Koha/Plugins/Circulation_hooks.t
@@ +68,5 @@
> +'AddBiblio calls the hook with action=create';
> +
> +warning_like { $item = $builder->build_sample_item({ biblionumber => 
> $biblio->biblionumber }); }
> +qr/after_item_action called with action: create, ref: 
> Koha::Item/,
> +'AddItem calls the hook with action=create';

Hmm.. does it make sense to additionally test the AddBiblio and AddItem hooks
here.. they're already well tested within
Koha/Plugins/Biblio_and_Items_plugin_hooks.t aren't they?

@@ +72,5 @@
> +'AddItem calls the hook with action=create';
> +
> +warning_like { AddIssue( $patron->unblessed, $item->barcode ); }
> +qr/after_item_action called with action: modify, ref: 
> Koha::Item/,
> +'AddItem calls the hook with action=modify';

'AddIssue' is being tested here.. not AddItem... must admit it feels a little
strange that we trigger the item modification hook on an issue.. though I think
I understand how that comes about.

@@ +77,5 @@
> +
> +warnings_like { AddRenewal( $patron->borrowernumber, $item->id, 
> $patron->branchcode ); }
> +[ qr/after_item_action called with action: modify, ref: 
> Koha::Item/,
> +  qr/post_renewal_action .* DateTime/ ],
> +'AddRenewal calls the post_renewal_action hook';

I have a vague feeling renewals can be triggered via AddIssue as well as
AddRenewal might be worth also testing that case to make sure you're always
triggering as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25906] In opac-serial-issues.pl, when looking at full history, the search facet form should look good.

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906

--- Comment #5 from Timothy Alexis Vass  ---
Looking at your screenshot Owen, it looks nice.

1. I still suggest to remove style="width:10em;" from the two select elements,
so that they adapt to the span2 width and so that the elements stay inside the
container.

2. I would also like to change the span2 to a span3 so that the space inside
makes sense at widths 768px to 1200px.

The .span2 select { width: 100%; } would need to apply for .span3 select too.

3. I also suggest that the Clear-button is centered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #46 from Marcel de Rooy  ---
How often this schema changes ? Need to check for updates ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106455|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 106471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106471&action=edit
Bug 25896: Add missing closing  tag

File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had
one lost closing  tag in "daysmode" block. Added.

Mentored-by: Andrew Nugged 

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

--- Comment #38 from Marcel de Rooy  ---
Minor observation, no blocker:
RemoveOldSessions (when you run with sessdays)
Not executed in dry mode.
So no numbers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

--- Comment #37 from Marcel de Rooy  ---
Created attachment 106470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106470&action=edit
Bug 24153: (QA follow-up) Removing one redundant initialization line

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106336|0   |1
is obsolete||

--- Comment #36 from Marcel de Rooy  ---
Created attachment 106469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106469&action=edit
Bug 24153: Add the confirm flag to the crontab calls

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106335|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 106468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106468&action=edit
Bug 24153: Make sure $count will not be reused for another purpose

The $count variable should be defined per block and set to 0 to avoid
confusion.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106332|0   |1
is obsolete||

--- Comment #32 from Marcel de Rooy  ---
Created attachment 106465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106465&action=edit
Bug 24153: Add a confirm flag to cleanup_database

How handy this will be, right?

This patch will change the behavior of this script as the --confirm flag
will now be required for effective changes.
Without --confirm and with --verbose you will see what could have done
the script in non dry-run mode.

Test plan:
Use different options of the script without the --confirm flag and have
a look at the output. It now tells you what would have been deleted if
the flag was passed.
Now use the --confirm flag and confirm that the changes are now
effective.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Signed-off-by: Sonia Bouis 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106333|0   |1
is obsolete||

--- Comment #33 from Marcel de Rooy  ---
Created attachment 106466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106466&action=edit
Bug 24153: Remove warning for message queue

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #106334|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 106467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106467&action=edit
Bug 24153: Improve verbose messages in dry-run mode

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

Marcel de Rooy  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #45 from Andrew Nugged  ---
(In reply to Fridolin SOMERS from comment #41)
> For Ubuntu Debian, we at biblibre installed from CPAN JSON::Validator 4.01
> and added the cache file.
> It works without patch on sources.

Confirming the same: just using cpanm with only one this updated all
quickfixed, temporarily for libs, but now I am learning how to make this
solution stable, reading all above & tracking :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

--- Comment #26 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #25)
> (In reply to Jonathan Druart from comment #23)
> > Well no, it was not the follow-up :)
> 
> -( $pPseudoTransactions ? ( days => $pPseudoTransactions
> ) : () ),
> -( $pPseudoTransactionsFrom ? ( from => $pPseudoTransactionsFrom
> ) : () ),
> -( $pPseudoTransactionsTo   ? ( to   => $pPseudoTransactionsTo  
> ) : () ),
> +( defined $pPseudoTransactions  ? ( days =>
> $pPseudoTransactions ) : () ),
> +( $pPseudoTransactionsFrom  ? ( from =>
> $pPseudoTransactionsFrom ) : () ),
> +( $pPseudoTransactionsTo? ( to   =>
> $pPseudoTransactionsTo   ) : () ),
> 
> 
> Well I did not test, but the change with defined explains it for me.

Hmm. I tried it now but filter_last_update works with < and truncates to days.
So what actually happens, is that I am purging records before today. Which is a
bit counterintuitive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25792] Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25792

--- Comment #9 from Julian Maurice  ---
(In reply to Mason James from comment #8) > (In reply to Julian Maurice from
comment #7)
> > (In reply to Tomás Cohen Arazi from comment #6)
> > > The fonts-dejavu package is available back to Jessie and the plan is to 
> > > drop
> > > the transitional ttf-dejavu package in bullseye:
> > > 
> > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872809
> > > 
> > > So this is ok.
> > 
> > Can we remove reference to ttf-dejavu ? In ubuntu fonts-dejavu is available
> > since trusty.
> 
> hmm, yes, i think so...
> 
> but, there is a problem for current koha installs, that the font path in
> koha-conf.xml will be incorrect
> 
> 
>  
>  >/usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif.ttf
> ...
>  
> 
> 
> when the unrequired ttf-dejavu package's symlinks are removed (eg: apt
> autoremove) the paths will need to be manually corrected
> keeping the ttf-dejavu reference in debian/control would postpone this
> problem until the system is upgraded to deb11/bullseye (which is probably a
> good thing?)
> 
> 
> any thoughts?

Ok, it is probably better this way then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #31 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #30)
> Looks like I followed-up on top of a local branch which did not have the
> last patches from bug 24152. Sorry about that, the patches apply cleanly now.

Yes, they apply. Having another look..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #10 from Marcel de Rooy  ---
Created attachment 106464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106464&action=edit
Bug 24544: Add new cronjob to cron files

Added the additional parameter -hours 2 to prevent a first time
run at night to do a full update (perhaps unexpected).
I would recommend to run a full update after configuring the
preferences.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/