[Koha-bugs] [Bug 25927] New: Software is not working perfectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25927 Bug ID: 25927 Summary: Software is not working perfectly Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: Windows Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: mokhethimoses...@gmail.com Reporter: mokhethimoses...@gmail.com QA Contact: mokhethimoses...@gmail.com Software runs with one error and zero failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25926] Application is not working as accepected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25926 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25926] New: Application is not working as accepected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25926 Bug ID: 25926 Summary: Application is not working as accepected Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: mokhethimoses...@gmail.com The application runs with one(1) error and zero(0) failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #12 from Jonathan Druart --- Sorry Julian I cannot retest right now. $HOME for kohadev-koha is /var/lib/koha/kohadev, that's why we are landing there without this patch. I tried with sudo to test the behaviour of the 'kshell' alias. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25925] New: In the alert box for unfilled important field in cataloging, the cancel button is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25925 Bug ID: 25925 Summary: In the alert box for unfilled important field in cataloging, the cancel button is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Created attachment 106522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106522=edit Alert box in French (CA) where the Cancel button is not translated I noticed when you try to save a record where an important field is not filled, the Cancel (and probably the OK) button is not translatable. I tried to find the string in my staff-prog.po file and couldn't find it. To get the alert: 1- Modify a framework and mark one of the fields as important 2- Open a new record in cataloging and fill out the mandatory fields but not the important field 3- Try to save the record There is a "Cancel" string and a "Cancel " string in staff-prog.po, but they only apply on the following lines, which is not the important alert as far as I can tell. #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:632 #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:636 #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:640 #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:644 #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:648 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Arthur Suzuki --- Hi Tuxayo, Hope you are doing well, you seem to be doing fine! I've made a small qa patch to solve the warn :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #13 from Arthur Suzuki --- Created attachment 106521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106521=edit Bug 25408: QA followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Matthias Meusburger changed: What|Removed |Added Status|Signed Off |In Discussion CC||matthias.meusburger@biblibr ||e.com --- Comment #3 from Matthias Meusburger --- The patch works as intended. However, using a wildcard on object (which is an identifier) does not seem to be a good idea, since you will retrieve many unwanted results. Moreover, the wildcard in C4::Logs::GetLogs was only on info, and not on object: if ($object) { $query .= " AND object = ? "; push( @parameters, $object ); } Hence, it doesn't restore the old behavior, but changes it. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25924] Broken link on Coce image in staff interface bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25924 --- Comment #1 from Owen Leonard --- Created attachment 106520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106520=edit Bug 25924: Remove broken link from detail page Coce image This patch removes the broken link around the Coce image on the bibliographic detail page in the staff interface. Even a working link to the detail page from the detail page isn't useful. To test you must have Coce configured and enabled in the staff client. Apply the patch and view the bibliographic detail page in the staff interface for a record which has a Coce cover image. The Coce image should not be linked to anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25924] Broken link on Coce image in staff interface bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25924 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Blocks||25924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25924 [Bug 25924] Broken link on Coce image in staff interface bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25924] New: Broken link on Coce image in staff interface bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25924 Bug ID: 25924 Summary: Broken link on Coce image in staff interface bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 18421 When viewing the bibliographic detail page in the staff interface with Coce images enabled, the Coce cover image is wrapped in a link: The "DetailPage" variable hasn't been defined so the link is broken. Rather than fix the variable I suggest we remove the link, since linking to the detail page from the detail page doesn't make any sense. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 [Bug 18421] Make Coce cover images available for staff search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #11 from Julian Maurice --- (In reply to Julian Maurice from comment #9) > Try: > # cd /tmp > # koha-shell -c pwd > # koha-shell > # pwd Forgot the instance name. I meant: root@localhost# cd /tmp root@localhost# koha-shell -c pwd kohadev root@localhost# koha-shell kohadev koahdev-koha@localhost$ pwd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24625] Phase out jquery.cookie.js: showLastPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24625] Phase out jquery.cookie.js: showLastPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 Julian Maurice changed: What|Removed |Added Attachment #106514|0 |1 is obsolete|| --- Comment #12 from Julian Maurice --- Created attachment 106519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106519=edit Bug 24625: Store showLastPatron information using localStorage This patch removes the use of jquery.cookie to store "last patron" information, using localStorage instead. jquery.cookie.js is obsolete. See Bug 24624. localStorage has been chosen as an alternative in this situation because it does not require transmission between the client and the server. See Bug 12410. Because there is no "session only" option with localStorage, additional handling of the showLastPatron data is added to the login page. That takes care of "stale" last patron information if user didn't log out but the session expired for some reason. To test apply the patch and enable the showLastPatron system preference. 1. Load a patron's account for checkout 2. Navigate away from patron-related pages: Perform a catalog search from the search header form and open the detail page from the search results. Confirm that the correct last patron information still shows. 3. Load another patron's account for checkout - There should now be a "Last patron" link in the breadcrumbs bar which links to the patron in step 1. Hovering your mouse over the link should display a tooltip containing the patron's name and card number. - Click the "X" to clear the last patron information. The last patron link should go away. 4. Log out and log back in. The last patron information should be gone. Signed-off-by: David Nind Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25443] Improve translation of "Select the host record to link%s to"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Julian Maurice changed: What|Removed |Added Attachment #105315|0 |1 is obsolete|| --- Comment #9 from Julian Maurice --- Created attachment 106517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106517=edit Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25443] Improve translation of "Select the host record to link%s to"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25443] Improve translation of "Select the host record to link%s to"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25443 --- Comment #10 from Julian Maurice --- Created attachment 106518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106518=edit Bug 25443: (follow-up) surround strings with Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 --- Comment #6 from Fridolin SOMERS --- (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Fridolin SOMERS from comment #4) > > Looks like its related to Bug 19261 > > > > > I will add a 'deny_list' > > where ? in DB ? > > On ViewPolicy.pm Oki super. Add field+subfield of biblio.biblionumber. Add field+subfield 999x used by Koha::Filter::MARC::EmbedItemsAvailability. Maybe add field+subfield of items.itemnumber ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #10 from Julian Maurice --- Also, why are you using sudo when you are already root ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #9 from Julian Maurice --- (In reply to Jonathan Druart from comment #7) > Looks ok for me > > With sudo: > root@f62733f90b41:koha(BZ25752)$ sudo koha-shell kohadev > kohadev-koha@f62733f90b41:/kohadevbox/koha$ pwd > /kohadevbox/koha > kohadev-koha@f62733f90b41:/kohadevbox/koha$ exit > root@f62733f90b41:koha(BZ25752)$ sudo koha-shell kohadev -c pwd > /kohadevbox/koha > > Without sudo: > root@f62733f90b41:koha(BZ25752)$ koha-shell kohadev > kohadev-koha@f62733f90b41:/kohadevbox/koha$ pwd > /kohadevbox/koha > root@f62733f90b41:koha(BZ25752)$ koha-shell kohadev -c pwd > /kohadevbox/koha Well, of course if you are running koha-shell from the home directory of kohadev-koha, the result will be the same. Try: # cd /tmp # koha-shell -c pwd # koha-shell # pwd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914 Alex Arnaud changed: What|Removed |Added Attachment #106478|0 |1 is obsolete|| --- Comment #3 from Alex Arnaud --- Created attachment 106516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106516=edit Bug 25914: Fix incorrect variable name causing relative's checkouts column to be empty in OPAC In the OPAC, the title column in the relatives checkouts table is always empty. Test Plan: 1) Enable viewing of relative's checkouts in OPAC 2) Check some items out to a patron 3) Log into the OPAC as a relative of that patron that should be able to view them 4) Note the title column is empty in the relative's checkouts tab 5) Apply this patch 6) Reload the page 7) Titles should appear in the title column! Signed-off-by: Owen Leonard Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25914] Relative's checkouts have empty title in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106386|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 106515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106515=edit Bug 25752: Stay in cwd after koha-shell After bug 25538, after a koha-shell we are not longer in the current directory: root@cec7bffd8100:koha(master)$ pwd /kohadevbox/koha root@cec7bffd8100:koha(master)$ sudo koha-shell kohadev kohadev-koha@cec7bffd8100:~$ pwd /var/lib/koha/kohadev Test plan: Repeat the commands above and confirm that with this version of the script you get /kohadevbox/koha inside the koha-shell Search for possible regressions Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24625] Phase out jquery.cookie.js: showLastPatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24625 Owen Leonard changed: What|Removed |Added Attachment #106164|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 106514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106514=edit Bug 24625: Store showLastPatron information using localStorage This patch removes the use of jquery.cookie to store "last patron" information, using localStorage instead. jquery.cookie.js is obsolete. See Bug 24624. localStorage has been chosen as an alternative in this situation because it does not require transmission between the client and the server. See Bug 12410. Because there is no "session only" option with localStorage, additional handling of the showLastPatron data is added to the login page. That takes care of "stale" last patron information if user didn't log out but the session expired for some reason. To test apply the patch and enable the showLastPatron system preference. 1. Load a patron's account for checkout 2. Navigate away from patron-related pages: Perform a catalog search from the search header form and open the detail page from the search results. Confirm that the correct last patron information still shows. 3. Load another patron's account for checkout - There should now be a "Last patron" link in the breadcrumbs bar which links to the patron in step 1. Hovering your mouse over the link should display a tooltip containing the patron's name and card number. - Click the "X" to clear the last patron information. The last patron link should go away. 4. Log out and log back in. The last patron information should be gone. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #7 from Jonathan Druart --- Looks ok for me With sudo: root@f62733f90b41:koha(BZ25752)$ sudo koha-shell kohadev kohadev-koha@f62733f90b41:/kohadevbox/koha$ pwd /kohadevbox/koha kohadev-koha@f62733f90b41:/kohadevbox/koha$ exit root@f62733f90b41:koha(BZ25752)$ sudo koha-shell kohadev -c pwd /kohadevbox/koha Without sudo: root@f62733f90b41:koha(BZ25752)$ koha-shell kohadev kohadev-koha@f62733f90b41:/kohadevbox/koha$ pwd /kohadevbox/koha root@f62733f90b41:koha(BZ25752)$ koha-shell kohadev -c pwd /kohadevbox/koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add after_circ_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 106513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106513=edit Bug 25855: (QA follow-up) Generalize hook and simplify tests This patch generalizes the hook so it can be used by other circulation actions. Tests are also simplified by mocking some of the (extensive) plugin hooks. To test: 1. Repeat the test plan on the original patch => SUCCESS: All good 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Attachment #106500|0 |1 is obsolete|| --- Comment #11 from Julian Maurice --- Created attachment 106512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106512=edit Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Julian Maurice changed: What|Removed |Added Attachment #106499|0 |1 is obsolete|| --- Comment #10 from Julian Maurice --- Created attachment 106511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106511=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] [19.11] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #8 from Alex Arnaud --- libraryNotPickupLocation red message disapears and we only have pickup location libraries in the list => Ok Just a specific case: If i set all my libraries as "no pickup location", i have no error message, an empty pickup location list and i can place a hold. I agree that it's a very specific case and not likely to happen. But can you technically accept a hold without pickup location ? What's your opinion on this ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Julian Maurice changed: What|Removed |Added Attachment #106501|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 106509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106509=edit Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 --- Comment #5 from Julian Maurice --- Created attachment 106510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106510=edit Bug 25922: Fix typo 'arial-label' -> 'aria-label' Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25923] New: pr-BR translations breaks Tools (Ferramentas) menu and submenus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25923 Bug ID: 25923 Summary: pr-BR translations breaks Tools (Ferramentas) menu and submenus Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: steven.schmie...@gmail.com Created attachment 106508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106508=edit Examples of erroneous lines in pt-BR code When updating translations to Koha version 20.05.01 using pt-BR (Brazilian Portuguese) coding errors are introduced into several files making the Tools (Ferramentas) and submenus inoperable. An "internal server error" message is displayed. The coding errors are found in at least two file that I can identify: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/pt-BR/modules/tools/tools-home.tt /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/pt-BR/includes/tools-menu.inc For example (there is more than one error in each file), in the file "tools-home.tt" at line 16, the original file has: [% IF (CAN_user_tools_manage_patron_lists || || CAN_user_clubs CAN_user_tools_moderate_comments || || CAN_user_tools_import_patrons CAN_user_tools_edit_notices || || CAN_user_tools_edit_notice_status_triggers CAN_user_tools_label_creator || || CAN_user_tools_delete_anonymize_patrons CAN_user_tools_edit_patrons || || CAN_user_tools_batch_extend_due_dates CAN_user_tools_moderate_tags || (CAN_user_tools_batch_upload_patron_images && Koha.Preference ('patronimages') ) ) %] Usuários e circulação The line should be: [% IF (CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_batch_extend_due_dates || CAN_user_tools_moderate_tags || (CAN_user_tools_batch_upload_patron_images && Koha.Preference ('patronimages') ) ) %] Usuários e circulação In the file "tools-menu.inc" at line 8, the original file has: [% IF (CAN_user_tools_manage_patron_lists || || CAN_user_clubs CAN_user_tools_moderate_comments || || CAN_user_tools_import_patrons CAN_user_tools_edit_notices || || CAN_user_tools_edit_notice_status_triggers CAN_user_tools_label_creator || || CAN_user_tools_delete_anonymize_patrons CAN_user_tools_edit_patrons || || (CAN_user_tools_moderate_tags CAN_user_tools_batch_upload_patron_images && Koha.Preference ('patronimages') ) ) % ] Usuários e circulação The line should be: [% IF (CAN_user_tools_manage_patron_lists || CAN_user_clubs || CAN_user_tools_moderate_comments || CAN_user_tools_import_patrons || CAN_user_tools_edit_notices || CAN_user_tools_edit_notice_status_triggers || CAN_user_tools_label_creator || CAN_user_tools_delete_anonymize_patrons || CAN_user_tools_edit_patrons || CAN_user_tools_moderate_tags || ( CAN_user_tools_batch_upload_patron_images && Koha.Preference('patronimages') ) ) %] Usuários e circulação There are other errors in both files. Theses are just two examples. Running "koha-translate --update pt-BR" reproduces the erroneous files. Manually editing both files solves the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 --- Comment #3 from Julian Maurice --- Ah I think I found the problem (a typo). I will submit a followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 --- Comment #2 from Julian Maurice --- I applied this patch and patches from bug 25244, then ran `./translate update fr-FR`. I cannot find 'Select search result:' in PO files. Does it work for you ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add after_circ_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Summary|Add post_renewal_hook in|Add after_circ_hook in |circulation |circulation --- Comment #9 from Tomás Cohen Arazi --- Taking Martin's suggestion to generalize this hook I'm renaming it 'after_circ_action' and made the params be 'action' ('renewal' in this case) and 'payload' for all we want to pass the plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] [19.11] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Alex Arnaud changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | CC||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 --- Comment #31 from Julian Maurice --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Julian Maurice changed: What|Removed |Added Attachment #103566|0 |1 is obsolete|| --- Comment #30 from Julian Maurice --- Created attachment 106507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106507=edit Bug 25067: Hide deprecation notice unless --verbose flag is given Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Julian Maurice changed: What|Removed |Added Attachment #103563|0 |1 is obsolete|| --- Comment #27 from Julian Maurice --- Created attachment 106504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106504=edit Bug 25067: Add missing globs in gulpfile for po:extract Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Julian Maurice changed: What|Removed |Added Attachment #103562|0 |1 is obsolete|| --- Comment #26 from Julian Maurice --- Created attachment 106503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106503=edit Bug 25067: Move PO file manipulation code into gulp tasks misc/translator/translate was doing three different things: - extract translatable strings - create or update PO files - install translated templates This patch separates responsibilities by moving the string extraction code into several 'xgettext-like' scripts and adds gulp tasks to automate string extraction and PO files update This has several benefits: - gulp runs tasks in parallel, so it's a lot faster (updating all PO files is at least 10 times faster with my 4-cores CPU) - there is no need for $KOHA_CONF to be defined LangInstaller.pm relied on $KOHA_CONF to get the different paths needed. I'm not sure why, since string extraction and PO update should work on source files, not installed files - string extraction code can be more easily tested This patch also brings a couple of fixes and improvements: - TT string extraction (strings wrapped in [% t(...) %]) was done with Template::Parser and PPI, which was extremely slow, and had some problems (see bug 24797). This is now done with Locale::XGettext::TT2 (new dependency) which is a lot faster, and fixes bug 24797 - string extraction for system preferences was putting context inside msgid. For instance: # Accounting > Policy msgid "accounting.pref#FinePaymentAutoPopup# automatically display " "a print dialog for a payment receipt when making a payment.." Now context is put into msgctxt, and the reference is set, which is cleaner #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref msgctxt "Accounting > Policy > FinePaymentAutoPopup" msgid "automatically display a print dialog for a payment receipt " "when making a payment.." The downside is that some messages will have to be re-translated, especially short messages like 'Do', for which msgmerge has a hard time finding the corresponding new msgid. - Replace deprecated gulp-util by recommended minimist - Fix header in 3 PO files Test plan: 1. Run `yarn install` and install Locale::XGettext::TT2 2. Run `gulp po:update` 3. Verify the contents of updated PO files 4. Run `cd misc/translator && ./translate install ` 5. Verify that all (templates, sysprefs, xslt, installer files) is correctly translated 6. Run `gulp po:create --lang ` and verify that it created all PO files for that language 7. Run `prove t/misc/translator` Signed-off-by: Bernardo Gonzalez Kriegel Need to install yarn & gulp, no errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Julian Maurice changed: What|Removed |Added Attachment #103565|0 |1 is obsolete|| --- Comment #29 from Julian Maurice --- Created attachment 106506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106506=edit Bug 25067: Add license notice to xgettext* scripts Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Julian Maurice changed: What|Removed |Added Attachment #103564|0 |1 is obsolete|| --- Comment #28 from Julian Maurice --- Created attachment 106505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106505=edit Bug 25067: Add translate create|update commands that call gulp Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24353] [19.05] privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24353] [19.05] privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud changed: What|Removed |Added Attachment #106422|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 106502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106502=edit Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #9 from Martin Renvoize --- Added bug 25922 to track the translation tools enhancement to allow the pickup of aria-labels for translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Martin Renvoize changed: What|Removed |Added Blocks||25244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Martin Renvoize changed: What|Removed |Added CC||bgkrie...@gmail.com, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Depends on||25922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 [Bug 25922] aria-labels are currently not translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 --- Comment #1 from Martin Renvoize --- Created attachment 106501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106501=edit Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25922] New: aria-labels are currently not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25922 Bug ID: 25922 Summary: aria-labels are currently not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The aria-label tag used for accessibility should be picked up for translation by the translation tools, currently, it is not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Blocks||25921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 [Bug 25921] Merge biblio* and items table - Update reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #8 from Martin Renvoize --- Created attachment 106500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106500=edit Bug 25244: (follow-up) QA corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25921] Merge biblio* and items table - Update reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25921] New: Merge biblio* and items table - Update reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 Bug ID: 25921 Summary: Merge biblio* and items table - Update reports Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 20271 We should update the existing reports to use, for instance, biblio_legacy instead of the biblio table. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Martin Renvoize changed: What|Removed |Added Attachment #106406|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 106499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106499=edit Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #236 from Jonathan Druart --- Thanks Martin, I've cherry-picked your 2 QA follow-ups and added your stamp on the whole stack! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 --- Comment #6 from Martin Renvoize --- (In reply to Julian Maurice from comment #5) > Shouldn't it be "Select bibliographic record" ? Hmm, perhaps "Select search result: ".. your right it's a bib record and not an item, but to an OPAC user I'm not sure they'd want to draw the difference.. it's used for selecting a result to place on hold etc. > > I think the values of aria-label attributes are not automatically picked up > by the translator, so it is not translatable. Good question.. I didn't think about that.. is that not a wider issue though.. we need aria-labels for accessibility.. we really ought to pick them for translations. > > Also, QA script complains about missing TT filters Oops.. I'll fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] Add a way to restrict anonymous access to public routes (OpacPublic behaviour)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 --- Comment #39 from Victor Grousset/tuxayo --- Thanks! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 Alex Arnaud changed: What|Removed |Added QA Contact||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 --- Comment #18 from Marcel de Rooy --- The crux is adding the $marcrecord->encoding('UTF-8') ! You should not change the new_from_xml call. We should respect the syntax parameter here instead of the marc flavour of the Koha instance. If you configured BNF correctly, it will say UNIMARC in the syntax field. Amending the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #51 from Victor Grousset/tuxayo --- (In reply to Julian Maurice from comment #50) > The cached copy of the schema is slightly different from the one at > https://schema.swagger.io/v2/schema.json > Where does it come from ? From what seems to be the canonical source: https://github.com/OAI/OpenAPI-Specification/blob/master/schemas/v2.0/schema.json -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24353] [19.05] privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Alex Arnaud changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | CC||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 Alex Arnaud changed: What|Removed |Added Attachment #106246|0 |1 is obsolete|| --- Comment #7 from Alex Arnaud --- Created attachment 106491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106491=edit Bug 25864: Unit test adjustment Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #235 from Martin Renvoize --- I've added a couple of additional followups with fixes to minor issues I found.. generally it's looking great, performs well and I've not found any regressions. I'm not 100% sure about the introduced *_legacy views as we're not using them here for updating reports.. but I do like the deleted* views as a way to lower the requirement for people to immediately update reports. Having spoken to Jonathan about this I think we were in agreement they were OK to stay with a later followup working on automating updating reports to use them. All in all, I've added my SO stamp to the patchset on another local branch: https://gitlab.com/mrenvoize/Koha/-/commits/qa_20271 ready for Jonathan to merge in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 --- Comment #13 from Julian Maurice --- Created attachment 106486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106486=edit Bug 23148: Fix bridge image paths in de-DE installer files Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 Julian Maurice changed: What|Removed |Added Attachment #106392|0 |1 is obsolete|| --- Comment #12 from Julian Maurice --- Created attachment 106485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106485=edit Bug 23148: (follow-up) Correct image paths in sample data and tests Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 didier changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #8 from didier --- Hi should be my $op = $input->param('op') // ''; remove an 'op is undefined' warning in plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 Alex Arnaud changed: What|Removed |Added Attachment #106345|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 106492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106492=edit Bug 25864 - Lower case fields for searching To recreate: 1 - Have Koha using ES5 and Elasticsearch as search engine 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 3 - Do a search in authorities using 'Search entire record' (abduction if using sample db) 4 - Note no results 5 - View the page source and find 'search_query' 6 - Note the uppercased fields 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty' 8 - Note all fields lower-cased 9 - Apply patch 10 - Repeat search 11 - It works! Signed-off-by: Heather Hernandez Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 Julian Maurice changed: What|Removed |Added Attachment #106353|0 |1 is obsolete|| --- Comment #11 from Julian Maurice --- Created attachment 106484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106484=edit Bug 23148: (follow-up) Replace gif files in the OPAC with pngs This patch removes the old gif files from the OPAC bridge set and replaces them with png files. Signed-off-by: David Nind Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 Julian Maurice changed: What|Removed |Added Attachment #106352|0 |1 is obsolete|| --- Comment #10 from Julian Maurice --- Created attachment 106483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106483=edit Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Signed-off-by: David Nind Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 --- Comment #22 from Marcel de Rooy --- Note to QA: This is a bit of a workaround to fix the SRU import. See also bug 18153. Leader 9 is actually undefined in UNIMARC. Field 100 $a/26-29 Character Sets (Mandatory) should be 50 50 = ISO 10646 Level 3 (Unicode, UTF-8) But we depend heavily on MARC::Record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717 Julian Maurice changed: What|Removed |Added Attachment #106477|0 |1 is obsolete|| --- Comment #3 from Julian Maurice --- Created attachment 106498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106498=edit Bug 25717: Improve automatic renewal error messages Improve wording and grammar for automatic renewal error messages. Test plan: 1. Review the error message changes and make sure they make sense. The new message make sense to me. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25576] ILL requests Help does not take you to the correct place in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25576 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|19.05 |20.11.00, 20.05.01, released in||19.11.07, 19.05.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Julian Maurice changed: What|Removed |Added Attachment #104927|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 106495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106495=edit Bug 25511: Add --force option to update_dbix_class_files.pl This adds a --force option to the aforementioned script allowing those in the know to overwrite the schema when changes above the found are detected. Signed-off-by: Ere Maijala Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #50 from Julian Maurice --- The cached copy of the schema is slightly different from the one at https://schema.swagger.io/v2/schema.json Where does it come from ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25916] Create function and UI to modify budgets and funds.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 rkui...@roundrocktexas.gov changed: What|Removed |Added Blocks||25918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25918 [Bug 25918] Add budget/fund modification history to function added in BUG 25916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard changed: What|Removed |Added Attachment #106405|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 106482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106482=edit Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #48 from Andrew Nugged --- Note by the way, these changes with dependencies brought issues with fresh installations: on Ubuntu 18.04 with those regular steps which worked everywhere usually before, (preps + "apt-get install koha-common" and voila) now fails with: install 'koha-common' failed: Unable to correct problems, you have held broken packages. Depends: libmojolicious-plugin-openapi-perl but it is not going to be installed Depends: libnet-oauth2-authorizationserver-perl but it is not going to be installed This was when: "deb http://debian.koha-community.org/koha 20.05 main" (https://wiki.koha-community.org/wiki/Koha_on_Debian#Follow_a_codename_.28version_number.29:_20.05.2C_19.11.2C_19.05) but adding mentioned above explicit release name: "deb http://debian.koha-community.org/koha 20.05 main bionic" made install seamless. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25576] ILL requests Help does not take you to the correct place in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25576 --- Comment #6 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25919] New: Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Bug ID: 25919 Summary: Desks link is available in left side menu even if UseCirculationDesks is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I noticed the 'Desks' link in the administration menu on the left side is displayed even if the UseCirculationDesks syspref is turned off. To reproduce: 1- Make sure UseCirculationDesks is set to 'Don't use' 2- Go in Administration > Libraries (or any other section of the admin module) 3- Notice the 'Desks' link in the left side menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6393] Ability to pick which records to import from staged record lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6393 --- Comment #2 from Abbey Holt --- The ability to choose which staged records to import would be so helpful! I'm thinking of instances when a few unwanted biblio records sneak into a batch that is staged. It would be more efficient to unselect the unwanted records at that point and proceed with importing, rather than stage a new batch or delete the unwanted records after import. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #5 from Julian Maurice --- (In reply to Katrin Fischer from comment #4) > It could be discussed if we want to change the former release notes - we had > named it badly, we fixed it after realizing our error. But I can see it was > a sponsored feature, so maybe this will be nicer for the library. Are we trying to rewrite history and to *deny* that we ever used the now forbidden word "blacklist" ? :) Seriously, please do not rewrite release notes. In 20.05.00 this syspref is named NotesBlacklist and this will forever be true for that particular version. This could only add confusion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #106 from Marcel de Rooy --- (In reply to Arthur Suzuki from comment #105) > Daag Marcel, Goedemorgen Arthur :) > There is a test in CanBook before the item loop. > Then if test is false it won't enter the loop. > The check in CanItem is there to have the syspref checked even when using > ItemLevelHold (like ILSDI-HoldItem for example). I do not see the change? You test in CanBook and if it's green, you will test it again for every item? Maybe you need to tell CanItem to test once? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25916] New: Create UI to modify budgets and funds.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 Bug ID: 25916 Summary: Create UI to modify budgets and funds. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: rkui...@roundrocktexas.gov QA Contact: testo...@bugs.koha-community.org Created attachment 106479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106479=edit Mock-up of Modify Fund page with +/- and transfer function The Koha-US Acquisitions SIG discussed this enhancement and came up with some features that multiple libraries said would help their workflow. The specific features are a need a transfer between funds function as well as a add/subtract function for each account. I have attached a mock-up of the 'Modify Fund ...' screen that would incorporate the features the libraries would like. Page 1 is a suggestion to make the fund modification screen accessible from the 'all available funds... page. Page 2 shows what the current 'Modify Fund' page looks like. Page 3 shows the mock-up of how we would like it to look. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/