[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950 --- Comment #5 from David Cook --- I am pretty keen to get this going, so I'm going to apply it locally rather than wait. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Cook --- Sorry, Nick, but can't apply the patch: error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 24379: Make login_attempts not nullable The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24379-Make-loginattempts-not-nullable-I8ewqG.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #13 from David Cook --- At a glance, these patches look good. They're a bit of a pain to test though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #12 from David Cook --- No change to login_attempts between 19.11.05 and 19.11.07... No change to login_attempts between 19.11.05 and origin/19.11.x... Ah, but this is an upgraded database. I see in kohastructure.sql that login_attempts has "default 0" but in my actual upgraded database it has "default null". In 16.12.00.037, there is the following (for Bug 18314 - Add FailedLoginAttempts and borrowers.login_attempts): ALTER TABLE borrowers ADD COLUMN login_attempts INT(4) DEFAULT 0 AFTER lastseen In 17.06.00.009, the DEFAULT 0 was removed (for Bug 19344 - Reorder lang and login_attempts in the [deleted]borrowers tables): ALTER TABLE borrowers MODIFY COLUMN login_attempts int(4) AFTER lang; So that explains that. New databases will be fine, but upgraded databases will not be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #9) > I have tried on both master and 19.11.x and login_attempts contains "0" I have tried on 19.11.05 and login_attempts is null. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I agree that patrons need to be able to manually renew items even when autorenewals is turned on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25963] New: Koha converts ":" to "=" in search terms for Zebra which causes search to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25963 Bug ID: 25963 Summary: Koha converts ":" to "=" in search terms for Zebra which causes search to fail Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au Koha changes : to = because Zebra uses = to separate indexes from search terms, but this is problematic, because it transforms all colons. For instance, "title : subtitle" will become "title = subtitle" and that will cause a Zebra error. Here's the bug removed: buildQuery eb6b10f8 (Chris Nighswonger 2010-02-01 23:18:09 -0500 1768) # $query =~ s/:/=/g; Here's the bug re-introduced. getRecords 08c15831 (Joe Atzberger 2009-07-08 15:27:45 -0500 381) $query_to_use =~ s/\:/\=/g; # change : to = last minute (FIXME) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #242 from Victor Grousset/tuxayo --- From what I understand cleanup_database.pl (and maybe other things) still rely on the original table names, so with the patchset, the views. It would be in a follow up to use the new tables right? (and check if deleted) To work incrementally and not further add to this patchset. Or maybe that's a good use of views that it would be better to keep? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 --- Comment #5 from Mason James --- (In reply to Mason James from comment #0) > This bug tracks the task of adding the liblocale-codes-perl package, to fix > ubuntu-stable (focal) > > looks like perl-5.30 on debian needs liblocale-codes-perl hmm, problem exists on debian 11 too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 --- Comment #4 from Mason James --- Created attachment 106672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106672=edit pic of error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Mason James changed: What|Removed |Added Version|20.05 |master CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 --- Comment #3 from Mason James --- > 5/ confirm liblocale-codes-perl pkg is now installed :) > $ apt-cache policy liblocale-codes-perl | grep Installed > Installed: 3.62-1 until this patch is pushed, you can manually fix this problem with the following command $ sudo apt install liblocale-codes-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12617 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12617 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23816 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25934 CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #21 from David Cook --- Wow this is intimidating. I want to make the password policy much more complex via Bug 25934, but it looks like a lot of the password code needs refactoring. Kudos to you for doing all this work O_O. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23816 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25934 CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #13 from David Cook ---
Honest question:
Why do this:
sub guarantor {
my $self = shift;
my $guarantor_rs = $self->_result->guarantorid;
return unless $guarantor_rs;
return Koha::Patron->_new_from_dbic($gaurantor_rs);
}
Instead of this:
sub guarantor {
my $self = shift;
my $guarantor;
my $guarantor_rs = $self->_result->guarantorid;
if ($guarantor_rs){
$guarantor = Koha::Patron->_new_from_dbic($gaurantor_rs);
}
return $guarantor;
}
I admit that the latter has 3 more lines than the former, but the latter is way
easier to read, easier to debug, and easier to add error-handling.
Actually, that latter should probably double-check the output of
Koha::Patron->_new_from_dbic() before returning.
I've noticed a lot of Koha code directly returning the output of a method call,
and it drives me crazy. We should do more data validation. It'll mean fewer
bugs and easier maintenance.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934
--- Comment #7 from David Cook ---
(In reply to Fred King from comment #6)
> While I agree that your password criteria would be useful for many Koha
> institutions, they would not be for all of them. My Koha system used to be
> behind my institution's firewall, and we didn't need such strict security. I
> had to move it to a cloud server so all our staff could access it while they
> worked from home, but I think that for us, your proposed changes would be
> far too strict.
>
Nothing would change for existing installs - only new ones. New installs could
turn off the enhanced security.
> #1: That's a lot of characters to remember. I work in a hospital where
> medical staff have access to extremely confidential information. Our minimum
> is eight characters. Even then, I usually end up writing mine down (in
> transliterated Cyrillic, so I think I'm minimizing the danger).
>
Encrypted password managers can be good for this. Although if a person doesn't
have a dedicated workstation (like in a clinic), this can admittedly be
problematic, but that really points to a problem with hospital computer
security practices.
But this problem can also be ameliorated by the use of Single Sign On to reduce
the number of different passwords, and to make it easier to update passwords.
> #2: See https://xkcd.com/936/. I think he has a good point.
There's been lots of online debate about this, but a person could do worse.
> #3: This one I agree with. I'd also recommend a minimum number of days
> before you can change it again, if you're considering letting people reuse
> passwords after x number of changes. ("Time to change my password, and I
> can't use my past three passwords. Well, I'll change it to cat, then owl,
> then cow, and then back to dog.")
>
Yeah, in practice I find people often just increment a number at the end of the
password to try to workaround this requirement. Users have shown me all kinds
of very similar systems that they thought were unique/difficult to crack.
> #4: Also challenging to low-spec systems that use more than one language.
> I'd really, really urge you to make this one optional.
Yeah, this one is really a "nice to have" rather than a must have. Even in a
default situation, I wouldn't enable this because there are too many variables.
> #5: Well, it's really useful on an in-house test system, but OK.
That makes me think about all those airplanes that have the same usernames and
passwords from when they were on the in-house test system though.
> I'm all in favor of protection, and I know full well that any online system
> can be attacked from anywhere. I'd just like the option to choose how many
> bars to put on the windows.
It's true. Koha is all about choice. I'll keep that in mind once I start on
this work. It's great getting all these different perspectives.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #4 from David Cook --- Created attachment 106671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106671=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #3 from David Cook --- (In reply to Kyle M Hall from comment #2) > Looks good, but the default should be to allow plugin uploads to keep in > line with current behavior. Agreed. I was thinking about that late last night and early this morning. While enable_plugins is 0 by default, all the in-Koha documentation says they just need to change it to enable_plugins 1. If they did that, and enable_plugin_browser_upload is 0, they won't even know they need to enable it. So I'll do a follow-up to enable it by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25718] Correct typo in additem.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25718] Correct typo in additem.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 106670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106670=edit Bug 25718: Correct typo in additem.tt This patch corrects a typo found in additem.tt The original sentence is ": Last item for bibliographic record wich biblio-level hold on it." It is now corrected to ": Last item for bibliographic record with biblio-level hold on it." To test: 1. Apply patch 2. Restart plack 3. Find or create a record with two items 4. Place a hold on the record (biblio-level) 5. In the record details, in the holdings table, check both items 6. Click on 'Delete selected items' 7. Click again on 'Delete selected items' 8. It should say that one of the two items could not be deleted and the sentence should appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879 Caroline Cyr La Rose changed: What|Removed |Added Attachment #106638|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 106669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106669=edit Bug 25879: Improve display of guarantor information in the patron entry form This patch makes some changes to the patron entry template to improve the display of guarantor information. To test, apply the patch and locate a patron with a "Child" type category. - Edit the patron's record - Under "Guarantor information," click the "Search to add" button. - Search for and select a patron. - The guarantor information should be added to the patron edit form. The information should be correct and well formatted. - Click the "Remove" link. The guarantor information should be removed. - Search for an select a guarantor again and save the record. - Edit the patron record again. The saved guarantor information should look correct. Looks great! Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Liz Rea changed: What|Removed |Added Attachment #106664|0 |1 is obsolete|| --- Comment #6 from Liz Rea --- Created attachment 106668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106668=edit Bug 23086 - Search for collection is broken It appears that we are quoting the ccode values deep in the search code. Under ICU chains this breaks searching by limits To recreate 1 - Setup Koha using Zebra and icuchains 2 - Add ccode to AdvancedSearchTypes 3 - In koha-conf.xml set zebra debug level to include request none,fatal,warn,request,info 4 - Set some items into different ccodes 5 - On opac perform a search for: ccode:NFIC 6 - It works 7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log 8 - Note search request like: Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 9 - On opac go to advanced search, select Collection, and limit to smae code a s above 10 - No results 11 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC' 12 - Apply patch 13 - Restart all 14 - Repeat search by collection limit 15 - Success! Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=23806 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25962] New: In Advanced Editor mandatory subfields are not enforced if tag is not mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25962 Bug ID: 25962 Summary: In Advanced Editor mandatory subfields are not enforced if tag is not mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: - set your framework so the 100$a is mandatory but the 100 as a whole is not - open a new record in the advanced editor - save the record without a 100$a - edit framework to make the 100 mandatory as well as the 100$a - open a new record - try to save without a 100$a, get an error It doesn't break anything to have to mark the tag required as well as the subfield, but it's more work and it's confusingly different from how we enforce these in the regular editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 --- Comment #3 from Tomás Cohen Arazi --- Only to clarify the test plan: you need to apply both patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Tomás Cohen Arazi changed: What|Removed |Added URL||https://github.com/bywaters ||olutions/koha-plugin-kitche ||n-sink/pull/12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 10 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10=edit [DO NOT PUSH] Bug 25961: Sample usage of the OPAC XSLT variables hooks Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 106667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106667=edit Bug 25961: Add hooks for plugins to inject variables to OPAC XSLT This patch adds the following plugin hooks: - opac_results_xslt_variables - opac_detail_xslt_variables This hooks will inject variables returned by the plugin in the form of a hashref, into the ones that are passed to the XSLT processing code. To test: 1. Apply the 'DO NOT PUSH' commit 2. Install the Kitchensink plugin 3. Restart all 4. Search biblios in the OPAC => SUCCESS: A text is injected in front of the biblio title 5. Enter the detail page of any of the results => SUCCESS: A text is injected in front of the biblio title 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336 Caroline Cyr La Rose changed: What|Removed |Added Attachment #104243|0 |1 is obsolete|| --- Comment #3 from Caroline Cyr La Rose --- Created attachment 106665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106665=edit Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file This patch moves the "Show checkouts to guarantor" and "Show fines to guarantor" data to display under the Contact information block To test: 1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow 2) View a patron record. 3) The "Show checkouts to guarantor" and "Show fines to guarantor" field will be on the right hand side of the screen under the Library use block. 4) Apply patch 5) Check that this data has now moved to the Contact information block on the left hand side of the patron record. Works for me! Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25959] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25959 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|Memek |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11461] Added functionality for batch Z39.50 searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11461 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] [19.11] Cannot copy MARC frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Aleisha Amohia changed: What|Removed |Added Version(s)||19.11.08 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Aleisha Amohia --- Backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- I'm looking at a couple patrons on a 19.11 install where payments were double-submitted. The first payment set the amountoutstanding on the fine to 0. The second payment posted to their account and tied to the fine via account_offsets, but with $0 applied. So the payment wasn't refused, but Koha knew enough not to make the fine have a negative amount due. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] New: Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Bug ID: 25961 Summary: Add hooks for plugins to inject variables to XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Nick Clemens changed: What|Removed |Added Attachment #92940|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 106664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106664=edit Bug 23086 - Search for collection is broken It appears that we are quoting the ccode values deep in the search code. Under ICU chains this breaks searching by limits To recreate 1 - Setup Koha using Zebra and icuchains 2 - Add ccode to AdvancedSearchTypes 3 - In koha-conf.xml set zebra debug level to include request none,fatal,warn,request,info 4 - Set some items into different ccodes 5 - On opac perform a search for: ccode:NFIC 6 - It works 7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log 8 - Note search request like: Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 9 - On opac go to advanced search, select Collection, and limit to smae code a s above 10 - No results 11 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC' 12 - Apply patch 13 - Restart all 14 - Repeat search by collection limit 15 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25959] New: Memek
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25959 Bug ID: 25959 Summary: Memek Change sponsored?: --- Product: Koha Version: master Hardware: HP OS: Mac OS Status: NEW Severity: major Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: farhanart010...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 106662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106662=edit Farhan Is Real -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] New: Allow LongOverdue cron to include/exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Bug ID: 25958 Summary: Allow LongOverdue cron to include/exclude specified lost values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When lost items are not marked as returned, they are still subject to the long overdue cron, so an item that has already been marked Lost may automatically roll to Long Overdue. In some cases, a library may not want that lost value to change. This becomes especially important with the introduction of Claims Returned, which uses a variety of lost. I'd like to see two options added to the cron. The first to take a list of lost values that are subject to long overdue, the second to take a list of lost values that are not subject to long overdue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to include/exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 --- Comment #2 from Nick Clemens --- Created attachment 106661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106661=edit Bug 25957: Don't push blank field values to ES document To test: 1 - Load the sample DB or edit a record (using advanced cataloging editor) to have a blank subfield in a field that is indexed as suggestible 2 - For example 'author' / 100a 100 _ _ ‡a 3 - Index that record into Elasticsearch 5.X: perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 4 - Note error 'value must have length > 0' 5 - Edit mappings to set author 100a not suggestible 6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 7 - Success 8 - Set field to suggestible again 9 - Apply patch 10 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 11 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 --- Comment #1 from Nick Clemens --- Created attachment 106660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106660=edit Bug 25957: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] New: Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 Bug ID: 25957 Summary: Elasticsearch 5.X - empty subfields cause error on suggestible fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com To recreate: 1 - Load the sample DB or edit a record (using advanced cataloging editor) to have a blank subfield in a field that is indexed as suggestible 2 - For example 'author' / 100a 100 _ _ ‡a 3 - Index that record into Elasticsearch 5.X: perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 4 - Note error 'value must have length > 0' 5 - Edit mappings to set author 100a not suggestible 6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 7 - Success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25956] New: Confirm button is greyed out on write off selected page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25956 Bug ID: 25956 Summary: Confirm button is greyed out on write off selected page Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: daniel.gag...@pueblolibrary.org QA Contact: testo...@bugs.koha-community.org The Confirm button on the Write Off Selected page is greyed out so fines cannot be written off on this page. To test, 1. Select user who has a fine. 2. Go to transactions 3. Select several fines and press the Write Off Selected button. 4. On the Make a Payment tab note that Confirm button is greyed out so no write off can be done through this page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] [19.11] Cannot copy MARC frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Tried the test plan: not needed for 19.05.x, even if it backported and reverted Bug 17232, same as 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934
Fred King changed:
What|Removed |Added
CC||fred.k...@medstar.net
--- Comment #6 from Fred King ---
While I agree that your password criteria would be useful for many Koha
institutions, they would not be for all of them. My Koha system used to be
behind my institution's firewall, and we didn't need such strict security. I
had to move it to a cloud server so all our staff could access it while they
worked from home, but I think that for us, your proposed changes would be far
too strict.
#1: That's a lot of characters to remember. I work in a hospital where medical
staff have access to extremely confidential information. Our minimum is eight
characters. Even then, I usually end up writing mine down (in transliterated
Cyrillic, so I think I'm minimizing the danger).
#2: See https://xkcd.com/936/. I think he has a good point.
#3: This one I agree with. I'd also recommend a minimum number of days before
you can change it again, if you're considering letting people reuse passwords
after x number of changes. ("Time to change my password, and I can't use my
past three passwords. Well, I'll change it to cat, then owl, then cow, and then
back to dog.")
#4: Also challenging to low-spec systems that use more than one language. I'd
really, really urge you to make this one optional.
#5: Well, it's really useful on an in-house test system, but OK.
I'm all in favor of protection, and I know full well that any online system can
be attacked from anywhere. I'd just like the option to choose how many bars to
put on the windows.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the Patron's Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #1 from Rebecca Coert --- This would save front-line staff a lot of time when helping a patron at the service desk. Less clicks & page loads = faster service = happier patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 mada...@ckls.org changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #1 from Owen Leonard --- Created attachment 106659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106659=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of with in header search forms where there is not already a label tag corresponding to the first form field. In cases where there is already a label on the first form field the is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25955] compare_es_to_db.pl broken by drop of Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 Nick Clemens changed: What|Removed |Added Blocks||25955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 [Bug 25955] compare_es_to_db.pl broken by drop of Catmandu dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25955] compare_es_to_db.pl broken by drop of Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 Nick Clemens changed: What|Removed |Added Depends on||24823 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 [Bug 24823] Drop Catmandu dependency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25955] compare_es_to_db.pl broken by drop of Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 --- Comment #1 from Nick Clemens --- Created attachment 106658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106658=edit Bug 25955: Fix getting index_name To test: 1 - Have a site running ES 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Lots of output, all bad 4 - Apply patch 5 - Repeate 6 - Whew, looks correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25955] New: compare_es_to_db.pl broken by drop of Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 Bug ID: 25955 Summary: compare_es_to_db.pl broken by drop of Catmandu dependency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Bug 24823 removed catmandu, but code in compare_es_to_db was not updated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] New: Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Bug ID: 25954 Summary: Header search forms should be labeled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The markup for the header search forms in the staff interface use a tag to show descriptive text about the form. For instance: Enter patron card number or partial name: In most cases this can be replaced with a label: Enter patron card number or partial name: This will improve accessibility and eliminate errors raised by WCAG checks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #90 from Martin Renvoize --- Rescued.. I've sorted the licence issues and added some POD.. Remaining QA script failure are false negatives. I've not QA'd as a whole as I'm not close enough to the area of code to really have an opinion whether it's good or not.. back to NQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #89 from Martin Renvoize --- Created attachment 106657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106657=edit Bug 17499: (QA follow-up) Fix POD errors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #88 from Martin Renvoize --- Created attachment 106656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106656=edit Bug 17499: (QA follow-up) Fix Licence Statements Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Martin Renvoize changed:
What|Removed |Added
Attachment #103441|0 |1
is obsolete||
--- Comment #85 from Martin Renvoize ---
Created attachment 106653
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106653=edit
Bug 17499: Add Koha-objects for messaging preferences
This patch adds Koha-objects for messaging preferences.
Adds simple validation for messaging preferences.
The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference
Adds a method for getting available messaging options.
Adds a method for setting default messaging preferenes.
$patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
...or...
Koha::Patron::Message::Preference->new_from_default({
borrowernumber => 123,
categorycode => "ABC",
message_attribute_id => 1,
});
Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
$preference->message_transport_types (for
getting)
$preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
(also supports other calling conventions, see documentation for more)
Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.
Includes test coverage for basic usage.
To test:
1. prove t/db_dependent/Koha/Patron/Message/*
Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.
Signed-off-by: Dominic Pichette
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Martin Renvoize changed: What|Removed |Added Attachment #103443|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 106655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106655=edit Bug 17499: Replace test subroutines with build_object This patch replaces subroutines used to build test objects with call to $builder->build_object. To test prove that tests are still running with: prove t/db_dependent/Koha/Patron/Message/* Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Martin Renvoize changed: What|Removed |Added Attachment #103442|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 106654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106654=edit Bug 17499: Define koha_object(s)_class where needed This patch adds koha_object(s)_class for needed modules to fix issues with tests. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24539] Build generic authentication module interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > I'm not using the existing Koha plugin system, as I'm still not 100% sure I > want to implement these as plugins that end-users can upload... but still > thinking. If https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 is pushed, then I think it would be reasonable to do auth plugins as Koha plugins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add class to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 David Cook changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add class to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 --- Comment #2 from David Cook --- Created attachment 106652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106652=edit Bug 25953: Add class to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" class to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add class to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add class to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 David Cook changed: What|Removed |Added Summary|Label installed plugins and |Add class to installed |add class to table to ease |plugins table to ease |styling and DOM mods|styling and DOM mods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Label installed plugins and add class to table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 David Cook changed: What|Removed |Added Summary|Change "Plugins" to |Label installed plugins and |"Installed plugins" on |add class to table to ease |plugins-home.pl |styling and DOM mods --- Comment #1 from David Cook --- Ah, but right now the "Search results" are shown as a h2 under the h1 of Plugins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] New: Change "Plugins" to "Installed plugins" on plugins-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 Bug ID: 25953 Summary: Change "Plugins" to "Installed plugins" on plugins-home.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org It would be more exact to say "Installed plugins" instead of "Plugins" on plugins-home.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What|Removed |Added Summary|Administrators should be|Install 1 Koha plugin for X |able to add/upload plugins |Koha instances using the |from the command line |CLI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #2 from David Cook --- Actually, I think the syntax would be "koha-plugin --install " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Kyle M Hall --- Looks good, but the default should be to allow plugin uploads to keep in line with current behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #1 from David Cook --- Created attachment 106651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106651=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
