[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 --- Comment #15 from David Cook --- (In reply to Julian Maurice from comment #14) > What is there to check in this particular situation ? _new_from_dbic either > dies or return a blessed object. If it dies then Koha::Patron::guarantor > should die too, if it returns a blessed object, then there is nothing to > check. That's an interesting perspective. If it dies, it's probably going to bring down that entire Plack worker. That seems problematic to me. We could try to trap the error in the caller, but in practice that is rare in Koha. That being said, even if it doesn't die, we need to handle a non-fatal exception too. Maybe it is better to die in the grand scheme of things, as it'll more easily show code bugs and bad data. If it doesn't die, what happens if you want to add a check to that object? Maybe you only want to return the guarantor under certain conditions. It probably makes sense to add that check here rather than in every caller of this method. To do that, you'd have to refactor to use the syntax I described anyway. Or maybe you're doing some debugging because the guarantor being returned isn't correct. You can't add any logging in this code unless you refactor to the syntax I described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #61 from David Cook --- (In reply to Julian Maurice from comment #59) > Failing QA to get an answer to comment 49 Yeah that's fair. I'll put it on my TODO list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950 --- Comment #7 from David Cook --- Thanks, Didier! For what it's worth, I have this running locally in production now, and it's working well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Mason James changed: What|Removed |Added Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Mason James changed: What|Removed |Added CC||alei...@catalyst.net.nz, ||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 --- Comment #6 from Mason James --- (In reply to Mason James from comment #5) > (In reply to Mason James from comment #0) > > This bug tracks the task of adding the liblocale-codes-perl package, to fix > > ubuntu-stable (focal) > > > > looks like perl-5.30 on debian needs liblocale-codes-perl > > > hmm, problem exists on debian 11 too this seems to stop installation at the 'web installer' stage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #52 from Victor Grousset/tuxayo --- +1 for proof-of-concept Maybe also one template at a time, I don't know. Maybe beginning with the proof-of-concepts and see if it's necessary to keep doing one by one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #12 from Kelly McElligott --- Hi, It would appear that the item does not remove until the page reloads? I would encourage to reload during this transaction so the staff can see it come off of the account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25971] Allow arbitrary database field as runtime parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25971 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25971] Allow arbitrary database field as runtime parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25971 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- Another awesome idea. I'd definitely like to see this implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25971] New: Allow arbitrary database field as runtime parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25971 Bug ID: 25971 Summary: Allow arbitrary database field as runtime parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Yet another runtime parameter idea, how about allowing a syntax like "SELECT * from accountlines WHERE debit_type_code like <>" So Koha then builds the parameter list based on a "select distinct code from account_debit_types" To make it even nicer, we could allow "<>" so we use the code as our value but display the corresponding description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25173] Create list of parameters to choose from via a query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25173 --- Comment #2 from Andrew Fuerste-Henry --- Kicking this around a little more, would it be easier or cleaner to make the parameter point at a saved report? So, for your example, you'd make one report that's "SELECT shelfname FROM virtualshelves" and then in your second report say "WHERE shelfname LIKE <>" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25970] Make account_debit_types and account_credit_types available as runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25970 --- Comment #2 from Andrew Fuerste-Henry --- (In reply to George Williams (NEKLS) from comment #1) > This is an outstanding idea. Well, I mean, it was yours :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273
--- Comment #14 from Nick Clemens ---
(In reply to Julian Maurice from comment #12)
> Hi Nick,
>
> Thanks for the explanation, it is much more clear to me now. The change
> makes sense and the patch works as expected.
>
> However I would like to see some changes in the patch before validating it:
>
> 1)
>
> -ModZebra( $authid, 'specialUpdate', 'authorityserver', $record );
> +ModZebra( $authid, 'specialUpdate', 'authorityserver', { record =>
> $record, authtypecode => $authtypecode } );
>
> This change is confusing. In ModZebra we now have a $record variable which
> is a hash that contain a 'record' key. Even with this simple patch I had to
> ask myself several times « what's this $record variable I'm looking at ? The
> hash or the MARC::Record ? ».
> Look at this line for instance:
>
> +$record = $record->{record};
>
> At some point in the subroutine, $record was a hasref, now it's a
> MARC::Record. This is the kind of things that make code hard to read, and
> make it easier for bugs to appear.
>
> And I think it is not needed to pass the authtypecode to ModZebra, since it
> can be obtained from the MARC::Record.
>
> 2)
>
> -unless ($record) {
> +if ($record) {
> +$indexer->update_index_background( [$biblionumber],
> [$record] );
> +} else {
> $record = GetMarcBiblio({
> biblionumber => $biblionumber,
> embed_items => 1 });
> +$indexer->update_index_background( [$biblionumber], [{
> record => $record }] );
> }
> -my $records = [$record];
> -$indexer->update_index_background( [$biblionumber], [$record] );
>
> I think it was easier to read before : unless there is a record, fetch it;
> in all cases call update_index_background
> Now it's : if there is a record, call update_index_background, otherwise
> fetch the record and call update_index_background.
> This change was not needed, so why ? :)
>
> 3)
>
> -my $id = $record->id // $record->authid;
> +my $id = $record->id;
>
> Again this change is not needed, but this time it causes a bug.
> Try this : misc/search_tools/rebuild_elasticsearch.pl -a -ai X (replace X by
> an existing authid)
1 - Yes, was trying to save a call to GuessAuthType, reverted
2 - This was a result of above, turning record into a hash if needed, undone
3 - It made sense at the time, but yes, it breaks, removed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #13 from Nick Clemens --- Created attachment 106759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106759=edit Bug 25273: (follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 --- Comment #2 from Kyle M Hall --- Created attachment 106758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106758=edit Bug 25969: Checking in a found hold at a different branch then confirming the hold causes internal server error If a record level hold is filled and waiting at Library A, and the item is checked in at Library B, and an attempt is made to re-fill the hold with the item, Koha will return an ISE. Test Plan: 1) Place a hold for Library A, at Library A, for pickup at Library A 2) Check in the item at Library A and fill the hold so it is waiting at Library A 3) Log in as Library B, check in the same barcode 4) Note the request to fill the hold with the item 5) Choose to fill the hold 6) Note you get an internal server error 7) Apply this patch 8) Restart all the things! 9) Repeat steps 1-5 10) No ISE! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25970] Make account_debit_types and account_credit_types available as runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25970 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- This is an outstanding idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25970] New: Make account_debit_types and account_credit_types available as runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25970 Bug ID: 25970 Summary: Make account_debit_types and account_credit_types available as runtime parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Accountlines reports would be easier to write if the new account_credit_types and account_debit_types tables were available as runtime parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 --- Comment #1 from Kyle M Hall --- So the root cause is that we are not passing the itemnumber *for the scanned barcode* back to the form, making itemnumber undef, so the Item object is empty, so calling the biblio method causes an ISE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] New: Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Bug ID: 25969 Summary: Checking in a found hold at a different branch then confirming the hold causes internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a record level hold is filled and waiting at Library A, and the item is checked in at Library B, AddReturn() calls RevertWaitingStatus(), which unsets found, and itemnumber ( if the hold was record level ). AddReturn() then retuns the message 'ResFound', which triggers the hold fulfillment dialog, which passes the reserve_id back to circulation.pl. Then, circulation.pl attempts to get the biblio via the itemnumber, which the hold doesn't have, causing an ISE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #118 from Maryse Simard --- I rebased the patches and merged the ones which were signed-off. By adding the atomic update changes to it, it took care of the first qa script error. For the second error, I directly altered the schema update patch to correct it. The status has been set back to signed off, as requested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95856|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95860|0 |1 is obsolete|| --- Comment #117 from Maryse Simard --- Created attachment 106757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106757=edit Bug 12446: (follow-up) Update for Bug 17168 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95855|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95854|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95857|0 |1 is obsolete|| --- Comment #116 from Maryse Simard --- Created attachment 106756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106756=edit Bug 12446: Schema update Category.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95859|0 |1 is obsolete|| --- Comment #115 from Maryse Simard --- Created attachment 106755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106755=edit Bug 12446: (follow-up) Code cleaning Some variable name change, remove unused code and other small fixes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95858|0 |1 is obsolete|| --- Comment #114 from Maryse Simard --- Created attachment 106754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106754=edit Bug 12446: (follow-up) Remove mandatory transfered values With the new system preference AdditionalGuarantorField, one can add data to be transfered to the guarantee, but cannot remove default ones. This patch renames the syspref to GuarantorFields and set hardcoded default values as the preference's default. To test: 1. After database update, check that the default value for the syspref GuarantorFields contains these columns: streetnumber|address|address2|city|state|zipcode|country| branchcode|phonepro|mobile|email|emailpro|fax 2. Set the value as empty 3. Try adding a guarantor to a patron (from the guarantor's page or the guarantee's): no values should be imported. 4. Check that it still works with different values for the preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What|Removed |Added Attachment #95853|0 |1 is obsolete|| --- Comment #113 from Maryse Simard --- Created attachment 106753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106753=edit Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25964] Data loss possible when items are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- My test plan was to apply this patch on top of bug 20271 and run: prove t/db_dependent/Items.t to confirm that it's fixed. See bug 20271 comment 243. And then apply it to master, run the same test to confirm that it still passes. And attach the signed off patch here (the on-top-of-master one) Is that a good test? If so we can mark this ticket as signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25964] Data loss possible when items are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #106695|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 106752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106752=edit Bug 25964: Prevent data loss when editing items from a MARC record Coming from: Bug 23463: Use new method Koha::Object->set_or_blank We have DB fields that are not mapped with MARC fields, for instance paidfor. They are not handled correctly. In ModItemFromMarc, we get a MARC record in parameter and update the item in DB. But we are loosing the fields that are not in the MARC record Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] New: Make logs sort by date descending as a default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Bug ID: 25968 Summary: Make logs sort by date descending as a default Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org It would be helpful to have the logs sort by date descending so that you can view the newest items at the top of the page rather than having to scroll to the bottom. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25907] When cancelling a waiting hold on returns.pl, looks for new hold to fill without rescanning barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106453|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 106751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106751=edit Bug 25907: When cancelling a waiting hold on returns.pl, looks for new hold to fill without rescanning barcode Right now, after canceling a hold on the checkin screen, a librarian needs to rescan the item barcode to check and trap the next hold. This is an extra unnecessary step. Test Plan: 1) Place two or more holds on a record 2) Check in the item 3) Confirm the hold 4) Check in the item again 5) Cancel the hold 6) Koha should now display the modal asking to confirm the next hold without the need to rescan the barcode! Signed-off-by: Owen Leonard Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106690|0 |1 is obsolete|| --- Comment #72 from Andrew Fuerste-Henry --- Created attachment 106750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106750=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106689|0 |1 is obsolete|| --- Comment #71 from Andrew Fuerste-Henry --- Created attachment 106749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106749=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106686|0 |1 is obsolete|| --- Comment #68 from Andrew Fuerste-Henry --- Created attachment 106746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106746=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106688|0 |1 is obsolete|| --- Comment #70 from Andrew Fuerste-Henry --- Created attachment 106748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106748=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106687|0 |1 is obsolete|| --- Comment #69 from Andrew Fuerste-Henry --- Created attachment 106747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106747=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106685|0 |1 is obsolete|| --- Comment #67 from Andrew Fuerste-Henry --- Created attachment 106745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106745=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106684|0 |1 is obsolete|| --- Comment #66 from Andrew Fuerste-Henry --- Created attachment 106744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106744=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104964|0 |1 is obsolete|| --- Comment #109 from ByWater Sandboxes --- Created attachment 106740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106740=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104966|0 |1 is obsolete|| --- Comment #110 from ByWater Sandboxes --- Created attachment 106741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106741=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106682|0 |1 is obsolete|| --- Comment #64 from Andrew Fuerste-Henry --- Created attachment 106742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106742=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106683|0 |1 is obsolete|| --- Comment #65 from Andrew Fuerste-Henry --- Created attachment 106743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106743=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Your Full Name Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104959|0 |1 is obsolete|| --- Comment #104 from ByWater Sandboxes --- Created attachment 106735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106735=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104963|0 |1 is obsolete|| --- Comment #108 from ByWater Sandboxes --- Created attachment 106739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106739=edit Bug 24857: Update existing Schema files [DO NOT PUSH] Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104960|0 |1 is obsolete|| --- Comment #105 from ByWater Sandboxes --- Created attachment 106736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106736=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104961|0 |1 is obsolete|| --- Comment #106 from ByWater Sandboxes --- Created attachment 106737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106737=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104962|0 |1 is obsolete|| --- Comment #107 from ByWater Sandboxes --- Created attachment 106738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106738=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104958|0 |1 is obsolete|| --- Comment #103 from ByWater Sandboxes --- Created attachment 106734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106734=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104956|0 |1 is obsolete|| --- Comment #101 from ByWater Sandboxes --- Created attachment 106732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106732=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104957|0 |1 is obsolete|| --- Comment #102 from ByWater Sandboxes --- Created attachment 106733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106733=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104953|0 |1 is obsolete|| --- Comment #98 from ByWater Sandboxes --- Created attachment 106729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106729=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104955|0 |1 is obsolete|| --- Comment #100 from ByWater Sandboxes --- Created attachment 106731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106731=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104954|0 |1 is obsolete|| --- Comment #99 from ByWater Sandboxes --- Created attachment 106730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106730=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 ByWater Sandboxes changed: What|Removed |Added Attachment #104952|0 |1 is obsolete|| --- Comment #97 from ByWater Sandboxes --- Created attachment 106728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106728=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #22 from Martin Renvoize --- Another rebase request ;)... two QAers interested here.. grab them whilst it's hot ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #19 from Arthur Suzuki --- yay, thanks! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 25633, which changed state. Bug 25633 Summary: Update debian/control.ini file for 20.05 release cycle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 25591, which changed state. Bug 25591 Summary: Update list-deps for Debian 10 and Ubuntu 20.04 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25640] [OMNIBUS] Ubuntu 20.04 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 Bug 25640 depends on bug 25591, which changed state. Bug 25591 Summary: Update list-deps for Debian 10 and Ubuntu 20.04 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #36 from Mason James --- (In reply to Aleisha Amohia from comment #34) > backported to 19.11.x for 19.11.07, as recommended for Bug 22522 this has been resolved now, closing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Mason James changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #29 from Mason James --- (In reply to Lucas Gass from comment #28) > backported to 19.05.x for 19.05.10 this has been resolved now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Mason James changed: What|Removed |Added Assignee|m...@kohaaloha.com |tomasco...@gmail.com --- Comment #14 from Mason James --- (In reply to Jonathan Druart from comment #6) > Wiki pages need to be updated: > > https://wiki.koha-community.org/wiki/Koha_on_Debian#Debian_Packages_on_Koha > > https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Introduction > > > Also should not we inform the ML? i've updated the following wiki page... https://wiki.koha-community.org/wiki/Koha_on_Debian and made a request to merge the following page... https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages i think this issue is now resolved :0) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #13 from Mason James --- (In reply to Mason James from comment #12) > (In reply to David Cook from comment #11) > > (In reply to Jonathan Druart from comment #10) > > > What is needed here? > > > > I imagine Mason probably just needs to remove libcryptx-perl from > > http://debian.koha-community.org/koha/pool/main/libc/libcryptx-perl/ > > i've updated the libcryptx-perl package for 20.05, built for deb9 > 20.05|main|amd64: libcryptx-perl 0.063-1~bpo9+1 > > the libcryptx-perl package for 19.11 is still built for deb8 > 19.11|main|amd64: libcryptx-perl 0.059-1~koha2 > > i have not updated the 19.11 libcryptx-perl package yet, as i dont want to > break 19.11/deb8 support for those who are still running this combination the libcryptx-perl package has now been updated for 20.05 and 19.11 releases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21373] Checkout not possible when biblio level hold but other items could satisfy it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21373 Joonas Kylmälä changed: What|Removed |Added Attachment #79378|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21373] Checkout not possible when biblio level hold but other items could satisfy it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21373 Joonas Kylmälä changed: What|Removed |Added Attachment #79377|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950 didier changed: What|Removed |Added Attachment #106647|0 |1 is obsolete|| --- Comment #6 from didier --- Created attachment 106722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106722=edit Bug 25950: Remove in X-Forwarded-For from proxy tests This patch removes the ip address in the X-Forwarded-For header from being tested against koha_trusted_proxies. Without this patch, REMOTE_ADDR will be set to null, if the ip address matches against koha_trusted_proxies. To Test: 1. Run the unit test t/Koha/Middleware/RealIP.t Signed-off-by: Didier Gautheron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950 didier changed: What|Removed |Added Patch complexity|Small patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #40 from Tomás Cohen Arazi --- (In reply to Hugo Agud from comment #39) > I hae tested the patch and it works fine! however the code applied to opac > is not applied to staff xslt and it shows the links always, even when there > is not analytics. My idea was to have feedback on the approach, and then move to other areas. The 'how to find analytics' discussion (i.e. the queries that are done) should be moved to another bug, for example. Thanks for testing, and I will add the intranet counterpart for you to SO ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #22 from Christopher Brannon --- (In reply to Tomás Cohen Arazi from comment #21) > So the result is similar, but ugly-ish. And involves an error prone > free-text field with pipe-separated values. So I don't see any advantage on > it. If we were to expose this condition on the API also, we would need to > add methods to extract the boolean with this kind of comparison, instead of > just reading what's on the category table. What if it wasn't a free-text field? What if we did something similar to what is being done in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844? Select the categories from a list rather than free typing? I'd prefer to keep these settings together, but if you think it makes more sense to put exclusions in the patron categories, then that would be acceptable. It works. My biggest concern is trying to debug behavior. It's one thing to have the items with their own exclusions in the record. But trying to figure out why it excluding items in some cases and not others because of a patron category exclusion might be more challenging. If there were some indicator when the exclusion is skipped somewhere, then I would have no problem with it. If it is logged, then it would be easy to trace. I'm just trying to make sure that our enhancement doesn't become a headache for those using it to try and understand system behavior. Circulation rules alone are hard to follow when dealing with multiple branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to include/exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 --- Comment #2 from Andrew Fuerste-Henry --- Yes, absolutely! We've already got several options in the cron that can only be set at the command line. It would be good to move toward making those options all configurable from the staff client so those sysprefs are an accurate representation of the cron's behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #1 from Lari Strand --- Or is there a way to leave the sip server socket connection open for future messages, in a way that it still allows me to catch the sip server's response, and when another message is being sent in the same address, check if the connection already exists and use that instead of creating a new socket connection, directly in the module? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #7 from David Cook --- The code is still WIP, but I probably won't get back to this for a week or two. Looking forward to getting back to this though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25967] New: Plugin upgrade should remove existing code before installing new code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25967 Bug ID: 25967 Summary: Plugin upgrade should remove existing code before installing new code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At the moment, upgrading a plugin really means overwriting the existing plugin files with new files. This is fine for files that are added or modified, but it won't remove files that have been deleted. Of course, we don't necessarily know what files to delete when we're upgrading a plugin, because we don't track the files, and the files can be a bit messy. For instance, "/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions" is the root for both KitchenSink and CoverFlow. This is probably an infeasible idea due to existing installs, but just pointing out the flaw in the plugin architecture. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall --- It is used in a SIP option. Take a look at etc/SIPconfig.xml in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #6 from David Cook --- The following would work too but it wouldn't be efficient with a KPZ file or a HTTP(S) URL, because it would be re-downloading and/or re-unzipping every time: koha-foreach perl misc/koha_plugin.pl --install https://github.com/bywatersolutions/koha-plugin-coverflow/releases/download/v2.4.35/koha-coverflow-plugin-v2.4.35.kpz koha-foreach perl misc/koha_plugin.pl --uninstall Koha::Plugin::Com::ByWaterSolutions::CoverFlow That said, it could be done with an unzipped plugin. That could be interesting. You wouldn't even need a KPZ file. You could point it right at a git checkout for instance. (That could actually be really useful from a Koha plugin development point of view as well.) -- Perhaps I should rename misc/koha_plugin.pl to misc/koha_plugin_manager.pl. -- A goal of mine is to use this management feature to actually install a Koha Plugin for all my many libraries which is itself a Web-based Koha Plugin manager (inspired by the "Game Package Registry for Unity release" from Google for the Unity IDE). That Web-based Koha Plugin manager will then easily let Koha intranet users decide which plugins they want to install, but it'll only include a list of curated plugins. Alternatively, I might use this management feature to install Koha plugins which used to be local customizations, and popular third-party plugins like Bywater's CoverFlow. Ultimately, I think we need a tool like this for dealing with plugins on any kind of scale that becomes manually unmanageable (e.g. 40 instances, 80 instances, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #5 from David Cook --- I'm also going to make it so that you can provide a KPZ file or an unzipped KPZ, so misc/koha_plugin.pl will be very flexible in terms of inputs. The Debian script koha-plugin will download plugins over HTTP/HTTPS, and then unpack downloaded/local KPZ files into a staging directory. The staging directory will then be copied to each instance specified. It should be pretty sweet. I want to add enable/disable options as well at some point, but that's not critical yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25966] New: Renewal of lost item generates overdue fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25966 Bug ID: 25966 Summary: Renewal of lost item generates overdue fine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If an item is both overdue and lost, renewal of that item will generate fines. This behavior is inconsistent with the behavior of the fines cron, which explicitly excludes lost items from fines. I expect there are libraries that prefer the current behavior but also libraries that would rather not generate overdue fines on renewal of lost items. So perhaps a system preference is in order? Do/Don't charge fines on renewal of lost items? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #4 from David Cook --- koha-shell -c "perl misc/koha_plugin.pl --install https://github.com/bywatersolutions/koha-plugin-coverflow/releases/download/v2.4.35/koha-coverflow-plugin-v2.4.35.kpz; kohadev koha-shell -c "perl misc/koha_plugin.pl --install https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.39/koha-plugin-kitchen-sink-v2.1.39.kpz; kohadev koha-shell -c "perl misc/koha_plugin.pl --uninstall Koha::Plugin::Com::ByWaterSolutions::CoverFlow" kohadev koha-shell -c "perl misc/koha_plugin.pl --uninstall Koha::Plugin::Com::ByWaterSolutions::KitchenSink" kohadev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25965] New: Create SIP2 client daemon with HTTPS API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 Bug ID: 25965 Summary: Create SIP2 client daemon with HTTPS API endpoint Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: lmstr...@gmail.com I am trying to pass messages to a sip server using a new endpoint I created in swagger/openApi. This endpoint uses the guidelines described here: http://biblstandard.dk/rfid/dk/rfid_sip2_over_https.htm The idea is to get rid of the tunneling/VPN implementations that we use, and use HTTPS instead to pass sip messages back and forth inside an XML. The Apache server handles the HTTPS stuff so I don't have had to worry about that so far when communicating with the REST api, hence the SipOHttp naming in my module. At the moment I can send the XML POST messages formed like in the linked guideline to the endpoint (XML wrapped SIP2 message to .../api/v1/sipmessages/). The api forwards the body content of the request to my module Koha::REST::V1::SipOHttp. The module validates and parses the contents of the XML message, extracts the information about the sip server the message is intended to (using the "login:" parameter inside the XML) and the sip message itself (inside the variable). Then the module passes the sip message on to the sip server using IO:Socket::INET. My problem is that the sip server closes the connection after this first SC device login message has been passed and the response has been read back in my module: (from sip2.log) . [INFO] [undef]@10.0.3.217: OUTPUT MSG: '941' C4::SIP::Sip::write_msg /home/koha/Koha/C4/SIP/Sip.pm (187) [DEBUG] SIPDEVICE@10.0.3.217: raw_transport: uname/inst: 'SIPDEVICE/SIPDEVICE' C4::SIP::SIPServer::raw_transport /home/koha/Koha/C4/SIP/SIPServer.pm (174) [DEBUG] SIPDEVICE@10.0.3.217: EOF returned on read C4::SIP::SIPServer::read_request /home/koha/Koha/C4/SIP/SIPServer.pm (349) [INFO] SIPDEVICE@10.0.3.217: raw_transport: shutting down C4::SIP::SIPServer::raw_transport /home/koha/Koha/C4/SIP/SIPServer.pm (178) So I need a way to keep this socket connection open for other future messages. Without touching the sip server's code itself, the only solution I can come up with is a proxy server that handles and passes on the REST api's incoming messages to sockets and keeps each invidual socket connection open to specific instances of the sip servers (I suppose the sip server itself ends the connections when needed so you wouldn't have to worry about it in the sender's end). Another solution would be to build a new api separate from the swagger/Openapi one. Like an all-in-one solution that deals with the requests and keeps tabs on the open socket connections. Let me know if you have ideas regarding this. Ps. I'm a trainee in Koha Suomi (Finland) so excuse me if the description of my problem is a bit vague and lacks some correct terms used. I'm happy to fill in any details I've left out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #42 from Martin Renvoize --- Tested and signed off by Heart of England NHS Trust. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #20 from Martin Renvoize --- Created attachment 106720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106720=edit Bug 25723: Remove tests for removed method We removed the exception_holidays (and single_holidays) methods as part of this patchset. As such, we should no longer test them ;) Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #18 from Martin Renvoize --- Created attachment 106718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106718=edit Bug 25723: Use the same code for single and exception holidays This patch refactors is_exception_holiday and is_single_holiday to utilise a single _holidays method which combines the logic of the previous single_holidays and exception_holidays methods. As Koha::Calendar is instantiated at a branch level, we also move split the cache into branches too. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #21 from Martin Renvoize --- Created attachment 106721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106721=edit Bug 25723: (QA follow-up) Silent POD warning I didn't introduce the method that is warned about, but adding POD for it seemed reasonable and will silence the QA Script warning. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #17 from Martin Renvoize --- Created attachment 106717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106717=edit Bug 25723: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #19 from Martin Renvoize --- Created attachment 106719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106719=edit Bug 25723: Update cache flushing calls This patch updates the previous single_holidays and exeption_holidays cache flushing calls to match the new cache key structure of the updated routines. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #16 from Martin Renvoize --- Created attachment 106716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106716=edit Bug 25723: Drop DateTime::Set from cpanfile Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #15 from Martin Renvoize --- Created attachment 106715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106715=edit Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #14 from Martin Renvoize --- Created attachment 106714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106714=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #3 from David Cook --- Turns out that the easier way to do this was to create "misc/koha_plugin.pl" which will be called by koha-plugin... koha-shell -c "perl misc/koha_plugin.pl --uninstall Koha::Plugin::Com::ByWaterSolutions::CoverFlow" kohadev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 --- Comment #15 from Julian Maurice --- (In reply to Jonathan Druart from comment #13) > root@615331e1369d:koha(master)$ cd /tmp > root@615331e1369d:tmp$ koha-shell -c pwd kohadev > /tmp > root@615331e1369d:tmp$ koha-shell kohadev > kohadev-koha@615331e1369d:/tmp$ pwd > /tmp Sorry, I misread the patch. The problem is with the --login option: # cwd is /home/koha/env/master/src # user test-koha created by hand so $HOME is different than with package install % debian/scripts/koha-shell --login -c pwd test /home/test-koha % debian/scripts/koha-shell --login test % pwd /home/koha/env/master/src Compare with sudo: # cwd is /home/koha/env/master/src % sudo --login -u test-koha pwd /home/test-koha % sudo --login -u test-koha % pwd /home/test-koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
