[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #509 from Aleisha Amohia --- (In reply to Owen Leonard from comment #498) > I ran into a problem at step 70, checking in a recalled item which requires > a transfer and clicking "confirm recall and transfer." The dialog disappears > as expected but then I'm shown another modal, the regular transfer dialog > which is shown when an item is checked in at the wrong branch. Believe I've fixed this, should be good to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #106817|0 |1 is obsolete|| --- Comment #508 from Aleisha Amohia --- Created attachment 106857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106857&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25862] TinyMCE editor mangles local url links (relative_urls is true) in tools/koha-new.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 --- Comment #6 from Lucas Gass --- Created attachment 106856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106856&action=edit Bug 25862: TinyMCE editor mangles local url links in tools/koha-new.pl To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25862] TinyMCE editor mangles local url links (relative_urls is true) in tools/koha-new.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086
--- Comment #8 from Katrin Fischer ---
The fix we use in production is a bit more radical than yours :)
-if ( $k !~ /mc-i(tem)?type/ ) {
-# in case the mc-ccode value has complicating chars like ()'s
inside it we wrap in quotes
-$this_limit =~ tr/"//d;
-$this_limit = $k.":'".$v."'";
-}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23086] Search for collection is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 --- Comment #7 from Katrin Fischer --- Created attachment 106855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106855&action=edit Bug 23086: Search for collection is broken It appears that we are quoting the ccode values deep in the search code. Under ICU chains this breaks searching by limits To recreate 1 - Setup Koha using Zebra and icuchains 2 - Add ccode to AdvancedSearchTypes 3 - In koha-conf.xml set zebra debug level to include request none,fatal,warn,request,info 4 - Set some items into different ccodes 5 - On opac perform a search for: ccode:NFIC 6 - It works 7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log 8 - Note search request like: Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 9 - On opac go to advanced search, select Collection, and limit to smae code a s above 10 - No results 11 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC' 12 - Apply patch 13 - Restart all 14 - Repeat search by collection limit 15 - Success! Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=23806 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25293] Don't call escapeHtml on null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 Katrin Fischer changed: What|Removed |Added Attachment #106634|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 106854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106854&action=edit Bug 25293: Don't call escapeHtml on null Test Plan: 1) Create two Checkouts 2) view patron's checkout list cgi-bin/koha/members/moremember.pl?borrowernumber=pp 3) in mysql shell delete a checkout home branch: update items set homebranch = null where itemnumber = xx; 4) view patron's checkout list, again Without this patch the list is empty. Same if biblio title is null (update biblio set title = null where biblionumber = yy;). Javascript error: TypeError: oObj.title is null Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25293] Don't call escapeHtml on null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25974] Remove inline style from table settings administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Katrin Fischer changed: What|Removed |Added Attachment #106786|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 106853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106853&action=edit Bug 25974: Remove inline style from table settings administration page This patch removes an inline style attribute from the table settings administration template. A different style is added to the page's
[Koha-bugs] [Bug 25974] Remove inline style from table settings administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #41 from Katrin Fischer --- (In reply to Maryse Simard from comment #40) > Rebased the patch and added a commit for unit tests. > > I was unsure which status to set this to, so I've set it back to needs > signoff. If the rebase was not too hard you can switch off back to Signed off usually. Also added tests are ok as a QA follow-up :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Katrin Fischer changed: What|Removed |Added Attachment #79826|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #10 from Katrin Fischer --- (In reply to Pablo AB from comment #9) > I just formatted Martin Renvoize's comment 5. Sorry Pablo, totally missed that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #33 from Katrin Fischer --- *** Bug 25741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25741] Guarantee shows guarantor with borrowernumber, not cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25741 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 23808 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20154] Stay in the open tab when editing authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20154 --- Comment #1 from Owen Leonard --- Created attachment 106852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106852&action=edit Bug 20154: Stay in the open tab when editing authority record This patch adds some JavaScript to the authority record detail page in the staff interface so that clicking "Edit" will take you to the authority edit page while keeping the same tab open. To test, apply the patch and locate an authority record in your catalog. - Click any of the numbered tabs besides tab 0. - Choose "Edit record" from the "Edit" dropdown menu. - When the authorities edit page loads the same tab should be preselected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20154] Stay in the open tab when editing authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20154 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20154] Stay in the open tab when editing authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20154 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED Summary|stay in the open tab when |Stay in the open tab when |going into edit mode|editing authority record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 --- Comment #2 from Owen Leonard --- Created attachment 106851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106851&action=edit Bug 15933: Add cataloguing plugin to search for existing publishers in other records This patch adds a new cataloging plugin for MARC21 installations, marc21_field-260b.pl. When enabled it provides autocomplete for publisher name, pulling existing data from biblioitems.publishercode. To test, apply the patch and enable the plugin: - Go to Administration -> MARC bibliographic framework -> MARC structure -> 260 -> Edit subfields -> Subfield b -> Other options. - Set "Plugin" to marc21_field_260b.pl. - Go to Cataloging and edit or create a record. - Under tab 2 click the field for 260$b. Start typing a publisher name. A dropdown should appear with matching publishers. - Selecting one of the results should populate the form field with that information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Summary|Add cataloguing plugin to |Add cataloguing plugin to |search for existing vendors |search for existing |in other records|publishers in other records Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 106850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106850&action=edit Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Magnus Enger Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106849|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 --- Comment #3 from Magnus Enger --- Tested on a regular Debian package install running version 19.11.07. I'd say this fixes a pretty major bug for libraries using ILL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 Magnus Enger changed: What|Removed |Added Attachment #106631|0 |1 is obsolete|| --- Comment #2 from Magnus Enger --- Created attachment 106849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106849&action=edit Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Magnus Enger Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106836|0 |1 is obsolete|| --- Comment #36 from Andrew Fuerste-Henry --- Created attachment 106848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106848&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones This patchset adds a new syspref: BiblioItemtypeInfo If you set BiblioItemtypeInfo to Koha, you will see the Koha record level itemtype info. This info is also shown if item-level_itypes is set to biblio Display of icons are controlled by noItemTypeImages/OpacnoItemTypeImages Material type display is controlled by DisplayIconsXSLT/DisplayOPACIconsXSLT To test: 1 - Apply patch 2 - Update database 3 - Do an opac search and view results 4 - Switch pref to 'Koha' and refresh 5 - Note itemtypes appear 6 - Click in to a record details 7 - Note you see itemtype and icon 8 - Switch the pref 9 - Note you don't see record level itemtype and icon 10 - Repeat in staff interface Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Lucas Gass changed: What|Removed |Added Attachment #106846|0 |1 is obsolete|| --- Comment #16 from Lucas Gass --- Created attachment 106847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106847&action=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Attachment #97058|0 |1 is obsolete|| Attachment #97073|0 |1 is obsolete|| Attachment #105522|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 106846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106846&action=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #30 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #28 from Lucas Gass --- backported to 20.05.x. for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23410] Add submenus to system preferences sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- Nice enhancement but not backporting to the 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #79 from Lucas Gass --- not backporting this enhancement to the 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #35 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #26 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user search if they have multiple sub permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #10 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Owen Leonard changed: What|Removed |Added Attachment #106828|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 106845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106845&action=edit Bug 25984: Add minimum height and width to shelf browser covers This patch adds a class to the shelf browser cover image links and a style for these links defining a minimum height and width. This allows the browser's default tab focus outline to be visible. This patch also adds a check for an enabled cover image service before displaying the cover image links. This patch introduces whitespace changes so diff accordingly. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the OPACShelfBrowser system preference. - Enable at least one cover image service (Amazon, Google, Coce, etc). - Locate a title in the OPAC which has items attached. - On the bibliographic detail page, click the "Browse shelf" link in the table of holdings to display the shelf browser. - Use the tab key to move the focus to cover images in the shelf browser. - Confirm that the focus outline moves through each cover link whether or not there is a cover image available. - Diable all cover image services. - Test the shelf browser again and confirm that it's not necessary to tap through an empty row. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00. 20.05.02 released in|| CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25379] HTML tags visible in Returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25807] Version 3.008 of Template breaks smart-rules display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #72 from Lucas Gass --- not backporting enhancement to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #67 from Lucas Gass --- not backporting this enhancement to the 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip trapping items with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #14 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #24 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25805] SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Copy a change on the calendar to all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #31 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18911] Option to set preferred language in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #14 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nick Clemens changed: What|Removed |Added Attachment #106831|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 106836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106836&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones This patchset adds a new syspref: BiblioItemtypeInfo If you set BiblioItemtypeInfo to Koha, you will see the Koha record level itemtype info. This info is also shown if item-level_itypes is set to biblio Display of icons are controlled by noItemTypeImages/OpacnoItemTypeImages Material type display is controlled by DisplayIconsXSLT/DisplayOPACIconsXSLT To test: 1 - Apply patch 2 - Update database 3 - Do an opac search and view results 4 - Switch pref to 'Koha' and refresh 5 - Note itemtypes appear 6 - Click in to a record details 7 - Note you see itemtype and icon 8 - Switch the pref 9 - Note you don't see record level itemtype and icon 10 - Repeat in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14532] koha-dump should provide a way to exclude Zebra indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tomás Cohen Arazi changed: What|Removed |Added Blocks||2 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 [Bug 2] Add --exclude-indexes option to koha-run-backups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Tomás Cohen Arazi changed: What|Removed |Added Depends on||14532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 [Bug 14532] koha-dump should provide a way to exclude Zebra indexes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 106835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106835&action=edit Bug 2: Add --exclude-indexes to koha-run-backups This patch adds a trivial switch so koha-run-backups can pass the --exclude-indexes option switch to koha-dump. This way if the sysadmin doesn't want to backup the Zebra indexes, it can be controlled by tweaking the cron definition. To test: 1. Apply this patch 2. Run: $ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha 3. Notice the size of the backups: $ ls -lh /var/spool/koha/kohadev 4. Try the new option switch: $ debian/scripts/koha-run-backups \ --exclude-indexes \ --days 2 --output /var/spool/koha 5. Repeat 3 => SUCCESS: Backups are smaller! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106830|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25964] Data loss possible when items are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25964] Data loss possible when items are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Keywords||rel_20_05_candidate --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 106834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106834&action=edit Bug 25909: Recent change to datatables JS in the OPAC causes errors This patch reverts some changes made by Bug 25287 which prematurely introduced the double-underscore i18n function. The i18n features haven't been fully implemented in the OPAC. Some lines are reverts to the previous version, and some are additions, for instance where Bug 25287 introduced new DataTables features and a new string translation is required. In addition to i18n changes, the patch also reverts the default configuration of DataTables in the OPAC so that the "dom" configuration option is set back to "t." This turns off features like pagination buttons, filters, etc. which were previously disabled by default. Enabling these features requires revision to the OPAC CSS in order for them to display well. To test, apply the patch and view a page in the OPAC which includes a DataTable. For instance: checkouts on the "your summary" page, serial issues on the "full subscription history" page. Tables should display correctly and sorting should work correctly. There should be no other DataTables controls visible. To test translatability: To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-opac-bootstrap.po - Locate strings pulled from bootstrap/en/includes/datatables.inc for translation, e.g.: #. SCRIPT #: opac-tmpl/bootstrap/en/includes/datatables.inc:4 msgid "Copy to clipboard" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR Open the translated copy of datatables.inc and confirm that the translated string appears. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106475|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25287] Add columns_settings support to API datatables wrapper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- Going to delay backporting this to 20.05.x until there is a resolution to bz25909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 --- Comment #5 from Kyle M Hall --- Created attachment 106833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106833&action=edit Bug 25961: Add hooks for plugins to inject variables to OPAC XSLT This patch adds the following plugin hooks: - opac_results_xslt_variables - opac_detail_xslt_variables This hooks will inject variables returned by the plugin in the form of a hashref, into the ones that are passed to the XSLT processing code. To test: 1. Apply the 'DO NOT PUSH' commit 2. Install the Kitchensink plugin 3. Restart all 4. Search biblios in the OPAC => SUCCESS: A text is injected in front of the biblio title 5. Enter the detail page of any of the results => SUCCESS: A text is injected in front of the biblio title 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Kyle M Hall changed: What|Removed |Added Attachment #10|0 |1 is obsolete|| Attachment #106667|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 106832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106832&action=edit Bug 25961: Sample usage of the OPAC XSLT variables hooks Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #34 from Nick Clemens --- This is rebuilt after Katrin's comment It no longer touches XSLT, only the templates. XSLT display is controlled by existing prefs, the new pref only controls whether record level info is shown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25964] Data loss possible when items are modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nick Clemens changed: What|Removed |Added Attachment #103548|0 |1 is obsolete|| --- Comment #33 from Nick Clemens --- Created attachment 106831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106831&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones This patchset adds a new syspref: BiblioItemtypeInfo If you set BiblioItemtypeInfo to Koha, you will see the Koha record level itemtype info. This info is also shown if item-level_itypes is set to biblio Display of icons are controlled by noItemTypeImages/OpacnoItemTypeImages Material type display is controlled by DisplayIconsXSLT/DisplayOPACIconsXSLT To test: 1 - Apply patch 2 - Update database 3 - Do an opac search and view results 4 - Switch pref to 'Koha' and refresh 5 - Note itemtypes appear 6 - Click in to a record details 7 - Note you see itemtype and icon 8 - Switch the pref 9 - Note you don't see record level itemtype and icon 10 - Repeat in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25951] Koha::Objects using the DBIx::Class relationships in Koha::Hold and Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Nicolas Legrand --- mhmm... I should add some tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] [19.11] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #11 from Kyle M Hall --- (In reply to Alex Arnaud from comment #10) > (In reply to Kyle M Hall from comment #9) > > > I think that would make a good bug report on its own. If no libraries are > > set as pickup locations, it makes sense to me to hide the holds tab > > altogether, or at the very least, disallow holds to be placed so long as > > there are no pickup locations. > > Why not just keep the "libraryNotPickupLocation" red message in this case ? > IMO that could be done more quickly. Because in that scenario, there are no libraries in the pulldown, so stating "this library is not a pickup location" doesn't really make sense. There is no library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106829|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 106830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106830&action=edit Bug 2: Add --exclude_indexes to koha-run-backups This patch adds a trivial switch so koha-run-backups can pass the --exclude_indexes option switch to koha-dump. This way if the sysadmin doesn't want to backup the Zebra indexes, it can be controlled by tweaking the cron definition. To test: 1. Apply this patch 2. Run: $ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha 3. Notice the size of the backups: $ ls -lh /var/spool/koha/kohadev 4. Try the new option switch: $ debian/scripts/koha-run-backups \ --exclude_indexes \ --days 2 --output /var/spool/koha 5. Repeat 3 => SUCCESS: Backups are smaller! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 106829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106829&action=edit Bug 2: Add --exclude_indexes to koha-run-backups This patch adds a trivial switch so koha-run-backups can pass the --exclude_indexes option switch to koha-dump. This way if the sysadmin doesn't want to backup the Zebra indexes, it can be controlled by tweaking the cron definition. To test: 1. Apply this patch 2. Run: $ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha 3. Notice the size of the backups: $ ls -lh /var/spool/koha/kohadev 4. Try the new option switch: $ debian/scripts/koha-run-backups \ --exclude_indexes \ --days 2 --output /var/spool/koha 5. Repeat 3 => SUCCESS: Backups are smaller! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #29 from Andrew Fuerste-Henry --- Realized I'd done some bad copy/paste on the test plan. Updated: 1- apply patch 2- updatedatabase, restart_all 3- verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on 4- verify WhenLostForgiveFine is set to "Forgive" 5- verify circ rules include fines 6- set Default lost item fee refund on return policy to "Refund lost item charge" 7- create 4 overdue checkouts that will incur fines 8- run fines.pl 9- confirm 4 items checked out with accruing fines 10- confirm all 4 items have a replacement price Item 1 11- mark the first item lost 12- verify that fine is gone and lost fee has been charged 13- check item in 14- verify that lost fee is gone and overdue charge has not returned Item 2 15- set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine" 16- mark second item lost 17- verify that fine is gone and lost fee has been charged 18- check item in 19- verify that lost fee is gone and a new overdue charge has been made Item 3 20- set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine" 21- mark third item lost 22- verify that fine is gone and lost fee has been charged 23- check item in 24- verify that lost fee is gone and the old overdue charge has been restored Item 4 25- set Default lost item fee refund on return policy to "Leave lost item charge" 26- mark fourth item lost 27- verify that fine is gone and lost fee has been charged 28- check item in 29- verify that lost fee remains and the overdue charge is still gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #28 from Andrew Fuerste-Henry --- Following the test plan above: When returning the item with the rule set to "Refund lost item charge and charge new overdue fine", no new fine was generated. Patron ended up with no lost fee or overdue charge for the second item, When returning the item with the rule set to "Refund lost item charge and restore overdue fine", I got this error: "Unknown error code LostItemFeeRestored at /kohadevbox/koha/circ/returns.pl line 544" Looks like the chunk of code in question relates to claims returned? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #34 from Emmi Takkinen ---
(In reply to David Nind from comment #33)
> Everything works as expected, however the tests fail! 8-(
>
> prove t/db_dependent/Koha/Quotes.t
> t/db_dependent/Koha/Quotes.t .. 1/13 Can't use string ("Koha::Quote") as a
> HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line
> 735.
> # Looks like your test exited with 255 just after 2.
> t/db_dependent/Koha/Quotes.t .. Dubious, test returned 255 (wstat 65280,
> 0xff00)
> Failed 11/13 subtests
Sorry, I was so focused on getting random quote work that testing changes I
made to get quote with id slipped my mind (and also actually checking if tests
still work). I'll provide patch with fix as soon as possible.
And thanks for new test plan!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25173] Create list of parameters to choose from via a query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25173 --- Comment #5 from Andrew Fuerste-Henry --- I filed bug 25971, suggesting the ability to just name a database field, the other day. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Martin Renvoize changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 --- Comment #3 from Martin Renvoize --- Remember to build the CSS from the SCSS file before testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 Martin Renvoize changed: What|Removed |Added Attachment #106827|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 106828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106828&action=edit Bug 25984: Add border highlight to anchor element Test Plan 1/ Search for an item 2/ Click through to the item 3/ Click the 'Browse shelf' button to expose the shelf browser 4/ Hit 'tab' on the keyboard to tab through the shelf browser 5/ Note each element is highlighted with a red border upon selection 6/ Ensure this is also the case for items where there is not cover image 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #33 from David Nind ---
Everything works as expected, however the tests fail! 8-(
prove t/db_dependent/Koha/Quotes.t
t/db_dependent/Koha/Quotes.t .. 1/13 Can't use string ("Koha::Quote") as a HASH
ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 735.
# Looks like your test exited with 255 just after 2.
t/db_dependent/Koha/Quotes.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 11/13 subtests
Test Summary Report
---
t/db_dependent/Koha/Quotes.t (Wstat: 65280 Tests: 2 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 13 tests but ran 2.
Files=1, Tests=2, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.63 cusr 0.16
csys = 1.82 CPU)
Result: FAIL
An updated test plan:
1. Apply the patch.
2. Run the database update (updatedatabase on koha-testing-docker).
3. Check that the 'QuoteOfTheDay' system preference options
work as expected:
- OPAC: QOTD only appears in the OAPC
- Staff interface: QOTD only appears in the staff interface
- Both (Select all): QOTD appears in the staff interface and OPAC
4. Run the tests and make sure they pass:
prove t/db_dependent/Koha/Quotes.t
5. Sign off!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 --- Comment #1 from Martin Renvoize --- Created attachment 106827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106827&action=edit Bug 25984: Add border highlight to anchor element -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 --- Comment #4 from Rudolf Byker --- Owen, did you read Bug #23425 ? This is the same as that, but for different pages. It boils down to this: When "MARC::Record::new_from_xml" fails (this happens e.g. when the XML file contains an incorrectly encoded character, or when a record containing such a character is imported from a Z39.50 server), it should be handled gracefully instead of crashing Koha, thereby allowing the user to fix the invalid data. So to reproduce: - Get a MarcXML file with at least one incorrectly encoded character. - Do something that causes that file to be sent to MARC::Record::new_from_xml In CS, this is known simply as "Robustness". This is also why many programming languages have the pattern of "checked exceptions", which forces you to either handle an error/exception or re-throw it to be handled elsewhere. I'm not a Perl programmer, so I'm not sure what the Perl equivalent of that would be. An alternative to error handling is to prevent the error from happening at all. Some text parsers allow you to replace incorrectly encoded characters by a predefined string, like "?", thereby silencing any encoding errors in the input. Whether this is acceptable, is a decision that depends on the use case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25984] New: Accessibility: Shelf browse lacks focus visibility when cover image is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984
Bug ID: 25984
Summary: Accessibility: Shelf browse lacks focus visibility
when cover image is missing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
Where items displayed on the ‘Book shelf’ do not include cover images, keyboard
focus is
not highlighted by a visible focus indicator. This means that some users may be
unable to
determine where their focus is on the page.
Solution:
Ensure that interactive page elements are highlighted by a visible focus
indicator when in
focus. This will enable keyboard only users to determine where their focus is
on the page
when navigating via keyboard commands. A visible focus indicator can be set
using CSS.
For example:
:focus :hover {
outline: 2px solid #f00;
}
Note: The colour used must meet 3:1 against the adjacent colours.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25983] Accessibility: 2.4.7 Focus Visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25983 Martin Renvoize changed: What|Removed |Added Depends on||25984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25984 [Bug 25984] Accessibility: Shelf browse lacks focus visibility when cover image is missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
