[Koha-bugs] [Bug 26168] New: Create admin Linux user "koha" which is member of all *-koha instance groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26168 Bug ID: 26168 Summary: Create admin Linux user "koha" which is member of all *-koha instance groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org It would be useful to have an administrative Linux user "koha" which is a member of all *-koha instance groups. The high level use case is a non-root (daemon) service that can run "koha-shell kohadev -c 'command'". At the moment, you could just run that (daemon) service as root, but ideally it would be better to run it as a less privileged user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #31 from Aleisha Amohia --- enhancement changing too much behaviour, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #9 from Aleisha Amohia --- enhancement, not backported to 19.11.x (even though I agree, it is a handy one) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is HTML not XML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21268] Can't add to basket from staged file if base-level allocated is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #13 from Aleisha Amohia --- I cannot recreate the bug in 19.11.x, all funds show in the fund list. Not backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25499] Fund code column is empty when closing a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 --- Comment #12 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Nick Clemens changed: What|Removed |Added Attachment #107371|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 107938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107938=edit Bug 25853: Fix file permissions for update_patrons_category script The permissions for this were -rw-r--r-- and need to be -rwxr-xr-x. To test: - Verify the file permissions before and after applying the patch. Signed-off-by: Didier Gautheron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25919] Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Works as described. One question: even after this I can access the page and define desks if the syspref is disabled - should we block this too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25919] Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens changed: What|Removed |Added Attachment #107433|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 107937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107937=edit Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25919] Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #537 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #528) > Some work should be done according to QA tools: Believe these are all fixed. Ready to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24591] Add developer script to preview a letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24591] Add developer script to preview a letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591
Nick Clemens changed:
What|Removed |Added
Attachment #101390|0 |1
is obsolete||
--- Comment #8 from Nick Clemens ---
Created attachment 107935
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107935=edit
Bug 24591: Add developer script to preview a letter
The script is very simple, it just calls GetPreparedLetter with
arguments given on command line and print the resulting letter content
Usage example:
misc/devel/get-prepared-letter.pl --module circulation \
--letter_code ODUE --tables '{"borrowers":1,"branches":"CPL"}' \
--repeat '{"item":[{"biblio":1,"items":1}]}' \
--loops '{"overdues":[1]}'
Signed-off-by: Bernardo Gonzalez Kriegel
Works for the example and other cases.
Correct option is 'letter-code', with dash, not underscore.
An usage message would be nice.
No errors
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24591] Add developer script to preview a letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Nick Clemens changed: What|Removed |Added Attachment #102685|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 107936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107936=edit Bug 24591: Add --help option to misc/devel/get-prepared-letter.pl Also fix code style with perltidy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #12 from Nick Clemens --- (In reply to Martin Renvoize from comment #9) > This now works as described so I'm signing off.. > > However, I wonder if it might be nicer reverse the logic and redirect back > to the search results by default instead of redirected to advanced search > and displaying a button to get to the prior results... I agree, it sent me down a path of adding this in other places, but I think we should file a new bug. If my follow-up looks good I am of the mindset to call this one a good enhancement after 10 years of waiting, and to do further enhancements on the next one. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 --- Comment #11 from Nick Clemens --- Created attachment 107934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107934=edit Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Nick Clemens changed: What|Removed |Added Attachment #107868|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 107933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107933=edit Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- This works as described. I have a question: for homebrnahcname and holdingbranchname we include the key whether or not we have a value - here the description tags are not included if the itype of location don't match an existing value - is there a reason for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Nick Clemens changed: What|Removed |Added Attachment #107087|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 107932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107932=edit Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http:///cgi-bin/koha/ilsdi.pl?service=GetRecords= 3. Check that there is and and that their value is correct. Signed-off-by: Arthur Suzuki Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Could you elaborate more on the rationale for this change? I don't understand it at all. Also, the change to koha-plack has the same problem as Bug 25778. The PERL5LIB will grow and grow each time you restart that starman instance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #56 from Nick Clemens --- Created attachment 107930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107930=edit Bug 19889: Add feedback when exclusion is updated on moredetail.pl Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26166] Patron verification through SMS one time code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26166 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I don't know about that first use case, although I suppose it's not that different to authenticating someone by scanning a card (ie something they *have* rather than something they *know*). That could be an interesting Koha Plugin. I like the second use case better. Using it to validate setting up SMS messaging, or being used as a 2nd factor for authentication (ie something they *have* PLUS something the password that they *know*). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #10 from Owen Leonard --- (In reply to Josef Moravec from comment #9) > So it need probably more refactoring... This patch was what prompted me to start the conversation on koha-devel about consolidating the staff interface header search forms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #55 from Nick Clemens --- Created attachment 107929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107929=edit Bug 19889: Make it possible to exclude items and categories from local holds priority This patch adds the ability to exclude patrons (by category) from local holds, and items, by editing the item itself or by batch item modification tool. To test: 1. apply patches 2. updatedatabase 3. Enable LocalHoldsPriority preference, and leave LocalHoldsPriorityPatronControl in pickup library, and LocalHoldsPriorityItemControl in holding library. 4. Search for a biblio with one item. 5. Place a hold with a patron (patron1) and set pickup location to a different library of the item's home library 6. Place another hold with another patron (patron2) and set pickup location to be the same as the item's home library 7. ./misc/cronjobs/holds/build_holds_queue.pl 8. Go to circulation -> holds queue 9. Search by the item's home library CHECK => only the hold for patron2 (with the pickup location the same as the item's home library) appears in the table 10. Go back to the biblio details page and click on "Items" tab CHECK => There is a new section in the item's details between "Statuses" and "History" called "Priority" 11. Set exclude to "Yes" and update 12. repeat steps 7 to 9 SUCCESS => only the hold for patron1 now appears, even the other hold had local hold priority 13. Repeat step 10 and 11 but this time set exclude to "No" 14. repeat steps 7 to 9 CHECK => the hold for patron2 is back 15. Edit patron2's category and set exclude from local holds priority to "Yes" 16. Repeat steps 7 to 9 SUCCESS => the hold for patron1 is back 17. Go to tools -> Batch item modification and in barcode list place several (existing) barcodes and press continue CHECK => There is a new section in the bottom called "Priority" 18. Set exclude to "Yes" and save SUCCESS => all items in the list now have exclude setted to "Yes" 19. Try to checkout the first item to a patron3 SUCCESS => Alert message appears saying that patron1 has a hold on that item 20. Click on Yes and then checkin that item SUCCESS => There is a modal window saying that a hold was found for patron1 21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t 22. Sign off Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #57 from Nick Clemens --- Created attachment 107931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107931=edit Bug 19889: (follow-up) Fix overlapping blue box and message in batch item modification Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Nick Clemens changed: What|Removed |Added Attachment #107908|0 |1 is obsolete|| Attachment #107909|0 |1 is obsolete|| Attachment #107910|0 |1 is obsolete|| Attachment #107911|0 |1 is obsolete|| Attachment #107912|0 |1 is obsolete|| Attachment #107913|0 |1 is obsolete|| --- Comment #52 from Nick Clemens --- Created attachment 107926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107926=edit Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems and categories tables Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #53 from Nick Clemens --- Created attachment 107927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107927=edit Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #54 from Nick Clemens --- Created attachment 107928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107928=edit Bug 19889: Add tests Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Myka Kennedy Stephens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #61 from Myka Kennedy Stephens --- *** Bug 20283 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26156] Record matching rule code should be unique
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26156 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > I am not sure if I see the need as the table has a primary key that is > unique and that key is used for example when you use the matching rules with > the command line scripts. > The primary key isn't very friendly though. I've done some work with matching rules (before discarding it), and working with the codes is much nicer. It's also possible that you could delete your record matching rule and re-create it, and then your old primary key is gone, but your code could still be the same. > We don't keep people from naming other things the same - it seems if they > do, that's not ideal, but doesn't necessarily need a code solution. Well, this would be a database schema change rather than a code solution per se. It would just be making a unique key for the code column. (The code solution would just be necessary at update time before creating the unique key to prevent fatal database errors.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20283] Editing a course item for an inactive course affects the item fields directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20283 Myka Kennedy Stephens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Myka Kennedy Stephens --- I'm not having trouble with this anymore and think it was resolved by bug 24772 and bug 23727. I cannot recreate the original issue. Marking as resolved for now. Please feel free to reopen if I'm wrong and it's still a bug. *** This bug has been marked as a duplicate of bug 23727 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #10 from David Cook --- Ahhh yes I assume that must be what this is about? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#Fixing_common_warnings If the browser is showing this warning for Koha, then we should look at that particular cookie and its usage. Otherwise, I don't argue that no changes are necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #9 from David Cook --- I notice some console errors saying "A cookie associated with a cross-site resource at http://youtube.com/ was set without the `SameSite` attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set... with `SameSite=None` and `Secure`." Is *this* the warning mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019#c0? If so, I think we can safely ignore it, except in cases where we're doing Cross-Origin Resource Sharing (CORS) requests, but I don't see why we'd be passing a cookie with a CORS request (unless you were doing a CORS request to the API with a cookie but that seems problematic and unnecessary since you can use OAuth2 or Basic Auth for the API). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #8 from David Cook --- I've actually been looking for cookies on sites I use, and for the most part I don't see any actually setting SameSite. (Of course, many of the sites are using ServiceWorker, and at a glance it's not obvious what it's doing in the background.) One exception is a load balancer stickness CORS cookie, AWSALBCORS, which has "SameSite=None". (More info available at https://forums.aws.amazon.com/ann.jspa?annID=7413) Noticing a "SameSite=None" cookie for www.google.com which is a tracking/targeting/advertising cookie. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107814|0 |1 is obsolete|| --- Comment #536 from Aleisha Amohia --- Created attachment 107925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107925=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107811|0 |1 is obsolete|| --- Comment #533 from Aleisha Amohia --- Created attachment 107922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107922=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107812|0 |1 is obsolete|| --- Comment #534 from Aleisha Amohia --- Created attachment 107923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107923=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107810|0 |1 is obsolete|| --- Comment #532 from Aleisha Amohia --- Created attachment 107921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107921=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107813|0 |1 is obsolete|| --- Comment #535 from Aleisha Amohia --- Created attachment 107924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107924=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107808|0 |1 is obsolete|| --- Comment #530 from Aleisha Amohia --- Created attachment 107919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107919=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107809|0 |1 is obsolete|| --- Comment #531 from Aleisha Amohia --- Created attachment 107920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107920=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107807|0 |1 is obsolete|| --- Comment #529 from Aleisha Amohia --- Created attachment 107918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107918=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #7 from David Cook --- So I'd argue it's not just a case of people creating a security risk by using SameSite=None, but also a case of people breaking things by using SameSite=Strict, which really just leaves SameSite=Lax, which is why that's the default in browsers I imagine. SameSite=Lax is a sane default. SameSite=None has no obvious use to me for Koha. SameSite=Strict... maybe but probably not. The exception being if we re-routed people through a login page for new navigations, even when authenticated. If someone clicked a link in their email for http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test, and they already had a valid Koha session for localhost:8081, we could bounce them through http://localhost:8081/cgi-bin/koha/mainpage.pl, which would then allow you to use SameSite=Strict. But I doubt we're going to change how we handle authentication and navigation just to use SameSite=Strict. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #6 from David Cook --- But what's the use case for a Koha staff user changing the SameSite value for a cookie? Due to deep linking (e.g. linking to a search result page and visiting it as an authenticated user), I can't think of a case off the top of my head that shoulnd't be SameSite=Lax. With SameSite=None, we'd be letting any site send that cookie. I can't see any reason to do that. We wouldn't be creating tracking cookies, and I don't know why we'd let another site send a cookie to Koha via a background call. SameSite=Strict sounds good in theory for internal cookie usage, but - due to that deep linking I mentioned - every cookie I can think of should be sendable when externally navigating to the site. That said, I'd be willing to test this theory to try to prove it wrong. I have a feeling that using SameSite=Strict would break a lot of Koha functionality when navigating directly to a page (like search results), but I'm happy to be proven wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872
--- Comment #1 from Barbara Johnson ---
We're using some dropdown lists of search options based on shelving location
codes that patrons can use to easily get to new items.
Just Arrived
-- Please choose --
New Fiction
New Mystery
New YA Fiction
We also use some jQuery for an item type limiter that can be used when
searching.
//BEGIN Add Search Limits to Main Search Box opac-main.pl
$(".mastheadsearch #masthead_search").after(" All ItemsBooksDVDs (Movies &
TV)DVDs
(Non-Fiction)");
Because the code doesn't have search terms in it the list of results can't be
sorted. We could change everything to use direct urls but that takes a lot of
time. Being able to use locations and item types in the code is easier and
cleaner.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #30 from Lucas Gass --- If you work with the HTML system prefs a lot, which are moving into the News tool, this enhancement could be pretty important. Choosing to backport to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- Handy and small enhancement, choosing to backport to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #53 from Lucas Gass --- skipping enhancement for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26060] Replace staff interface table sort icons with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26060 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Skipping enchancement for 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is HTML not XML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- This enhancement improves translatability so I am choosing to backport this to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21268] Can't add to basket from staged file if base-level allocated is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25499] Fund code column is empty when closing a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26167] New: Display information when a member or item is excluded from local holds priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26167 Bug ID: 26167 Summary: Display information when a member or item is excluded from local holds priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: agustinmoy...@theke.io Reporter: agustinmoy...@theke.io QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 19889 As Nick Clemens explained in this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889#c45 > I think we must display on moremember.pl and detail.pl the info on when a > patron/item is excluded, otherwise these changes may not be visible to > staff who cannot edit items/patrons/categories and they will not understand > what is happening to the holds So this means we should add info to displayed patron category in members/moremember.pl and in item's table in catalogue/detail.pl if category/item is excluded. Alternatively we can also add info to existing holds table in /reserve/request.pl for patron and item exclusions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 [Bug 19889] LocalHoldsPriority needs exclusions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Blocks||26167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26167 [Bug 26167] Display information when a member or item is excluded from local holds priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #9 from Josef Moravec --- So it need probably more refactoring... whole form with id "cat-search-block" could be in its own template? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954
--- Comment #8 from Josef Moravec ---
Comment on attachment 107915
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107915
Bug 25954: (Follow-up) Correct label "for" attribute
Review of attachment 107915:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=25954=107915)
-
Sorry being so pedantive...
::: koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc
@@ +27,4 @@
>
> id="cat-search-block">
> [% IF ( Koha.Preference('IntranetCatalogSearchPulldown') ) %]
> +Enter search
> keywords:
The label could be before IF and you do not need the ELSE branch then...
also there are some more occurences, see:
git grep 'for="idx"'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26166] New: Patron verification through SMS one time code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26166 Bug ID: 26166 Summary: Patron verification through SMS one time code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Often we have a patron that will call to do something with their account and cannot because they don't have their card on them or they have lost their card. It would be FANTASTIC if there was a button on the account, for those that have SMS messaging setup, to send them a one-time code that they could read back to us to verify that it is them. I could also see this as a validation process for setting up SMS messaging on the patron (OPAC) side. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26009] Elasticsearch homebranch and holdingbranch facets are limited to 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26009 Josef Moravec changed: What|Removed |Added QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26009] Elasticsearch homebranch and holdingbranch facets are limited to 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26009 Josef Moravec changed: What|Removed |Added Attachment #107717|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 107916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107916=edit Bug 26009: Add facet size to home/holdingbranch To test: 0 - Set DisplayLibraryFacets to 'both' and FacetMaxCount to 20 1 - Have more than 10 branches 2 - Have items in each of those branches 3 - Enable ES, set system preference SearchEngine to Elasticsearch 4 - Search for '*' 5 - Expand homebranch/holdingbranch facets 6 - Note you only get 10 7 - Apply patch 8 - Repeat search 9 - Now you get all your facets Signed-off-by: Michael Springer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26009] Elasticsearch homebranch and holdingbranch facets are limited to 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26009 --- Comment #4 from Josef Moravec --- Created attachment 107917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107917=edit Bug 26009: (QA follow-up) It does not harm to test more Test plan: prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t --> should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #7 from Owen Leonard --- Created attachment 107915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107915=edit Bug 25954: (Follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23632] Remove C4::Logs::GetLogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23632 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23632] Remove C4::Logs::GetLogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23632 Josef Moravec changed: What|Removed |Added Attachment #107871|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 107914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107914=edit Bug 23632: Remove C4::Logs::GetLogs Koha::ActionLogs->search must be used instead. There is no call to this subroutine in our code, it should be removed. Test plan: Make sure the 3 test files still return green and that there is no more occurrences of GetLogs in the codebase. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Attachment #107196|0 |1 is obsolete|| --- Comment #50 from Agustín Moyano --- Created attachment 107912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107912=edit Bug 19889: Add feedback when exclusion is updated on moredetail.pl Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Attachment #107195|0 |1 is obsolete|| --- Comment #49 from Agustín Moyano --- Created attachment 107911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107911=edit Bug 19889: Make it possible to exclude items and categories from local holds priority This patch adds the ability to exclude patrons (by category) from local holds, and items, by editing the item itself or by batch item modification tool. To test: 1. apply patches 2. updatedatabase 3. Enable LocalHoldsPriority preference, and leave LocalHoldsPriorityPatronControl in pickup library, and LocalHoldsPriorityItemControl in holding library. 4. Search for a biblio with one item. 5. Place a hold with a patron (patron1) and set pickup location to a different library of the item's home library 6. Place another hold with another patron (patron2) and set pickup location to be the same as the item's home library 7. ./misc/cronjobs/holds/build_holds_queue.pl 8. Go to circulation -> holds queue 9. Search by the item's home library CHECK => only the hold for patron2 (with the pickup location the same as the item's home library) appears in the table 10. Go back to the biblio details page and click on "Items" tab CHECK => There is a new section in the item's details between "Statuses" and "History" called "Priority" 11. Set exclude to "Yes" and update 12. repeat steps 7 to 9 SUCCESS => only the hold for patron1 now appears, even the other hold had local hold priority 13. Repeat step 10 and 11 but this time set exclude to "No" 14. repeat steps 7 to 9 CHECK => the hold for patron2 is back 15. Edit patron2's category and set exclude from local holds priority to "Yes" 16. Repeat steps 7 to 9 SUCCESS => the hold for patron1 is back 17. Go to tools -> Batch item modification and in barcode list place several (existing) barcodes and press continue CHECK => There is a new section in the bottom called "Priority" 18. Set exclude to "Yes" and save SUCCESS => all items in the list now have exclude setted to "Yes" 19. Try to checkout the first item to a patron3 SUCCESS => Alert message appears saying that patron1 has a hold on that item 20. Click on Yes and then checkin that item SUCCESS => There is a modal window saying that a hold was found for patron1 21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t 22. Sign off Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #51 from Agustín Moyano --- Created attachment 107913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107913=edit Bug 19889: (follow-up) Fix overlapping blue box and message in batch item modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Attachment #107194|0 |1 is obsolete|| --- Comment #48 from Agustín Moyano --- Created attachment 107910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107910=edit Bug 19889: Add tests Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Attachment #107193|0 |1 is obsolete|| --- Comment #47 from Agustín Moyano --- Created attachment 107909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107909=edit Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What|Removed |Added Attachment #107192|0 |1 is obsolete|| --- Comment #46 from Agustín Moyano --- Created attachment 107908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107908=edit Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems and categories tables Sponsored-by: Cooperative Information Network (CIN) Signed-off-by: Christopher Brannon Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #13 from Owen Leonard --- (In reply to Martin Renvoize from comment #12) > * The search bar doesn't react properly when shrinking and growing the > window width however. This has been fixed in the remote branch. > * I'm not sure about the increase in whitespace and sizes... I'm happy to reevaluate this if others are bothered by it. I think it might be a difference in Bootstrap defaults. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136
Josef Moravec changed:
What|Removed |Added
Attachment #107784|0 |1
is obsolete||
--- Comment #3 from Josef Moravec ---
Created attachment 107907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107907=edit
Bug 26136: Prevent double submit on checkin-form
To test:
1 - Browse to Circulation->Check-in
2 - Type a barcode into the Check in box
3 - Hit Enter as many as times as you can
4 - Check the statistics table:
SELECT * FROM statistics WHERE itemnumber={itemnumber} AND
DATE(datetime)=CURDATE();
5 - Note you have multiple lines for the same item at the same time
6 - Apply patch
7 - Reload the page
8 - Type the barcode
9 - Press Enter even more fast and more furiously
10 - Check the statistics table
11 - Only one entry, huzzah!
Signed-off-by: Sally
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Josef Moravec changed: What|Removed |Added Attachment #107896|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744 --- Comment #4 from Lucas Gass --- This patch modifies the following files: replaced with in these file: includes/borrower_debarments.inc includes/holds_table.inc includes/patron-article-requests.inc includes/permissions.inc modules/acqui/lateorders.tt modules/acqui/newordersuggestion.tt modules/acqui/parcel.tt modules/admin/aqbudgetperiods.tt modules/admin/aqcontract.tt modules/admin/auth_subfields_structure.tt modules/admin/categories.tt modules/admin/marc_subfields_structure.tt modules/admin/preferences/cataloguing.pref modules/admin/preferences/searching.pref modules/catalogue/MARCdetail.tt modules/catalogue/detail.tt modules/catalogue/imageviewer.tt modules/catalogue/issuehistory.tt modules/catalogue/labeledMARCdetail.tt modules/catalogue/moredetail.tt modules/catalogue/stockrotation.tt modules/cataloguing/addbooks.tt modules/cataloguing/linkitem.tt modules/cataloguing/moveitem.tt modules/circ/circulation.tt modules/circ/pendingreserves.tt modules/clubs/club-enrollments.tt modules/clubs/clubs-add-modify.tt modules/clubs/clubs.tt modules/clubs/patron-enroll.tt modules/clubs/templates-add-modify.tt modules/course_reserves/add_items-step1.tt modules/course_reserves/add_items-step2.tt modules/course_reserves/batch_add_items.tt modules/course_reserves/course-details.tt modules/course_reserves/course.tt modules/members/memberentrygen.tt modules/members/moremember.tt modules/plugins/plugins-home.tt modules/reserve/request.tt modules/rotating_collections/addItems.tt modules/rotating_collections/editCollections.tt modules/rotating_collections/transferCollection.tt modules/serials/routing-preview.tt modules/serials/routing.tt modules/serials/serials-collection.tt modules/serials/serials-edit.tt modules/serials/subscription-add.tt modules/serials/subscription-detail.tt modules/serials/viewalerts.tt modules/suggestion/suggestion.tt modules/tags/list.tt modules/tools/marc_modification_templates.tt modules/virtualshelves/shelves.tt Replaced with in these files: includes/budgets-active-currency.inc includes/cateditor-ui.inc includes/checkouts-table.inc includes/holds_table.inc includes/waiting_holds.inc modules/about.tt modules/acqui/invoice-files.tt modules/acqui/lateorders.tt modules/acqui/neworderempty.tt modules/acqui/orderreceive.tt modules/admin/aqplan.tt modules/admin/auth_tag_structure.tt modules/admin/checkmarc.tt modules/admin/itemtypes.tt modules/admin/preferences/i18n_l10n.pref modules/authorities/detail.tt modules/authorities/searchresultlist-auth.tt modules/basket/basket.tt modules/catalogue/MARCdetail.tt modules/catalogue/issuehistory.tt modules/catalogue/labeledMARCdetail.tt modules/cataloguing/addbooks.tt modules/cataloguing/value_builder/unimarc_field_210c.tt modules/circ/branchoverdues.tt modules/circ/branchtransfers.tt modules/circ/circulation.tt modules/circ/pendingreserves.tt modules/circ/reserveratios.tt modules/circ/returns.tt modules/circ/transferstoreceive.tt modules/ill/log/status_change.tt modules/labels/result.tt modules/members/paycollect.tt modules/onboarding/onboardingstep1.tt modules/onboarding/onboardingstep2.tt modules/onboarding/onboardingstep3.tt modules/plugins/plugins-upload.tt modules/pos/pay.tt modules/reports/acquisitions_stats.tt modules/reports/guided_reports_start.tt modules/reviews/reviewswaiting.tt modules/serials/checkexpiration.tt modules/serials/result.tt modules/serials/routing-preview-slip.tt modules/suggestion/suggestion.tt modules/tools/export.tt modules/tools/holidays.tt modules/tools/import_borrowers.tt modules/tools/letter.tt modules/tools/manage-marc-import.tt modules/tools/picture-upload.tt modules/tools/problem-reports.tt modules/tools/quotes.tt modules/tools/upload-images.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744 --- Comment #3 from Lucas Gass --- Created attachment 107906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107906=edit Bug 25744: replace with in the staff interface This patch set attempts to replace all the tags with and all the tags with in the staff interface. I attempted to get all the templates, includes, and xslt files. To test: 1. Review the changes as best as possible, looking for mistakes. 2. grep for and in the modules, includes, and xslt folders. You should get nothing/ 3. If you grep '<\/i>' you should only see instances of Font Awesome. 4. If you grep '<\/b>' you should only see instances where caret is used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 --- Comment #6 from Nick Clemens --- Created attachment 107905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107905=edit Bug 25606: (QA follow-up) Don't show remove all button if no reserves Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 Nick Clemens changed: What|Removed |Added Attachment #105494|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 107904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107904=edit Bug 25606: Remove all reserve items button Adds button to course records to remove all attached reserve items. A warning dialog box will appear before executed. Test plan 1. Install patch 2. Log in as user with permission to delete reserves 3. View a course reserve record with multiple items attached 4. There should now be a button that says "- Batch remove reserves" 5. When you click the button a dialog box should appear with a warning 6. Click "Ok" 7. All course reserves should be removed from the record 8. Add an item to more than course record 9. Redo 3-7 10. Items should have been removed from that course but remain on all other courses 11. Log in as a user without delete reserves permission 12. You should not see the batch remove option Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #105360|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #32 from Nick Clemens --- Hi Aleisha, The comment on the syspref says jobs will be run hourly - probably should say something like: NOTE: This system preference requires the misc/cronjobs/holds/ cronjobs. Ask your system administrator to schedule them. When confirming a hold the max pickup delay is added for days correctly, however, the time part is set to 00:00:00 - I thin it should be preserved from original setting or set to 23:59:59 t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use 23:59:59 if time not specified? I am not sure how it is handled for checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744 --- Comment #2 from Lucas Gass --- Created attachment 107903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107903=edit Bug 25744: Replace with in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24910] Make it possible to choose see also-authorities in authority finder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24910 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #1 from Heather --- If we're talking about the linking function within editing a bib record, how about something like a pull-down menu similar to what we have in other areas, e.g., you activate the authority linking function (i.e., by keying ctrl-shift-L in the advanced bib editor), it executes the search, and next to each term is a button labeled "Actions" and when you select that button, it turns into a menu (similar to when importing a record via Z39.50, or when searching the Aut file in the staff client) with actions like: Choose View Edit And if you choose "View" of that heading, a window pops up that could have the 4XX & 5XX terms hyperlinked to execute a new search within this aut finder/linker. Is that something like what you're envisioning? Cheerio! h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 --- Comment #12 from Lucas Gass --- attached to wrong bug, sorry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
