[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #102 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24591] Add developer script to preview a letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24591 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- small and very. useful enhancement, choosing to backport backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25336] Show checkouts/fines to guarantor is in the wrong section of the patron file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25336 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 --- Comment #8 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25919] Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26009] Elasticsearch homebranch and holdingbranch facets are limited to 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26009 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26158] Z3950 search button broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26158 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #27 from Lucas Gass --- many parts of this do not apply clean to 20.05.x, no backport If needed please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26125] In 'Patron search' tab link should lead to patron details instead of checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26125 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26017] Cashup registers never shows on tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26017 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #124 from Michal Denar --- Hi Bouzid, good work, it works for me. SO again after rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar changed: What|Removed |Added Attachment #108309|0 |1 is obsolete|| --- Comment #123 from Michal Denar --- Created attachment 108310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108310=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #122 from Bouzid Fergani --- Hi all, - I have finished resolving the issues that Nick raised. - Now, when we create a new record, all the open windows close correctly and the links are done automatically, I even added the deletion of the authorities creation link in case the link is made correctly. - Move AddAuthorityFromHeading to C4/AuthoritiesMarc.pm - Delete GetRecordValue - Restore default linker behavior - Deleting param biblioindex and using index - Make the Link authorities automatically button invisible if the user does not have editauthorities permission I believe I have resolved all the issues raised, hoping they will be accepted. This feature is very late and its maintenance is becoming more and more complex. Thanks in advance to those who will pay attention to this feature and allow it to move forward. Bouzid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What|Removed |Added Attachment #108091|0 |1 is obsolete|| --- Comment #121 from Bouzid Fergani --- Created attachment 108309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108309=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #2 from Amit Gupta --- Created attachment 108308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108308=edit Screenshot2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta changed: What|Removed |Added Assignee|oleon...@myacpl.org |amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #1 from Amit Gupta --- Created attachment 108307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108307=edit Screenshot1 When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] New: When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Bug ID: 26218 Summary: When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: amitddng...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26217 [Bug 26217] Move translatable strings out of templates into acq.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26217] New: Move translatable strings out of templates into acq.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26217 Bug ID: 26217 Summary: Move translatable strings out of templates into acq.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr, testo...@bugs.koha-community.org Depends on: 21156 Strings defined for translation in templates as global variables and used in acq.js can now be wrapped in the new translation function and put in acq.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #9 from Amit Gupta --- I have checked and calendar have some issues. While doing the registration from OPAC if we will give any invalid date it is not giving any alert or error message. It's simply saving the record. I will raise a bug to fix the calendar issue on the OPAC side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26216] Remove the use of jquery.checkboxes plugin from catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26216 --- Comment #1 from Owen Leonard --- Created attachment 108306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108306=edit Bug 26216: Remove the use of jquery.checkboxes plugin from catalog search results This patch removes the use of jquery.checkboxes plugin from the staff interface catalog search results page. To test, apply the patch and perform a catalog search in the staff interface which will return results. On the search results page test the "Select all" and "Clear all" links at the top of the results. They should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26216] Remove the use of jquery.checkboxes plugin from catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26216 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25553] Edit item date sort does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25553 --- Comment #14 from Lucas Gass --- This still seems to sort wrong. I have some data like this: MariaDB [koha_kohadev]> select itemnumber, dateaccessioned from items where biblionumber = '4'; ++-+ | itemnumber | dateaccessioned | ++-+ | 12 | 2015-01-28 | | 13 | 2015-04-08 | | 14 | 2013-04-08 | | 18 | 2015-11-28 | ++-+ You can see that the dateaccessioned is still not sorting right (ASC or DESC): https://snipboard.io/gtScJK.jpg https://snipboard.io/z7Av8O.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24884] Remove 'New list' button in 'Public lists' tab if OpacAllowPublicListCreation is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24884 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #1 from rkui...@roundrocktexas.gov --- Agree. This is confusing to the patron. Rhonda K. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26216] New: Remove the use of jquery.checkboxes plugin from catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26216 Bug ID: 26216 Summary: Remove the use of jquery.checkboxes plugin from catalog search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the staff interface catalog search results page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26216 [Bug 26216] Remove the use of jquery.checkboxes plugin from catalog search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #8 from Amit Gupta --- (In reply to Owen Leonard from comment #7) > I'm getting some errors from this. If I have the patron category field > exposed in the patron self-registration form I get this error when > submitting the form with an invalid date of birth: > > Can't call method "param" on an undefined value at > /kohadevbox/koha/opac/opac-memberentry.pl line 485 > > If I hide the patron category field and submit the form with a valid or > invalid date of birth I get this error: > > Can't call method "dateofbirthrequired" on an undefined value at > /kohadevbox/koha/opac/opac-memberentry.pl line 482 Thank Owen for giving the feedback. I am able to reproduce the second issue. But with first one I am able to save the form and not find any issue. In case if I am giving the invalid date of birth (In reply to Owen Leonard from comment #7) > I'm getting some errors from this. If I have the patron category field > exposed in the patron self-registration form I get this error when > submitting the form with an invalid date of birth: > > Can't call method "param" on an undefined value at > /kohadevbox/koha/opac/opac-memberentry.pl line 485 > > If I hide the patron category field and submit the form with a valid or > invalid date of birth I get this error: > > Can't call method "dateofbirthrequired" on an undefined value at > /kohadevbox/koha/opac/opac-memberentry.pl line 482 Thank Owen for giving the feedback. I am able to reproduce the second issue. But with first one I am able to save the form and not find any issue. In case if I am giving the invalid date of birth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 --- Comment #9 from Katrin Fischer --- Together with bug 25630 that should cover the cases pointed out by Joubu and some more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 --- Comment #8 from Katrin Fischer --- Created attachment 108305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108305=edit Bug 26015: Terminology: Fix tons more staff clients to staff interfaces This takes care of more occurences of staff client and changes it to staff interface, including in code comments. To test: - I think in this case careful code review is what we look for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 Katrin Fischer changed: What|Removed |Added Attachment #107643|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 108304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108304=edit Bug 26015: Terminology: Use staff interface instead of staff client We have agreed to use 'staff interface' instead of 'staff client' and similar terms. This fixes the template files where staff client appears: To test: - Check Administration > Patron categories - Check the title of the staff interface start page in your browser tab - Check the description of hte catalogue permission - One more: this changes the message shown when someone managed to log in as the database user - as we no longer allow that, I am not sure if it can be triggered. Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- I'm getting some errors from this. If I have the patron category field exposed in the patron self-registration form I get this error when submitting the form with an invalid date of birth: Can't call method "param" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 485 If I hide the patron category field and submit the form with a valid or invalid date of birth I get this error: Can't call method "dateofbirthrequired" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 482 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #6 from Katrin Fischer --- The QA scripts complain if the commit message doesn't start with Bug : - that was what I meant, but I was not clear about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta changed: What|Removed |Added Attachment #108283|0 |1 is obsolete|| --- Comment #5 from Amit Gupta --- Created attachment 108303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108303=edit Bug 26211 - Patron age verification while doing the self-registration. Modify Commit message -> "Patron age versification while doing the self-registration" To Test 1. Create the patron category from the staff page for ex: Kid and give age required and age Upperage limit age required 5 yrs and upperage limit 17. 2. Allow category in PatronSelfRegistrationDefaultCategory for online registration from opac. 3. Go to /cgi-bin/koha/opac-memberentry.pl page. 4. Fill the form and give choose date of birth 10/10/1974 and click OK. Now you can able to save the page. 5. Apply the patch. 6. Again go to cgi-bin/koha/opac-memberentry.pl page. 7. Fill the form and give choose date of birth 10/10/1974 and click OK. It will give the error message. Patron's age is incorrect for their category. Ages allowed are 5-17. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #4 from Amit Gupta --- (In reply to Katrin Fischer from comment #2) > Looks good on first glance! Commit message needs a little fix - > Bug 26211: Patron ... I think below message looks OK. "Patron age verification while doing the self-registration" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age verification while doing the self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta changed: What|Removed |Added Summary|Patron age checking while |Patron age verification |doing the membership|while doing the |registration through OPAC |self-registration --- Comment #3 from Amit Gupta --- (In reply to Katrin Fischer from comment #2) > Looks good on first glance! Commit message needs a little fix - > Bug 26211: Patron ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #83 from Martin Renvoize --- I think I should rebase this upon bug 18501.. that bug does some nice refactoring which we should utilise. I will try to get to that early next week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18501 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25663 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26210] issue_id should be consistently set for Lost item handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26210 --- Comment #2 from Martin Renvoize --- Created attachment 108302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108302=edit Bug 26210: Allow issue_id to be passed to add_credit This patch add the ability for Koha::Account->add_credit to accept an issue_id parameter and record it to the accountlines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #39 from Martin Renvoize --- Created attachment 108301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108301=edit Bug 18501: (QA follow-up) Fix regressions highlighted by unit tests The migration of unit tests in the preceeding patch highlighted a few regressions which are dealt with here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #40 from Martin Renvoize --- Right.. we probably need to squash some of the middle patches.. but I think we're now well covered by the tests and they highlighted some issue with the approach which I have since corrected in the final follow-up. This feels like a pretty elegant solution at this point :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #38 from Martin Renvoize --- Created attachment 108300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108300=edit Bug 18501: (QA follow-up) Migrate and update unit tests This patch moves the _FixAccountForLostAndFound tests from Circulation.t to Koha/Items.t and updates then to call an item store as aposed to the now removed _FixAccountForLostAndFound method. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #37 from Martin Renvoize --- Created attachment 108299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108299=edit Bug 18501: (QA follow-up) Remove FIXME + Track issue_id We correct some compilation errors here by updating the transfered _FixAccountForLostAndFound method to use $self references. We add issue_id tracking so that future reports can clearly see how a refund relates to the original charge and finally we remove a FIXME as I agree that the 'discard_changes' call is not required. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108248|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 108297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108297=edit Bug 18501: set the is_refunded flag as internal var After discussion with Martin we decided that it could be the correct way Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108249|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 108298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108298=edit Bug 18501: Adjust condition for flagging an item found Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108243|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 108296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108296=edit Bug 18501: wip - need to know it has been refunded Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108194|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 108294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108294=edit Bug 18501: Add _set_found_trigger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108195|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 108295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108295=edit Bug 18501: but.. what was the meaning of holdingbranch here? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108169|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 108293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108293=edit Bug 18501: Auto refund if mark as found from cataloguing If an item is marked as found (ie. not itemlost) we need to refund the patron. Test plan: Mark an item as lost to create a fee for the patron Mark it as found from the cataloguing module and confirm that the patron is refunded Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108168|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 108292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108292=edit Bug 18501: Remove the borrowernumber parameter It was not used Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108167|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 108291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108291=edit Bug 18501: Prepare the ground This code was duplicated and we are going to need it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #6 from Tomás Cohen Arazi --- I made it dependent on bug 25778 because that bugfix should be pushed ASAP as well, to the stable branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Tomás Cohen Arazi --- This is such a great idea Kyle. We need to document it once pushed. I hope we can even backport this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 [Bug 26163] Add plugin directories to PERL5LIB -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||25778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 --- Comment #15 from Tomás Cohen Arazi --- David's plugin does the job. I tested on a kohadevbox and printing the PERL5LIB value. REmote debugging works as expected. About the question on the FIXME, remote debugging won't work with multiple instances at a time, I wouldn't worry about that now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108221|0 |1 is obsolete|| --- Comment #14 from Tomás Cohen Arazi --- Created attachment 108290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108290=edit Bug 25778: Fix var scope in koha-plack for PERL5LIB and KOHA_HOME Currently, if a koha-plack is given multiple instances, it will create duplicate $KOHA_HOME/installer and $KOHA_HOME/installer/lib entries in PERL5LIB as these changes are done at the global rather than local level. This issue can only be seen in non-dev Koha, since dev Koha installs rewrite PERL5LIB. This patch localizes PERL5LIB to each instance. To test dev installs: 0. cp debian/scripts/koha-plack /usr/sbin/koha-plack 1. koha-plack --restart kohadev 2. Note that nothing breaks To test non-dev installs: 0. Don't replace /usr/sbin/koha-plack yet 1. Create multiple non-dev installs with plack enabled and running 2. Set up one of these non-dev installs so you can use the web UI (that is beyong the scope of this test plan) 3. koha-plack --restart test1 test2 test3 4. For test3, go to /cgi-bin/koha/about.pl 5. Note that there are duplicate /usr/share/koha/installer and /usr/share/koha/lib/installer entries in PERL5LIB 6. cp debian/scripts/koha-plack /usr/sbin/koha-plack 7. koha-plack --restart test1 test2 test3 8. For test3, go to /cgi-bin/koha/about.pl 9. Note that there are no duplicates entries in PERL5LIB Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 --- Comment #4 from Barbara Johnson --- The patch worked well and I will find it very useful. Here are some observations from testing: For libraries that have a lot of CSS or jQuery it would be helpful to add a horizontal scroll bar at the top of the modal. I think it would be preferable to have the first line of the modal left justified - right now it is indented. Also, it would be nice to have the name of the system preference (such as IntranetUserJS) on the first line of the modal with the first line of actual code displaying on a separate line - right now the first line of code displays after the system preference name and it runs off the page causing the user to have to scroll. Removing code worked just fine. Copying a section of code and moving to another place in the system preference would split comments. It would be helpful if the log entries were numbered - I know that this is not part of this bug but as I was testing it would have been helpful. I can submit that as another bug. Here's an example from testing - https://snipboard.io/ZFnmI0.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26215] Remove the use of jquery.checkboxes plugin from Z39.50 search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26215 --- Comment #1 from Owen Leonard --- Created attachment 108289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108289=edit Bug 26215: Remove the use of jquery.checkboxes plugin from Z39.50 search pages This patch removes the use of the jquery.checkboxes plugin from three Z39.50 search templates: Acquisitions, Authorities, and Cataloging. To test, apply the patch and test the controls for selecting and deselecting Z39.50 search targets on the following pages: - In Acquisitions: Locate a vendor and add to basket -> From an external source. - In Authorities: Click "New authority" -> "New from Z39.50/SRU." - In Cataloging: Click "New from Z39.50/SRU." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26215] Remove the use of jquery.checkboxes plugin from Z39.50 search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26215 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26172] Add a cashup summary view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #4 from Sally --- Hi Martin, thanks for writing this! When I confirmed the cashup: cgi-bin/koha/pos/register.pl?op=cashup I received the following error: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_testing1.debit_type_code.description' isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 413 at /kohadevbox/koha/C4/Templates.pm line 122 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26215] New: Remove the use of jquery.checkboxes plugin from Z39.50 search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26215 Bug ID: 26215 Summary: Remove the use of jquery.checkboxes plugin from Z39.50 search pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on Z39.50 search pages: - acqui/z3950_search.tt - cataloguing/z3950_auth_search.tt - cataloguing/z3950_search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26215 [Bug 26215] Remove the use of jquery.checkboxes plugin from Z39.50 search pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26214] Remove the use of jquery.checkboxes plugin on late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Owen Leonard changed: What|Removed |Added Attachment #108287|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 108288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108288=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26214] Remove the use of jquery.checkboxes plugin on late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 --- Comment #1 from Owen Leonard --- Created attachment 108287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108287=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26214] Remove the use of jquery.checkboxes plugin on late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 [Bug 26214] Remove the use of jquery.checkboxes plugin on late orders page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26214] New: Remove the use of jquery.checkboxes plugin on late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Bug ID: 26214 Summary: Remove the use of jquery.checkboxes plugin on late orders page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the late orders page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master --- Comment #13 from Tomás Cohen Arazi --- This should be backported down to 19.11 once we agree on the fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26213] Remove the use of jquery.checkboxes plugin when adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26213] Remove the use of jquery.checkboxes plugin when adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 --- Comment #1 from Owen Leonard --- Created attachment 108286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108286=edit Bug 26213: Remove the use of jquery.checkboxes plugin when adding orders from MARC file This patch removes the use of the jquery.checkboxes plugin from the page for adding orders to a basket from a staged MARC file. This patch fixes an unreported bug wherein the "select all" and "clear all" controls affected not only MARC record checkboxes but also the "show inactive funds" checkboxes. To test, apply the patch and go to Acquisitions. - Go to Vendor -> Add to basket -> From a staged file. - Select a staged file with multiple records. - Test the "Select all" and "Clear all" links at the top of the "Select to import" tab. They should work correctly to select and deselect checkboxes corresponding to staged MARC records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23302] Less clicks on Z3950 search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #16 from Marcel de Rooy --- Hope this "compromise" meets the most consensus. See commit message of the patch. Ready for testing. One TODO still: we need to facilitate translation of the button text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23302] Less clicks on Z3950 search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #15 from Marcel de Rooy --- Created attachment 108285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108285=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23302] Less clicks on Z3950 search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age checking while doing the membership registration through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #2 from Katrin Fischer --- Looks good on first glance! Commit message needs a little fix - Bug 26211: Patron ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 [Bug 26213] Remove the use of jquery.checkboxes plugin when adding orders from MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26213] New: Remove the use of jquery.checkboxes plugin when adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26213 Bug ID: 26213 Summary: Remove the use of jquery.checkboxes plugin when adding orders from MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced when adding orders to a basket from a MARC file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age checking while doing the membership registration through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age checking while doing the membership registration through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26212] Remove the use of jquery.checkboxes plugin from pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Owen Leonard changed: What|Removed |Added Attachment #108282|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 108284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108284=edit Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0Generator=koct-firefoxGeneratorVersion=0.1 2020-08-14 13:24:21issue01091323300093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26211] Patron age checking while doing the membership registration through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #1 from Amit Gupta --- Created attachment 108283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108283=edit Bug 26211-Patron age checking while doing the membership registration through OPAC To Test 1. Create the patron category from the staff page for ex: Kid and give age required and age Upperage limit age required 5 yrs and upperage limit 17. 2. Allow category in PatronSelfRegistrationDefaultCategory for online registration from opac. 3. Go to /cgi-bin/koha/opac-memberentry.pl page. 4. Fill the form and give choose date of birth 10/10/1974 and click OK. Now you can able to save the page. 5. Apply the patch. 6. Again go to cgi-bin/koha/opac-memberentry.pl page. 7. Fill the form and give choose date of birth 10/10/1974 and click OK. It will give the error message. Patron's age is incorrect for their category. Ages allowed are 5-17. This patch check patron age defined in the patron categories while doing the registration from the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26212] Remove the use of jquery.checkboxes plugin from pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26212] Remove the use of jquery.checkboxes plugin from pending offline circulations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 --- Comment #1 from Owen Leonard --- Created attachment 108282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108282=edit Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0Generator=koct-firefoxGeneratorVersion=0.1 2020-08-14 13:24:21issue01091323300093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25867] Label holdingbranch as Current library rather than Current location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25867 Nick Clemens changed: What|Removed |Added Attachment #108277|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 108281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108281=edit Bug 25867: Database update for changing existing frameworks This updates the descriptions for 952$a und $b in all existing frameworks, if the English description hasn't been changed since installing Koha. To test: - Look at your item edit form or on the MARC tab for the descriptions shown for $a and $b for any framework - Note the descriptons say '... location' - Change one or more using the frameworks. - Run the database update - Verify only the unchanged ones have been updated Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25867] Label holdingbranch as Current library rather than Current location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25867 Nick Clemens changed: What|Removed |Added Attachment #108276|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 108280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108280=edit Bug 25867: Label "Current location" as "Current library" and "Permanent location" as "Home library" There is some confusion between the different locations and libraries appearing in the GUI. holdingbranch is sometimes labeled as current location homebranch is sometimes labeled as permanent location The patch fixes these occurences in various files: - Item search form, results and export options - MARC frameworks for en, fr-Fr, nb-NO, and pl-PL - Holds awaiting pickup report - Item display on order receive screen (create items on receive) - OPAC system preference: OPACResultsLibrary - Staff and OPAC detail pages - Lost items report - Rotating collections Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
