[Koha-bugs] [Bug 26246] Create a display area to show pending requests

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26246

--- Comment #1 from Alvaro Cornejo  ---
Have done some testings for article requests adding this code to header.inc 

 [%# ALVARO ADDED FOR SHOW PENDINGS %]
 [% IF ( pending_article_requests ) %]
 
   Article requests:
[% pending_article_requests | html %]
 
 [% END %]

With this modiification pending articles appear only in main menu since others
do not have access to pending info "pending_article_requests".

For other pages to include pending info (tested only with article request), we
need to include these libraries:

  use C4::Context;
  use Koha::ArticleRequests;
  use Koha::BiblioFrameworks;

We also need to include variable $flags in the definition of
get_template_and_user even if original script does not use it so it will be
something like

 my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user(

Note that it seems the content of the array? does not matter...

and finaly add the code to get the values for the pendings:

  # ALVARO TEST
my $branch =
  (  C4::Context->preference("IndependentBranchesPatronModifications")
  || C4::Context->preference("IndependentBranches") )
  && !$flags->{'superlibrarian'}
  ? C4::Context->userenv()->{'branch'}
  : undef;

my $pending_article_requests = Koha::ArticleRequests->search_limited(
{
status => Koha::ArticleRequest::Status::Pending,
$branch ? ( 'me.branchcode' => $branch ) : (),
}
)->count;
$template->param(   pending_article_requests   =>
$pending_article_requests,  );
  ## END ALVARO

Before sending the html output to template

  output_html_with_http_headers $query, $cookie, $template->output;


So far I tried with search.pl, ciculation-home.pl, detail.pl, addbiblio.pl
tool-home.pl and members-home.pl and worked fine in all cases

I guess it can be possible to add the others pending notices in the same way

I apologise if the code/terms used are not the correct ones but I´m by no means
a programmer but just have some basic understanding of it. Have no idea if what
I´ve done have any impact somewhere else... specially with user permits...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
This patch looks definitely incorrect.

(It also updates Auth.pm.old rather than Auth.pm)

But interesting bug report. I'm planning to use the OAuth setup in the near
future so I'll keep an eye out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26252] Allow patron_emailer.pl to select notice branch from report

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26252

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Add a task queue

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #147 from David Cook  ---
(In reply to Katrin Fischer from comment #146)
> Me too? This one isn't for me tho.

Is that due to any particular reason? I'm happy to provide more information if
that will help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163

--- Comment #16 from David Cook  ---
(In reply to Kyle M Hall from comment #15)
> I just wanted to clarify that I'm mean I designed the kitchen sink plugin
> addition to test this badly.

No worries. I've just looked at the plugin and I see what you mean.

I'll have to take a look at it later, but I'll make a note to do it with the
curbside plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25314] Make OPAC facets collapse

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

--- Comment #16 from Katrin Fischer  ---
We can take care of adding the sign off line in QA this time, but signing off
patches is easy with the sandboxes if you want to give it a try:
https://wiki.koha-community.org/wiki/Sandboxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21750] Move collection code to its own column in checkins table

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750

Lisette Scheer  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA
 CC||lisettesla...@gmail.com

--- Comment #4 from Lisette Scheer  ---
The dependency is resolved fix and the patch applied cleanly but didn't add a
column either on the returns screen or as an option in column configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5807] Add collection code to circulation rules

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5807

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #2 from Lisette Scheer  ---
this would be very helpful, especially if it could work something like this:

rule:

TYPE OR Collection Checkout Period

BOOK   21 DAYS
LUCKY DAY  14 DAYS

Any book that didn't have the lucky day collection type would checkout for 21
days. Any book that did have the lucky day collection type would checkout for
14 days. 

This was our item types could all be by the actual type of material, but we
could set different circ rules based on collections such as lucky day, new
book, new dvd, which should really be collections only for the Book and DVD
item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863

--- Comment #3 from Lisette Scheer  ---
(In reply to Andrew Fuerste-Henry from comment #2)
> If we make the syspref force all terms to be fuzzy when on, can we make it
> so that when the syspref is off the ~ still works to fuzzy an individual
> term? I agree that it's unreasonable to expect patrons to remember to use a
> fancy search trick like that, but I think the flexibility is good for staff
> users.

Agreed, the flexibility is nice for staff but our patrons have been somewhat
frustrated, espcially with titles that have apostrophes. 

(In reply to Nick Clemens from comment #0)
> The QueryFuzzy syspref affects zebra in that a fuzziness value is passed to
> the query, however, it simply allows or disallows the use of the fuzzy
> search option
> 
> To activate fuzziness on a term one must add '~'
> 
> Should turning on fuzziness do this automatically?

We have QueryFuzzy turned on and ~ does not seem to work to make a term fuzzy.
If it just did it automatically I think that would be better for our patrons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108706|0   |1
is obsolete||

--- Comment #10 from ByWater Sandboxes  ---
Created attachment 108710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108710=edit
Bug 22789: Add non priority feature to C4 classes and staff interface

This patch implements necesary code to implement non priority feature

To test:
1) Apply all patches.
2) Run updatedatabase.
3) Checkout a specific item for patron1.
4) Place a hold on the same item for patron2 (do not check non priority
   hold checkbox).
5) Try to renew the item for patron1.
CHECK => in checkouts table, there is a message that the item could not
be renewed because there was a hold.
6) Cleanup all checkouts and holds.
7) repeat steps 3 to 5, but this time check the non priority checkbox.
SUCCESS => item was renewed
8) prove t/db_dependent/Holds.t

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #11 from Lisette Scheer  ---
Worked as expected and I'm looking forward to this development!
I wasn't able to prove t/db_dependent/Holds.t as I was on the sandbox.
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108703|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 108707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108707=edit
Bug 22789: Add tests

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108704|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 108708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108708=edit
Bug 22789: Add non_priority column to reserves and old_reserves

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108705|0   |1
is obsolete||

--- Comment #9 from ByWater Sandboxes  ---
Created attachment 108709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108709=edit
Bug 22789: Set non_priority column as boolean in schema

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.01  |20.11.00, 20.05.01,
released in||19.11.09
 Status|Pushed to stable|Pushed to oldstable

--- Comment #13 from Aleisha Amohia  ---
backported second patch to 19.11.x for 19.11.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

--- Comment #6 from Agustín Moyano  ---
Created attachment 108706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108706=edit
Bug 22789: Add non priority feature to C4 classes and staff interface

This patch implements necesary code to implement non priority feature

To test:
1) Apply all patches.
2) Run updatedatabase.
3) Checkout a specific item for patron1.
4) Place a hold on the same item for patron2 (do not check non priority
   hold checkbox).
5) Try to renew the item for patron1.
CHECK => in checkouts table, there is a message that the item could not
be renewed because there was a hold.
6) Cleanup all checkouts and holds.
7) repeat steps 3 to 5, but this time check the non priority checkbox.
SUCCESS => item was renewed
8) prove t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

--- Comment #5 from Agustín Moyano  ---
Created attachment 108705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108705=edit
Bug 22789: Set non_priority column as boolean in schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

--- Comment #3 from Agustín Moyano  ---
Created attachment 108703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108703=edit
Bug 22789: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

--- Comment #4 from Agustín Moyano  ---
Created attachment 108704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108704=edit
Bug 22789: Add non_priority column to reserves and old_reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish non-priority holds

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25314] Make OPAC facets collapse

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

--- Comment #15 from Lucas Gass  ---
Ivan,

In that case you need to also upload the signed-off patch as attachment and
mark the initial one as obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233

Michael Sutherland  changed:

   What|Removed |Added

 CC||sudrl...@vt.edu

--- Comment #15 from Michael Sutherland  ---
You can easily run a report and get the same results. I have hundred of
holdings and can show that it doesn't work properly. Let's take Der Spiegel for
example. I have 630 holdings in my test server running 19.11.08.  

https://vtlib-eds-files.s3.amazonaws.com/Screen+Shot+2020-08-19+at+5.13.10+PM.png

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26259] Redundant restriction alert in circulation.pl

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26259

--- Comment #1 from Christopher Brannon  ---
Created attachment 108702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108702=edit
Multiple restriction alerts and punctuation inconsistencies

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26259] New: Redundant restriction alert in circulation.pl

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26259

Bug ID: 26259
   Summary: Redundant restriction alert in circulation.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When checking out items with a restriction override, there seems to be a
redundancy in alerts about restrictions:

Patron is restricted
Patron's card is expired
Patron has an indefinite restriction.
Restriction overridden temporarily.

I am not sure why staff need to be told twice, let alone 3 times about a
restriction.  If we are overriding a restriction, it is given there is a
restriction.  If a patron has an indefinite restriction, it is given there is a
restriction.

This should have really told me:

Patron's card is expired
Restriction(s) overridden temporarily

I am also seeing inconsistencies in punctuation.  Should the alerts end with a
period or not?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #75 from Lisette Scheer  ---
Worked as intended. 

ISBN 978-1-78416-110-1 did import the date as 2016-09-22 and the box only
allows you to type in 4 characters. It would not let me submit the form with
the date that it autofilled, which might cause some patron confusion. 

It only said "Please match the requested format" but doesn't tell you what the
requested format is. Functionally it worked great, that was the only odd thing
I noticed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103532|0   |1
is obsolete||

--- Comment #73 from ByWater Sandboxes  ---
Created attachment 108700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108700=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103529|0   |1
is obsolete||

--- Comment #70 from ByWater Sandboxes  ---
Created attachment 108697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108697=edit
Bug 14242: (follow-up) Change the icon to words

Fix a bug that meant it would search on empty ISBN

To test
1. Fill in a valid ISBN (Book data is correctly loaded)
2. Clear the ISBN from the field (Book data is correctly removed)
3. Tab away from the empty ISBN field: Data is loaded for a title
  "ISBN 0-9690745-2-2"
4. Apply patch
5. Repeat 1,2 and 3 notice a search is no longer done

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103533|0   |1
is obsolete||

--- Comment #74 from ByWater Sandboxes  ---
Created attachment 108701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108701=edit
Bug 14242: Styling of buttons, get copyright date, fixing plugin comment

And other code-y bits. Addressing comments in Comment 59.

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103531|0   |1
is obsolete||

--- Comment #72 from ByWater Sandboxes  ---
Created attachment 108699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108699=edit
Bug 14242: (follow-up) Translateable js strings, $raw filter

Sponsored-by: Region Halland
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103530|0   |1
is obsolete||

--- Comment #71 from ByWater Sandboxes  ---
Created attachment 108698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108698=edit
Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes

To test, enter a valid ISBN complete with -
eg
978-1-78416-110-1

The search should still work

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #68 from ByWater Sandboxes  ---
Created attachment 108695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108695=edit
Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s) into
search fields for Google Books API and automaticly fills requested fields with
search result.

Use in OPAC purchase suggestions to automaticly fill out fields when entering
ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACAutoFill"
3. Log into OPAC and go to purchase suggetions page
4. Write a valid ISBN into the ISBN field and press the edit icon next to the
   field, or unfocus the field.
5. Title, Author, Publisher and Item Type fields should now be filled
   automaticly.
6. Press "undo" to undo - should restore all changed fields to original values

Tested all patches together, works as expected.
Signed-off-by: Marc 

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25314] Make OPAC facets collapse

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

Ivan Dziuba  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #14 from Ivan Dziuba  ---
(In reply to Lucas Gass from comment #13)
> Doesn't look like this has been tested so I'm not sure why the status was
> changed to 'Signed-off', reseting this to 'Needs Signoff'

I tested this bug. It works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #103528|0   |1
is obsolete||

--- Comment #69 from ByWater Sandboxes  ---
Created attachment 108696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108696=edit
Bug 14242: (follow up) renaming syspref

OPACAutoFill -> OPACSuggestionAutoFill

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #2 from Christopher Brannon  ---
Created attachment 108694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108694=edit
Inconsistencies in tabs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #1 from Christopher Brannon  ---
And club counts should not be in parenthesis.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] New: Circulation tabs inconsistent with counters

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

Bug ID: 26258
   Summary: Circulation tabs inconsistent with counters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The circulation tabs on circulation.pl and moremember.pl are inconsistent
between each other and the two pages.

Clubs should have counters in front of the name like the other tabs.

Restrictions does not have a counter on the circulation.pl page, but it does on
the moremember.pl page.

Restrictions should be Restriction(s) on both pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502

Donna  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

--- Comment #3 from Donna  ---
This is still an issue in 19.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #14 from Lucas Gass  ---
Jonathan,

Because you pushed 26234 to master this patch no longer cleanly applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25314] Make OPAC facets collapse

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #13 from Lucas Gass  ---
Doesn't look like this has been tested so I'm not sure why the status was
changed to 'Signed-off', reseting this to 'Needs Signoff'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25314] Make OPAC facets collapse

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

Ivan Dziuba  changed:

   What|Removed |Added

 CC||ivan.dzi...@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150

Brandon J  changed:

   What|Removed |Added

 Attachment #107853|0   |1
is obsolete||

--- Comment #2 from Brandon J  ---
Created attachment 108693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108693=edit
Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page

This patch removes the use of the jquery.checkboxes plugin from the
inventory page and replaces it with custom JS.

To test, apply the patch and go to Tools -> Inventory.

 - Submit the form with some selections which will return results on the
   following page. I filtered by library.
 - On the page showing results, test that the "Select all" and "Clear
   all" links work correctly.

Signed-off-by: Brandon J 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150

Brandon J  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] Compare values of system preference log entries

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

Brandon J  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] Compare values of system preference log entries

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

Brandon J  changed:

   What|Removed |Added

 Attachment #108271|0   |1
is obsolete||

--- Comment #5 from Brandon J  ---
Created attachment 108692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108692=edit
Bug 26207: Compare values of system preference log entries

This patch adds the ability to compare the values of system preferences
in the system log. The user can select two entries in the log search
results and view a diff of the two versions.

The feature is designed specifically for CSS and JS preferences like
OpacUserCSS or OpacUserJS where code changes are difficult to track.

To test, apply the patch and go to Tools -> Log viewer. You may need to
add values and make changes to preferences like OpacUserCSS if you don't
already have a history in your logs.

- Perform a search for log entries in the "System prefs" module.
- In the results, each entry for a system preference should have a
  "Compare" checkbox."
- Check one of the checkboxes.
  - The table should now be filtered by the system preference name. This
facilitates meaningful selections for comparison.
  - You should see a message displayed onscreen, "Showing results
for...[ preference name]"
  - The "Check none" link in the toolbar above the table should now be
enabled.
  - If youy click the "Compare selected" link in the toolbar at this
stage you should get a message, "You must select two entries to
compare."
  - If you uncheck the checkbox the table should return to an unfiltered
state.
- Check two checkboxes.
  - The "Compare selected" link in the toolbar should now be enabled.
  - Next to each of the checkboxes you checked should be a "View
comparison" link.
  - Clicking either of the "View comparison" links or the "Compare
selected" link should trigger a modal with the diff view of the two
preferences.
- Try to select a third checkbox. You should get a message, "You can
  select a maximum of two checkboxes." The box should remain unchecked.
- Test that unchecking both checkboxes manually clears the table filter.
- Test that the "Check none" link works to uncheck checked boxes and
  clear the table filter.

Signed-off-by: Brandon J 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26222] Ability to show membership registration and membership renewal date on opac-memberentry.pl page

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26222

--- Comment #3 from Brandon J  ---
Created attachment 108691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108691=edit
Bug 26222: Ability to show membership registration and membership renewal date
on opac-memberentry.pl page

Test case:
1. Login to the OPAC page /cgi-bin/koha/opac-user.pl
2. On the left hand side you can see your personal details tab.
3. Click on the your personal details.
4. Now you can see the personal detail for ex cardnumber, homelibrary.
5. Apply the patch.
6. Reload the page now you can able to see the Registration date of the member
and Renewal date of the member in case membership is renewed.

Signed-off-by: Brandon J 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26222] Ability to show membership registration and membership renewal date on opac-memberentry.pl page

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26222

Ivan Dziuba  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ivan.dzi...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26257


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257
[Bug 26257] Move translatable strings out of subscription-add.tt and into
subscription-add.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26257] New: Move translatable strings out of subscription-add.tt and into subscription-add.js

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257

Bug ID: 26257
   Summary: Move translatable strings out of subscription-add.tt
and into subscription-add.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, testo...@bugs.koha-community.org
Depends on: 21156

Strings defined for translation in subscription-add.tt can now be wrapped in
the new translation function and put in subscription-add.js.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26256] Move translatable strings out of templates and into serials-toolbar.js

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26256

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26256] Move translatable strings out of templates and into serials-toolbar.js

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26256

--- Comment #1 from Owen Leonard  ---
Created attachment 108690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108690=edit
Bug 26256: Move translatable strings out of templates and into
serials-toolbar.js

This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.

To test:

- Apply the patch and go to Serials and search for a subscription.
- Open the detail page for an open subscription.
- Click the "Close" button. You should get a confirmation, "Are you
  sure you want to close this subscription?"
- Confirm that you want to close it.
- When the page reloads, click the "Reopen" button. You should get a
  confirmation, "Are you sure you want to reopen this subscription?"
- Cancel.
- Choose Edit -> Delete subscription. You should get a confirmation,
  "Are you sure you want to delete this subscription?"
- Perform the same tests from the "Serial collection" page.

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

  > cd misc/translator
  > perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js for translation,
  e.g.:

  msgid "Are you sure you want to delete this subscription?"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

  > perl translate install fr-FR

- Switch to your newly translated language in the staff client
  and repeat the test plan above. The translated strings should
  appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #107844|0   |1
is obsolete||

--- Comment #7 from Andrew Nugged  ---
Created attachment 108689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108689=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules

Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge
in circulation rules per specific items/patron categories.
When value not found in circulation rules it uses global
ExpireReservesMaxPickUpDelayCharge, as it was before this smart-rules
feature was introduced.

To check the feature after applying the patch:
1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added "Expire reserve charge" row.
2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
3) Prepare an item for our next step, pick a biblio that has item
with the same item type you altered in smart rules and check it out.
3) Place a hold on that item and set the expiration date as the
next day.
4) Check in it after that.
5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE
`reserve_id`=329;"
 Or alternatively:
5) Wait for tomorrow, change server time or invent a time machine.
6) Run cancel_expired_holds.pl cron job.
7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount
of fee you assigned in that rule
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
8) You can repeat this with other rules and different
numbers/biblio/item types to check that different fees apply according
to smart rules.
9) If there's no matching smart rule or smart rule have an empty
string as a fee - global ExpireReservesMaxPickUpDelayCharge variable
value will be used.
   10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.

IMPORTANT:
Smart-rules filters only applied to item-level holds, when item-type
for items is known. If there's biblio-level hold, then again global
ExpireReservesMaxPickUpDelayCharge value will be used (as well global
one can be empty or zero).

Mentored-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26256


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26256
[Bug 26256] Move translatable strings out of templates and into
serials-toolbar.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26256] New: Move translatable strings out of templates and into serials-toolbar.js

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26256

Bug ID: 26256
   Summary: Move translatable strings out of templates and into
serials-toolbar.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, testo...@bugs.koha-community.org
Depends on: 21156

Strings defined for translation in serials-collection.tt, serials-home.tt,
serials-search.tt, and subscription-detail.tt can now be wrapped in the new
translation function and put in serials-toolbar.js.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156
[Bug 21156] Internationalization: plural forms, context, and more for JS files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244

--- Comment #1 from Owen Leonard  ---
Created attachment 108688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108688=edit
Bug 26243: Move translatable strings out of memberentrygen.tt and into
JavaScript

This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.

Note: I was unable to trigger the confirmation message in the
check_form_borrowers function. I think the form is now structured in a
way that it is never triggered, thus a candidate for removal.

To test:

- Apply the patch and go to Patrons.
- Add or edit a patron.
- Select a date of birth at least one month in the past and confirm that
  the patron's age is displayed in the hint below.
- Test multiple variations to confirm that the singular and plural of
  'year' and 'month' display correctly. (e.g. 1 year 9 months, 2 years,
  etc).
- Set some patron messaging preferences for the patron.
- Change the patron category.
- You should get a confirmation: "Change messaging preferences to
  default for this category?"

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

  > cd misc/translator
  > perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/members.js for translation, e.g.:

  msgid "%s years"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

  > perl translate install fr-FR

- Switch to your newly translated language in the staff client
  and repeat the test plan above. The translated strings should
  appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #150 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #127)
> Hm, I've checked the test plan on the dependent bug now too and am still a
> little confused about the use case for this.
> 
> Reading "volume" made me think of something that would be used for serial
> issues bound together into one volume (serials, binding) But this doesn't
> seem to be the case with how the volume hold feature works.

That is correct. The term volume is used here because that is what most if not
all other ILSs use.

> Does this more work like a "Hold group" maybe? One item out of the group
> appears to satisfy the hold - so maybe "Group" would be a better word to
> describe the idea?

You are correct! I described it in a bit more detail in my previous comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233

--- Comment #13 from Ivan Dziuba  ---
(In reply to Jonathan Druart from comment #12)
> Hi Ivan, please try with the 4 dates from comment 6 and with the system
> preferences dateformat set to "us"

Hi Jonathan, sorry I don't have biblionumber = '4', but I have more than 4
dates for biblionumber = '66343' and it works nice...

T-SQL:
select itemnumber, dateaccessioned from items where biblionumber = '66343';

++-+
| itemnumber | dateaccessioned |
++-+
|  75554 | 2014-11-25  |
|  7 | 2014-12-17  |
|  75556 | 2014-12-17  |
|  75557 | 2015-01-28  |
|  75558 | 2015-02-21  |
|  75559 | 2015-03-17  |
|  75560 | 2015-04-14  |
|  75561 | 2015-05-21  |
|  75562 | 2015-06-11  |
|  75563 | 2015-08-28  |
|  75564 | 2015-10-13  |
|  75565 | 2015-11-19  |
|  75566 | 2016-01-06  |
|  75567 | 2016-02-11  |
|  75568 | 2016-03-15  |
|  75569 | 2016-04-13  |
|  75570 | 2016-05-07  |
|  75571 | 2016-06-15  |
|  75572 | 2016-08-19  |
|  75573 | 2016-09-21  |
|  75574 | 2016-11-23  |
++-+

https://prnt.sc/u2dabp

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #149 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #126)
> This one is a little scary already, but going in for a first review :)
> 
> 1) QA script
Fixed!

> 2) Doubled up use statement in Biblio.pm

Fixed!

> 3) REST API
> 
> I'd love to have Tomas take a look on the REST API bits here. 

I'll ask Tomas to take a look!

> 
> 4) sysprefs.sql

Fixed!

> 
> 5) Pref (question)
> 
> Enable|Don't enable
> volumes feature to allow collecting groups of items on a record into volumes.
> 
> Does it mean the items have to be from the same record or could they be from
> different ones?

We decided early on that volumes would have contain only items within the same
record.

> 6) Table configuration
> 
> The new volumn column on the holdings table needs to be added to the table
> configuration options.

This table is not a datatable so that doesn't really apply.

> 7) GUI
> 
> "Create new" on the items table would work nicer as "Create new volume" or
> "New volume" to give context to translators and for better accessibility.

Fixed!

> Future improvements:
> It might be nice to offer a kind of grouped view for the items in volumes...
> but I am not sure yet how this would work best. 
> It might be nice to show the volumes in the OPAC as well.

Agreed. If volume management turns out to be popular, that would be an easy
extension to this work.

> 8) Use case and future plans?
> 
> Can you tell a bit about in what context or use case this partner is using
> this? Serials?

Our current and only use case at this time is for volume level holds. Some
libraries keep different volumes on the same record ( imagine different seasons
of a TV series ). In these cases, a bib level hold won't work if you only want
Season 1, but if there are 3 copies of season one, you wouldn't want an item
level hold either. Volume level holds solve this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #148 from Kyle M Hall  ---
Created attachment 108686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108686=edit
Bug 24857: Change button text from "Create new" to "New volume"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #146 from Kyle M Hall  ---
Created attachment 108684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108684=edit
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #145 from Kyle M Hall  ---
Created attachment 108683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108683=edit
Bug 24857: Fix simple-quote string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #147 from Kyle M Hall  ---
Created attachment 108685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108685=edit
Bug 24857: Fix sorting of new syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #144 from Kyle M Hall  ---
Created attachment 108682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108682=edit
Bug 24857: Add missing filter and move js to footer on additem.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #143 from Kyle M Hall  ---
Created attachment 108681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108681=edit
Bug 24857: Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #138 from Kyle M Hall  ---
Created attachment 108676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108676=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #142 from Kyle M Hall  ---
Created attachment 108680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108680=edit
Bug 24857: Fix license statements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #141 from Kyle M Hall  ---
Created attachment 108679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108679=edit
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #139 from Kyle M Hall  ---
Created attachment 108677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108677=edit
Bug 24857: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #140 from Kyle M Hall  ---
Created attachment 108678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108678=edit
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #137 from Kyle M Hall  ---
Created attachment 108675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108675=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #133 from Kyle M Hall  ---
Created attachment 108671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108671=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #134 from Kyle M Hall  ---
Created attachment 108672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108672=edit
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #135 from Kyle M Hall  ---
Created attachment 108673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108673=edit
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #132 from Kyle M Hall  ---
Created attachment 108670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108670=edit
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #136 from Kyle M Hall  ---
Created attachment 108674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108674=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #131 from Kyle M Hall  ---
Created attachment 108669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108669=edit
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #129 from Kyle M Hall  ---
Created attachment 108667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108667=edit
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #130 from Kyle M Hall  ---
Created attachment 108668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108668=edit
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #108443|0   |1
is obsolete||
 Attachment #108444|0   |1
is obsolete||
 Attachment #108445|0   |1
is obsolete||
 Attachment #108446|0   |1
is obsolete||
 Attachment #108447|0   |1
is obsolete||
 Attachment #108448|0   |1
is obsolete||
 Attachment #108449|0   |1
is obsolete||
 Attachment #108450|0   |1
is obsolete||
 Attachment #108451|0   |1
is obsolete||
 Attachment #108452|0   |1
is obsolete||
 Attachment #108453|0   |1
is obsolete||
 Attachment #108454|0   |1
is obsolete||
 Attachment #108455|0   |1
is obsolete||
 Attachment #108456|0   |1
is obsolete||

--- Comment #128 from Kyle M Hall  ---
Created attachment 108666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108666=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca  Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26254] New: Large patron imports through the web interface can timeout in plack

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26254

Bug ID: 26254
   Summary: Large patron imports through the web interface can
timeout in plack
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The patron import job through the interface often times out with batches of
import patrons of more than ~1000 patrons. Normally the job will complete in
the background, but it is surprising and upsetting to users when this happens.

It seems to happen more when there is significant matching happening.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26245] Remove unused functions from members.js

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245

--- Comment #2 from Owen Leonard  ---
This patch probably should have included changes to memberentrygen.tt, since
some related strings are defined there. But they will be removed by Bug 26244.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16112] Specify due date for batch renew

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Marco Abi-Ramia  changed:

   What|Removed |Added

 CC||marco.abi-ra...@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16112] Specify due date for batch renew

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Marco Abi-Ramia  changed:

   What|Removed |Added

 Attachment #108659|0   |1
is obsolete||

--- Comment #17 from Marco Abi-Ramia  ---
Created attachment 108665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108665=edit
Bug 16112: (follow-up) Form style improvements, clear date

This follow-up makes some markup and style improvements in order to make
the renew form more consistent with similar forms like checkout and
check-in.

It also adds a "Clear" button for the datepicker field, matching similar
date inputs.

To test, apply the patch and go to Circulation -> Renew.

 - With or without the  SpecifyDueDate system preference enabled the
   form should look correct.
 - With the SpecifyDueDate preference enabled you should see the date
   form below the barcode input field.
 - Select a date and test that the "Clear" button works to clear it.
 - Compare to the check-in page to confirm that they look consistent
   with each other.

Signed-off-by: Marco Abi-Ramia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804

Ivan Dziuba  changed:

   What|Removed |Added

 CC||ivan.dzi...@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #12 from Jonathan Druart  
---
Hi Ivan, please try with the 4 dates from comment 6 and with the system
preferences dateformat set to "us"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041

Brandon J  changed:

   What|Removed |Added

 Attachment #107276|0   |1
is obsolete||

--- Comment #12 from Brandon J  ---
Created attachment 108664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108664=edit
Bug 26041: Remove readonly flag

This patch removes the readonly attribute from the date fields for
'reserve suspension' on the holds table and in opac-user.

Note: I could not find where the readonly attribute is added to the date
fields used when places a reserver.

Note: I'm not sure about this followup.. if you enter a date in the
wrong format (American vs British for example) you might end up with a
bad date being submitted which could either result in a nasty server
error or the wrong date being used.

Signed-off-by: Brandon J 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041

Brandon J  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #6 from Jonathan Druart  
---
Koha_Master_U20 #73

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26172] Add a cashup summary view

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172

--- Comment #7 from Sally  ---
(In reply to Martin Renvoize from comment #2)
> Initial proof of concept patch attached.. it would be good to get some early
> feedback whilst I write tests for the existing code and refine the finer
> details.

This looks great, Martin - really really useful.  

It's in a really logical location to retrieve, and it's great that the summary
contains both the register name and cashing up period.

The table is really clear, and the split between the 'Total' takings and the
'Bankable' physical cash is really useful.

Having had a test with it, there's two things that would be useful:

1)  Could a button be added to send the contents of the modal to the printer? 
Highlighting it and then choosing Print Selection achieves this (obviously),
but it would be great to make that easier for those librarians who are less
confident with computers.

2)  From the Total and the Bankable, it's possible to calculate the payments
which has already been reconciled (Banked?) - but could this total also be
displayed to save any math errors by the librarians?  

I know Martin knows our system very well but to explain for others reading
this, we currently have a custom cash module and all transactions processed
through the till are listed under 'Total'.  This is then split into payment
types - e.g. Cash, Card, Cheque.  This is because we submit these differently
to our accounting department, so the cash up summary looks like this:  

Total:  57.00
Card:  37.00
Cash:  11.00
Cheque:  9.00

With the current modal, it would be useful if we could see the payment
breakdown (like above), or an 'Banked' total listed, e.g.  

Total: 57.00 
Banked: 37.00
Bankable: 20.00

So Total is all takings, Banked is credit/debit card payments that have already
been reconciled, Bankable is cash/cheque which needs to be taken from the till
and deposited in the bank.

But yeah, it works brilliantly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218

--- Comment #9 from Amit Gupta  ---
(In reply to Amit Gupta from comment #8)
> Hi Brandon,
> 
> Thanks for looking the patch and testing. You have checked only patch and
> you look into the other one.

Hi Brandon,

Thanks for looking the patch and testing. You have checked only patch can you
look into the other one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218

Amit Gupta  changed:

   What|Removed |Added

 CC||brandon.jime...@inlibro.com

--- Comment #8 from Amit Gupta  ---
Hi Brandon,

Thanks for looking the patch and testing. You have checked only patch and you
look into the other one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16112] Specify due date for batch renew

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Marco Abi-Ramia  changed:

   What|Removed |Added

 Attachment #108662|0   |1
is obsolete||

--- Comment #16 from Marco Abi-Ramia  ---
Created attachment 108663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108663=edit
Bug 16371: (follow-up) DB changes

We need to keep "opac" is the pref was set before the upgrade

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16112] Specify due date for batch renew

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Marco Abi-Ramia  changed:

   What|Removed |Added

 Attachment #108661|0   |1
is obsolete||

--- Comment #15 from Marco Abi-Ramia  ---
Created attachment 108662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108662=edit
Bug 16371: (follow-up) DB changes

We need to keep "opac" is the pref was set before the upgrade

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16112] Specify due date for batch renew

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112

Marco Abi-Ramia  changed:

   What|Removed |Added

 Attachment #108641|0   |1
is obsolete||

--- Comment #14 from Marco Abi-Ramia  ---
Created attachment 108661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108661=edit
Bug 16371: (follow-up) DB changes

We need to keep "opac" is the pref was set before the upgrade

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26067] Member email validation based on MX record

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067

Brandon J  changed:

   What|Removed |Added

 Attachment #107979|0   |1
is obsolete||

--- Comment #14 from Brandon J  ---
Created attachment 108660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108660=edit
Bug 26067 Member email validation based on MX record.

To Test
Currently we are doing testing for Primary email address from the OPAC page.
1. Enable system preference PatronSelfRegistration
2. Set PatronSelfRegistrationDefaultCategory for ex: ST
3. Set PatronSelfRegistrationLibraryList for ex: MPL
4. Open the page /cgi-bin/koha/opac-memberentry.pl
5. Fill the form and enter email address in Primary email for ex:
   amit@gmail.c you will able to submit the page and it will not give any error
message.
6. Apply the patch
7. Check system preference PatronEmailValidationMXrecord by default it show
"Require".
8. Open the /cgi-bin/koha/opac-memberentry.pl again
9. Fill the form and enter email address in Primary email for ex:
   amit@gmail.c and click on Submit button and it will give error message
"Invalid primary email address".

Signed-off-by: Brandon J 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26067] Member email validation based on MX record

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067

Brandon J  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #59 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #58)
> Sorry for posting on this old report, but it looks like (at least imo) that
> this availability block still needs further attention:
> 
> Availability line looks like: Block 1 (Alternate holdings) Block 2 (For loan
> with callno) Block 3 (Reference block with callno) Block 4 (if with colon)
> Block 5 (reallynotforloan with callno) Block 6 (list of other statuses)
> 
> On order status is no longer set in C4/XSLT; the term reallynotforloan is
> used now and is quite confusing to me?
> Block 4 with the colon and the  in block 5 are dubious.
> No big difference between block reference and block reallynotforloan.
> 
> On the already opened bug 21260 I hope to provide some follow up work..

Clarifications:
Before these patches all positive not for loan values were listed as 'Available
for reference' and all negative not for loan were 'On order'

After we separate 'Not for loan' items into:

reallynotforloan - negative not for loan values
reference - positive not for loan values

Block 1:
If no items available for loan and none for reference then we check the
AlternateHoldingsField in the sysprefs to see if we should display items from
there. Other we show 'No items available'

Block 2:
Available items - they don't have pending holds or waiting holds, they aren't
in transit, damaged, lost, withdrawn, marked notforloan or checked out. 

This block includes the 'reference' items (you call these 2 blocks) they go
into the  because we assume that these are still in the
library and can be accessed

Block 3:
This if with colon is wrong - it should be part of block 1 or just removed- if
there are no items available we say 'No items available' then add the colon,
then list the unavailable items on a new line

Block 4:
Unavailable notforloan items (reallynotforloan) on a new line - the br has
always been there to separate 'available' and 'unavailable' spans

Block 5:
List of other status, all under the 'unavailable' umbrella and same line as
above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >