[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250
--- Comment #10 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #9)
> We have a QA script fail here:
>
> FAIL t/db_dependent/Koha/Patrons.t
>OK critic
>FAIL forbidden patterns
> forbidden pattern: Use of DateTime->now should certainly be
> replaced with
> dt_from_string (bug 24840) (line 612)
> forbidden pattern: Use of DateTime->now should certainly be
> replaced with
> dt_from_string (bug 24840) (line 613)
> forbidden pattern: Use of DateTime->now should certainly be
> replaced with
> dt_from_string (bug 24840) (line 1427)
> forbidden pattern: Use of DateTime->now should certainly be
> replaced with
> dt_from_string (bug 24840) (line 1428)
That's not valid, the diff is:
-AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1
) );
-AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5
) );
-AddIssue( $patron, $item_3->{barcode} );
+AddIssue( $patron, $item_1->barcode, DateTime->now->subtract( days => 1 )
);
+AddIssue( $patron, $item_2->barcode, DateTime->now->subtract( days => 5 )
);
+AddIssue( $patron, $item_3->barcode );
> Hm, and some tests are failing?
> t/db_dependent/CourseReserves/CourseItems.t
> Test Summary Report
> ---
> t/db_dependent/CourseReserves/CourseItems.t (Wstat: 1536 Tests: 35 Failed: 6)
> Failed tests: 2, 7, 12, 17, 22, 34
> Non-zero exit status: 6
It passes for me :-/
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #5 from Ulrich Kleiber --- I don't now the real reason for this bug, but without Plack there is no ProxyError and no Timeout. With 6000 patrons, the script runs for approximately 8 minutes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #4 from David Cook --- After quickly reviewing the code, I don't see anything that is particularly Plack unfriendly. The non-proxying of certain CGI scripts was due to them forking (like Bug 15032). But this code doesn't seem to have that problem. It just seems like it's probably long-running code. What proxy error is received and how long does it take to receive it? Is it 300+ seconds or less? If ProxyTimeout is not defined in Apache, it should use Timeout, which I think should default to 300 in Debian and Ubuntu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 David Cook changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #103527|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26253] duplicated mana_config in etc/koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26253 Katrin Fischer changed: What|Removed |Added Attachment #108729|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 108774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108774&action=edit Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml It was there already but not at the same place! Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26253] duplicated mana_config in etc/koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26253 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26128 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22417 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Katrin Fischer changed: What|Removed |Added Attachment #108171|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 108772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108772&action=edit Bug 26023: Properly secure the cashup action for libraries The libraries summary page for cash management is available for users wit the 'anonymous_refund' permission to allow them to navigate to alternate cash registers and search for the prior transaction to refund. However, currently the cashup option appears, and is not blocked at the server, for all user who may access the page. It should be blocked for those users without the 'cashup' permission. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Katrin Fischer changed: What|Removed |Added Attachment #108172|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 108773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108773&action=edit Bug 26023: Properly secure the cashup and refund actions The cash register summary page for cash management is available for users with the 'anonymous_refund' or 'cashup' permission and the actions available are appropriately displayed. However, the actions are not yet correctly tested for at the server and so a user may force submit to accomplish the action. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 --- Comment #10 from Katrin Fischer --- I think we might still want to some refinements, for example having "cash register" on admin and on tools, but not being the same thing is a little confusing. But that's out of scope here and this improves things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26263] Style error on OPAC search results when item-level_itypes is set to bibliographic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 --- Comment #1 from Katrin Fischer --- Created attachment 108771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108771&action=edit Screenshot of result list with bibliographic level item type showing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #53 from Katrin Fischer --- I am passing this, but we do have a CSS issue in the OPAC result list with and without these patches. I've filed bug 26263. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26263] New: Style error on OPAC search results when item-level_itypes is set to bibliographic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 Bug ID: 26263 Summary: Style error on OPAC search results when item-level_itypes is set to bibliographic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When item-level_itypes is set to bibliographic, the OPAC results list splits 50 / 50 with the item type showing in the first half. To test: - Set tem-level_itypes to bibliogrphic - Make sure you have the record level itemtype set in some records - Search for them in the OPAC - Verify the display issue in the result list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #108764|0 |1 is obsolete|| --- Comment #52 from Katrin Fischer --- Created attachment 108770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108770&action=edit Bug 8732: (QA follow-up) Terminology - staff client to staff interface Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #108441|0 |1 is obsolete|| --- Comment #51 from Katrin Fischer --- Created attachment 108769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108769&action=edit Bug 8732: (follow-up) Make icon show on opac details and correct pref Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #107709|0 |1 is obsolete|| --- Comment #49 from Katrin Fischer --- Created attachment 108767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108767&action=edit Bug 8732: undo XSLT changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #107705|0 |1 is obsolete|| --- Comment #47 from Katrin Fischer --- Created attachment 108765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108765&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones This patchset adds a new syspref: BiblioItemtypeInfo If you set BiblioItemtypeInfo to Koha, you will see the Koha record level itemtype info. This info is also shown if item-level_itypes is set to biblio Display of icons are controlled by noItemTypeImages/OpacnoItemTypeImages Material type display is controlled by DisplayIconsXSLT/DisplayOPACIconsXSLT To test: 1 - Apply patch 2 - Update database 3 - Do an opac search and view results 4 - Switch pref to 'Koha' and refresh 5 - Note itemtypes appear 6 - Click in to a record details 7 - Note you see itemtype and icon 8 - Switch the pref 9 - Note you don't see record level itemtype and icon 10 - Repeat in staff interface Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #107706|0 |1 is obsolete|| --- Comment #48 from Katrin Fischer --- Created attachment 108766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108766&action=edit Bug 8732: Update statement Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Attachment #108322|0 |1 is obsolete|| --- Comment #50 from Katrin Fischer --- Created attachment 108768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108768&action=edit Bug 8732: (QA follow-up) Fix capitalization and terminology on BiblioItemtypeInfo description - opac = OPAC - add "system preference" to make context easier to understand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #46 from Katrin Fischer --- Created attachment 108764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108764&action=edit Bug 8732: (QA follow-up) Terminology - staff client to staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- We have a QA script fail here: FAIL t/db_dependent/Koha/Patrons.t OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 612) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 613) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 1427) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 1428) Hm, and some tests are failing? t/db_dependent/CourseReserves/CourseItems.t Test Summary Report --- t/db_dependent/CourseReserves/CourseItems.t (Wstat: 1536 Tests: 35 Failed: 6) Failed tests: 2, 7, 12, 17, 22, 34 Non-zero exit status: 6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26262] New: Paging on course reserves tables in OPAC is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Bug ID: 26262 Summary: Paging on course reserves tables in OPAC is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The styling on the paging options for the course reserves tables in OPAC is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- I think this is close, but not quite right: Instead of modeling the 'specify due date' feature, this should model the "renewal due date" feature we have in circulation (footer of the circulation table). So we should change the labelling and also the 'activation' conditions. The renewal due date option is always visible and doesn't depend on the SpecifyDueDate preference. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify renewal date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer changed: What|Removed |Added Summary|Specify due date for batch |Specify renewal date for |renew |batch renew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 Katrin Fischer changed: What|Removed |Added Attachment #108693|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 108763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108763&action=edit Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page This patch removes the use of the jquery.checkboxes plugin from the inventory page and replaces it with custom JS. To test, apply the patch and go to Tools -> Inventory. - Submit the form with some selections which will return results on the following page. I filtered by library. - On the page showing results, test that the "Select all" and "Clear all" links work correctly. Signed-off-by: Brandon J Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21750] Move collection to its own column in checkins table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Katrin Fischer changed: What|Removed |Added Attachment #108727|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 108762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108762&action=edit Bug 21750: Move collection code to its own column on checkins table To test: 1 - Set 'ShowAllCheckins' to show 2 - Set a collcection code for an item 3 - Check it in 4 - Note it displays in the the 'Item type' column 5 - Apply patch 6 - Check it in again 7 - Note the new 'Collection' column 8 - Hide/show the column using column visibility on the checkins page 9 - Go to Admin->Configure columns 10 - Test the various settings for this column and check in the item to make sure they work as expected Signed-off-by: Devinim Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21750] Move collection to its own column in checkins table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 --- Comment #10 from Katrin Fischer --- I really like this feature! Only thing I was wondering is the label on the checkbox. Currently it reads 'compare' but it also has a filter function. I wonder if something like "Filter and compare" would work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 Katrin Fischer changed: What|Removed |Added Attachment #108692|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 108760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108760&action=edit Bug 26207: Compare values of system preference log entries This patch adds the ability to compare the values of system preferences in the system log. The user can select two entries in the log search results and view a diff of the two versions. The feature is designed specifically for CSS and JS preferences like OpacUserCSS or OpacUserJS where code changes are difficult to track. To test, apply the patch and go to Tools -> Log viewer. You may need to add values and make changes to preferences like OpacUserCSS if you don't already have a history in your logs. - Perform a search for log entries in the "System prefs" module. - In the results, each entry for a system preference should have a "Compare" checkbox." - Check one of the checkboxes. - The table should now be filtered by the system preference name. This facilitates meaningful selections for comparison. - You should see a message displayed onscreen, "Showing results for...[ preference name]" - The "Check none" link in the toolbar above the table should now be enabled. - If youy click the "Compare selected" link in the toolbar at this stage you should get a message, "You must select two entries to compare." - If you uncheck the checkbox the table should return to an unfiltered state. - Check two checkboxes. - The "Compare selected" link in the toolbar should now be enabled. - Next to each of the checkboxes you checked should be a "View comparison" link. - Clicking either of the "View comparison" links or the "Compare selected" link should trigger a modal with the diff view of the two preferences. - Try to select a third checkbox. You should get a message, "You can select a maximum of two checkboxes." The box should remain unchecked. - Test that unchecking both checkboxes manually clears the table filter. - Test that the "Check none" link works to uncheck checked boxes and clear the table filter. Signed-off-by: Brandon J Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 Katrin Fischer changed: What|Removed |Added Attachment #108736|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 108761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108761&action=edit Bug 26207: (follow-up) Remove whitespace from markup Markup indentation around log entries in the template cause extra whitespace in the diff view. Removing the markup whitespace corrects it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- This works for staff, can we have the same change for OPAC please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Add ability to decrease fines with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Caroline Cyr La Rose changed: What|Removed |Added Summary|Fines not cleared with |Add ability to decrease |dropbox mode|fines with dropbox mode CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #54 from Caroline Cyr La Rose --- I changed the title a bit for the release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #53 from Katrin Fischer --- Hi Kyle, thx for the follow-ups! > > > 5) Sample notice > > Sample notice added! Can you please also include the translated installers (the .sql files)? We still use them at the moment and not sure when we can get rid of them all yet (for example UNIMARC still needs some work) > > 6) Authorised value > > I've added the AV category, but no values. I suppose we could add values for > new installations, but I don't think we'd want them for existing installs > being upgraded. Let me know what you think. Agree! > > 7) GUI > > > > reserve.pl > > I think it would be nice if the cancellation reason only activated once a > > "del" was selected. Otherwise people might expect it to do something without > > that or expect it to also work when they cancel using "X". > > It *does* work when canceling using the "X"! For that reason it is not > hidden. If you think it's simpler to not allow a reason when using the X and > have it hidden unless one of the pulldowns is marked "del" I can make that > change too. I'll test, but then we should leave as is! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Katrin Fischer changed: What|Removed |Added Attachment #108744|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 108759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108759&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #14 from Katrin Fischer --- Sally, always happy to QA patches you tested :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Add 'requested', 'sent' and 'arrived' dates in Transfers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Caroline Cyr La Rose changed: What|Removed |Added Summary|Transfers should record |Add 'requested', 'sent' and |'requested' as well as |'arrived' dates in |'sent' and 'arrived' dates |Transfers table Component|Circulation |Architecture, internals, ||and plumbing CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #24 from Caroline Cyr La Rose --- With the release notes in mind, I changed the component from "Circulation" to "Architecture, internals and plumbing" as this only affects the database, and it's not actually a circulation functionality. I also changed the title a bit to reflect this. I hope it's ok. Feel free to change it back if you think this is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21884] Writeoff "amount" changed from positive values to negative values.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21884 Alex C changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #4 from Alex C --- Hi Katrin, Yes I haven't updated this bug because there wasn't an actual fix so far to uniform the positive write-off values and negative write-off values. Is there a way or patch to batch modify all the previous (red) positive write-off amounts into (green) negative amounts? Thanks. Alex. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, gmcha...@gmail.com Keywords|release-notes-needed| Component|Architecture, internals,|System Administration |and plumbing| --- Comment #20 from Caroline Cyr La Rose --- I changed the component from "Architecture, internals and plumbing" to "System administration" so that it appears under Administration in the release notes. From a user stand point, I think it makes more sense to have it under Administration. If I were a system administrator, I would check the administration section of the release notes and I would want to know that a syspref changed name. I hope this is ok. If not, feel free to change it back :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Caroline Cyr La Rose changed: What|Removed |Added Component|Architecture, internals,|System Administration |and plumbing| CC||caroline.cyr-la-rose@inlibr ||o.com, gmcha...@gmail.com --- Comment #22 from Caroline Cyr La Rose --- I changed the component from "Architecture, internals and plumbing" to "System administration" so that it appears under Administration in the release notes. I hope this is ok. If not, feel free to change it back :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Caroline Cyr La Rose changed: What|Removed |Added Component|System Administration |Architecture, internals, ||and plumbing --- Comment #36 from Caroline Cyr La Rose --- Sorry!! Wrong bug, I put it back -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Caroline Cyr La Rose changed: What|Removed |Added Component|Architecture, internals,|System Administration |and plumbing| CC||caroline.cyr-la-rose@inlibr ||o.com, gmcha...@gmail.com --- Comment #35 from Caroline Cyr La Rose --- I changed the component from "Architecture, internals and plumbing" to "System administration" so that it appears under Administration in the release notes. I hope this is ok. If not, feel free to change it back :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Owen Leonard changed: What|Removed |Added Attachment #106027|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 --- Comment #1 from Owen Leonard --- Created attachment 108758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108758&action=edit Bug 26261: Split calendar.inc into include file and JavaScript file This patch moves most of the JavaScript out of calendar.inc and into a new file, calendar.js. English strings in calendar.js are now wrapped in the double-underscore function to allow for translation. The patch shouldn't affect datepicker functionality in any way. To test, apply the patch and test the datepicker in various contexts: - Reports -> Statistics wizards -> Patrons - Date of birth "from" and "to" should be linked so that the former must come before the latter. - Patrons -> Add or edit patron - The date of birth field datepicker shouldn't allow you to pick a future year from the dropdown. - Tools -> Calendar. - Test that the calendar tool works correctly. - Test with various settings of the dateformat system preference. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/en/js/calendar.js for translation, e.g.: msgid "August" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test the datepicker again. Translated strings like days of the week and months should be correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #84 from Katrin Fischer --- (In reply to Jonathan Druart from comment #80) > (In reply to Jonathan Druart from comment #58) > > * I think the following block is not translator friendly > > +Exclude from local holds priority updated to > > +[% IF updated_exclude_from_local_holds_priority %]Yes[% ELSE > > %]No[% END %] > > You replaced it with: > > -[% IF updated_exclude_from_local_holds_priority %]Yes[% ELSE > %]No[% END %] > +[% IF updated_exclude_from_local_holds_priority %] > +Yes > +[% ELSE %] > +No > +[% END %] > > What I meant is that it will be displayed with the TT block in the po files. > I think it would be better: > [% IF updated_exclude_from_local_holds_priority %] > Exclude from local holds priority updated to Yes > [% ELSE %] > Exclude from local holds priority updated to No > [% END %] > > Asking confirmation to Katrin. I think I'd avoid the - as HTML tags they break up the strings. I haven't tested this, but with your suggestion I think we could end up with: Exclude from local holds priority updated to Yes (Best is always to confirm by updating the po files if unsure) Better, I think, would be something like: Exclude from local holds priority updated to ... [IF ELSE for yes and no, maybe with apostropes instad of italic? 'Yes'] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #13 from Martin Renvoize --- (In reply to Sally from comment #12) > (In reply to Martin Renvoize from comment #10) > > I've rebased and simplified the patchset. > > > > You will need to run the CSS build to test this. (If testing on a sandbox, > > you can use the 'Build CSS' option from the 'Actions' menu) > > No worries, thanks for the tip - it's probably paranoia but I always use > 'Build CSS' if I think the patch touches anything styling-wise. > > Signed off. :) Many thanks for testing 😀, very wise to use the Build CSS options, I must admit I'm terrible at remembering to mention it in the test plans. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 [Bug 26261] Split calendar.inc into include file and JavaScript file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26261] New: Split calendar.inc into include file and JavaScript file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26261 Bug ID: 26261 Summary: Split calendar.inc into include file and JavaScript file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 21156 Now that we have JavaScript internationalization there's no need to have strings defined in an include file like calendar.inc. I propose that we trim calendar.inc down to only those things which require template processing and move the rest of the JavaScript into its own JS file. This would allow us to do proper linting and allow browsers to cache the file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25811] authentication.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #22 from Nick Clemens --- (In reply to Jonathan Druart from comment #21) > Koha_Master_U18 #871 > > 12:20:17 koha_1 | # Failed test 'OPAC interface authentication' > 12:20:17 koha_1 | # at t/db_dependent/selenium/authentication.t line > 134. > 12:20:17 koha_1 | An element could not be located on the page using > the given search parameters: //div[@id="login"],xpath at > t/db_dependent/selenium/authentication.t line 100. > 12:20:17 koha_1 | # Looks like your test exited with 255 just after 2. > 12:20:18 koha_1 | [10:20:18] t/db_dependent/selenium/authentication.t > > https://snipboard.io/6dYKtk.jpg The screen capture shows we are still logged in. Is it possible: 1 - That the mainpage has been cached and when we 'get' it we are still seeing when we were logged in? 2 - That we are somehow being logged in by another test running at same time? LDAP or Shib or something retaining a logged in cookie? 3 - Could we dump the patron info so we can see if it is this patron that has not been logged out, or another patron that is logged in? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031 --- Comment #10 from Nick Clemens --- Looking again - the page returned has search result numbers, but no content: 1. Material type: Text No holds allowed | Add to cart (remove) | Edit record | Edit items | OPAC view No items 2. Material type: Text No holds allowed | Add to cart (remove) | Edit record | Edit items | OPAC view No items You can recreate 12 failures by setting all 6 XSLT sysprefs to a non existent file (or just any text, I used "5") I am guessing another test is altering the XSLT file prefs, or the files cannot be reached for some reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534
--- Comment #52 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #39)
> Doing a first review here:
>
> 1) QA script:
Fixed!
>
> 2) Unit tests
Fixed!
> 3) Docs
>
> Maybe it would be worth mentioning that this allows to store a cancellation
> reason in the documentation? (Bug title + description for release notes).
> Currently only the email functionality is mentioned, but we also have an
> interesting db change.
Added! Feel free to change them, I wasn't sure what I should add really.
> 4) Constants for translation?
>
> +var REASON_LABEL = _("Reason: ");
>
> I believe this is not really needed here as the Javascript code is in a tt
> file and not js. Not a blocker, but was wondering.
I see that model being followed on many templates, added for consistency.
> 5) Sample notice
Sample notice added!
> 6) Authorised value
I've added the AV category, but no values. I suppose we could add values for
new installations, but I don't think we'd want them for existing installs being
upgraded. Let me know what you think.
>
> 7) GUI
>
> reserve.pl
> I think it would be nice if the cancellation reason only activated once a
> "del" was selected. Otherwise people might expect it to do something without
> that or expect it to also work when they cancel using "X".
It *does* work when canceling using the "X"! For that reason it is not hidden.
If you think it's simpler to not allow a reason when using the X and have it
hidden unless one of the pulldowns is marked "del" I can make that change too.
> moremember.pl/circulation.pl
> I think for context we should add "Cancellation reason:" here before the
> pull down too.
Done!
>
> Why pendingreserves, but not holds queue?
Pending reserves has a cancellation function already while the holds queue does
not.
> pendingreserves: I'd remove the bold and add : (only one string to translate
> for translators :) )
Done!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #51 from Kyle M Hall --- Created attachment 108757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108757&action=edit Bug 25534: (QA follow-up) Add colon to label on pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #50 from Kyle M Hall --- Created attachment 108756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108756&action=edit Bug 25534: (QA follow-up) Add AV category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #47 from Kyle M Hall --- Created attachment 108753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108753&action=edit Bug 25534: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #45 from Kyle M Hall --- Created attachment 108751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108751&action=edit Bug 25534: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #48 from Kyle M Hall --- Created attachment 108754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108754&action=edit Bug 25534: (QA follow-up) Add sample notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #46 from Kyle M Hall --- Created attachment 108752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108752&action=edit Bug 25534: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #49 from Kyle M Hall --- Created attachment 108755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108755&action=edit Bug 25534: (QA follow-up) Add label to reason pulldown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #41 from Kyle M Hall --- Created attachment 108747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108747&action=edit Bug 25534: Add ability to send an email specifying a reason when canceling a hold Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #43 from Kyle M Hall --- Created attachment 108749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108749&action=edit Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #42 from Kyle M Hall --- Created attachment 108748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108748&action=edit Bug 25534: Update Schema Files [DO NOT PUSH] Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #44 from Kyle M Hall --- Created attachment 108750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108750&action=edit Bug 25534: Add reason to pendingreserves.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Attachment #108477|0 |1 is obsolete|| Attachment #108478|0 |1 is obsolete|| Attachment #108479|0 |1 is obsolete|| Attachment #108480|0 |1 is obsolete|| Attachment #108481|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 108746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108746&action=edit Bug 25534: Update database Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26023] Incorrect permissions handling for cashup actions on the library level registers summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26023 --- Comment #9 from Martin Renvoize --- (In reply to Katrin Fischer from comment #8) > (In reply to Martin Renvoize from comment #2) > > Test Plan > > 1/ Setup some cash registers > > 2/ Login as a user with just the 'refund' permission Oops.. this should have been 'anonymous_refund'.. i.e. the subpermission in cash_management rather than the subpermission of accounts.. my apologies. > > I have a bit of trouble following the test plan here: > > 1-4) > My user has catalog and refund permissions. > With the patch applied, this prevents me from accessing: > http://localhost:8081/cgi-bin/koha/pos/registers.pl See above: However I do wonder if at some point the availability of this page may need/want to fall outside of the cash_management permissions or have it's own permission associated with it (one for another bug however, once I understand the possible use case) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 --- Comment #1 from Owen Leonard --- Created attachment 108745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108745&action=edit Bug 25317: Move translatable strings out of additem.js.inc This patch moves the definition of translatable strings out of additem.js.inc and into additem.js using the new JS i81n function. additem.js.inc is removed, being obsolete. To test: When creating an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when placing an order." - Apply the patch and go to Acquisitions -> Vendor -> Add to basket -> From a new (empty) record. - In the "Item" section, confirm that the buttons at the bottom of the form are correct: "Add item," "Clear," and "Add multiple items." - Click "Add multiple items." The placeholder in the revealed form field should read "Number of items to add." The corresponding button should be labeled "Add." - You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied." - Fill out the item entry form and add a number to the "multiple items" field. Click "Add." - A table of items should be displayed with "Edit" and "Delete" buttons for each new item. - Click one of the "Edit" buttons. The item form should be populated with the item's data, with an "Update item" button at the bottom. When receiving an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when receiving an order." - Go to Acquisitions -> Vendor -> Receive shipments. - Select or create an invoice. - Click "Receive" on an order which has a quantity greater than 1. - Add two items, duplicating in each at least one value which is marked as unique by the "UniqueItemFields" system preference (e.g. fill in the same barcode number for each item). - Click "Save." You should get an alert about duplicated values, and there should be an alert message on the page, "barcode 'XXX' is duplicated." - Edit one of the two items and change the barcode to one which already exists in your database. - Click "Save." An alert message should be shown on the page, "barcode 'XXX' already exists in the database." - Note: I was unable to find out how to trigger this error, "You can't receive any more items." It may be obsolete. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/additem.js for translation, e.g.: msgid "Add multiple items" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25314] Make OPAC facets collapse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Lucas Gass --- There are some issues with this patchset that I did not realize when I wrote it. Mainly related to the use of pseudo elements as checkmarks. Pseudo elements are semantically meaningless. From what I understand pseudo elements must only be used for decorative purposes only This would be an accessibility issue so I am failing QA on this until a better solution can be devised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Sally --- (In reply to Martin Renvoize from comment #10) > I've rebased and simplified the patchset. > > You will need to run the CSS build to test this. (If testing on a sandbox, > you can use the 'Build CSS' option from the 'Actions' menu) No worries, thanks for the tip - it's probably paranoia but I always use 'Build CSS' if I think the patch touches anything styling-wise. Signed off. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #108743|0 |1 is obsolete|| --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 108744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108744&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 --- Comment #10 from Martin Renvoize --- I've rebased and simplified the patchset. You will need to run the CSS build to test this. (If testing on a sandbox, you can use the 'Build CSS' option from the 'Actions' menu) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize changed: What|Removed |Added Attachment #108165|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26189] Table options on points of sale misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 Martin Renvoize changed: What|Removed |Added Attachment #108164|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 108743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108743&action=edit Bug 26189: Improve styling of datatables within fieldsets Unset label width restriction: The label width restriction within fieldsets causes issues for the datatables header. Unsetting it explicitly here resolves the line wrapping issues :) Reset margins for datatables found inside fieldsets such that the datatable properly utilises the available space and restore the default datatable label font weights. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Nick Clemens changed: What|Removed |Added Attachment #106637|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 108742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108742&action=edit Bug 17661 - Ending punctuation causes duplicate facets The current code for facets doesn't pull strip ending punctuation from facets This causes duplicate facets for terms that should be combined Sometimes series can have different punctuation depending on the field they are in Author initials punctuation should be preserved To test: 1 - Do search and pull up some records 2 - Edit some of the records to have authors like: Date, C.J. Date, C.j. Date, C.J . 3 - Edit the records to have some series statments like: 830 $aDate, C.J. ;$v5 830 $aDate, C.J. ; $v5 830 $aDate, C.J.; $v5 4 - Add some 490s to the record with first indicator 1 and series like: You wouldn't want to-- You wouldn't want to You wouldn't want to.. 5 - Search again and note you have 3 facets each for author and series 6 - Apply patch 7 - Repeat 8 - Now you get 2 facets for author, period not removed when following Upper case immediately, is otherwise 9 - Now you should have a single series facet 10 - Switch search engine to ES (index before applying patch) 11 - Note facets are separate again 12 - Reset mappings and reindex perl misc/search_tools/rebuild_elasticsearch -v -r 13 - Repeat search, facets combined as above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff --- Comment #19 from Jonathan Druart --- It needs to be backported Lucas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 Jonathan Druart changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 --- Comment #18 from Lucas Gass --- > The "span title" needs to be removed in that case :) > If we go with data-order I think we should do a big move and have only 1 way > of doing things. I am willing to help anybody who would like to work on that. If we would like to go the data-order route moving forward I would be happy to work on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #107 from Martin Renvoize --- As discussed on IRC.. we should be testing for the behaviour of an unset userenv and correctly handling it. The first followup removes the duplicate test The second followup adds a test for an undefined userenv The third followup handles the undefined userenv The fourth followup adds a test for the high fallback for when get_lostreturn_policy is called with return_branch => undef -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #106 from Martin Renvoize --- Created attachment 108741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108741&action=edit Bug 18501: (follow-up) Add fallback to ItemHomeBranch When 'RefundLostOnReturnControl' is set to 'CheckinLibrary' but return_branch is passed as undefined we should fallback to 'ItemHomeBranch' before falling back to the default rule. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 --- Comment #104 from Martin Renvoize --- Created attachment 108739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108739&action=edit Bug 18501: (follow-up) Test undefined userenv behaviour This patch adds a test to ensure that the 'Koha::Item->store' method will function when the userenv is not set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501
--- Comment #105 from Martin Renvoize ---
Created attachment 108740
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108740&action=edit
Bug 18501: (follow-up) Do not rely on userenv->{branchcode}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 Martin Renvoize changed: What|Removed |Added Attachment #108732|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 108738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108738&action=edit Bug 18501: (follow-up) Remove duplicate test The ModItem test found in t/db_dependent/Items.t was a duplciate (but slightly less functional) for the test we introduced for the *_on trigger functionality in t/db_dependent/Koha/Items.t::store The failure was a missing C4::Context mock, but the logical fix is to simply remove the duplicate test. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #83 from AgustÃn Moyano --- (In reply to Nick Clemens from comment #82) > (In reply to Nick Clemens from comment #81) > > Created attachment 108728 [details] [review] [review] > > Bug 19889: (QA follow-up) Check that exclude from local holds priority is > > set and not a blank string > > I thought it was my follow-up that messed things up so followed up here. > Seems we need to test if defined and set to something. Agustin feel free to > comment or update my follow-ups if needed Thanks Nick for catching this up.. I'll check it out, but I don't think I will need to update your follow-up. It seems ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 Lucas Gass changed: What|Removed |Added Resolution|--- |INVALID Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 --- Comment #17 from Lucas Gass --- Yes, this issue is now fixed (in my testing) because of Bug 26234, marking this one resolved. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #3 from George Williams (NEKLS) --- I agree. Consistency would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5807] Add collection code to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5807 --- Comment #3 from Christopher Davis --- (In reply to Lisette Scheer from comment #2) Hear here to what Lisette said. If an item looks like a book, acts like a book, and feels like a book, call it a book, not a "New Book" or a "History Center Material" because that is the only way we can control its circulation. Thank you. > this would be very helpful, especially if it could work something like this: > > rule: > > TYPE OR Collection Checkout Period > > BOOK 21 DAYS > LUCKY DAY 14 DAYS > > Any book that didn't have the lucky day collection type would checkout for > 21 days. Any book that did have the lucky day collection type would checkout > for 14 days. > > This was our item types could all be by the actual type of material, but we > could set different circ rules based on collections such as lucky day, new > book, new dvd, which should really be collections only for the Book and DVD > item types. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Text to go in the||Adds new column release notes||cancellation_reason to ||holds tables, used to store ||new AV value ||CANCELLATION_REASON. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Kyle M Hall changed: What|Removed |Added Summary|Add ability to send an |Add ability to send an |email specifying a reason |email specifying a reason |when canceling a hold |and store the reason when ||canceling a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Donna changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 ByWater Sandboxes changed: What|Removed |Added Attachment #108712|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 108737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108737&action=edit Bug 20502: Split URI on course detail view If there are more that one URIs for biblio or item, we should split the value. This patch reuses the same code as bug 24697. Test plan: Add one item to a course Add several URI for this item and for its biblio Show the course detail view The different URI of the item must be displayed Remove all URI for the item Show the course detail view The different URI of the biblio must be displayed Signed-off-by: Donna Bachowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26207] Compare values of system preference log entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207 --- Comment #7 from Owen Leonard --- Created attachment 108736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108736&action=edit Bug 26207: (follow-up) Remove whitespace from markup Markup indentation around log entries in the template cause extra whitespace in the diff view. Removing the markup whitespace corrects it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
