[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 --- Comment #1 from David Cook --- Created attachment 108964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108964&action=edit Bug 26285: Follow E.164 pattern for validating SMS numbers Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 3. Type in 04 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 8. Type in 04 and note no validation error 9. Type in +614 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26030] Allow to explicitly search for a hidden ILL status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26030 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26265] Makefile.PL is missing pos directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #17 from Katrin Fischer --- Can we have the simple patch pushed and fix the tests later? I believe the stables are pending release any moment now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26286] Add option to use JSON objects rather than JSON arrays for public reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26286 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > You an use the annotated operator, then you can use the names. bug 11491 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26286] Add option to use JSON objects rather than JSON arrays for public reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26286 --- Comment #2 from Katrin Fischer --- You an use the annotated operator, then you can use the names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #11 from Joonas Kylmälä --- Just a gentle reminder I would like to hear others' (especially people using this feature) thoughts on the Elasticsearch vs Wikipedia approach to this. Also have you thought about having this JavaScript code in OPACUserJS? I tried to put it there and it worked flawlessly. Would it be OK solution if we just documented the steps in wiki for example on how to add this feature to the syspref? Some potential pros & cons: Elasticsearch: + user queries stay within Koha instance, no privacy leak + tailored suggestions for the Koha database - more difficult to implement Wikipedia: + simple to implement - suggestion feature availability depends on wikipedia - search queries go to third party server +/- suggestions might provide no results / not tailored to the Koha database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26286] Add option to use JSON objects rather than JSON arrays for public reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26286 --- Comment #1 from David Cook --- Also, unless you're the writer of the report, it's impossible to know what data you're working with when using a JSON array of JSON arrays. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26286] New: Add option to use JSON objects rather than JSON arrays for public reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26286 Bug ID: 26286 Summary: Add option to use JSON objects rather than JSON arrays for public reports Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At the moment, /cgi-bin/koha/svc/report outputs a JSON array of JSON arrays. It would be better to output a JSON array of JSON objects. Currently, you have to know the index position of the column you want. If you change your report, you can easily break your API consumer logic. In the future, you could use the column name as the object key. This means that you could update your report with a new column, and so long as you keep the other column names the same, your existing API consumer would work fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 David Cook changed: What|Removed |Added Blocks||26285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 [Bug 26285] Use country code + number (E.164) validation for SMS numbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 David Cook changed: What|Removed |Added Depends on||22594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 [Bug 22594] Validate SMS messaging numbers using the E.164 format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26285] New: Use country code + number (E.164) validation for SMS numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Bug ID: 26285 Summary: Use country code + number (E.164) validation for SMS numbers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com According to the E.164 standard, a phone number must be a maximum of 12 digits plus a 1-3 digit country code for a maximum of 15 digits. For North America, that would look like +1 306 555 (11 total digits) or 306 555 (10 digits). For Australian phone numbers, that looks like +61 2 (11 total digits) or 02 (10 digits). Unfortunately, since Bug 22594, Australian phone numbers without a country code aren't validating because they start with a 0. Further reading: https://en.wikipedia.org/wiki/E.164 https://www.itu.int/rec/T-REC-E.164/ https://en.wikipedia.org/wiki/List_of_country_calling_codes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #9 from David Cook --- Unfortunately, this doesn't seem to closely follow E.164, and it actually breaks validation for any Australian phone number that doesn't have a country code (e.g. 02 ), since this patch doesn't let a phone number start with a 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Attachment #108959|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #57 from David Cook --- (In reply to Martin Renvoize from comment #56) > Ping :) I don't really want to work on this again, but it would be a good thing to have. I'll put it on the list again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 --- Comment #5 from David Cook --- (In reply to Nicholas van Oudtshoorn from comment #3) > (Having said that, with things manually patched, everything works great! We > are able to use the API to create student accounts from our centralised > student management system (creates google,local computer and koha accounts). > The only thing that is missing from the API is the ability to upload patron > photos. At some point, I should get around to adding a bug report about > that!) I suspect that it might be working as expected but not working correctly. But would need more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 --- Comment #4 from David Cook --- (In reply to Nicholas van Oudtshoorn from comment #0) > Just spent a whole bunch of time on this - and think I have a solution. The > rest api, is looking for the authorization header - but for some reason, > koha is rewriting this header to be "x-koha-authorization". > What do you mean by "koha is rewriting this header to be "x-koha-authorization". Your API client is sending the Authorization header. It sounds like your API client is putting the Authorization header into "x-koha-authorization" instead of "Authorization". Sounds to me like a bug with your API client and not Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #6 from David Cook --- (In reply to Ulrich Kleiber from comment #5) > I don't now the real reason for this bug, but without Plack there is no > ProxyError and no Timeout. With 6000 patrons, the script runs for > approximately 8 minutes. That's interesting. I would expect Apache httpd to timeout after 5 minutes. How do you have Koha installed? Can you verify your Apache configuration? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 Katrin Fischer changed: What|Removed |Added Attachment #106904|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 108963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108963&action=edit Bug 25113: Refactor CirculationRules.t when testing scope combinations We used to test rule scopes by explicitly defining each combination. When adding new scopes, it is much easier if these tests are auto- generated for you so that you don't have to repeat similar code. This patch removes those "duplicates" and adds a method that returns test cases for each scope as follows: branchcode categorycode itemtype __ branchcode categorycode itemtype branchcode categorycode * branchcode *itemtype branchcode ** * categorycode itemtype * categorycode * * *itemtype * ** And automatically extends the test when new scopes are added. This also obsoletes the "Get effective issuing rule in correct order" test in t/db_dependent/Koha/IssuingRules.t To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer --- I am sorry, but the tests are not passing, can you please have a look? Test Summary Report --- t/db_dependent/Koha/Libraries.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 8. t/db_dependent/Illrequests.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 13 tests but ran 8. Without the patches I still have one failing test - not ok 10 - Checking out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- When I run the reindex as suggested, I have a warn that I haven't without the patches: $ misc/search_tools/rebuild_elasticsearch.pl -v -d -r Use of uninitialized value $authtypecode in hash element at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch.pm line 542. Can't call method "tag" on an undefined value at /home/vagrant/kohaclone/C4/Heading.pm line 71. I tried to follow the test plan, but the linking on my "Waterworks" record didn't happen :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #30 from Katrin Fischer --- Created attachment 108962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108962&action=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer --- Hi Nick, can you please rebase and adjust the test plan in the commit message? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- 2 things to note, but I think not blocker: - When a basket is created, a "MODIFY_BASKET_HEADER" is logged at the same time - Deleting a basket is not logged yet - The info column is not logged here, so the information known is the basket affected and the users involved, but no information about the change itself. I think this is worth knowing, but could be easily extended later. I see that the question from Jonathan in comment#28 remained unanswered - can you please check, so we can move this forward? Testing looks good so far. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26284] New: Lu Buliq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26284 Bug ID: 26284 Summary: Lu Buliq Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: zulfikar34...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 108961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108961&action=edit Xnzul Gans -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26284] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26284 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|Lu Buliq|SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26246] Create a display area to show pending requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26246 Alvaro Cornejo changed: What|Removed |Added CC||cornejo.alv...@gmail.com --- Comment #3 from Alvaro Cornejo --- Created attachment 108960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108960&action=edit Example pendings on last-borrower As per comment #2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #7 from Alvaro Cornejo --- Comment on attachment 108959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108959 Example pendings on last-borrower Sorry wrong bug!!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 Alvaro Cornejo changed: What|Removed |Added CC||cornejo.alv...@gmail.com --- Comment #6 from Alvaro Cornejo --- Created attachment 108959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108959&action=edit Example pendings on last-borrower As per comment #3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26246] Create a display area to show pending requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26246 --- Comment #2 from Alvaro Cornejo --- Hi still jiggling with this. I didn´t found how to get a window for pendings similar to last-borrower so, for testing purposes, I´ve added pending codes to last-borrower.inc as: Last Patron Article Resquests: [% pending_article_requests %] Suggestions pending approval: [% pendingsuggestions | html %] Comments pending approval: [% pendingcomments | html %] Tags pending approval: [% pendingtags | html %] You can see the result on the attached capture. For now, those are fixed; however, an if(PendingVar) can be added to display each pending if there are any. This still require to add, to each page where we want to display the pending, the correspoding code to get the pendings qty. I´m still unable to know/understand how to handle user permissions. BTW, does a feature like this might be accepted? Haven´t receive any comment yet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #17 from Katrin Fischer --- Please also check the comments! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #16 from Katrin Fischer --- I just noticed that there is a dependent bug, that needs to be tested first, but worth noting, that this does no longer apply on top: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24190: Add acquisition logging error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt). error: could not build fake ancestor Patch failed at 0001 Bug 24190: Add acquisition logging The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24190-Add-acquisition-logging-mCG2UX.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- I am not quite sure if that works alright, so adding my test plan: 1) Check out an item to any patron with checkbox "auto-renewal" selected The circulation rule is NOT set up for auto-renewal. 2) Place a hold on the record 3) Check out an item with circulation rule auto-renewal 4) Place a hold on the record too The items show as scheduled for auto-renewal, but it only shows (on hold) in staff, not in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21189] GDPR: Log all CRUD actions on patron data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21189 Reyy kakeru changed: What|Removed |Added CC||asukoe...@gmail.com --- Comment #2 from Reyy kakeru --- Created attachment 108958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108958&action=edit Cioo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9251] Add option to print checkin and renewal quick slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251 Reyy kakeru changed: What|Removed |Added CC||asukoe...@gmail.com --- Comment #7 from Reyy kakeru --- Created attachment 108957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108957&action=edit Ok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 813] OPAC lists should store comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813 Reyy kakeru changed: What|Removed |Added CC||asukoe...@gmail.com --- Comment #7 from Reyy kakeru --- Created attachment 108956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108956&action=edit Cok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1091] Do a second sarch with shorter terms if there are no results found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Reyy kakeru changed: What|Removed |Added CC||asukoe...@gmail.com --- Comment #3 from Reyy kakeru --- Created attachment 108955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108955&action=edit Cok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #107831|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 108953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108953&action=edit Bug 25033: (follow-up) Don't delete branchcode key from suggestion_ref Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #39 from Katrin Fischer --- Created attachment 108954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108954&action=edit Bug 25033: Fix number of tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104357|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 108951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108951&action=edit Bug 25033: Improve JS code a bit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104161|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108949&action=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104160|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 108948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108948&action=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104162|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 108950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108950&action=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104940|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 108952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108952&action=edit Bug 25033: (follow-up) Deal with 'Any' branch and don't show dropdown if organized by library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32 from Katrin Fischer --- I really like this. This is a great improvement for a reoccurring support question I'd love to get rid of! The only thing that gets me thinking a bit is that there is a bit of code repeat between the start page and the acquisition home page right now. But I'd not want this to be held up much longer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #63 from Katrin Fischer --- I repeated the test with a serial, as they show the link on master: Zebra, UseControlNumber = Don't. On master: 1) Search for Gairm in test data 2) New > Add new child record 3) Check 773$w is set 4) Add 245 and other mandatory fields, save 5) Verify link back and forth between Analytics: and In: works. Switch UseControlnumber = Do 6) Links back and forth work. Switch to Elasticsearch, UseControlnumber = Don't 7) Links back and forth work. Switch to UseControlnumber = Do 8) In: link works, analytics link doesn't (NOT OK) rcn:11388674 and (bib-level:a or bib-level:b) rcn: alone works. bib-level:a alone works. Something wrong with the search syntax for Elasticsearch? Repeating the test on the analytics branch: 9) Zebra, UseControlNumber = Don't: Works 10) Zebra, UseControlNumber = Do: Works (now) 11) Elasticsearch, UseControlNumber = Don't: Works 12) Elasticsearch, UseControlnumber = Do: Link disappears (NOT OK) After retesting I think the problem last night was either Elasticsearch being active or the record not being properly reindexed when I tried. Result: UseControlNumber doesn't work with Elasticsearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
