[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

David Nind  changed:

   What|Removed |Added

 Attachment #110517|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 110525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110525=edit
Bug 11223: Fix the ind1 semantics for 785 in the staff interface

For 780 and 785 the field should not display when the first indicator
is 1. After checking the code, I found that 785 in staff was missing.
This patches fixes that one.

To test:
- Catalog a record with 785 and 780 fields with one 1st indicator set to
  0 and another to 1.
- Verify in staff and OPAC detail pages that only the fields with 0 display.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

David Nind  changed:

   What|Removed |Added

 Attachment #110486|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 110524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110524=edit
Bug 26504: Remove the use of jquery.checkboxes plugin from checkout notes page

This patch removes the inclusion of the jquery.checkboxes plugin from
the checkout notes page. It is unused.

To test, apply the patch and confirm that the AllowCheckoutNotes system
preference is enabled.

- Go to Circulation -> Checkout notes.
- Confirm that the "Select all" and "Clear all" links work correctly.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

David Nind  changed:

   What|Removed |Added

 Attachment #110518|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 110523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110523=edit
Bug 13625: Change messaging preferences descriptions according to
RenewalSendNotice

Sending out renewal notices depends on the RenewalSendNotice and the
patron having the checkout notice checked in their messaging
preferences.

To test:
- Apply patch
- Take a look at the messaging preferences table on the following pages:
  - OPAC > patron account > your messaging tab
  - Staff interface > patron account > details tab
  - Staff interface > patron account > edit patron
- Toggle the RenewalSendNotice preferences
  - The label on the last notice should switch between "Item checkout"
and "Item checkout and renewal" depending on the pref setting

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21818] Don't use AutoCommit flag in stage-marc-import.pl

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #10 from David Cook  ---
(In reply to Katrin Fischer from comment #8)
> You have to look at the full example in the links I posted. 3 lines:
> 
> 
> 
> 
> 
> So yes, but then it uses that form to remove the diacritics:
> https://www.compart.com/en/unicode/category/Mn

Ahhh right. I should've been more thorough.

I was thinking recently about how Zebra ICU has been seen as inferior to
Elasticsearch ICU on the listserv. 

Looking at
ftp://ftp.software.ibm.com/software/globalization/icu/3.6/icu-3_6-userguide.pdf,
it looks like ICU actually originated in Java (ICU4J) and was later ported to
C++ and C (ICU4C). 

According to
https://wiki.koha-community.org/wiki/Record_Indexing_and_Retrieval_Options_for_Koha,
the Zebra use of libicu is inferior to Lucence ICU which uses ICU4J. There's no
evidence given for the claim, but it seems believable (especially considering
global prominence of Solr and Elasticsearch).

Looking at https://lucene.apache.org/core/4_4_0/analyzers-icu/index.html, it
seems that writing systems can use dictionary based algorithms (for systems
like Thai script, Chinese, etc). That explains a lot. I know a bit of Chinese,
and I've wondered how indexers could handle such a context-dependent
language...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965

--- Comment #17 from David Cook  ---
(In reply to Kyle M Hall from comment #16)
> This is a very interesting concept, but completely non-standard and I would
> not expect to see any adoption of it or even much use outside of you
> specific needs. NCIP has pretty much supplanted SIP for this use case ( NISO
> is still trying to figure out what to do with SIP & NCIP now that it
> controls both specifications ).
> 
> I think this would be much better suited as an API plugin.

This sounds reasonable to me as well. 

I think that Lari has already implemented this locally (in testing) at
Koha-Suomi in Finland, but I think that they'd probably benefit from doing it
as an API plugin too. 

I suggested sharing the work on Bugzilla anyway though in case anyone else
finds the work interesting. It also gives a chance to get some community
feedback. 

Lari, is there a reason the vendor isn't using NCIP? (I admit that I've never
used it so didn't even think of it. Cheers, Kyle!)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acqisition advanced search

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503

--- Comment #2 from Katrin Fischer  ---
Created attachment 110522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110522=edit
Bug 26503: Add unit tests

Run
  prove t/db_dependent/Acquisition.t

Verify all tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acqisition advanced search

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
Version|unspecified |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acqisition advanced search

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503

--- Comment #1 from Katrin Fischer  ---
Created attachment 110521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110521=edit
Bug 26503: Add limit for standing orders to acq advanced search

This allows to filter on standing orders on the acq advanced search
checkbox. For this purpose a new checkbox is shown behind the order
status search option.

As both not yet ordered and standing orders have the status
'new' or partially received internally, this seems like a good
placement as it will help distinguish these cases clearly.

new + standing order = standing order, but nothing received yet
partially received + standing order = active standing order
all status + standing order = all standing orders

To test:
- Create some baskets with at least one order, some 'standing' and
  others not
- In the top toolbar choose tab Orders search > Advanced search
- Make some searches with and without the new 'Standing order' option
- Verify the right orders are found
- In the search results standing orders will now show with the
  status + (standing order).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acqisition advanced search

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

--- Comment #1 from Katrin Fischer  ---
Created attachment 110518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110518=edit
Bug 13625: Change messaging preferences descriptions according to
RenewalSendNotice

Sending out renewal notices depends on the RenewalSendNotice and the
patron having the checkout notice checked in their messaging
preferences.

To test:
- Apply patch
- Take a look at the messaging preferences table on the following pages:
  - OPAC > patron account > your messaging tab
  - Staff interface > patron account > details tab
  - Staff interface > patron account > edit patron
- Toggle the RenewalSendNotice preferences
  - The label on the last notice should switch between "Item checkout"
and "Item checkout and renewal" depending on the pref setting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging table

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

Katrin Fischer  changed:

   What|Removed |Added

Summary|RenewalSendNotice setting   |RenewalSendNotice setting
   |should be reflected in  |should be reflected in
   |messaging   |messaging table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

Katrin Fischer  changed:

   What|Removed |Added

Summary|RenewalSendNotice setting   |RenewalSendNotice setting
   |should be reflected in  |should be reflected in
   |messaging table |messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13625] RenewalSendNotice setting should be reflected in messaging

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

--- Comment #2 from Katrin Fischer  ---
Created attachment 110517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110517=edit
Bug 11223: Fix the ind1 semantics for 785 in the staff interface

For 780 and 785 the field should not display when the first indicator
is 1. After checking the code, I found that 785 in staff was missing.
This patches fixes that one.

To test:
- Catalog a record with 785 and 780 fields with one 1st indicator set to
  0 and another to 1.
- Verify in staff and OPAC detail pages that only the fields with 0 display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

Katrin Fischer  changed:

   What|Removed |Added

Summary|Incorrect ind1 semantics|Incorrect ind 1 semantics
   |for MARC21 785  |for MARC21 785 on the
   ||detail page in staff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

--- Comment #37 from Aleisha Amohia  ---
Created attachment 110516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110516=edit
Bug 12224: (follow-up) Access old_issues table when editing notice

This QA follow-up allows access to the old_issues table when editing the
notice in Tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind1 semantics for MARC21 785

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|15437   |
 Depends on||15437


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437
[Bug 15437] MARC21: Show $i for 780/785
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||11223
 Depends on|11223   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223
[Bug 11223] Incorrect ind1 semantics for MARC21 785
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11223] Incorrect ind1 semantics for MARC21 785

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||15437


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437
[Bug 15437] MARC21: Show $i for 780/785
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||11223


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223
[Bug 11223] Incorrect ind1 semantics for MARC21 785
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110492|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 110515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110515=edit
Bug 26414: Unable to export Withdrawn status using CSV profile

When using CSV profiles to export MARC records, it is impossible to export the
withdrawn status. I suspect it is because withdrawn is in 952$0 and 0 is
considered null rather than an actual 0.

Test Plan :
1) Go to Tools > CSV profiles
2) Click on New CSV profile
3) Enter a profile name (ex. Simple record)
4) In the Profile MARC fields field enter the following (for MARC21)
245a|100a|952o|9520
5) Save your profile
6) Go to Search and search for something
7) Add a couple of things in your cart
8) Go to your cart
9) Click on Download and choose your CSV profile
10) Open the file and notice the 9520 column contains the whole of the 952
field and not just the withdrawn status
11) Apply patch
12) Redo steps 9) and 10)

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #48 from Arthur Suzuki  ---
Test patch works as expected (there is one test which doesn't pass when test
patch is applied alone).
However the test patch seems to change things in C4/Circulation as well,
is this due to a change in the db structure,
and shouldn't this change be in the main patch anyway?
Other than this comment, happy to signoff :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #24 from Katrin Fischer  ---
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/StockRotationItems.t
t/db_dependent/StockRotationItems.t .. 5/8 # Looks like you planned 6 tests
but ran 5.

#   Failed test 'Tests for needs_advancing.'
#   at t/db_dependent/StockRotationItems.t line 229.
Can't locate object method "clone" via package "0" (perhaps you forgot to load
"0"?) at /usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Duration.pm line 326.
# Looks like your test exited with 255 just after 6.
t/db_dependent/StockRotationItems.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 3/8 subtests 

Test Summary Report
---
t/db_dependent/StockRotationItems.t (Wstat: 65280 Tests: 6 Failed: 1)
  Failed test:  6
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 6.
Files=1, Tests=6,  3 wallclock secs ( 0.02 usr  0.01 sys +  2.64 cusr  0.25
csys =  2.92 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #110485|0   |1
is obsolete||

--- Comment #47 from Arthur Suzuki  ---
Created attachment 110514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110514=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26481] Add Koha::Item::Transfer->in_transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26481

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25941] Reindent Upload local cover image page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26481] Add Koha::Item::Transfer->in_transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26481

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110301|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 110513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110513=edit
Bug 26481: Add Koha::Item::Transfer->in_transit method

This method returns a boolean representing the in_transit state of the
transfer.

Test plan
1/ Run the included tests

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receive method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110399|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 110512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110512=edit
Bug 25767: (QA follow-up) receipt -> receive

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receive method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110398|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 110511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110511=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receive method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110397|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 110510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110510=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receive method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110297|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 110508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110508=edit
Bug 25757: Add Koha::Item::Transfer->transit method

Test plan
1/ Run the included unit tests

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110298|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 110509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110509=edit
Bug 25757: Add unit tests for item relation

Test plan
1/ Run the unit test

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receive method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add |Add
   |Koha::Item::Transfer->recei |Koha::Item::Transfer->recei
   |pt method   |ve method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110296|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 110507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110507=edit
Bug 25757: Add item relation to Koha::Item::Transfer

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110393|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 110503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110503=edit
Bug 25755: (QA follow-up) Clarify POD and parameters

This patch removes a FIXME that signified possible future work and also
updates the POD and optional parameters to more clearly specify their
function.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110430|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 110505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110505=edit
Bug 25755: Fix typo in POD

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110466|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 110506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110506=edit
Bug 25755: (follow-up) Fix unit test

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110394|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 110504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110504=edit
Bug 25755: Add Unit tests for update get_transfer

We updated Koha::Item->get_transfer here to account for the new
daterequested field availability. It is now possible to set requested
without setting datesent simultaneiously.. as such we need to update
get_transfer to ensure we always return the right transfer (either the
one 'in transit' or the oldest request first.

This patch update the unit tests to test for this.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110392|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 110502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110502=edit
Bug 25755: Add Koha::Item->request_transfer method

This patch adds the request_transfer method to the Koha::Item object.
The new method requires `to` and `reason` parameters and will throw an
exception if an active transfer request is found on the item.

Test plan
1/ Run the included updated tests in t/db_dependent/Koha/Item.t
2/ Verify the tests pass
3/ Signoff

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #95 from Katrin Fischer  ---
Created attachment 110501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110501=edit
Bug 14242: (QA follow-up) Fix buttons for new bootstrap version

Stole the mark-up from bug 26478.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110145|0   |1
is obsolete||

--- Comment #91 from Katrin Fischer  ---
Created attachment 110497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110497=edit
Bug 14242: (follow-up) Translateable js strings, $raw filter

Sponsored-by: Region Halland
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110148|0   |1
is obsolete||

--- Comment #94 from Katrin Fischer  ---
Created attachment 110500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110500=edit
Bug 14242: (follow-up) Adding publication year hint and fix js translations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110144|0   |1
is obsolete||

--- Comment #90 from Katrin Fischer  ---
Created attachment 110496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110496=edit
Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes

To test, enter a valid ISBN complete with -
eg
978-1-78416-110-1

The search should still work

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110143|0   |1
is obsolete||

--- Comment #89 from Katrin Fischer  ---
Created attachment 110495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110495=edit
Bug 14242: (follow-up) Change the icon to words

Fix a bug that meant it would search on empty ISBN

To test
1. Fill in a valid ISBN (Book data is correctly loaded)
2. Clear the ISBN from the field (Book data is correctly removed)
3. Tab away from the empty ISBN field: Data is loaded for a title
  "ISBN 0-9690745-2-2"
4. Apply patch
5. Repeat 1,2 and 3 notice a search is no longer done

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110146|0   |1
is obsolete||

--- Comment #92 from Katrin Fischer  ---
Created attachment 110498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110498=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110147|0   |1
is obsolete||

--- Comment #93 from Katrin Fischer  ---
Created attachment 110499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110499=edit
Bug 14242: Styling of buttons, get copyright date, fixing plugin comment

And other code-y bits. Addressing comments in Comment 59.

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110142|0   |1
is obsolete||

--- Comment #88 from Katrin Fischer  ---
Created attachment 110494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110494=edit
Bug 14242: (follow up) renaming syspref

OPACAutoFill -> OPACSuggestionAutoFill

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110141|0   |1
is obsolete||

--- Comment #87 from Katrin Fischer  ---
Created attachment 110493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110493=edit
Bug 14242: Use ISBN-field to automatically fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s) into
search fields for Google Books API and automatically fills requested fields
with
search result.

Use in OPAC purchase suggestions to automatically fill out fields when entering
ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACAutoFill"
3. Log into OPAC and go to purchase suggetions page
4. Write a valid ISBN into the ISBN field and press the edit icon next to the
   field, or unfocus the field.
5. Title, Author, Publisher and Item Type fields should now be filled
   automaticly.
6. Press "undo" to undo - should restore all changed fields to original values

Tested all patches together, works as expected.
Signed-off-by: Marc 

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

David Nind  changed:

   What|Removed |Added

 Attachment #110479|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 110492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110492=edit
Bug 26414: Unable to export Withdrawn status using CSV profile

When using CSV profiles to export MARC records, it is impossible to export the
withdrawn status. I suspect it is because withdrawn is in 952$0 and 0 is
considered null rather than an actual 0.

Test Plan :
1) Go to Tools > CSV profiles
2) Click on New CSV profile
3) Enter a profile name (ex. Simple record)
4) In the Profile MARC fields field enter the following (for MARC21)
245a|100a|952o|9520
5) Save your profile
6) Go to Search and search for something
7) Add a couple of things in your cart
8) Go to your cart
9) Click on Download and choose your CSV profile
10) Open the file and notice the 9520 column contains the whole of the 952
field and not just the withdrawn status
11) Apply patch
12) Redo steps 9) and 10)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

David Nind  changed:

   What|Removed |Added

 Attachment #110443|0   |1
is obsolete||

--- Comment #47 from David Nind  ---
Created attachment 110490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110490=edit
Bug 14367: (follow-up) Fixing merge conflicts...

...and other fixes to make patch work.

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

David Nind  changed:

   What|Removed |Added

 Attachment #110442|0   |1
is obsolete||

--- Comment #46 from David Nind  ---
Created attachment 110489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110489=edit
Bug 14367: Add MARC record history

This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.

The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.

If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.

Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.

At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.

The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.

Documentation of the functions/methods are also needed.

Icon is ugly and needs to be improved.

Sponsored-By: Halland County Library & Catalyst IT

Test plan:
* Run updatedatabase.pl
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
  a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
  to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
  clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

David Nind  changed:

   What|Removed |Added

 Attachment #110444|0   |1
is obsolete||

--- Comment #48 from David Nind  ---
Created attachment 110491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110491=edit
Bug 14367: (follow-up) Rebasing to make patch work on master

Run through test plan and confirm everything still works as expected.

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25941] Reindent Upload local cover image page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #7 from Katrin Fischer  ---
Hi Owen, missing the first patch - git bz attach fail?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110456|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 110488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110488=edit
Bug 25771: Allow the user to sort checkouts by the renew column in the OPAC

This patch makes it possible for the logged-in OPAC user to sort their
checkouts by the number of renewals they have remaining on their
checkouts.

To test, apply the patch and log in to the OPAC as a user with multiple
checkouts. To fully test the patch's functionality the user's checkouts
should have a varying number of renewals available.

On the "your summary" page, confirm that the "Renew" column is now
sortable and that it sorts correctly by the number of renewals left on
each checked-out item.

Signed-off-by: Henry Bolshaw 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26497] "Hide all columns" throws Javascript error on aqplan.pl

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26497

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110465|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 110487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110487=edit
Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl

This patch updates the JavaScript for checking and unchecking checkboxes
on the Acquisitions planning page so that it doesn't require the
checkboxes plugin.

To test, apply the patch and go to Administration -> Budgets -> Budget
details -> Planning.

On the planning page, test the "Show all columns" and "Hide all columns"
checkboxes. They should work correctly to show and hide the correct
columns.

Signed-off-by: Henry Bolshaw 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26497] "Hide all columns" throws Javascript error on aqplan.pl

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26497

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---
It was recently decided that we will no longer support IE. Firefox, Chrome or
Edge are recommended. See also: bug 26305

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

Owen Leonard  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

--- Comment #1 from Owen Leonard  ---
Created attachment 110486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110486=edit
Bug 26504: Remove the use of jquery.checkboxes plugin from checkout notes page

This patch removes the inclusion of the jquery.checkboxes plugin from
the checkout notes page. It is unused.

To test, apply the patch and confirm that the AllowCheckoutNotes system
preference is enabled.

- Go to Circulation -> Checkout notes.
- Confirm that the "Select all" and "Clear all" links work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||alexis.ripe...@inlibro.com

--- Comment #46 from Alexis Ripetti  ---

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.
I also changed one thing that seemed weird to me in the C4/Circulation.pm file.

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

And finally:
5) prove -v t/db_dependent/Circulation.t


All the tests should now pass.

Waiting for your comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #106809|0   |1
is obsolete||

--- Comment #45 from Alexis Ripetti  ---
Created attachment 110485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110485=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039

--- Comment #18 from David Nind  ---
(In reply to Tomás Cohen Arazi from comment #15)
> Naw, it was just I forgot to commit the updated dates to the DB.

It all works now and have signed off!

One minor thing I noticed was that in the preview table listing changes to be
made it shows the new due date as (for example) 09/21/2020 00:00

When applied the new due date is shown as 09/21/2020 23:59 on the item record
and in the patron's circulation history.

This may or may not be an issue...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Alexander Borkowski  changed:

   What|Removed |Added

 CC||alexander.borkow...@kau.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668

Alexander Borkowski  changed:

   What|Removed |Added

 CC||alexander.borkow...@kau.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006

Owen Leonard  changed:

   What|Removed |Added

 Depends on||26504


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504
[Bug 26504] Remove the use of jquery.checkboxes plugin from checkout notes page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26504] New: Remove the use of jquery.checkboxes plugin from checkout notes page

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26504

Bug ID: 26504
   Summary: Remove the use of jquery.checkboxes plugin from
checkout notes page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 26006

The jquery.checkboxes plugin is included on the checkout notes page but is
unused. It should be removed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006
[Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039

David Nind  changed:

   What|Removed |Added

 Attachment #110460|0   |1
is obsolete||

--- Comment #17 from David Nind  ---
Created attachment 110484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110484=edit
Bug 25039: (follow-up) Don't forget to store the updated checkout

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039

David Nind  changed:

   What|Removed |Added

 Attachment #110073|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 110483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110483=edit
Bug 25039: Move new due date calculation to Koha::Checkout

This is a follow-up patch of bug 25020.

This patch adds a new method Koha::Checkout->shift_due_date that accepts
the same parameters we provide in the form. It catches bad scenarios
(type errors, passing both parameters when only one is accepted, and so
 on). Date manipulation is tested so time is kept and resulting dates
are correct.

The controller script is cleaned a bit to use the introduced method.

I do this because:
- We really need tests for this and doing it with selenium is no-end
- I see a use for this new method for encapsulating behaviours, for
  example we might want to add Calendar support for the 'days' use case,
  and having the method here assures we will have tests, etc.

To test:
1. Apply this patches
2. Repeat the original test plan
=> SUCCESS: Everything works as expected
3. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Checkout.t
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #66 from Tomás Cohen Arazi  ---
Thanks Andrew, the last version of the patch should cover it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #110478|0   |1
is obsolete||

--- Comment #65 from Tomás Cohen Arazi  ---
Created attachment 110482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110482=edit
Bug 20212: Use API to render orders datatable

This patch makes the pending orders datatable render using the API
instead of hte old controller script. It implements native server-side
pagination thanks to the API and the datatables wrapper.

On polishing it, we found that data can contain many null values, and it
got dirtier in the process.

This code with all the checks that are done on the data is the result of
testing this dev with real-life production databases, huge ones with
thousands of orderlines.

To test:
1. You should compare the behaviour between this table, and the original
   one in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

David Nind  changed:

   What|Removed |Added

 Attachment #110439|0   |1
is obsolete||

--- Comment #18 from David Nind  ---
Created attachment 110481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110481=edit
Bug 15436: (follow-up) Fix separator for a single 440 in staff

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

David Nind  changed:

   What|Removed |Added

 Attachment #110304|0   |1
is obsolete||

--- Comment #17 from David Nind  ---
Created attachment 110480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110480=edit
Bug 15436: Use semicolon between series name and volume

MARC21 dictates that we should be using a ; before $v in 440, 490,
810, 811 and 830.

This patch also introduces some additional changes to unify formatting
between the various options for cataloguing series:

- The separator between multiple series is switched form ; to the
  now commonly used | with a class for easy change of formatting.
- There was some missing logic that prevented the separator to show
  up correctly between traced and untraced series.
- For some series $v was included in the link for others not. Now
  $v always appears as text and only $a is linked, as this is what
  we actually search for.

To test this:
- You should be cataloguing multiple series in different ways, using
  - deprecated 440 (still present in old data)
  - 490, Ind. 1 = empty or 0 = not traced
  - 490, Ind. 1 = 1 = traced in combination with an 8xx field

Example (you should try a different combination!)
440 _ _ $aFirst series
490 _ _ $aSecond series ;$v1
490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display)
830 _ _ $aThird series ;$v1

Without patch:
Series: First Series; Second series ; 1Third series: 1

With patch:
Series: First series | Second series ; 1 | Third series ; 1

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050

Marcy Dunning  changed:

   What|Removed |Added

 CC||libr...@crmm.org

--- Comment #12 from Marcy Dunning  ---
We have the same problem with basic searches on names pulling up donors as well
as authors. While users can restrict the searches by limiting them to the
author field, we want to make the OPAC as easy as possible to use. In some
cases we have donors who have given hundreds of items, making a search on that
name very confusing. Thanks for working on this.
Marcy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

--- Comment #8 from Alexis Ripetti  ---
(In reply to Katrin Fischer from comment #5)
> Hi Alexis,
> 
> I believe the tests may need a bit more work to run on different
> installations:

Hi Katrin,
I reseted the test that I had changed.
The tests should now pass on your installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

--- Comment #7 from Alexis Ripetti  ---
(In reply to didier from comment #2)
> hi
> 
> Why not just a plain
>   my $subfieldtag = $2;
> 
> and removing the WIP comment with the previous line?
> 
> Regards
> Didier

Hi,
I fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #110132|0   |1
is obsolete||

--- Comment #6 from Alexis Ripetti  ---
Created attachment 110479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110479=edit
Bug 26414: Unable to export Withdrawn status using CSV profile

When using CSV profiles to export MARC records, it is impossible to export the
withdrawn status. I suspect it is because withdrawn is in 952$0 and 0 is
considered null rather than an actual 0.

Test Plan :
1) Go to Tools > CSV profiles
2) Click on New CSV profile
3) Enter a profile name (ex. Simple record)
4) In the Profile MARC fields field enter the following (for MARC21)
245a|100a|952o|9520
5) Save your profile
6) Go to Search and search for something
7) Add a couple of things in your cart
8) Go to your cart
9) Click on Download and choose your CSV profile
10) Open the file and notice the 9520 column contains the whole of the 952
field and not just the withdrawn status
11) Apply patch
12) Redo steps 9) and 10)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile

2020-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >