[Koha-bugs] [Bug 26509] Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 David Nind changed: What|Removed |Added Attachment #110573|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110574=edit Bug 26511: [19.11.x] Remove PatronSelfRegistrationConfirmEmail from opac.pref Test plan: 1. In 19.11 search for PatronSelfRegistrationConfirmEmail and you'll see the sys pref 2. Apply patch 3. System pref should be gone Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26322] REST API plugin authorization is not checked anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26322 Aleisha Amohia changed: What|Removed |Added Version(s)||20.05.04, 19.11.10 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26322] REST API plugin authorization is not checked anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26322 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable --- Comment #28 from Lucas Gass --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26322] REST API plugin authorization is not checked anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26322 Lucas Gass changed: What|Removed |Added Group|Koha security | Component|Koha|Architecture, internals, ||and plumbing Product|Koha security |Koha Status|Passed QA |Pushed to stable Version|unspecified |master --- Comment #27 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 --- Comment #1 from Lucas Gass --- Created attachment 110573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110573=edit Bug 26511: [19.11.x] Remove PatronSelfRegistrationConfirmEmail from opac.pref Test plan: 1. In 19.11 search for PatronSelfRegistrationConfirmEmail and you'll see the sys pref 2. Apply patch 3. System pref should be gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26511] New: PatronSelfRegistrationConfirmEmail preference shows up 19.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26511 Bug ID: 26511 Summary: PatronSelfRegistrationConfirmEmail preference shows up 19.11 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In 19.11 if you search for PatronSelfRegistrationConfirmEmail in system preferences you will find it. This new system preference was NOT backported to 19.11. This seems to be a rebasing error: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=083ce15dee7b7108a3103c2d4c90fca8df28230b;hp=7c0b9d9108b5e63d0c1ee6a6438f453fec136656 This should be removed from 19.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #153 from Michal Denar --- Hi Nick, awesome work. Patches working if I follow test plan. But sometimes I can't make match with local authority and link if: - $x (650) or - $v is filled in biblio record. If I'll clear $v and try to autolink, link wil be created without problem. Is it correct behaviour? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #152 from Michal Denar --- Created attachment 110572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110572=edit Bug 11299: (follow-up) correct link Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #150 from Michal Denar --- Created attachment 110570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110570=edit Bug 11299: (follow-up) Correct rebase errors and add message class to dialog Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #149 from Michal Denar --- Created attachment 110569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110569=edit Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update Removed my from variables in test Undid stray line deletions Undid adding 1; to test file Fix CSS replace command Update license Fix spelling Signed-off-by: Nick Clemens Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #151 from Michal Denar --- Created attachment 110571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110571=edit Bug 11299: (follow-up) Skip fields with no 9 subfields To test: 1 - Disable the 'thesaurus' for a controlled field like 600a or 650a 2 - Edit a record and put random data in this field 3 - Try to link, get a JS error 4 - Apply patch 5 - Repeat 6 - No more error, field is not linked (as it has no $9 subfield) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar changed: What|Removed |Added Attachment #110553|0 |1 is obsolete|| Attachment #110554|0 |1 is obsolete|| Attachment #110555|0 |1 is obsolete|| Attachment #110556|0 |1 is obsolete|| Attachment #110557|0 |1 is obsolete|| --- Comment #148 from Michal Denar --- Created attachment 110568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110568=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : 1 - In your system preferences set: AutoCreateAuthorities: don't generate BiblioAddsAuthorities: don't allow 2 - Go to the Cataloging -> New record (koha/cataloguing/addbiblio.pl) Ensure you are using the basic editor 3 - Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." 4 - Add random informations in field 600$a of the biblio record. 5 - Click the "Link authorities automatically" button. the message box should now show "600 - No matching authority found.". the 9 subfield is red Above the 9 subfield is a red X with a blue plus next to it Hover on the plus, see it is titled 'Create authority' 6 - Click the 'Create authority' link 7 - A new authroity form pops up, the info from the cataloging editor is prefilled Click the 100 field heading to expand and confirm info is transferred 8 - Fill in necessary fields and save the new authority 9 - The cataloging screen now has the 9 subfield populated and is green 10 - Click "Link authorities automatically" again Dialog says "No authority link was changed" 11 - In another tab go to System preferences and set AutoCreateAuthorities to 'Allow' 12 - Add random information to the 650 field 13 - Click 'Link authorities' button 14 - Dialog says:650 - No matching authority found. A new authority was created automatically. 15 - The subfield 9 is green and has the id of the new authority record 16 - In another tab search authorities and find an existing subject heading 17 - Add a new 650 with the info from the existing record 18 - Click 'Link authorities' 19 - The new field is correctly linked to existing authority Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar Signed-off-by: Nick Clemens Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #110558|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 110567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110567=edit Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 --- Comment #2 from Kyle M Hall --- Created attachment 110566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110566=edit Bug 26510 - Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled If HoldsQueueSkipClosed is enabled, and a library happens to be closed on the day you edit the transport cost matrix, all the values for that library will not show. Instead they will appear disabled, and if you were to edit the cell and save a new value in it, it will also 'disappear' when the page is reloaded. Test Plan: 1) Set today as a holiday for a library 2) Set HoldsQueueSkipClosed to 'open' 3) Go to the transport cost matrix editor 4) Edit a cell where the 'from' is for the closed library 5) Note the value doesn't 'save', it is still in the database though 6) Apply this patch 7) Restart all the things! 8) Reload the transport cost matrix editor 9) The value now appears correctly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 Kyle M Hall changed: What|Removed |Added Summary|Transport Cost Matrix |Transport Cost Matrix |editor doesn't show all |editor doesn't show all |data when |data when |HoldsQueueSkipClosed is |HoldsQueueSkipClosed is |enabled.|enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 --- Comment #1 from Kyle M Hall --- Screencast of bug and patch: https://www.youtube.com/watch?v=SPU9ge4l-24=youtu.be -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 Kyle M Hall changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26510] New: Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26510 Bug ID: 26510 Summary: Transport Cost Matrix editor doesn't show all data when HoldsQueueSkipClosed is enabled. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If HoldsQueueSkipClosed is enabled, and a library happens to be closed on the day you edit the transport cost matrix, all the values for that library will not show. Instead they will appear disabled, and if you were to edit the cell and save a new value in it, it will also 'disappear' when the page is reloaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | CC||agustinmoy...@theke.io -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 --- Comment #38 from Nick Clemens --- Created attachment 110565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110565=edit Bug 25265: Fix copy paste error for parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26509] Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 110564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110564=edit Bug 26509: Add Koha::Items->safe_delete This patch adds a handy method that can be used to call safe_delete on a resultset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26509] Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 110563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110563=edit Bug 26509: Add CannotBeDeleted object exception This patch adds a new exception with tests for the stringification. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26509] Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26509] Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26509] New: Add Koha::Items->safe_delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26509 Bug ID: 26509 Summary: Add Koha::Items->safe_delete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be handy to be able to safe_delete on an items result set. For example, if we wanted to cancel an order in the Koha:: namespace, we could just call $self->items->safe_delete; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What|Removed |Added Attachment #110382|0 |1 is obsolete|| --- Comment #37 from Nick Clemens --- Created attachment 110562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110562=edit Bug 25265: Rename skip_modzebra_update to skip_record_index -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What|Removed |Added Attachment #110381|0 |1 is obsolete|| --- Comment #36 from Nick Clemens --- Created attachment 110561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110561=edit Bug 25265: Prevent double reindex of the same item in batchmod When batch editing, 2 reindex calls are sent to ES/Zebra. We can easily avoid that reusing the skip_modzebra_update (renamed skip_record_index) Additionally we should only send one request for biblio, and we should only do it if we succeed As the whole batch mod is in a transaction it is possible to fail in which case Zebra queue is reset, but ES indexes have already been set In addition to the skip param this patchset moves Zebra and Elasticsearch calls to Indexer modules and introduces a generic Koha::SearchEngine::Indexer so that we don't need to check the engine when calling for index The new index_records routine takes an array so that we can reduce the calls to the ES server. The index_records routine for Zebra loops over ModZebra to avoid affecting current behaviour Test plan: General tests, under both search engines: 1 - Add a biblio and confirm it is searchable 2 - Edit the biblio and confirm changes are searchable 3 - Add an item, confirm it is searchable 4 - Delete an item, confirm it is not searchable 5 - Delete a biblio, confirm it is not searchable 6 - Add an authority and confirm it is searchable 7 - Delete an authority and confirm it is not searchable Batch mod tests, under both search engines 1 - Have a bib with several items, none marked 'not for loan' 2 - Do a staff search that returns this biblio 3 - Items show as available 4 - Click on title to go to details page 5 - Edit->Item in a batch 6 - Set the not for loan status for all items 7 - Repeat your search 8 - Items show as not for loan 9 - Test batch deleting items a - Test with a list of items, not deleting bibs b - Test with a list of items, deleting bibs if no items remain where all items are only item on a biblio: SELECT MAX(barcode) FROM items GROUP BY biblionumber HAVING COUNT(barcode) IN (1) c - Test with a list of items, deleting bibs if no items remain where some items are the only item on a biblio: SELECT MAX(barcode) FROM items GROUP BY biblionumber HAVING COUNT(barcode) IN (1,2) 10 - Confirm records are update/deleted as appropriate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What|Removed |Added Attachment #110380|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 110560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110560=edit Bug 25265: Unit tests These cover Koha::SearchEngine::Indexer and ensure that all calls in the code are routed correctly to the expected search engine Bug 25265: (follow-up) Skip tests if elastic not configured -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25596] "Overpayment refund" is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #5 from Martin Renvoize --- Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the issue date early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the overdues script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26418] The "description" for REFUND accountlines is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 Owen Leonard changed: What|Removed |Added Attachment #109820|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 110559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110559=edit Bug 26418: Fix translatability of REFUND credit type Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26418] The "description" for REFUND accountlines is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 --- Comment #1 from Nick Clemens --- Created attachment 110558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110558=edit Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26508] "sn:" shortcut to search by biblionumber is too broad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26508 --- Comment #1 from Andrew Fuerste-Henry --- If I change SearchEngine back to Zebra, with QueryAutoTruncate set to "automatically," it somehow knows not to truncate this search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26508] New: "sn:" shortcut to search by biblionumber is too broad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26508
Bug ID: 26508
Summary: "sn:" shortcut to search by biblionumber is too broad
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: and...@bywatersolutions.com
Searching for "sn:1" seems to be returning every bib with a 1 in its bib
number. "sn:100" only returns bib 100.
Turned on DumpSearchQueryTemplate and pulled this from the source when
searching "sn:1":
'query' => '(local-number:1*)',
'default_operator' => 'AND',
'lenient' =>
$VAR1->{'search_query'}{'query'}{'query_string'}{'analyze_wildcard'}
}
},
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||26507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 [Bug 26507] New items not indexed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||25265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26507] New: New items not indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26507 Bug ID: 26507 Summary: New items not indexed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com When adding a new item under ES, that item is not automatically indexed. It is indexed if subsequently edited and saved. To recreate: - find/create a bib with no items - add an item with barcode "abc123" - do a general keyword search for "abc123," see your bib is not in the results - perform a search that includes your bib in the results, confirm it shows as having no items - click through to bib details, confirm it shows your item here - edit and save your item - confirm barcode is now searchable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #147 from Nick Clemens --- Created attachment 110557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110557=edit Bug 11299: (follow-up) correct link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What|Removed |Added Attachment #108835|0 |1 is obsolete|| --- Comment #144 from Nick Clemens --- Created attachment 110554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110554=edit Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update Removed my from variables in test Undid stray line deletions Undid adding 1; to test file Fix CSS replace command Update license Fix spelling Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What|Removed |Added Attachment #109062|0 |1 is obsolete|| --- Comment #145 from Nick Clemens --- Created attachment 110555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110555=edit Bug 11299: (follow-up) Correct rebase errors and add message class to dialog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What|Removed |Added Attachment #109181|0 |1 is obsolete|| --- Comment #146 from Nick Clemens --- Created attachment 110556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110556=edit Bug 11299: (follow-up) Skip fields with no 9 subfields To test: 1 - Disable the 'thesaurus' for a controlled field like 600a or 650a 2 - Edit a record and put random data in this field 3 - Try to link, get a JS error 4 - Apply patch 5 - Repeat 6 - No more error, field is not linked (as it has no $9 subfield) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What|Removed |Added Attachment #108834|0 |1 is obsolete|| --- Comment #143 from Nick Clemens --- Created attachment 110553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110553=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : 1 - In your system preferences set: AutoCreateAuthorities: don't generate BiblioAddsAuthorities: don't allow 2 - Go to the Cataloging -> New record (koha/cataloguing/addbiblio.pl) Ensure you are using the basic editor 3 - Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." 4 - Add random informations in field 600$a of the biblio record. 5 - Click the "Link authorities automatically" button. the message box should now show "600 - No matching authority found.". the 9 subfield is red Above the 9 subfield is a red X with a blue plus next to it Hover on the plus, see it is titled 'Create authority' 6 - Click the 'Create authority' link 7 - A new authroity form pops up, the info from the cataloging editor is prefilled Click the 100 field heading to expand and confirm info is transferred 8 - Fill in necessary fields and save the new authority 9 - The cataloging screen now has the 9 subfield populated and is green 10 - Click "Link authorities automatically" again Dialog says "No authority link was changed" 11 - In another tab go to System preferences and set AutoCreateAuthorities to 'Allow' 12 - Add random information to the 650 field 13 - Click 'Link authorities' button 14 - Dialog says:650 - No matching authority found. A new authority was created automatically. 15 - The subfield 9 is green and has the id of the new authority record 16 - In another tab search authorities and find an existing subject heading 17 - Add a new 650 with the info from the existing record 18 - Click 'Link authorities' 19 - The new field is correctly linked to existing authority Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #49 from Alexis Ripetti --- (In reply to Arthur Suzuki from comment #48) > Test patch works as expected (there is one test which doesn't pass when test > patch is applied alone). > However the test patch seems to change things in C4/Circulation as well, > is this due to a change in the db structure, > and shouldn't this change be in the main patch anyway? > Other than this comment, happy to signoff :) The change in the C4/Circulation.pm file should have been applied on the main patch. You previously said that a test should fail when patches are applied. But which test does fail for you and which one is supposed to fail? Because when I apply both patches every tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 --- Comment #1 from Matthias Meusburger --- Created attachment 110552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110552=edit Bug 26506: Fix Koha::Account::pay if called when no user is logged-in Currently, Koha::Account::pay will fail if no user is logged-in when it is called. In this case, this patch will use undef instead of 0 for $manager_id in order to comply with the foreign key constraint on manager_id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25596] "Overpayment refund" is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize changed: What|Removed |Added Attachment #109818|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 110551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110551=edit Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26506] New: Koha::Account::pay will fail if $userenv is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506
Bug ID: 26506
Summary: Koha::Account::pay will fail if $userenv is not set
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Fines and fees
Assignee: koha-bugs@lists.koha-community.org
Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
Koha::Account::pay will fail if $userenv is not set.
The context would be a payment plugin for the opac, in which the payment system
will call a callback URL to confirm the payment has been made. In this
situation, no user is logged in when the plugin uses Koha::Account::pay.
The problem is that the following line in Koha::Account::pay:
my $manager_id = $userenv ? $userenv->{number} : 0;
will result in an SQL error, since $userenv->{number} is not set, and 0 is not
an acceptable value because of foreign key constraint:
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_hkr`.`accountlines`, CONSTRAINT
`accountlines_ibfk_borrowers_2` FOREIGN KEY (`manager_id`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE)
By the way, if you have a look at C4/Accounts.pm, in the manualinvoice
function:
my $manager_id = C4::Context->userenv ? C4::Context->userenv->{'number'} :
undef;
$manager_id will be set to undef, which will not fail, since undef is an
acceptable value regarding to SQL foreign key constraints.
It's hard to provide a test plan, since it relies on a plugin, sorry, but I
will try to answer to any question :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 David Nind changed: What|Removed |Added Attachment #110521|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 110549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110549=edit Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 David Nind changed: What|Removed |Added Attachment #110522|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110550=edit Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Katrin Fischer changed: What|Removed |Added Summary|Allow to limit on standing |Allow to limit on standing |orders in acqisition|orders in acquisition |advanced search |advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23828] Elasticsearch - ES - Authority record results not ordered correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #110176|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 110548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110548=edit Bug 23828: Elasticsearch - Preserve record order when combining subfield in mappings Currently if you combine subfields in the marc mappings the subfields are indexed in the order listed in the mapping. i.e. 650(avxyz) in mapping and in record: 650 $aHeading $zGeosubdiv $vFormsubdiv is indexed as: Heading Formsubdiv Geosubdiv We should preserve the order and index as: Heading Geosubdiv Formsubdiv We can use built in function in Marc::Field to achieve this To test: 1 - It is easy to find examples of this using authorities 2 - Find or create a record with subfields order azv e.g. 150$aActresses$zUnited states$vBiography 3 - Add or have a second authority e.g. 150$aActresses$vPortraits 4 - Set an authorities mapping for 'Heading' to 150(abgvxyz) find at: Administration->Search engine configuration (Elasticsearch)->Authorities tab 5 - Index the records in Elasticsearch perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1691 -ai 1692 6 - View the first record in the ES index curl es:9200/koha_kohadev_authorities/data/1692?pretty 7 - Note 'Heading' field is ordered as in the mapping 8 - Search authorities for 'contains' "act" 9 - Note the records sort incorrectly 10 - Apply patches 11 - perl misc/search_tools/rebuild_elaticsearch.pl -a -ai 1692 12 - curl es:9200/koha_kohadev_authorities/data/1692?pretty 13 - Note the order is now preserved 14 - Search authorities for 'contains' "act" 15 - Note the records sort correctly Signed-off-by: Heather Hernandez -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23828] Elasticsearch - ES - Authority record results not ordered correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23828] Elasticsearch - ES - Authority record results not ordered correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #110175|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 110547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110547=edit Bug 23828: Unit tests Signed-off-by: Heather Hernandez -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26490] Column configuration for account-fines hides the wrong columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 David Nind changed: What|Removed |Added Attachment #110440|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110546=edit Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option https://bugs.koha-community.org/show_bug.cgi?id=26490 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26490] Column configuration for account-fines hides the wrong columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize changed: What|Removed |Added Depends on||24446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks||4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26057] Transfers should record if they have been cancelled/overridden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com ||, n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26057] Transfers should record if they have been cancelled/overridden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110285|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 110544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110544=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110286|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 110545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110545=edit Bug 22569: Refine GetTransfersFromTo to filter out unsent transfers GetTransfersFromTo is used solely by the transferstorecieve page which assumes items have already been sent. With the introduction of daterequested we allow for a state where a transfer has been scheduled but not yet sent (See stockrotation for such a case) and so we need to filter these transfers out from the transferstorecieve report. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110284|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 110543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110543=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110534|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 110539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110539=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110537|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 110542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110542=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110535|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 110540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110540=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110536|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 110541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110541=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110533|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 110538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110538=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #31 from Martin Renvoize --- Leaving as FQA.. just thought of some more tests I aught to add with that final followup :| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #30 from Martin Renvoize --- Created attachment 110537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110537=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110281|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 110534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110534=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110283|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 110536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110536=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110280|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 110533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110533=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110282|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 110535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110535=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501
--- Comment #5 from Marcel de Rooy ---
-active_table.row( a.closest('tr') ).remove().draw();
+active_datatable.row( a.closest('tr') ).remove().draw();
Typo.
I used Process and Cancel to test. Probably skipped Complete completely ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501 Marcel de Rooy changed: What|Removed |Added Attachment #110470|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 110532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110532=edit Bug 26501: Add datatables to article-requests form Actually two tables: one for pending and processing. Variable active_table has been renamed to active_tab. To prevent a flickering form we hide stuff until ready. Test plan: [1] Submit a few article requests. [2] Verify that Process, Complete and Cancel still work via Actions. [3] Test again with multiselect and top Actions menu. [4] Test Search and Sort on the datatable. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26501] Article requests: Add datatables to requests form in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26501 --- Comment #3 from Marcel de Rooy --- (In reply to Owen Leonard from comment #2) > In my test the "Complete request" menu item trips a JavaScript error under > both the "Pending" and "Processing" tabs: "Uncaught ReferenceError: > active_table is not defined" Have tested quite a bit but also with different versions. So i will retest right away. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26505] New: Suspend hold modal broken in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26505 Bug ID: 26505 Summary: Suspend hold modal broken in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 20168 The suspend hold modal was broken by the Bootstrap 4 upgrade. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Owen Leonard changed: What|Removed |Added Blocks||26505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26505 [Bug 26505] Suspend hold modal broken in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #110403|0 |1 is obsolete|| --- Comment #38 from PTFS Europe Sandboxes --- Created attachment 110529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110529=edit Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Alexandra Speer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #110516|0 |1 is obsolete|| --- Comment #40 from PTFS Europe Sandboxes --- Created attachment 110531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110531=edit Bug 12224: (follow-up) Access old_issues table when editing notice This QA follow-up allows access to the old_issues table when editing the notice in Tools. Signed-off-by: Alexandra Speer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #110404|0 |1 is obsolete|| --- Comment #39 from PTFS Europe Sandboxes --- Created attachment 110530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110530=edit Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. Signed-off-by: David Nind Signed-off-by: Alexandra Speer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #25 from Martin Renvoize --- Oops, I forgot to mark this as assigned.. I found a couple fo bugs whilst sorting out some of the tree last week.. working on them at the moment.. thanks for testing Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on the detail page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223 --- Comment #4 from Katrin Fischer --- Thx, David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
