[Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 George Williams (NEKLS) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 ByWater Sandboxes changed: What|Removed |Added Attachment #111316|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 111676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111676=edit Bug 23979: MOve locked message to patron info section To test: 1 - Set failed login attempts to some number 2 - Attempt enough logins with a patront o lock them, or: UPDATE borrowers SET login_attempts = 500 WHERE borrowernumber=5; 3 - Attempt to checkout to borrower, no notice of lock 4 - View patron details tab, see the locked message 5 - Apply patch 6 - Note the message is now in patron info and visible on all tabs for the member Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #1 from David Cook --- Created attachment 111675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111675=edit Bug 26685: Move starman out of debian/control.in and into cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] New: Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Bug ID: 26685 Summary: Move Starman out of debian/control.in and into cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com If we put Starman in to cpanfile, it will help people using cpanfile without the Debian packages, and it should mean that the dependency is automatically added to debian/control. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 --- Comment #6 from David Cook --- Created attachment 111674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111674=edit Bug 26672: Make koha-core not rely on koha-common and have koha-full rely on koha-core -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 --- Comment #5 from David Cook --- Actually, maybe koha-core shouldn't be a metapackage for koha-common after all... We can do better than that... This is an opportunity to really decide on what is "core"... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 --- Comment #4 from David Cook --- Technically, we should move "memcached" from koha-common to koha-full, but I imagine that would take a lot of people by surprise... "koha" should also depend on "koha-full" instead of "koha-common"... While "idzebra-2.0" includes the Zebra server (zebrasrv), it also includes the Zebra zebraidx tool, which we need on the same server as Koha. Depending on the future of Zebra in Koha, we could have a koha-zebra package. I suppose the depth that we take this really depends on how comfortable people are with change... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #3 from David Cook --- So far I've only included MySQL/MariaDB server and RabbitMQ, since there isn't an out-of-the-box installation option for Elasticsearch (https://wiki.koha-community.org/wiki/Koha_on_Debian#Elasticsearch). Perhaps we should also include a patch here to remove rabbitmq-server from koha-common as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 --- Comment #2 from David Cook --- Created attachment 111673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111673=edit Bug 26672: Add koha-core and koha-full metapackages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 --- Comment #1 from David Cook --- There was limited feedback on the listserv, but it seems like people are OK with creating a "koha-core" metapackage (requiring koha-common) and a "koha-full" metapackage (requiring koha-common, mariadb-server, elasticsearch, RabbitMQ, etc). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #4 from David Cook --- Created attachment 111672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111672=edit Bug 26684: [Do not push] Remember to update Koha::Schema::Result::AuthHeader -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #3 from David Cook --- Created attachment 111671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111671=edit Bug 26684: Remove marc column from existing databases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #2 from David Cook --- Created attachment 111670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111670=edit Bug 26684: Remove marc from auth_header for new installs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 --- Comment #1 from David Cook --- Actually, we'll also need to re-generate Koha/Schema/Result/AuthHeader.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26683 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26673 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #11 from David Cook --- Ok I've opened Bug 26683 to deal with the Perl critic issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #6 from David Cook --- Koha::Z3950Responder::RPN test plan: 0. Open 2 terminals Terminal 1: 1. koha-z3950-responder --stop kohadev 2. perl misc/z3950_responder.pl Terminal 2: 3. yaz-client 127.0.0.1:2100/biblios 4. #Note connection accepted 5. find @or @1=4 Bruce @1=4 Damian 6. #Note Number of hits: 9 7. #Iterate through results using "show" and notice the 245 has either Bruce or Damian in it Note that this just makes sure the koha-z3950-responder is still running. It doesn't actually test that the Net::Z3950::RPN::* modules are actually doing anything it seems. Ere Maijala might be the best person to verify this, since he's the one who added Koha::Z3950Responder::RPN in Bug 13937 for "Add support for SRU and Elasticsearch" Before I added the 3rd patch "Load localized Net::Z3950::RPN::* modules", the t/db_dependent/Koha/Z3950Responder/GenericSession.t test was failing, but now it's passing. -- (It's a shame we don't have a "lib" directory that contains all our Perl modules, but that would require renaming too many files, so I don't see that ever happening...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #5 from David Cook --- Created attachment 111669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111669=edit Bug 26683: Load localized Net::Z3950::RPN::* modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #35 from Katrin Fischer --- The new tests pass, but the QA script fails: FAIL t/db_dependent/Koha/Cash/Register/Action.t OK critic FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 197) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 207) Can you assure me you know what you are doing or make it go away? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer changed: What|Removed |Added Attachment #111634|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 111668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111668=edit Bug 26172: (QA follow-up) Add Unit Test Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #4 from David Cook --- C4::Barcodes::ValueBuilder test plan: 1. Iterate through the "autoBarcode" options 2. For each autoBarcode option, try generating a barcode at http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=29=scs_1602720764348 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #3 from David Cook --- Created attachment 111667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111667=edit Bug 26683: Decompose Koha::Z3950Responder::RPN into Net::Z3950::RPN::* packages This patch reverts the usage of Net::Z3950::SimpleServer's samples/render-search.pl example, and instead creates modified packages which will be loaded before the standard ones due to these being located higher up in the @INC path. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] New: Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 Bug ID: 26684 Summary: Remove 'marc' column from auth_header table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org There's no need to have a marc column in the auth_header table anymore. We'll need to change at least the following files: ./installer/data/mysql/kohastructure.sql ./C4/AuthoritiesMarc.pm (AddAuthority, ) t/db_dependent/Linker_FirstMatch.t We'll also need to drop the column using updatedatabase.pl: ./installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What|Removed |Added Attachment #111657|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 111666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111666=edit Bug 26683: Decompose C4::Barcodes::ValueBuilder to make Perl critic happy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 Katrin Fischer changed: What|Removed |Added Attachment #111636|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 111665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111665=edit Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js This patch moves strings defined for translation in js_includes.inc into basket.js for translation using the new double-underscore i81n function. To test, apply the patch and perform a catalog search in the staff client. - Click the Cart link in the header menu. A pop-up should appear saying "Your cart is currently empty." - On the search results page, click the "Add to cart" link next to any search result. The text should change to "In your cart." - Click the "Remove" link. The text should change to "Add to cart." - Check the box next to a title in the search results and click the "Add to cart" button in the search results toolbar. A message should appear, "1 item(s) added to your cart." - Click the "Add to cart" button again. You should see the message "No item was added to your cart (already in your cart)!" - Uncheck all check boxes on the search results page and click "Add to cart." You should see "No item was selected." - Add more items to your cart so that it contains more than one item. - Click the "Cart" link to open it. - Click the "Empty and close" button. You should be asked to confirm, "Are you sure you want to empty your cart?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/basket.js for translation, e.g.: msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26572] Add autocomplete to librarian field in log viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26572 Katrin Fischer changed: What|Removed |Added Attachment #111637|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 111664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111664=edit Bug 26572: Add autocomplete to librarian field in log viewer This patch adds patron autocomplete to the librarian field in the log viewer search form. Also changed: Some HTML markup errors in the template have been corrected: Labels with invalid corresponding ids or with no valid id. To test, apply the patch and go to Tools -> Log Viewer. Type a name or cardnumber into the "Librarian" form field. This should trigger an autocomplete dropdown. Select a patron and confirm that the field is populated with the correct borrowernumber. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26572] Add autocomplete to librarian field in log viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26572 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26615] Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26615 --- Comment #2 from Katrin Fischer --- Hi Muhammad, is it possible you changed the setting of the timeout preference? If set to an invalid value, this could explain your immediate session timeouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26616] Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26616 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 26615 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26615] Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26615 --- Comment #1 from Katrin Fischer --- *** Bug 26616 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Katrin Fischer changed: What|Removed |Added Attachment #111333|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 111663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111663=edit Bug 26621: Adjust docs/contributors.yaml accordingly Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 --- Comment #11 from Katrin Fischer --- The file might still be a bit messy, but this reads as a nice improvement overall. Small steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Katrin Fischer changed: What|Removed |Added Attachment #111332|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 111662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111662=edit Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26617] Add koha-testing-docker to INSTALL file and correct URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26617 --- Comment #4 from Katrin Fischer --- Always love to see documentation fixes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26617] Add koha-testing-docker to INSTALL file and correct URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26617 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26617] Add koha-testing-docker to INSTALL file and correct URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26617 Katrin Fischer changed: What|Removed |Added Attachment #111311|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 111661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111661=edit Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links Test plan: 1. View the INSTALL file in a text editor 2. The INSTALL file should reference koha-testing-docker and KohaDevBox using Gitlab links Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Katrin Fischer changed: What|Removed |Added Attachment #111270|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 111660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111660=edit Bug 25636: Assignment fix Whilst working on this bug I found a weird inconsistent variable assignment line https://bugs.koha-community.org/show_bug.cgi?id=26536 Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Katrin Fischer changed: What|Removed |Added Attachment #111269|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 111659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111659=edit Bug 26536: WRITEOFF not writeoff There is inconsistency in variable case between the controller script and the template. This patch corrects those inconsistencies. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Katrin Fischer changed: What|Removed |Added Attachment #111268|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 111658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111658=edit Bug 26536: Fix incorrectly scoped variable During work on bug 26076 a variable scope mistake was made when reverting the logic to use distinct queries for selected accountlines. This patch restores the script scope of the varaible by removing the superflous 'my' declaration. Test plan 1/ Add a set of manual invoices 2/ Select a subset of those manual invoices to 'Writeoff selected' 3/ Confirm that only those selected invoices have been written off. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 --- Comment #1 from David Cook --- Created attachment 111657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111657=edit Bug 26683: Decompose C4::Barcodes::ValueBuilder to make Perl critic happy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org --- Comment #10 from David Cook --- (In reply to David Cook from comment #9) > I'll open a new bug report for those though. In theory, > C4/Barcodes/ValueBuilder.pm and Koha/Z3950Responder/RPN.pm would just become > packages that "use" the subpackages that can be split off into their own > files. (I'll take a look if there are any other packages that are guilty of > the same Perl critic violation...) Ok C4/Barcodes/ValueBuilder.pm was easy, but I just realized Koha/Z3950Responder/RPN.pm overrides a non-C4/non-Koha namespace. Blah. This is where our terrible codetree layout comes to bite us heh. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26657] "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26657 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26522] Elasticsearch - don't attempt to index record if it cannot be retrieved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26522 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26683] New: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 Bug ID: 26683 Summary: Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Both ./C4/Barcodes/ValueBuilder.pm and ./Koha/Z3950Responder/RPN.pm violate the Perl Critic policy of Modules::RequireFilenameMatchesPackage. You can read more about it at https://metacpan.org/pod/Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage The failures look like this: FAIL C4/Barcodes/ValueBuilder.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). FAIL Koha/Z3950Responder/RPN.pm FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #18 from Katrin Fischer --- I am sorry, but this currently no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24603: Allow to cancel charges in patron accounting Applying: Bug 24603: (follow-up) Update to double entry accounting error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). error: could not build fake ancestor Patch failed at 0001 Bug 24603: (follow-up) Update to double entry accounting The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24603-follow-up-Update-to-double-entry-account-FBn5S8.patch I'd also love an explanation on how void, cancel and other options differ! (little confused there) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #9 from David Cook --- (In reply to Joonas Kylmälä from comment #3) > Not caused by this change though, maybe you want to file separate bug for > this and the same issue with Koha/Z3950Responder/RPN.pm, and actually not > totally sure these are bugs. Yeah, I don't think we should fail this bug for those Perl critic failures. I'll open a new bug report for those though. In theory, C4/Barcodes/ValueBuilder.pm and Koha/Z3950Responder/RPN.pm would just become packages that "use" the subpackages that can be split off into their own files. (I'll take a look if there are any other packages that are guilty of the same Perl critic violation...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 David Cook changed: What|Removed |Added Attachment #111584|0 |1 is obsolete|| --- Comment #6 from David Cook --- Created attachment 111655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111655=edit Bug 26673: Remove shebangs from Perl modules It's not needed. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from David Cook --- (In reply to Joonas Kylmälä from comment #5) > This patch missed one instance where the shebang is not needed: > C4/TTParser.pm Nice catch. I've added a patch for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #7 from David Cook --- Created attachment 111656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111656=edit Bug 26673: Remove #!/usr/bin/env perl from .pm modules too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #87 from Katrin Fischer --- I am really sorry, but patches no longer apply again :( I fixed the first conflict in the messaging templates that was caused by my own change (so easy) but then got stuck on another conflict in IllRequest.pm that is more complicated. I promise to test this or next week if rebased. Note: While fixing the conflict in messaging preferences I noticed that the new options will always show, I think we should add a check on ILLModule pref so prevent it showing for libraries that don't use the ILL module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Allow using item information in OAI set mappings and automatically update sets when items are added, edited or deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #25 from Alex Buckley --- Hi Katrin, Thank you for clarifying that. I agree with your changes. This patchset ensures OAI sets are altered when items are added/altered (if 952 subfields are defined in the OAI set mappings). But as you say, it doesn't mean item data will automatically be embedded in the OAI sets output. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #69 from Katrin Fischer --- Hi Josef, I see you are QA contact on this one, will you be able to finish here or should we reassign? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Ok, I have a bit of bad news here too - with the patch set it's no longer possible to print unpadded barcodes as it requires the barcodes entered to be of the same length. Example: from 1 to 33 will no longer print. I am not sure what the best fix here would be - maybe check for the numbers to start with zero and only output the hint if they do? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer changed: What|Removed |Added Attachment #90|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #6 from Katrin Fischer --- Created attachment 111654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111654=edit Bug 26340: (QA follow-up) Rephrase hint on to and from values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer changed: What|Removed |Added Summary|Printing labels without |When printing labels from a |zero(s) in the start of |barcode range, keep zero |labels |padding -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #5 from Katrin Fischer --- Created attachment 111653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111653=edit Bug 26340: Keep zero padding when printing barcodes from a range When creating barcode labels from a range, the leading zeros of padded barcodes will be removed. They should be kept instead. TO TEST: 1. Go to Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. 7. Apply patch and retest - the zeros should be kept now. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #4 from Katrin Fischer --- Hi Ivan, I think this might be your first patch for Koha, so some hints about bugzilla and our tools: 1) Please make sure you set yourself as "Assignee" once you plan on submitting a patch to a bug. 2) When using git bz -e or git bz edit it might seem like you can edit the commit message, but while this will post here, it's not changing the patch file. In order to include the test plan and patch description in your patch, you will have to do so in the git commit step. I will upload an updated patch and have already updated bugzilla :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |ivan.dzi...@inlibro.com |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon to help identify staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Summary|Add Font Awesome icon only |Add Font Awesome icon to |for staff patrons |help identify staff patrons --- Comment #37 from Katrin Fischer --- I really like this and think it would be nice in other spots like the patron search as well. But this is a solid start. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Attachment #87|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 111650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111650=edit Bug 26534: (follow-up) Only center when using patronimages I felt the change to always center the user title worked well when patronimages was enabled, but not so well when it was not (it looked strange without a background for non-staff users). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Attachment #89|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 111652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111652=edit Bug 26534: Use IF ELSE directly on h5 opening tag Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Attachment #86|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 111649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111649=edit Bug 26534: (QA follow-up) Fix CSS declaration Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Attachment #88|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 111651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111651=edit Bug 26534: Replace 'grade' by 'is-patron' and 'patron-type' Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Attachment #85|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 111648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111648=edit Bug 26534: Add Font Awesome icon only for staff patrons In patron pages it would help to see an icon indicating that this is a staff patron (having permission to access staff interface). This may avoid wrong patron deletion or permission mistakes. I propose the shield Font Awesome icon and a grey background Patch also shows patron name and cardnumber aligned center instead of right. Patch adds to 'patroninfo' div a class 'staffgrade' or 'normalgrade' to allow more styling depending on patron beeing staff or not. Test plan: Compare display between a patron having staff interface access and one without permissions. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add Font Awesome icon only for staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Allow using item information in OAI set mappings and automatically update sets when items are added, edited or deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #24 from Katrin Fischer --- Created attachment 111647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111647=edit Bug 25460: (QA follow-up) Remove stray quote from system preference descrpition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Allow using item information in OAI set mappings and automatically update sets when items are added, edited or deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Katrin Fischer changed: What|Removed |Added Summary|Update OAI set (and |Allow using item |optionally embed item |information in OAI set |information) when |mappings and automatically |adding/editing/deleting |update sets when items are |items |added, edited or deleted Text to go in the|Update OAI sets when item |This allows library staff release notes|records are created or |to use information from |updated. |items when creating | |mappings for OAI sets. When |Allow library |the new system preference |staff to embed item record |OAI-PMH:AutoUpdateSetsEmbed |data when creating or |ItemData is set, editing, |updating records so that|deleting or adding items |OAI set mappings of 952 |will update records listed |MARC subfields are |in the OAI sets according |respected. |to the mapppings. --- Comment #23 from Katrin Fischer --- I wonder if the bug description might be a little misleading. This makes it possible to use 952 in your OAI set mappings and it makes the updates of the OAI sets happen nicely when items are changed/added/updated. But what it not does is embedding item information in the output formats - you still have to set the conf file and flag for marcxml in order to make that happen. So I am changing the title slightly, let me know if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #22 from Alex Buckley --- Thank you David and Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #21 from Katrin Fischer --- Created attachment 111646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111646=edit Bug 25460: (QA follow-up) Readd ending punctuation to sys pref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #20 from Katrin Fischer --- Created attachment 111645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111645=edit Bug 25460: Add unit test for change to C4::OAI::Sets->UpdateOAISetsBiblio() Test plan: 1. Run unit test: sudo koha-shell prove t/db_dependent/OAI/Sets.t 2. All tests should pass Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Katrin Fischer changed: What|Removed |Added Attachment #111085|0 |1 is obsolete|| Attachment #111086|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 111644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111644=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Also adds syspref to optionally choose to embed item information in record when adding/editing bibliographic and item records. Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [ITEM EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ITEM ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [ITEM DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ITEM ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [ITEM EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [ITEM EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [ITEM DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #28 from Katrin Fischer --- Currently blocked by dependent bug 23971 being Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #38 from Katrin Fischer --- (In reply to Jonathan Druart from comment #28) > Some comments from bug 24190 comment 14 (&15) apply here. > > Additionally I don't think it's a good idea to pass the flag to CloseBasket. > > 577 # Close the basket, passing a flag indicating that this > action > 578 # originated from an approval > 579 CloseBasket($b, 1); > > Cannot we imagine that Koha::EDI deals with this specific situation? (UPDATE > the action_log with the desire action) Hi Andrew, could you answer the question above about EDI please? Then should this be reset to Signed off or NSO? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 --- Comment #70 from Katrin Fischer --- I am passing QA here, but there are some caveats: 1) This adds a dependency on Locale::XGettext::TT2 that currently has no packages for Debian. 2) The second part that deals with the translations of system preferences on bug 26547 is not ready yet. I believe both patches should only be pushed together. I hope that moving this a step further will be a little push for things to be finished. The other option would be moving it into BLOCKED (leaving that to RM) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 --- Comment #69 from Katrin Fischer --- Created attachment 111643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111643=edit Bug 25067: (QA follow-up) Add +x on test files Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Katrin Fischer changed: What|Removed |Added Attachment #110776|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 111642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111642=edit Bug 25067: Move PO file manipulation code into gulp tasks misc/translator/translate was doing three different things: - extract translatable strings - create or update PO files - install translated templates This patch separates responsibilities by moving the string extraction code into several 'xgettext-like' scripts and adds gulp tasks to automate string extraction and PO files update This has several benefits: - gulp runs tasks in parallel, so it's a lot faster (updating all PO files is at least 10 times faster with my 4-cores CPU) - there is no need for $KOHA_CONF to be defined LangInstaller.pm relied on $KOHA_CONF to get the different paths needed. I'm not sure why, since string extraction and PO update should work on source files, not installed files - string extraction code can be more easily tested This patch also brings a couple of fixes and improvements: - TT string extraction (strings wrapped in [% t(...) %]) was done with Template::Parser and PPI, which was extremely slow, and had some problems (see bug 24797). This is now done with Locale::XGettext::TT2 (new dependency) which is a lot faster, and fixes bug 24797 - Fix header in 4 PO files For backward compatibility, 'create' and 'update' commands of misc/translator/translate can still be used and will execute the corresponding gulp task Test plan: 1. Run `yarn install` and install Locale::XGettext::TT2 2. Run `gulp po:update` 3. Verify the contents of updated PO files 4. Run `cd misc/translator && ./translate install ` 5. Verify that all (templates, sysprefs, xslt, installer files) is correctly translated 6. Run `gulp po:create --lang ` and verify that it created all PO files for that language 7. Run `prove t/misc/translator` Signed-off-by: Bernardo Gonzalez Kriegel Need to install yarn & gulp, no errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26547] Move context from msgid to msgctxt in pref PO files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26547 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I feel this needs more work. I tested together with bug 25067 and for de-DE ALL translations are marked fuzzy now. This would require translators in Pootle to update every and each of them. We need to see how we can avoid this. Poedit shows: Translated 0 of 2582 (0%) - Remaining 2582 But the weird thing is: The fuzzy strings are still used in the translations so my system preference editor shows up in German. Often times fuzzy strings can break the translation process/templates, so they should be ignored/fallback to English. I am in a bit of trouble here - I think we need both, bug 25067 and this one to move forward. I'll put this in FQA and put my SO stamps on the other with a note. We also need to take care of the unpackaged dependency on the other bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Nind from comment #4) > Hi Tomás. > > After applying the patch I get these errors: Thanks for testing it! I've already submitted a fixed version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25134] Return claims column should not be shown if ClaimReturnedLostValue is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #6 from Andrew Fuerste-Henry --- But, following Barbara's comment, it might not be unreasonable to only show the Claims Returned controls if the syspref contains a *valid* lost value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106835|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
